| *** schmots has quit IRC | 00:05 | |
| *** caowei has joined #openstack-manila | 01:01 | |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for service and quota resource [5/10] https://review.openstack.org/522909 | 01:13 |
|---|---|---|
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for group resource [6/10] https://review.openstack.org/523318 | 01:33 |
| zhongjun | tbarron bswartz gouthamr: This is ready for review for policy in code feature :) https://review.openstack.org/#/q/project:openstack/manila++topic:policy-and-docs-in-code+(status:open+OR+status:merged) thanks in advance | 01:35 |
| openstackgerrit | Merged openstack/puppet-manila master: Prepare for Queens Milestone 2 https://review.openstack.org/523582 | 01:59 |
| openstackgerrit | zhongshengping proposed openstack/puppet-manila master: Deprecate os_region_name option https://review.openstack.org/523291 | 02:15 |
| *** junboli has joined #openstack-manila | 02:20 | |
| *** raissa has quit IRC | 02:58 | |
| *** threestrands has joined #openstack-manila | 03:05 | |
| *** jiaopengju_ has joined #openstack-manila | 03:21 | |
| *** jiaopengju_ has left #openstack-manila | 03:23 | |
| *** jiaopengju has joined #openstack-manila | 03:24 | |
| gouthamr | zhongjun: late ack, have that in my backlog - will review | 03:30 |
| *** caowei has quit IRC | 03:40 | |
| *** caowei has joined #openstack-manila | 03:41 | |
| zhongjun | gouthamr: thanks :) | 03:43 |
| *** threestrands has quit IRC | 04:29 | |
| *** threestrands has joined #openstack-manila | 04:41 | |
| *** threestrands has quit IRC | 04:41 | |
| *** threestrands has joined #openstack-manila | 04:41 | |
| *** gouthamr has quit IRC | 04:43 | |
| *** eharney has quit IRC | 05:00 | |
| *** caowei has quit IRC | 05:04 | |
| *** sticker has quit IRC | 05:08 | |
| *** caowei has joined #openstack-manila | 05:25 | |
| *** threestrands has quit IRC | 05:32 | |
| *** gouthamr has joined #openstack-manila | 05:46 | |
| *** gouthamr has quit IRC | 06:04 | |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for replica and network resource [7/10] https://review.openstack.org/523696 | 06:17 |
| openstackgerrit | Chris Yang proposed openstack/manila master: QNAP: Add support for QES 1.1.4 https://review.openstack.org/523017 | 06:18 |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for replica and network resource [7/10] https://review.openstack.org/523696 | 06:18 |
| *** lpetrut has joined #openstack-manila | 06:38 | |
| *** junboli has quit IRC | 07:15 | |
| *** dsariel has joined #openstack-manila | 07:26 | |
| *** lpetrut has quit IRC | 07:37 | |
| *** AlexeyAbashkin has joined #openstack-manila | 07:47 | |
| *** lpetrut has joined #openstack-manila | 07:53 | |
| *** Manor has joined #openstack-manila | 07:53 | |
| *** lpetrut has quit IRC | 07:54 | |
| *** Manor has quit IRC | 07:56 | |
| *** Manor has joined #openstack-manila | 07:56 | |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for replica and network resource [7/10] https://review.openstack.org/523696 | 07:59 |
| *** Manor_ has joined #openstack-manila | 08:02 | |
| *** pcaruana has joined #openstack-manila | 08:04 | |
| *** Manor has quit IRC | 08:05 | |
| *** Manor_ has quit IRC | 08:55 | |
| *** Manor has joined #openstack-manila | 08:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila master: Updated from global requirements https://review.openstack.org/523742 | 09:00 |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for share and type extra resource [8/10] https://review.openstack.org/523770 | 09:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/523794 | 09:18 |
| *** Manor_ has joined #openstack-manila | 09:29 | |
| *** Manor has quit IRC | 09:31 | |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for AZ, scheduler and message resource [9/10] https://review.openstack.org/523819 | 09:35 |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for AZ, scheduler and message resource [9/10] https://review.openstack.org/523819 | 09:37 |
| openstackgerrit | zhongjun proposed openstack/manila master: [policy in code] Add support for AZ, scheduler and message resource [9/10] https://review.openstack.org/523819 | 09:38 |
| *** caowei has quit IRC | 09:38 | |
| *** gcb has joined #openstack-manila | 09:39 | |
| *** a-pugachev has joined #openstack-manila | 09:46 | |
| *** caowei has joined #openstack-manila | 09:50 | |
| *** ganso has joined #openstack-manila | 09:51 | |
| *** Manor_ has quit IRC | 10:05 | |
| *** a-pugachev has quit IRC | 10:11 | |
| openstackgerrit | Chris Yang proposed openstack/manila master: QNAP: Add support for QES 1.1.4 https://review.openstack.org/523017 | 10:13 |
| *** a-pugachev has joined #openstack-manila | 10:21 | |
| *** caowei has quit IRC | 10:27 | |
| *** AlexeyAbashkin has quit IRC | 10:28 | |
| amito-infinidat | Anyway to run local cover tests in my manila environment? zhongjun maybe you can help? :) | 10:57 |
| *** a-pugachev has quit IRC | 11:03 | |
| *** gcb has quit IRC | 11:05 | |
| *** AlexeyAbashkin has joined #openstack-manila | 11:19 | |
| *** a-pugachev has joined #openstack-manila | 11:21 | |
| *** AlexeyAbashkin has quit IRC | 11:23 | |
| *** erlon has joined #openstack-manila | 11:23 | |
| *** AlexeyAbashkin has joined #openstack-manila | 11:27 | |
| *** raissa has joined #openstack-manila | 12:12 | |
| *** eharney has joined #openstack-manila | 12:20 | |
| *** threestrands has joined #openstack-manila | 12:42 | |
| *** threestrands has quit IRC | 12:42 | |
| *** threestrands has joined #openstack-manila | 12:42 | |
| openstackgerrit | Amit Oren proposed openstack/manila master: INFINIDAT add Manila driver https://review.openstack.org/515432 | 12:46 |
| *** threestrands has quit IRC | 13:01 | |
| *** schmots has joined #openstack-manila | 13:06 | |
| *** eharney has quit IRC | 13:07 | |
| *** openstackstatus has quit IRC | 13:43 | |
| *** openstack has joined #openstack-manila | 13:46 | |
| *** ChanServ sets mode: +o openstack | 13:46 | |
| *** eharney has joined #openstack-manila | 13:54 | |
| tbarron | amito-infinidat: run 'tox -ecover' then look in the cover subdirectory, you can run a browser on that subdirectory | 13:56 |
| amito-infinidat | tbarron: thanks, it fails when trying to install the lxml dependency. | 13:56 |
| *** dustins has joined #openstack-manila | 13:58 | |
| tbarron | amito-infinidat: i'm running it now to see if I hit that issue | 14:14 |
| *** dsariel has quit IRC | 14:20 | |
| tbarron | amito-infinidat: it worked for me. My advice would be to clone a new manila workspace, run 'tox -e cover' and if that works cherry-pick your changes on top of it and run it again. | 14:20 |
| tbarron | amito-infinidat: you could also just 'rm -rf .tox' and run the command again in your current workspace | 14:21 |
| tbarron | amito-infinidat: that will be a bit faster if it works; the first suggestion should however ensure that all requirements are up to date, etc. too | 14:21 |
| amito-infinidat | tbarron: how much coverage is needed for the tox-cover job to succeed? | 14:27 |
| tbarron | amito-infinidat: it's a non-voting job and it's criteria for success is crude. | 14:28 |
| tbarron | amito-infinidat: it checks out a workspace at the previous commit & collects coverage results | 14:29 |
| tbarron | amito-infinidat: then with your candidate commit | 14:29 |
| tbarron | amito-infinidat: if there are four lines or more less being covered with the new commit it fails | 14:29 |
| tbarron | amito-infinidat: we don't really treat negatives on that report as decisive | 14:29 |
| tbarron | amito-infinidat: but in your review gouthamr looked at the actual coverage reports for your new functional code ... | 14:30 |
| tbarron | amito-infinidat: does that make sense? | 14:31 |
| amito-infinidat | tbarron: what do you mean? wasn't what gouthamr pointed to extracted from the job results? | 14:32 |
| * tbarron looks at the review again | 14:32 | |
| amito-infinidat | :) | 14:33 |
| tbarron | amito-infinidat: his remarks on patch set 14 w.r.t. lines 227, 480, 497 have links to the coverage job reports w.r.t. manila_share_drivers_infinidat.py | 14:34 |
| tbarron | amito-infinidat: you can see there in red lines not covered by unit tests and those he cites correspond to changes you are making in your patch | 14:35 |
| tbarron | amito-infinidat: so you can modify your unit tests to cover these branches in the code path (basically testing exception paths so far as I can see from a quick look) and check this output file after you run the coverage test again | 14:36 |
| amito-infinidat | tbarron: OK, so this is indeed from the tox-cover job | 14:37 |
| amito-infinidat | tbarron: thanks :) | 14:37 |
| tbarron | amito-infinidat: yw, and good luck. Looks like you're making good progress. | 14:37 |
| *** openstack has quit IRC | 14:46 | |
| *** openstack has joined #openstack-manila | 14:51 | |
| *** ChanServ sets mode: +o openstack | 14:51 | |
| *** a-pugachev has quit IRC | 14:53 | |
| *** a-pugachev_ is now known as a-pugachev | 14:53 | |
| openstackgerrit | Amit Oren proposed openstack/manila master: INFINIDAT add Manila driver https://review.openstack.org/515432 | 15:11 |
| *** gouthamr has joined #openstack-manila | 15:22 | |
| *** dsariel has joined #openstack-manila | 15:24 | |
| *** dsariel has quit IRC | 15:42 | |
| *** dsariel has joined #openstack-manila | 15:42 | |
| *** a-pugachev has quit IRC | 16:01 | |
| *** a-pugachev has joined #openstack-manila | 16:03 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Increase code coverage https://review.openstack.org/514964 | 16:08 |
| *** AlexeyAbashkin has quit IRC | 16:23 | |
| *** a-pugachev has quit IRC | 16:24 | |
| *** dsariel has quit IRC | 16:26 | |
| *** dsariel has joined #openstack-manila | 16:28 | |
| *** a-pugachev has joined #openstack-manila | 16:32 | |
| openstackgerrit | kedy zhao proposed openstack/manila master: fix allow the use of blank in user group name to access the share https://review.openstack.org/522440 | 16:41 |
| openstackgerrit | kedy zhao proposed openstack/python-manilaclient master: fix allow the use of blank in user group name to access the share https://review.openstack.org/522444 | 16:45 |
| *** eharney has quit IRC | 16:50 | |
| *** eharney has joined #openstack-manila | 16:54 | |
| amito-infinidat | zhongjun gouthamr: the new patch set is ready :) https://review.openstack.org/515432 | 17:04 |
| *** dsariel has quit IRC | 17:09 | |
| openstackgerrit | Merged openstack/manila master: Updated from global requirements https://review.openstack.org/523742 | 17:15 |
| *** vivsoni_ has joined #openstack-manila | 17:31 | |
| *** a-pugachev has quit IRC | 17:47 | |
| *** vivsoni_ has quit IRC | 18:32 | |
| *** ociuhandu has joined #openstack-manila | 19:32 | |
| *** ociuhandu has quit IRC | 19:36 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/523794 | 20:01 |
| *** AlexeyAbashkin has joined #openstack-manila | 20:14 | |
| *** a-pugachev has joined #openstack-manila | 20:15 | |
| *** AlexeyAbashkin has quit IRC | 20:18 | |
| *** threestrands has joined #openstack-manila | 20:47 | |
| *** threestrands has quit IRC | 20:47 | |
| *** threestrands has joined #openstack-manila | 20:47 | |
| *** erlon has quit IRC | 20:53 | |
| *** pcaruana has quit IRC | 21:00 | |
| *** sticker has joined #openstack-manila | 21:22 | |
| *** ganso has quit IRC | 21:27 | |
| *** eharney has quit IRC | 22:05 | |
| *** dustins has quit IRC | 22:08 | |
| *** jmlowe has quit IRC | 22:16 | |
| *** jmlowe has joined #openstack-manila | 22:30 | |
| *** schmots has quit IRC | 22:51 | |
| *** schmots has joined #openstack-manila | 23:07 | |
| *** hoonetorg has joined #openstack-manila | 23:10 | |
| *** jmlowe has quit IRC | 23:13 | |
| *** AlexeyAbashkin has joined #openstack-manila | 23:14 | |
| *** AlexeyAbashkin has quit IRC | 23:19 | |
| *** jmlowe has joined #openstack-manila | 23:21 | |
| *** absubram has joined #openstack-manila | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!