Monday, 2017-07-31

*** kaisers has joined #openstack-manila00:11
*** baojg has joined #openstack-manila00:19
*** kaisers has quit IRC00:19
*** baojg has quit IRC00:25
*** deep-book-gk has joined #openstack-manila01:17
*** kaisers has joined #openstack-manila01:17
*** deep-book-gk has left #openstack-manila01:18
*** baojg has joined #openstack-manila01:20
*** kaisers has quit IRC01:26
*** baojg has quit IRC01:27
*** gouthamr has quit IRC02:07
*** jiaopengju has joined #openstack-manila02:20
*** kaisers has joined #openstack-manila02:23
*** baojg has joined #openstack-manila02:24
*** baojg has quit IRC02:29
*** tuanluong has joined #openstack-manila02:38
*** kaisers has quit IRC02:42
openstackgerritzhongshengping proposed openstack/puppet-manila master: Update openstackdocstheme>=1.16.0  https://review.openstack.org/48905103:02
openstackgerritzhongjun proposed openstack/manila master: Fix cannot deny ipv6 access rules  https://review.openstack.org/48893803:03
openstackgerritzhongjun proposed openstack/manila master: Fix cannot deny ipv6 access rules  https://review.openstack.org/48893803:09
*** baojg has joined #openstack-manila03:25
*** baojg has quit IRC03:32
*** kaisers has joined #openstack-manila03:39
*** kaisers has quit IRC03:49
*** kaisers has joined #openstack-manila04:14
*** eharney has quit IRC04:19
*** kaisers has quit IRC04:24
*** baojg has joined #openstack-manila04:28
*** rejy has joined #openstack-manila04:31
*** baojg has quit IRC04:32
*** kaisers has joined #openstack-manila04:54
*** kaisers has quit IRC05:05
*** arnewiebalck_ has joined #openstack-manila05:10
*** rejy has quit IRC05:15
*** rraja has joined #openstack-manila05:23
*** arnewiebalck_ has quit IRC05:28
*** rraja has quit IRC05:28
*** baojg has joined #openstack-manila05:29
*** baojg has quit IRC05:39
*** GK1wmSU has joined #openstack-manila05:40
*** GK1wmSU has left #openstack-manila05:42
*** _GK1wmSU has joined #openstack-manila05:54
*** _GK1wmSU has left #openstack-manila05:54
*** _GK1wmSU has joined #openstack-manila05:54
*** _GK1wmSU has left #openstack-manila05:57
*** kaisers has joined #openstack-manila06:01
*** pcaruana has joined #openstack-manila06:19
*** tuanluong has quit IRC06:19
*** kaisers has quit IRC06:33
*** tuanluong has joined #openstack-manila07:18
*** td has quit IRC07:28
*** kaisers has joined #openstack-manila07:30
*** baojg has joined #openstack-manila07:35
*** baojg has quit IRC07:40
*** kaisers has quit IRC07:41
*** td has joined #openstack-manila07:42
*** dsariel has joined #openstack-manila07:52
*** baojg has joined #openstack-manila08:37
*** kaisers has joined #openstack-manila08:38
*** baojg has quit IRC08:41
*** kaisers has quit IRC08:59
*** lpetrut has joined #openstack-manila09:15
*** tosky has joined #openstack-manila09:21
*** jiaopengju1 has joined #openstack-manila09:25
*** jiaopengju has quit IRC09:27
*** baojg has joined #openstack-manila09:38
*** baojg has quit IRC09:43
*** kaisers has joined #openstack-manila09:56
*** kaisers has quit IRC10:05
*** jiaopengju1 has quit IRC10:09
openstackgerritMerged openstack/manila-ui master: Updated from global requirements  https://review.openstack.org/48823810:36
*** baojg has joined #openstack-manila10:39
*** baojg has quit IRC10:44
openstackgerritOpenStack Proposal Bot proposed openstack/manila-ui master: Imported Translations from Zanata  https://review.openstack.org/48917410:47
*** ganso has joined #openstack-manila10:51
*** kaisers has joined #openstack-manila11:02
*** tuanluong has quit IRC11:08
*** kaisers has quit IRC11:24
*** baojg has joined #openstack-manila11:41
*** baojg has quit IRC11:46
*** arnewiebalck_ has joined #openstack-manila12:01
openstackgerritMerged openstack/python-manilaclient master: Update reno for stable/pike  https://review.openstack.org/48878712:12
*** kaisers has joined #openstack-manila12:20
*** catintheroof has joined #openstack-manila12:29
*** kaisers has quit IRC12:31
*** baojg has joined #openstack-manila12:41
openstackgerritMerged openstack/manila-ui master: Imported Translations from Zanata  https://review.openstack.org/48917412:46
*** baojg has quit IRC12:48
*** rraja has joined #openstack-manila12:48
*** baojg has joined #openstack-manila12:51
*** baojg has quit IRC12:51
*** baojg has joined #openstack-manila12:54
*** cknight has joined #openstack-manila12:56
*** mtanino has joined #openstack-manila13:04
*** dustins has joined #openstack-manila13:05
*** arnewiebalck_ has quit IRC13:08
openstackgerritMerged openstack/manila master: Imported Translations from Zanata  https://review.openstack.org/48899313:14
*** baojg has quit IRC13:15
*** baojg has joined #openstack-manila13:16
*** arnewiebalck_ has joined #openstack-manila13:28
*** kaisers has joined #openstack-manila13:28
*** arnewiebalck_ has quit IRC13:28
*** arnewiebalck_ has joined #openstack-manila13:30
*** gouthamr has joined #openstack-manila13:30
*** rraja has quit IRC13:43
*** gcb has joined #openstack-manila13:46
bswartztbarron: can you explain your comment above about leaking file descriptors?13:51
*** eharney has joined #openstack-manila13:52
bswartztbarron: n/m I followed the link you posted13:53
bswartzI'm really confused13:53
bswartztbarron: https://bugs.launchpad.net/ubuntu/+source/lvm2/+bug/59182313:57
openstackLaunchpad bug 591823 in lvm2 ""File descriptor \d+ (\S+) leaked on lvs invocation."" [Unknown,Fix released]13:57
*** jiaopengju has joined #openstack-manila14:02
*** kaisers has quit IRC14:02
*** xyang1 has joined #openstack-manila14:05
*** jiaopengju has quit IRC14:07
*** arnewiebalck_ has quit IRC14:15
tbarronbswartz: thanks14:20
*** jiaopengju has joined #openstack-manila14:22
*** chenying__ has quit IRC14:33
*** openstackgerrit has quit IRC14:33
*** kaisers has joined #openstack-manila15:00
*** pcaruana has quit IRC15:04
*** markstur has joined #openstack-manila15:07
*** kaisers has quit IRC15:09
*** gcb has quit IRC15:23
*** jiaopengju has quit IRC15:24
*** dsariel has quit IRC15:36
*** jmlowe has quit IRC15:37
*** kaisers has joined #openstack-manila16:06
*** baojg has quit IRC16:07
*** kaisers has quit IRC16:25
*** kaisers has joined #openstack-manila16:46
bswartztbarron: based on the bug description it looks like something that needs to be worked around but it's not really our fault16:48
bswartztbarron: we might want to use the LVM_SUPPRESS_FD_WARNINGS thing16:53
bswartznot sure how that works with the rootwrap16:53
*** kaisers has quit IRC16:55
*** kaisers has joined #openstack-manila17:08
*** lpetrut has quit IRC17:15
bswartztbarron: actually upon deeper investigation I think the leaked file descriptor warning is a red herring17:15
bswartzthe actual error was on the next line: "Can't remove merging snapshot logical volume lvm-shares/share-snapshot-686b8648-e34c-45fe-bc49-ad7cdfea763f."17:16
bswartzthat's what caused error code 5 and what caused us to fail17:16
bswartzthe leaked file descriptor warning amounts to log spam that we can ignore17:16
tbarronbswartz: ok, would be nice to suppress it then, but not urgent.  I see the lvremove failure.17:18
tbarronbswartz: we're trying to lvremove while the snapshot is still merging?17:19
bswartztbarron: the merge is an async operation17:24
bswartzwe kick it off but don't wait for it to complete17:25
bswartzthat may explain why the problem is intermittent17:25
bswartzsometimes it completes fast enough and sometimes it takes too long17:25
bswartzwe need a way to block until it's done17:29
*** tosky has quit IRC17:32
bswartztbarron: https://sourceware.org/git/?p=lvm2.git;a=blob;f=lib/metadata/lv_manip.c;h=1851783bf5cfaca7f53a2b457f04c552fa7d073b;hb=HEAD#l628117:32
tbarronbswartz: can we just do a retry loop on the lvremove?17:33
bswartzif we can find a way to tell the difference between this failure and other permanent failures17:34
*** jmlowe has joined #openstack-manila17:34
bswartzI'm trying to navigate the call graph inside lvconvert to see how it arrived at that error17:36
bswartzit seems very strange17:36
bswartzI'm wondering why we have an "-f" flag on lvremove now17:36
bswartzhmm maybe that just skips the interactive confirmation17:38
*** jmlowe has quit IRC17:39
*** jmlowe has joined #openstack-manila17:39
bswartztbarron: I see that the existing code already has a retry loop17:41
bswartzaround lvremove17:41
tbarronbswartz: ack, and I see three tries (all failing) in the logs17:48
bswartzyeah vish seems to have known about the flakiness of lvm calls17:48
bswartzI'm going to see if there's a way I can restructure the LVM driver code to make the merge operation happen synchronously17:49
bswartzwhen I first wrote this it did not occur to me that there were background timing issues17:49
bswartzso I'm going to try harder to eliminate them before reverting to a horrible polling mechanism17:49
*** harlowja has joined #openstack-manila18:11
bswartztbarron: there's something odd here in the lvm revert code18:13
* bswartz loads up the git blame18:13
bswartzlooks like the code got modified a few times and somehow we have multiple calls to unmount18:15
bswartzugh18:16
bswartzokay I'm going to end up addressing multiple bugs with 1 fix I think18:16
*** lpetrut has joined #openstack-manila18:17
bswartztbarron: I now suspect this whole problem is a result of a bad interaction between the revert to snapshot code and the mountable snapshots code in the LVM driver18:21
gansobswartz: I remember testing this interaction18:23
gansobswartz: but locally, I did not face such random issues18:23
bswartzganso: I can see how it would have worked18:24
bswartzbut not reliably18:24
bswartzI think the code bugs are my fault, but there are some readability issues added by tpsilva's patch that make it hard to understand why my code was wrong18:24
gansobswartz: see https://review.openstack.org/#/c/431315/ https://review.openstack.org/#/c/433039/ https://review.openstack.org/#/c/444709/18:25
*** catintheroof has quit IRC18:59
*** catintheroof has joined #openstack-manila19:00
*** catintheroof has quit IRC19:00
*** catintheroof has joined #openstack-manila19:01
*** arnewiebalck_ has joined #openstack-manila19:03
bswartzganso: sorry I had a meeting19:33
bswartzganso: I'm working on a fix19:34
*** openstackgerrit has joined #openstack-manila19:41
openstackgerritRaissa Sarmento proposed openstack/manila master: Use tempest-plugin service client registration  https://review.openstack.org/33459619:41
*** jmlowe has quit IRC20:16
*** cknight has quit IRC20:50
openstackgerritBen Swartzlander proposed openstack/manila master: Change the way snapshots are exported in LVM  https://review.openstack.org/48856920:52
bswartz^ this is not the fix20:53
*** eharney has quit IRC20:59
*** lpetrut has quit IRC21:01
*** catintheroof has quit IRC21:17
*** dustins has quit IRC21:23
*** arnewiebalck_ has quit IRC21:32
*** gouthamr has quit IRC22:46
*** gouthamr has joined #openstack-manila23:15
*** catintheroof has joined #openstack-manila23:24
*** https_GK1wmSU has joined #openstack-manila23:39
*** https_GK1wmSU has left #openstack-manila23:40
*** catintheroof has quit IRC23:43
openstackgerritGoutham Pacha Ravi proposed openstack/python-manilaclient master: Add rally job manifests  https://review.openstack.org/48943523:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!