| *** gcb has quit IRC | 00:21 | |
| *** sapcc-bot has quit IRC | 01:37 | |
| *** carthaca_ has quit IRC | 01:37 | |
| *** sapcc-bot has joined #openstack-manila | 01:38 | |
| *** carthaca_ has joined #openstack-manila | 01:38 | |
| *** gcb has joined #openstack-manila | 02:03 | |
| openstackgerrit | Ryan Liang proposed openstack/manila master: VNX: bump the version for Pike https://review.openstack.org/481473 | 02:39 |
|---|---|---|
| *** dsariel has quit IRC | 03:09 | |
| *** jmlowe has joined #openstack-manila | 03:58 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Test https://review.openstack.org/482402 | 04:00 |
| openstackgerrit | Rajat Sharma proposed openstack/manila master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/481543 | 04:19 |
| *** arnewiebalck_ has joined #openstack-manila | 04:33 | |
| *** markstur has quit IRC | 04:55 | |
| *** jprovazn has joined #openstack-manila | 04:57 | |
| *** dsariel has joined #openstack-manila | 05:33 | |
| *** jprovazn has quit IRC | 05:39 | |
| *** lpetrut has joined #openstack-manila | 05:41 | |
| *** arnewiebalck_ has quit IRC | 05:49 | |
| *** dsariel has quit IRC | 05:56 | |
| *** pcaruana has joined #openstack-manila | 06:04 | |
| *** dsariel has joined #openstack-manila | 06:06 | |
| *** jprovazn has joined #openstack-manila | 06:08 | |
| *** td has quit IRC | 06:09 | |
| *** zhonghua has quit IRC | 06:11 | |
| *** zhonghua has joined #openstack-manila | 06:12 | |
| *** td has joined #openstack-manila | 06:18 | |
| *** jmlowe has quit IRC | 06:25 | |
| *** dsariel has quit IRC | 06:30 | |
| *** lpetrut has quit IRC | 06:39 | |
| *** arnewiebalck_ has joined #openstack-manila | 06:45 | |
| *** belmoreira has joined #openstack-manila | 06:46 | |
| *** arnewiebalck_ has quit IRC | 06:46 | |
| *** arnewiebalck_ has joined #openstack-manila | 06:49 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** a-pugachev has joined #openstack-manila | 07:55 | |
| vponomaryov | jprovazn: pong | 07:55 |
| jprovazn | vponomaryov: hi, wanted to check your comment on https://review.openstack.org/#/c/313549/ | 07:56 |
| jprovazn | vponomaryov: you want explicit db tests that the table is present on upgrade and table is gone on downgrade? | 07:57 |
| vponomaryov | jprovazn: test of Db schema change | 07:58 |
| vponomaryov | jprovazn: as it is done for other existing DB migrations | 07:58 |
| jprovazn | vponomaryov: in this case db schema change consists of just adding a new db, my understanding of https://github.com/openstack/manila/blob/master/manila/tests/db/migrations/alembic/migrations_data_checks.py is that it's purpose is testing migrations which contain some extra logic (e.g. altering columns). "as it is done for other existing DB migrations" - we don't test upgrade/downgrade if it's just create/drop of a table (w/o any | 08:01 |
| jprovazn | logic) | 08:01 |
| jprovazn | s/a new db/a new table/ | 08:01 |
| vponomaryov | jprovazn: what do you mean "we don't"? Upgrade part checks that table exists and we can write to table, downgrade part checks that table is absent | 08:03 |
| vponomaryov | jprovazn: we DO test it for existing migrations | 08:03 |
| vponomaryov | jprovazn: example with other proposed feature: https://review.openstack.org/#/c/452158/33/manila/tests/db/migrations/alembic/migrations_data_checks.py | 08:05 |
| *** raissa has joined #openstack-manila | 08:12 | |
| *** a-pugachev has joined #openstack-manila | 08:13 | |
| jprovazn | vponomaryov: ok, fair enough. | 08:15 |
| *** Manor has joined #openstack-manila | 08:15 | |
| *** openstackgerrit has joined #openstack-manila | 08:27 | |
| *** Manor_ has joined #openstack-manila | 08:47 | |
| *** Manor has quit IRC | 08:51 | |
| *** lpetrut has joined #openstack-manila | 09:04 | |
| openstackgerrit | zhongjun proposed openstack/manila master: Test https://review.openstack.org/482402 | 09:11 |
| *** arnewiebalck_ has quit IRC | 09:15 | |
| *** Manor has joined #openstack-manila | 09:19 | |
| *** Manor_ has quit IRC | 09:22 | |
| *** raissa has quit IRC | 09:25 | |
| *** Manor has quit IRC | 10:00 | |
| openstackgerrit | Thomas Bechtold proposed openstack/manila master: Allow docs build without git https://review.openstack.org/482494 | 10:08 |
| openstackgerrit | Mayur Indalkar proposed openstack/manila master: Implementation of Manila driver for Veritas Access https://review.openstack.org/472190 | 10:10 |
| *** gcb has quit IRC | 10:13 | |
| *** raissa has joined #openstack-manila | 10:25 | |
| openstackgerrit | Alexander Pugachev proposed openstack/python-manilaclient master: Covers manilaclient/common/apiclient/auth.py:discover_auth_systems(). https://review.openstack.org/482108 | 10:26 |
| openstackgerrit | Alexander Pugachev proposed openstack/python-manilaclient master: Increases code coverage https://review.openstack.org/482108 | 10:27 |
| *** gouthamr has quit IRC | 10:33 | |
| *** gouthamr has joined #openstack-manila | 10:41 | |
| *** ganso has joined #openstack-manila | 10:43 | |
| openstackgerrit | Jan Provaznik proposed openstack/manila master: User Messages https://review.openstack.org/313549 | 10:56 |
| *** jprovazn has quit IRC | 10:56 | |
| *** dsariel has joined #openstack-manila | 11:03 | |
| *** rraja has joined #openstack-manila | 11:09 | |
| *** jprovazn has joined #openstack-manila | 11:17 | |
| *** jprovazn has quit IRC | 11:18 | |
| *** jprovazn has joined #openstack-manila | 11:18 | |
| *** jprovazn has quit IRC | 11:18 | |
| *** jprovazn has joined #openstack-manila | 11:18 | |
| openstackgerrit | Thomas Bechtold proposed openstack/manila master: Allow docs build without git https://review.openstack.org/482494 | 11:55 |
| *** raissa_ has joined #openstack-manila | 12:00 | |
| *** raissa has quit IRC | 12:00 | |
| *** dustins has joined #openstack-manila | 12:09 | |
| *** MVenesio has joined #openstack-manila | 12:32 | |
| *** openstackgerrit has quit IRC | 12:47 | |
| tbarron | vponomaryov: need to get this fix (thank you) backported to stable/ocata and stable/newton: https://review.openstack.org/#/c/482308/ | 12:53 |
| tbarron | vponomaryov: please give it your blessing | 12:53 |
| vponomaryov | done | 12:55 |
| vponomaryov | jprovazn: ping | 13:06 |
| jprovazn | vponomaryov, hi | 13:08 |
| vponomaryov | hello | 13:08 |
| vponomaryov | jprovazn: why in https://review.openstack.org/#/c/313549/56/manila_tempest_tests/tests/api/admin/test_user_messages.py in some tests you use line "messages = body['messages']" in some other don't? | 13:08 |
| jprovazn | vponomaryov, IIRC there is a nasty hack in manila tempest helper which checks whether size of items in reponse is 1 and if so it returns this single item instead of list of items, /me searches for the link | 13:12 |
| vponomaryov | jprovazn: I know about tempest | 13:13 |
| vponomaryov | jprovazn: it means that you API returns more than 1 arg | 13:13 |
| vponomaryov | jprovazn: for the same API | 13:13 |
| vponomaryov | jprovazn: we expect 2 keys only for share_type_list | 13:13 |
| vponomaryov | jprovazn: which has "volume_types" and "share_types" | 13:14 |
| vponomaryov | jprovazn: I guess the problem is in here: https://review.openstack.org/#/c/313549/56/manila/api/views/messages.py | 13:15 |
| vponomaryov | jprovazn: "messages_links" is added | 13:15 |
| vponomaryov | jprovazn: I really doubt it is by design | 13:16 |
| jprovazn | vponomaryov, not sure what you mean? | 13:18 |
| vponomaryov | jprovazn: I mean that your code violates agreed spec for this feature, that is defined here: https://specs.openstack.org/openstack/manila-specs/specs/pike/user-messages.html#rest-api-impact | 13:18 |
| vponomaryov | where we have only one top-level key - messages | 13:18 |
| vponomaryov | also, "detail_id" is absent there -> https://review.openstack.org/#/c/313549/56/manila/db/sqlalchemy/models.py | 13:19 |
| vponomaryov | jprovazn: ^ | 13:19 |
| vponomaryov | tbarron: ^ | 13:19 |
| jprovazn | vponomaryov, detail_id is on line 1200 | 13:20 |
| vponomaryov | I am saying it is absent in spec | 13:20 |
| vponomaryov | we have "detail" in spec | 13:20 |
| vponomaryov | and it is 255 chars long | 13:20 |
| vponomaryov | not 10 | 13:20 |
| jprovazn | vponomaryov, re spec difference - ack - so are you suggesting to remove message_links because it differs from spec? | 13:21 |
| vponomaryov | jprovazn: first of all, the reason for it is not clear | 13:21 |
| vponomaryov | jprovazn: second, yes, spec is different | 13:21 |
| vponomaryov | jprovazn: it is completely unclear what is "detail_id" | 13:21 |
| vponomaryov | that longs 10 chars | 13:21 |
| jprovazn | vponomaryov, so there is a parallel user messages patch for cinder tommylikehu is working on - IIRC detail -> detail_id came from my intention to keep both versions more aligned | 13:22 |
| vponomaryov | jprovazn: "id" fields refer to some table | 13:23 |
| vponomaryov | you don't have new table for details | 13:23 |
| vponomaryov | which means, it is etiher uncompleted commit or it has wrong name and size of column for detail | 13:24 |
| jprovazn | vponomaryov, in this case detail_id is ID of a detail which is mapped to detail message | 13:24 |
| vponomaryov | mapped to which table? | 13:24 |
| vponomaryov | you added only one -> https://review.openstack.org/#/c/313549/56/manila/db/sqlalchemy/models.py | 13:24 |
| jprovazn | https://review.openstack.org/#/c/313549/56/manila/message/message_field.py | 13:26 |
| jprovazn | mapping is done in message_field, I don't mean reference on db level | 13:27 |
| *** openstackgerrit has joined #openstack-manila | 13:27 | |
| openstackgerrit | Merged openstack/python-manilaclient master: Updated from global requirements https://review.openstack.org/478080 | 13:27 |
| *** gcb has joined #openstack-manila | 13:32 | |
| vponomaryov | jprovazn: ok, let it be so, there are other concerns, left comments | 13:33 |
| vponomaryov | jprovazn: in commit | 13:33 |
| jprovazn | vponomaryov, ok, thanks, I'll look in a moment | 13:34 |
| jprovazn | vponomaryov, re: "contradicts spec" comments - are these comments just statement of the fact or are do you expect update of the patch? IMO these deviations are minor, not a dramatic violation of the spec. Spec is a proposal at the time of writing, IMO doing minor changes during development is fine. | 13:44 |
| vponomaryov | jprovazn: comments for action_id and detail_id are for other reviewers, it will be enough just to update notes before these lines where is it taken from | 13:48 |
| *** eharney has joined #openstack-manila | 13:48 | |
| jprovazn | vponomaryov, ok, I suppose you are ok with keeping message_links too? | 13:52 |
| vponomaryov | jprovazn: either keep this key always or remove it | 13:52 |
| vponomaryov | jprovazn: when we don't have messages key "messages" always exists , just with empty value | 13:53 |
| vponomaryov | empty list* | 13:53 |
| jprovazn | vponomaryov, I think it makes sense to keep it there unconditionally, on the other side if I grep other APis it seems it's usually added conditionally | 13:56 |
| jprovazn | (which is the reason I added condition too) | 13:57 |
| jprovazn | vponomaryov, looking closer, it seems that consensus across manila and cinder is to return xxx_links conditionally (only if the query used 'limit' param) - I would lean to be consistent with the rest | 14:06 |
| bswartz | tbarron: the newton backport is having issues | 14:26 |
| *** xyang1 has joined #openstack-manila | 14:27 | |
| vponomaryov | jprovazn: if so, then need to make tempest safe | 14:33 |
| zhongjun | tbarron: xyang1 : Addressed your comments and responses some comments. Could you take a look at again. Thanks https://review.openstack.org/#/c/462468/ | 14:41 |
| xyang1 | zhongjun: sure | 14:44 |
| zhongjun | xyang1: :) | 14:45 |
| *** openstackgerrit has quit IRC | 14:48 | |
| *** openstackgerrit has joined #openstack-manila | 14:49 | |
| openstackgerrit | Tom Barron proposed openstack/manila-ui master: DO NOT MERGE https://review.openstack.org/482591 | 14:49 |
| tbarron | bswartz: thanks, looks like I need a separate fix in tests in stable/newton | 14:50 |
| tbarron | zhongjun: will try to look this afternoon; also, on the client side patch please make sure we discuss the proposed change from the spec from '~' to '_' in the weekly meeting. | 14:51 |
| *** jmlowe has joined #openstack-manila | 14:56 | |
| *** markstur has joined #openstack-manila | 15:06 | |
| zhongjun | tbarron: ok, we should discuss it | 15:09 |
| *** catintheroof has joined #openstack-manila | 15:28 | |
| *** YuYangWang has quit IRC | 15:30 | |
| *** belmoreira has quit IRC | 15:38 | |
| *** lpetrut has quit IRC | 15:56 | |
| *** jmlowe has quit IRC | 15:57 | |
| *** eharney has quit IRC | 16:00 | |
| *** jmlowe has joined #openstack-manila | 16:00 | |
| *** markstur has quit IRC | 16:01 | |
| *** markstur has joined #openstack-manila | 16:02 | |
| *** jmlowe has quit IRC | 16:22 | |
| *** dsariel has quit IRC | 16:49 | |
| *** a-pugachev has quit IRC | 17:12 | |
| *** lpetrut has joined #openstack-manila | 17:19 | |
| *** YuYangWang has joined #openstack-manila | 17:30 | |
| tbarron | vponomaryov: ganso bswartz https://review.openstack.org/#/c/482572/ | 17:40 |
| *** eharney has joined #openstack-manila | 17:40 | |
| tbarron | ^^^ stable/newton version of that manila-ui fix needed a couple tweaks | 17:40 |
| *** raissa_ has quit IRC | 17:49 | |
| *** lpetrut has quit IRC | 17:51 | |
| *** eharney has quit IRC | 18:05 | |
| *** lpetrut has joined #openstack-manila | 18:13 | |
| *** eharney has joined #openstack-manila | 18:18 | |
| *** rraja has quit IRC | 18:18 | |
| *** lpetrut has quit IRC | 18:47 | |
| openstackgerrit | David Hill proposed openstack/manila master: Define meta_value to 'none' if it's not defined https://review.openstack.org/482672 | 19:04 |
| *** arnewiebalck_ has joined #openstack-manila | 19:06 | |
| openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient master: Enable IPv6 in manila(client) https://review.openstack.org/328932 | 19:52 |
| openstackgerrit | Ben Swartzlander proposed openstack/python-manilaclient master: Enable IPv6 in manila(client) https://review.openstack.org/328932 | 19:58 |
| bswartz | tbarron: ping | 20:01 |
| tbarron | bswartz: pong | 20:01 |
| bswartz | tbarron: I noticed something weird today | 20:01 |
| bswartz | I can do IPv6 mounts on xenial... | 20:02 |
| tbarron | nice! | 20:02 |
| bswartz | I'm not sure what changed | 20:02 |
| tbarron | well, me either but that's a good thing. | 20:03 |
| bswartz | tbarron: I wonder if the debian or ubuntu maintainers backported the IPv6 bits to the older package | 20:04 |
| tbarron | ipv6 marches forward, or lurches | 20:04 |
| bswartz | I don't have time to dig through the changelogs but it seems that unless I'm really confused we might be able to test ipv6 in our existing jobs | 20:04 |
| tbarron | bswartz: so you are starting to test zhongjun's patches | 20:04 |
| bswartz | well you probably saw the client one needed some updating ^^^ | 20:05 |
| bswartz | but with those updates I think it's working now | 20:05 |
| bswartz | just need to add unit tests to my patches and get the whole thing merged | 20:06 |
| bswartz | also I have some more functional testing to do | 20:06 |
| bswartz | but I'm feeling good about his | 20:07 |
| bswartz | about this | 20:07 |
| tbarron | bswartz: sorry, got disconnected, but yeah, just roll with it and let's get this stuff tested. the centos lvm job is there if we need it. | 20:11 |
| *** MVenesio has quit IRC | 20:25 | |
| *** arnewiebalck_ has quit IRC | 20:44 | |
| openstackgerrit | David Hill proposed openstack/manila master: Define meta_value to 'none' if it's not defined https://review.openstack.org/482672 | 20:46 |
| *** carthaca_ has quit IRC | 21:04 | |
| *** sapcc-bot has quit IRC | 21:04 | |
| *** sapcc-bot has joined #openstack-manila | 21:04 | |
| *** carthaca_ has joined #openstack-manila | 21:04 | |
| *** catintheroof has quit IRC | 21:04 | |
| *** jmlowe has joined #openstack-manila | 21:05 | |
| *** dustins has quit IRC | 21:22 | |
| *** pcaruana has quit IRC | 21:23 | |
| openstackgerrit | David Hill proposed openstack/manila master: Define meta_value to 'none' if it's not defined https://review.openstack.org/482672 | 21:24 |
| *** jprovazn has quit IRC | 21:43 | |
| *** eharney has quit IRC | 21:47 | |
| *** jmlowe has quit IRC | 21:57 | |
| *** jmlowe has joined #openstack-manila | 22:01 | |
| *** jmlowe has quit IRC | 22:09 | |
| *** ganso has quit IRC | 23:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!