Wednesday, 2017-02-15

« Tuesday, 2017-02-14 Index Thursday, 2017-02-16 »
*** mtanino has quit IRC00:23
*** catintheroof has quit IRC00:29
*** crushil has quit IRC01:57
*** dsariel has quit IRC02:09
*** gouthamr has quit IRC02:45
*** gouthamr has joined #openstack-manila02:46
*** crushil has joined #openstack-manila02:50
*** crushil has quit IRC02:56
*** crushil has joined #openstack-manila02:58
*** waj334_ has joined #openstack-manila03:04
*** dmellado_ has joined #openstack-manila03:06
*** draynium_ has joined #openstack-manila03:06
*** dmellado has quit IRC03:07
*** waj334 has quit IRC03:07
*** smcginnis has quit IRC03:07
*** crushil has quit IRC03:07
*** bswartz has quit IRC03:07
*** gcb has quit IRC03:07
*** draynium has quit IRC03:07
*** smcginnis_ has joined #openstack-manila03:07
*** waj334_ is now known as waj33403:07
*** smcginnis_ is now known as smcginnis03:07
*** crushil has joined #openstack-manila03:08
*** gcb has joined #openstack-manila03:08
openstackgerritTommyLike proposed openstack/manila master: Fix: [LVM] Can't extend share when snapshots exist  https://review.openstack.org/43131503:14
*** crushil has quit IRC03:15
*** gouthamr has quit IRC04:01
openstackgerritTommyLike proposed openstack/manila master: Fix: [LVM] Can't extend share when snapshots exist  https://review.openstack.org/43131504:49
openstackgerritTommyLike proposed openstack/manila master: Fix: [LVM] Can't extend share when snapshots exist  https://review.openstack.org/43131504:59
openstackgerritDanny Al-Gaaf proposed openstack/manila master: Adds manila-manage 'db purge' command to man page  https://review.openstack.org/43367605:11
openstackgerritGhanshyam Mann proposed openstack/manila master: Fix to use correct config options for network_for_ssh  https://review.openstack.org/43407005:13
*** faizy has joined #openstack-manila05:28
*** sandanar has joined #openstack-manila05:36
*** wiebalck has joined #openstack-manila06:05
openstackgerritDanny Al-Gaaf proposed openstack/manila master: doc: verify all rst files  https://review.openstack.org/43408606:08
*** lpetrut has joined #openstack-manila06:09
*** pcaruana has joined #openstack-manila06:20
openstackgerritTommyLike proposed openstack/manila master: Add shrink share in LVM driver  https://review.openstack.org/43348906:21
*** dsariel has joined #openstack-manila06:27
*** wiebalck has quit IRC06:57
openstackgerritTommyLike proposed openstack/manila master: Fix: LVM driver doesn't resize lv while is required  https://review.openstack.org/43355907:07
*** kaisers has joined #openstack-manila07:12
*** lpetrut has quit IRC07:22
*** jprovazn has joined #openstack-manila07:25
*** tommylikehu_ has joined #openstack-manila07:30
*** tommylikehu_ has quit IRC07:35
*** lpetrut has joined #openstack-manila07:37
*** rraja has joined #openstack-manila07:38
*** lpetrut has quit IRC07:48
*** tuanluong has joined #openstack-manila08:35
openstackgerritdengshaolin proposed openstack/python-manilaclient master: Raise TypeError in manilaclient/common/httpclient.py  https://review.openstack.org/43414008:39
vponomaryovbswartz: https://github.com/openstack/manila/blob/4cfdbea4/manila_tempest_tests/tests/api/base.py#L799-L82608:42
vponomaryovbswartz: it is used for dynamic creation of share types in lots of places for share replication/migration and other kind of tests...08:42
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Upgrade share group snapshot members DB model  https://review.openstack.org/43385408:51
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Upgrade share group snapshot members DB model  https://review.openstack.org/43385408:55
*** akapil has joined #openstack-manila09:02
*** lpetrut has joined #openstack-manila09:17
*** lpetrut has quit IRC09:26
*** lpetrut has joined #openstack-manila09:28
*** gcb has quit IRC09:31
*** gcb has joined #openstack-manila09:33
*** dsariel has quit IRC09:43
*** dsariel has joined #openstack-manila09:54
*** tuanluong has quit IRC10:14
*** wiebalck has joined #openstack-manila10:22
*** ociuhandu has joined #openstack-manila10:28
*** ganso has joined #openstack-manila10:47
*** wiebalck has quit IRC11:22
*** yumiriam has joined #openstack-manila11:24
*** crushil has joined #openstack-manila11:25
*** tommylikehu_ has joined #openstack-manila11:40
*** ociuhandu has quit IRC11:42
*** gcb has quit IRC11:48
*** rraja has quit IRC11:50
*** ociuhandu has joined #openstack-manila11:55
*** crushil has quit IRC12:06
*** catintheroof has joined #openstack-manila12:36
*** faizy has quit IRC12:39
*** tommylikehu_ has quit IRC12:47
*** ociuhandu has quit IRC12:48
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Upgrade share group snapshot members DB model  https://review.openstack.org/43385412:48
*** tommylikehu_ has joined #openstack-manila12:49
*** tommylikehu_ has quit IRC12:51
*** tommylikehu_ has joined #openstack-manila12:51
*** gouthamr has joined #openstack-manila13:13
*** faizy has joined #openstack-manila13:15
*** gcb has joined #openstack-manila13:23
*** eharney has joined #openstack-manila13:26
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Upgrade share group snapshot members DB model  https://review.openstack.org/43385413:30
*** bswartz has joined #openstack-manila13:38
openstackgerritJan Provaznik proposed openstack/manila-specs master: Add spec for user messages  https://review.openstack.org/43427713:40
*** xyang_ has joined #openstack-manila13:41
*** dustins has joined #openstack-manila13:49
openstackgerritMerged openstack/manila master: [Tempest] Refactor api/tests/admin/test_share_servers module  https://review.openstack.org/43300313:51
*** ociuhandu has joined #openstack-manila13:51
*** tongli has joined #openstack-manila13:54
*** xyang_ has quit IRC13:59
*** xyang_ has joined #openstack-manila13:59
*** xyang_ has quit IRC14:02
*** crushil has joined #openstack-manila14:03
vponomaryovmarkstur: >>> https://review.openstack.org/#/c/425904/ <<<14:10
*** porrua has joined #openstack-manila14:15
*** xyang_ has joined #openstack-manila14:18
openstackgerritMerged openstack/manila master: Add Share Migration devref docs  https://review.openstack.org/37577114:18
openstackgerritMerged openstack/manila master: Improve HNAS driver coverage  https://review.openstack.org/43361014:24
*** dmellado_ is now known as dmellado14:27
*** chlong has quit IRC14:37
*** tongli has quit IRC14:40
gansogouthamr: ping14:47
*** gcb has quit IRC14:49
*** gcb has joined #openstack-manila14:49
gouthamrganso: pong14:49
gansogouthamr: Hi Goutham. are you saying that this patch https://review.openstack.org/#/c/433613/ cannot be backported after Ocata release on Feb 23rd ?14:50
*** ociuhandu has quit IRC14:51
*** dustins has quit IRC14:51
bswartzganso: yikes!14:57
bswartzyou forgot to update the version before the branch?14:57
gansobswartz: yes14:57
bswartzganso: this seems sketchy to me14:59
bswartzI don't agree that a reno would make this any better14:59
gansobswartz: indeed it wouldn't14:59
bswartzganso: can't we phrase it as a bug?15:00
bswartzthe fix is not trivial because it does impact user-observable functionality15:00
gansobswartz: we could, stating that it is shown the same version as newton with the same functionality15:00
bswartzand the problem you're solving is that someone forgot to bump a version number15:00
bswartzit feels like a bug15:00
gansobswartz: ok, if considered as a bug can be solved as a bug15:01
gansobswartz: can it be backported?15:01
bswartzyeah I don't see why not15:01
gansobswartz: oh ok then, gouthamr's statement made me think it could not15:01
gouthamrganso: it's possible to backport imo... it's not a trivialfix15:03
bswartzganso: the trick will be when the fix merges compared to when we cut rc215:03
bswartzif we can get a backport completed before rc2 then I think it's fine15:04
bswartzotherwise, we'd want to wait until after official release to do the backport15:04
gansobswartz: oh it can be included in RC2? I was assuming this one could only be backported after the release on Feb 23rd15:04
bswartzganso: we would never do an RC2 just for such a small bug15:05
bswartzbut because we have a critical bug, other low-risk fixes can get combined with that fix for rc215:05
gansobswartz: cool I thought RC2 was restricted to include only the critical bugfix15:07
bswartzganso: we could do it that way too15:08
bswartzIMO if we're doing the tag anyways, there's no reason not to include obviously low risk changes along with it15:08
*** cknight has joined #openstack-manila15:09
*** zhonghua2 has joined #openstack-manila15:10
bswartzI'm also thinking of the windows driver fix15:10
bswartzin fact we should get those bugs targetted so we don't forget15:11
bswartzanyone have a link to the windows driver bug?15:11
*** zhonghua has quit IRC15:12
bswartznm15:14
openstackgerritMerged openstack/manila master: Fix to use correct config options for network_for_ssh  https://review.openstack.org/43407015:14
openstackgerritRodrigo Barbieri proposed openstack/manila master: Update HNAS driver version history  https://review.openstack.org/43361315:14
*** JoseMello has joined #openstack-manila15:15
*** mtanino has joined #openstack-manila15:16
*** dustins has joined #openstack-manila15:36
*** dustins_ has joined #openstack-manila15:42
*** dustins has quit IRC15:45
*** chlong has joined #openstack-manila16:04
marksturgouthamr: ping16:07
gouthamrmarkstur: pong16:10
marksturgouthamr: Those reno patches that kind of mess up the previous release info.  Do we merge those as is or wait for some fix?  They don't look right as-is.16:12
gouthamrmarkstur: bswartz thinks we should merge and investigate16:14
bswartzmarkstur: I don't care either way -- fixing broken renos isn't a priority for me -- that infrastructure appears to be fragile and owned by someone else16:17
*** dschoenb__ has joined #openstack-manila16:24
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Only return share host for admins  https://review.openstack.org/43371616:25
marksturgouthamr: OK.  Merge first and ask questions later.  Is that how the saying goes?16:26
marksturbut it makes sense to me if we don't have some fix in the works that should go in first16:26
*** dustins_ has quit IRC16:27
*** faizy has quit IRC16:28
*** tommylikehu_ has quit IRC16:29
*** crushil has quit IRC16:29
*** crushil has joined #openstack-manila16:29
openstackgerritMerged openstack/manila-ui master: Update reno for stable/ocata  https://review.openstack.org/42590716:32
*** sandanar has quit IRC16:36
*** arnewiebalck_ has joined #openstack-manila16:38
*** arnewiebalck has quit IRC16:40
*** arnewiebalck_ is now known as arnewiebalck16:40
*** akapil_ has joined #openstack-manila16:55
*** shausy has joined #openstack-manila16:59
*** akapil has quit IRC16:59
*** akapil_ has quit IRC16:59
*** crushil has quit IRC17:01
*** crushil has joined #openstack-manila17:02
openstackgerritMerged openstack/python-manilaclient master: Update reno for stable/ocata  https://review.openstack.org/42590417:07
*** faizy has joined #openstack-manila17:09
*** jprovazn has quit IRC17:12
*** dustins_ has joined #openstack-manila17:14
*** dschoenb__ has quit IRC17:16
*** lpetrut has quit IRC17:19
*** shausy has quit IRC17:24
*** shausy has joined #openstack-manila17:24
*** chlong has quit IRC17:24
*** porrua has quit IRC17:25
*** dsariel has quit IRC17:29
bswartzganso: ping17:34
gansobswartz: pong17:34
bswartzganso: I'm seeing migration tests fail on my system -- do migration tests required anything exltra?17:34
bswartzextra*17:34
gansobswartz: which exactly? I just found a bug in migration17:35
bswartzlike do I need nova or neutron or cinder for migration tests to pass?17:35
bswartztesting with manila lvm driver17:35
gansobswartz: a single test failed or all of them?17:35
bswartz3 tests17:35
gansobswartz: which ones?17:35
bswartzmanila_tempest_tests.tests.api.admin.test_migration.MigrationCancelNFSTest.test_migration_cancel_1_True[backend,positive]17:36
bswartzmanila_tempest_tests.tests.api.admin.test_migration.MigrationTwoPhaseNFSTest.test_migration_2phase_1_True[backend,positive]17:36
bswartzmanila_tempest_tests.tests.api.admin.test_migration.MigrationWithShareExtendingNFSTest.test_extend_on_migrated_share_1_True[backend,positive]17:36
gansobswartz: did test_migrate_share_to_no_snapshot_capability_share_type pass?17:36
bswartz{0} manila_tempest_tests.tests.api.admin.test_migration.MigrationWithDifferentSnapshotSupportNFSTest.test_migrate_share_to_snapshot_capability_share_type_1_True [40.915820s] ... ok17:37
gansobswartz: o_O17:38
gansobswartz: well, gotta debug to find out the problem17:39
gansobswartz: if test_migrate_share_to_no_snapshot_capability_share_type passed, then it is probably working17:39
bswartzganso: more detail here: https://paste.fedoraproject.org/559026/71803561/17:39
gansobswartz: it wouldn't have if configuration was wrong17:39
bswartzgah! bad line wrapping is bad17:39
gansobswartz: and test_migrate_share_to_no_snapshot_capability_share_type is the one that has the bug I found lol17:39
gansobswartz: so it should not be passing at all17:39
bswartzoh fpaste allows you to unwrap lines17:40
bswartz+1 fpaste17:40
gansobswartz: gotta check the screen logs17:40
bswartzganso that's what I was afraid of17:40
bswartzganso: this tell you anything? https://paste.fedoraproject.org/559028/80530148/17:42
bswartzwhat is 50.50.50.50?17:42
*** porrua has joined #openstack-manila17:42
bswartzand what is 51.51.51.51?17:43
bswartzare these IPs coming from tempest or devstack?17:43
gansobswartz: those are fake access rules17:44
gansobswartz: migration test attempts to migrate a share which has access rules17:44
gansobswartz: and the rules should be migrated as well17:44
gansobswartz: looking at that trace17:44
gansobswartz: migration_start is trying to cast the rules to readonly17:44
*** faizy has quit IRC17:45
bswartzfwiw all the exports on my test system are to 51.51.51.5117:46
bswartzanyone remember the command to 1 a single tempest test?17:46
bswartzvponomaryov: ^17:46
bswartzto run a single tempest test17:46
gansobswartz: tox -eall-plugin manila_tempest_tests.tests.api.admin.test_migration -- --concurrency=1 | tee test2.log17:47
gansobswartz: it is invoking LVM driver update_access with parameters add_rules=[] and delete_rules=[]17:47
gansobswartz: which makes the driver remove all rules and add them again in RO17:47
gansobswartz: so, it is trying to remove 50.50.50.50, and it failed17:48
gansobswartz: it could have failed because it wasn't there17:48
bswartzganso: where is the flakiness most likely?17:49
bswartztest error, manila error, or environment error?17:49
gansobswartz: I am thinking why it wouldnt be there... like some sort of concurrency17:49
bswartzI ran with concurrency=117:49
gansobswartz: ok, no concurrency17:50
gansobswartz: well, I have no idea then how the rule was not there, or why the command just failed17:50
gansobswartz: it does not say why it failed17:50
gansobswartz: ProcessExecutionError: Unexpected error while running command.17:51
bswartzikr17:51
bswartzthat's pretty crappy error reporting17:51
*** crushil has quit IRC17:51
gansobswartz: 6 times the same error17:51
gansobswartz: I guess it can't be a coincidence17:51
bswartzyet another reason to rewrite the access helper for lvm17:51
*** crushil has joined #openstack-manila17:51
gansobswartz: 3, in fact17:52
gansobswartz: messages are repeated17:52
bswartzganso: in the gate, how many backends do we run with?17:52
gansobswartz: 217:52
bswartzand the migration always goes between the backends right?17:53
bswartzwe never migration back to the same pool?17:53
bswartzmigrate*17:53
gansobswartz: currently, no17:53
gansobswartz: Yogesh may have added a test that migrates to the same pool17:53
gansobswartz: I am not sure17:53
bswartzhttps://paste.fedoraproject.org/559038/18135114/17:56
bswartzthat's all the commands run when I did the single tempest test17:56
*** crushil has quit IRC17:56
*** crushil has joined #openstack-manila17:56
bswartzthere are 2 errors 3 seconds apart17:57
bswartzgeez these logs are hard to read17:58
gansobswartz: still no way to guess the reason for that18:02
gansobswartz: if you could add a log line before the execute18:03
gansobswartz: that prints the content of /etc/exports18:03
gansobswartz: we could figure out if the rule was there18:03
bswartzyeah18:03
bswartzstill this isn't happening on the gate which points to something about my system18:04
gansobswartz: yes18:04
bswartzgah18:06
bswartzthe LVM driver has no debug logic whatsoever18:06
*** lpetrut has joined #openstack-manila18:07
bswartzganso: added the debug and ran again18:11
*** shausy has quit IRC18:11
bswartzthat export did exist at the time the exportfs -u command was invoked18:11
*** shausy has joined #openstack-manila18:12
bswartzganso: I worry there's a timing issue here, despite the lack on concurrency18:14
bswartzlack of concurrency18:14
*** xyang_ has quit IRC18:14
gansobswartz: lol we need concurrency for it to work, let's remove tooz and locks :P18:14
bswartzI wonder if it's possible that commands are getting sent too fast18:14
bswartznooooo18:14
*** JoseMello has quit IRC18:15
gansobswartz: if the rule was there, why did the command fail?18:15
gansobswartz: maybe you should add -v to the exportfs command18:15
gansobswartz: exportfs -vu18:15
bswartzwhat would that do?18:15
gansobswartz: verbose18:16
gansobswartz: maybe improve error message18:16
bswartztrying...18:16
bswartzokay the exportfs error might be a red herring18:18
bswartzit looks like the failure occurs before then, and that particular error is the cleanup logic failing to cleanup18:18
gansobswartz: but it is in migration_start18:19
gansobswartz: it could be that the test adds the rule18:19
gansobswartz: but does not wait for the rule to be added18:19
bswartzoh wait18:19
gansobswartz: so it invokes migration_start18:19
bswartzhttps://paste.fedoraproject.org/559044/87182783/18:19
bswartzexportfs -vu does cause a message to get printed18:20
bswartzhowever the message indicates success while the exit code indicates failure18:20
bswartzganso: are there any config options I need to be setting related to LVM and migration?18:21
gansobswartz: the data_node_access_ip18:21
bswartzI'm not running devstack-gate and I'm not using the pre/post hooks18:22
bswartzI'm just running bare devstack and tempest with my own config18:22
gansobswartz: but it is not even reaching the Data service part18:22
bswartzokay that value is getting set correctly by default18:23
bswartzoh no I just had a really dark thought18:25
bswartzI'm not running the normal ubuntu nfs-utils, I'm running my own compiled versions18:26
bswartzwhat if there's a bug in my exportfs binary?18:26
* bswartz smh18:26
*** shausy has quit IRC18:27
gansobswartz: that's a possibility18:27
bswartztesting that theory will require rebuilding my base image18:28
*** shausy has joined #openstack-manila18:28
bswartzrebuilding now...18:29
*** shausy has quit IRC18:36
bswartz20 minutes to rebuild...18:51
bswartzrestacking now18:51
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix migration_success before completing  https://review.openstack.org/43446218:51
*** yumiriam has quit IRC19:03
*** pcaruana has quit IRC19:03
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix migration_success before completing  https://review.openstack.org/43446219:06
bswartzganso: unbelievable! I reverted my nfs-utils to the ubuntu version and the test failures went away19:13
gansobswartz: that's very good! :D19:15
gansobswartz: and bad at the same time19:15
bswartzit's good for this bug, bad for future work on ipv619:15
gansobswartz: as that nfs-utils was going to be required for ipv6, right?19:15
bswartzganso: yes19:15
bswartzganso: the ubuntu guy are unlikely to give us a decent nfs-utils until zesty+119:17
gansobswartz: yep19:18
gansobswartz: as they haven't so far19:18
bswartzganso: well debian stretch has a newer version, and stretch just became "stable" last week19:19
bswartzso ubuntu should start pulling packages from there for zesty+119:19
gansobswartz: but does this newer include what we need for ipv6?19:20
bswartzganso: yes by a lot19:20
bswartzhowever it's unknown what regressions the new package might cause19:20
bswartzhere we just found 1 hidden regression caused by me compiling my own version19:21
*** chlong has joined #openstack-manila19:36
*** xyang_ has joined #openstack-manila19:40
*** chlong has quit IRC19:51
*** xyang_ has quit IRC19:54
*** wiebalck has joined #openstack-manila20:02
*** xyang_ has joined #openstack-manila20:04
*** xyang_ has quit IRC20:11
*** akapil has joined #openstack-manila20:14
*** xyang_ has joined #openstack-manila20:17
*** akapil has quit IRC20:19
gansobswartz, gouthamr: maybe we can include this one in RC2 as well? https://review.openstack.org/#/c/434462/20:25
*** fishbone has joined #openstack-manila20:29
*** wiebalck has quit IRC20:31
*** timcl has joined #openstack-manila20:37
*** xyang_ has quit IRC20:39
*** xyang_ has joined #openstack-manila20:39
bswartzganso: that's a big change that hasn't even been reviewed and merged in master20:40
bswartzlet me read the bug report20:40
bswartzokay can you explain where exactly this can affect users negatively?20:41
gansobswartz: the change is not very big20:42
gansobswartz: and users are unlikely to notice if no errors occur20:42
bswartzganso: am I looking at the wrong change?20:42
bswartzI see 44 lines in manager.py20:43
gansobswartz: but if an error occurs after the task_state is set to migration_success, and before it is actually completed, it will be an inconsistent state20:43
gansobswartz: yes 44 lines, not very big20:43
bswartz6 separate edits20:43
bswartzmy point is that it's not trivially safe -- this change affects logic20:44
gansobswartz: also, there is a slightly big window of chance the user can invoke migration_complete twice causing problems20:44
gansobswartz: well, it is ok to backport after Ocata release20:44
bswartzupon closer inspection it looks like you copy/pasted some code around20:45
gansobswartz: yes, I moved code, basically20:45
bswartzLet's focus on merging in master20:45
bswartzand revisit the decision to backport when we're getting ready for RC220:46
bswartzI'd like risk assessments from others too20:46
gansobswartz: RC2 is tomorrow, right?20:46
bswartzit's whenever we get the critical bug fixed20:47
gansobswartz: ok20:47
bswartzdue to the vagaries of the time-based release process it's possible for RC2 to not happen at all20:47
bswartzbut I'm hopeful we'll get it done tomorrow20:47
-openstackstatus- NOTICE: We're currently battling an increase in log volume which isn't leaving sufficient space for new jobs to upload logs and results in POST_FAILURE in those cases; recheck if necessary but keep spurious rebasing and rechecking to a minimum until we're in the clear.20:56
*** xyang_ has quit IRC21:12
*** xyang_ has joined #openstack-manila21:18
*** zhonghua2 has quit IRC21:19
*** zhonghua has joined #openstack-manila21:20
*** porrua has quit IRC21:20
*** dustins_ has quit IRC21:29
openstackgerritBen Swartzlander proposed openstack/manila-test-image master: Add fake sudo script  https://review.openstack.org/43452721:35
*** xyang_ has quit IRC21:36
*** xyang_ has joined #openstack-manila21:37
*** xyang_ has quit IRC21:40
*** lpetrut has quit IRC21:41
*** xyang_ has joined #openstack-manila21:42
*** cknight has quit IRC21:46
gouthamrganso: still around?21:49
gansogouthamr: yes21:50
gouthamrganso: hey! about https://review.openstack.org/#/c/434462/21:50
*** eharney_ has joined #openstack-manila21:50
*** eharney has quit IRC21:50
gouthamrganso: i still have the same concern i may have spoken to you about before the code merged in ocata/newton (don't remember)21:50
*** eharney_ is now known as eharney21:50
gouthamrganso: why can't we update the instance and the share in the same update..21:51
gouthamrganso: i.e, within the same sqlalchemy session21:51
gouthamrganso: i know share_instance_update currently doesn't do that.. but it feels like that's the fix we need21:51
*** crushil has quit IRC21:51
gansogouthamr: the first share instance update that sets the destination instance to available should be before attempting to delete the source instance, else the user will see the status "inactive" when listing the shares. Then later, when everything is complete, a share update is needed to set the task_state to migration_success21:52
gansogouthamr: so the timing of the updates is different, how can it be combined here?21:52
gouthamrganso: do it in the second update..21:57
gouthamrganso: currently, you have three round trips to the database..21:57
gouthamrganso: we can delete the source instance, get the list of updates we need based on the share type and update the destination instance and the share in one transaction22:01
gouthamrganso: for a brief unit of time, the user might see "migrating_to" -> however, i think that's alright22:02
gansogouthamr: ok I'll look into optimizing it tomorrow22:06
gansogouthamr: if we are okay with the user seeing "migrating_to", that could work22:06
gouthamrganso: sure.. this might be something to punt to "share migration pike improvements" if we want to not touch the database APIs...22:07
ganso gouthamr: it could be backported22:08
gansogouthamr: I guess22:08
gansogouthamr: looks simple enough22:08
gansogouthamr: I mean, for this patch, reduce a DB call22:08
gansogouthamr: for Pike, add a method that updates share_instance and share in one call22:08
gouthamrganso: yes... looks simple and we update share access rules the same way22:08
gansogouthamr: that would reduce one more22:08
gouthamrganso: only the ceph driver exercises that path.. but you can update an instance access mapping and share access mapping in one transaction22:09
gansogouthamr: if the user starts seeing migrating => migrating_to => available instead of migrating => available like it is today, then it is an APIImpact, right?22:10
gouthamrganso: it likely is..22:10
*** gouthamr has quit IRC22:22
*** eharney has quit IRC22:49
*** gouthamr has joined #openstack-manila22:53
*** catintheroof has quit IRC23:00
*** fishbone has quit IRC23:03
*** tommylikehu_ has joined #openstack-manila23:13
*** fishbone has joined #openstack-manila23:15
*** tommylikehu_ has quit IRC23:20
openstackgerritMerged openstack/manila master: Update HNAS driver version history  https://review.openstack.org/43361323:28
« Tuesday, 2017-02-14 Index Thursday, 2017-02-16 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!