Thursday, 2017-02-02

*** erlon has quit IRC00:00
*** ganso has quit IRC00:04
openstackgerritMerged openstack/manila-test-image: Support testing on Fedora  https://review.openstack.org/42680400:09
*** xyang1 has quit IRC00:12
*** esker has quit IRC00:19
*** tinwood has quit IRC00:20
*** tinwood has joined #openstack-manila00:21
*** esker has joined #openstack-manila00:41
*** openstackgerrit has quit IRC01:02
*** esker has quit IRC01:03
*** mtanino has quit IRC01:53
*** cdelatte has quit IRC02:19
*** kaisers_ has joined #openstack-manila02:53
*** kaisers has quit IRC02:56
*** mtanino has joined #openstack-manila03:20
*** gouthamr has quit IRC03:24
*** mtanino has quit IRC03:24
*** gaurangt has joined #openstack-manila03:36
*** test123 has joined #openstack-manila04:21
*** akapil has joined #openstack-manila04:21
*** test123 has quit IRC04:24
*** gaurangt has left #openstack-manila04:25
*** akapil has quit IRC04:25
*** gaurangt has joined #openstack-manila04:26
*** kaisers_ has quit IRC06:09
*** zhonghua2 has joined #openstack-manila06:10
*** zhonghua has quit IRC06:12
*** mnaser has quit IRC06:12
*** rhefner has quit IRC06:13
*** lpetrut has joined #openstack-manila06:18
*** kaisers has joined #openstack-manila06:30
*** mnaser has joined #openstack-manila06:35
*** tommylikehu_ has joined #openstack-manila07:04
*** lpetrut has quit IRC07:07
*** kaisers has quit IRC07:16
*** kaisers has joined #openstack-manila07:17
*** jprovazn has joined #openstack-manila07:25
*** lpetrut has joined #openstack-manila07:29
*** a-pugachev has joined #openstack-manila07:32
*** a-pugachev has quit IRC07:32
*** pcaruana has joined #openstack-manila07:39
*** pcaruana has quit IRC07:42
*** pcaruana has joined #openstack-manila07:43
*** nkrinner_afk is now known as nkrinner07:45
*** lpetrut has quit IRC08:07
*** lpetrut has joined #openstack-manila08:18
*** shausy has joined #openstack-manila08:22
*** openstackgerrit has joined #openstack-manila08:40
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui master: Fix Manage Replicas button availability  https://review.openstack.org/36872608:40
*** tommylikehu_ has quit IRC08:40
*** akapil has joined #openstack-manila08:41
*** akapil has quit IRC08:44
*** akapil has joined #openstack-manila08:51
*** lpetrut has quit IRC08:57
*** lpetrut has joined #openstack-manila09:01
*** lpetrut has quit IRC09:19
*** yumiriam has joined #openstack-manila09:48
*** ganso has joined #openstack-manila09:50
*** akapil has quit IRC09:56
*** makowals has quit IRC09:56
*** makowals has joined #openstack-manila09:59
*** akapil has joined #openstack-manila10:04
*** alyson_ has joined #openstack-manila10:10
*** makowals has quit IRC10:15
*** makowals has joined #openstack-manila10:26
openstackgerritRodrigo Barbieri proposed openstack/manila master: [DEBUG] Some CI testing  https://review.openstack.org/42676210:34
openstackgerritAlyson proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots  https://review.openstack.org/42807710:36
*** erlon has joined #openstack-manila10:45
*** a-pugachev has joined #openstack-manila10:48
openstackgerritMiriam Yumi proposed openstack/manila master: HNAS: Fix managed snapshots not being mounted  https://review.openstack.org/42761610:58
*** lpetrut has joined #openstack-manila11:01
*** makowals has quit IRC11:06
openstackgerritAlyson proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots  https://review.openstack.org/42807711:13
*** ociuhandu has quit IRC11:17
*** makowals has joined #openstack-manila11:19
*** akapil has quit IRC11:25
*** dsariel has quit IRC11:31
*** tinwood is now known as tinwood_afk11:44
*** dsariel has joined #openstack-manila11:44
*** akapil has joined #openstack-manila11:45
*** catintheroof has joined #openstack-manila11:47
jprovaznameade: hello11:48
*** akapil has quit IRC11:50
*** jcsp has quit IRC11:51
openstackgerritMerged openstack/manila-ui master: Fix Manage Replicas button availability  https://review.openstack.org/36872611:54
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766011:56
*** openstackgerrit has quit IRC12:03
*** akapil has joined #openstack-manila12:06
*** ociuhandu has joined #openstack-manila12:21
*** openstackgerrit has joined #openstack-manila12:21
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation  https://review.openstack.org/42781112:21
*** makowals has quit IRC12:44
*** makowals has joined #openstack-manila12:45
*** assassin has quit IRC12:52
*** ubijtsa has joined #openstack-manila12:52
*** ubijtsa has quit IRC12:52
*** ubijtsa has joined #openstack-manila12:52
*** ubijtsa is now known as assassin12:55
*** lseki has joined #openstack-manila12:59
*** gcb has joined #openstack-manila13:00
*** gouthamr has joined #openstack-manila13:12
*** jprovazn has quit IRC13:21
*** jprovazn has joined #openstack-manila13:23
*** eharney has quit IRC13:29
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation  https://review.openstack.org/42781113:32
*** shausy has quit IRC13:36
*** akapil has quit IRC13:45
openstackgerritValeriy Ponomaryov proposed openstack/manila master: Fix default approach for share group snapshot creation  https://review.openstack.org/42781113:46
*** crushil has quit IRC13:56
*** eharney has joined #openstack-manila14:02
*** dsariel has quit IRC14:04
*** gcb has quit IRC14:05
*** eharney has quit IRC14:07
*** akapil has joined #openstack-manila14:08
*** dustins has joined #openstack-manila14:09
vponomaryovrhagarty: according to your topic for weekly meeting, we have appropriate API and client method for it -> "$ manila -d api-version"14:11
vponomaryovrhagarty: doesn't it solve the needs you describe in topic?14:12
*** jcsp has joined #openstack-manila14:15
*** dustins has quit IRC14:17
*** dustins has joined #openstack-manila14:17
*** crushil has joined #openstack-manila14:19
*** eharney has joined #openstack-manila14:19
*** jprovazn has quit IRC14:21
*** jcsp has quit IRC14:27
*** xyang_ has joined #openstack-manila14:28
*** porrua has joined #openstack-manila14:28
vponomaryovrraja: Hello, are you aware that Ci job for "glusterfs-native" driver constantly fails?14:31
vponomaryovcsaba: ^14:32
*** jprovazn has joined #openstack-manila14:33
*** jprovazn is now known as jprovazn_14:33
*** jprovazn_ is now known as jprovazn14:33
csabavponomaryov: what I know that tbarron had invested some effort to fix it up, but I haven't synced up with him on that.14:33
openstackgerritMerged openstack/manila master: Decrease share migration periodic task interval  https://review.openstack.org/42709914:34
*** sandanar has joined #openstack-manila14:35
rrajavponomaryov: yes.14:35
*** jprovazn has quit IRC14:36
vponomaryovcsaba, rraja: tbarron is responsible for maintenance of this job now? Is it correct?14:37
rrajavponomaryov: I think it's csaba and I. tbarron has been helping out.14:39
vponomaryovcsaba, rraja: as I can see now from logs, job config requires update, based on this error in scheduler -> Share type extra spec requirement "create_share_from_snapshot_support=<is> False" does not match reported capability "True"14:39
bswartzvponomaryov: how many open bugs remain on share groups?14:39
vponomaryovbswartz: you mean targeted?14:40
vponomaryovto rc1&14:40
vponomaryov?14:40
rrajavponomaryov: we'll look into it. thanks for the pointer.14:40
bswartzvponomaryov: https://wiki.openstack.org/wiki/Manila/Meetings14:40
bswartzI put an agenda item for the meeting to discuss share groups remaining issues14:40
bswartzI'm sure I missed 1 or 2 known issues14:41
bswartzI'm going to propose disabling the APIs for Ocata until we fix the remaining bugs in Pike14:41
vponomaryovbswartz: disabling APIs?14:42
vponomaryovbswartz: first 2 are finished14:42
vponomaryovfrom list14:42
vponomaryovthird in netapp only and forth - even not sure14:43
bswartzYes I'm worried that leaving the API enabled will cause problems14:43
bswartzI'm writing some more bugs as I think of them14:43
*** crushil has quit IRC14:43
*** dustins has quit IRC14:43
*** crushil has joined #openstack-manila14:44
*** dustins has joined #openstack-manila14:44
bswartzmaybe all of the remaining issues are specific to the consistent_snapshot group type extra spec14:45
vponomaryovbswartz: we even haven't discussed group specs14:46
vponomaryovbswartz: I consider absence of group specs as expected for now14:47
rhagartyvponomaryov: does it consider that client might be out of sync with service? or do you think that is not an issue?14:48
vponomaryovrhagarty: what do you mean by "out of sync"?14:49
vponomaryovrhagarty: client requests root URL14:49
vponomaryovrhagarty: server ignores microversion14:50
vponomaryovrhagarty: and returns list of supported APIs with their microversions14:50
rhagartyvponomaryov: ok - I will try it out14:51
*** xyang_ has quit IRC14:53
rhagartyvponomaryov: what I meant by out of sync is the client might be older than service. Service might support 2.51, but older client doesn't have support for feature added in 2.44, for ex.14:55
vponomaryovrhagarty: how is it related to possibility to get list of supported microversions?14:55
*** xyang_ has joined #openstack-manila14:56
rhagartyvponomaryov: current microversion support is just returned by endpoint, without regard to what client version is14:57
rhagartyvponomaryov: am thinking this may become an issue as we add more and more features based on microversion. maybe not...14:59
vponomaryovrhagarty: your topic says "provide an easy way for other projects to know our current supported microversion?" - I mentioned the way it is possible now14:59
vponomaryovyou can get it now either from server directly or via client15:00
rhagartyvponomaryov: - from manila-ui perspective. let me play with it some15:00
rhagartyvponomaryov: ok - thanks. I will try it ot15:00
*** Yogi1 has joined #openstack-manila15:00
rhagartyot/ot15:00
gansogouthamr: Hi Goutham, could you please +W https://review.openstack.org/#/c/427101 ?15:00
rhagartyot/out15:00
bswartz--> #openstack-meeting-alt <--15:01
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766015:03
*** jprovazn has joined #openstack-manila15:04
*** tinwood_afk is now known as tinwood15:05
*** rraja_ has joined #openstack-manila15:06
*** rraja has quit IRC15:06
*** rraja_ has quit IRC15:11
openstackgerritMerged openstack/manila master: Fix setup of DHSS=False mode for generic driver  https://review.openstack.org/42673715:11
*** mtanino has joined #openstack-manila15:13
*** xyang_ has quit IRC15:16
*** xyang_ has joined #openstack-manila15:18
*** rraja_ has joined #openstack-manila15:20
*** jcsp has joined #openstack-manila15:22
*** rraja_ has quit IRC15:25
*** rraja_ has joined #openstack-manila15:25
*** breitz has quit IRC15:33
*** breitz has joined #openstack-manila15:34
*** sandanar has quit IRC15:36
*** rraja_ has quit IRC15:38
openstackgerritRodrigo Barbieri proposed openstack/manila master: Blocked migration of shares within share groups  https://review.openstack.org/42783415:38
openstackgerritMiriam Yumi proposed openstack/manila master: HNAS: Fix managed snapshots not being mounted  https://review.openstack.org/42761615:47
openstackgerritMerged openstack/manila master: Enable host-assisted migration in ZFSOnLinux CI  https://review.openstack.org/42710116:02
openstackgerritTom Barron proposed openstack/manila master: Do Not Merge  https://review.openstack.org/42823016:03
*** dsariel has joined #openstack-manila16:04
gansovponomaryov: if you could please +W the patches that you +2'ed, have 2 +2, green CI (basically all 4 of them), and there's nothing holding back, it would be great to merge asap so we can rebase asap if they end up conflicting with each other when merging. Here are the links: https://review.openstack.org/428077 https://review.openstack.org/42680616:13
gansohttps://review.openstack.org/#/c/427096 and https://review.openstack.org/42733216:13
bswartzganso: +116:14
bswartzget those merge conflicts out of the way!16:14
bswartz(hopefully not to many merge conflits between bugfixes)16:15
*** kberger has joined #openstack-manila16:25
*** xyang_ has quit IRC16:56
*** hoonetorg has quit IRC17:03
*** hoonetorg has joined #openstack-manila17:04
*** xyang_ has joined #openstack-manila17:06
*** xyang_ has quit IRC17:07
openstackgerritAlyson proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create  https://review.openstack.org/42826717:11
*** akapil_ has joined #openstack-manila17:15
openstackgerritMerged openstack/manila master: HNAS: Fix concurrency error when managing snapshots  https://review.openstack.org/42680617:17
openstackgerritMerged openstack/manila master: HNAS: avoid mismatch access level for managed shares  https://review.openstack.org/42709617:17
openstackgerritMerged openstack/manila master: Fix snapshot export locations incorrectly handled  https://review.openstack.org/42733217:17
*** mtanino_ has joined #openstack-manila17:18
*** mtanino__ has joined #openstack-manila17:19
*** akapil has quit IRC17:19
*** mtanino has quit IRC17:19
*** timcl has quit IRC17:19
*** akapil_ has quit IRC17:20
*** mtanino_ has quit IRC17:22
*** dsariel has quit IRC17:24
*** timcl has joined #openstack-manila17:24
*** xyang_ has joined #openstack-manila17:25
*** xyang_ has quit IRC17:26
*** hoonetorg has quit IRC17:38
*** chlong has joined #openstack-manila17:39
*** hoonetorg has joined #openstack-manila17:40
*** nkrinner is now known as nkrinner_afk17:41
marksturganso: https://review.openstack.org/#/c/428267/117:44
marksturganso: ^ what the heck?17:44
gansomarkstur: lol17:44
gansomarkstur: for HNAS we always make the share readonly17:45
gansomarkstur: when taking snapshots17:45
*** xyang_ has joined #openstack-manila17:45
marksturdoes user get stale mounts or just fail when trying to save stuff?17:45
marksturI mean is it really bad or just bad17:45
gansomarkstur: does not get stable mount at all17:46
gansomarkstur: *stale17:46
marksturThat is good.17:46
gansomarkstur: it is very seamless17:46
gansomarkstur: if application is writing to disc, it gets a "filesystem is read-only" message from the OS17:46
*** hoonetorg has quit IRC17:47
marksturSeriously, you do what you need to do, but I didn't know manila share might fail on write when someone takes a snap17:47
*** xyang_ has quit IRC17:47
marksturganso: So the app fails17:47
gansomarkstur: but this is very fast, as the create_snapshot operation is efficient by only creating links/references17:47
vponomaryovmarkstur: suddenly ))17:47
marksturor the write fails or the transaction fails, whatever17:47
vponomaryovmarkstur: I am surprised too )17:47
vponomaryovganso: why it just does not hand a bit?17:48
marksturwell if it is so fast that nobody notices then it is not a problem  :)17:48
vponomaryovs/hand/hang/17:48
marksturIt is a "flash" snap17:48
* markstur looks to see if anyone is using "flash" for anything important or trademarks it17:48
gansovponomaryov, markstur: unfortunately, we cannot freeze/delay I/O with this mechanism... there is another mechanism that is capable of that, and it is consistent, but it takes snapshot of the whole filesystem...17:49
gansovponomaryov: "does not hand a bit" ? sorry I don't get the expression17:49
marksturI suppose it is one of those things where you get a support call and the support folks says "try again" and the write works, so they say call closed17:49
gansomarkstur: yes, kinda like that17:49
gansomarkstur: for CIFS it is more complicated17:50
vponomaryovganso:  "does not hanG a bit"17:50
* markstur grumbles17:50
gansovponomaryov: oh... as I said above, we cannot freeze/delay I/O in this mechanism17:50
vponomaryovganso: yeah, its ok ))17:50
gansomarkstur: for CIFS we have a config option to say "Error, please unmount your share when taking snapshots"17:51
marksturnice17:51
gansomarkstur: or, if option is not enabled, take snapshots anyway at your own risk17:51
gouthamrganso: typically, people go out and build stuff into the applications if applications have to be quiesced..17:52
marksturganso: ?  what do you mean option not enabled?  You mean outside of manila?17:52
vponomaryovganso: if your data stayed consistent, we are sorry, it is completely accidentally? ))17:52
gansomarkstur: in manila17:52
gouthamrganso: i feel there's no need to protect your share through manila17:52
gansomarkstur: in the config17:52
*** xyang_ has joined #openstack-manila17:52
marksturcreate snapshot --lossy-is-fine17:53
gansogouthamr: we don't know how it is used for, so without much effort, we added a little config option17:53
gansocreate snapshot --i-dont-care-if-it-is-consistent17:53
gouthamr:P17:53
marksturganso: I'm a fan of toggles. If they want to turn it off, then good.17:53
*** xyang_ has quit IRC17:54
marksturganso: put a ' in don't. So you have to be an advanced user to escape it properly17:54
gansomarkstur: good, it will be an option only for advanced users17:55
marksturSo ultimately I think we hopefully don't need more snapshot options (that was so ocata) but perhaps this superfast glitch is just something that maybe is an HNAS bug(?) so a "known limitation" which may or may not ever get fixed17:56
*** lpetrut has quit IRC17:56
vponomaryovmarkstur: GPFS is not like that? ))17:57
vponomaryovmarkstur: how is it done there?17:57
*** xyang_ has joined #openstack-manila17:57
marksturvponomaryov: Hey! What?17:57
vponomaryovmarkstur: snapshotting and access to share being snapshotted at once?17:57
marksturOh.  I haven't seen any problem snapshotting while accessing, but maybe I wouldn't know yet.17:58
marksturI'd assume most have figured out how to do live snaps, but...17:58
marksturexactly how consistent and "crash-consistent"' does vary17:58
*** hoonetorg has joined #openstack-manila17:59
bswartzcrash consistent is a bare minimum standard17:59
gansomarkstur: it is a known limitation at this moment, it is documented17:59
*** xyang_ has quit IRC18:00
marksturvponomaryov: "o run concurrently with user updates and still obtain a consistent copy of the file system as of the time the copy was created'18:01
* markstur sees no shenanigans in gpfs18:02
vponomaryovmarkstur: which approach is used? temp I/O freeze?18:02
marksturvponomaryov: How did this friendly conversation turn on me?18:02
vponomaryovmarkstur: ^_^18:03
vponomaryovmarkstur: nice trick to say "don't know" )018:03
marksturignorance is bliss18:04
marksturSo it does a flush, quiesce, flush-again, snap.  I wonder if it is ever possible that it takes too long and the writer can catch an error.18:06
*** xyang_ has joined #openstack-manila18:06
*** a-pugachev has quit IRC18:09
vponomaryovmarkstur: you just won a prise! you can be the first person marking this commit https://review.openstack.org/#/c/427811/ with +2, hurry up! Don't miss your chance!18:09
marksturvponomaryov: Will look at it later. First I need to reply to a Nigerian prince who wants me to help him with his money.18:10
markstur... and buy a timeshare18:11
gansomarkstur: LOL that's a classic one18:11
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766018:11
*** akapil has joined #openstack-manila18:14
openstackgerritAlyson proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create  https://review.openstack.org/42826718:14
vponomaryovmarkstur: I am aware about nice timeshares in Ukraine, lots of nice places, and it is completely cheap! =)18:15
vponomaryovmarkstur: look, chances are around you!18:16
markstur:)  OK I'm looking at the patch18:16
vponomaryovmarkstur: good choice18:18
vponomaryovmarkstur: I should admit you have really good taste of excellence, very good choice18:19
gansomarkstur: Mark, Alyson and I discussed about not needing a reno18:21
gansomarkstur: see my previous comment in patch https://review.openstack.org/#/c/42826718:21
gansomarkstur: with the bug or bugfix, the snapshot is the same... the only difference is that the application does not get an error message18:23
marksturusually gouthamr is the reno enforcer18:24
*** akapil has quit IRC18:26
gansomarkstur: https://review.openstack.org/#/c/427616/ is ready18:28
gansovponomaryov: https://review.openstack.org/#/c/427834/ is ready18:28
vponomaryovganso: what ELSE i can do for you with this change?18:29
vponomaryovganso: bless it for successful merge? ))18:29
gansovponomaryov: lol sorry my page was stale I did not notice18:30
gansovponomaryov: but blessing it would be nice18:30
marksturI think ganso has hit some quota limit for today18:30
* markstur goes back to reviewing Valeriy's TODOs18:30
vponomaryovmarkstur: those todo in 5 words - "make it prety, but later"18:32
markstur-1 s/prety/pretty/18:32
vponomaryovjust typo18:32
vponomaryovhave a mercy18:32
gouthamrvponomaryov: have a minute to talk about a related concern?18:33
vponomaryovgouthamr: sure18:33
vponomaryov gouthamr: go ahead18:33
bswartzgouthamr: are you out of your meeting yet?18:33
gouthamrvponomaryov: how can you tell if a share group supports consistent snapshots?18:33
vponomaryovgouthamr: you mean right now, with current code?18:34
gouthamrbswartz: not yet.. multitasking :P18:34
gouthamrvponomaryov: i.e, i can look at the group type extra specs...18:34
vponomaryovgouthamr: not planned?18:34
vponomaryovgouthamr: we do not have group type specs defined yet18:34
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766018:34
vponomaryovgouthamr: I guess, it is PTG topic18:34
vponomaryovgouthamr: to define it18:34
gouthamrvponomaryov: but you can change group type extra-specs :(18:35
gouthamrvponomaryov: can we do what we're doing with shares, right now18:35
vponomaryovgouthamr: yes, we have mechanism18:35
vponomaryovgouthamr: just do not use it atm18:35
bswartzgouthamr: no worries, I want to make that API change we talked about18:36
gouthamrvponomaryov: because it's a DB migration that you can't back-port18:36
gouthamrbswartz: oh.. the one about the access rules change?18:37
vponomaryovgouthamr: backport? I guess it should have some context18:37
vponomaryovgouthamr: the thing you are talking about18:37
gouthamrvponomaryov: you can make a group that supports consistent snapshots18:37
gouthamrvponomaryov: then go back and change that group18:37
vponomaryovgouthamr: addon of a member is change too18:37
bswartzgouthamr: locking out reverts on shares undergoing access rules updates18:37
gouthamrvponomaryov: change the group-type*18:38
gouthamrbswartz: +118:38
bswartzgouthamr: I need to know exactly what field I should be looking at18:38
vponomaryovgouthamr: such vulnerability we have for share types too18:38
gouthamrvponomaryov: which we solved with share capability fields18:39
gouthamrbswartz: "access_rules_status"18:39
vponomaryovgouthamr: right, but we should "decide" what exactly should it be for groups18:40
vponomaryovfirst18:40
vponomaryovthen implement18:40
vponomaryovit is more than one cycle of efforts for such big feature18:40
vponomaryovand it is expected18:41
gouthamrvponomaryov: i'd call it "consistent_snapshot_support"18:41
vponomaryovgouthamr: keep for PTG ))18:41
vponomaryovor add notes in etherpad )18:41
gouthamrvponomaryov: will do.. but wanted to know if we can do it now.. because adding a new field requires a DB migration18:43
vponomaryovgouthamr: I don't mind18:43
gouthamrvponomaryov: as we discussed today, we won't shy away from fixing all the bugs now, even if we turn off the APIs18:43
bswartzvponomaryov: gouthamr is asking us to fast track this one extra spec because it we can get it into ocata it makes possible other bugfix backports18:43
bswartzI'm neutral on whether it's a good idea18:44
vponomaryovbswartz: I understood18:44
bswartzI don't see any harm in it but the gain is also pretty minimal18:44
vponomaryovredundant field, if it is redundant don't make harm18:44
gansovponomaryov: can we get db migration export locations for group_snapshots  as well?18:45
vponomaryovganso: why?18:45
vponomaryovganso: I was thinking about it18:45
gansovponomaryov: so we can backport to ocata18:45
gansovponomaryov: cool18:45
vponomaryovganso: and came to idea, that it will be too much18:45
gansovponomaryov: thx18:45
gansovponomaryov: (((((((((((((((((((((((((((((((((((18:46
vponomaryovganso: we just do not support mountable snapshots in groups as of Ocata18:46
vponomaryovganso: it could be developed for CGs18:46
openstackgerritMerged openstack/manila master: Blocked migration of shares within share groups  https://review.openstack.org/42783418:46
gansovponomaryov: but you have regular snapshots, in groups...18:46
vponomaryovganso: it does not mean we have wide support of mountable snapshots18:47
vponomaryovto implement it so late18:47
vponomaryovit is feature18:47
gansovponomaryov: ok18:47
vponomaryov"provider_location" is a must18:47
vponomaryovbecause some drivers , like HNAS, will not work without it, right?18:48
*** xyang_ has quit IRC18:48
*** xyang_ has joined #openstack-manila18:50
vponomaryovganso: https://review.openstack.org/#/c/427660/5..6/manila/share/drivers/hitachi/hnas/ssh.py -> hiding trace you may not get know that you could search share with typo'ed share name18:52
vponomaryovganso: it is always useful to have a trace18:52
gansovponomaryov: I replied your comment18:52
vponomaryovganso: I see, I amreplying to reply here )18:52
vponomaryovganso: will you reply to my reply for your reply? )18:53
gansovponomaryov: sorry I don't understand what the error scenario is18:53
gansovponomaryov: what you just said above18:53
vponomaryovganso: you get there "not found"18:53
gansovponomaryov: y18:53
gansovponomaryov: *yes18:53
vponomaryovganso: I am saying, that you could get "false" not found because of bug18:53
gansovponomaryov: what bug?18:54
vponomaryovganso: which is typo in name you search with18:54
gansovponomaryov: the error message prints the share_name18:54
gansovponomaryov: in LOG.error18:54
vponomaryovit is separately created18:54
vponomaryovnot the command you used18:54
vponomaryovso, having there "exception" you do not lose anything, just cover one more possible error case18:55
vponomaryovbut yes, since it is your driver and your head ache, I don't mind merge it as is now )18:55
gansovponomaryov: still not understanding the need for it, how is it separately from the command just created?18:56
vponomaryovganso: because you can log "proper" name, but search with wrong one indeed18:56
*** carthaca_ has quit IRC19:00
*** sapcc-bot has quit IRC19:00
*** eharney has quit IRC19:00
*** carthaca_ has joined #openstack-manila19:00
*** yumiriam has quit IRC19:00
*** dgonzalez_ has joined #openstack-manila19:00
*** sapcc-bot has joined #openstack-manila19:00
*** tpatzig_ has joined #openstack-manila19:00
*** ociuhandu has quit IRC19:01
*** dgonzalez_ has quit IRC19:02
*** tpatzig_ has quit IRC19:02
gansovponomaryov: sorry I got pulled... so I use my string to search, how am I seeing the "proper" name anywhere? The string I search is the one I log19:05
vponomaryovganso: ok, forget, you have +2 there19:07
*** lpetrut has joined #openstack-manila19:08
*** porrua has quit IRC19:08
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766019:09
*** cknight has joined #openstack-manila19:12
openstackgerritMerged openstack/manila master: HNAS: Fix managed snapshots not being mounted  https://review.openstack.org/42761619:14
openstackgerritRodrigo Barbieri proposed openstack/manila master: HNAS: Fix syntax to make shares read-only in snapshot create  https://review.openstack.org/42826719:24
gansomarkstur: rebase hell19:26
marksturvery busy hnas today19:27
*** ociuhandu has joined #openstack-manila19:28
marksturgit rebase failed with "commit failed. Repo is read-only while snapshot in progress."19:35
*** xyang_ has quit IRC19:37
*** eharney has joined #openstack-manila19:37
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766019:38
gansomarkstur: :P19:38
*** mtanino__ has quit IRC19:39
*** xyang_ has joined #openstack-manila19:39
openstackgerritYogesh proposed openstack/manila master: Improve test coverage for share migration  https://review.openstack.org/41855919:41
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver always handling mountable snapshots  https://review.openstack.org/42807719:41
bswartzganso markstur xyang vponomaryov cknight toabctl gouthamr tbarron: http://imgur.com/a/Thb5f19:45
bswartzfeedback?19:46
gouthamr:P I like it19:46
marksturSQUIREL!19:46
gouthamrnot a skunk19:47
gouthamr:P19:47
marksturit is a little weasely. I might like a skunk better.  But it is not bad.19:47
gouthamrxyang_ ^19:47
bswartzI didn't want a skunk19:47
marksturlooks a little like a honey badger  :)19:47
bswartzI think they did a good job of making it non-skunky19:48
gouthamrmarkstur: ikr...19:48
marksturbswartz: Is there a scratch-and-sniff version?19:48
openstackgerritBen Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert  https://review.openstack.org/42839819:50
bswartzganso: ^ if you want a preview of how I'm trying to fix LVM revert19:51
gansobswartz: looking19:53
*** a-pugachev has joined #openstack-manila19:57
gansobswartz: did you forget to upload the ugly part?19:57
bswartzganso: haven't tested it yet19:58
gansobswartz: oh19:58
bswartzwhat's ugly is what will happen inside the LVM driver19:58
bswartzganso: also I need to add a couple of lines to api/v2/shares.py19:58
gansobswartz: it's not different than what I expected... remove all rules... add them back19:58
gouthamrganso:  a likely migration/mount-snapshot-support bug when you have a min19:59
gansogouthamr: sure19:59
gouthamrganso: so, firstly, snapshot-instance-export locations aren't being updated from the driver after migrate19:59
bswartzgouthamr ganso: if you find any new bugs add them to LP immediately so we can track RC1 status19:59
gouthamrbswartz: yep.. will confirm with ganso and add it20:00
gansogouthamr: yea... bug20:00
gouthamrganso: secondly, if we wanted to add that, it'd be a couple of lines of a code-fix, but  then we need to get into the intricacies of whether we should allow export locations to be set, depending on whether we have the mount-snapshot-support capability in the destination share type20:01
gansogouthamr: hold on you lost me on "allow export locations to be set"20:01
gansogouthamr: why wouldn't we? it is the same as provider location update20:01
gouthamrganso: this is wrt your recent bugfix.. https://review.openstack.org/#/c/427332/20:02
gouthamrganso: we can't allow export-locations to be updated by the driver if the destination share type doesn't need it20:02
gansogouthamr: yes, we just wouldn't show at the API20:02
gansogouthamr: the driver wouldn't return export locations if it doesn't support20:03
gansogouthamr: and we would handle it like this https://review.openstack.org/42733220:03
gouthamrganso: in that bugfix, you fixed it such that we'd ignore the driver's update..20:04
gansogouthamr: yes20:04
gouthamrganso: drivers don't have the destination share type to tell whether export locations should be updated20:04
gansowe would do the same20:04
gansogouthamr: oh right20:04
gansogouthamr: wait I handled that20:04
gansogouthamr: just a sec20:04
gouthamrganso: well, we have the share-type-id, we can call into the DB code if we wanted to20:05
* gouthamr bswartz: smh20:05
gansogouthamr: https://github.com/openstack/manila/blob/master/manila/share/manager.py#L132120:05
gouthamrganso: yah, that's too late, we'd need to bubble up snapshot updates20:06
bswartzgouthamr: ?20:06
gansogouthamr: no no, I am saying I'd handle the same way20:06
gansogouthamr: we have snapshot instances20:06
gansogouthamr: we pass the snapshot_dict20:06
gansogouthamr: the snapshot_dict contains mount_snapshot_support20:06
gansogouthamr: we pass the destination snapshot instance to drivers20:07
gansogouthamr: so they will have that info20:07
gouthamrbswartz: was just typing "smh" for you based off my sentence before that, lol20:07
bswartzwhat did we miss here?20:07
bswartzexport locations of snapshots after a migration?20:08
gansobswartz: yes20:08
gouthamrbswartz: yes..20:08
gansobswartz: cooperation between mountable and migration features20:08
* bswartz smh20:08
gouthamrganso: mount_snapshot_support is in the share model..20:08
gouthamrlol20:08
bswartzis it not just more model updates?20:08
gouthamrbswartz: it's teh question of selective updates..20:09
* ganso wonders why smh means... googles it... finds "shake my head"20:09
* ganso is still confused20:09
bswartzshaking my head20:09
gansogouthamr: it is, but...20:09
bswartzthe nonverbal version of "no"20:09
gansogouthamr: it is proxified20:10
gansogouthamr: and snapshot['share'] is a share_instance20:10
gansogouthamr: which can do snapshot['share']['mount_snapshot_support'] to read the proxified property20:10
gansogouthamr: and that would not work because it would read the old value20:10
gansogouthamr: :\20:11
gouthamrganso: last i saw, it wasn't... https://bugs.launchpad.net/manila/+bug/166082520:11
openstackLaunchpad bug 1660825 in Manila "Share capabilities are missing from share instance model" [Undecided,New]20:11
gouthamrganso: it's a low priority bug since nothing needs it.. ^20:11
gouthamrganso: but you're right.. proxying doesn't work for this, because we need the new share type20:12
gansogouthamr: https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L34120:12
gouthamrganso: ah, nice. you did the right thing.. but we didn't do that for revert_to_snapshot_support, snapshot_support and csfss20:12
* gouthamr counts typos in above sentence.. no typos. yay.20:13
gansogouthamr: if I did, vponomaryov would come and -1 "unrelated change"20:13
gouthamrhaha20:13
gansogouthamr: I would mark it high priority though20:14
gansogouthamr: wait20:14
gouthamrganso: so i think we should call https://github.com/openstack/manila/blob/master/manila/share/share_types.py#L180 and update the export locations based on the share-type-id20:14
gansogouthamr: only NetApp and ZFS do driver assisted migration, and none of them do mountable snapshots20:14
gansogouthamr: so ok Low priority... although it breaks dummy driver :( poor dummy20:15
gouthamrganso: you'd be surprised if i told you which one did20:15
gouthamrganso: there you go20:15
*** lpetrut has quit IRC20:15
gansogouthamr: dummy will have to remain broken20:15
gansogouthamr: :P20:15
gansogouthamr: jk20:16
gouthamrganso: our all capable driver breaks on migration tests for snapshots.. and helps discover this important bug20:16
gansogouthamr: did Yogesh's patch find this?20:16
gouthamrganso: yep20:16
gansogouthamr: very cool20:16
gansogouthamr: did you suggest that drivers would call this? https://github.com/openstack/manila/blob/master/manila/share/share_types.py#L180]20:17
gouthamrganso: no, we'll do that in the manager code..20:17
gouthamrganso: allow the update selectively..20:17
gansogouthamr: ok and how would drivers figure out they need to return export locations?20:17
gouthamrganso: they probably shouldn't care.. do what they do for all snapshots20:20
openstackgerritBen Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert  https://review.openstack.org/42839820:22
bswartzgouthamr: https://review.openstack.org/#/c/428398/2/manila/api/v2/shares.py <-- going to test this now20:22
gansogouthamr: could you log the bug?20:23
gouthamrganso: yep.. will do20:25
gansobswartz: I'd do that check in share/api.revert_to_snapshot20:25
bswartzganso: what check?20:26
*** crushil has quit IRC20:26
bswartzganso: it's too late to do it there, we've already logged that the operation is happening20:26
*** crushil has joined #openstack-manila20:26
*** jprovazn has quit IRC20:32
*** makowals_ has joined #openstack-manila20:32
*** kaisers_ has joined #openstack-manila20:32
gouthamrganso: https://bugs.launchpad.net/manila/+bug/166138120:33
openstackLaunchpad bug 1661381 in Manila "Can't update snapshot instance export locations on completion of (driver assisted) migration" [High,New]20:33
*** makowals has quit IRC20:34
*** kaisers has quit IRC20:35
gansogouthamr: thanks20:42
gansobswartz: oh, revert performed all checks in v2/shares.py20:43
gansobswartz: I normally don't do that, but in that case, it is ok20:44
*** zhonghua2 has quit IRC20:50
*** zhonghua has joined #openstack-manila20:52
*** akapil has joined #openstack-manila21:00
*** harlowja has quit IRC21:00
openstackgerritRodrigo Barbieri proposed openstack/manila master: Fix HNAS driver inconsistent exceptions  https://review.openstack.org/42766021:05
*** alyson_ has quit IRC21:07
openstackgerritYogesh proposed openstack/manila master: Improve test coverage for share migration  https://review.openstack.org/41855921:09
*** catintheroof has quit IRC21:14
*** xyang_ has quit IRC21:15
*** catintheroof has joined #openstack-manila21:15
*** xyang_ has joined #openstack-manila21:17
*** xyang_ has quit IRC21:18
*** xyang_ has joined #openstack-manila21:18
*** catintheroof has quit IRC21:19
*** xyang_ has quit IRC21:20
*** sapcc-bot has quit IRC21:33
*** carthaca_ has quit IRC21:33
*** sapcc-bot has joined #openstack-manila21:35
*** tpatzig_ has joined #openstack-manila21:35
*** tpatzig_ has quit IRC21:37
gansogouthamr: do you have any idea how the dummy job got so unstable?21:40
gouthamrganso: what are the failures?21:41
gansogouthamr: every run is a different failure21:41
gouthamrganso: there's one we know and we've slated to talk about at the PTG21:41
gansogouthamr: I've seen several on revert tests21:41
gansogouthamr: but not this https://review.openstack.org/#/c/428267/ and https://review.openstack.org/#/c/428077/ are different21:41
gouthamrganso: https://bugs.launchpad.net/manila/+bug/1631314 <-- this one21:42
openstackLaunchpad bug 1631314 in Manila "Tempest test "test_promote_out_of_sync_share_replica" is concurrency-prone" [High,Confirmed] - Assigned to Goutham Pacha Ravi (gouthamr)21:42
gouthamrganso: failure on https://review.openstack.org/#/c/428267/ is the bug ^21:43
*** Yogi1 has quit IRC21:43
gouthamrganso: http://logs.openstack.org/77/428077/3/check/gate-manila-tempest-minimal-dsvm-dummy-ubuntu-xenial/eee927a/console.html <-- seeing this for the first time.. will take a look21:43
*** cknight has quit IRC21:52
openstackgerritBen Swartzlander proposed openstack/manila master: [WIP] Pass access rules to driver on snapshot revert  https://review.openstack.org/42839821:53
*** porrua has joined #openstack-manila21:55
*** xyang_ has joined #openstack-manila22:02
*** xyang_ has quit IRC22:03
openstackgerritTom Barron proposed openstack/manila master: Do not merge  https://review.openstack.org/42846322:05
*** akapil has quit IRC22:07
openstackgerritTom Barron proposed openstack/manila master: Do Not Merge  https://review.openstack.org/42823022:07
*** breitz has quit IRC22:14
*** xyang_ has joined #openstack-manila22:18
*** crushil has quit IRC22:19
*** harlowja has joined #openstack-manila22:25
*** breitz has joined #openstack-manila22:26
*** harlowja has quit IRC22:32
*** harlowja has joined #openstack-manila22:33
*** dustins has quit IRC22:39
*** erlon has quit IRC22:40
*** kaisers_ has quit IRC22:47
*** mtanino has joined #openstack-manila22:51
-openstackstatus- NOTICE: Restarting gerrit due to performance problems22:51
*** lseki has quit IRC23:00
bswartzganso xyang vponomaryov cknight toabctl tbarron: still curious if you have any issues with: http://imgur.com/a/Thb5f23:20
*** xyang_ has quit IRC23:26
openstackgerritBen Swartzlander proposed openstack/manila master: Pass access rules to driver on snapshot revert  https://review.openstack.org/42839823:31
*** gouthamr has quit IRC23:33
*** a-pugachev has quit IRC23:42
gansobswartz: it could use a brigher brown23:45
gansobswartz: s/brighter/lighter23:45
gansobswartz: so it is more distinguishable from the black23:45
bswartzganso: your color contrast on your monitor might be off23:46
bswartzit looks pretty light to me23:46
gansowhoa23:46
gansobswartz: lemme try on my cell phone23:46
gansobswartz: same23:47
gansobswartz: I mean, it is distinguishable, but I suppose we are going to have T-shirts, caps, stickers, etc, and I think it would be better if it is a little lighter23:47
marksturI actually would have gone with blue or something colorful, but brown is OK23:52
marksturI think the contrast is fine.  I just thought other colors would be more cartoony which I think is the style they are using23:52
marksturbrown is kind of real23:52
marksturcould be a Manila Mink23:52
marksturbut I left that varmint up on my monitor for a while and I'll add that the more I saw it the more I liked it. It grows on you23:53
gansomarkstur: which animal is our mascot again? I forgot the real name, all I can remember is that it is similar to skunk23:53
marksturManila Zorilla23:53
gansomarkstur: zorilla!23:53
gansomarkstur: thanks23:54
marksturganso: Don't let bswartz hear you say similar to skunk!23:54
gansomarkstur: lol23:54
gansobswartz: ok so comparing to google images of zorillas23:54
markstur^ that's good research there23:55
gansobswartz: I think it should have have a grayer tone instead of brownish23:55
gansobswartz: and should have some white detail on its head23:55
gansobswartz: maybe if it was drawn a bit in perspective, or with its head turning, it would be able to draw some white detail on its head23:56
gansobswartz: because right now the ear is covering that23:56
* ganso is aware of why people usually regret asking for his opinion on something23:57
marksturhttp://giphy.com/gifs/pepe-J6edbjeFkeoJa23:58
bswartzganso: I don't think we can change the artistic style23:58
bswartzganso: mostly the question is whether we're happy with zorilla and the mascot overall23:58
bswartzI think it's pretty good23:58
bswartzand it definitely non-skunky23:59
marksturI'd say just the right amount of skunky23:59
gansolol23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!