| *** tinwood has quit IRC | 00:00 | |
| *** tinwood has joined #openstack-manila | 00:01 | |
| *** harlowja has quit IRC | 00:04 | |
| *** tommylikehu_ has joined #openstack-manila | 00:08 | |
| *** tommylikehu_ has quit IRC | 00:13 | |
| *** crushil has joined #openstack-manila | 00:25 | |
| *** esker has joined #openstack-manila | 00:28 | |
| openstackgerrit | yankee proposed openstack/manila: Allow use of <is> with extra_spec_value in share type https://review.openstack.org/413338 | 00:30 |
|---|---|---|
| *** tommylikehu_ has joined #openstack-manila | 00:33 | |
| *** yankee has joined #openstack-manila | 00:44 | |
| *** esker has quit IRC | 00:58 | |
| *** esker has joined #openstack-manila | 01:01 | |
| *** esker has quit IRC | 01:10 | |
| *** mtanino has quit IRC | 01:10 | |
| *** esker has joined #openstack-manila | 01:11 | |
| *** yankee has quit IRC | 01:14 | |
| *** esker has quit IRC | 01:25 | |
| *** cknight1 has quit IRC | 01:40 | |
| *** tommylikehu_ has quit IRC | 01:47 | |
| *** tommylikehu_ has joined #openstack-manila | 01:48 | |
| *** tommylikehu_ has quit IRC | 01:53 | |
| *** xinyanzhang has quit IRC | 02:03 | |
| *** xinyanzhang has joined #openstack-manila | 02:03 | |
| *** ganso has quit IRC | 02:04 | |
| *** kaisers has quit IRC | 02:05 | |
| *** esker has joined #openstack-manila | 02:05 | |
| *** tommylikehu_ has joined #openstack-manila | 02:07 | |
| *** tommylikehu_ has quit IRC | 02:07 | |
| *** yankee has joined #openstack-manila | 02:17 | |
| *** yankee has left #openstack-manila | 02:17 | |
| *** tommylikehu_ has joined #openstack-manila | 02:21 | |
| *** tommylikehu_ has quit IRC | 02:22 | |
| *** tommylikehu_ has joined #openstack-manila | 02:22 | |
| *** sapcc-bot1 has quit IRC | 02:27 | |
| *** sapcc-bot has joined #openstack-manila | 02:27 | |
| *** esker has quit IRC | 02:31 | |
| *** esker has joined #openstack-manila | 02:33 | |
| *** esker has quit IRC | 02:42 | |
| *** absubram has joined #openstack-manila | 02:43 | |
| *** absubram has quit IRC | 02:48 | |
| *** absubram has joined #openstack-manila | 02:49 | |
| *** tommylikehu_ has quit IRC | 02:52 | |
| *** tommylikehu_ has joined #openstack-manila | 02:52 | |
| *** tommylikehu_ has quit IRC | 03:02 | |
| *** tommylikehu_ has joined #openstack-manila | 03:06 | |
| *** mtanino has joined #openstack-manila | 03:15 | |
| *** mtanino has quit IRC | 03:21 | |
| openstackgerrit | yankee proposed openstack/manila: Allow use of <is> with extra_spec_value in share type https://review.openstack.org/413338 | 03:22 |
| openstackgerrit | yankee proposed openstack/manila: Allow use of <is> with extra_spec_value in share type https://review.openstack.org/413338 | 03:25 |
| *** crushil has quit IRC | 03:28 | |
| *** crushil has joined #openstack-manila | 03:28 | |
| *** porrua has joined #openstack-manila | 03:29 | |
| *** tommylikehu_ has quit IRC | 03:41 | |
| *** porrua has quit IRC | 03:42 | |
| *** gouthamr has quit IRC | 03:43 | |
| *** esker has joined #openstack-manila | 04:35 | |
| *** tommylikehu_ has joined #openstack-manila | 04:46 | |
| *** tommylikehu_ has quit IRC | 04:49 | |
| *** tommylikehu_ has joined #openstack-manila | 04:55 | |
| *** absubram has quit IRC | 04:55 | |
| *** tommylikehu_ has quit IRC | 05:06 | |
| *** shausy has joined #openstack-manila | 05:29 | |
| *** david-lyle has quit IRC | 05:46 | |
| *** esker has quit IRC | 05:47 | |
| *** kaisers has joined #openstack-manila | 05:54 | |
| *** kaisers has quit IRC | 05:55 | |
| *** crushil has quit IRC | 06:07 | |
| *** crushil has joined #openstack-manila | 06:09 | |
| *** crushil has quit IRC | 06:15 | |
| *** lpetrut has joined #openstack-manila | 06:26 | |
| *** kaisers has joined #openstack-manila | 06:55 | |
| *** nkrinner_afk is now known as nkrinner | 06:56 | |
| openstackgerrit | aditi sharma proposed openstack/manila-ui: Remove link to modindex https://review.openstack.org/426109 | 07:08 |
| openstackgerrit | aditi sharma proposed openstack/manila-image-elements: Remove link to modindex https://review.openstack.org/426110 | 07:10 |
| *** kaisers has quit IRC | 07:21 | |
| *** kaisers has joined #openstack-manila | 07:36 | |
| *** akapil has joined #openstack-manila | 08:59 | |
| *** a-pugachev has joined #openstack-manila | 09:18 | |
| *** tommylikehu has quit IRC | 09:43 | |
| *** tommylikehu has joined #openstack-manila | 09:43 | |
| *** yumiriam has joined #openstack-manila | 09:48 | |
| *** tommylikehu_ has joined #openstack-manila | 09:54 | |
| *** ganso has joined #openstack-manila | 09:58 | |
| *** absubram has joined #openstack-manila | 10:02 | |
| *** absubram has quit IRC | 10:07 | |
| *** tommylikehu_ has quit IRC | 10:18 | |
| *** lpetrut has quit IRC | 10:21 | |
| *** surabujin has quit IRC | 10:36 | |
| *** tommylikehu_ has joined #openstack-manila | 10:40 | |
| *** tommylikehu_ has quit IRC | 10:42 | |
| *** surabujin has joined #openstack-manila | 10:55 | |
| *** ociuhandu has quit IRC | 10:58 | |
| *** akapil has quit IRC | 11:07 | |
| *** lpetrut has joined #openstack-manila | 11:23 | |
| *** chlong has joined #openstack-manila | 11:24 | |
| *** akapil has joined #openstack-manila | 11:27 | |
| *** yankee has joined #openstack-manila | 11:33 | |
| *** lpetrut has quit IRC | 11:34 | |
| *** lpetrut has joined #openstack-manila | 11:35 | |
| *** catintheroof has joined #openstack-manila | 12:04 | |
| *** yankee has quit IRC | 12:04 | |
| *** yankee has joined #openstack-manila | 12:10 | |
| *** rraja has joined #openstack-manila | 12:23 | |
| *** yankee has quit IRC | 12:26 | |
| openstackgerrit | yankee proposed openstack/manila: Allow use of <is> with extra_spec_value in share type https://review.openstack.org/413338 | 12:33 |
| *** tommylikehu_ has joined #openstack-manila | 12:46 | |
| *** ociuhandu has joined #openstack-manila | 12:46 | |
| *** yankee_ has joined #openstack-manila | 12:58 | |
| *** yankee_ has quit IRC | 13:01 | |
| *** catintheroof has quit IRC | 13:05 | |
| *** catintheroof has joined #openstack-manila | 13:16 | |
| *** tommylikehu_ has quit IRC | 13:19 | |
| *** tommylikehu_ has joined #openstack-manila | 13:20 | |
| *** rraja has quit IRC | 13:29 | |
| *** rraja has joined #openstack-manila | 13:37 | |
| *** tommylikehu_ has quit IRC | 13:49 | |
| *** gouthamr has joined #openstack-manila | 13:53 | |
| *** esker has joined #openstack-manila | 13:58 | |
| *** porrua has joined #openstack-manila | 13:58 | |
| *** dustins has joined #openstack-manila | 13:59 | |
| *** xyang1 has joined #openstack-manila | 14:01 | |
| *** esker has quit IRC | 14:08 | |
| bswartz | tbarron: ping | 14:08 |
| *** shausy has quit IRC | 14:11 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Mark 'v1' API deprecated in the versions response https://review.openstack.org/425814 | 14:12 |
| *** absubram has joined #openstack-manila | 14:14 | |
| *** esker has joined #openstack-manila | 14:17 | |
| *** absubram has quit IRC | 14:18 | |
| *** rraja_ has joined #openstack-manila | 14:18 | |
| *** rraja has quit IRC | 14:19 | |
| *** absubram has joined #openstack-manila | 14:24 | |
| *** lpetrut has quit IRC | 14:37 | |
| *** cknight has joined #openstack-manila | 14:50 | |
| *** makowals has quit IRC | 14:56 | |
| *** makowals has joined #openstack-manila | 14:57 | |
| *** a-pugachev has quit IRC | 14:59 | |
| *** crushil has joined #openstack-manila | 15:01 | |
| *** a-pugachev has joined #openstack-manila | 15:05 | |
| *** absubram has quit IRC | 15:06 | |
| *** nkrinner is now known as nkrinner_afk | 15:12 | |
| vponomaryov | bswartz: what do you think about https://review.openstack.org/#/c/425814/ to merge in O ? | 15:13 |
| bswartz | vponomaryov: it seems harmless, and follows guidelines of API-WG | 15:14 |
| bswartz | Is there any way that change could break something? | 15:14 |
| vponomaryov | I think we should have already done it | 15:14 |
| bswartz | I had this conversation with gouthamr yesterday | 15:14 |
| vponomaryov | don't think that it can break something | 15:14 |
| bswartz | we've already deprecated the v1.0 API | 15:14 |
| bswartz | this change just removes confusion about that | 15:15 |
| vponomaryov | bswartz: does it mean we can really remove it in Pike? | 15:15 |
| bswartz | we don't want people to see "SUPPORTED" and think it's not deprecated | 15:15 |
| bswartz | technically we *can* remove if it we want to but as you know I'm always opposed to removing old things | 15:15 |
| *** mtanino has joined #openstack-manila | 15:16 | |
| vponomaryov | not really know ) | 15:16 |
| vponomaryov | v2 was aound really for loong time | 15:16 |
| bswartz | well deprecating and removing at 2 differents | 15:16 |
| vponomaryov | s/aound/around/ | 15:16 |
| bswartz | I'm in favor of deprecating old things but not so much in favor of removing them | 15:16 |
| bswartz | it's a question of cost to maintain vs. cost to remove | 15:17 |
| vponomaryov | bswartz: what is the benefit to keep v1? | 15:17 |
| vponomaryov | bswartz: what is use case to keep it? | 15:17 |
| bswartz | mainly backwards compatibility, and we avoid the work required to strip out all the code and tests for v1 | 15:17 |
| vponomaryov | bswartz: I consider "removal" also as "poke" action for those who just didn't start using v2 | 15:19 |
| *** gouthamr has quit IRC | 15:19 | |
| bswartz | yes, it's just important to remember how slowly real users upgrade | 15:20 |
| vponomaryov | ok, we have one more topic for PTG ) | 15:21 |
| bswartz | +1 | 15:21 |
| *** esker has quit IRC | 15:36 | |
| *** gouthamr has joined #openstack-manila | 15:41 | |
| *** rraja_ has quit IRC | 15:42 | |
| *** absubram has joined #openstack-manila | 15:49 | |
| *** lpetrut has joined #openstack-manila | 16:07 | |
| *** dustins has quit IRC | 16:10 | |
| *** esker has joined #openstack-manila | 16:11 | |
| *** akapil has quit IRC | 16:15 | |
| *** crushil has quit IRC | 16:15 | |
| *** crushil has joined #openstack-manila | 16:16 | |
| *** esker has quit IRC | 16:16 | |
| *** eharney has quit IRC | 16:20 | |
| *** akapil has joined #openstack-manila | 16:33 | |
| *** absubram has quit IRC | 16:47 | |
| *** crushil has quit IRC | 16:54 | |
| *** esker has joined #openstack-manila | 17:11 | |
| *** akapil_ has joined #openstack-manila | 17:17 | |
| *** esker has quit IRC | 17:18 | |
| *** akapil has quit IRC | 17:20 | |
| *** akapil_ has quit IRC | 17:22 | |
| *** dsariel has quit IRC | 17:32 | |
| *** timcl1 has joined #openstack-manila | 17:38 | |
| *** timcl has quit IRC | 17:39 | |
| bswartz | tbarron: ping2 | 17:42 |
| tbarron | bswartz: vacation day today and I'm mostly running family errands, leaving in 5 | 17:42 |
| tbarron | bswartz: what's up? | 17:43 |
| bswartz | tbarron: ah I forgot | 17:43 |
| tbarron | bswartz: no prob, just 'splainin | 17:43 |
| bswartz | tbarron: mostly wanted to tell you I untangled my neutron config to the point that IPv6 works without horrifying hacks | 17:43 |
| *** ociuhandu has quit IRC | 17:43 | |
| bswartz | I will be producing a writeup next week, would like you to test it | 17:43 |
| tbarron | bswartz: that's great news, I would very much like to do that | 17:44 |
| bswartz | k | 17:44 |
| bswartz | enjoy your day off | 17:44 |
| tbarron | bswartz: trips to lowes, etc., change of pace | 17:44 |
| tbarron | bswartz: I look forward to the writeup | 17:44 |
| *** dsariel has joined #openstack-manila | 17:44 | |
| *** a-pugachev has quit IRC | 17:45 | |
| *** crushil has joined #openstack-manila | 17:55 | |
| *** eharney has joined #openstack-manila | 18:01 | |
| *** harlowja has joined #openstack-manila | 18:02 | |
| *** chlong has quit IRC | 18:03 | |
| *** JoseMello has joined #openstack-manila | 18:21 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila: Fix creation of share group types using share type names https://review.openstack.org/426335 | 18:23 |
| vponomaryov | rhagarty: ^ | 18:28 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Don't strip comments out of config files https://review.openstack.org/426347 | 18:54 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Add .gitreview file https://review.openstack.org/426351 | 18:57 |
| *** yumiriam has quit IRC | 18:59 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Add script for testing images really quickly https://review.openstack.org/426356 | 19:00 |
| rhagarty | vponomaryov: thanks, I'll test it | 19:01 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Support SSH keys from config drive https://review.openstack.org/426358 | 19:06 |
| *** absubram has joined #openstack-manila | 19:10 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Support DHCPv6 https://review.openstack.org/426364 | 19:12 |
| bswartz | vponomaryov, tbarron: ^^^^^ These 5 changes were all part of my IPv6 testing work | 19:13 |
| *** absubram has quit IRC | 19:15 | |
| bswartz | gah, looks like the gate is broken for manila-test-image | 19:15 |
| bswartz | 2017-01-27 18:58:55.824955 | + tox -v -ebashate | 19:16 |
| bswartz | 2017-01-27 18:58:56.013579 | ERROR: toxini file 'tox.ini' not found | 19:16 |
| bswartz | what does this mean? | 19:16 |
| * bswartz suspects a job definition got chaged somewhere... | 19:18 | |
| bswartz | changed | 19:18 |
| *** absubram has joined #openstack-manila | 19:18 | |
| *** dustins|out is now known as dustins | 19:27 | |
| *** crushil has quit IRC | 19:37 | |
| *** crushil has joined #openstack-manila | 19:40 | |
| vkmc | hey, what's what going on with the gate? just curious | 19:50 |
| bswartz | vkmc: it's for the manila-test-image project | 19:51 |
| bswartz | not for anything critical | 19:51 |
| vkmc | bswartz, yeah, I saw that the manila-test-image was failing as well... but before that the main gate was off, right? | 19:51 |
| vkmc | I remember seeing gate-manila-tempest-minimal-dsvm-dummy-ubuntu-xenial fail but I couldn't get why | 19:51 |
| bswartz | I'm not sure if the gate changed or if this bashate job was always broken | 19:51 |
| bswartz | that's totally unrelated | 19:52 |
| bswartz | there are real issues with the gate for manila | 19:52 |
| bswartz | caused by infra/qa problems | 19:52 |
| *** gregsfortytwo has quit IRC | 19:54 | |
| *** gregsfortytwo has joined #openstack-manila | 19:57 | |
| *** david-lyle has joined #openstack-manila | 20:01 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Fix bashate job https://review.openstack.org/426378 | 20:02 |
| bswartz | vkmc: ^ hopefully this sorts it out | 20:03 |
| *** lpetrut has quit IRC | 20:03 | |
| vkmc | bswartz, nice :) | 20:05 |
| openstackgerrit | Merged openstack/manila-test-image: Fix bashate job https://review.openstack.org/426378 | 20:15 |
| bswartz | markstur: talk to me about hating tabs | 20:17 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Replace chown with chmod https://review.openstack.org/426390 | 20:24 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Don't strip comments out of config files https://review.openstack.org/426347 | 20:26 |
| bswartz | vkmc: did they remove the reverify command? | 20:33 |
| vkmc | bswartz, last time I checked, they did | 20:34 |
| bswartz | that's a shame | 20:34 |
| bswartz | now I have to use recheck like everyone else | 20:35 |
| vkmc | hahaha | 20:35 |
| *** crushil has quit IRC | 20:38 | |
| *** crushil has joined #openstack-manila | 20:39 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Replace chown with chmod https://review.openstack.org/426390 | 20:39 |
| *** adrianofr_ has quit IRC | 20:39 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Support SSH keys from config drive https://review.openstack.org/426358 | 20:39 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Add script for testing images really quickly https://review.openstack.org/426356 | 20:44 |
| *** porrua has quit IRC | 20:48 | |
| bswartz | markstur: in all seriousness I'd like to figure out what to do with tabs in manila-test-image -- I still use tabs out of habit for shellscripts and other UNIXy things (believe it or not I used to use tab in C/Java code too) | 20:49 |
| markstur | I'm back | 20:50 |
| *** lpetrut has joined #openstack-manila | 20:50 | |
| bswartz | markstur: I'm not opposed to converting all the tabs to spaces I just don't know what the accepted rule are for indentation | 20:50 |
| markstur | bswartz: I'm not opposed to keeping them if that is the current convention -- and if most of us never ever ever have to edit the file | 20:50 |
| markstur | the real tab problem is when they get inconsistent | 20:51 |
| markstur | (and I was always one of those odd ones that like a 3 space indent :) ) | 20:51 |
| bswartz | well my convention is tabs, but I'd be happy to conform to the community convention if I knew what it was | 20:51 |
| bswartz | and I agree it should be an all-or-nothing conversion, not a mixture | 20:51 |
| markstur | I thought reverify still works but now it is the same as recheck. | 20:52 |
| bswartz | markstur: also I addressed your concern in https://review.openstack.org/#/c/426358/ but gerrit didn't remove your -1 for some reason | 20:52 |
| markstur | I still use it just to recognize that a job is at gate even if it doesn't matter | 20:53 |
| bswartz | markstur: do you not have +2 power on this repo? | 20:53 |
| markstur | I do. I'll look. | 20:53 |
| markstur | I don't usually look at that repo | 20:53 |
| bswartz | nobody does | 20:54 |
| bswartz | it's been silent for months while we've been doing real work | 20:54 |
| bswartz | I needed to use it for my ipv6 work because cirros and ubuntu are both crap | 20:54 |
| markstur | bswartz: Well of course it didn't remove my -1. You didn't change anything | 20:54 |
| bswartz | and running fedora in a cloud seems like a weird thing to do | 20:55 |
| bswartz | markstur: I changed the parent commit | 20:55 |
| bswartz | I split change into 2 commits but gerrit didn't realize I did that because the end result is the same... | 20:56 |
| markstur | OK. I see the change, but yeah not in diff. | 20:56 |
| bswartz | there is no diff because that change is in another commit now | 20:56 |
| bswartz | https://review.openstack.org/#/c/426390 | 20:57 |
| bswartz | sorry if it seems weird, I meant to split it this way originally and forgot to | 20:57 |
| markstur | It just seemed weird because gerrit tricked me | 20:58 |
| vkmc | I wonder if it would make sense to replace what there is in manila-test-image with manila-image-elements stuff | 21:03 |
| vkmc | I didn't know this repo existed | 21:04 |
| bswartz | vkmc: so you don't know this history of this repo then | 21:05 |
| vkmc | nope | 21:05 |
| bswartz | vkmc: the reason it's separate from manila-image-elements is because of licensing (GPL vs Apache) | 21:06 |
| bswartz | I found the -image-elements stuff to be inadequate for building REALLY SMALL images for use in testing | 21:06 |
| vkmc | I see | 21:06 |
| bswartz | the smallest ubuntu images we can create are in 300-350MB range | 21:07 |
| bswartz | I suspect that centos-based images would be the same or worse | 21:07 |
| vkmc | yeah, that for sure | 21:07 |
| vkmc | can we use something small like cirros for testing? not sure if that is enough | 21:07 |
| bswartz | cirros is small, but lacks the features we need, and we're not going to start contributing to cirros | 21:08 |
| vkmc | makes sense | 21:08 |
| bswartz | the design of manila-test-image is similar to cirros, but with a focus on filesystem mounting | 21:08 |
| bswartz | currently manila-test-image produces a 6.5MB Linux system with everything we need for testing Manila | 21:09 |
| bswartz | and it need no storage and just 64MB of RAM to run | 21:09 |
| markstur | nice | 21:09 |
| markstur | recently was struggling with that big ubuntu image | 21:10 |
| vkmc | that's cool | 21:10 |
| vkmc | are we using it on the gate? | 21:10 |
| bswartz | markstur: can't tell if you're being facetious | 21:10 |
| vkmc | sorry, I wrong question | 21:11 |
| bswartz | vkmc: not yet, there's more effort involved | 21:11 |
| vkmc | why aren't we using it? | 21:11 |
| vkmc | ahh | 21:11 |
| vkmc | k | 21:11 |
| vkmc | cool :) | 21:11 |
| bswartz | it's just a question of time (mine or whoever else volunteers) | 21:11 |
| markstur | bswartz: Seriously rhagarty were dealing with manila image timeouts and copying that thing around | 21:12 |
| bswartz | okay, that's my experience too | 21:12 |
| markstur | smaller is better. size matters | 21:12 |
| bswartz | some people believe that 350MB *is* small | 21:12 |
| markstur | At HP we could never download that thing | 21:12 |
| bswartz | I was always shaking my head at how large it was | 21:13 |
| bswartz | if you talk to the docker guys they'll tell you a 2GB container is small | 21:13 |
| bswartz | so it's all a matter of perspective I guess | 21:13 |
| *** ganso has quit IRC | 21:14 | |
| markstur | funny how we went from so little KBs and MBs to suddenly who cares its cheap and now we are caring again | 21:15 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Support SSH keys from config drive https://review.openstack.org/426358 | 21:15 |
| bswartz | well not everyone cares | 21:15 |
| bswartz | it's a question of how you're using the images | 21:15 |
| markstur | bswartz: The extra settings I commented on. That isn't another gerrit trick? | 21:15 |
| bswartz | there are use cases where the size really doesn't matter | 21:16 |
| bswartz | but in our case we're copying these files hundreds of times per day so it starts to matter | 21:16 |
| bswartz | what extra settings? | 21:17 |
| markstur | https://review.openstack.org/#/c/426347/2 | 21:17 |
| markstur | bswartz: diff makes me think you are adding stuff that is not comments and changing a couple of settings | 21:17 |
| bswartz | oh! | 21:17 |
| markstur | so sneaky | 21:17 |
| bswartz | those are good catches | 21:17 |
| bswartz | this is an accident on my part | 21:18 |
| markstur | yes. I don't know if the settings are good or bad, but looked like it could be a mistake | 21:18 |
| markstur | some accidental optimization :) | 21:18 |
| bswartz | well I definitely wanted to enabled those things | 21:18 |
| bswartz | but I meant to split those into another patchset to make it obvious i was adding them | 21:19 |
| bswartz | the rebases will be hell if I split this one though | 21:19 |
| bswartz | how about I update the commend to explain what was added? | 21:19 |
| markstur | So one thing, is that I'm not planning to test this. So I was going to ask about that. | 21:20 |
| markstur | Otherwise, it's fine with me if the commit message matches the change and someone confirms that it is a good thing | 21:20 |
| bswartz | don't worry about testing -- if this thing has bugs nobody will get hurt (except me) | 21:20 |
| bswartz | part of getting this to be used in our actual gate will be adding real tests | 21:21 |
| bswartz | so it won't be possible to make a change that breaks the gate | 21:21 |
| markstur | that's what I thought, but figured I should ask before closing my eyes and approving -- but I can do the visual reviews | 21:21 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Don't strip comments out of config files https://review.openstack.org/426347 | 21:22 |
| bswartz | these reviews are very helpful | 21:23 |
| markstur | This actually is looking like something I'd like to test, but unfortunately it is late Friday and by Monday I'll probably change my mind | 21:23 |
| bswartz | after the current backlog gets merged I can look into a wholesale tab->space conversion | 21:23 |
| markstur | (it is not late here, but I was going to do other things) | 21:23 |
| bswartz | markstur: if you clone the repo and read the README I think you'll find it fairly easy to run | 21:24 |
| markstur | bswartz: or something silly like vim settings in the files :O | 21:24 |
| bswartz | I have on my todo list to add a gate job that actually builds the images | 21:24 |
| markstur | bswartz: Yeah. I just looked at that. I'm serious about wanting to try it -- but probably not today | 21:24 |
| bswartz | the effort to build it is 2 minutes of reading and typing commands, then waiting for ~60 minutes while it compiles like crazy | 21:25 |
| bswartz | you'd be surprised how long it takes to compile a 6.5MB image | 21:25 |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-test-image: Support SSH keys from config drive https://review.openstack.org/426358 | 21:26 |
| *** absubram has quit IRC | 21:33 | |
| *** a-pugachev has joined #openstack-manila | 21:36 | |
| *** catintheroof has quit IRC | 21:44 | |
| *** catintheroof has joined #openstack-manila | 21:45 | |
| *** catintheroof has quit IRC | 21:49 | |
| *** cknight has quit IRC | 21:53 | |
| *** JoseMello has quit IRC | 21:55 | |
| *** absubram has joined #openstack-manila | 21:55 | |
| *** breitz has quit IRC | 22:01 | |
| *** absubram has quit IRC | 22:01 | |
| *** breitz has joined #openstack-manila | 22:02 | |
| *** crushil has quit IRC | 22:16 | |
| *** gouthamr has quit IRC | 22:27 | |
| *** dustins is now known as dustins|out | 22:41 | |
| *** xyang1 has quit IRC | 22:44 | |
| *** gouthamr has joined #openstack-manila | 22:51 | |
| *** lpetrut has quit IRC | 22:55 | |
| *** tinwood has quit IRC | 23:05 | |
| *** tinwood has joined #openstack-manila | 23:06 | |
| *** a-pugachev has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!