Friday, 2017-01-13

*** chlong has quit IRC00:01
*** gouthamr has quit IRC00:02
*** yumiriam has left #openstack-manila00:05
*** cknight has quit IRC00:12
*** gouthamr has joined #openstack-manila00:26
*** furlongm has quit IRC00:34
*** furlongm has joined #openstack-manila00:36
*** furlongm has quit IRC00:38
*** gouthamr has quit IRC00:47
*** mtani____ has quit IRC00:47
*** furlongm has joined #openstack-manila00:56
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila-image-elements: Adds support for NFS Ganesha  https://review.openstack.org/41150001:00
openstackgerritLucio Seki proposed openstack/manila: [DEBUG] Show LVM volume filesystem and list mount path  https://review.openstack.org/41962701:26
*** kaisers2 has joined #openstack-manila01:36
*** kaisers3 has joined #openstack-manila01:36
*** kaisers1 has quit IRC01:37
*** kaisers has quit IRC01:38
openstackgerritzhongjun proposed openstack/manila: Add manila-manage db purge command  https://review.openstack.org/30821201:38
*** kaisers has joined #openstack-manila02:17
*** kaisers_ has quit IRC02:20
*** gouthamr has joined #openstack-manila02:34
*** gouthamr has quit IRC02:43
*** ganso has quit IRC02:44
*** gouthamr has joined #openstack-manila02:45
*** breitz has quit IRC02:52
openstackgerritJeremy Liu proposed openstack/python-manilaclient: Enable coverage report in console output  https://review.openstack.org/41973302:57
*** porrua has joined #openstack-manila02:59
*** porrua has quit IRC03:04
*** absubram has joined #openstack-manila03:11
*** absubram_ has joined #openstack-manila03:18
*** absubram has quit IRC03:19
*** absubram_ is now known as absubram03:19
*** gcb has quit IRC03:26
openstackgerritPony Chou proposed openstack/manila: Add QNAP Manila Driver  https://review.openstack.org/39470303:39
openstackgerritzhongjun proposed openstack/manila: [TrivialFix] Add negative test in quota detail  https://review.openstack.org/41974603:40
*** gouthamr has quit IRC04:04
*** alekseyruban has joined #openstack-manila04:10
*** alekseyruban has quit IRC04:14
*** breitz has joined #openstack-manila04:28
*** porrua has joined #openstack-manila04:48
*** porrua has quit IRC04:52
*** kaisers has quit IRC04:54
*** sticker has quit IRC05:31
*** alekseyruban has joined #openstack-manila05:32
*** kaisers has joined #openstack-manila05:55
*** lpetrut has joined #openstack-manila05:59
*** alekseyruban has quit IRC06:06
*** jprovazn has joined #openstack-manila06:27
*** porrua has joined #openstack-manila06:36
*** kaisers has quit IRC06:40
*** porrua has quit IRC06:41
*** alekseyruban has joined #openstack-manila06:48
*** lpetrut has quit IRC06:50
*** a-pugachev has joined #openstack-manila06:53
*** nkrinner_afk is now known as nkrinner07:15
*** kaisers has joined #openstack-manila07:36
*** a-pugachev has quit IRC07:57
*** nherciu has joined #openstack-manila07:58
openstackgerritzhongjun proposed openstack/manila: Fix column name error in migration script  https://review.openstack.org/41816808:24
openstackgerritzhongjun proposed openstack/manila: Fix column name error in migration script  https://review.openstack.org/41816808:27
*** tuanluong has joined #openstack-manila08:28
*** kaisers has quit IRC08:41
*** ociuhandu has joined #openstack-manila09:05
*** a-pugachev has joined #openstack-manila09:17
*** porrua has joined #openstack-manila09:18
*** porrua has quit IRC09:22
*** ganso has joined #openstack-manila09:31
*** gaurangt has joined #openstack-manila09:51
*** lpetrut has joined #openstack-manila10:08
*** tuanluong has quit IRC10:09
*** tuanluong has joined #openstack-manila10:10
*** tuanluong has quit IRC10:11
openstackgerritTina Tang proposed openstack/manila: [Unity driver] VLAN enhancement  https://review.openstack.org/41003710:17
*** JoseMello has joined #openstack-manila10:18
*** openstackgerrit has quit IRC10:18
*** kaisers has joined #openstack-manila10:36
*** makowals has quit IRC10:42
*** makowals has joined #openstack-manila10:44
*** absubram has quit IRC10:47
*** makowals has quit IRC10:54
*** tommylikehu_ has joined #openstack-manila10:58
*** yumiriam has joined #openstack-manila11:01
*** tommylikehu_ has quit IRC11:03
*** porrua has joined #openstack-manila11:06
*** makowals_ has joined #openstack-manila11:08
*** porrua has quit IRC11:11
gansovponomaryov: ping11:14
vponomaryovganso: pong11:14
gansovponomaryov: Hi Valeriy. Why are you suggesting the use of skip_if_microversion_lt instead of skip_if_microversion_not_supported in test_share_basic_ops.py ?11:15
vponomaryovganso: why do you suggest using "not_supported"?11:16
gansovponomaryov: you told me some time ago that using "not_supported" is more appropriate11:16
vponomaryovganso: my argument is that we are ok with higher version11:16
vponomaryoveven if this particular one is ot supported11:16
vponomaryovs/ot/not/11:16
vponomaryovganso: every statement has its context11:17
gansovponomaryov: why cannot it be "not_support" ?11:17
vponomaryovganso: it can, but it is wrong11:17
gansovponomaryov: why?11:18
vponomaryovganso: we need exactly "greater" or "notless than"11:18
gansovponomaryov: what if this function changes?11:18
gansovponomaryov: we would need to update the decorator again11:18
vponomaryovganso: Rodrigo, update of test after update of API is expected thing11:18
*** openstackgerrit has joined #openstack-manila11:19
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client  https://review.openstack.org/33512011:19
gansovponomaryov: ok so in what situation "not_supported" is properly used?11:19
vponomaryovganso: when you need specific version, obviously11:20
gansovponomaryov: let's take CG tests as an example... it is going to not be supported anymore, why would we maintain tests for that?11:21
vponomaryovganso: where do you see it is being maintained?11:21
gansovponomaryov: like, we could either rename and update the tests, in that case "skip_if_microversion_lt" is valid11:21
gansovponomaryov: I am trying to find an example where "not_supported" is correct but "skip_if_microversion_lt" is not, despite other factors such as "we can update the tests and use the higher version always"11:22
vponomaryovhttps://github.com/openstack/manila/blob/0d6db358/manila_tempest_tests/tests/api/admin/test_share_manage.py11:23
vponomaryovganso: you are burying deep into useless thing. Answer has already been given11:24
vponomaryovganso: when you need specific version, that's all11:24
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526411:32
*** lseki has joined #openstack-manila11:34
*** kaisers has quit IRC11:43
*** openstackgerrit has quit IRC11:47
dmelladovponomaryov: hey o/11:57
dmelladocould you please have another look at https://review.openstack.org/#/c/419440/11:57
*** openstackgerrit has joined #openstack-manila11:57
dmelladoit should be quite straightforward and already has 2 +2's ;)11:57
dmelladothanks!11:57
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526411:58
openstackgerritLucio Seki proposed openstack/manila: Mountable snapshots scenario tests  https://review.openstack.org/41200111:59
vponomaryovdmellado: done12:00
dmelladovponomaryov: thanks!12:01
*** makowals_ has quit IRC12:06
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client  https://review.openstack.org/33512012:09
*** tommylikehu_ has joined #openstack-manila12:21
*** timcl has joined #openstack-manila12:22
*** catintheroof has joined #openstack-manila12:30
*** catintheroof has quit IRC12:31
*** catintheroof has joined #openstack-manila12:32
openstackgerritMerged openstack/manila: Allow skipping manila tempest tests.  https://review.openstack.org/41944012:37
*** kaisers has joined #openstack-manila12:39
*** gaurangt has left #openstack-manila12:43
*** dsariel has quit IRC12:54
*** makowals has joined #openstack-manila13:02
openstackgerritTom Barron proposed openstack/manila: Remove NovaNetworkPlugin  https://review.openstack.org/41045013:13
*** jcsp has joined #openstack-manila13:15
*** tommylikehu_ has quit IRC13:17
*** tommylikehu_ has joined #openstack-manila13:17
*** kaisers has quit IRC13:27
openstackgerritzhongjun proposed openstack/manila: Fix column name error in migration script  https://review.openstack.org/41816813:30
*** absubram has joined #openstack-manila13:40
*** timcl1 has joined #openstack-manila13:42
*** timcl has quit IRC13:45
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509313:46
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509313:59
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526413:59
*** xyang1 has joined #openstack-manila14:06
*** gouthamr has joined #openstack-manila14:15
*** jprovazn has quit IRC14:21
*** jprovazn has joined #openstack-manila14:21
*** kaisers has joined #openstack-manila14:22
*** jprovazn has quit IRC14:23
gansogouthamr: ping14:28
gouthamrganso: pong14:30
*** jprovazn has joined #openstack-manila14:30
gansogouthamr: Hi Goutham. Good morning! I have a question about https://review.openstack.org/#/c/419163/4/manila/share/api.py@44114:30
*** dustins has joined #openstack-manila14:31
gouthamrganso: Goodmorning. Wassup?14:31
*** ChanServ changes topic to "OpenStack Shared File Systems | Manila| Feature Proposal Freeze is here | Core reviewers use your -2 powers!"14:31
*** porrua has joined #openstack-manila14:32
gansogouthamr: I would like to understand it better, because I followed where it leads, and it seems it does absolutely nothing14:32
gansogouthamr: the value is passed to create_share_instance_and_get_request_spec, which sets in the share_replica variable it returns, and then only uses the ID from it14:33
*** tommylikehu has quit IRC14:33
*** tommylikehu has joined #openstack-manila14:34
gouthamrganso: we create the instance with that field set to True; https://review.openstack.org/#/c/419163/4/manila/share/api.py@37214:35
gansogouthamr: set to False, you mean?14:39
gansogouthamr: where is it created set to True? o_O14:39
*** makowals has quit IRC14:45
*** chlong has joined #openstack-manila14:45
*** makowals has joined #openstack-manila14:45
*** eharney has quit IRC14:46
openstackgerritMerged openstack/manila: [TrivialFix] Add negative test in quota detail  https://review.openstack.org/41974614:49
gouthamrganso: L442: readable replicas have it set to True, L444, others have it set to False, L363-372: We're committing that to the database when we create the replica14:56
*** cknight has joined #openstack-manila14:57
gansogouthamr: omg I can't believe I missed that DB call14:57
gouthamrganso: :)14:58
gansogouthamr: I was coding the validation in the wrong unit14:58
gansogouthamr: thanks!14:58
gansogouthamr: unit *test14:58
gouthamrganso: you're welcome! thanks for handling that14:59
*** mtanino has joined #openstack-manila14:59
*** rraja has joined #openstack-manila14:59
*** eharney has joined #openstack-manila15:08
openstackgerritClinton Knight proposed openstack/manila: Implement share revert to snapshot  https://review.openstack.org/34050215:09
*** tommylikehu_ has quit IRC15:17
*** xyang1 has quit IRC15:19
openstackgerritRodrigo Barbieri proposed openstack/manila: Add cast_rules_to_readonly to share instances  https://review.openstack.org/41916315:21
*** nkrinner is now known as nkrinner_afk15:37
*** kaisers has quit IRC15:39
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509316:06
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526416:10
*** cdelatte has joined #openstack-manila16:15
openstackgerritValeriy Ponomaryov proposed openstack/manila: Manila Share Groups  https://review.openstack.org/33509316:18
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Add functional tests for share groups feature  https://review.openstack.org/35526416:18
*** kaisers has joined #openstack-manila16:35
*** makowals has quit IRC16:35
*** pcaruana has joined #openstack-manila16:36
*** chlong has quit IRC16:38
*** chlong has joined #openstack-manila16:43
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila-image-elements: Enables end user to pick share protocol  https://review.openstack.org/40041116:43
*** chlong has quit IRC16:48
*** rraja has quit IRC16:57
*** chlong has joined #openstack-manila16:59
*** ociuhandu has quit IRC17:07
*** chlong has quit IRC17:09
*** nherciu_ has joined #openstack-manila17:28
*** eharney has quit IRC17:29
*** nherciu has quit IRC17:29
*** kaisers has quit IRC17:30
*** nherciu__ has joined #openstack-manila17:31
*** lpetrut has quit IRC17:33
*** nherciu_ has quit IRC17:34
*** eharney has joined #openstack-manila17:51
*** ociuhandu has joined #openstack-manila17:58
*** a-pugachev has quit IRC18:02
*** dustins has quit IRC18:04
*** dustins has joined #openstack-manila18:09
*** dustins has quit IRC18:09
*** dustins has joined #openstack-manila18:10
*** dustins has quit IRC18:21
*** dustins has joined #openstack-manila18:21
*** jprovazn has quit IRC18:24
*** pcaruana has quit IRC18:26
*** kaisers has joined #openstack-manila18:27
*** dustins has quit IRC18:29
*** dustins has joined #openstack-manila18:29
openstackgerritVictoria Martinez de la Cruz proposed openstack/manila-image-elements: Enables end user to pick share protocol  https://review.openstack.org/40041118:38
*** pcaruana has joined #openstack-manila18:39
*** lpetrut has joined #openstack-manila18:43
*** cknight has quit IRC18:57
*** openstack has joined #openstack-manila19:01
*** lpetrut has quit IRC19:01
*** gouthamr has joined #openstack-manila19:02
*** pcaruana has quit IRC19:02
*** lpetrut has joined #openstack-manila19:09
*** chlong has joined #openstack-manila19:14
*** ianychoi has quit IRC19:15
*** yumiriam has quit IRC19:27
*** dustins has quit IRC19:46
*** cknight has quit IRC19:51
*** gouthamr has quit IRC19:51
*** ganso has quit IRC19:54
*** cknight has joined #openstack-manila19:54
*** gouthamr has joined #openstack-manila19:55
*** kaisers has joined #openstack-manila19:57
*** openstackstatus has quit IRC19:57
*** openstack has joined #openstack-manila20:01
*** nherciu__ has quit IRC20:01
*** eharney has quit IRC20:11
*** eharney has joined #openstack-manila20:26
*** openstackstatus has quit IRC20:27
*** openstack has joined #openstack-manila20:31
*** porrua has quit IRC20:36
*** cdelatte has quit IRC20:43
*** timcl1 has quit IRC20:44
*** dustins has joined #openstack-manila21:01
*** absubram has quit IRC21:05
*** lpetrut has quit IRC21:05
*** alekseyruban has quit IRC21:09
*** kaisers has quit IRC21:10
*** JoseMello has quit IRC21:25
*** xyang1 has joined #openstack-manila21:28
*** gouthamr has quit IRC21:31
*** adrianofr_ has quit IRC21:49
*** eharney has quit IRC22:06
*** kaisers has joined #openstack-manila22:06
*** lseki has quit IRC22:10
*** xyang1 has quit IRC22:21
*** baling-wire is now known as david-lyle22:26
*** catintheroof has quit IRC22:38
*** dustins has quit IRC22:56
*** tommylikehu_ has joined #openstack-manila23:06
*** tommylikehu_ has quit IRC23:07
*** tommylikehu_ has joined #openstack-manila23:10
*** kaisers has quit IRC23:14
*** tommylikehu_ has quit IRC23:15
*** cknight has quit IRC23:38
*** chlong has quit IRC23:38
*** tommylikehu has quit IRC23:46
*** tommylikehu has joined #openstack-manila23:46
*** gouthamr has joined #openstack-manila23:54
*** harlowja has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!