Tuesday, 2016-09-13

*** Suyi_ has quit IRC00:07
*** yangyapeng has quit IRC00:18
*** kaisers has joined #openstack-manila00:34
*** kaisers1 has quit IRC00:35
*** kaisers_ has joined #openstack-manila00:52
*** kaisers_ has quit IRC00:56
*** akshai_ has quit IRC01:10
*** chlong_ has joined #openstack-manila01:14
*** yangyapeng has joined #openstack-manila01:30
*** ganso has quit IRC01:45
*** chlong_ has quit IRC01:49
openstackgerritzzxwill proposed openstack/manila: Put all imports from manila.i18n in one line  https://review.openstack.org/36109901:53
*** StraubTW has joined #openstack-manila02:04
*** chlong_ has joined #openstack-manila02:06
*** ociuhandu has joined #openstack-manila02:09
*** gouthamr has quit IRC02:15
*** martyt has joined #openstack-manila02:16
*** martyt has quit IRC02:21
*** kaisers_ has joined #openstack-manila02:41
*** kaisers_ has quit IRC02:45
openstackgerritMerged openstack/manila: HPE 3PAR: file share support of AD in devref  https://review.openstack.org/36604502:49
openstackgerritzhongjun proposed openstack/manila: Add share_type filter support to pool_list  https://review.openstack.org/36561703:09
openstackgerritMerged openstack/manila: Updated from global requirements  https://review.openstack.org/36811003:09
openstackgerritMerged openstack/manila: Fix typo in response status code  https://review.openstack.org/36773103:09
*** jcsp has quit IRC03:10
*** StraubTW has quit IRC03:13
openstackgerritBin Zhou proposed openstack/manila: Modify use of assertTrue(A in B)  https://review.openstack.org/36876703:14
*** rhefner has joined #openstack-manila03:29
*** dustins has joined #openstack-manila03:31
*** senk has joined #openstack-manila03:35
*** sticker has joined #openstack-manila03:39
*** kaisers_ has joined #openstack-manila03:51
*** senk has quit IRC04:08
*** netapp has quit IRC04:25
*** netapp has joined #openstack-manila04:28
*** timcl has quit IRC04:39
*** rooneym has quit IRC04:49
*** timcl has joined #openstack-manila04:52
*** senk has joined #openstack-manila05:09
*** amitkqed has quit IRC05:16
*** amitkqed has joined #openstack-manila05:16
*** ociuhandu has quit IRC05:27
*** lpetrut has joined #openstack-manila05:31
*** jcsp has joined #openstack-manila05:34
*** dsariel has joined #openstack-manila05:41
*** senk has quit IRC05:55
openstackgerritzzxwill proposed openstack/manila: Put all imports from manila.i18n in one line  https://review.openstack.org/36109905:55
*** nkrinner_afk is now known as nkrinner06:00
*** nherciu has joined #openstack-manila06:30
*** senk has joined #openstack-manila06:30
openstackgerritzhongjun proposed openstack/manila: Add share_type filter support to pool_list  https://review.openstack.org/36561706:41
*** nherciu has quit IRC06:44
*** lpetrut has quit IRC06:45
*** pcaruana has joined #openstack-manila07:02
*** kaisers_ has quit IRC07:04
*** lpetrut has joined #openstack-manila07:09
*** nherciu has joined #openstack-manila07:10
*** akapil has joined #openstack-manila07:29
*** nherciu has quit IRC07:32
openstackgerritzzxwill proposed openstack/manila: Put all imports from manila.i18n in one line  https://review.openstack.org/36109907:33
*** nherciu has joined #openstack-manila07:35
*** lpetrut has quit IRC07:35
*** dsariel has quit IRC07:46
*** openstackgerrit has quit IRC07:48
*** openstackgerrit has joined #openstack-manila07:49
*** aovchinnikov has joined #openstack-manila07:55
openstackgerritValeriy Ponomaryov proposed openstack/manila: [docs] Update dev docs for ZFSonLinux share driver  https://review.openstack.org/36685608:04
*** dsariel has joined #openstack-manila08:07
*** tpatzig_ has joined #openstack-manila08:18
*** tpatzig has quit IRC08:20
*** mkoderer has quit IRC08:20
*** mkoderer has joined #openstack-manila08:21
*** zigo_ is now known as zigo08:34
*** kaisers_ has joined #openstack-manila08:52
*** kaisers_ has quit IRC08:57
*** lpetrut has joined #openstack-manila09:09
*** yangyapeng has quit IRC10:17
*** permalac has joined #openstack-manila10:17
*** yangyapeng has joined #openstack-manila10:18
*** yangyapeng has quit IRC10:22
*** tpatzig_ has quit IRC10:25
*** mkoderer has quit IRC10:25
*** cknight has joined #openstack-manila10:40
*** kaisers_ has joined #openstack-manila10:41
*** gouthamr_ has joined #openstack-manila10:45
*** kaisers_ has quit IRC10:46
*** permalac has quit IRC10:51
*** rooneym has joined #openstack-manila11:01
*** ganso has joined #openstack-manila11:20
gansogouthamr_: ping11:21
*** gouthamr_ has quit IRC11:25
openstackgerritMerged openstack/manila: [ZFSonLinux] Add test coverage for share migration  https://review.openstack.org/36683311:49
*** nkrinner has quit IRC11:58
*** nkrinner has joined #openstack-manila12:02
*** dsariel has quit IRC12:04
*** nkrinner has quit IRC12:09
*** nkrinner has joined #openstack-manila12:23
*** jcsp has quit IRC12:26
*** dmellado is now known as dmellado|lunch12:27
*** dmellado|lunch is now known as dmellado12:27
*** kaisers_ has joined #openstack-manila12:30
*** permalac has joined #openstack-manila12:33
*** kaisers_ has quit IRC12:35
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Fix for LV mounting issue in docker containers  https://review.openstack.org/35346312:39
*** xyang1 has joined #openstack-manila12:42
*** StraubTW has joined #openstack-manila12:52
openstackgerritzzxwill proposed openstack/manila: Put all imports from manila.i18n in one line  https://review.openstack.org/36109912:57
*** rraja has joined #openstack-manila13:02
gansobswartz: ping13:07
*** akapil has quit IRC13:09
*** akapil has joined #openstack-manila13:11
bswartzganso: in a meeting13:12
cknightcsaba, rraja: Please see question on your GlusterFS bugfix.  https://review.openstack.org/#/c/352167/13:13
csabacknight: thanks for reaching out to us. Yes, it does :)13:14
cknightcsaba: Thanks.  What is the possibility of seeing both Gluster CI runs pass?  Can you show that with a dependent patch?13:15
gansobswartz: Hi Ben. When you have some time, there are several patches waiting to be backported. They already got +1s, please take a look: https://review.openstack.org/368007, https://review.openstack.org/364352, https://review.openstack.org/354694, https://review.openstack.org/356167, https://review.openstack.org/354812, https://review.openstack.org/355256,13:15
gansohttps://review.openstack.org/352668, https://review.openstack.org/328544.13:15
csabacknight: Rodrigo has called for a recheck and the results just has arrived in 10 minutes. both gluster jobs are passing now!13:17
cknightcsaba: Great, thanks.13:17
*** jcsp has joined #openstack-manila13:18
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix useless statements in unit tests  https://review.openstack.org/36806513:21
*** yangyapeng has joined #openstack-manila13:22
*** eharney has joined #openstack-manila13:24
*** akshai has joined #openstack-manila13:36
openstackgerritClinton Knight proposed openstack/manila: Fix flaky Neutron port binding unit tests  https://review.openstack.org/36946213:38
*** akerr has joined #openstack-manila13:39
*** vbellur has quit IRC13:42
*** gouthamr has joined #openstack-manila13:42
gouthamrganso: hey!13:43
*** ociuhandu has joined #openstack-manila13:43
gansogouthamr: hello Goutham! good morning13:47
*** erlon has quit IRC13:47
gansogouthamr: I saw that you changed the bug to "triaged". So I assume it does not make sense to use it in my patch anymore13:49
gansogouthamr: I am unfamiliar with the term "triaged", so I was unsure if it is better to can it or not, since the behavior that was the bug is now the behavior we want13:51
gouthamrganso: Goodmorning! yep.. we 'triaged' the issue and went with a resolution.. however, that bug may be a candidate for "invalid" or "wont fix"13:52
gouthamrganso: i just wanted to leave the notes of our discussion on the bug..13:52
gansogouthamr: oh, now I get it, like a "trial"... I googled for "triage" and found stuff related to medicine o_O13:53
gouthamrganso: :P probably a derivative..13:54
gansogouthamr: ok, I am opening a new bug13:54
gansogouthamr: ideally, we should get together and "trial" about the nondisruptive13:55
gansogouthamr: so we can change the code asap13:55
*** vbellur has joined #openstack-manila13:57
*** akshai has quit IRC13:58
*** akshai has joined #openstack-manila13:59
*** baojg has joined #openstack-manila14:01
*** baojg has quit IRC14:01
*** baojg has joined #openstack-manila14:02
*** baojg has quit IRC14:02
*** baojg has joined #openstack-manila14:02
*** baojg has quit IRC14:03
*** eharney has quit IRC14:03
*** baojg has joined #openstack-manila14:03
*** baojg has quit IRC14:03
*** baojg has joined #openstack-manila14:04
*** senk has quit IRC14:06
*** kaisers_ has joined #openstack-manila14:09
openstackgerritzzxwill proposed openstack/manila: Put all imports from manila.i18n in one line  https://review.openstack.org/36109914:14
*** baojg has quit IRC14:14
*** baojg has joined #openstack-manila14:16
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Fix for LV mounting issue in docker containers  https://review.openstack.org/35346314:18
*** kaisers_ has quit IRC14:18
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix allow/deny error message and race in migration  https://review.openstack.org/36513614:20
*** nherciu has quit IRC14:23
gouthamrganso: yep.. whenever you're free. i think that nondisruptive must be True by default, in line with 'writable' and 'preserve_metadata'..14:25
gouthamrganso: serves two purposes: 1) people who expect migrations to be nondisruptive all the time can see a failure and react to it, rather than expect no disruption and be unpleasantly surprised.14:26
gouthamrganso: 2) makes for a better user (admin) experience when all three checkboxes are ticked (that result in running only driver assisted migrations) instead of just two of the three flags14:27
*** kaisers_ has joined #openstack-manila14:28
*** aovchinnikov has quit IRC14:29
openstackgerritMerged openstack/manila: Fix useless statements in unit tests  https://review.openstack.org/36806514:29
*** baojg has quit IRC14:30
openstackgerritMerged openstack/manila: [docs] Update dev docs for ZFSonLinux share driver  https://review.openstack.org/36685614:30
*** kaisers_ has quit IRC14:34
*** kaisers_ has joined #openstack-manila14:35
*** kaisers__ has joined #openstack-manila14:37
*** eharney has joined #openstack-manila14:37
*** kaisers_ has quit IRC14:38
*** kaisers__ has quit IRC14:42
*** kaisers_ has joined #openstack-manila14:44
*** vbellur has quit IRC14:45
*** nkrinner is now known as nkrinner_afk14:48
*** porrua has joined #openstack-manila14:55
*** vbellur has joined #openstack-manila14:56
*** kaisers_ has quit IRC15:02
*** erlon has joined #openstack-manila15:04
mkoderer__cknight: ping15:08
cknightmkoderer__: pong15:11
cknightmkoderer__: welcome back15:11
cknightmkoderer__: I wasn't sure you were back, so I fixed the unit test issue.  Hope that's OK.15:12
mkoderer__cknight: I am still on vacation and don't have time to test ;) - if you delete the mock in time.time does it mean that it runs for some seconds?15:12
mkoderer__cknight: I am back next week actually ;)15:12
cknightmkoderer__: No, I made sure of that.  Sleep is still mocked.15:12
mkoderer__cknight: ahh ok that fine15:13
mkoderer__cknight: thanks for fixing!15:13
cknightmkoderer__: Glad to.  Enjoy the rest of your vacation!15:13
mkoderer__thanks!15:13
*** kaisers_ has joined #openstack-manila15:21
*** vbellur has quit IRC15:30
*** gouthamr has quit IRC15:30
*** vbellur has joined #openstack-manila15:30
*** gouthamr has joined #openstack-manila15:35
*** akapil has quit IRC15:40
gansogouthamr: sorry for the delay15:45
gansogouthamr: just got back from lunch15:45
gansogouthamr: my argument is that migration should be expected to always be disruptive, unless in special cases where drivers can migrate non-disruptively15:46
gansogouthamr: it should be exception, not the norm15:47
*** kaisers_ has quit IRC15:48
*** akshai has quit IRC15:56
*** lpetrut has quit IRC15:58
*** akshai has joined #openstack-manila15:59
*** timcl has quit IRC16:08
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix allow/deny error message and race in migration  https://review.openstack.org/36513616:10
*** akshai has quit IRC16:19
*** permalac has quit IRC16:20
*** akshai has joined #openstack-manila16:21
*** akshai has quit IRC16:25
*** akshai has joined #openstack-manila16:26
*** timcl has joined #openstack-manila16:26
*** nherciu has joined #openstack-manila16:28
*** alyson_ has joined #openstack-manila16:46
openstackgerritMerged openstack/manila: Fix flaky Neutron port binding unit tests  https://review.openstack.org/36946216:55
*** pcaruana has quit IRC16:59
*** aovchinnikov has joined #openstack-manila17:02
*** dustins has joined #openstack-manila17:03
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to address current performance problems, but should return to a working state within a few minutes17:10
openstackgerritMerged openstack/manila: Fix for LV mounting issue in docker containers  https://review.openstack.org/35346317:19
*** lpetrut has joined #openstack-manila17:36
*** Suyi_ has joined #openstack-manila17:37
*** akerr has quit IRC17:38
*** akerr has joined #openstack-manila17:39
gouthamrganso: (sorry for the latency) i understand that, but some people might "accidentally" kick off a disruptive migration when they really wanted manila to only migrate if it can be nondisruptive17:40
*** sandanar has joined #openstack-manila17:42
bswartzgouthamr, tbarron: you've probably seen the answers to my inquiry about string freezes on the stable branches by now17:43
gouthamrbswartz: on this thread? http://lists.openstack.org/pipermail/openstack-dev/2016-September/103279.html17:44
bswartzyeah17:44
bswartzlooks like it was my mistake to -1 backports containing translatable strings17:45
gouthamrbswartz: if i understand correctly, the stance is important bugfixes can introduce/change existing translatable strings?17:45
bswartzno17:45
bswartzthe theory is that string freeze ENDS after the release is cut17:45
gouthamrbswartz: oh!17:45
gouthamrbswartz: #TIL. thank you for clarifying.17:46
bswartzgouthamr: we wouldn't have reached this conclusion if you hadn't pushed for it. thanks for starting the thread17:49
gouthamrbswartz: you're welcome..17:49
*** dustins has quit IRC17:57
*** senk has joined #openstack-manila17:58
*** sandanar has quit IRC18:02
*** ociuhandu has quit IRC18:07
*** akshai has quit IRC18:17
gansogouthamr: ping18:20
gouthamrganso: pong18:20
gansogouthamr: I believe the "non-disruptive" default value change will require a microversion18:21
gansogouthamr: it is a bit too late for that :\18:21
gouthamrganso: it's unreleased yet, and the last API change .. so we can make this a bugfix?18:22
gansogouthamr: no microversion bump?18:22
gouthamrganso: not sure.. i vote no.. because it's still unreleased and we've made no other API changes after 2.2218:23
*** david-lyle has quit IRC18:23
*** david-lyle has joined #openstack-manila18:26
*** dsariel has joined #openstack-manila18:32
*** esker has joined #openstack-manila18:34
*** pcaruana has joined #openstack-manila18:36
*** alyson_ has quit IRC18:38
*** alyson_ has joined #openstack-manila18:38
*** akshai has joined #openstack-manila18:40
*** akshai_ has joined #openstack-manila18:41
*** akshai has quit IRC18:45
*** akerr has quit IRC18:48
*** akerr has joined #openstack-manila18:51
bswartzgouthamr, tpsilva: https://bugs.launchpad.net/manila/+bug/160984119:00
openstackLaunchpad bug 1609841 in Manila "Access allow/deny APIs get stuck due to concurrency" [High,Confirmed] - Assigned to Goutham Pacha Ravi (gouthamr)19:00
bswartzI see a bug targeted but I see no fixes19:01
*** esker has quit IRC19:01
*** vbellur has quit IRC19:03
bswartzalyson_: how is https://review.openstack.org/#/c/366310/ going19:10
bswartzalyson_: also https://review.openstack.org/#/c/356087/19:12
gansobswartz: those 2 should be ready tomorrow19:12
bswartzganso: https://review.openstack.org/#/c/366324/ this doesn't need a RC1 target19:12
bswartzdoes it?19:12
gansobswartz: its purpose was to identify bugs19:13
gansobswartz: since we can see that the tests pass without needing to merge, it does not need to merge before RC119:13
*** dustins has joined #openstack-manila19:13
bswartzyeah19:13
bswartzgenerally speaking, increasing test coverage doesn't need a bug/blueprint19:13
gansobswartz: yes, generally speaking, no19:15
*** aovchinnikov has quit IRC19:15
gansobswartz: https://review.openstack.org/#/c/36513619:16
*** david-lyle has quit IRC19:16
*** eharney has quit IRC19:16
*** gregsfortytwo has quit IRC19:16
*** bhakta has quit IRC19:16
*** dsariel has quit IRC19:16
*** jcsp has quit IRC19:16
*** amitkqed has quit IRC19:16
*** hoonetorg has quit IRC19:16
*** cknight has quit IRC19:17
*** cargonza has quit IRC19:17
*** sage_ has quit IRC19:17
*** dgonzalez has quit IRC19:17
*** madorn has quit IRC19:17
*** markstur has quit IRC19:17
*** vkmc has quit IRC19:17
*** tbarron has quit IRC19:17
*** cFouts has quit IRC19:17
*** logan- has quit IRC19:17
*** porrua has quit IRC19:17
*** StraubTW has quit IRC19:17
*** rooneym has quit IRC19:17
*** zigo has quit IRC19:17
*** zhongjun_ has quit IRC19:17
*** cfey has quit IRC19:17
*** andreaf has quit IRC19:17
*** senk has quit IRC19:17
*** zengyingzhe has quit IRC19:17
*** darrenc has quit IRC19:17
*** scottda has quit IRC19:17
*** ChanServ has quit IRC19:17
*** lpetrut has quit IRC19:17
*** nkrinner_afk has quit IRC19:17
*** zhugaoxiao has quit IRC19:17
*** ameade has quit IRC19:17
*** FL1SK has quit IRC19:17
*** alyson_ has quit IRC19:17
*** yangyapeng has quit IRC19:17
*** rraja has quit IRC19:17
*** harlowja has quit IRC19:17
*** mkoderer__ has quit IRC19:17
*** tries_ has quit IRC19:17
*** erlon has quit IRC19:17
*** ganso has quit IRC19:17
*** amit213 has quit IRC19:17
*** _laco has quit IRC19:17
*** Suyi_ has quit IRC19:17
*** nherciu has quit IRC19:17
*** rhefner has quit IRC19:17
*** MikeG451 has quit IRC19:17
*** jseiler_ has quit IRC19:17
*** aorourke has quit IRC19:18
*** chlong_ has quit IRC19:18
*** gouthamr has quit IRC19:18
*** netapp has quit IRC19:18
*** jay-mehta has quit IRC19:18
*** dustins has quit IRC19:18
*** pcaruana has quit IRC19:18
*** xyang1 has quit IRC19:18
*** kaisers has quit IRC19:18
*** bswartz has quit IRC19:18
*** DuncanT has quit IRC19:18
*** furlongm has quit IRC19:18
*** kaisers2 has quit IRC19:18
*** johnthetubaguy has quit IRC19:18
*** timcl has quit IRC19:18
*** openstackgerrit has quit IRC19:18
*** sticker has quit IRC19:18
*** gopenshaw has quit IRC19:18
*** csaba has quit IRC19:18
*** draynium has quit IRC19:18
*** bkreitch has quit IRC19:18
*** vponomaryov has quit IRC19:18
*** diegows has quit IRC19:18
*** draynium has joined #openstack-manila19:19
*** johnthetubaguy has joined #openstack-manila19:22
*** bhakta has joined #openstack-manila19:22
*** gregsfortytwo has joined #openstack-manila19:22
*** eharney has joined #openstack-manila19:22
*** chlong_ has joined #openstack-manila19:22
*** kaisers has joined #openstack-manila19:22
*** pcaruana has joined #openstack-manila19:22
*** FL1SK has joined #openstack-manila19:22
*** ameade has joined #openstack-manila19:22
*** zhugaoxiao has joined #openstack-manila19:22
*** nkrinner_afk has joined #openstack-manila19:22
*** lpetrut has joined #openstack-manila19:22
*** jay-mehta has joined #openstack-manila19:22
*** bswartz has joined #openstack-manila19:22
*** _laco has joined #openstack-manila19:22
*** ganso has joined #openstack-manila19:22
*** 32NABYQA1 has joined #openstack-manila19:22
*** dsariel has joined #openstack-manila19:22
*** david-lyle has joined #openstack-manila19:22
*** ChanServ has joined #openstack-manila19:22
*** netapp has joined #openstack-manila19:22
*** gouthamr has joined #openstack-manila19:22
*** porrua has joined #openstack-manila19:22
*** StraubTW has joined #openstack-manila19:22
*** rooneym has joined #openstack-manila19:22
*** zigo has joined #openstack-manila19:22
*** zhongjun_ has joined #openstack-manila19:22
*** cfey has joined #openstack-manila19:22
*** andreaf has joined #openstack-manila19:22
*** amitkqed has joined #openstack-manila19:22
*** Suyi_ has joined #openstack-manila19:22
*** nherciu has joined #openstack-manila19:22
*** rhefner has joined #openstack-manila19:22
*** MikeG451 has joined #openstack-manila19:22
*** jseiler_ has joined #openstack-manila19:22
*** aorourke has joined #openstack-manila19:22
*** furlongm has joined #openstack-manila19:22
*** cknight has joined #openstack-manila19:22
*** markstur has joined #openstack-manila19:22
*** sage_ has joined #openstack-manila19:22
*** dgonzalez has joined #openstack-manila19:22
*** madorn has joined #openstack-manila19:22
*** tbarron has joined #openstack-manila19:22
*** vkmc has joined #openstack-manila19:22
*** cFouts has joined #openstack-manila19:22
*** logan- has joined #openstack-manila19:22
*** orwell.freenode.net sets mode: +o ChanServ19:22
*** xyang1 has joined #openstack-manila19:23
*** timcl has joined #openstack-manila19:23
*** openstackgerrit has joined #openstack-manila19:23
*** sticker has joined #openstack-manila19:23
*** gopenshaw has joined #openstack-manila19:23
*** csaba has joined #openstack-manila19:23
*** bkreitch has joined #openstack-manila19:23
*** vponomaryov has joined #openstack-manila19:23
*** diegows has joined #openstack-manila19:23
*** hoonetorg has joined #openstack-manila19:23
*** jcsp has joined #openstack-manila19:23
*** dustins has joined #openstack-manila19:23
*** yangyapeng has joined #openstack-manila19:23
*** rraja has joined #openstack-manila19:23
*** harlowja has joined #openstack-manila19:23
*** tries_ has joined #openstack-manila19:23
*** mkoderer__ has joined #openstack-manila19:23
*** senk has joined #openstack-manila19:23
*** zengyingzhe has joined #openstack-manila19:23
*** darrenc has joined #openstack-manila19:23
*** ameade has quit IRC19:24
*** nherciu has quit IRC19:27
*** draynium has quit IRC19:29
*** draynium has joined #openstack-manila19:34
*** porrua has quit IRC19:36
*** scottda has joined #openstack-manila19:46
*** akshai_ has quit IRC19:48
*** lpetrut has quit IRC19:51
gansobswartz: finally reconnected19:55
*** dsariel has quit IRC19:56
*** erlon has joined #openstack-manila19:58
*** DuncanT has joined #openstack-manila19:59
*** amit213 has joined #openstack-manila19:59
*** eharney has quit IRC19:59
*** eharney has joined #openstack-manila19:59
*** cargonza has joined #openstack-manila20:03
*** rraja has quit IRC20:03
*** ameade has joined #openstack-manila20:04
gansobswartz: so, can we merge that one before RC1?20:04
bswartzganso: you're going to have to recreate the context20:08
bswartzthe netsplit killed my scrollback and I think I missed the last few lines you wrote20:08
gansobswartz: what merged before the FF had a logic in allow_access intended to allow the admin to mount the share between phase 1 and 220:09
gansobswartz: but that logic was broken20:09
gansobswartz: so the patch is fixing the logic, and fixing another concurrency bug20:10
gansobswartz: due to our discussion yesterday, the logic in allow_access is to prevent access now, nlloq20:11
*** pcaruana has quit IRC20:11
gansobswartz: s/nlloq/allow20:11
gansobswartz: nevermind that last part, my keyboard messed up20:13
gansobswartz: so, current patch is preventing any access during migration20:13
*** akerr has quit IRC20:15
*** vbellur has joined #openstack-manila20:17
*** kaisers_ has joined #openstack-manila20:20
*** trinode has joined #openstack-manila20:20
*** trinode has quit IRC20:24
bswartzganso: which current patch? the proposed one or the merged one?20:24
gansobswartz: proposed one20:24
bswartzI thought we agreed that change should wait until ocata20:25
bswartzyou want to make it in newton?20:25
bswartzyou claimed it was proposed and agreed to at the midcycle so we shouldn't just change it without having the discussion again20:26
gansobswartz: but it is broken20:26
gansobswartz: it needs to be fix either to fully allow access or block it20:26
bswartzI thought you had a fix hat makes it not broken20:26
bswartzI was okay with your fix20:27
gansobswartz: this is the fix https://review.openstack.org/#/c/365136/20:27
bswartzI was just confused because the fix shrank a lot20:27
gansobswartz: yes, it was allowing admins to mount the share between phase 1 and phase 220:27
bswartzI'm okay with this20:27
gansobswartz: but yesterday we had the discussion that we wanted to not allow20:27
bswartzI haven't had time to properly review the updated change20:28
gansobswartz: so I changed the code to not to20:28
bswartzdid you see my +2 comment on PS5?20:28
bswartzoh20:28
gansobswartz: I did after I pushed PS 620:29
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Fix Access Rules APIs  https://review.openstack.org/36966820:29
bswartzgouthamr: \o/20:29
bswartzganso: well what would you like to do?20:29
bswartzI can't remember who asked for the "verify" feature, but I'm against it20:30
gansobswartz: thing is, that change, up to PS #5, was changing the driver interface and was introducing behavior that we agreed we prefer to not have right now, and maybe add it later in ocata if we find it to be necessary20:30
gansobswartz: up to PS #5 it had the verify feature20:30
gansobswartz: now the verify feature is removed in latest PS20:31
gansobswartz: we just need to merge it to fix broken API message20:31
bswartzganso: so you prefer PS9 to PS5?20:32
bswartzif so I'll just review it and provide feedback on the new patch20:32
gansobswartz: we agreed PS 9 is what we want, because we don't want to allow the admin to verify at this moment20:32
*** esker has joined #openstack-manila20:33
gansogouthamr: got a question, before digging into the code20:33
gouthamrganso: ask away..20:34
gansogouthamr: in commit message it says state transitions from new, active, error, etc to deleted. why was this status 'deleted' necessary, I thought that we already had this before when we deny the rules20:35
*** cknight has quit IRC20:35
gouthamrganso: when the rules were deleted, they wouldn't update the "state" -> because there was no "state" in the database20:35
gouthamrganso: but with soft_delete, you can ask for a state change.. consistency with the rest of the models20:36
gansogouthamr:  deleted = Column(String(36), default='False')20:36
gouthamrganso: yes, the weird thing about having state and not updating it when deleted is realizing that soft deleted rows have statuses that make no sense..20:37
gansogouthamr: when rules were deleted, before, they were not accounted for anymore20:37
gansogouthamr: oh I mean, you had a deleted = True rule with status 'Active', is that it?20:37
gouthamrganso: yep. that behavior's not changed.. is that line in the commit message confusing?20:37
gouthamrganso: yah20:37
gansogouthamr: thanks, I got it now.20:38
gansogouthamr: no it is not, I was just wondering it that state was attached to any other mechanism20:38
gansogouthamr: it looks better this way20:38
gansogouthamr: *if that state20:38
gouthamrganso: yes20:40
*** lpetrut has joined #openstack-manila20:43
gansogouthamr: I gotta go home now, I'll review the patch tonight20:46
openstackgerritMerged openstack/manila: glusterfs: handle new cli XML format  https://review.openstack.org/35216720:46
gouthamrganso: thank you..20:50
openstackgerritCarlos Camacho proposed openstack/puppet-manila: Test latest puppet-lint  https://review.openstack.org/36968821:02
*** harlowja has quit IRC21:04
*** eharney has quit IRC21:14
*** kaisers_ has quit IRC21:20
*** lpetrut has quit IRC21:21
*** lpetrut has joined #openstack-manila21:21
*** amit213 has quit IRC21:27
*** erlon has quit IRC21:27
*** scottda has quit IRC21:27
*** jcsp has quit IRC21:27
*** dustins has quit IRC21:27
*** yangyapeng has quit IRC21:27
*** mkoderer__ has quit IRC21:27
*** tries_ has quit IRC21:28
*** tries_ has joined #openstack-manila21:28
*** tries_ has quit IRC21:28
*** tries_ has joined #openstack-manila21:28
*** jcsp has joined #openstack-manila21:28
*** dustins has joined #openstack-manila21:28
*** yangyapeng has joined #openstack-manila21:28
*** gouthamr has quit IRC21:28
*** mkoderer__ has joined #openstack-manila21:29
*** scottda has joined #openstack-manila21:34
*** amit213 has joined #openstack-manila21:34
*** erlon has joined #openstack-manila21:35
*** lpetrut has quit IRC21:38
*** gouthamr has joined #openstack-manila21:45
*** dustins has quit IRC21:54
*** esker has quit IRC21:54
*** harlowja has joined #openstack-manila22:03
*** xyang1 has quit IRC22:03
*** erlon has quit IRC22:07
*** ociuhandu has joined #openstack-manila22:16
*** rooneym has quit IRC22:29
*** dsariel has joined #openstack-manila22:33
*** StraubTW has quit IRC22:56
*** dsariel has quit IRC23:36

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!