Wednesday, 2016-08-24

openstackgerritRodrigo Barbieri proposed openstack/manila: Share migration Newton improvements  https://review.openstack.org/32843100:04
openstackgerritRodrigo Barbieri proposed openstack/manila: Add share type change to Share Migration  https://review.openstack.org/34514200:04
*** yangyapeng has quit IRC00:11
openstackgerritJay Mehta proposed openstack/manila: HPE 3PAR driver pool support  https://review.openstack.org/32955200:20
*** Suyi has quit IRC00:22
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Manila install guide: Fix post-install steps  https://review.openstack.org/35949100:22
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Manila install guide: Fix post-install steps  https://review.openstack.org/35949100:25
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Manila install guide: Fix post-install steps  https://review.openstack.org/35949100:26
*** tpsilva has quit IRC00:28
*** qeelee has joined #openstack-manila00:29
*** dustins has quit IRC00:30
openstackgerritGoutham Pacha Ravi proposed openstack/manila: Manila install guide: Fix post-install steps  https://review.openstack.org/35949100:41
openstackgerritRodrigo Barbieri proposed openstack/python-manilaclient: Update Share Migration CLI  https://review.openstack.org/32843700:45
openstackgerritRodrigo Barbieri proposed openstack/python-manilaclient: Add share type change to Share Migration CLI  https://review.openstack.org/34512500:45
*** kaisers_ has joined #openstack-manila00:53
*** kaisers_ has quit IRC00:58
*** JoseMello has quit IRC01:10
*** mtanin___ has quit IRC01:12
openstackgerritCedric Zhuang proposed openstack/manila: Add documentation for EMC Unity Driver for Manila  https://review.openstack.org/35857601:19
*** cknight has joined #openstack-manila01:19
*** chlong has joined #openstack-manila01:20
*** cknight1 has joined #openstack-manila01:22
*** cknight has quit IRC01:24
*** yangyapeng has joined #openstack-manila01:28
*** wangqun has joined #openstack-manila01:45
zhongjun_gouthamr: ping02:10
gouthamrzhongjun_: pong.02:23
*** gouthamr_ has joined #openstack-manila02:25
*** gouthamr has quit IRC02:28
*** kaisers_ has joined #openstack-manila02:42
openstackgerritYingzhe Zeng proposed openstack/manila: Implement replication support in huawei driver  https://review.openstack.org/33158602:43
*** kaisers_ has quit IRC02:46
zhongjun_gouthamr: In https://review.openstack.org/#/c/359316/02:49
zhongjun_gouthamr: Does Netapp can pass the ipv6 tempest test?02:51
gouthamr_zhongjun_: looks like it works for the generic driver02:52
gouthamr_zhongjun_: just ran the job on the CI.. teh NetApp CI waits for Jenkins to vote +1 before kicking off tests..02:52
gouthamr_zhongjun_: ignore my comments on the generic driver.. looks like those tests were skipped..02:53
gouthamr_zhongjun_: but it looks like the tests passed on the ZFS driver.. http://logs.openstack.org/16/359316/2/check/gate-manila-tempest-dsvm-postgres-zfsonlinux/d2bb73f/console.html02:55
gouthamr_zhongjun_: some access rule related failures though. worth digging in..02:55
zhongjun_gouthamr: some access rule related failures, because I change access_type ipv6 to ip02:58
*** yangyape_ has joined #openstack-manila02:59
gouthamr_zhongjun_: maybe remove cifs from the list... some of the errors are because of that03:00
*** yangyapeng has quit IRC03:02
gouthamr_zhongjun_: also take a look at http://logs.openstack.org/16/359316/2/check/gate-manila-tempest-minimal-dsvm-lvm/b896df6/logs/screen-m-shr.txt.gz?level=TRACE#_2016-08-23_18_23_59_32803:02
zhongjun_gouthamr_: Many driver CI not run, so I could not see all of feedback03:02
gouthamr_zhongjun_: that's the log from teh LVM driver03:03
gouthamr_zhongjun_: we're using netaddr to validate the range ... and the validation is failing03:03
*** gouthamr_ is now known as gouthamr03:05
zhongjun_gouthamr: The validation is failing, Because I passed all of the ip.03:08
*** mtanino has joined #openstack-manila03:08
zhongjun_gouthamr: https://review.openstack.org/#/c/359316/2/manila/api/v1/shares.py03:08
gouthamrzhongjun_: oh03:09
gouthamrzhongjun_: those are "expected" failures then :)03:09
zhongjun_gouthamr: yes03:09
gouthamrnp.. this is a good test patch.. we can still get some insights..03:09
*** yangyapeng has joined #openstack-manila03:12
*** yangyape_ has quit IRC03:12
*** yangyape_ has joined #openstack-manila03:13
*** yangyapeng has quit IRC03:13
openstackgerritPeter Wang proposed openstack/manila: Use job for NFS share creation  https://review.openstack.org/35956703:20
openstackgerritPeter Wang proposed openstack/manila: Use job for NFS share creation  https://review.openstack.org/35956703:22
*** gouthamr has quit IRC03:36
*** gouthamr has joined #openstack-manila03:37
*** ganso has quit IRC03:41
*** gouthamr has quit IRC03:45
*** cknight1 has quit IRC03:48
*** cknight has joined #openstack-manila03:49
openstackgerritzhongjun proposed openstack/manila: [DNM] Test IP(ipv4 and ipv6) rules with all drivers  https://review.openstack.org/35931603:52
*** shausy has joined #openstack-manila04:29
*** kaisers_ has joined #openstack-manila04:31
openstackgerritPeter Wang proposed openstack/manila: VNX: Use job for NFS share creation  https://review.openstack.org/35956704:32
*** kaisers_ has quit IRC04:35
*** cknight has quit IRC04:39
*** mtanino has quit IRC04:42
marksturbswartz, et. al.  I'm on jury duty this week. Will miss the weekly meeting and be away from IRC.04:55
*** markstur is now known as markstur_jury_du04:56
*** lpetrut has joined #openstack-manila05:20
*** yangyape_ has quit IRC05:32
*** nkrinner_afk is now known as nkrinner05:43
*** yangyapeng has joined #openstack-manila05:45
*** sandanar has joined #openstack-manila06:02
openstackgerritgecong proposed openstack/manila: Correct reraising of exception  https://review.openstack.org/35961206:18
*** kaisers_ has joined #openstack-manila06:19
*** lpetrut has quit IRC06:20
*** aovchinnikov has joined #openstack-manila06:22
*** lpetrut has joined #openstack-manila06:22
*** kaisers_ has quit IRC06:24
*** FL1SK has quit IRC06:27
*** lpetrut has quit IRC06:33
*** rraja has joined #openstack-manila06:38
*** lpetrut has joined #openstack-manila06:46
*** kaisers_ has joined #openstack-manila06:47
*** tovchinnikova has joined #openstack-manila06:53
*** lpetrut has quit IRC07:03
*** nkrinner has quit IRC07:21
*** nkrinner has joined #openstack-manila07:25
openstackgerritgecong proposed openstack/manila: Correct reraising of exception  https://review.openstack.org/35961207:27
*** nkrinner has quit IRC07:30
*** nkrinner has joined #openstack-manila07:43
openstackgerritzhongjun proposed openstack/manila: [DNM] Test IP(ipv4 and ipv6) rules with all drivers  https://review.openstack.org/35931607:49
*** FL1SK has joined #openstack-manila08:26
*** aovchinnikov has quit IRC08:27
*** pcaruana has joined #openstack-manila08:29
*** aovchinnikov has joined #openstack-manila09:32
*** lpetrut has joined #openstack-manila09:59
*** tovchinnikova has quit IRC10:13
*** lpetrut1 has joined #openstack-manila10:14
*** lpetrut has quit IRC10:15
*** lpetrut1 is now known as lpetrut10:15
*** yangyapeng has quit IRC10:19
*** kaisers_ has quit IRC10:30
*** wangqun has quit IRC10:34
*** shausy has quit IRC10:45
*** shausy has joined #openstack-manila10:45
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023610:56
*** JoseMello has joined #openstack-manila11:05
openstackgerritRamana Raja proposed openstack/manila: glusterfs: handle new cli XML format  https://review.openstack.org/35216711:09
*** alyson_ has joined #openstack-manila11:15
*** timcl has joined #openstack-manila11:18
*** tpsilva has joined #openstack-manila11:34
*** yangyapeng has joined #openstack-manila11:47
*** dustins has joined #openstack-manila12:02
*** xyang1 has joined #openstack-manila12:14
*** kaisers_ has joined #openstack-manila12:18
*** kaisers_ has quit IRC12:23
*** gouthamr has joined #openstack-manila12:26
*** xyang1 has quit IRC12:34
*** xyang1 has joined #openstack-manila12:36
*** porrua has joined #openstack-manila12:37
*** ganso has joined #openstack-manila12:40
gansoxyang1, gouthamr, markstur_jury_du, bswartz, tbarron: Hello folks, could you please a look at the scenario job fix? :) #link https://review.openstack.org/#/c/35916612:41
gouthamrganso: how do we know 50.2.5.x isn't part of a tenant network allocation?12:53
bswartzganso: where does the 50.2.5.0/24 range come from?12:53
bswartzyou can't just make up subnet ranges12:53
gansobswartz: it can be overwritten from local.conf12:54
gansobswartz: FIXED_RANGE is defined in there, ADMIN_NET_RANGE is not12:55
gansogouthamr: in CI it is not part of any existing tenant12:58
gouthamrganso: for the CI specifically, setting the opt in contrib/ci/pre_test_hook.sh makes sense12:59
gouthamrjust like $FIXED_RANGE, if not specified, you can't use that setting.. rather than have a network range for a normal devstack13:00
tbarronoh, you guys are asking just hat I asked on the review :)13:01
tbarronganso: thanks for figuring out what was going on, btw13:02
gansogouthamr: ok, I will move and export it in pre_test_hook, and add conditions to not the config if not defined13:04
gansogouthamr: not *do the config13:04
gouthamrganso: +1 thanks...13:04
gansogouthamr: thanks for the feedback13:05
gansogouthamr: forgot that plugin.sh is also used by other installations, not only CI13:05
gouthamrganso: np.. running tempest against the new optimized migration fixes; how brave do you feel this morning? :D13:06
gansogouthamr: lol13:06
gansogouthamr: speaking of which13:06
gansogouthamr: I think I will have to kidnap Valeriy's dummy driver migration support patch13:07
gouthamr* with DHSS=True... something vponomaryov didn't add in a "real" driver. :P13:07
*** eharney has joined #openstack-manila13:07
gouthamrganso: nice.. i think the ZFS patch needs an update too.. i guess bswartz was going to help with that13:08
gouthamrganso: quick q13:15
gouthamrganso: didn't understand your answer for "why can't tempest migrate between two pools"13:16
*** akerr has joined #openstack-manila13:17
gansogouthamr: testing with dummy driver had 4 backends, 2 DHSS=True and 2 DHSS=False13:19
gansogouthamr: tempest isn't smart enough to choose the one that has a compatible share type13:19
gansogouthamr: like, it creates the share originally with DHSS=True, so, for that share type, it can only be migrated to another DHSS=True pool13:20
gansogouthamr: and it doesn't know how to choose, there is no API that exposes the pool capabilities to tempest13:20
gansogouthamr: so I used the etc/tempest.conf [share] backend_names config option to determine which tempest can choose13:21
gouthamrganso:  self.shares_client.list_pools()['pools'] is teh API to expose pool capabilities13:21
gansogouthamr: humm if I am not mistaken, it doesn't show capabilities13:22
gouthamrganso: it does, use 'details=True' :)13:22
gansogouthamr: I probably did not try that13:22
gansogouthamr: ok I can refactor that, and then it won't need the enabled_backends option anymore13:23
gouthamrganso: https://github.com/openstack/manila/blob/master/manila_tempest_tests/tests/api/base.py#L602 <-- example13:23
bswartzganso: why not 10.2.5.0/24 ?13:23
gansobswartz: I don't know, why 10.2.5.0/24 ? for CI I believe it doesn't really matter13:24
gansobswartz: I'll move from plugins.sh to pre_test_hool.sh btw13:25
bswartzganso: it matters13:25
bswartzganso: 50.2.5.0/24 is routable, 10.2.5.0/24 is not13:25
*** openstackgerrit has quit IRC13:26
bswartzganso: read RFC 1918 if you don't know the difference13:26
gansobswartz: Yea I just google on that. Addresses that are supposed to be reached from the internet13:27
*** openstackgerrit has joined #openstack-manila13:27
gansobswartz: I will include that in the upcoming patch13:28
*** rraja has quit IRC13:33
*** eharney has quit IRC13:38
*** qeelee has quit IRC13:38
*** eharney has joined #openstack-manila13:43
*** rraja has joined #openstack-manila13:44
*** rraja has quit IRC13:45
*** sandanar has quit IRC13:45
*** rraja has joined #openstack-manila13:45
openstackgerritAlexey Ovchinnikov proposed openstack/manila: [DNM] Tests for scenario tests  https://review.openstack.org/34023613:50
*** aovchinnikov has quit IRC13:52
*** kaisers_ has joined #openstack-manila14:07
*** kaisers_ has quit IRC14:11
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix connectivity problem in Scenario job  https://review.openstack.org/35916614:22
*** kaisers_ has joined #openstack-manila14:32
*** dsariel has joined #openstack-manila14:36
*** eharney has quit IRC14:36
*** shausy has quit IRC14:40
*** rraja has quit IRC14:44
*** cknight has joined #openstack-manila14:48
*** shausy has joined #openstack-manila14:51
*** dustins has quit IRC14:51
*** kaisers_ has quit IRC14:52
*** eharney has joined #openstack-manila14:55
*** rraja has joined #openstack-manila14:56
*** rraja has quit IRC14:57
*** vbellur has quit IRC15:02
*** kaisers_ has joined #openstack-manila15:08
*** nkrinner is now known as nkrinner_afk15:16
*** david-lyle_ has joined #openstack-manila15:25
*** david-lyle_ has quit IRC15:26
*** vbellur has joined #openstack-manila15:28
*** shausy has quit IRC15:29
*** dsariel has quit IRC15:35
openstackgerritzhongjun proposed openstack/manila: [DNM] Test IP(ipv4 and ipv6) rules with all drivers  https://review.openstack.org/35931615:41
*** dsariel has joined #openstack-manila15:47
*** Suyi has joined #openstack-manila16:32
tpsilvacknight, tbarron, xyang1: hey folks! could you please take a look on this hitachi driver patch? I think it's ready for merge for quite a while: https://review.openstack.org/#/c/356049/16:33
tpsilvathank you!16:33
*** kaisers_ has quit IRC16:34
cknighttpsilva: Looks good, thanks for doing this.16:39
bswartzganso: I'm testing your patch now, and I put a comment on it16:49
bswartzganso: can you explain how data_node_access_ip works?16:49
gansobswartz: which patch?16:49
bswartzhttps://review.openstack.org/35916616:49
*** mtanino has joined #openstack-manila16:50
tpsilvacknight: thank you16:50
gansobswartz: data_node_access_ip is the IP of the data node in the admin network, which should be given access to so shares can be mounted in the data node16:50
tbarrontpsilva: should you trigger a recheck on hitachi-hsp ?16:50
bswartzganso: your patch sets its value to a subnet though16:51
gansobswartz: yes, since I am not employing any mechanism to detect the node IP, I am using the subnet, as I was already doing before16:51
bswartzbut in a devstack-gate environment, what IP does it actually use?16:51
gansobswartz: the subnet range specified is able to be used both for the driver admin network and the data node16:52
bswartzganso: does something create an IP in that subnet for the manila node to use?16:52
bswartzI just don't understand how the packets are flowing16:52
tpsilvatbarron: this patch is regarding hitachi hnas16:52
gansobswartz: the IP is generated at run time16:53
tpsilvatbarron: doesn't touch hsp driver code16:53
gansobswartz: so the node running the test has many interfaces16:53
tpsilvatbarron: but I see it failed... will check the hsp CI16:53
gansobswartz: it has eth0, eth1, etc... and it has a tap interface which is assigned an IP in the admin_net16:53
tpsilvatbarron: hnas CI is ok16:53
bswartzganso: can you point to the code that creates the tap interface?16:53
gansobswartz: we do not know which IP that tap interface will have, the generic driver will create it16:53
tbarrontpsilva: yeah, that's what I thought, but the optics :)16:53
gansobswartz: yes, just a sec16:54
tpsilvatbarron: but hey, thanks... I'll check what's going on with that CI16:54
bswartzganso: the tap interface that the generic driver creates would be the server IP, no the client IP16:54
bswartzganso: access rule should specify the client IP or IP range16:54
gansobswartz: https://github.com/openstack/manila/blob/master/manila/share/drivers/service_instance.py#L89216:54
tbarrontpsilva: I'll go on and +2, the code looks fine.  Dunno if you need that other CI passing for +W, will let the cores with more experience here decide16:55
bswartzganso: thanks, but as I said above that's an IP of the NFS server not the client16:55
gansobswartz: yes, there is another one, I am looking for it16:56
tpsilvatbarron: thank you16:56
tbarrontpsilva: bswartz woops, pressed +W by mistake, but I think it's fine :)16:56
gansobswartz: there are 2 IPs, one the share server will have (the one I linked you) and the one in the host16:56
bswartztbarron: >_<16:56
bswartztbarron: which patch16:56
tbarrontpsilva: if your other driver breaks for some reason I can't  fathom b/c of this patch, it's on you16:56
cknighttbarron: I think it's fine, I asked them to move this driver when they added the HSP one.16:56
tbarroneverybocy else is passing16:56
tpsilvatbarron, bswartz: it's fine... think it's an isolated failure of that CI16:57
tbarroncknight: +116:57
tbarronbswartz: https://review.openstack.org/#/c/356049/16:57
bswartztbarron: looks fine it got 2 +2s16:58
gansobswartz: https://github.com/openstack/manila/blob/master/manila/share/drivers/service_instance.py#L101316:58
gansobswartz: that one goes to the host16:58
gansoso the share server and the host have IPs, they can reach each other16:58
gansobswartz: the host is actually the data node itself16:58
bswartztbarron: everyone makes that mistake eventually -- if you do it on a patch that really shouldn't merge you know you can throw it out of the gate by removing the +W and pushing a new patchset right?16:58
gansobswartz: so when it is invoked "allow_access" with the host IP, the host can mount it16:59
gansobswartz: since it is very hard to determine at run time, for CI only, we use the subnet16:59
tbarronbswartz: yeah, that was one of valeriy's pro tips when i was inducted, but thanks for the reminder16:59
bswartztbarron: it seemed timely16:59
tbarron:)17:00
bswartzganso: running some experiments with that17:00
gansobswartz: experiments?17:01
bswartzganso: I want to avoid hacking core stuff to work around weird generic driver limitations17:04
bswartzso I'm trying to figure out if we can make generic more like everything else in this case17:05
gansobswartz: actually, after we introduced "admin networks" to drivers, it made most of them consistent17:06
gansobswartz: I remember talking to cknight about this back in Mitaka17:06
gansobswartz: for any share that has an export in the admin network, you would just use the data node IP address instead of range, then it works17:07
bswartzganso: yes but it seems that, weirdly, if you use generic driver you'll get one of these IP per share server17:08
gansobswartz: the one in L1013 no17:08
gansobswartz: unless, it is in different share networks17:09
cknightbswartz, ganso:  My main objection in the mitaka code was that if I had an access rule for the same address as the data node address, the rule was deleted at the end of the migration.  It's probably not a common use case, but it's annoying in a dev environment.17:09
gansocknight: I may have fixed that. I don't remember17:09
gansocknight: I remember the problem, but I don't remember if I fixed it17:09
cknightganso: You didn't want to fix it in Mitaka.  I haven't tried since then.17:09
gansocknight: yes, but I may have fixed later17:10
*** JoseMello has quit IRC17:10
*** dsariel has quit IRC17:17
*** aovchinnikov has joined #openstack-manila17:27
openstackgerritMerged openstack/manila: add access_key to share_access_map  https://review.openstack.org/34330617:32
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix connectivity problem in Scenario job  https://review.openstack.org/35916617:39
gansobswartz: ^17:44
gansobswartz: btw, I believe we are going to miss manila-ui FF for share migration17:52
*** dustins has joined #openstack-manila17:52
*** timcl has quit IRC17:54
*** timcl has joined #openstack-manila17:54
gouthamrbswartz: can you take a look and +1 this removal patch? https://review.openstack.org/#/c/359235/17:58
gouthamrbswartz: we merged the install guide in-tree and I have the last few fixes here: https://review.openstack.org/#/c/359491/17:58
bswartzganso: what do we need to merge?17:58
gansobswartz: for manila-ui? 3 big patches17:59
gansobswartz: + manila-ui's17:59
bswartzganso: the UI patches depend on the manila patches?17:59
*** lpetrut has quit IRC17:59
* bswartz sighs17:59
bswartzthat's a disappointment17:59
gansobswartz: they don't have depends-on in the commit message, but to work, they do18:00
*** vbellur has quit IRC18:00
bswartzyeah we can't release a manila UI that doesn't work18:00
*** Yogi1 has joined #openstack-manila18:00
gansobswartz: can we remove a feature in manila-ui bugfix period (between FF and RC1) if we think it is not good?18:01
openstackgerritMerged openstack/manila: Updated from global requirements  https://review.openstack.org/35951618:01
bswartzganso: we could, but that's not an excuse to merge a feature that doesn't work yet18:01
gansobswartz: it works (still needs to be updated with nondisruptive parameter I added yesterday to main share migration patch), but it may not be bug-free or results be satisfactory18:02
gansobswartz: but yes, it is not right to merge it before share migration main patches18:02
gansobswartz: if main share migration patches were merged, we could do that even with some bugs and fix later18:03
bswartzokay so we should just merge all the manila migration patches before the end of the day today?18:03
bswartz:-D18:03
gansobswartz: but I highly advise people to try it and see what they think18:03
gansobswartz: lol18:04
gansobswartz: if could if they are all reviewed, have you taken a look at https://review.openstack.org/#/c/345142/ yet ?18:04
gansobswartz: *we could if...18:04
bswartzganso: needs a rebase18:05
gansobswartz: ^ that one is a bit scary DB migration... seems like it hasn't broken anything18:05
gansobswartz: yes, I know... will rebase it very soon, later today18:05
gansobswartz: I still would like to update the dummy driver support patch18:08
*** vbellur has joined #openstack-manila18:16
tbarrontpsilva: one #openstack-infra mwhahaha just asked: Anyone know who the owner of 'Hitachi Manila HNAS CI' is and why it's trying to run on puppet-swift changes?18:16
tpsilvatbarron: hm, weird18:17
tpsilvatbarron: I'll check with our CI guy :)18:17
tpsilvatbarron: thanks for letting me know18:17
tbarrontpsilva: is it you they want to talk to?18:17
tpsilvatbarron: no... it's marcusvrn18:18
tbarrontpsilva: k, they are making noises about disabliing stuff over in #openstack-infra18:19
*** aovchinnikov has quit IRC18:19
tpsilvatbarron: I'll get in there to check that as well18:19
tpsilvathank you18:19
*** marcusvrn_ has joined #openstack-manila18:20
tpsilvatbarron: thanks a lot... sounds like if we missed that it could get disabled18:22
*** akerr has quit IRC18:23
tbarrontpsilva: yeah, I don't really know.  Don't see the relevant parties on this channel to ask, just seemed safer to check.18:24
*** akerr has joined #openstack-manila18:24
*** rooneym has quit IRC18:25
tpsilvatbarron: I'll setup some keywords to get notifications from openstack-infra to avoid that happening again :)18:26
tbarrontpsilva: i have a ping on 'manila'.  not too annoying yet.18:29
*** aovchinnikov has joined #openstack-manila18:40
*** lpetrut has joined #openstack-manila18:43
bswartzwho is mwhahaha?19:10
bswartzganso: no matter what I do, admin_net and default have the same IP range19:13
* bswartz must be doing something wrong19:14
gansobswartz: so you are trying to override and it is not working?19:14
bswartzganso: what local.conf options should I use to set them19:19
bswartzI was using FIXED_RANGE and MANILA_ADMIN_NET_RANGE19:19
bswartzonly the value for FIXED_RANGE got used though19:20
*** lpetrut has quit IRC19:26
bswartzganso: ah I was using your old patch not your new one19:27
bswartztrying again now19:27
*** lpetrut has joined #openstack-manila19:30
*** lpetrut has quit IRC19:33
gansobswartz: I am not sure, but I believe it will only work if you export the env var... not if you set in local.conf prior to stacking19:35
bswartzganso: o_O19:35
gansobswartz: i've seen this for several env vars in my CI19:35
bswartzganso: the whole point for local.conf is to set the variables that devstack consumes19:35
bswartzganso: if that doesn't work we may have bugs in our devstack plugin19:36
gansobswartz: yes, but I don't know if the script exports everything that is in local.conf before starting pre_test_hook. in that case it would work, but as I've seen this not work in my CI I am led to believe it does not do this19:36
gansobswartz: this forces us to check if something is in local.conf before doing anything19:37
bswartzit shouldn't need to export...19:37
bswartzwe should always read from localconf19:37
gansobswartz: we currently just add to local.conf, regardless of what is there, so it may in fact end up overwriting local.conf I suppose19:37
*** lpetrut has joined #openstack-manila19:38
gansobswartz: I mostly replicated what is already in pre_test_hook.sh19:38
bswartzganso: there's only 1 export in there, and it's MANILA_TEMPEST_CONCURRENCY19:39
gansobswartz: yes, but all other values such as echo "TEMPEST_CONCURRENCY=${MANILA_TEMPEST_CONCURRENCY:-8}" >> $localrc_path19:41
akerra lot of values are set in post_test_hook because it runs after devstack and can use iniset to update the conf files19:41
bswartzright. most of that file is generating local.conf19:42
gansobswartz: I am not sure if that is overriding if TEMPEST_CONCURRENCY is already set19:42
bswartzI don't use the pre test hooks or the post test hooks19:42
bswartzdevelopers aren't supposed to use those -- they're ONLY for CI19:42
bswartzthe devstack plugin is meant to stand on its own19:42
gouthamrganso: so, migration-get-progress will remain a call through newton..19:44
gouthamrganso: while migration-start changes from RPC call to cast19:44
*** aovchinnikov has quit IRC19:45
gouthamrganso: wanted to point out that i ran into an issue with this.. i was in the middle of a m-shr restart; and the RPC call timed out after a while19:45
gouthamrganso: maybe, before you make the call, you need to check if the service is up and enabled19:46
gansogouthamr: timeout is 60 seconds19:46
gansogouthamr: hummm, could do that19:47
gouthamrganso: yeah.. why wait, you can send an error immediately19:47
bswartzoookay my scripts are seriously buggy19:50
bswartzthat's why none of this is working right19:50
gansobswartz: for CI it is using pre_test_hook, which sets the variable in local.conf... plugin.sh reads what is in local.conf. This is what the user would use, so there is no problem here19:51
gansobswartz: if a user is setting in local.conf, then it will work19:51
bswartzganso: yeah ignore all my earlier comments until I stop being an idiot19:51
bswartzI'll get this right, then I'll complain if I'm still having an issue19:52
gansobswartz: but the case where it might not work because local.conf is overriden as I said above is for CI as well, not user's19:52
gansobswartz: as for "might not work" I mean, what is set in local.conf previously to devstack... pre_test_hook is ensuring the default is being applied19:52
*** porrua has quit IRC20:06
openstackgerritMerged openstack/manila: Rename and move HNAS driver  https://review.openstack.org/35604920:07
*** Yogi1 has quit IRC20:08
bswartzganso: okay sanity has returned20:14
*** vbellur has quit IRC20:14
bswartzI'm seeing the networks created correctly by devstack now20:14
bswartzonly issue is that generic driver doesn't seem to have a network interface on the tenant subnet20:15
*** akerr has quit IRC20:15
gansobswartz: AFAIK it shouldn't have, there is a config "connect_to_tenant_network" that needs to be set for that, but it is not by default. The default is to have a router connect the manila_service_network and the tenant_network... not a network interface20:17
*** akerr has joined #openstack-manila20:45
*** akerr_ has joined #openstack-manila20:47
*** akerr has quit IRC20:50
bswartzganso: okay I'm having different problems with the generic driver now (related to cinder) but I think your patch is fine20:55
gansobswartz: great, can we merge it then? :)20:56
bswartzanyone seen this failure w/ generic driver? http://paste.openstack.org/show/563138/20:57
bswartzganso: -1 from jenkins20:58
gansobswartz: dang... I will check that once I get home20:58
gouthamrbswartz: manila service tenant issues?20:58
bswartzk it looks fine to me other than that20:58
bswartzgouthamr: yeah probably something changed and I didn't update my conf20:59
bswartzgouthamr: if you know what the change is it would help20:59
gouthamrbswartz: strange this is DHSS=True?21:00
bswartzyes, generic21:00
gouthamrbswartz: the nova VM got created fine, but the cinder API gave you an error; weird indeed.. nope never seen that issue.. 401 is the auth token response from the cinder wsgi app..21:03
openstackgerritJay Mehta proposed openstack/manila: Enhance setup_server() unit-tests for Huawei, generic, share drivers  https://review.openstack.org/36008821:10
*** timcl has quit IRC21:23
*** gouthamr has quit IRC21:23
*** dsariel has joined #openstack-manila21:38
*** gouthamr has joined #openstack-manila21:42
*** lpetrut has quit IRC21:55
*** alyson_ has quit IRC22:03
*** dsariel has quit IRC22:12
*** dustins has quit IRC22:18
*** cknight has quit IRC22:31
*** marcusvrn_ has quit IRC22:54
*** zigo has quit IRC22:56
*** zigo has joined #openstack-manila22:57
*** tpsilva has quit IRC23:08
*** faiz89 has joined #openstack-manila23:22
*** xyang1 has quit IRC23:31
*** cknight has joined #openstack-manila23:40
*** cknight1 has joined #openstack-manila23:46
*** cknight has quit IRC23:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!