Tuesday, 2016-08-02

*** Suyi_ has quit IRC00:01
*** adrianofr has quit IRC00:01
*** yangyapeng has quit IRC00:02
*** faiz89 has joined #openstack-manila00:10
*** gouthamr has joined #openstack-manila00:23
*** faiz89 has quit IRC00:23
*** gouthamr_ has joined #openstack-manila00:24
*** gouthamr has quit IRC00:28
*** mtanin___ has joined #openstack-manila00:28
*** mtanino has quit IRC00:30
*** tpsilva has quit IRC00:36
*** vbellur has joined #openstack-manila01:05
*** cfey has quit IRC01:10
*** liyifeng has quit IRC01:12
openstackgerritzhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs  https://review.openstack.org/30444901:15
*** yangyapeng has joined #openstack-manila01:16
zhongjun_vponomaryov: ping01:18
*** cknight has joined #openstack-manila01:25
*** yangyape_ has joined #openstack-manila01:47
*** yangyapeng has quit IRC01:47
*** mtanin___ has quit IRC01:52
*** yangyapeng has joined #openstack-manila01:59
*** yangyape_ has quit IRC02:02
*** liyifeng has joined #openstack-manila02:03
*** ganso has quit IRC02:11
*** amitkqed has quit IRC02:30
*** amitkqed has joined #openstack-manila02:30
*** yangyapeng has quit IRC02:36
*** yangyapeng has joined #openstack-manila02:36
*** akapil has joined #openstack-manila02:42
*** akapil has quit IRC02:47
*** gouthamr_ has quit IRC03:31
*** bill_az has quit IRC03:46
*** shausy has joined #openstack-manila03:57
*** akapil has joined #openstack-manila04:57
*** akapil has quit IRC05:01
*** nkrinner_afk is now known as nkrinner05:17
*** cknight has quit IRC05:28
*** cknight has joined #openstack-manila05:31
*** nidhimittalhada has joined #openstack-manila05:47
nidhimittalhadahttps://review.openstack.org/315012   https://review.openstack.org/348160   https://review.openstack.org/342104   Can someone please review this?  @vponomaryov @gouthamr @markstur @bswartz @ganso05:48
*** nidhimittalhada has quit IRC05:57
*** cknight has quit IRC06:03
*** lpetrut has joined #openstack-manila06:06
*** tovchinnikova has joined #openstack-manila06:21
*** lpetrut has quit IRC07:26
*** dsariel has joined #openstack-manila07:30
*** lpetrut has joined #openstack-manila07:37
openstackgerritMarc Koderer proposed openstack/manila: Add MTU information in DB and API  https://review.openstack.org/34950607:39
*** gaurangt has joined #openstack-manila07:45
*** lpetrut has quit IRC07:46
openstackgerritAlexey Ovchinnikov proposed openstack/manila: Container driver  https://review.openstack.org/30893008:05
*** MikeG451 has quit IRC08:17
*** DuncanT has quit IRC08:19
*** DuncanT has joined #openstack-manila08:20
*** MikeG451 has joined #openstack-manila08:31
*** lpetrut has joined #openstack-manila09:02
*** tovchinnikova has quit IRC09:11
*** jcsp has joined #openstack-manila10:07
*** jcsp has quit IRC10:08
*** jcsp has joined #openstack-manila10:08
*** yangyapeng has quit IRC10:23
openstackgerritBéla Vancsics proposed openstack/manila: Use more specific asserts in tests  https://review.openstack.org/34992610:35
*** timcl has joined #openstack-manila10:52
*** tovchinnikova has joined #openstack-manila10:54
vponomaryovjseiler: case you described is use case, and you should just handle such input in your driver, and don't disable test as tpsilva suggests11:02
*** rraja has joined #openstack-manila11:07
*** ganso has joined #openstack-manila11:19
*** gaurangt has left #openstack-manila11:21
*** yangyapeng has joined #openstack-manila11:26
zhongjun_vponomaryov: hi, in https://review.openstack.org/#/c/348160/11:40
vponomaryovzhongjun_: hello11:41
zhongjun_vponomaryov: I saw you update share/snapshot size to 1 after manage share/snapshot fail11:41
vponomaryovand?11:41
zhongjun_vponomaryov: but I have a confuse: the quota(shares, share_gigabytes) will not be changed when we manage share(test_A) fail.  but the quota(shares, share_gigabytes) will be changed(-1) when we delete share(test_A)11:43
zhongjun_vponomaryov: Because we update share size to 1 after manage share(test_A) fail11:44
vponomaryovzhongjun_: your statement "the quota(shares, share_gigabytes) will not be changed when we manage share(test_A) fail" is false11:46
zhongjun_vponomaryov: you means the shares quota value will be changed?11:48
zhongjun_vponomaryov: I test it, did I miss something?11:49
vponomaryovzhongjun_: sorry, you are right, "manage_share" method just has a bug, it should update quota always - https://github.com/openstack/manila/blob/225bae39/manila/share/manager.py#L154811:49
jseilervponomaryov: Thank you. After I posted above, I realized IP Address '1.2.3.4/32' is really just a single IP Address. Our file system can handle that, I was just sending it down wrong.11:50
jseilervponomaryov: So it turns out, I do not need to disable a single test case. And thank you for clarifying that a single test case should not be disabled.11:51
zhongjun_vponomaryov: so, we need to update quota if the manage operation fail, or not update size to 1 and check the size type when we delete a share.11:55
vponomaryovzhongjun_: update always11:56
jseilerganso: I was trying to run the scenario tests. My driver is reporting snapshot_support = False. In tempest.conf, I have run_snapshot_tests = False. The scenario tests fail.11:57
gansojseiler: which scenario tests are failing?12:00
gansovponomaryov: ping12:00
vponomaryovganso: ?12:00
jseilerganso: {0} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsCIFS.test_mount_share_one_vm [41.133299s] ... FAILED12:00
jseiler{1} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_mount_share_one_vm [40.221991s] ... FAILED12:00
jseiler{1} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_read_write_two_vms [32.301221s] ... FAILED12:00
jseiler{0} manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsCIFS.test_read_write_two_vms [32.682002s] ... FAILED12:00
gansovponomaryov: Hi Valeriy12:00
gansojseiler: these tests are not related to snapshots12:01
vponomaryovganso: Hello Rodrigo, just see this -> https://bugs.launchpad.net/manila/+bug/160829312:01
openstackLaunchpad bug 1608293 in Manila "tempest tests for migration do not check for snapshot support" [Undecided,New]12:01
jseilerganso: I checked the console messages, but then also checked the m-sch window12:01
vponomaryovjseiler: you just verified existing bug ^12:02
gansovponomaryov: I am aware of that problem, it is fixed in one of my patches, I was thinking yesterday about moving the fix to a separate, more urgent patch12:02
zhongjun_vponomaryov: update always, sounds like there are so many places need to change.12:02
jseilerganso: in the scheduler, I noticed the message ' Share type ext12:02
jseilerra spec requirement "snapshot_support=<is> True" does not match reported capability "False" '12:02
gansojseiler: could you please paste the error in paste.openstack.org and post here?12:02
gansovponomaryov: it is a negative test that is related to the bug, not scenarios12:03
vponomaryovganso: fix of that bug should be separate12:03
vponomaryovganso: we have scenario tests with migration12:03
vponomaryovzhongjun_: could be12:03
gansovponomaryov: yes, but there is a negative test that tries to create snapshot without checking if it is supported12:04
vponomaryovganso: then we have two places with this bug12:05
vponomaryovganso: scenario tests do not pay attention to that config option12:05
gansovponomaryov: this is why I want to see the logs.   manila_tempest_tests.tests.scenario.test_share_basic_ops.TestShareBasicOpsNFS.test_mount_share_one_vm [40.221991s] ... FAILED is not related to migration at all12:05
zhongjun_vponomaryov: How about we not update the size to 1 when manage fail? because actually the size is zero. Is there another problem if we not update the share size to 1.12:06
vponomaryovganso: it is related to wrong share type12:06
gansovponomaryov: yes, I assume it uses the default type12:06
vponomaryovganso: scenario tests run only with snapshot_support=True now12:06
gansovponomaryov, jseiler the default type has to be changed in manila.conf to one that has snapshot_support = False12:07
gansojseiler: that might fix your problem12:07
gansovponomaryov: really?12:07
gansovponomaryov: why?12:07
vponomaryovbecause bug12:07
vponomaryov))12:07
gansovponomaryov: lol12:07
vponomaryovSincerely your captain obvious12:07
gansovponomaryov: anyway, I pinged you to talk about something else12:08
vponomaryovzhongjun_: every registered thing should be handles correctly12:08
*** alyson_ has joined #openstack-manila12:08
vponomaryovs/handles/handled/12:08
jseilerganso: Thanks. Let me try that.12:08
gansovponomaryov: I believe our migration names discussion outcome will be implemented in https://review.openstack.org/#/c/328431/12:08
vponomaryovzhongjun_: it is developer problem how complex it is12:09
gansovponomaryov: not https://review.openstack.org/#/c/332267/12:09
gansovponomaryov: so there is no need to block the fix because of this12:09
vponomaryovganso: "fix" ? )))12:09
gansovponomaryov: the big fix12:10
vponomaryovganso: why there?12:10
vponomaryovganso: when it directly influences implementation of share migration support?12:11
gansovponomaryov: because existing names have been agreed in mitaka12:11
vponomaryovganso: ?12:11
gansovponomaryov: and the other patch "newton migration improvements" can change that and bump API microversion12:11
vponomaryovganso: ther eis no relation of API to the driver inerface12:11
vponomaryovganso: still don't see a reason for making there12:12
gansovponomaryov: so are you saying you prefer the API to have one name and interface a different one?12:12
vponomaryovganso: I am saying they are not related directly12:12
vponomaryovganso: and fix of driver interface does not require update of API12:13
gansovponomaryov: if we are going to have different names, then no12:13
gansovponomaryov: but I assume you also disagree with the API name12:13
vponomaryovganso: main concern you already saw - one more driver method is required12:14
gansovponomaryov: if it is confusing for a developer, it is most likely confusing to a user too12:14
gansovponomaryov: driver interfaces are reflecting API12:14
gansovponomaryov: reflecting exactly the way the API is12:14
vponomaryovganso: we have driver interfaces that are not tied to API at all12:15
gansovponomaryov: yes we do, my main concern is getting the name right12:15
vponomaryovganso: you started from "implement it separately"12:16
vponomaryovganso: not "lets name it finally"12:16
gansovponomaryov: are you suggesting merging the patches?12:16
vponomaryovOO Which patches?12:17
openstackgerritYingzhe Zeng proposed openstack/manila: Implement replication support in huawei driver  https://review.openstack.org/33158612:17
gansovponomaryov: https://review.openstack.org/#/c/328431/ and https://review.openstack.org/#/c/332267/12:17
vponomaryovganso: you got it from my mesages? ))12:18
vponomaryovs/mesages/messages/12:18
vponomaryovganso: I am saying that https://review.openstack.org/#/c/332267/ should be updated for having one more driver interface12:19
vponomaryovganso: for addressing concern raised in dummy driver commit12:19
vponomaryovthat implements share migration support12:19
gansovponomaryov: you are aware that once that dummy driver patch merges, I will have to update the interface for https://review.openstack.org/#/c/328431/ , right?12:20
gansovponomaryov: there are new parameters introduced, and others have been renamed12:20
vponomaryovganso: is it a problem?12:20
gansovponomaryov: it is not12:20
gansovponomaryov: I will include the dummy driver update in https://review.openstack.org/#/c/328431/12:21
vponomaryovthen how can I help you?12:21
gansovponomaryov: because it will make changes to code that existing driver will be using12:21
zhongjun_vponomaryov: I see. By the way, :D, Could you please review the snapshot instance python-manilaclient code https://review.openstack.org/#/c/304449/. The part of snapshot instance manila code has been merged, thanks.12:21
gansovponomaryov: you are suggesting a change that will change later again12:21
gansovponomaryov: I am suggesting changing only once, later12:22
vponomaryovganso: sooooo complicated12:22
gansovponomaryov: if dummy driver code is merged right now, I will update it within the later patch12:22
vponomaryovganso: it is not dummy driver problem12:22
jseilerganso: Before I get too deep, the driver I'm working on is for ocata (I don't want to take up too much of your time with newton deadlines looming)12:22
vponomaryovganso: it is interface problem12:23
vponomaryovganso: why are you going to change interface after it?12:23
jseilerganso: before I ran the api tests, I had deleted the default service-type, then created the service-type for my driver and named it default12:23
vponomaryovjseiler: don't be afraid, you already late for that party )12:23
vponomaryovservice type?12:23
jseilerganso: I had not noticed the default_share_type in manila.conf12:24
gansovponomaryov: current one we are discussing: https://review.openstack.org/#/c/332267/37/manila/share/driver.py12:24
gansovponomaryov: later change https://review.openstack.org/#/c/328431/24/manila/share/driver.py12:24
gansovponomaryov: I assumed you had taken a look at it12:25
jseilersorry type - as in type-create12:25
jseilersorry, still new to manila12:25
gansojseiler: humm so that approach did not solve your problem12:25
gansojseiler: as vponomaryov said, an existing bug causes scenario tests to depend on snapshot_support = True regardless of the defined share type or driver12:26
vponomaryovganso: your statement about change was looking like you are going to remove that additional driver interface12:26
gansovponomaryov: no, not remove, update12:26
jseilerganso: oh, sorry, missed that12:26
gansojseiler: np, still, I believed it was worth a shot, too bad it did not work12:26
jseilerganso: vponomaryov: That answers my question. I will not be able to run the scenario tests until I update my driver to support snapshots - right?12:27
vponomaryovganso: actually by default it creates share type without regards to that value12:27
gansojseiler: or bug is fixed12:27
vponomaryovganso: but if we set option "default_share_type_name" it will use user defined share type12:28
gansovponomaryov: oh so it can be worked around12:28
vponomaryovjseiler:  ^12:28
gansovponomaryov: cool, I wasn't aware of this option for tempest12:28
vponomaryovhttps://github.com/openstack/manila/blob/b06e111e/manila_tempest_tests/tests/scenario/test_share_basic_ops.py#L14412:28
vponomaryovyes, it can be worked around12:29
jseilerdefault_share_type_name - is that in manila.conf or tempest.conf ?12:30
gansojseiler: tempest_conf12:30
gansojseiler: but you are going to use the same value as you use for manila.conf12:30
*** adrianofr has joined #openstack-manila12:30
jseilerok12:30
gansojseiler: in your case, you must set it to 'default'12:30
gansojseiler: since you created your custom share type and renamed it to default12:31
vponomaryovganso: false12:31
gansovponomaryov: ?12:31
vponomaryovganso: scenario tests either create its own share type or you one you defined, it can be any you provide there12:31
vponomaryovs/you one you/one you/12:31
*** xyang1 has joined #openstack-manila12:31
vponomaryovganso: no relation to "default"12:32
*** gouthamr has joined #openstack-manila12:32
vponomaryovganso: I provided link to the logic - https://github.com/openstack/manila/blob/b06e111e/manila_tempest_tests/tests/scenario/test_share_basic_ops.py#L14412:32
gansovponomaryov: yes, I looked at it12:32
gansovponomaryov: the code for the config option will use one defined in tempest.conf12:33
gansovponomaryov: instead of creating one, if it is defined12:33
vponomaryovganso: it means your statement "in your case, you must set it to 'default'" is false12:33
gansovponomaryov: "default_share_type_name = default" in tempest.conf12:34
vponomaryovganso: it should be "... set it to one you defined in config"12:34
vponomaryovganso: because default in manila is different12:34
gansovponomaryov: yes, in his case, it is "default_share_type = default" in manila.conf as well, it is the one he wants to use, he changed it to have snapshot_support=False12:35
*** aovchinnikov has joined #openstack-manila12:42
vponomaryovzhongjun_: added comment12:42
zhongjun_vponomaryov: Thanks12:43
vponomaryovzhongjun_: + for such thing it is really better to add functional tests12:43
openstackgerritTiago Pasqualini da Silva proposed openstack/manila: Add Hitachi HSP driver  https://review.openstack.org/32913412:43
jseilerganso: vponomaryov: I set default_share_type_name in tempest.conf. That resolved the supports_snapshots issue. but now I'm getting a failure because it is trying to create a CIFS share.12:48
jseilerganso: vponomaryov: My driver is intially supporting only nfs.  that is configured in manila.conf. Is there another place I need to config nfs support only?12:48
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support  https://review.openstack.org/34998212:49
gansovponomaryov: fix ^12:50
jseilerganso: vponomaryov:  My driver reports storage_protocol: 'NFS'12:51
vponomaryovjseiler: https://github.com/openstack/manila/blob/master/manila_tempest_tests/config.py12:51
gansojseiler: have you set: 'capability_storage_protocol=NFS' ?12:52
vponomaryovjseiler: all available options are there12:52
vponomaryovjseiler: so, set "enable_protocols=nfs", "enable_ip_rules_for_protocols=nfs" and so on12:53
jseilerganso: Yes, I have capability_storage_protocol = NFS in tempest.conf12:53
gansojseiler: if that and vponomaryov's settings suggested don't fix your problem, then it is another bug12:54
*** tpsilva has joined #openstack-manila12:55
gouthamrmkoderer: ping12:57
*** liyifeng has quit IRC12:57
*** tpsilva has quit IRC12:58
*** tpsilva_ has joined #openstack-manila12:58
*** tpsilva_ is now known as tpsilva12:59
*** rraja has quit IRC12:59
*** mtanino has joined #openstack-manila13:02
mkoderergouthamr: hello sir13:03
gouthamrmkoderer: Hey Marc.. :) I have a quick question regarding https://review.openstack.org/#/c/34950613:03
mkoderergouthamr: yes ;)13:03
mkoderergouthamr: I am currently discussing it with out on-site netapp team13:04
gouthamrmkoderer: okay, so we were trying to allow configuring the MTU in the driver section of manila.conf;13:04
mkoderers/out/our/13:04
gouthamrmkoderer: nice13:04
gouthamrmkoderer: i see your change pulls the MTU value from neutron/nova-network instead; i think that's better since you'll avoid two different places to configure it..13:04
mkoderergouthamr: but the information comes from the neutron net, no?13:04
*** faiz89 has joined #openstack-manila13:05
gouthamrmkoderer: yeah.. so, my question was wrt to changes to MTU..13:05
gouthamrmkoderer: do you think admins can change the MTU value in the neutron config and expect changes to applied to existing VLAN resources?13:06
mkoderergouthamr: I don't think that neturon supports changing the MTU13:07
gouthamrmkoderer: http://docs.openstack.org/mitaka/networking-guide/adv-config-mtu.html13:07
gouthamrmkoderer: yep.. "For existing deployments, MTU values only apply to new network resources.";13:07
mkoderergouthamr: yep. So I think it ok to store the initial value13:09
mkoderergouthamr: we have issue with such things also with other neturon net information - like the gateway can't be updated too13:09
gouthamrmkoderer: so, in the cDOT driver, we create broadcast domains that span the neutron subnet..13:10
gansovponomaryov: is there an existing decorator function to use for that? I haven't found it and am about to create one13:11
*** mkoderer_cloud has joined #openstack-manila13:11
vponomaryovganso: sure13:12
gansovponomaryov: which is?13:12
*** rraja has joined #openstack-manila13:13
vponomaryovganso: i.e. https://github.com/openstack/manila/blob/49695bde/manila_tempest_tests/tests/api/test_share_networks_negative.py#L6113:13
vponomaryovganso: or "@testtools.skipUnless(..."13:14
gansovponomaryov: oh it is in testtools13:14
gansovponomaryov: thanks13:14
gouthamrmkoderer: so, think of this scenario: MTU is configured to 5000, a share network is created and manila creates a share server (NetApp vServer).. and then the admin changes the config value to 4000 and so, if a share server is created on the same subnet, and then the administrator changes the configuration13:16
*** dustins has joined #openstack-manila13:16
gouthamrmkoderer: this doesn't affect the existing subnet?13:17
openstackgerritAlexey Khodos proposed openstack/manila: Nexenta: adding share drivers for NexentaStor  https://review.openstack.org/30928613:17
mkoderergouthamr: so far I understand it in neutron there is no relation between mtu and subnet13:19
mkoderergouthamr: we are currently planning some more test in that area13:20
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support  https://review.openstack.org/34998213:20
mkoderergouthamr: I think we need to be sure how neutron handles changes of mtu's in general13:20
*** yangyapeng has quit IRC13:21
gouthamrmkoderer: yes.. i'll dig into their code/documentation.. I saw net_info['MTU'], and thought they're storing the info in the database per network13:21
*** akerr has joined #openstack-manila13:24
gouthamrmkoderer: thanks! we can discuss this more offline.13:25
*** yangyapeng has joined #openstack-manila13:25
*** akshai has joined #openstack-manila13:36
openstackgerritDustin Schoenbrun proposed openstack/manila: Check for usage of same Cephx ID as manila service  https://review.openstack.org/34971813:36
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui: Remove unit tests warnings  https://review.openstack.org/35001113:37
*** porrua has joined #openstack-manila13:38
*** vbellur has quit IRC13:38
*** mtanino has quit IRC13:41
*** merooney has joined #openstack-manila13:43
gansogouthamr: ping13:51
gouthamrganso: hey Rodrigo..13:51
gansogouthamr: hey Goutham13:51
*** shausy has quit IRC13:51
gansogouthamr: I saw your comment13:51
gansogouthamr: the option I used derives from the one you suggested13:51
*** rraja has quit IRC13:52
gouthamrganso: yep, but it's specifically used for the extra-spec..13:52
gouthamrganso: i can't see/don't know why we have two config opts.13:53
gansogouthamr: yes... I never guessed there was one specific option for extra-spec... since they are related13:53
gouthamrganso: ...sigh, but the test skips always use run_snapshot_tests..13:54
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix share migration test with snapshot support  https://review.openstack.org/34998213:54
*** JoseMello has joined #openstack-manila13:59
*** vbellur has joined #openstack-manila14:00
*** tovchinnikova has quit IRC14:01
*** bill_az has joined #openstack-manila14:02
*** aovchinnikov has quit IRC14:04
*** eharney_ has joined #openstack-manila14:15
openstackgerritzhongjun proposed openstack/python-manilaclient: Add snapshot instances admin APIs  https://review.openstack.org/30444914:21
*** timcl has quit IRC14:26
openstackgerritzhongjun proposed openstack/manila: Implement share backup  https://review.openstack.org/34398014:29
*** alkhodos has joined #openstack-manila14:30
*** rraja has joined #openstack-manila14:42
*** eharney_ is now known as eharney14:44
*** mtanino has joined #openstack-manila14:45
*** timcl has joined #openstack-manila14:49
*** cknight has joined #openstack-manila15:10
*** nkrinner is now known as nkrinner_afk15:17
*** mkoderer_cloud has quit IRC15:18
*** kaisers_ has joined #openstack-manila15:19
*** dustins has quit IRC15:23
*** faiz89 has quit IRC15:31
*** rraja has quit IRC15:39
*** dustins has joined #openstack-manila15:39
*** timcl has quit IRC15:40
*** cknight has quit IRC15:41
*** zhonghua-lee has quit IRC15:45
vponomaryovxyang1: ping15:51
xyang1vponomaryov: hi15:55
vponomaryovxyang1: Hello =)15:55
vponomaryovxyang1: wanted to ask you, have you seen answer in https://review.openstack.org/#/c/349575/2/manila/share/drivers/zfsonlinux/driver.py ?15:55
xyang1vponomaryov: looking15:56
vponomaryovxyang1: we just will not reach case of NameError, because we will fail eirlier if list is empty15:57
vponomaryovs/eirlier/earlier/15:58
xyang1vponomaryov: maybe, it just looks wierd using the variable defined in the loop only15:58
vponomaryovxyang1: why do you find it weird?15:58
xyang1vponomaryov: if you define it before entering the loop, that looks better15:59
vponomaryovxyang1: how?15:59
vponomaryovxyang1: it is one of python features15:59
vponomaryovxyang1: no need to define redundant object links16:00
xyang1vponomaryov: I think it's best to check if it is None before using it16:00
vponomaryovxyang1: snapshot_id just cannot be None16:01
vponomaryovxyang1: for snapshot_instance16:01
xyang1vponomaryov: not snapshot_id, I mean replica_snapshot16:01
vponomaryovxyang1: it cannot be None too ))16:02
vponomaryovxyang1: because we would fail in loop16:02
xyang1vponomaryov: I'd like others to take a look as well16:02
vponomaryovearlier16:02
vponomaryovxyang1: as you wish16:05
xyang1vponomaryov: removed -1.  let's see if others are ok with it16:05
*** faiz89 has joined #openstack-manila16:17
*** krotscheck is now known as krot_sickleave16:27
*** porrua has quit IRC16:27
vponomaryovganso: ping16:30
*** JoseMello has quit IRC16:30
*** rhagarty has joined #openstack-manila16:31
*** timcl has joined #openstack-manila16:40
gansovponomaryov: I gotta go now16:53
vponomaryovganso: :(16:53
bswartzvponomaryov: I just had a chat with ganso16:53
bswartzI think we will all be in agreement soon about the migration interfaces16:53
vponomaryovI had different question16:54
bswartzI'm going to write a ML post and put time on teh agenda for the thursday meeting16:54
gansovponomaryov: I may have time to answer while I am mobile16:54
bswartzoh sorry for taking ganso's time then  vponomaryov16:54
bswartz:-(16:54
vponomaryovganso: have you tested that https://review.openstack.org/#/c/332267/37/manila/share/access.py really fixes bug https://bugs.launchpad.net/manila/+bug/1566815 ?16:54
openstackLaunchpad bug 1566815 in Manila "share manager fails to remove access rules on replicated share" [High,In progress] - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010)16:54
vponomaryovganso: I suspect it does16:55
vponomaryovganso: and we should separate it too another commit16:55
vponomaryovganso: and get some statistics16:55
*** lpetrut has quit IRC16:55
vponomaryovganso: with just one change, lock should be on general "update" method16:56
vponomaryovganso: not private one that is just part of "update"16:56
*** chlong has quit IRC16:58
*** dsariel has quit IRC16:59
openstackgerritValeriy Ponomaryov proposed openstack/manila: [Tempest] Run tempest with the only plugin - manila's  https://review.openstack.org/33837117:03
*** porrua has joined #openstack-manila17:03
*** chlong has joined #openstack-manila17:12
openstackgerritValeriy Ponomaryov proposed openstack/manila: [debug] do not merge  https://review.openstack.org/35016817:16
*** dustins has quit IRC17:23
*** timcl has quit IRC17:25
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DEBUG] bug 1566815  https://review.openstack.org/35017417:28
openstackbug 1566815 in Manila "share manager fails to remove access rules on replicated share" [High,In progress] https://launchpad.net/bugs/1566815 - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010)17:28
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DEBUG2] bug 1566815  https://review.openstack.org/35017517:28
openstackgerritValeriy Ponomaryov proposed openstack/manila: [DEBUG3] bug 1566815  https://review.openstack.org/35017617:29
*** dustins has joined #openstack-manila17:33
*** jcsp has quit IRC17:42
*** gouthamr has quit IRC17:42
*** timcl has joined #openstack-manila17:43
*** lpetrut has joined #openstack-manila17:51
*** faiz89 has quit IRC18:00
*** faiz89 has joined #openstack-manila18:01
*** gouthamr has joined #openstack-manila18:02
openstackgerritTatiana Ovchinnikova proposed openstack/manila-ui: Fix unit tests  https://review.openstack.org/35021018:11
*** akerr is now known as akerr_away18:15
*** akerr_away has quit IRC18:15
*** akerr has joined #openstack-manila18:15
*** Suyi_ has joined #openstack-manila18:39
*** lpetrut has quit IRC18:41
*** abhi has joined #openstack-manila18:51
*** lpetrut has joined #openstack-manila19:03
*** kaisers_ has quit IRC19:07
*** timcl has quit IRC19:22
*** timcl has joined #openstack-manila19:24
*** alkhodos has quit IRC19:51
*** ganso has quit IRC19:51
*** porrua has quit IRC20:18
*** lpetrut has quit IRC20:21
*** akerr has quit IRC20:34
*** openstackgerrit_ has joined #openstack-manila20:35
*** openstackgerrit_ has quit IRC20:36
*** rhagarty has quit IRC20:38
*** kaisers_ has joined #openstack-manila20:56
*** timcl has quit IRC20:57
*** kaisers_ has quit IRC21:01
*** akshai has quit IRC21:02
*** akshai has joined #openstack-manila21:09
*** akshai has quit IRC21:10
*** vbellur has quit IRC21:11
*** vbellur has joined #openstack-manila21:44
*** porrua has joined #openstack-manila21:51
*** porrua_ has joined #openstack-manila21:54
*** porrua has quit IRC21:57
*** faiz89 has quit IRC22:02
*** alyson_ has quit IRC22:03
*** porrua_ has quit IRC22:04
*** vbellur has quit IRC22:04
*** dustins has quit IRC22:07
*** faiz89 has joined #openstack-manila22:14
*** lpetrut has joined #openstack-manila22:22
*** faiz89 has quit IRC22:25
*** eharney has quit IRC22:30
*** lpetrut has quit IRC22:31
*** kaisers_ has joined #openstack-manila22:45
*** akerr has joined #openstack-manila22:47
*** akerr_ has joined #openstack-manila22:48
*** kaisers_ has quit IRC22:50
*** david-lyle has quit IRC22:50
*** david-lyle has joined #openstack-manila22:51
*** akerr has quit IRC22:52
*** tpsilva has quit IRC22:58
*** merooney has quit IRC23:04
*** gouthamr has quit IRC23:09
*** xyang1 has quit IRC23:29
*** liyifeng has joined #openstack-manila23:34
*** bill_az has quit IRC23:44
openstackgerritMark Sturdevant proposed openstack/manila: HPE3PAR make share from snapshot writable  https://review.openstack.org/33792623:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!