| *** darrenc is now known as darrenc_afk | 00:26 | |
| *** darrenc_afk is now known as darrenc | 00:53 | |
| *** bswartz has joined #openstack-manila | 03:29 | |
| *** akshai_ has joined #openstack-manila | 04:03 | |
| *** akshai has quit IRC | 04:06 | |
| *** sgotliv has joined #openstack-manila | 04:11 | |
| *** sgotliv has quit IRC | 04:19 | |
| *** jasonsb has joined #openstack-manila | 04:36 | |
| *** akshai_ has quit IRC | 04:58 | |
| *** shausy has joined #openstack-manila | 05:06 | |
| *** jasonsb has quit IRC | 05:09 | |
| *** jasonsb has joined #openstack-manila | 05:13 | |
| *** jasonsb has quit IRC | 05:24 | |
| *** sgotliv has joined #openstack-manila | 05:25 | |
| *** jasonsb has joined #openstack-manila | 05:27 | |
| *** sgotliv has quit IRC | 05:31 | |
| *** sgotliv has joined #openstack-manila | 05:32 | |
| *** shausy has quit IRC | 05:37 | |
| *** shausy has joined #openstack-manila | 05:38 | |
| *** nkrinner has joined #openstack-manila | 05:55 | |
| *** lpetrut has joined #openstack-manila | 05:59 | |
| *** sgotliv has quit IRC | 06:39 | |
| *** lpetrut has quit IRC | 07:08 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance | 07:14 | |
| *** bswartz has quit IRC | 07:40 | |
| *** sgotliv has joined #openstack-manila | 08:03 | |
| *** lpetrut has joined #openstack-manila | 08:44 | |
| *** sgotliv_ has joined #openstack-manila | 09:40 | |
| *** sgotliv has quit IRC | 09:41 | |
| *** number80 has quit IRC | 09:44 | |
| *** ociuhandu has quit IRC | 09:59 | |
| *** jcsp has joined #openstack-manila | 10:31 | |
| *** rraja has joined #openstack-manila | 10:35 | |
| *** ociuhandu has joined #openstack-manila | 10:40 | |
| *** openstackgerrit has quit IRC | 10:48 | |
| *** openstackgerrit has joined #openstack-manila | 10:48 | |
| *** jcsp has quit IRC | 10:56 | |
| *** jcsp has joined #openstack-manila | 10:57 | |
| *** krotscheck_vaca is now known as krotscheck | 11:13 | |
| openstackgerrit | Merged openstack/manila: Fix force-delete on snapshot resource https://review.openstack.org/297205 | 11:21 |
|---|---|---|
| openstackgerrit | Tom Barron proposed openstack/manila: Remove ununsed logging import and LOG global https://review.openstack.org/301054 | 11:25 |
| *** gouthamr has joined #openstack-manila | 11:31 | |
| *** nidhimittalhada has joined #openstack-manila | 11:39 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add doc for Share Replication https://review.openstack.org/300018 | 11:42 |
| *** rraja has quit IRC | 11:51 | |
| *** marcusvrn_ has joined #openstack-manila | 11:56 | |
| *** mlima has joined #openstack-manila | 11:58 | |
| *** erlon has joined #openstack-manila | 12:13 | |
| *** eharney has quit IRC | 12:21 | |
| *** gouthamr has quit IRC | 12:31 | |
| *** nidhimittalhada has left #openstack-manila | 12:32 | |
| *** timcl has joined #openstack-manila | 12:39 | |
| *** bswartz has joined #openstack-manila | 12:40 | |
| *** xyang1 has joined #openstack-manila | 12:40 | |
| *** gouthamr has joined #openstack-manila | 12:44 | |
| *** mlima has quit IRC | 12:49 | |
| *** merooney has joined #openstack-manila | 13:10 | |
| *** lgreg has joined #openstack-manila | 13:13 | |
| *** akshai has joined #openstack-manila | 13:21 | |
| *** mtanino has joined #openstack-manila | 13:24 | |
| *** dalgaaf has joined #openstack-manila | 13:27 | |
| *** mlima has joined #openstack-manila | 13:29 | |
| *** esker has quit IRC | 13:30 | |
| *** Yogi1 has joined #openstack-manila | 13:35 | |
| openstackgerrit | Tom Barron proposed openstack/manila: Remove unused logging import and LOG global https://review.openstack.org/301054 | 13:36 |
| *** dencaval has quit IRC | 13:40 | |
| *** eharney has joined #openstack-manila | 13:48 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add release notes usage and documentation https://review.openstack.org/300656 | 13:54 |
| *** akerr has joined #openstack-manila | 13:54 | |
| *** shausy has quit IRC | 13:55 | |
| *** shausy has joined #openstack-manila | 13:55 | |
| *** eharney has quit IRC | 13:57 | |
| openstackgerrit | Goutham Pacha Ravi proposed openstack/manila: Add release notes usage and documentation https://review.openstack.org/300656 | 13:57 |
| *** eharney has joined #openstack-manila | 14:00 | |
| *** shausy has quit IRC | 14:03 | |
| *** a_ta has joined #openstack-manila | 14:04 | |
| *** shausy has joined #openstack-manila | 14:04 | |
| *** shausy has quit IRC | 14:09 | |
| *** shausy has joined #openstack-manila | 14:10 | |
| *** a_ta has quit IRC | 14:16 | |
| *** xyang1 has quit IRC | 14:17 | |
| *** xyang1_ has joined #openstack-manila | 14:17 | |
| *** a_ta has joined #openstack-manila | 14:18 | |
| *** esker has joined #openstack-manila | 14:22 | |
| *** esker has quit IRC | 14:23 | |
| *** esker has joined #openstack-manila | 14:24 | |
| *** jasonsb has quit IRC | 14:25 | |
| *** jasonsb has joined #openstack-manila | 14:26 | |
| *** shausy has quit IRC | 14:31 | |
| *** cknight has joined #openstack-manila | 14:34 | |
| *** nkrinner has quit IRC | 14:52 | |
| *** eharney has quit IRC | 14:56 | |
| *** mlima has quit IRC | 15:00 | |
| *** merooney has quit IRC | 15:01 | |
| *** merooney has joined #openstack-manila | 15:05 | |
| *** eharney has joined #openstack-manila | 15:12 | |
| *** mlima has joined #openstack-manila | 15:15 | |
| openstackgerrit | Tom Barron proposed openstack/manila: update dev env doc for Fedora releases https://review.openstack.org/300144 | 15:38 |
| *** david-lyle_ has quit IRC | 15:48 | |
| *** david-lyle has joined #openstack-manila | 15:48 | |
| ganso | vponomaryov: ping | 16:02 |
| vponomaryov | ganso: pong | 16:03 |
| ganso | vponomaryov: Hi Valeriy. Regarding your comment on https://review.openstack.org/#/c/300138 , are you suggesting removing the second part of the test? | 16:03 |
| vponomaryov | ganso: yes, it becomes redundant if you address previous comment | 16:05 |
| vponomaryov | ganso: also, not a point of test | 16:05 |
| ganso | vponomaryov: but then how will resource on backend be cleaned up? | 16:05 |
| vponomaryov | ganso: how it will be cleaned up if you use "addCleanup"? | 16:06 |
| ganso | vponomaryov: yes, DB entry will be removed, but resource in the backend will remain there | 16:06 |
| vponomaryov | ganso: in which case it will remain? | 16:07 |
| ganso | vponomaryov: in both cases, sucess and failure. Share needs to be properly managed to be removed | 16:07 |
| vponomaryov | ganso: addressing my comment tempest will try to delete shares, current code will do nothing. | 16:08 |
| vponomaryov | ganso: will not try to delete if test fails | 16:09 |
| vponomaryov | ganso: after share creation | 16:09 |
| vponomaryov | ganso: I mean "manage" | 16:09 |
| ganso | vponomaryov: setUp method unmanages the share. There is no more share to be deleted after test is finished, since the id is gone | 16:09 |
| vponomaryov | ganso: Rodrigo )) | 16:09 |
| vponomaryov | ganso: I don't know why "manage" features confuses so much | 16:10 |
| ganso | vponomaryov: o_O | 16:10 |
| vponomaryov | ganso: you fixed API, so you always create DB record with amnage API | 16:11 |
| vponomaryov | ganso: on line 176 you get it | 16:11 |
| vponomaryov | ganso: so, I wrote to call "addCleanup" func right after this 176 line | 16:12 |
| vponomaryov | ganso: to make it be deleted with any test result | 16:12 |
| vponomaryov | ganso: right now, your test will leave DB record undeleted if test fails | 16:12 |
| vponomaryov | ganso: if you want, I can make required change for you | 16:13 |
| ganso | vponomaryov: I agree, that is a flaw and needs to be corrected, I did no think of that before | 16:13 |
| vponomaryov | ganso: so, did I answer your question? | 16:14 |
| ganso | vponomaryov: but I do not understand why the last part needs to be removed | 16:14 |
| ganso | vponomaryov: no, my question was related to the last part | 16:14 |
| vponomaryov | ganso: why should it exist? | 16:14 |
| ganso | vponomaryov: if first manage call fails, which is expected | 16:14 |
| ganso | vponomaryov: because parameters are incorrect | 16:14 |
| ganso | vponomaryov: the way I see, adding just a cleanup will not remove resource from backend, because it was not properly managed | 16:15 |
| vponomaryov | ganso: DB RECORD | 16:15 |
| ganso | vponomaryov: yes, it will remove the db record | 16:15 |
| vponomaryov | ganso: for making cleanup be happy | 16:15 |
| ganso | vponomaryov: but both should be removed | 16:16 |
| vponomaryov | ganso: and your current approach will not do it | 16:16 |
| ganso | vponomaryov: no, it needs a fix just for when test fails (first manage succeeds) | 16:16 |
| ganso | vponomaryov: to clean both DB and resource | 16:17 |
| vponomaryov | ganso: and how it answers the question "why should it exist?"? | 16:19 |
| vponomaryov | ganso: what is the purpose of test? | 16:19 |
| vponomaryov | ganso: removal part is not part of purpose | 16:20 |
| vponomaryov | ganso: that is why it should be removed and "addCleanup" added above as mentioned | 16:20 |
| ganso | vponomaryov: there are 2 tests, you may disagree from the start that the 2 tests should not be combined in one | 16:21 |
| ganso | vponomaryov: let's say there is only one test | 16:21 |
| ganso | vponomaryov: which is negative, and should try to manage a share with improper parameters | 16:22 |
| ganso | vponomaryov: if this test succeeds, resource and DB should be cleaned up, that can be accomplished by managing the share again and deleting it | 16:22 |
| vponomaryov | ganso: split for two was incorrect too )) | 16:22 |
| vponomaryov | ganso: you still ignore answer for purpose question | 16:23 |
| vponomaryov | )) | 16:23 |
| vponomaryov | ganso: you combine these two tests - it is ok, because they should have never been splitted | 16:24 |
| ganso | vponomaryov: why do you say I ignore the answer for purpose question? I am confused | 16:25 |
| vponomaryov | ganso: I see ) | 16:25 |
| ganso | vponomaryov: I will submit a new patch fixing the case of test failing (first manage succeeding) | 16:26 |
| vponomaryov | ganso: from testing point of view, you test here "retry", not share deletion | 16:26 |
| ganso | vponomaryov: well, I can rename the test | 16:26 |
| vponomaryov | ganso: that is why "deletion" and, moreover, assertions, should be removed | 16:26 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix Share status when driver migrates https://review.openstack.org/299332 | 16:28 |
| *** sgotliv_ has quit IRC | 16:29 | |
| *** a_ta has quit IRC | 16:30 | |
| *** a_ta has joined #openstack-manila | 16:31 | |
| *** a_ta_ has joined #openstack-manila | 16:33 | |
| *** gouthamr has quit IRC | 16:33 | |
| *** a_ta has quit IRC | 16:35 | |
| *** esker has quit IRC | 16:39 | |
| openstackgerrit | Tom Barron proposed openstack/manila: Remove unused logging import and LOG global https://review.openstack.org/301054 | 16:40 |
| *** merooney has quit IRC | 16:42 | |
| *** merooney has joined #openstack-manila | 16:48 | |
| *** eharney has quit IRC | 16:49 | |
| mlima | hello guys, mitaka was affected by this change? https://review.openstack.org/#/c/290511/ | 16:52 |
| tbarron | mlima: that change is included in stable/mitaka branch if that is what you are asking. | 16:55 |
| *** eharney has joined #openstack-manila | 16:55 | |
| *** gouthamr has joined #openstack-manila | 17:00 | |
| mlima | tbarron, thanks for the answer | 17:03 |
| mlima | 17:03 | |
| *** jasonsb has quit IRC | 17:04 | |
| *** timcl has quit IRC | 17:29 | |
| *** lpetrut has quit IRC | 17:31 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila: Fix manage tempest test validation https://review.openstack.org/300138 | 17:34 |
| gouthamr | ganso: ping | 17:36 |
| ganso | gouthamr: pong | 17:36 |
| gouthamr | hey ganso! | 17:36 |
| gouthamr | ganso: maybe you're hitting this bug? https://bugs.launchpad.net/manila/+bug/1565903 | 17:36 |
| openstack | Launchpad bug 1565903 in Manila "retry for manage share fails with an API error " [Undecided,Confirmed] - Assigned to Yogesh (ykshirsa) | 17:36 |
| gouthamr | ganso: simple one-line fix :) | 17:37 |
| gouthamr | ganso: and then your test doesn't need the try.. excepts. | 17:37 |
| ganso | gouthamr: I did not hit it | 17:37 |
| ganso | gouthamr: let me understand the bug hold on a sec | 17:37 |
| gouthamr | ganso: ideally, your test can do this: 1) Manage with invalid share_type 2) check whether the share ends up with 'manage_error' 3) Don't reset state, just try manage again, with a valid share_type 4) Cleanup | 17:38 |
| ganso | gouthamr: wait, that implies going back to the code before this patch I just submitted... right | 17:39 |
| ganso | gouthamr: | 17:39 |
| ganso | gouthamr: ? | 17:39 |
| gouthamr | ganso: because of that bug though, the test will fail. You would need to copy.deepcopy() in https://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/api.py#L1112 | 17:39 |
| *** merooney has quit IRC | 17:39 | |
| gouthamr | ganso: yep.. | 17:40 |
| ganso | gouthamr: different things. The patch I just submitted was to address vponomaryov 's concerns about not cleaning up DB in case of test failing | 17:40 |
| ganso | gouthamr: then, it can be validated adjusting tempest test to do it. | 17:41 |
| gouthamr | ganso: i understand cleanups don't go through if tests fail.. but shouldn't that be handled by the cleanup layer? | 17:42 |
| gouthamr | ganso: seems wonky to have try excepts in the test.. | 17:42 |
| ganso | gouthamr: so, a cleanup like in line 113 is run only if test fails? | 17:44 |
| gouthamr | ganso: that does make some sense.. worth a try.. | 17:45 |
| *** a_ta_ has quit IRC | 17:46 | |
| gouthamr | ganso: but then you don't need to delete the share that was created in the DB, try manage again.. according to the API, that should work.. | 17:46 |
| gouthamr | ganso: (if the test does pass) | 17:46 |
| ganso | gouthamr: but if share_type is different, it should not consider as same share | 17:46 |
| *** a_ta has joined #openstack-manila | 17:46 | |
| gouthamr | ganso: you can change the share_type | 17:47 |
| gouthamr | ganso: since the export location and the host are the same, it should be considered as the same share? | 17:47 |
| gouthamr | ganso: i think ^ | 17:47 |
| ganso | gouthamr: according to line 501 in share/api.py, no | 17:47 |
| gouthamr | ganso: i mean, it is the same actual share :) | 17:47 |
| ganso | gouthamr: it is the actual | 17:47 |
| ganso | gouthamr: but in order to consider it a retry, thus triggering condition in like 536, it needs to be the same share type | 17:48 |
| ganso | gouthamr: I am confused as how that bug even exists | 17:48 |
| gouthamr | ganso: oh.. damn, thought you could retry with a different type | 17:48 |
| gouthamr | ganso: actually, i don't userstand manage retry | 17:48 |
| gouthamr | ganso: what was the whole point? :) | 17:48 |
| ganso | gouthamr: no idea o_O | 17:49 |
| gouthamr | ganso: :P | 17:49 |
| gouthamr | s/userstand/understand | 17:49 |
| *** timcl has joined #openstack-manila | 17:49 | |
| gouthamr | ganso: we don't allow "retry" on any other API.. it's kinda weird that we have it on manage | 17:49 |
| ganso | gouthamr: agreed | 17:50 |
| gouthamr | ganso: so, in your case, you could insert it into the cleanup method resources as soon as it is created.. so that it will be cleaned up even if tests fail.. | 17:50 |
| *** a_ta has quit IRC | 17:51 | |
| gouthamr | ganso: :P Yogi1 has the oneliner fix for the other bug in a related change | 17:51 |
| ganso | gouthamr: but I guess I should use the cleanup method resources approach only if test achieves the undesired effect (manage successfully instead of failing)... because I also need to clean the resource in the backend, not just the DB record, and to do so I need to manage properly | 17:53 |
| gouthamr | ganso: oh. yes, i understand that | 17:54 |
| gouthamr | ganso: because the 'host' is set | 17:54 |
| gouthamr | ganso: it always takes the call to the backend | 17:54 |
| ganso | gouthamr: it may not... scheduler may not allow | 17:55 |
| gouthamr | ganso: i meant the delete call | 17:55 |
| ganso | gouthamr: oh yes | 17:55 |
| gouthamr | ganso: or not.. delete works only for 'available', 'error' or 'inactive' | 17:56 |
| gouthamr | ganso: unless the operation is forced.. | 17:56 |
| * gouthamr wonders what sorta share will be in 'inactive' state | 17:58 | |
| ganso | gouthamr: a share that is being migrated | 17:58 |
| ganso | gouthamr: that's why I reset state... you cannot delete a manage_error share | 17:59 |
| gouthamr | ganso: ah.. makes sense.. | 18:01 |
| gouthamr | ganso: or you can use 'force_delete' | 18:01 |
| gouthamr | :) | 18:01 |
| ganso | gouthamr: I'd rather not use force_delete instead of reset_state =) | 18:02 |
| gouthamr | ganso: haha.. yeah.. lemme think and give you review feedback if some better idea strikes. | 18:03 |
| ganso | gouthamr: do you have a link for Yogesh's fix? | 18:06 |
| gouthamr | ganso: code's still internal.. im hoping he'll have it up today. | 18:07 |
| *** number80 has joined #openstack-manila | 18:17 | |
| *** a_ta has joined #openstack-manila | 18:30 | |
| *** sgotliv_ has joined #openstack-manila | 18:40 | |
| *** timcl has quit IRC | 18:46 | |
| *** gouthamr has quit IRC | 18:48 | |
| *** timcl has joined #openstack-manila | 18:50 | |
| *** gouthamr has joined #openstack-manila | 18:52 | |
| *** Yogi1 has quit IRC | 18:54 | |
| *** ociuhandu has quit IRC | 19:17 | |
| *** mlima_ has joined #openstack-manila | 19:19 | |
| *** mlima has quit IRC | 19:23 | |
| *** mlima_ has quit IRC | 20:17 | |
| *** akerr has quit IRC | 20:21 | |
| openstackgerrit | Merged openstack/manila: Use install_package when preparing LVM driver installation https://review.openstack.org/299322 | 20:21 |
| *** akshai has quit IRC | 20:25 | |
| *** timcl has quit IRC | 20:26 | |
| *** cknight has quit IRC | 20:47 | |
| *** akshai has joined #openstack-manila | 20:58 | |
| *** lpetrut has joined #openstack-manila | 21:03 | |
| *** ociuhandu has joined #openstack-manila | 21:06 | |
| *** sgotliv_ has quit IRC | 21:53 | |
| *** david-lyle_ has joined #openstack-manila | 22:02 | |
| *** david-lyle has quit IRC | 22:03 | |
| *** david-lyle_ is now known as david-lyle | 22:03 | |
| *** a_ta has quit IRC | 22:05 | |
| *** a_ta has joined #openstack-manila | 22:06 | |
| *** xyang1_ has quit IRC | 22:07 | |
| *** a_ta has quit IRC | 22:10 | |
| *** eharney has quit IRC | 22:10 | |
| *** lpetrut has quit IRC | 22:17 | |
| *** tpsilva has quit IRC | 22:27 | |
| *** ganso has quit IRC | 22:40 | |
| *** rebase has joined #openstack-manila | 22:44 | |
| *** david-lyle has quit IRC | 22:44 | |
| *** david-lyle has joined #openstack-manila | 22:47 | |
| *** gouthamr has quit IRC | 23:09 | |
| *** divab has joined #openstack-manila | 23:10 | |
| *** akshai has quit IRC | 23:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/manila: Updated from global requirements https://review.openstack.org/300767 | 23:17 |
| *** chlong has joined #openstack-manila | 23:18 | |
| *** rebase_ has joined #openstack-manila | 23:25 | |
| *** rebase has quit IRC | 23:27 | |
| *** rebase_ has quit IRC | 23:29 | |
| *** dalgaaf has quit IRC | 23:38 | |
| *** akshai has joined #openstack-manila | 23:52 | |
| *** akshai_ has joined #openstack-manila | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!