Tuesday, 2015-12-29

*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-manila00:02
*** jwang_ has joined #openstack-manila00:14
*** jwang has quit IRC00:17
*** zhongjun2 has quit IRC00:24
*** zhongjun has joined #openstack-manila00:26
*** gnarld_ is now known as nug00:27
*** nug is now known as Guest5674900:28
*** david-lyle has quit IRC00:40
*** haomaiwa_ has joined #openstack-manila01:03
*** haomaiwang has quit IRC01:03
*** darkwsh has quit IRC01:20
*** haomaiwa_ has quit IRC01:26
*** jasonsb has quit IRC01:29
*** david-lyle has joined #openstack-manila01:49
*** xxxxxx has joined #openstack-manila01:54
*** xxxxxx has quit IRC01:54
*** xxxxxx has joined #openstack-manila01:56
*** haomaiwang has joined #openstack-manila02:16
*** houming has joined #openstack-manila02:33
openstackgerritHou Ming Wang proposed openstack/manila: Trivial: Remove unused logging import  https://review.openstack.org/26153802:45
*** esker has joined #openstack-manila02:56
*** david-lyle has quit IRC02:57
*** haomaiwang has quit IRC03:01
*** haomaiwa_ has joined #openstack-manila03:01
*** esker has quit IRC03:02
openstackgerritxing-yang proposed openstack/manila: Manage and unmanage snapshot  https://review.openstack.org/24954203:06
openstackgerritxing-yang proposed openstack/manila: Tempest tests for Manage and unmanage snapshot  https://review.openstack.org/26211403:06
*** jasonsb has joined #openstack-manila03:25
*** david-lyle has joined #openstack-manila03:26
*** david-lyle has quit IRC03:52
*** haomaiwa_ has quit IRC04:01
*** haomaiwang has joined #openstack-manila04:01
*** esker has joined #openstack-manila05:00
*** haomaiwang has quit IRC05:01
*** 21WAAM5NW has joined #openstack-manila05:01
*** esker has quit IRC05:05
*** xxxxxx has quit IRC05:09
*** david-lyle has joined #openstack-manila05:27
*** sgotliv has joined #openstack-manila05:40
*** xxxxxx has joined #openstack-manila05:47
*** david-lyle has quit IRC05:58
*** 21WAAM5NW has quit IRC06:01
*** haomaiwa_ has joined #openstack-manila06:01
*** jasonsb has quit IRC06:18
*** jasonsb has joined #openstack-manila06:19
*** david-lyle has joined #openstack-manila06:29
*** haomaiwa_ has quit IRC07:01
*** haomaiwang has joined #openstack-manila07:01
*** esker has joined #openstack-manila07:03
*** esker has quit IRC07:08
*** lpetrut has joined #openstack-manila07:23
openstackgerritliucheng proposed openstack/manila: Huawei: Add manage share with share type in Huawei driver  https://review.openstack.org/25099507:58
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-manila08:01
*** lpetrut has quit IRC08:25
*** xxxxxx has quit IRC08:43
*** xxxxxx has joined #openstack-manila08:47
*** xxxxxx has quit IRC08:47
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-manila09:01
*** esker has joined #openstack-manila09:06
*** esker has quit IRC09:11
*** haomaiwang has quit IRC10:01
*** haomaiwa_ has joined #openstack-manila10:04
*** esker has joined #openstack-manila10:07
*** lpetrut has joined #openstack-manila10:10
*** esker has quit IRC10:12
gansovponomaryov: ping10:24
vponomaryovganso:  pong10:25
gansovponomaryov: Hello! I've been reading your patches regarding export location metadata and admin export location. I'm having a hard time understanding how your implementation of admin export location works in generic driver10:26
gansovponomaryov: unless the implementation is still incomplete10:26
vponomaryovganso: return list of export locations with any amount of them with key "is_admin"only" set to boolean10:27
vponomaryov ganso: generic, foo, bar driver, no diff10:28
gansovponomaryov: I don't see the driver.py base class being changed, is there no need to?10:32
vponomaryovganso: why driver.py should be changed?10:34
vponomaryovganso: share manager handles responses from share driver10:35
vponomaryovganso: you just change response10:35
vponomaryovganso: now share manager and DB api understand two approaches - old and new10:35
vponomaryovganso: so, admin export location mechanism is done10:38
gansovponomaryov: I see, I was expecting db.export_location_metadata_update to be called, but it isn't being called in code10:39
vponomaryovganso: and generic driver here has an example of using new approach here - https://review.openstack.org/#/c/251930/40/manila/share/drivers/generic.py , but it does not really create second export location10:39
vponomaryovganso: what do you mean not called?10:40
gansovponomaryov: in manager, to update metadata, but it is called only within DB class10:40
vponomaryovganso: driver returns data to manager and manager does all required stuff10:40
gansovponomaryov: I understand now, the only interaction point is when driver returns the export location when creating share / ensuring share10:42
gansovponomaryov: then manager takes care of all the rest10:43
vponomaryovganso: manage, and others10:43
vponomaryovganso: you can use this DB APi in any place of share manager10:43
vponomaryovganso: driver is not allowed to call DB10:43
gansovponomaryov: but for generic driver, it is not really allocating any IP from admin network right? (as far from what I see in the code, just an example), so for migration, it will not have any real reachable IP to mount10:44
vponomaryovganso: existing commits - implementation of mechanism10:45
vponomaryovganso: tha tis not used10:45
vponomaryovganso: implementation in drivers - completely separate thing10:46
vponomaryovganso: "example" shows that mechanism works10:46
vponomaryovganso: mechanism does not care where did you get info that is provided as export location10:47
gansovponomaryov: I see, so still all DHSS drivers need to implement something to support this feature, it is not something that can be done only in Manila core code.10:47
vponomaryovganso: in case of Generic driver it could be some additional option with admin net and its usage10:48
gansovponomaryov:  I see that the export location metadata patch still has missing the part where it can print the additional metadata10:48
vponomaryovganso: if is finished10:48
vponomaryovganso: nothing is missed10:48
vponomaryovs/if/it/10:48
vponomaryovganso: read commit description10:48
gansovponomaryov: https://review.openstack.org/#/c/251930/40/manila/api/views/export_locations.py10:49
vponomaryovganso: there is no metadata to view10:49
gansovponomaryov: shouldn't it loop through the metadata and print them?10:49
vponomaryovganso: no10:49
gansovponomaryov: but if there was, would it work?10:49
vponomaryovganso: design assumes that we, as community, make agreement on metadata and only then define keys that will be shown explicitely10:50
vponomaryovspecific metadata10:50
vponomaryovganso: not all, not any10:50
gansovponomaryov: oh, so only common metadata, not scoped ones10:51
gansovponomaryov: ok so it is complete :)10:51
vponomaryovganso: yes10:51
vponomaryovmechanism is completed10:51
gansovponomaryov: I will finish reviewing the unit tests now, thanks for clearing it up :)10:52
vponomaryovnp10:52
*** haomaiwa_ has quit IRC11:01
*** haomaiwa_ has joined #openstack-manila11:01
*** ociuhandu has quit IRC11:03
*** ociuhandu has joined #openstack-manila11:29
gansovponomaryov: btw, is gerrit failing a lot to load pages for you?11:29
*** haomaiwa_ has quit IRC12:01
*** haomaiwa_ has joined #openstack-manila12:01
*** lpetrut has quit IRC12:03
*** lpetrut has joined #openstack-manila12:04
*** david-lyle has quit IRC12:06
*** esker has joined #openstack-manila12:10
*** esker has quit IRC12:15
openstackgerrithuyang proposed openstack/manila: Huawei: Add share server support  https://review.openstack.org/25971912:35
mkodererganso: gerrit is failing a lot for all of us.. see #openstack-infra ;)12:36
gansomkoderer: Thanks Marc! :)12:41
*** haomaiwa_ has quit IRC13:01
*** houming has quit IRC13:01
*** haomaiwang has joined #openstack-manila13:01
*** haomaiwang has quit IRC13:04
*** david-lyle has joined #openstack-manila13:09
*** esker has joined #openstack-manila13:11
*** esker has quit IRC13:17
*** kambiz has quit IRC13:37
*** porrua has joined #openstack-manila13:43
*** haomaiwang has joined #openstack-manila13:43
*** erlon has joined #openstack-manila13:57
*** haomaiwang has quit IRC14:01
*** kambiz has joined #openstack-manila14:01
*** haomaiwang has joined #openstack-manila14:01
*** porrua has quit IRC14:27
*** kambiz has quit IRC14:50
*** kambiz has joined #openstack-manila14:52
*** haomaiwang has quit IRC15:01
*** 7JTABFCS0 has joined #openstack-manila15:01
*** ociuhandu has quit IRC15:20
*** 7JTABFCS0 has quit IRC16:01
*** 17WABFTAV has joined #openstack-manila16:01
*** kambiz has quit IRC16:13
*** kambiz has joined #openstack-manila16:15
*** lpetrut has quit IRC16:15
*** david-lyle has quit IRC16:21
*** kambiz has quit IRC16:38
*** kambiz has joined #openstack-manila16:41
*** david-lyle has joined #openstack-manila16:42
*** david-lyle has quit IRC16:48
*** david-lyle has joined #openstack-manila16:58
*** david-lyle has quit IRC16:59
*** esker has joined #openstack-manila17:00
*** 17WABFTAV has quit IRC17:01
*** haomaiwang has joined #openstack-manila17:01
*** dustins has quit IRC17:06
*** esker has quit IRC17:09
*** haomaiwang has quit IRC18:01
*** 14WAAJEAT has joined #openstack-manila18:01
*** david-lyle has joined #openstack-manila18:14
*** david-lyle has quit IRC18:24
*** vbellur has joined #openstack-manila18:31
*** ociuhandu has joined #openstack-manila18:44
*** 14WAAJEAT has quit IRC19:01
*** haomaiwang has joined #openstack-manila19:01
*** david-lyle has joined #openstack-manila19:28
*** david-lyle has quit IRC19:33
*** david-lyle has joined #openstack-manila19:33
*** david-lyle has quit IRC19:42
*** david-lyle has joined #openstack-manila19:43
*** haomaiwang has quit IRC20:01
*** 17WABFU7I has joined #openstack-manila20:01
openstackgerritxing-yang proposed openstack/manila: Tempest tests for Manage and unmanage snapshot  https://review.openstack.org/26211420:03
*** david-lyle has quit IRC20:10
*** ganso has quit IRC20:39
*** david-lyle has joined #openstack-manila20:43
*** esker has joined #openstack-manila21:00
*** 17WABFU7I has quit IRC21:01
*** 6A4ABG0AL has joined #openstack-manila21:01
*** ociuhandu has quit IRC21:01
*** ociuhandu has joined #openstack-manila21:03
*** erlon has quit IRC21:16
*** openstackgerrit has quit IRC21:17
*** openstackgerrit has joined #openstack-manila21:18
*** jasonsb has quit IRC21:20
*** esker has quit IRC21:32
*** 6A4ABG0AL has quit IRC22:01
*** haomaiwa_ has joined #openstack-manila22:01
openstackgerritMerged openstack/manila: Fix wrong flake8 exception and pep8 violations  https://review.openstack.org/26133522:12
*** david-lyle has quit IRC22:28
*** david-lyle has joined #openstack-manila22:36
*** david-lyle has quit IRC22:50
*** haomaiwa_ has quit IRC23:01
*** haomaiwang has joined #openstack-manila23:01
*** marcusvrn_ has quit IRC23:07
*** sgotliv has quit IRC23:42
*** david-lyle has joined #openstack-manila23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!