Friday, 2015-09-18

*** Zhongjun has joined #openstack-manila00:03
*** jasonsb has quit IRC00:08
*** jasonsb has joined #openstack-manila00:08
*** mtanino has quit IRC00:22
*** david-lyle has quit IRC00:40
*** david-lyle has joined #openstack-manila00:44
bswartzmarkstur you around?00:52
bswartzany cores here?01:03
bswartztoabctl u_glide1 markstur xyang vponomaryov01:03
*** gouthamr has joined #openstack-manila01:08
*** jasonsb has quit IRC01:13
*** gouthamr has quit IRC01:39
*** gouthamr has joined #openstack-manila01:50
*** haomaiwang has joined #openstack-manila01:56
*** haomaiwang has quit IRC02:01
*** haomaiwa_ has joined #openstack-manila02:05
*** haomaiwa_ has quit IRC02:05
*** haomaiwa_ has joined #openstack-manila02:06
*** Zhongjun has quit IRC02:07
openstackgerritBen Swartzlander proposed openstack/python-manilaclient: Dummy change (DO NOT MERGE)  https://review.openstack.org/22496202:11
*** baojg has joined #openstack-manila02:17
*** baojg has quit IRC02:20
*** baojg has joined #openstack-manila02:22
*** jasonsb has joined #openstack-manila02:25
*** esker has joined #openstack-manila02:44
*** markstur_ has joined #openstack-manila02:51
*** gouthamr has quit IRC02:57
*** haomaiwa_ has quit IRC03:01
*** haomaiwang has joined #openstack-manila03:01
openstackgerritzhongjun proposed openstack/manila: Add Huawei driver details  https://review.openstack.org/22497303:05
*** zhongjun22 has quit IRC03:09
*** wilson-1 has quit IRC03:09
*** wilson has joined #openstack-manila03:10
*** zhongjun has joined #openstack-manila03:10
*** wilson is now known as Guest2042103:11
*** DericHorn-HP has joined #openstack-manila03:12
*** vbellur has joined #openstack-manila03:19
*** esker has quit IRC03:19
*** EinstCrazy has joined #openstack-manila03:29
*** bill_az has quit IRC03:34
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-manila04:01
*** nidhimittalhada has joined #openstack-manila04:17
*** nidhimittalhada has quit IRC04:32
*** vbellur has quit IRC04:49
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-manila05:01
*** lpetrut has joined #openstack-manila05:23
*** openstackgerrit has quit IRC05:31
*** openstackgerrit has joined #openstack-manila05:31
*** shausy has joined #openstack-manila05:32
bswartzu_glide1 vponomaryov: manilaclient gate is broken https://review.openstack.org/#/c/224962/05:34
*** DericHorn-HP has quit IRC05:37
*** vbellur has joined #openstack-manila05:46
*** vbellur has quit IRC05:53
*** rraja has joined #openstack-manila05:58
*** lpetrut has quit IRC05:58
*** deepakcs has joined #openstack-manila05:59
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-manila06:01
*** markstur_ has quit IRC06:05
*** nkrinner_afk is now known as nkrinner06:05
*** baojg has quit IRC06:12
*** baojg has joined #openstack-manila06:19
*** DericHorn-HP has joined #openstack-manila06:28
*** vbellur has joined #openstack-manila06:29
*** DericHorn-HP has quit IRC06:31
*** baojg has quit IRC06:33
*** DericHorn-HP has joined #openstack-manila06:36
*** ktolstoy has joined #openstack-manila06:37
*** baojg has joined #openstack-manila06:39
*** DericHorn-HP has quit IRC06:48
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-manila07:01
*** DericHorn-HP has joined #openstack-manila07:09
*** vbellur has quit IRC07:09
*** shausy has quit IRC07:11
*** DericHorn-HP has quit IRC07:19
*** esker has joined #openstack-manila07:27
*** esker has quit IRC07:28
*** esker has joined #openstack-manila07:28
*** EinstCrazy has quit IRC07:33
*** vbellur has joined #openstack-manila07:41
*** ktolstoy has joined #openstack-manila07:56
*** resker has joined #openstack-manila07:57
*** esker has quit IRC08:00
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-manila08:01
*** baojg has quit IRC08:01
*** dsariel_ has joined #openstack-manila08:03
*** baojg has joined #openstack-manila08:08
*** baojg has quit IRC08:17
*** baojg has joined #openstack-manila08:18
*** dsariel_ has quit IRC08:28
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Use v2 API of Manila  https://review.openstack.org/22483608:30
*** vbellur has quit IRC08:33
*** lpetrut has joined #openstack-manila08:41
openstackgerritRamana Raja proposed openstack/manila: glusterfs_native: Add Manila host CN configurable.  https://review.openstack.org/22484608:43
*** chlong has quit IRC08:47
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-manila09:01
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506709:03
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506709:04
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506709:04
openstackgerritzhongjun proposed openstack/manila: Add Huawei driver details in doc  https://review.openstack.org/22497309:27
*** ktolstoy has quit IRC09:44
*** julia_ has joined #openstack-manila09:53
*** csaba has quit IRC09:58
*** haomaiwang has quit IRC10:01
*** haomaiwang has joined #openstack-manila10:01
*** ktolstoy has joined #openstack-manila10:05
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506710:06
*** csaba has joined #openstack-manila10:07
*** sslypushenko has quit IRC10:22
*** baojg has quit IRC10:45
*** baojg has joined #openstack-manila10:46
*** baojg has quit IRC10:50
*** ganso has joined #openstack-manila10:51
*** ktolstoy has quit IRC10:52
*** ktolstoy has joined #openstack-manila10:53
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-manila11:01
*** julia_ has quit IRC11:01
*** ktolstoy has quit IRC11:06
*** ktolstoy has joined #openstack-manila11:07
openstackgerritRamana Raja proposed openstack/manila: glusterfs_native: Hardwire Manila Host CN pattern  https://review.openstack.org/22484611:09
*** ktolstoy has quit IRC11:09
*** ktolstoy has joined #openstack-manila11:11
*** rraja has quit IRC11:13
gansovponomaryov: ping11:14
*** ktolstoy has quit IRC11:14
bswartzvponomaryov: what can we do to unblock the manilaclient gate and get a release made?11:15
*** ktolstoy has joined #openstack-manila11:15
*** ktolstoy has quit IRC11:22
*** ktolstoy has joined #openstack-manila11:29
vponomaryovbswartz: https://review.openstack.org/#/c/225067/11:29
vponomaryovbswartz: this is temporary workaround11:30
vponomaryovbswartz: just need to update11:30
vponomaryovbswartz: fixed two of three tests11:30
*** ktolstoy has quit IRC11:30
vponomaryovbswartz: also see manilaclient bug that is a MUST to be fixed before release - https://bugs.launchpad.net/python-manilaclient/+bug/149721511:30
openstackLaunchpad bug 1497215 in python-manilaclient "share created with CG can not be deleted" [Critical,In progress] - Assigned to Valeriy Ponomaryov (vponomaryov)11:30
vponomaryovbswartz: already working on it11:31
vponomaryovbswartz: and will upload it soon11:31
*** ktolstoy has joined #openstack-manila11:32
*** ccesario has quit IRC11:32
*** sgotliv has quit IRC11:32
*** lpetrut has quit IRC11:35
*** cbrown2_ocf has joined #openstack-manila11:37
cbrown2_ocfHi, just noticed the commit removing GPFS - is this removing the driver completely or just from CI testing?11:38
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Fix shares CLI for using CGs  https://review.openstack.org/22511411:41
vponomaryovcbrown2_ocf: completely. It can be reverted back if third-party CI is up for it11:42
*** bill_az has joined #openstack-manila11:43
*** alyson_ has joined #openstack-manila11:43
cbrown2_ocfSo to be clear, Manila no longer supports GPFS from this point?11:43
*** cbrown2_ocf has quit IRC11:45
*** cbrown2_ocf has joined #openstack-manila11:46
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Fix shares CLI for using CGs  https://review.openstack.org/22511411:46
vponomaryovcbrown2_ocf: yes11:47
vponomaryovcbrown2_ocf: Kilo version - does support, but not Liberty11:47
vponomaryovcbrown2_ocf: you still can use it with Kilo11:48
cbrown2_ocfvponomaryov, ok, thanks11:48
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Fix shares CLI for using CGs  https://review.openstack.org/22511411:50
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506711:55
*** deepakcs has quit IRC11:57
*** ktolstoy has quit IRC11:59
*** ktolstoy has joined #openstack-manila12:00
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-manila12:01
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix HDS HNAS Create from snapshot ignoring Size  https://review.openstack.org/22511612:03
openstackgerritCsaba Henk proposed openstack/manila: glusterfs: fix gluster-nfs export for volume mapped layout  https://review.openstack.org/22511712:04
*** ktolstoy has quit IRC12:04
gansovponomaryov, bswartz: hello. could you please tag ^ ? Another bug, another fix submitted12:05
vponomaryovganso: done12:06
*** chlong has joined #openstack-manila12:06
*** ktolstoy has joined #openstack-manila12:06
*** chlong has quit IRC12:07
openstackgerritCsaba Henk proposed openstack/manila: glusterfs*: amend export location  https://review.openstack.org/22488512:07
gansovponomaryov: thanks12:07
*** chlong has joined #openstack-manila12:07
bswartzcsaba: is https://review.openstack.org/225117 and https://bugs.launchpad.net/manila/+bug/1495910 the other bugfix you mentioned yesterday afternoon?12:08
openstackLaunchpad bug 1495910 in Manila "glusterFS_NFS_driver: unable to NFS mount manila share with directory mapped layout" [Undecided,In progress] - Assigned to Csaba Henk (chenk)12:08
*** dzamboni has joined #openstack-manila12:08
*** cbrown2_ocf has quit IRC12:08
*** ktolstoy has quit IRC12:08
vponomaryovbswartz: I expect https://review.openstack.org/#/c/225067/ to pass and fix manilaclient gates12:09
bswartzvponomaryov: thanks12:09
vponomaryovbswartz: then combined fix for two bugs related to CGs - https://review.openstack.org/#/c/225114/12:09
bswartzokay12:09
bswartzthen cfouts' change is not needed anymore?12:10
vponomaryovbswartz: yes12:10
csababswartz: yes.. and also told you of yet another one -- that one we reconsidered, as not critical, so we don't insist on that; however, another minor-but-critical bug was discovered today morming for which I'm sending a fix soon12:10
bswartzwhy not rebase 225114 on top of 225067?12:10
*** ktolstoy has joined #openstack-manila12:10
bswartzcsaba: I'm confused -- how many bugs total need targetting?12:11
bswartz1 more bug or 2 more bugs?12:11
vponomaryovbswartz: ok, will rebase12:11
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Fix shares CLI for using CGs  https://review.openstack.org/22511412:11
vponomaryovbswartz: done, now we can just wait for CI12:12
bswartzyes12:12
csababswartz: alltogether 2, the one for which I just sent a fix, https://bugs.launchpad.net/manila/+bug/1495910, and a fresh one, https://bugs.launchpad.net/manila/+bug/149721212:13
openstackLaunchpad bug 1495910 in Manila "glusterFS_NFS_driver: unable to NFS mount manila share with directory mapped layout" [Undecided,In progress] - Assigned to Csaba Henk (chenk)12:13
openstackLaunchpad bug 1497212 in Manila "GlusterfsShareDriver: m-shr continuously crashes upon setting up ganesha with volume based layout" [Undecided,New]12:13
bswartzI can ninja merge those but let's try to get some other reviewers on both of them12:13
bswartzcsaba: I'd rather not target it until there is a fix in gerrit12:13
bswartzjust ping me again when the fix actually goes up12:13
bswartzdid rraja respond to my -1?12:14
bswartzoh I see he did12:14
openstackgerritAlyson proposed openstack/manila: Add Hitachi HNAS driver documentation  https://review.openstack.org/22473212:15
csababswartz: that's my plan... and I'll rebase https://review.openstack.org/225117 atop of https://review.openstack.org/224885 to proactively manage their conflict12:15
bswartzcsaba: you might want to wait on the rebase until you get +2 on the 22488512:19
bswartzyou'll just waste time if we -1 or -2 for some reason12:19
*** haomaiwang has quit IRC12:19
bswartzI have to drive into office but I'll start reviewing all the open patches when I get in12:19
csababswartz: I'll leave early this afternoon and will be away from keyboard for the weekend12:19
bswartzso hopefully you'll have my review in less than an hour12:19
csabaif there is an intent to merge these patches but you can't because of the confict...12:20
csabais it OK if I get back to resole the conflict on Monday?12:20
bswartzwe'll merge them as long as they don't look like stealth features and don't have any problems12:20
bswartzcsaba: how long until you have to leave for the weekend?12:21
bswartzis there someone you can hand the patches off to in case they need another revision?12:21
*** ktolstoy has quit IRC12:21
bswartzcsaba: Monday might be okay if it's really early12:22
bswartzMonday is our target day for RC112:22
csababswartz: OK but maybe it's better if I rebase for our QE as well so that the two patches can be tested together... do you *mind* if I rebase now?12:23
bswartzno it's okay12:23
*** xyang1 has joined #openstack-manila12:23
bswartzit just creates more work if the earlier change needs another patchset12:23
bswartzI'll tell you what12:24
bswartzI will review it right now before I drive to the office12:24
csababswartz: thanks!12:24
*** ktolstoy has joined #openstack-manila12:24
bswartzokay csaba it looks fine12:30
* bswartz goes to drive into office12:30
*** bswartz has quit IRC12:30
csababswartz: thx!12:30
*** eharney has joined #openstack-manila12:31
openstackgerritAlyson proposed openstack/manila: Fix HDS HNAS manage incorrect share size  https://review.openstack.org/22483012:32
*** vbellur has joined #openstack-manila12:39
*** ktolstoy has quit IRC12:40
*** ktolstoy has joined #openstack-manila12:41
*** bswartz has joined #openstack-manila12:54
bswartzokay I'm back12:54
bswartzany cores who can review https://review.openstack.org/#/c/225114/ ?12:56
*** gouthamr has joined #openstack-manila12:56
*** cbrown2_ocf has joined #openstack-manila12:57
*** ktolstoy has quit IRC13:01
openstackgerritJulia Varlamova proposed openstack/python-manilaclient: Change Manilaclient to use --os-region-name param  https://review.openstack.org/22513313:02
*** ktolstoy has joined #openstack-manila13:03
*** ktolstoy has quit IRC13:05
*** ktolstoy has joined #openstack-manila13:06
bswartzjvalamova isn't in IRC?13:08
*** cknight has joined #openstack-manila13:08
vponomaryovbswartz: ask me13:12
bswartzvponomaryov: why is patch from jvalamova maked workflow -1?13:13
vponomaryovbswartz: no unit tests13:13
*** haomaiwang has joined #openstack-manila13:13
bswartzok13:14
*** nkrinner is now known as nkrinner_afk13:14
*** jvarlamova has joined #openstack-manila13:14
*** haomaiwang has quit IRC13:15
*** dustins has joined #openstack-manila13:16
*** haomaiwang has joined #openstack-manila13:16
openstackgerritJulia Varlamova proposed openstack/python-manilaclient: Change Manilaclient to use --os-region-name param  https://review.openstack.org/22513313:17
*** ktolstoy has quit IRC13:18
*** nkrinner_afk has quit IRC13:18
*** ktolstoy has joined #openstack-manila13:21
*** jvarlamova has quit IRC13:21
*** ktolstoy has quit IRC13:21
*** ktolstoy has joined #openstack-manila13:23
*** rraja has joined #openstack-manila13:27
openstackgerritJulia Varlamova proposed openstack/python-manilaclient: Change Manilaclient to use --os-region-name param  https://review.openstack.org/22513313:27
*** jvarlamova has joined #openstack-manila13:28
openstackgerritCsaba Henk proposed openstack/manila: glusterfs: fix gluster-nfs export for volume mapped layout  https://review.openstack.org/22511713:37
*** Zhongjun_ has joined #openstack-manila13:39
openstackgerritMerged openstack/python-manilaclient: Workaround broken openstack client for functional tests  https://review.openstack.org/22506713:42
*** eharney has quit IRC13:45
*** openstackgerrit has quit IRC13:46
*** openstackgerrit has joined #openstack-manila13:46
openstackgerritMerged openstack/python-manilaclient: Fix shares CLI for using CGs  https://review.openstack.org/22511413:52
vponomaryovbswartz: time for tag! =)13:53
*** gouthamr has quit IRC13:55
vponomaryovcknight: have you seen https://bugs.launchpad.net/manila-ui/+bug/1495652 ?13:57
openstackLaunchpad bug 1495652 in manila-ui ""Error: Unable to retrieve volume limit information." as demo user" [Undecided,New]13:57
*** haomaiwang has quit IRC14:01
*** 77CAAT0IJ has joined #openstack-manila14:01
cknightvponomaryov: Had not seen that.  What is meant by 'volume limit information'?14:01
*** akerr has joined #openstack-manila14:02
openstackgerritCsaba Henk proposed openstack/manila: glusterfs*: fix ssh credential options  https://review.openstack.org/22516114:03
*** gouthamr has joined #openstack-manila14:03
bswartzvponomaryov: https://review.openstack.org/#/c/225159/ https://review.openstack.org/#/c/224943/14:10
*** ayma has joined #openstack-manila14:13
*** rraja has quit IRC14:16
*** mtanino has joined #openstack-manila14:16
*** cbrown2_ocf has quit IRC14:17
*** lpetrut has joined #openstack-manila14:21
bswartzvponomaryov: the release merged14:21
bswartzwaiting for 1.4.0 tag to appear14:22
bswartzvponomaryov: 1.4.0 is tagged14:25
bswartzvponomaryov: in g-r the maniaclient version is still 1.2.014:27
bswartzshould it be bumped to 1.3.0?14:27
*** lpetrut has quit IRC14:29
*** baojg has joined #openstack-manila14:30
*** david-lyle has quit IRC14:31
*** rhagarty_ has quit IRC14:36
*** rhagarty has quit IRC14:36
*** rhagarty has joined #openstack-manila14:43
*** rhagarty_ has joined #openstack-manila14:43
*** baojg has quit IRC14:45
openstackgerritMerged openstack/manila-ui: Use v2 API of Manila  https://review.openstack.org/22483614:46
*** ktolstoy has quit IRC14:49
*** ktolstoy has joined #openstack-manila14:49
*** cbrown2_ocf has joined #openstack-manila14:53
*** EinstCrazy has joined #openstack-manila14:56
bswartzvponomaryov: did you want to make a change to manila-ui's requirements before doing the manilaclient release?14:56
*** vbellur has quit IRC15:00
*** 77CAAT0IJ has quit IRC15:01
*** haomaiwang has joined #openstack-manila15:01
*** rushil has joined #openstack-manila15:07
*** vbellur has joined #openstack-manila15:08
*** EinstCrazy has quit IRC15:09
*** resker has quit IRC15:14
*** esker has joined #openstack-manila15:14
vponomaryovbswartz: yes15:19
*** lpabon has joined #openstack-manila15:20
vponomaryovbswartz: why do you update "upper constraint" in https://review.openstack.org/#/c/224943/  ?15:20
vponomaryovbswartz: we should cahnge this - https://github.com/openstack/requirements/blob/b95d747c/global-requirements.txt#L15815:21
bswartzvponomaryov: https://review.openstack.org/#/c/225186/15:22
*** ktolstoy has quit IRC15:23
*** DericHorn-HP has joined #openstack-manila15:27
*** bill_az has quit IRC15:28
bswartzvponomaryov: so can we update requirements for manila-ui before the g-r update? or do we have to wait?15:30
vponomaryovbswartz: we do not have "requirements" job, so - yes, where we have - would fail15:30
vponomaryovbswartz: i.e. in manila15:31
vponomaryovbswartz: we need improve our gates for manila-ui15:31
vponomaryovbswartz: merge https://review.openstack.org/#/c/224885/ ?15:33
bswartzvponomaryov: I've added that to the TODO list for Mitaka15:39
bswartzkeep telling me about core infrastructure stuff that needs time and energy and we'll collect it all and prioritize it for Mitaka15:39
vponomaryovbswartz: manila UI testing is very, very big untilled field15:41
vponomaryovbswartz: + support of all new features15:42
*** ktolstoy has joined #openstack-manila15:42
bswartzyes I need to ask NetApp what is the plan for CGs UI15:45
vponomaryovcknight: I am not sure about "volume limit information" thing, but I remember you have fixed something in NetApp driver according to getting info with some roles fails15:45
cknightvponomaryov: OK.  This one was opened internally by Jeff Applewhite.  I'll follow up directly with him.15:46
eskerbswartz: do you know anybody at NetApp that might know?15:46
*** eharney has joined #openstack-manila15:47
bswartzesker: martyt would know but he's OOO15:47
bswartzesker: I'm just tossing in a story so he doesn't forget15:47
eskerbswartz: I think perhaps my joke missed its target... :-)15:47
openstackgerritMerged openstack/manila: Fix HDS HNAS Create from snapshot ignoring Size  https://review.openstack.org/22511615:53
*** ChanServ changes topic to "Time to fix bugs for RC1. 6 bugs left"15:54
*** haomaiwang has quit IRC16:01
vponomaryovganso: ping16:01
*** haomaiwang has joined #openstack-manila16:01
gansopong16:07
gansovponomaryov: ^16:07
vponomaryovganso: https://bugs.launchpad.net/manila/+bug/149735216:08
openstackLaunchpad bug 1497352 in Manila ""task_state" field of a share is not shown via API" [Undecided,New]16:08
vponomaryovganso: view should not have "experimental=True" indeed, also it is not covered with tests at all =)16:10
*** haomaiwang has quit IRC16:11
gansovponomaryov: hummm, so what do you think the correct fix should be?16:12
gansovponomaryov: updated create and get with experimental true?16:12
gansovponomaryov: or we could remove experimental=true requirement to show it, since it is a field that is committed to DB and would be shown at all times16:13
vponomaryovganso: "task_state" is field of Share Model, it is not directly related to migration16:13
vponomaryovganso: it can be used by any API that works with existing share16:13
gansovponomaryov: agreed. So that commit should be completely reverted, correct?16:13
vponomaryovganso: so, yes, it should not have "experimental" equal to True and should be covered with unit tests at least16:14
vponomaryovganso: no16:14
vponomaryovganso: not reverted16:14
vponomaryovganso: just make its "view" update non-experimental16:14
gansovponomaryov: ok, I will submit a new patch in a few16:15
vponomaryovfew "months"? =)16:16
vponomaryovganso: I can fix it too16:16
gansovponomaryov: few minutes :)16:17
*** DericHorn-HP has quit IRC16:20
bswartzdustins: ping16:21
gansovponomaryov: do you think the change to "get_share" should be reverted? it is useful if anyone wants to use it with experimental = True...16:24
gansovponomaryov: https://review.openstack.org/#/c/223245/4/manila_tempest_tests/services/share/v2/json/shares_client.py16:24
*** lpetrut has joined #openstack-manila16:24
vponomaryovganso: "get_share" is not experimental API16:25
bswartz+116:25
gansovponomaryov: agreed16:25
bswartzexperimental shouldn't be sprinkled everywhere -- it's just a documentation thing for APIs that might be completely changed16:26
vponomaryovbswartz: https://bugs.launchpad.net/manila/+bug/1497352 RC1 candidate?16:28
openstackLaunchpad bug 1497352 in Manila ""task_state" field of a share is not shown via API" [Undecided,New]16:28
vponomaryovbswartz: it is not critical, but it is still a bug, bug in API16:28
bswartzvponomaryov: I'm confused16:28
bswartzwhy does experimental have anything to do with what a non-experimental API returns?16:29
bswartzdid we implement it so the API behaves differently if you send experimental=True vs False?16:29
vponomaryovbswartz: yes16:29
vponomaryovbswartz: such header makes influence16:30
bswartzokay -- that's not something I had intended or even thought about when we designed experimental APIs16:30
bswartzit's not a terrible idea, but we need to carefully consider the consequences16:30
bswartzvponomaryov: what is your proposal? both for how it should work and how to fix this bug16:31
*** eharney has quit IRC16:32
vponomaryovbswartz: fix is easy and useful - API will not require updates and if one startts to use "share migration" he will need it16:32
gansovponomaryov: why did you add 2.5 in test_share_create_with_consistency_group here https://github.com/openstack/manila/commit/3ea5752570564c21d3d0b9386ed2eb23b502a0d2 ?16:32
bswartzvponomaryov: so what does the fix for the bug look like?16:34
vponomaryovbswartz: update "view" decorator to make it not require "experimental" header, that is absent in case of "create/get" operations16:34
vponomaryovbswartz: and should be absent16:34
bswartzright16:34
bswartzthe API should work without experimental16:35
bswartzbut you do think it should work differently *with* experimental?16:35
vponomaryovit already does16:35
bswartzso the change is to allow it to work the old way without experimental?16:35
vponomaryovwe have no "task_state" in response16:35
vponomaryovyes16:36
bswartzyeah that's something which should be RC1 targeted I think16:36
vponomaryovor, then, we will have all our APIs be experimental16:36
vponomaryovif we want to support such things and this makes its implementation redundant if everything start require it16:37
openstackgerritMerged openstack/manila: glusterfs*: amend export location  https://review.openstack.org/22488516:37
bswartzvponomaryov, u_glide1, xyang1, cknight, markstur, toabctl: we have 3 bugfixes ready for review/merge: https://review.openstack.org/224830 https://review.openstack.org/224890 https://review.openstack.org/22484616:38
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/22462316:38
vponomaryovbswartz: last one requires address of merge conflict as csaba said16:39
*** ChanServ changes topic to "Time to fix bugs for RC1. 5 bugs left"16:40
bswartzvponomaryov: oh it conflicts with the patch that just merged16:40
bswartzI hope rraja is around today16:41
openstackgerritOpenStack Proposal Bot proposed openstack/python-manilaclient: Updated from global requirements  https://review.openstack.org/22467616:42
*** ktolstoy has quit IRC16:42
gansovponomaryov: patch is almost ready, I just would like to understand why 2.5 in test_share_create_with_consistency_group to know if I remove "2.5"16:43
vponomaryovganso: why do you want to remove this test?16:44
vponomaryovganso: it is reducing test coverage16:44
gansovponomaryov: because in "2.4" test, task_state will not be there, but in "2.5" it will16:45
gansovponomaryov: the way it is it is not going to pass "2.5"16:45
*** cbrown2_ocf has quit IRC16:45
vponomaryovganso: it is Ok to update case with 2.516:45
vponomaryovganso: no need to remove it16:46
gansovponomaryov: if I add expected['share']['task_state'] = None it will fail "2.4"16:46
vponomaryovganso: you know version in each test16:46
*** eharney has joined #openstack-manila16:46
vponomaryovganso: make condition16:46
gansovponomaryov: oh right, well observed16:47
*** esker has quit IRC16:51
openstackgerritValeriy Ponomaryov proposed openstack/manila: glusterfs_native: Hardwire Manila Host CN pattern  https://review.openstack.org/22484616:51
*** rraja has joined #openstack-manila16:53
vponomaryovxyang1, bswartz: rebased https://review.openstack.org/#/c/224846/ , there was little conflict in test module.16:53
vponomaryovrraja: ^16:54
xyang1vponomaryov: ok16:54
*** jasonsb has quit IRC16:54
rrajavponomaryov: I was just about to commit the patch after resolving the merge conflict. and then I see that you committed the patch already.16:55
vponomaryovbswartz: ganso already works on https://bugs.launchpad.net/manila/+bug/149735216:55
openstackLaunchpad bug 1497352 in Manila ""task_state" field of a share is not shown via API" [High,Triaged] - Assigned to Valeriy Ponomaryov (vponomaryov)16:55
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix experimental=True for view in microversion 2.5  https://review.openstack.org/22524116:55
gansovponomaryov: yup ^16:55
rrajavponomaryov: thanks!16:55
vponomaryovrraja: does CI cover this case?16:56
*** cknight has quit IRC16:57
*** cknight has joined #openstack-manila16:57
bswartzvponomaryov: oh oops16:58
rrajavponomaryov: no! our CI is currently broken. we'd need to test it once I manage to get that up early next week.16:59
vponomaryovrraja: ok17:00
bswartzrraja: fixing glusterfs jenkins jobs is urgent17:00
bswartzplease don't put that off17:00
bswartzvponomaryov, rraja: thanks for quickly fixing rebase conflict I'll rereview17:00
rrajabswartz: terribly sorry! yes! I understand the urgency. the behemoth patch that csaba had merged late in the feature freeze is not something I was prepared for.17:02
*** lpetrut has quit IRC17:03
*** lpetrut has joined #openstack-manila17:03
rrajas/is/was/17:04
*** rraja has quit IRC17:05
*** lpetrut has quit IRC17:07
*** absubram has joined #openstack-manila17:09
*** DericHorn-HP has joined #openstack-manila17:14
gansovponomaryov: replied to your question17:29
dustinsbswartz: pong17:29
vponomaryovganso: in https://review.openstack.org/#/c/225241/1/manila_tempest_tests/services/share/v2/json/shares_client.py is unsafe get of "task-state"17:29
* dustins was out at lunch17:29
vponomaryovganso: also, it should be tested in "test case"17:30
vponomaryovganso: you changed "client"17:30
vponomaryovganso: client should use "guaranteed" thing to make its work17:30
vponomaryovganso: no need to use "latest"17:31
gansovponomaryov: I see, so the client should receive version parameter from method calling it, correct?17:31
vponomaryovganso: so, proper thing to do is to add one more functional test covering it and use in client some fixed version, may be redefined with arg17:32
*** DericHorn-HP has quit IRC17:38
*** zhongjun has quit IRC17:40
*** Zhongjun_ is now known as Zhongjun17:40
openstackgerritMerged openstack/manila: Fix HDS HNAS manage incorrect share size  https://review.openstack.org/22483017:40
*** ChanServ changes topic to "Time to fix bugs for RC1. 4 bugs left"17:45
*** erlon has joined #openstack-manila17:46
*** Zhongjun has quit IRC17:47
openstackgerritMerged openstack/manila: Fix pool_list filter tests to match pools exactly  https://review.openstack.org/22489017:50
*** DericHorn-HP has joined #openstack-manila17:51
*** ChanServ changes topic to "Time to fix bugs for RC1. 3 bugs left"17:52
*** timcl1 has joined #openstack-manila17:52
bswartzganso: new patch incoming?17:55
*** akerr has quit IRC17:55
*** akerr has joined #openstack-manila17:56
*** timcl has quit IRC17:56
gansobswartz: working on it, adapting manila_tempest changes17:56
bswartzbbiab17:57
*** bswartz has quit IRC17:58
openstackgerritRodrigo Barbieri proposed openstack/manila: Fix experimental=True for view in microversion 2.5  https://review.openstack.org/22524118:01
gansovponomaryov ^18:02
*** jasonsb has joined #openstack-manila18:05
*** vbellur has quit IRC18:09
*** jasonsb has quit IRC18:14
*** jasonsb has joined #openstack-manila18:14
*** cknight has quit IRC18:23
*** vbellur has joined #openstack-manila18:28
*** tpsilva has joined #openstack-manila18:43
*** rraja has joined #openstack-manila18:50
*** rraja has quit IRC18:50
*** vbellur has quit IRC18:51
*** dzamboni has quit IRC19:02
*** sage has quit IRC19:13
*** sage has joined #openstack-manila19:13
*** sage has quit IRC19:13
*** sage has joined #openstack-manila19:15
*** tpsilva has quit IRC19:20
*** timcl1 has quit IRC19:21
*** timcl has joined #openstack-manila19:23
*** cknight has joined #openstack-manila19:35
*** cknight1 has joined #openstack-manila19:38
*** absubram has quit IRC19:40
*** cknight has quit IRC19:41
*** timcl has quit IRC19:42
gansovponomaryov: Valeriy, I read your comments, I am sorry but I am having a hard time understanding what is missing19:49
*** DericHorn-HP has quit IRC19:49
*** jasonsb_ has joined #openstack-manila19:51
*** jasonsb has quit IRC19:51
*** tpsilva has joined #openstack-manila19:55
*** bswartz has joined #openstack-manila20:09
*** akshai has joined #openstack-manila20:19
*** tpsilva has quit IRC20:23
bswartzI'm back I wasn't able to get wireless working while in that meeting....20:24
*** cknight1 has quit IRC20:35
*** akerr has quit IRC20:41
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/22462320:43
*** a_ta has joined #openstack-manila20:44
*** jasonsb_ has quit IRC20:44
*** jasonsb has joined #openstack-manila20:44
a_taHello, we're trying to create a manila share on the glustershare driver but keep failing with "Failed to schedule create_share: No valid hosts was found"20:45
a_tadoes anyone know what could be causing this?20:45
*** gouthamr has quit IRC20:57
*** dustins has quit IRC21:04
bswartza_ta: there are 2 glusterfs drivers, the regular one and the native one21:06
bswartza_ta: which one are you using and what kind of share are you trying to create?21:06
a_tawe are using the regular one to create an NFS21:06
bswartza_ta: that should work21:07
bswartzthe glusterfs experts here are csaba and rraja21:07
a_taok, I'll try to ping them. thanks!21:10
bswartza_ta: you could also try eharney and lpabon21:10
lpabona_ta: hi21:11
lpaboni'll try to see if I can help you21:11
*** bswartz has quit IRC21:12
*** bswartz has joined #openstack-manila21:12
*** chlong has quit IRC21:14
*** eharney has quit IRC21:20
*** rushil has quit IRC21:22
*** lpabon has quit IRC21:26
*** DericHorn-HP has joined #openstack-manila21:27
*** DericHorn-HP has quit IRC21:28
*** DericHorn-HP has joined #openstack-manila21:29
*** erlon has quit IRC21:48
*** jasonsb_ has joined #openstack-manila22:00
*** jasonsb has quit IRC22:00
*** DericHorn-HP has quit IRC22:00
openstackgerritMerged openstack/manila: Fix experimental=True for view in microversion 2.5  https://review.openstack.org/22524122:00
*** alyson_ has quit IRC22:01
*** eduardo has quit IRC22:04
*** ayma has quit IRC22:06
*** ganso has quit IRC22:15
*** ganso has joined #openstack-manila22:18
*** gouthamr has joined #openstack-manila22:20
*** lpabon has joined #openstack-manila22:26
*** lpabon has quit IRC22:31
*** lpabon has joined #openstack-manila22:37
*** lpabon has quit IRC22:38
*** lpabon has joined #openstack-manila22:38
*** lpabon has quit IRC22:39
*** lpabon has joined #openstack-manila22:39
*** lpabon has quit IRC22:44
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-manila22:46
*** jasonsb_ has quit IRC22:52
*** jasonsb has joined #openstack-manila22:53
openstackgerritMerged openstack/manila: Updated from global requirements  https://review.openstack.org/22462322:53
*** gouthamr has quit IRC23:03
*** netapp has quit IRC23:05
*** akshai has quit IRC23:05
*** jasonsb has quit IRC23:08
*** a_ta has quit IRC23:10
*** esker has joined #openstack-manila23:15
*** jasonsb has joined #openstack-manila23:16
*** esker has quit IRC23:22
*** akshai has joined #openstack-manila23:26
*** akshai_ has joined #openstack-manila23:34
*** akshai has quit IRC23:37
*** esker has joined #openstack-manila23:41
*** esker has quit IRC23:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!