Monday, 2020-08-10

*** yamamoto has joined #openstack-lbaas00:08
*** yamamoto has quit IRC00:13
*** sapd1 has quit IRC00:33
openstackgerritsuhaiming proposed openstack/octavia master: Correct a typo in the document  https://review.opendev.org/74547101:04
*** lxkong has joined #openstack-lbaas01:20
*** spatel has joined #openstack-lbaas01:28
*** spatel has quit IRC01:28
*** yamamoto has joined #openstack-lbaas02:17
*** sapd1 has joined #openstack-lbaas02:42
*** sapd1 has quit IRC02:47
*** mvorwerk has joined #openstack-lbaas02:51
*** sapd1 has joined #openstack-lbaas02:55
*** mvorwerk has quit IRC02:56
*** psachin has joined #openstack-lbaas03:35
*** yamamoto has quit IRC04:01
*** yamamoto has joined #openstack-lbaas04:06
*** yamamoto has quit IRC04:23
*** vishalmanchanda has joined #openstack-lbaas04:28
*** ramishra has joined #openstack-lbaas04:31
*** gcheresh_ has joined #openstack-lbaas05:00
*** yamamoto has joined #openstack-lbaas05:02
*** yamamoto has quit IRC05:11
*** sapd1 has quit IRC05:37
*** yamamoto has joined #openstack-lbaas05:42
*** yamamoto has quit IRC05:45
*** yamamoto has joined #openstack-lbaas05:54
*** yamamoto has quit IRC06:00
*** yamamoto has joined #openstack-lbaas06:39
*** yamamoto has quit IRC06:42
*** yamamoto has joined #openstack-lbaas06:42
*** mvorwerk has joined #openstack-lbaas06:42
*** gregwork has quit IRC06:49
*** maciejjozefczyk has joined #openstack-lbaas07:08
*** sapd1 has joined #openstack-lbaas07:19
*** yamamoto has quit IRC07:27
*** ataraday_ has joined #openstack-lbaas07:32
*** maciejjozefczyk has quit IRC07:37
*** ccamposr has joined #openstack-lbaas07:40
*** maciejjozefczyk has joined #openstack-lbaas07:41
*** ccamposr__ has quit IRC07:42
*** maciejjozefczyk has quit IRC07:52
*** yamamoto has joined #openstack-lbaas07:58
*** maciejjozefczyk has joined #openstack-lbaas08:02
*** yamamoto has quit IRC08:05
openstackgerritMerged openstack/octavia master: [Trivial]Add missing space between words  https://review.opendev.org/74347608:32
*** yamamoto has joined #openstack-lbaas08:35
*** maciejjozefczyk has quit IRC08:52
*** maciejjozefczyk has joined #openstack-lbaas08:52
*** yamamoto has quit IRC08:59
*** sapd1 has quit IRC09:04
*** born2bake has joined #openstack-lbaas09:09
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs  https://review.opendev.org/74452009:17
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add HTTP/2 over TLS support to amphora provider  https://review.opendev.org/74490509:17
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add Copr cgoncalves/haproxy repo for CentOS amps  https://review.opendev.org/74410209:17
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib  https://review.opendev.org/74550609:17
*** rcernin has quit IRC09:24
*** yamamoto has joined #openstack-lbaas09:34
*** sapd1 has joined #openstack-lbaas09:38
*** yamamoto has quit IRC09:41
*** yamamoto has joined #openstack-lbaas09:52
*** yamamoto has quit IRC09:58
*** yamamoto has joined #openstack-lbaas10:05
*** yamamoto has quit IRC10:12
*** yamamoto has joined #openstack-lbaas10:17
*** vishalmanchanda has quit IRC10:18
*** psachin has quit IRC10:36
*** maciejjozefczyk has quit IRC10:48
*** maciejjozefczyk has joined #openstack-lbaas10:51
*** gcheresh_ has quit IRC10:54
*** gcheresh_ has joined #openstack-lbaas11:01
*** sapd1 has quit IRC11:25
*** servagem has joined #openstack-lbaas11:54
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib  https://review.opendev.org/74550612:21
*** wuchunyang has joined #openstack-lbaas12:43
*** wuchunyang has quit IRC12:45
*** wuchunyang has joined #openstack-lbaas12:46
*** wuchunyang has quit IRC12:48
*** wuchunyang has joined #openstack-lbaas12:48
*** yamamoto has quit IRC12:52
*** wuchunyang has quit IRC12:53
*** yamamoto has joined #openstack-lbaas12:53
*** yamamoto has quit IRC12:53
*** yamamoto has joined #openstack-lbaas12:54
*** wuchunyang has joined #openstack-lbaas12:56
*** wuchunyang has quit IRC12:57
*** yamamoto has quit IRC12:58
*** yamamoto has joined #openstack-lbaas13:00
*** yamamoto has quit IRC13:04
*** TrevorV has joined #openstack-lbaas13:49
*** sapd1 has joined #openstack-lbaas14:01
*** sapd1 has quit IRC14:08
*** psachin has joined #openstack-lbaas14:10
*** sapd1 has joined #openstack-lbaas14:25
*** psachin has quit IRC14:30
*** gcheresh_ has quit IRC14:51
*** sapd1 has quit IRC14:56
*** ataraday_ has quit IRC15:07
*** armax has joined #openstack-lbaas15:16
*** gcheresh_ has joined #openstack-lbaas15:48
*** mvorwerk has quit IRC15:49
*** mvorwerk has joined #openstack-lbaas15:53
*** yamamoto has joined #openstack-lbaas15:58
*** yamamoto has quit IRC16:18
*** ramishra has quit IRC16:51
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs  https://review.opendev.org/74452017:13
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs  https://review.opendev.org/74452017:34
openstackgerritMichael Johnson proposed openstack/octavia-tempest-plugin master: Adjust API tests for NotImplemented skip  https://review.opendev.org/74480518:13
johnsomOne more suite of tests to fix....18:16
*** yamamoto has joined #openstack-lbaas18:17
*** yamamoto has quit IRC18:29
*** gcheresh_ has quit IRC18:32
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib  https://review.opendev.org/74550619:46
openstackgerritCarlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs  https://review.opendev.org/74452019:46
haleybjohnsom: i have a question about the 'create pool' API, wondering if you had a minute for a question20:22
johnsomI sure do20:22
johnsomAnything to take a break from test code... lol20:22
haleybmaciej had started a fix for this bug, https://bugs.launchpad.net/neutron/+bug/188864620:22
openstackLaunchpad bug 1888646 in neutron "[OVN Octavia Provider] octavia_tempest_plugin.tests.api.v2.test_pool.PoolAPITest.test_pool_create_with_listener fails" [High,In progress] - Assigned to Brian Haley (brian-haley)20:22
haleybbut i see conflicting code between the api and scenario tests, don't know if one is wrong20:23
haleybbasically, he surmised a 'create pool' with a listener should yield an operating status of ONLINE20:23
haleybi can't find in the api-ref if that is correct20:24
johnsomWell, per the API reference, the only case something is "OFFLINE" is if it is administratively disabled.20:25
haleybthese two tests are different, let me paste20:26
haleyboctavia_tempest_plugin.tests.scenario.v2.test_pool.PoolScenarioTest.test_TCP_SIP_pool_with_listener_CRUD20:26
haleyboctavia_tempest_plugin.tests.api.v2.test_pool.PoolAPITest.test_pool_create_with_listener20:26
haleybthe second checks operating status based on a listener being present, the first always checks OFFLINE20:26
*** yamamoto has joined #openstack-lbaas20:28
johnsomYeah, so the json returned from the "create" call will have operating status "OFFLINE" and provisioning status "PENDING_CREATE" in it. After it is provisioned a call to "pool show" will return operating status "ONLINE" and provisioning status "ACTIVE".20:31
johnsomYeah, the scenario test there is a bit odd and subject to race I would say.20:33
haleybjohnsom: so that operating status isn't dependent on a listener being in the pool?  the api checks that20:34
haleybif has_listener and not CONF.load_balancer.test_with_noop:20:34
haleybcheck for ONLINE20:34
johnsomWell if the pool is attached to the LB, it is not operational. Only if it's attached to a listener does it receive traffic.20:37
*** yamamoto has quit IRC20:38
haleybso, should https://review.opendev.org/#/c/714004/29/octavia_tempest_plugin/tests/scenario/v2/test_pool.py#L440 be changed?  i.e. check depending on listener_protocol?  i can only guess that would fail against the amphora driver20:41
haleybthat link doesnt work :(20:41
johnsomThere aren't 440 lines in that file20:42
johnsomWell, the non-patch version of that file20:42
haleybi added the #L440 by hand, so was going to fail, was just trying to highlight L440 on the right-hand side20:42
*** yamamoto has joined #openstack-lbaas20:42
haleybhttps://review.opendev.org/#/c/714004/29/octavia_tempest_plugin/tests/scenario/v2/test_pool.py@44020:44
*** servagem has quit IRC20:48
johnsomWell, like I mentioned above, it's probably subject to race, but that test has passed that way for probably about three years.20:49
johnsomAh, I guessed wrong, two years.20:50
johnsomlol20:50
*** TrevorV has quit IRC20:52
haleybso it passes because the initial check shows it OFFLINE, but later could be ONLINE.  with the OVN driver we can set the status right away, so we can pass the API or scenario test, but not both, i'll open a bug for the scenario test and try to make both the same20:55
johnsomOperating status is observed status, so there is a time window before it switches to ONLINE. Basically we don't want to lie to the user by marking it ONLINE when in reality the pool is still being provisioned. So in OVN case, after all of the OVS instances are programmed would it go ONLINE.20:58
johnsomIn theory. Now, if you want to set it online right away, that is up to the driver I guess.20:59
*** maciejjozefczyk has quit IRC20:59
haleybwell, in this case i think maciej's change at https://review.opendev.org/#/c/742644/5/ovn_octavia_provider/helper.py is valid - the OVN DB command succeeded, and since there was a listener id given it should be ONLINE21:03
haleybbut his assumption might be based off the test21:04
johnsomYeah, the API test is correct.21:05
*** ccamposr has quit IRC21:05
johnsomYeah, that looks fine. Technically you don't need to set it OFFLINE as it would already be in that state.21:05
haleybthe one that waits... so i guess it should also check for OFFLINE in an else:21:05
haleyband the scenario test could basically do the same thing, i just don't know about the noop check21:06
johnsomNoop will never go online as there is nothing to observe that status.21:06
haleybright, guess i'm saying the check in the scenario test should also have the noop check21:08
johnsomThere is no point to running scenario tests with the noop drivers.21:10
haleyboh, that test_with_noop isn't going to be set, right :)21:11
*** rcernin has joined #openstack-lbaas21:49
*** rcernin has quit IRC21:50
*** rcernin has joined #openstack-lbaas21:50
*** born2bake has quit IRC21:52
*** ccamposr has joined #openstack-lbaas21:52
*** tkajinam has joined #openstack-lbaas22:46
johnsomrm_work: https://storyboard.openstack.org/#!/story/200799823:07
rm_workYeah makes sense I think? But ugh.23:11
johnsomYeah, maybe just need a try/except block in the client when it compiles that "data" list?23:12
*** rcernin has quit IRC23:14
*** rcernin has joined #openstack-lbaas23:17
johnsomMaybe you or sorrison can handle that? I'm a bit buried in tempest land at the moment.23:18
*** mvorwerk_ has joined #openstack-lbaas23:20
*** mvorwerk has quit IRC23:22
rm_workYeah wrapping up metrics soon23:31

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!