Tuesday, 2022-05-10

opendevreviewTakashi Kajinami proposed openstack/keystonemiddleware master: Remove six  https://review.opendev.org/c/openstack/keystonemiddleware/+/84118000:09
*** dviroel|afk is now known as dviroel11:28
knikollagmann: is there a srbac meeting today? if not, when is it?13:18
*** dasm|off is now known as dasm13:31
gmannknikolla: yes, its in an 5 min from now https://wiki.openstack.org/wiki/Consistent_and_Secure_Default_Policies_Popup_Team#Meeting13:55
gmannknikolla: dansmith  dmendiza[m] RBAC meeting started in https://meet.google.com/gie-derw-eer14:01
opendevreviewJulia Kreger proposed openstack/keystoneauth master: WIP: Only include parameters not present upon redirect  https://review.opendev.org/c/openstack/keystoneauth/+/84116914:13
*** dviroel is now known as dviroel|lunch|afk14:53
dmendiza[m]#startmeeting keystone15:01
opendevmeetMeeting started Tue May 10 15:01:01 2022 UTC and is due to finish in 60 minutes.  The chair is dmendiza[m]. Information about MeetBot at http://wiki.debian.org/MeetBot.15:01
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:01
opendevmeetThe meeting name has been set to 'keystone'15:01
knikollao/15:01
dmendiza[m]#topic Roll Call15:01
h-asahinao/15:01
bbobrovhenlo15:01
dmendiza[m]Hi y'all!15:02
dmendiza[m]As usual the agenda is over here:15:03
dmendiza[m]#link https://etherpad.opendev.org/p/keystone-weekly-meeting15:03
dmendiza[m]Courtesy ping for admiyo, bbobrov, crisloma, d34dh0r53, dpar, dstanek, hrybacki, knikolla, lbragstad, lwanderley, kmalloc, rodrigods, samueldmq, ruan_he, wxy, sonuk, vishakha, Ajay, rafaelwe15:03
d34dh0r53o/15:03
dmendiza[m]#topic Review Past Meeting Action Items15:03
dmendiza[m]#link https://meetings.opendev.org/meetings/keystone/2022/keystone.2022-05-03-15.26.html15:03
d34dh0r53lurking today, conflict with another meeting15:03
dmendiza[m]We didn't have any šŸŽ‰15:03
dmendiza[m]#topic Liaison Updates15:04
dmendiza[m]I don't have any updates this week15:04
dmendiza[m]...15:05
dmendiza[m]Although now that I think about it15:05
dmendiza[m]Zed-1 Milestone is next week15:05
dmendiza[m]#link https://releases.openstack.org/zed/schedule.html15:05
dmendiza[m]I'm not sure if we have any deadlines for Zed-1?15:05
dmendiza[m]I'm guessing probably not15:06
dmendiza[m]OK, moving on15:09
dmendiza[m]#topic OAuth 2.015:09
dmendiza[m]Do we have any updates this week?15:09
h-asahinaFrom us no update.15:09
h-asahinaWe are planning to apply comments within this month.15:11
*** afaranha__ is now known as afaranha15:11
dmendiza[m]thanks h-asahina 15:11
h-asahinathank you too for your review :)15:11
dmendiza[m]#topic Secure RBAC15:12
dmendiza[m]We had a pop-up meeting this morning right before this meeting.15:12
dmendiza[m]We discussed the "service" role spec, and gmann will be updating some comments there with the discussion points.15:13
dmendiza[m]We also agreed to enable the new defaults in Keystone this cycle15:13
dmendiza[m]enabled by default, that is15:13
dmendiza[m]new defaults by default. :D15:13
dmendiza[m]So we'll work on a patch for that.15:14
dmendiza[m]The next pop-up will be in 2 weeks on May 24th @ 1400 UTC15:14
dmendiza[m]Any questions/comments about Secure RBAC?15:15
dmendiza[m]OK, moving on15:17
dmendiza[m]#topic Gate inherited assignments from parent (bbobrov)15:17
bbobrovhi15:17
dmendiza[m]#link https://review.opendev.org/c/openstack/keystone-specs/+/33436415:17
bbobrovthis spec is from 2016, so we can send it to school soon15:17
dmendiza[m]haha15:18
bbobrovoriginally it was proposed by Henry Nash when he was working on his hierarchical-everything project15:18
bbobrovi reworked the spec and simplified it15:18
bbobrovthe tldr version is that some projects in the hierarchy need to be exempt from inherited role assignments15:18
bbobrovmy current proposal is to make it as simple as possible. The project has a tag -> it is exempt. Its subtree is not affected15:18
bbobrovwe can also affect the subtree. It should not be much harder, but i do not have a usecase for that - we use an almost-flat hierarchy in my company15:19
bbobrovplease comment and review15:19
bbobrovi will implement it when if accepted15:20
knikollathanks! makes sense to me15:20
dmendiza[m]yeah, we'll review the spec and go from there15:23
dmendiza[m]Anything else on this topic for now? bbobrov ?15:24
bbobrovnope, thanks15:24
dmendiza[m]Cool, I'll add the spec to the Reviewathon this Friday15:24
dmendiza[m]#topic bandit seems to be broken, cannot build keystone from git 15:25
dmendiza[m]I think this is admiyo 's topic15:25
dmendiza[m]I have not tried to build a fresh clone15:25
dmendiza[m]so I'm not sure if this is currently an issue?15:25
dmendiza[m]I'll try to reproduce it this week and see what happens15:27
dmendiza[m]#topic Bug Review15:27
dmendiza[m]Let's start with the one that bbobrov added15:27
dmendiza[m]#link https://bugs.launchpad.net/keystone/+bug/195032515:28
bbobrovthank you15:29
bbobrovi added it on top because it is not new15:29
bbobrovPast discussion about this bug: https://meetings.opendev.org/irclogs/%23openstack-keystone/%23openstack-keystone.2021-11-09.log.html#t2021-11-09T15:29:3015:29
bbobrovI am hitting the bug more and more often and would like to fix it15:29
bbobrovWhat was the agreement on the way to fix it? Do we return the domains the user has access to? Do we return only 1 domain (the one the token is scoped to)? Do we return all domains?15:29
bbobrovIn my company domain list is basically public, so i do not have a preference15:29
knikollaif it's domain scoped it should probably only return the domain in the token15:31
knikollaor at least follow the same behavior of listing projects with a project scoped token (?)15:32
bbobrovhmm, i wonder what the behavior will be15:33
bbobrovlet me try real quick15:33
knikollai think my comment from back then makes sense. if /projects returns the domain in the unfiltered list, then /projects?is_domain=true should also return it15:35
knikollasince it's weird to provide a subset that gives you a result not included in the larger set15:36
knikollaoh, the flag doesn't act as a filter.15:37
knikollai need more coffee 15:37
bbobrovit does not return the domain15:38
knikollaquoting "redrobotsounds like GET /v3/projects?is_domain=true should be the same as GET /v3/domains"15:38
bbobrovthis is also something i was thinking about15:39
bbobrovalso "project list" seems to return projects that i do not have access to15:40
knikollaif you are scoped to the domain, you can query the projects in the domain IIRC15:40
bbobrovi am scoped to a "is_admin" project15:40
bbobrov(old setup, no system-scope yet)15:41
knikollaif you are admin, you can query everything15:41
bbobrovoof15:41
bbobrovok, at least nobody thinks that 40x or empty list is the way to go, right?15:42
knikollait depends on what /v3/domains returns. 15:43
knikollai think v3/projects?is_domain=True should be equal to that15:43
dmendiza[m]^^^ I still think this too15:44
knikollai don't know if having a role on a domain allows you to query that domain, so empty list may be a valid response. 15:44
* dmendiza[m] is formerly known as redrobot15:44
bbobrovok. I will then propose a change that will make that request behave the same way as a request to /v3/domains, and we can go from there15:45
dmendiza[m]sounds good bbobrov 15:45
bbobrovthanks, i have nothing else about this topic15:45
dmendiza[m]Cool, thanks15:45
dmendiza[m]Moving on to the rest of the bug review15:45
knikollaif you're looking for domains a user can scope to, we also have this https://docs.openstack.org/api-ref/identity/v3/?expanded=get-available-domain-scopes-detail#get-available-domain-scopes15:46
dmendiza[m]#link https://bugs.launchpad.net/keystone/?orderby=-id&start=015:46
dmendiza[m]I don't think we've looked at this one yet:15:47
dmendiza[m]#link https://bugs.launchpad.net/keystone/+bug/197093215:47
dmendiza[m]> 15:47
dmendiza[m]Domain Admins possibility for privilege escalation15:47
knikollalooks like expected behavior with the current state of the policy world15:49
dmendiza[m]Yeah, title seems way scarier than it actually is15:50
knikollasounds like is_admin_project is kicking in and just checking the name15:50
dmendiza[m]oof15:50
knikollaso this is most probably solved by the new policy defaults15:51
dmendiza[m]Yup.  I'll comment on there 15:51
dmendiza[m]next15:51
dmendiza[m]#link https://bugs.launchpad.net/keystone/+bug/197169115:51
dmendiza[m]>  Support application credentials as a source for EC2 auth 15:52
bbobrovit feels more like a feature request15:52
dmendiza[m]Yep, sure does15:52
knikollainteresting feature idea. extends what we did for oauth 2.0  client credentials using app creds15:53
knikollawe could use app creds as an engine for those too.15:53
bbobrovthe reporter and i work in the same company, so i am interested in the feature too, but i do not have a direct understanding the usecase15:53
bbobrovbut the idea is indeed that app creds are used as an engine for ec2 creds15:54
knikollaThis definitely needs a spec15:54
dmendiza[m]Yeah, I'll leave a comment to please write a spec with a link to our spec doc15:55
dmendiza[m]That's it for keystone bugs15:56
dmendiza[m]moving on15:56
dmendiza[m]#link https://bugs.launchpad.net/python-keystoneclient/?orderby=-id&start=015:56
dmendiza[m]No new python-keystoneclient bugs15:56
dmendiza[m]#link https://bugs.launchpad.net/keystoneauth/+bugs?orderby=-id&start=015:57
dmendiza[m]No new keystoneauth bugs15:57
dmendiza[m]#link https://bugs.launchpad.net/keystonemiddleware/+bugs?orderby=-id&start=015:58
dmendiza[m]No new keystonemiddleware bugs15:58
dmendiza[m]#link https://bugs.launchpad.net/pycadf/+bugs?orderby=-id&start=015:58
dmendiza[m]and no new pycadf bugs15:58
dmendiza[m]#link https://bugs.launchpad.net/ldappool/+bugs?orderby=-id&start=015:58
dmendiza[m]and no new ldappool bugs15:58
dmendiza[m]...15:58
dmendiza[m]And we're just about out of time.15:58
dmendiza[m]Thanks for joining, y'all!15:58
dmendiza[m]#endmeeting15:58
opendevmeetMeeting ended Tue May 10 15:58:59 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:58
opendevmeetMinutes:        https://meetings.opendev.org/meetings/keystone/2022/keystone.2022-05-10-15.01.html15:58
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/keystone/2022/keystone.2022-05-10-15.01.txt15:58
opendevmeetLog:            https://meetings.opendev.org/meetings/keystone/2022/keystone.2022-05-10-15.01.log.html15:58
alistarleHey folks, seems I miss the open discussion this time, so if anyone left I have a question regarding groups in mapping for federation 15:59
dmendiza[m]Hi alistarle 16:00
alistarleIt seems that we can only assign one group at a time in the mapping, and Keystone doesn't iterate over the array of the OIDC claim16:00
alistarleI saw a patch to fix that in the project creation workflow : https://review.opendev.org/c/openstack/keystone/+/727891, but nothing seems to be done group side, can I propose a patch for that ?16:01
alistarleMore precisely, keystone can't assign multiple group at a time (despite the OIDC claim is well interpreted as a python array), and it require the mapping to be done like that, not very generic:     {16:03
alistarle        "local": [16:03
alistarle            {16:03
alistarle                "group": {16:03
alistarle                    "name": "/dev"16:03
alistarle                }16:03
alistarle            }16:03
alistarle        ],16:03
alistarle        "remote": [16:03
alistarle            {16:03
alistarle                "type": "HTTP_OIDC_GROUPS",16:03
alistarle                "any_one_of": [16:03
alistarle                    "/dev"16:03
alistarle                ]16:03
alistarle            }16:03
alistarle        ]16:03
alistarle    },16:03
alistarle    {16:03
alistarle        "local": [16:03
alistarle            {16:03
alistarle                "group": {16:03
alistarle                    "name": "/ops"16:03
alistarle                }16:03
alistarle            }16:03
alistarle        ],16:03
alistarle        "remote": [16:03
alistarle            {16:03
alistarle                "type": "HTTP_OIDC_GROUPS",16:03
alistarle                "any_one_of": [16:03
alistarle                    "/ops"16:03
alistarle                ]16:03
alistarle            }16:03
alistarle        ]16:03
alistarle    }16:03
dmendiza[m]d34dh0r53 is my go-to federation guy16:08
dmendiza[m]d34dh0r53: what do you think about ^^^16:08
dmendiza[m]?16:08
*** dasm is now known as dasm|bbl17:27
d34dh0r53Yeah, that is a limitation of the mapping engine AFAIK.  A patch would be great, Iā€™d be happy to review it17:56
d34dh0r53dmendiza[m], alistarle: ^17:56
opendevreviewMerged openstack/pycadf master: Drop lower-constraints.txt and its testing  https://review.opendev.org/c/openstack/pycadf/+/84006218:32
*** dviroel|lunch|afk is now known as dviroel\18:53
*** dviroel\ is now known as dviroel18:53
*** dviroel is now known as dviroel|out21:22

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!