Wednesday, 2019-09-11

*** jamesmcarthur has joined #openstack-keystone00:02
*** liushuobj__ has joined #openstack-keystone00:02
*** liushuo_ has quit IRC00:05
*** jamesmcarthur has quit IRC00:06
*** jamesmcarthur has joined #openstack-keystone00:10
*** jamesmcarthur has quit IRC00:27
*** liushuo_ has joined #openstack-keystone00:33
*** liushuobj__ has quit IRC00:37
*** jamesmcarthur has joined #openstack-keystone00:39
*** gyee has quit IRC00:42
*** jamesmcarthur has quit IRC00:44
*** jamesmcarthur has joined #openstack-keystone01:02
*** spatel has joined #openstack-keystone01:24
*** liushuobj__ has joined #openstack-keystone01:24
*** tkajinam has quit IRC01:25
*** lbragstad has quit IRC01:26
*** tkajinam has joined #openstack-keystone01:26
*** lbragstad has joined #openstack-keystone01:26
openstackgerritColleen Murphy proposed openstack/keystone master: Remove obsolete grant policies from policy.v3cloudsample.json  https://review.opendev.org/66773101:27
*** liushuo_ has quit IRC01:28
*** jamesmcarthur has quit IRC01:59
*** liushuo_ has joined #openstack-keystone02:02
*** jamesmcarthur has joined #openstack-keystone02:04
*** liushuobj__ has quit IRC02:05
*** FlorianFa has quit IRC02:15
*** liushuobj__ has joined #openstack-keystone02:28
*** liushuo_ has quit IRC02:32
*** FlorianFa has joined #openstack-keystone02:35
*** jamesmcarthur has quit IRC03:00
*** spatel has quit IRC03:03
*** jamesmcarthur has joined #openstack-keystone03:06
openstackgerritMerged openstack/keystone master: Implement system reader for implied roles  https://review.opendev.org/68079503:09
*** jamesmcarthur has quit IRC03:13
*** jamesmcarthur has joined #openstack-keystone03:25
*** liushuo_ has joined #openstack-keystone03:35
*** liushuobj__ has quit IRC03:39
*** knikolla has quit IRC03:42
*** ildikov has quit IRC03:42
*** csatari has quit IRC03:42
*** knikolla has joined #openstack-keystone03:45
*** ildikov has joined #openstack-keystone03:45
*** csatari has joined #openstack-keystone03:45
openstackgerritMerged openstack/python-keystoneclient master: Generate pdf documentation  https://review.opendev.org/67937703:49
*** liushuobj__ has joined #openstack-keystone03:50
*** liushuo_ has quit IRC03:53
*** jamesmcarthur has quit IRC03:57
*** etp has joined #openstack-keystone04:12
*** dave-mccowan has quit IRC04:29
*** liushuobj__ has quit IRC04:32
*** liushuobj__ has joined #openstack-keystone04:33
*** pcaruana has joined #openstack-keystone04:42
openstackgerritMerged openstack/keystone master: Remove system policy and its association from policy.v3cloudsample.json  https://review.opendev.org/67847504:49
openstackgerritMerged openstack/keystone master: Generate PDF documentation  https://review.opendev.org/66998204:49
openstackgerritColleen Murphy proposed openstack/keystone master: Implement system scope for domain role management  https://review.opendev.org/68084404:54
*** Luzi has joined #openstack-keystone05:07
*** pcaruana has quit IRC05:12
*** rcernin has quit IRC05:22
*** redrobot has quit IRC05:25
*** rcernin has joined #openstack-keystone05:38
openstackgerritColleen Murphy proposed openstack/keystone master: Expose access rules as its own API  https://review.opendev.org/66823805:44
openstackgerritColleen Murphy proposed openstack/keystone master: Add access rules to token validation  https://review.opendev.org/63199305:44
openstackgerritColleen Murphy proposed openstack/keystone master: Update API version for access rules  https://review.opendev.org/67137405:44
*** rcernin has quit IRC05:51
openstackgerritAndreas Jaeger proposed openstack/keystone master: Fix timeout Zuul changes  https://review.opendev.org/68138006:05
*** rcernin has joined #openstack-keystone06:09
*** pcaruana has joined #openstack-keystone06:21
*** etp has quit IRC06:32
*** etp has joined #openstack-keystone06:33
*** liushuo_ has joined #openstack-keystone06:38
*** liushuobj__ has quit IRC06:42
*** dancn has joined #openstack-keystone06:42
*** liushuobj__ has joined #openstack-keystone07:06
*** awalende has joined #openstack-keystone07:08
*** trident has quit IRC07:08
*** ivve has joined #openstack-keystone07:09
*** liushuo_ has quit IRC07:10
*** tesseract has joined #openstack-keystone07:11
*** trident has joined #openstack-keystone07:17
*** liushuo_ has joined #openstack-keystone07:18
*** liushuobj__ has quit IRC07:22
*** trident has quit IRC07:22
*** liushuobj__ has joined #openstack-keystone07:28
openstackgerritVishakha Agarwal proposed openstack/keystone master: Implement scope type checking for EC2 credentials  https://review.opendev.org/60782007:29
*** trident has joined #openstack-keystone07:31
*** liushuo_ has quit IRC07:32
*** rcernin has quit IRC07:38
*** liushuo_ has joined #openstack-keystone08:17
*** asettle has joined #openstack-keystone08:19
*** liushuobj__ has quit IRC08:20
asettleHey keystoners - I'm hoping to get some help getting through three patches for master, stein, and rocky  just to get some broken links fixed https://review.opendev.org/676906, https://review.opendev.org/676908, and https://review.opendev.org/67695508:20
asettleThey have three separate changes, so they're not backports.08:20
asettleWell, one is a backport of a completely different change08:20
*** tkajinam has quit IRC08:27
*** jawad_axd has joined #openstack-keystone08:29
openstackgerritVishakha Agarwal proposed openstack/keystone master: Remove system EC2 credentials from policy.v3cloudsample.json  https://review.opendev.org/68116208:40
openstackgerritzhouguowei proposed openstack/keystoneauth master: Add blueprints for the document  https://review.opendev.org/68140708:41
*** liushuobj__ has joined #openstack-keystone08:43
*** liushuo_ has quit IRC08:47
*** rcernin has joined #openstack-keystone09:10
*** rcernin has quit IRC09:41
*** liushuo_ has joined #openstack-keystone09:44
*** dancn has quit IRC09:45
*** liushuobj__ has quit IRC09:47
openstackgerritVishakha Agarwal proposed openstack/keystone master: Implement system reader & member for domain config API  https://review.opendev.org/67962310:17
openstackgerritVishakha Agarwal proposed openstack/keystone master: Implement system admin for domain config API  https://review.opendev.org/67975010:17
openstackgerritVishakha Agarwal proposed openstack/keystone master: Add Domain User for security compliance domain config API  https://review.opendev.org/67996610:17
openstackgerritVishakha Agarwal proposed openstack/keystone master: Add Project User coverage for domain config API  https://review.opendev.org/68034110:17
openstackgerritVishakha Agarwal proposed openstack/keystone master: Remove system Domain Config from policy.v3cloudsample.json  https://review.opendev.org/68035710:17
*** liushuobj__ has joined #openstack-keystone11:05
*** liushuo_ has quit IRC11:08
openstackgerritMerged openstack/keystone master: Fix timeout Zuul changes  https://review.opendev.org/68138011:29
*** raildo has joined #openstack-keystone11:44
*** spsurya has joined #openstack-keystone11:58
*** dave-mccowan has joined #openstack-keystone12:05
*** awalende has quit IRC12:22
*** awalende has joined #openstack-keystone12:23
*** jamesmcarthur has joined #openstack-keystone12:25
*** awalende has quit IRC12:27
*** jamesmcarthur has quit IRC12:30
*** etp has quit IRC12:31
*** awalende has joined #openstack-keystone12:34
*** awalende has quit IRC12:38
*** jmlowe has quit IRC12:42
*** dancn has joined #openstack-keystone12:45
*** jmlowe has joined #openstack-keystone12:59
*** jmlowe has quit IRC12:59
*** jmlowe has joined #openstack-keystone13:00
*** vishakha has quit IRC13:10
*** jaosorior has quit IRC13:26
lbragstadhttps://pasted.tech/pastes/b45c6b015b97c865018c4b3290f60e0456fe304a.raw is blowing my mind13:45
lbragstadfor some reason i get ^ locally with https://review.opendev.org/#/c/667730/13:45
lbragstadbut zuul doesn't seem to have issues with it13:45
*** redrobot has joined #openstack-keystone13:50
*** jawad_axd has quit IRC13:55
*** Luzi has quit IRC13:59
*** dancn has quit IRC14:18
lbragstadbah14:33
lbragstadhttps://opendev.org/openstack/keystone/src/branch/master/keystone/api/groups.py#L84 leads to https://opendev.org/openstack/keystone/src/branch/master/keystone/server/flask/common.py#L917-L94314:35
lbragstadand by default we short circuit14:35
lbragstadhttps://opendev.org/openstack/keystone/src/branch/master/keystone/server/flask/common.py#L924-L92614:35
lbragstadbut i have a local config that enabled domain_specific_drivers_enabled = True14:35
lbragstadso - if you set that option and then run those tests, they'll fail14:36
lbragstaddocumented all of ^ in https://review.opendev.org/#/c/645968/14:48
*** vishakha has joined #openstack-keystone14:59
*** spatel has joined #openstack-keystone15:01
*** jmlowe has quit IRC15:04
*** ayoung has quit IRC15:07
*** jamesmcarthur has joined #openstack-keystone15:08
*** jmlowe has joined #openstack-keystone15:09
cmurphylbragstad: aha15:10
cmurphyso the system role tests break when domain specific drivers are enabled because there's no domain in the token?15:10
*** ayoung has joined #openstack-keystone15:10
evrardjpo/15:11
lbragstadcmurphy i believe so15:12
lbragstadi just stumbled across it15:12
cmurphylbragstad: i think we should address that separately15:12
cmurphyand open a new bug for it15:12
lbragstadbut i think that method blows up with tokens that it can't find domains for (which makes sense because system doesn't belong under a domain)15:12
lbragstadok15:12
lbragstadso continue merging that series?15:13
cmurphylbragstad: i think so - it seems like domain specific drivers being broken with system scope is a separate issue?15:13
cmurphyor are we introducing a regression if we merge this?15:13
lbragstadwell - arguable the regression already existsed15:14
lbragstadyour work just highlighted the regression15:14
lbragstadIMO15:14
cmurphyokay15:14
lbragstadi would assume it was introduced when the system-scope work happened15:15
lbragstador was merged15:15
lbragstadwe could backport this15:15
vishakhao/15:16
cmurphy++15:16
cmurphyo/15:16
lbragstad(but that's probably a low priority since system-scoped tokens aren't used for anything in keystone's api)15:16
lbragstadprior to stein15:16
cmurphyoh i still need to address the duplicate test though15:18
cmurphythe matrix of tests needed for the grants api is ridiculously huge15:22
*** gyee has joined #openstack-keystone15:23
openstackgerritColleen Murphy proposed openstack/keystone master: Implement domain reader support for grants  https://review.opendev.org/64596815:24
openstackgerritColleen Murphy proposed openstack/keystone master: Implement domain admin support for grants  https://review.opendev.org/66773015:24
openstackgerritColleen Murphy proposed openstack/keystone master: Remove obsolete grant policies from policy.v3cloudsample.json  https://review.opendev.org/66773115:24
vishakhacmurphy: For EC2 credentials link# https://review.opendev.org/#/c/607820/ my project test cases are failing. I am trying to find the root cause.  Could it be possible to merge only for system users and update about the project users in the commit message ?15:24
cmurphyvishakha: hrm it seems kind of important to me that things like test_user_cannot_create_ec2_credentials_for_others works, if this test is causing project users to be able to delete other users' credentials that is a regression15:27
vishakhacmurphy: ok. Thanks.15:29
*** ivve has quit IRC15:29
*** ayoung has quit IRC15:43
*** jaosorior has joined #openstack-keystone15:44
kmalloco/15:45
cmurphyo/15:45
*** ayoung has joined #openstack-keystone15:45
openstackgerritColleen Murphy proposed openstack/keystone master: Implement system admin for implied roles  https://review.opendev.org/68079615:47
openstackgerritColleen Murphy proposed openstack/keystone master: Remove implied roles policies from v3cloudsample  https://review.opendev.org/68079715:47
kmalloclbragstad: immutable/resource options bits are all passing and needing some eyes (cc gagehugo, gyee) starting here https://review.opendev.org/#/c/678322/15:48
gagehugoo/15:48
gyeeyes sir15:52
lbragstadcmurphy done https://bugs.launchpad.net/keystone/+bug/184360916:01
openstackLaunchpad bug 1843609 in OpenStack Identity (keystone) "Domain-specific domain ID resolution breaks with system-scoped tokens" [High,Triaged]16:01
cmurphythanks lbragstad16:01
cmurphywe can try to address it before RC16:01
lbragstad++16:01
*** spatel has quit IRC16:01
*** spatel has joined #openstack-keystone16:02
*** spatel has quit IRC16:07
kmalloccmurphy: +2 on the doc changes except the one that needed commit cleanup (stable branches)16:09
cmurphyasettle: ^16:09
asettleThank you cmurphy :D16:10
asettleJust left it as a plain commit message16:11
cmurphythanks asettle16:12
*** jmlowe has quit IRC16:13
kmalloccmurphy: +2/+A (overrode your -1, commit message is fine now)16:16
cmurphyasettle: not to nitpick but you still could have mentioned in the commit message why it's not being cherry-picked, my comment was only about the reference to comments on the gerrit review16:17
cmurphykmalloc: that's fine16:17
asettlecmurphy, can do :)16:17
cmurphyasettle: not important at this point16:17
kmallocasettle: I'll re-+2/+A if you feel like updating again16:17
asettlecmurphy, I admittedly left it because of the comment history. But will keep in mind for future.16:17
kmallocbut it's really ok as is16:17
asettleIf you're both okay with it, I'm okay. I'll just be sure to remmeber it for future. In fairness, I just want these done... and in the way the projects want them done. So, i'm easy :)16:18
kmallocasettle: :)16:18
kmallocyeah don't worry about it16:18
*** liushuobj__ has quit IRC16:24
zanebhey folks! In Heat we're planning to allow users to specify domains for stuff we previously didn't have a way to specify the domain on by using syntax like <user>@<domain> https://review.opendev.org/66340416:28
zanebdoes that sound basically sane, or are there potential gotchas?16:29
cmurphyzaneb: one potential issue is that @ is a valid character for both a username or a domain name16:29
zanebis there another syntax that would be recommended instead?16:30
cmurphynot really, it would be better if you had some way to keep the fields separate16:31
cmurphywe had the same issue with puppet resources16:31
cmurphylet me look up what delimiter we ended up using16:31
zanebwe looked at adding properties to everything, but it was kind of intrusive and would behave weirdly in the case where you specified a UUID for the user16:32
zaneband still failed on stuff like parameter constraints16:32
zanebI think an @ in the domain shouldn't actually be an issue, because the patch splits on the first @16:33
zaneban @ in the username would be a big problem though16:33
cmurphywhat if you're using an email address as a username?16:33
cmurphylooks like we chose :: as the delimeter https://opendev.org/openstack/puppet-keystone/src/branch/master/examples/user_project_user_role_composite_namevar.pp#L11-L2516:35
zanebI guess we could try looking up the domain first, and if that fails fall back to just treating it as a username16:35
zanebcmurphy: thanks. that seems very... puppety... but it's worth considering16:36
cmurphylol16:36
cmurphytrying to look up the domain first seems like a good idea16:36
cmurphyany way to treat the fields as separate would be safest16:37
zanebcmurphy: do you have a convenient reference on which characters are and are not allowed? or does anything go and you just tried to pick something unlikely for puppet?16:37
cmurphyzaneb: there are no disallowed characters, we just chose :: in puppet because it seemed less likely to cause problems than @16:38
zanebok, makes sense16:38
zanebit does indeed seem very likely that there are people using email addresses as usernames in the wild since that's allowed16:38
cmurphyyep16:38
zanebI assume the same applies to group/role/project?16:39
cmurphyyes16:39
*** Ben78 has joined #openstack-keystone16:39
zanebcmurphy: cool, thanks for your help16:41
cmurphynp16:41
* zaneb will try to find a way to avoid disaster16:41
*** ivve has joined #openstack-keystone16:42
*** jaosorior has quit IRC16:46
*** ayoung has quit IRC16:51
*** ayoung has joined #openstack-keystone16:53
*** tesseract has quit IRC16:57
kmallocif there is more than one @, rsplit vs lsplit17:00
kmallocbut only if you explicitly define domain as required.17:01
kmallocbut because we weren't more opinionated...we are stuck17:02
kmallocyeah, don't assume @ is safe at all17:02
*** awalende has joined #openstack-keystone17:03
*** awalende has quit IRC17:07
*** ayoung has quit IRC17:14
zanebkmalloc: yeah, we're retrofitting it into existing properties so we can't require the domain either17:15
zanebI currently thinking of something like "user{domain}"17:16
zanebthat should be extraordinarily unlikely to occur by accident17:16
*** ayoung has joined #openstack-keystone17:17
kmallocsorry i can't be more help17:18
kmallocyeah {} is probably fine17:18
kmallocalternative options that are unlikely to occur normally are probably <>17:19
*** Ben78 has quit IRC17:32
*** spsurya has quit IRC17:32
*** jmlowe has joined #openstack-keystone17:36
*** ayoung has quit IRC17:39
*** ayoung has joined #openstack-keystone17:42
openstackgerritColleen Murphy proposed openstack/keystone master: Add immutable roles status check  https://review.opendev.org/67550918:04
cmurphygyee: ^18:04
*** jamesmcarthur has quit IRC18:06
*** jamesmcarthur has joined #openstack-keystone18:07
*** jamesmcarthur has quit IRC18:11
gyeelooking18:28
*** vishakha has quit IRC18:28
openstackgerritColleen Murphy proposed openstack/keystone master: Implement scope type checking for EC2 credentials  https://review.opendev.org/60782018:59
openstackgerritColleen Murphy proposed openstack/keystone master: Remove system EC2 credentials from policy.v3cloudsample.json  https://review.opendev.org/68116219:00
openstackgerritColleen Murphy proposed openstack/keystone master: Implement scope type checking for EC2 credentials  https://review.opendev.org/60782019:01
openstackgerritColleen Murphy proposed openstack/keystone master: Remove system EC2 credentials from policy.v3cloudsample.json  https://review.opendev.org/68116219:01
*** vishalmanchanda has quit IRC19:48
*** jamesmcarthur has joined #openstack-keystone20:06
*** ayoung has quit IRC20:24
*** ayoung has joined #openstack-keystone20:24
*** mvkr has quit IRC20:27
*** markvoelker has quit IRC20:27
*** mvkr has joined #openstack-keystone20:32
*** ayoung has quit IRC20:35
*** markvoelker has joined #openstack-keystone20:36
*** ayoung has joined #openstack-keystone20:38
*** markvoelker has quit IRC20:41
*** ivve has quit IRC21:05
*** ivve has joined #openstack-keystone21:05
*** Ben78 has joined #openstack-keystone21:13
*** rcernin has joined #openstack-keystone21:15
*** jamesmcarthur has quit IRC21:20
*** markvoelker has joined #openstack-keystone21:59
openstackgerritColleen Murphy proposed openstack/keystone master: Increase tox job timeouts to 90 minutes  https://review.opendev.org/68162122:25
cmurphysadness ^22:25
*** threestrands has joined #openstack-keystone22:37
gagehugo:(22:44
*** raildo has quit IRC22:49
*** Ben78 has quit IRC22:50
*** dtruong has quit IRC22:55
*** dtruong has joined #openstack-keystone22:55
*** tkajinam has joined #openstack-keystone23:04
*** jamesmcarthur has joined #openstack-keystone23:32
*** jamesmcarthur has quit IRC23:46
*** jamesmcarthur has joined #openstack-keystone23:46
*** jamesmcarthur has quit IRC23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!