Tuesday, 2019-08-06

*** jamesmcarthur has quit IRC00:09
*** jamesmcarthur has joined #openstack-keystone00:16
*** gyee has quit IRC00:19
kmalloccmurphy: i think you're going to have the same issue w/ filtering on that one00:21
kmalloccmurphy: really, the best bet is a toggle to just disable it, batched is going to still be rough unless we can be sure we've already warned at some point and just avoid warning again.00:22
*** jamesmcarthur has quit IRC00:38
openstackgerritzhufl proposed openstack/keystone master: Fix missing print format and missing ws between words  https://review.opendev.org/67452100:41
*** markvoelker has joined #openstack-keystone00:41
*** markvoelker has quit IRC00:51
*** markvoelker has joined #openstack-keystone01:17
*** spsurya has joined #openstack-keystone01:17
*** altlogbot_3 has quit IRC01:37
*** altlogbot_0 has joined #openstack-keystone01:38
*** markvoelker has quit IRC01:38
*** jamesmcarthur has joined #openstack-keystone01:44
*** jamesmcarthur has quit IRC01:49
*** jamesmcarthur has joined #openstack-keystone02:18
*** markvoelker has joined #openstack-keystone02:42
*** jamesmcarthur has quit IRC02:53
*** jamesmcarthur has joined #openstack-keystone02:54
*** jamesmcarthur has quit IRC02:59
*** jamesmcarthur has joined #openstack-keystone03:04
*** whoami-rajat has joined #openstack-keystone03:07
*** markvoelker has quit IRC03:15
*** jamesmcarthur has quit IRC03:17
openstackgerritAdrian Turjak proposed openstack/keystone master: Add support for previous TOTP windows  https://review.opendev.org/64765503:19
adriantkmalloc: ^ as discussed, max is 10, default is 1, and it has tests now03:22
adriantnot sure if I need to use the timefixture there, but I am using freezegun to make my passcodes in the past03:22
*** jamesmcarthur has joined #openstack-keystone03:40
cmurphykmalloc: not sure why there would be the same issue with filtering, isn't the inefficiency due to the number of warnings being emitted that need to be scanned and filtered? if there was just one warning for every 50 we have now wouldn't that be more efficient?03:57
openstackgerritChason Chan proposed openstack/keystone master: Specify keystone is OS user for fernet and credential setup  https://review.opendev.org/67472504:05
kmalloccmurphy: it is stilla ton of notifications04:21
kmalloccmurphy: honestly i think we're still going to cause CI pressure in unfun ways.04:22
kmallocannnnd IRCCloud is broken on my phone =/04:33
*** jamesmcarthur has quit IRC04:40
*** jhesketh has joined #openstack-keystone04:54
*** jamesmcarthur has joined #openstack-keystone05:09
openstackgerritAdrian Turjak proposed openstack/keystone-specs master: Reparent Projects  https://review.opendev.org/61814405:10
*** jamesmcarthur has quit IRC05:15
adriantkmalloc, cmurphy: ^ cleaned up that spec to get the discussion going. I still stand by "No real security impact." and that this is very much a needed feature if we actually want people using sub-projects.05:18
adriantand that the supposed security impacts are just features of how project trees and assignments work.05:18
openstackgerritAdrian Turjak proposed openstack/keystone-specs master: Reparent Projects  https://review.opendev.org/61814405:25
*** markvoelker has joined #openstack-keystone05:28
*** markvoelker has quit IRC05:33
*** tkajinam has quit IRC05:38
*** tkajinam has joined #openstack-keystone05:38
kmallocadriant: I am still not happy with an API that does this. But whatever. I feel like it isn’t worth arguing against.05:42
adriantkmalloc: I understand why, but at the same time I think that it's not something we can live without if we want people to use project trees. Otherwise projects are immutable.05:44
adriantWhich we know isn't the case05:44
kmallocI do not agree with the no security impact05:44
adriantI know :P05:45
kmallocThere is inherently concerns and anyone doing this must be aware of the potential new access or removed access if roles are inherited.05:45
kmallocYou will also need to deal with all app creds for the project when it happens05:45
kmallocAnd revalidate access or revoke all of them.05:46
kmallocAnd trusts05:46
adriantDon't app creds and trusts change based on the role assignments?05:46
kmallocApp creds might revalidate them but no they don’t auto change05:46
kmallocLive-validate*05:47
kmallocBut, please be 100% sure05:47
adriantThat's why I'm leaning towards option 2 the NEW api05:48
adriantwith a GET that returns the full impact of the reparenting05:48
kmallocIirc we explicitly invalidate app creds when a role changes.05:48
adriantand a post to do it05:48
kmallocEh, probably a post to validate/check impact and a patch to relate to05:48
kmallocEasier to send a body than an ugly get url ;)05:49
kmallocPatch to reparent*05:49
adriantpost to me implies a creation to me, so get with an optional param felt like a safer bet05:49
adriantunless we actually want to track the 're-parent action' and then confirm it05:50
kmallocEh. But patch is update of resource05:50
* adriant isn't fussed too muct05:50
kmallocI’d do reparent/project_id body {new-parent}05:50
kmallocBut really05:51
kmallocThis is bike shedding05:51
adriantmuch*05:51
adriantyeah05:51
adriantI just want a way to audit the change, and a way to do it05:51
kmallocPropose it, I won’t block it. I’m done with fighting this battle. If it is needed and cores beside me sign off on it, so be it05:51
adriantand that satisfies that we have done all we can to limit a loss of a metaphorical toe05:51
kmallocAnd then I’ll review the code as I would any other approved spec’s code.05:52
adriantI wish we didn't need this feature, but it's one that keeps coming up. :(05:53
*** jamesmcarthur has joined #openstack-keystone06:11
*** jamesmcarthur has quit IRC06:16
*** joshualyle has joined #openstack-keystone06:28
*** vishalmanchanda has joined #openstack-keystone06:36
*** markvoelker has joined #openstack-keystone06:36
*** jamesmcarthur has joined #openstack-keystone06:46
*** jamesmcarthur has quit IRC06:51
*** xek has joined #openstack-keystone07:00
*** jamesmcarthur has joined #openstack-keystone07:00
*** xek has quit IRC07:03
*** jamesmcarthur has quit IRC07:05
*** markvoelker has quit IRC07:09
*** tesseract has joined #openstack-keystone07:30
*** jaosorior has quit IRC07:34
*** jamesmcarthur has joined #openstack-keystone07:39
*** jamesmcarthur has quit IRC07:43
*** rcernin has quit IRC08:04
*** xek has joined #openstack-keystone08:06
*** tkajinam has quit IRC08:06
*** jamesmcarthur has joined #openstack-keystone08:08
*** jamesmcarthur has quit IRC08:12
*** jamesmcarthur has joined #openstack-keystone08:14
*** jamesmcarthur has quit IRC08:20
*** jaosorior has joined #openstack-keystone08:35
*** jaosorior has quit IRC08:37
*** jaosorior has joined #openstack-keystone08:41
*** jamesmcarthur has joined #openstack-keystone08:44
*** jamesmcarthur has quit IRC09:18
*** shyamb has joined #openstack-keystone09:22
*** dancn has joined #openstack-keystone09:44
*** jamesmcarthur has joined #openstack-keystone09:55
*** jamesmcarthur has quit IRC09:59
*** shyamb has quit IRC10:19
*** shyamb has joined #openstack-keystone10:50
*** jamesmcarthur has joined #openstack-keystone10:55
*** jamesmcarthur has quit IRC11:00
*** jaosorior has quit IRC11:02
*** shyamb has quit IRC11:12
*** shyam89 has joined #openstack-keystone11:12
*** shyamb has joined #openstack-keystone11:17
*** shyam89 has quit IRC11:17
*** ivve has joined #openstack-keystone11:22
*** jaosorior has joined #openstack-keystone11:31
*** jamesmcarthur has joined #openstack-keystone11:31
*** jamesmcarthur has quit IRC11:35
openstackgerritRadosław Piliszek proposed openstack/keystone master: Honor group_members_are_ids for user_enabled_emulation  https://review.opendev.org/67478211:35
*** jamesmcarthur has joined #openstack-keystone11:35
* yoctozepto is to be contacted about ^11:41
yoctozeptohappy to learn writing unit tests in here11:42
*** markvoelker has joined #openstack-keystone12:04
*** markvoelker has quit IRC12:06
*** markvoelker has joined #openstack-keystone12:06
*** shyamb has quit IRC12:10
*** shyamb has joined #openstack-keystone12:11
*** jamesmcarthur has quit IRC12:20
*** mvkr has quit IRC12:21
*** shyamb has quit IRC12:27
*** mvkr has joined #openstack-keystone13:11
*** jamesmcarthur has joined #openstack-keystone13:17
*** kplant has joined #openstack-keystone13:47
knikollao/13:50
cmurphyo/13:52
gagehugoo/14:09
*** altlogbot_0 has quit IRC14:12
*** altlogbot_0 has joined #openstack-keystone14:14
*** joshualyle has quit IRC14:20
*** Ben78 has joined #openstack-keystone15:19
*** hoonetorg has quit IRC15:24
*** hoonetorg has joined #openstack-keystone15:25
openstackgerritKristi Nikolla proposed openstack/keystone master: Add federated support for get user  https://review.opendev.org/44873015:27
*** gyee has joined #openstack-keystone15:29
cmurphyteam meeting in 20 minutes in #openstack-meeting-alt15:40
openstackgerritMerged openstack/oslo.policy master: Add attribute to suppress deprecation warnings  https://review.opendev.org/67393215:40
bnemecI assume you would like ^ released ASAP.15:42
cmurphybnemec: that would be wonderful15:43
openstackgerritKristi Nikolla proposed openstack/keystone master: Add federated support for get user  https://review.opendev.org/44873015:43
knikollaoops, wrong rebase.15:46
*** ivve has quit IRC15:46
openstackgerritKristi Nikolla proposed openstack/keystone master: Add federated support for get user  https://review.opendev.org/44873015:50
*** xek has quit IRC15:54
*** dancn has quit IRC15:57
cmurphyany last minute topics to add to the agenda?15:59
cmurphymeeting now in #openstack-meeting-alt16:03
*** mvkr has quit IRC16:20
*** jamesmcarthur has quit IRC16:31
*** markvoelker has quit IRC16:32
*** markvoelker has joined #openstack-keystone16:44
*** Ben78 has quit IRC16:46
openstackgerritColleen Murphy proposed openstack/keystone master: Allows to use application credentials through group membership  https://review.opendev.org/65516616:54
*** spsurya has quit IRC17:52
openstackgerritMerged openstack/keystone master: Fix websso auth loop  https://review.opendev.org/67412218:22
*** tesseract has quit IRC18:52
*** xek has joined #openstack-keystone18:57
*** jamesmcarthur has joined #openstack-keystone18:57
*** jamesmcarthur has quit IRC19:08
*** ivve has joined #openstack-keystone19:32
*** mloza has joined #openstack-keystone19:41
*** mloza is now known as atmark19:41
kplantshould i be concerned that shibboleth is generating metadata with redirect URIs that are not correct? for instance: http://sp.keystone.example.org:5000/Shibboleth.sso/SAML2/POST19:43
*** jamesmcarthur has joined #openstack-keystone19:44
cmurphykplant: how are you querying the metadata?19:47
kplantcurl -s http://sp.keystone.example.org:5000/Shibboleth.sso/Metadata19:50
cmurphythe url in the metadata is based on how you queried it19:52
cmurphyif shibboleth is accessible from port 5000 and you used port 5000 to query the metadata then that's how it will show up19:53
cmurphyso it's not incorrect if that's how you want your browser to access it19:53
kplantoh yeah, i did notice that. i meant more specifically the path, where it's actually redirecting is: http://sp.keystone.example.org:5000/v3/auth/OS-FEDERATION/identity_providers/keycloak/protocols/saml2/websso?origin=http://sp.keystone.example.org/auth/websso/19:54
kplantand the idp isn't happy with the redirect uri not matching what's in the metadata19:54
*** jamesmcarthur has quit IRC19:54
kplantactually if i manually add 'http://sp.keystone.example.org:5000/Shibboleth.sso/SLO/Redirect' as a valid redirect URI that seems to clear it up19:57
cmurphythose urls have totally different purposes19:57
cmurphyShibboleth.sso/SAML2/POST is for the idp to submit the saml response, /v3/auth/OS-FEDERATION/blabla is the auth endpoint in keystone19:57
kplantyeah i was incorrect in where i thought it was redirecting19:58
kplanti added '*' as a valid redirect uri and i traced too far19:58
kplantlooks like it was redirecting to 'http://sp.keystone.example.org:5000/Shibboleth.sso/SLO/Redirect'19:58
kplantor not, i'm getting invalid redirect uri again20:00
kplanti tried doing a samltrace to find where it's trying to redirect, any idea where i could find that out?20:01
cmurphysamltrace is where i would have started, not sure off the top of my head what would be using the HTTP-Redirect url20:03
kplantmind if i paste what i changed in the configs to try to get this working?20:05
cmurphysure20:05
kplanthttp://paste.openstack.org/show/755584/20:05
cmurphykplant: you probably want <Location /Shibboleth.sso> to be outside the *:5000 vhost and accessible just from port 8020:07
cmurphyit's possible that might be related to the weird redirects20:08
kplantif i did that i'd have to put it in the horizon container20:08
kplanthorizon listens on :80 on this guy20:08
cmurphyit will still work with horizon, horizon doesn't pay attention to /Shibboleth.sso20:08
kplanti can definitely try that, just to add some more data... if i add '*' as a valid uri then the redirect does work20:10
kplantbut then i'm met with: a 401 http://paste.openstack.org/show/755584/20:10
kplanterr, wrong paste20:10
kplant"the request you have made requires authentication."20:10
cmurphywhere are you putting '*' ?20:10
kplantjust so it allows any uri and completes the redirect20:11
kplantif i do that it makes its way back to keystone20:11
cmurphyi mean where in the config20:12
kplantoh, sorry20:12
kplanti read "where" as "why"20:12
kplantin the IdP (keycloak)20:12
kplantthere's a list of "Valid Redirect URIs"20:12
*** jamesmcarthur has joined #openstack-keystone20:14
cmurphyin keycloak?20:15
kplantyes20:15
*** jamesmcarthur has quit IRC20:15
cmurphyokay i'm not familiar with keycloak20:15
cmurphybut what you can do is turn on insecure_debug=true in keystone.conf20:16
cmurphyand then that will tell you exactly why you're getting a 40120:16
kplantis thaty under [DEFAULT] ?20:16
cmurphywhich is probably that the url is going to is wrong20:16
cmurphyyes20:16
kplantawesome20:16
kplanti'll do that20:16
kplant"Could not map user while setting ephemeral user identity. Either mapping rules must specify user id/name or REMOTE_USER environment variable must be set. (Disable insecure_debug mode to suppress these details.)" <-- that's a much better error message20:17
kplantthank you!20:17
cmurphy:)20:17
*** jamesmcarthur has joined #openstack-keystone20:17
*** jamesmcarthur has quit IRC20:19
*** jamesmcarthur has joined #openstack-keystone20:25
*** dancn has joined #openstack-keystone20:28
kplantfigured out the redirect uri issue, it was redirecting to the ip instead of the fqdn. hah20:46
kplantshould have thought of that20:46
*** whoami-rajat has quit IRC20:56
*** kplant has quit IRC21:02
*** xek has quit IRC21:11
openstackgerritAdrian Turjak proposed openstack/keystone master: Add support for previous TOTP windows  https://review.opendev.org/64765521:21
adriantcmurphy: ty for explicit deadline!21:26
cmurphyadriant: yw ;)21:26
adriantI'm reading through the Keystoneauth code and figuring out how to do what I need to do...21:26
openstackgerritColleen Murphy proposed openstack/keystone master: Fix list_mappings deprecation warning message  https://review.opendev.org/67493421:27
adriantthe problem is I need to make a 'multi-method' auth module, but that may either mean implementing a sub-module for each method, or... rewriting the existing modules to be able to be used together21:27
adriantsince I think the existing code is focused heavily on 1 module 1 auth method per request21:28
adriantthat's to allow MFA in one hit. So maybe that's for another time21:28
adriantmaybe for now I just make the auth modules all be able to take an auth receipt21:29
cmurphyi would use kmalloc or mordred as a rubberduck for that one21:29
adriantI'll dig through the code and see what my options are21:29
adriantand ping kmalloc and mordred once I have some ideas :)21:30
openstackgerritColleen Murphy proposed openstack/keystone master: Clean up irrelevant comment  https://review.opendev.org/67493521:32
*** markvoelker has quit IRC21:38
*** jamesmcarthur has quit IRC21:39
openstackgerritColleen Murphy proposed openstack/keystone master: Make policy deprecation reasons less verbose  https://review.opendev.org/67494021:49
*** raildo has quit IRC21:57
*** dancn has quit IRC22:18
*** jamesmcarthur has joined #openstack-keystone22:20
kmallocadriant: i am fine with supporting multi-module where it crafts the json post like we would expect22:37
kmallocadriant: the one-module one auth is mostly historical "no one needed this before"22:37
adriantkmalloc: mostly it's a question of how much I can get away with changing while still maintaining backward compatibility22:49
*** tkajinam has joined #openstack-keystone22:51
adriantkmalloc: Ideally what I'd like to see is that the existing modules work as expected, but their internals change to be built off a new module class that can be given to a multi-method module22:52
adriantMultiMethodAuth(methods=[PasswordAuth(...), TOTPAuth(...)])22:53
adriant^ something like that22:53
adriantbut... I'll wait till I've read through the full code path, and all the variants and made some notes before I actually propose something22:54
adriantWhat I expect the work to be is22:55
adriant1. add a new exception type for AuthReceipts22:55
adriant2. add a means to ANY existing single auth method to supply with it an auth receipt (likely in some base class)22:55
adriant3. add multimethod support so we can auth in one go22:55
kmalloci think you should just modify the interface so that it works as does today, but also accepts a list/tuple/iterable of methods and builds the JSON as expected to auth23:10
kmallocthe exception handling for authreceipts is 100% new code and behavior you'd expect to grow as it's a new exception type23:11
kmallocin the case of an authreceipt, new base-class (ABCMeta?) param for instantiating the auth method plugin that contains optional auth receipt23:12
kmallocor a new method that adds in the auth receipt data to the baseclass plugin23:12
kmalloci think that covers our "don't break anyone" and adds the new functionality23:13
kmallocwe can emit a warning (eventually) that a list-form of methods is always preferred23:13
*** markvoelker has joined #openstack-keystone23:13
kmalloceven if we never remove the ability to pass a single auth plugin23:13
kmallocalternative is a way to just "add" a secondary plugin, and authreceipt is setup as a plugin23:13
kmallocso primary is used then .add_auth_method_pluigin(authReceipt(receipt_data=xXXXXXX))23:14
kmallocand you can add N plugins this way, JSON is built as expected for auth23:14
kmallocadriant: ^23:14
adriantyeah, that sounds right :)23:15
kmallocthe latter option i outlined would be the lowest barrier to entry as no downstream auth plugins should need modification23:16
kmallocto accept even an optional new param23:16
adriantyeah add_auth_method_plugin could be a good option23:17
kmallocadriant: i trust your choice on approach in this manner. don't break people using KSA, and make the interface easy to use.23:17
adriantthat's the goal23:17
kmalloci think i like .add_auth_method the best.23:18
*** markvoelker has quit IRC23:18
kmallocthe more i think about it23:18
kmallocwe should bounce this off mordred too (tomorrow probably, i think he is some timezone that means he's mostly done for the day)23:18
adriantkmalloc: what about the loader layer? I remember reading through some of that code ages ago. Doesn't that help things like the CLI build auth method requirements?23:19
kmallocwe provide new mechanisms to add in the new auth data needed23:20
kmallocif the CLI and other loader things do not grow to accept this, they will not work with MFA23:20
kmallocand auth receipts23:20
kmallocyou'll need to fix those consumers where possible23:20
adriantand they do need to23:20
adriantyep, that's the plan23:20
adriantat least for the OSC23:20
kmallocwhere not possible, the new exception is fine.23:20
adriant(i won't touch any of the standalone CLIs)23:20
kmallocmake sure SDK handles this before osc, imo23:21
kmallocorder: KSA functionality + testing, SDK consume it + testing, osc consume it + testing23:21
adriantthen finally horizon23:21
adriantyep23:21
kmallocyup23:21
adriantthat's the total roadmap for this feature, with KSA being targeted for train, and then the rest afterwards23:22
kmallochorizon can be done concurrent with OSC or before SDK tbh23:22
kmallocbut i'd prob still do SDK before OSC or horizon23:22
adriantthe U cycle can be the cycle where OS now finally supports MFA in all places that matter :P23:22
adriantI'll probably do all three concurrently23:23
adriantthe worry with the CLI is the need to keep doing auth every command, so some better way of saving the token into an envvar or something would be good23:23
adriantwhich is how I do it for us currently: https://github.com/catalyst-cloud/adjutant-mfa/blob/master/horizon-plugin/adjutant_mfa_ui/mfa/templates/mfa/openrc_v3_mfa.sh.template23:24
adriant^ I fetch a token, then clear the password and such from the envvars23:25
adriantand set the auth type to token23:25
*** rcernin has joined #openstack-keystone23:26
cmurphyschedule is out https://www.openstack.org/summit/shanghai-2019/summit-schedule23:29
*** jamesmcarthur has quit IRC23:42
mordredkmalloc, adriant: I will read and digest the scrollback in the morning23:44
mordredah. MFA. yeah - ksa support23:45
mordred:)23:45
mordredbut I'll read in the morning23:45
adriantmordred: Then SDK, then OSC, then Horizon, and In Adjutant I'll add to core APIs for managing a users own MFA rules, and a horizon panel for!23:46
*** joshualyle has joined #openstack-keystone23:47
*** jamesmcarthur has joined #openstack-keystone23:47
*** joshualyle has quit IRC23:51
*** joshualyle has joined #openstack-keystone23:53
*** jamesmcarthur_ has joined #openstack-keystone23:54
*** jamesmcarthur has quit IRC23:54
*** joshualyle has quit IRC23:55
*** joshualyle has joined #openstack-keystone23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!