| kmalloc | knikolla: nvm, found it | 00:00 |
|---|---|---|
| *** dklyle has quit IRC | 00:20 | |
| *** lbragstad has joined #openstack-keystone | 00:28 | |
| *** ChanServ sets mode: +o lbragstad | 00:28 | |
| kmalloc | knikolla: i need to check the header format from the webob request object | 00:28 |
| kmalloc | knikolla: so i can properly extend the flask header(s) | 00:28 |
| *** Nel1x has joined #openstack-keystone | 00:31 | |
| *** gyee has quit IRC | 00:39 | |
| openstackgerrit | Merged openstack/keystone master: Convert services api to flask native dispatching https://review.openstack.org/589641 | 01:01 |
| lbragstad | kmalloc: qq | 01:08 |
| kmalloc | lbragstad: qa | 01:08 |
| lbragstad | the json home document for policies is missing the resource relations for /policies | 01:09 |
| lbragstad | i must be doing something wrong in https://review.openstack.org/#/c/589950/2/keystone/api/policy.py@39 | 01:09 |
| kmalloc | in your implementation or in general? | 01:09 |
| lbragstad | the OS-ENDPOINT-POLICY relations look to be ok | 01:10 |
| kmalloc | looking | 01:10 |
| lbragstad | for example there is no https://docs.openstack.org/api/openstack-identity/3/rel/policies key in the actual response | 01:10 |
| lbragstad | (but there is in the reference) | 01:11 |
| kmalloc | hm. | 01:11 |
| lbragstad | so when i ported policies to flask, i must have missed something that builds that for the /v3/policies key | 01:11 |
| kmalloc | that is the current patch? | 01:11 |
| lbragstad | no - but the handful of changes that i have locally aren't related to that | 01:12 |
| lbragstad | or to json jome | 01:12 |
| lbragstad | home* | 01:12 |
| kmalloc | ah, ok well first AssertionError: View function mapping is overwriting an existing endpoint function: policy.policyresource | 01:12 |
| kmalloc | View function mapping is overwriting an existing endpoint function: policy.policyresource | 01:12 |
| kmalloc | }}} <-- error that is because you can't use a resource twice | 01:12 |
| lbragstad | note that https://review.openstack.org/#/c/589950/2/keystone/api/policy.py@31 appears to be working fine | 01:12 |
| lbragstad | yeah - i already fixed that bit | 01:12 |
| kmalloc | sec. let me do one thing | 01:13 |
| kmalloc | hm. weird. | 01:13 |
| kmalloc | because Adding standard routes to API policy for `MethodViewType` (API Prefix: ) [/policies, /policies/<string:policy_id>] | 01:14 |
| kmalloc | should add json_home bits | 01:14 |
| lbragstad | i had to add _api_url_prefix = '/policies' to fix the policy.policyresource error you just pasted | 01:14 |
| lbragstad | in the PolicyAPI class | 01:15 |
| kmalloc | you're going to have an issue then, since /policies will prefix and you'll have /policies/policies | 01:15 |
| lbragstad | i removed the /policies/ from the other paths | 01:15 |
| kmalloc | but we automatically construct for Resources | 01:16 |
| kmalloc | which includes the collection_kehy | 01:16 |
| kmalloc | key* | 01:16 |
| kmalloc | you might want to add the changes from https://review.openstack.org/#/c/591082/9/keystone/tests/unit/test_versions.py | 01:16 |
| kmalloc | they make debugging json_home issues a lot easier | 01:16 |
| kmalloc | so, if you want to use a prefix, you'll need to do a resource_mapping for the main resource as well [totally fine] | 01:17 |
| lbragstad | nice | 01:17 |
| lbragstad | diffing that error is a pain | 01:17 |
| lbragstad | let me try that quick | 01:17 |
| kmalloc | yeah $%!@ diffing the errors. | 01:17 |
| kmalloc | if you push the latest code up, i can cherry-pick it and look at it | 01:18 |
| kmalloc | it's a little frustrating/fragile when porting, but pretty bomb proof once you get it down. | 01:18 |
| kmalloc | anyway i need to go eat. | 01:19 |
| lbragstad | ack | 01:19 |
| kmalloc | will check back in in a bit. remember, you can have multiple api classes (look at federation) | 01:20 |
| kmalloc | if it helps | 01:20 |
| kmalloc | lbragstad: https://git.openstack.org/cgit/openstack/keystone/tree/keystone/api/os_federation.py?h=refs/changes/82/591082/9#n559 | 01:21 |
| lbragstad | ok | 01:21 |
| lbragstad | thanks | 01:21 |
| kmalloc | also note if you do that the _additional_parameters parts | 01:21 |
| kmalloc | needed to construct json_home sanely | 01:21 |
| kmalloc | if you want to use that you'll need to rebase on top of OS-FEDERATION | 01:21 |
| kmalloc | some other fixes were rolled in (such as the regex/sub of <> to {} | 01:22 |
| kmalloc | for the whole url, not just the post-prefix parts | 01:22 |
| kmalloc | so 591082 is safe to rebase on, might make it easier for you too since you can just delete EP-Polidy routers | 01:23 |
| kmalloc | since by that point endpoints is already ported | 01:23 |
| *** dave-mccowan has quit IRC | 02:19 | |
| *** openstack has joined #openstack-keystone | 02:33 | |
| *** ChanServ sets mode: +o openstack | 02:33 | |
| *** Nel1x has quit IRC | 03:11 | |
| openstackgerrit | Merged openstack/keystone master: Convert endpoints api to flask native dispatching https://review.openstack.org/589642 | 03:41 |
| *** ayoung has quit IRC | 03:44 | |
| *** orange_julius has quit IRC | 04:40 | |
| *** pcaruana has joined #openstack-keystone | 05:12 | |
| openstackgerrit | wangqiang-bj proposed openstack/keystone master: modify json file relative path in 'application-credentials' https://review.openstack.org/591909 | 06:20 |
| *** jaosorior has joined #openstack-keystone | 06:25 | |
| openstackgerrit | wangqiang-bj proposed openstack/keystone master: fix wrong relative path in 'application-credentials.inc' https://review.openstack.org/591919 | 06:35 |
| *** jaosorior has quit IRC | 06:40 | |
| openstackgerrit | wangqiang-bj proposed openstack/keystone master: fix wrong relative path in 'inherit.inc' https://review.openstack.org/591922 | 06:44 |
| openstackgerrit | wangqiang-bj proposed openstack/keystone master: fix wrong relative path in 'os-pki.inc' https://review.openstack.org/591924 | 06:49 |
| openstackgerrit | wangqiang-bj proposed openstack/keystone master: fix wrong relative path in 'inherit.inc' https://review.openstack.org/591926 | 06:55 |
| openstackgerrit | Andriy Shevchenko proposed openstack/ldappool master: fix tox python3 overrides https://review.openstack.org/591927 | 06:55 |
| *** s10 has joined #openstack-keystone | 07:11 | |
| *** jaosorior has joined #openstack-keystone | 07:15 | |
| *** s10 has quit IRC | 07:22 | |
| openstackgerrit | Shuo Liu proposed openstack/keystoneauth master: add release notes to readme.rst https://review.openstack.org/591943 | 07:48 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Fix db model inconsistency for FederatedUser https://review.openstack.org/566242 | 07:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Enable Foreign keys for sql backend unit test https://review.openstack.org/558029 | 07:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Enable foreign keys for unit test https://review.openstack.org/558193 | 07:51 |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: ADD a test for idp and federated user cascade deleting https://review.openstack.org/591946 | 07:51 |
| openstackgerrit | Shuo Liu proposed openstack/keystonemiddleware master: add releasenotes to readme.rst https://review.openstack.org/591947 | 07:52 |
| *** lbragstad has quit IRC | 07:54 | |
| *** rha has quit IRC | 08:34 | |
| *** josecastroleon has quit IRC | 09:00 | |
| *** josecastroleon has joined #openstack-keystone | 09:00 | |
| *** samueldmq_ has joined #openstack-keystone | 09:16 | |
| *** andreaf has quit IRC | 09:16 | |
| *** andreaf has joined #openstack-keystone | 09:17 | |
| *** bzhao__ has quit IRC | 09:18 | |
| *** samueldmq has quit IRC | 09:18 | |
| *** samueldmq_ is now known as samueldmq | 09:18 | |
| *** josecastroleon has quit IRC | 10:09 | |
| openstackgerrit | Merged openstack/oslo.limit master: fix doc gate https://review.openstack.org/591162 | 10:41 |
| openstackgerrit | Merged openstack/oslo.limit master: import zuul job settings from project-config https://review.openstack.org/588697 | 10:41 |
| *** s10 has joined #openstack-keystone | 10:41 | |
| openstackgerrit | Merged openstack/oslo.limit master: add python 3.6 unit test job https://review.openstack.org/589599 | 10:45 |
| *** raildo has joined #openstack-keystone | 11:59 | |
| *** josecastroleon has joined #openstack-keystone | 12:00 | |
| knikolla | o/ | 12:34 |
| *** josecastroleon has quit IRC | 12:54 | |
| *** josecastroleon has joined #openstack-keystone | 12:54 | |
| *** mvkr has quit IRC | 13:10 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Convert policy API to flask https://review.openstack.org/589950 | 13:16 |
| *** dklyle has joined #openstack-keystone | 13:31 | |
| *** orange_julius has joined #openstack-keystone | 13:38 | |
| *** mvkr has joined #openstack-keystone | 13:40 | |
| *** david-lyle has joined #openstack-keystone | 13:48 | |
| *** dklyle has quit IRC | 13:49 | |
| *** david-lyle has quit IRC | 13:49 | |
| *** david-lyle has joined #openstack-keystone | 13:49 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Convert policy API to flask https://review.openstack.org/589950 | 14:31 |
| *** _ix has joined #openstack-keystone | 14:33 | |
| gagehugo | o/ | 14:44 |
| *** d0ugal has joined #openstack-keystone | 14:59 | |
| *** david-lyle is now known as dklyle | 15:01 | |
| *** gyee has joined #openstack-keystone | 15:32 | |
| *** fiddletwix has quit IRC | 15:41 | |
| *** mvkr has quit IRC | 15:46 | |
| *** itlinux has joined #openstack-keystone | 15:52 | |
| *** FracKen has joined #openstack-keystone | 15:56 | |
| *** ayoung has joined #openstack-keystone | 16:15 | |
| *** sayalilunkad has quit IRC | 16:16 | |
| *** sayalilunkad has joined #openstack-keystone | 16:20 | |
| *** sayalilunkad has quit IRC | 16:32 | |
| *** sayalilunkad has joined #openstack-keystone | 16:47 | |
| *** sayalilunkad has quit IRC | 16:51 | |
| *** sayalilunkad has joined #openstack-keystone | 16:52 | |
| *** openstackstatus has joined #openstack-keystone | 16:57 | |
| *** ChanServ sets mode: +v openstackstatus | 16:57 | |
| *** sayalilunkad has quit IRC | 17:09 | |
| *** mbuil has quit IRC | 17:10 | |
| *** s10 has quit IRC | 17:11 | |
| *** gyee has quit IRC | 17:54 | |
| *** mvkr has joined #openstack-keystone | 17:56 | |
| openstackgerrit | Michael Beaver proposed openstack/oslo.policy master: WIP Docs: Remove references to JSON format https://review.openstack.org/592170 | 18:21 |
| _ix | I think I've gotten the most mileage out of asking questions in here. No good deed goes unpunished ;) | 18:25 |
| _ix | Is there a specific channel for tempest questions? | 18:26 |
| ayoung | _ix, qa used to be it | 18:28 |
| ayoung | try /join #openstack-qa | 18:28 |
| _ix | Thanks, ayoung! | 18:29 |
| ayoung | _ix, tell them kmalloc sent you | 18:30 |
| *** Dano8080 has joined #openstack-keystone | 19:09 | |
| *** openstackgerrit has quit IRC | 19:19 | |
| kmalloc | lol | 19:28 |
| *** openstackgerrit has joined #openstack-keystone | 19:53 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert policy API to flask https://review.openstack.org/589950 | 19:53 |
| openstackgerrit | Merged openstack/ldappool master: fix ldappool bad password retry logic https://review.openstack.org/591174 | 20:01 |
| Dano8080 | Hi. Does anyone know if there's a way to have keystone include the elapsed time in the log message for a request? Or some other way to capture the elapsed time for a request? | 20:01 |
| *** raildo has quit IRC | 20:42 | |
| kmalloc | Dano8080: there are two ways, but they are chatty/can slow things down. | 20:53 |
| kmalloc | Dano8080: there is the debug middleware (just per request data) | 20:53 |
| kmalloc | And there is the trace log level (logs a TON of data about each manager call/time in the DB, etc) | 20:54 |
| kmalloc | My guess is you want the debug middleware | 20:54 |
| openstackgerrit | Michael Beaver proposed openstack/oslo.policy master: Docs: Remove references to JSON format https://review.openstack.org/592170 | 20:55 |
| *** ayoung has quit IRC | 21:19 | |
| *** rcernin has joined #openstack-keystone | 21:29 | |
| Dano8080 | kmalloc: Thanks. I will investigate those methods | 21:32 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 22:14 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Refactor ProviderAPIs object to better design pattern https://review.openstack.org/571955 | 22:15 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism https://review.openstack.org/591146 | 22:15 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching https://review.openstack.org/591147 | 22:15 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix a translation of log https://review.openstack.org/591164 | 22:15 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching https://review.openstack.org/591165 | 22:15 |
| kmalloc | knikolla: ^ ok i *think* i've solved all the issues with OS-FEDERATION port | 22:16 |
| kmalloc | going to see what zuul has to say, but it should be ready now. | 22:16 |
| *** FracKen has left #openstack-keystone | 22:21 | |
| *** itlinux has quit IRC | 22:22 | |
| *** d0ugal has quit IRC | 22:33 | |
| *** imacdonn has quit IRC | 22:38 | |
| *** imacdonn has joined #openstack-keystone | 22:38 | |
| *** d0ugal has joined #openstack-keystone | 22:44 | |
| kmalloc | knikolla: yep, passes functional test now. phew | 22:45 |
| *** d0ugal has quit IRC | 23:01 | |
| *** _ix has quit IRC | 23:01 | |
| *** d0ugal has joined #openstack-keystone | 23:03 | |
| kmalloc | knikolla: further along, there is another os-federation issue cropping up, but we're good for reviews up until OS-FEDERATION patch and maybe one after | 23:07 |
| *** rcernin has quit IRC | 23:18 | |
| *** rcernin has joined #openstack-keystone | 23:19 | |
| *** d0ugal has quit IRC | 23:42 | |
| *** d0ugal has joined #openstack-keystone | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!