Tuesday, 2018-07-03

*** threestrands_ has joined #openstack-keystone00:07
*** threestrands_ has quit IRC00:07
*** threestrands_ has joined #openstack-keystone00:07
*** threestrands_ has quit IRC00:08
*** threestrands_ has joined #openstack-keystone00:09
*** threestrands_ has quit IRC00:09
*** threestrands_ has joined #openstack-keystone00:09
*** threestrands has quit IRC00:10
*** threestrands_ has quit IRC00:10
*** threestrands_ has joined #openstack-keystone00:10
*** threestrands_ has quit IRC00:11
*** threestrands_ has joined #openstack-keystone00:12
*** threestrands_ has quit IRC00:13
*** threestrands_ has joined #openstack-keystone00:13
*** threestrands_ has quit IRC00:13
*** threestrands_ has joined #openstack-keystone00:13
*** threestrands_ has quit IRC00:14
*** threestrands_ has joined #openstack-keystone00:15
*** threestrands_ has quit IRC00:15
*** threestrands_ has joined #openstack-keystone00:15
*** threestrands_ has quit IRC00:16
*** threestrands_ has joined #openstack-keystone00:16
*** edmondsw has joined #openstack-keystone00:23
*** edmondsw has quit IRC00:28
openstackgerritMerged openstack/oslo.policy master: Fix requirements and convert to stestr  https://review.openstack.org/57916900:33
*** blake has quit IRC00:48
*** blake has joined #openstack-keystone00:49
*** blake has quit IRC00:53
*** dklyle has quit IRC00:55
*** blake has joined #openstack-keystone01:13
*** masber has joined #openstack-keystone01:13
*** blake has quit IRC01:14
*** blake has joined #openstack-keystone01:16
*** blake has quit IRC01:17
openstackgerritwangxiyuan proposed openstack/keystone master: Add auto increase primary key for unified limit  https://review.openstack.org/57602501:30
*** tonytan4ever has joined #openstack-keystone01:35
*** tonytan4ever_brb has quit IRC01:38
*** annp has joined #openstack-keystone01:52
*** blake has joined #openstack-keystone01:55
*** blake has quit IRC01:55
*** mylu has quit IRC01:57
*** tonytan4ever has quit IRC01:57
*** tonytan4ever has joined #openstack-keystone01:57
*** mylu has joined #openstack-keystone02:21
*** tonytan4ever_brb has joined #openstack-keystone02:39
*** tonytan4ever has quit IRC02:41
*** tonytan4ever_brb has quit IRC02:41
*** tonytan4ever has joined #openstack-keystone02:42
*** mylu has quit IRC02:43
*** felipemonteiro has joined #openstack-keystone02:50
*** felipemonteiro has quit IRC02:58
openstackgerritMorgan Fainberg proposed openstack/keystone master: Add support for enforce_call to set value on flask.g  https://review.openstack.org/57818903:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Address minor comments from initial impl RBACEnforcer  https://review.openstack.org/57934203:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Flesh out and add testing for flask_RESTful scaffolding  https://review.openstack.org/57819003:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Move keystone.server.common to keystone.server  https://review.openstack.org/57974603:10
kmalloclbragstad: ^ sorry for another huge change (mostly tests)03:11
*** felipemonteiro has joined #openstack-keystone03:30
*** felipemonteiro has quit IRC03:38
*** tonytan4ever_brb has joined #openstack-keystone04:14
*** tonytan4_ has joined #openstack-keystone04:15
*** tonytan4ever_brb has quit IRC04:15
*** tonytan4ever has quit IRC04:16
*** vigneshwar has joined #openstack-keystone04:24
vigneshwarhello..04:24
vigneshwarhow a system can automatically revoke the keys when it is compromised ?04:24
*** threestrands_ has quit IRC04:25
*** tonytan4_ has quit IRC04:56
*** tonytan4ever has joined #openstack-keystone04:57
*** tonytan4ever has quit IRC05:01
*** tonytan4ever has joined #openstack-keystone05:31
*** vishakha has quit IRC05:39
*** edmondsw has joined #openstack-keystone05:48
*** vishakha has joined #openstack-keystone05:51
*** edmondsw has quit IRC05:53
*** vigneshwar has quit IRC06:10
*** felipemonteiro has joined #openstack-keystone06:19
*** nicolasbock has joined #openstack-keystone06:42
*** gongysh has joined #openstack-keystone06:43
*** openstackgerrit has quit IRC06:49
*** felipemonteiro has quit IRC06:49
*** rcernin has quit IRC06:55
*** martinus__ has joined #openstack-keystone06:59
*** tesseract has joined #openstack-keystone07:06
*** sonuk has joined #openstack-keystone07:07
*** sonuk_ has quit IRC07:09
*** ispp has joined #openstack-keystone07:15
*** josecastroleon has joined #openstack-keystone07:18
*** amoralej|off is now known as amoralej07:19
*** vishakha has quit IRC07:21
*** peereb has joined #openstack-keystone07:21
*** ispp has quit IRC07:27
*** openstackgerrit has joined #openstack-keystone07:29
openstackgerritNguyen Hung Phuong proposed openstack/keystone-specs master: fix tox python3 overrides  https://review.openstack.org/57979107:29
*** vishakha has joined #openstack-keystone07:33
*** vigneshwar has joined #openstack-keystone07:36
*** edmondsw has joined #openstack-keystone07:36
*** edmondsw has quit IRC07:41
*** ispp has joined #openstack-keystone07:42
*** cz2 has quit IRC08:14
*** cz2 has joined #openstack-keystone08:16
*** mvk has quit IRC08:28
*** vigneshwar has quit IRC08:33
*** mvk has joined #openstack-keystone08:55
*** gongysh has quit IRC09:03
*** sonuk_ has joined #openstack-keystone09:04
*** sonuk has quit IRC09:08
*** edmondsw has joined #openstack-keystone09:25
*** edmondsw has quit IRC09:29
*** aloga has joined #openstack-keystone09:32
*** aloga has quit IRC09:46
*** nicolasbock has quit IRC09:55
*** gongysh has joined #openstack-keystone09:56
*** chrome0 has quit IRC10:18
openstackgerritMerged openstack/oslo.policy master: Pass dictionary as creds in policy tests  https://review.openstack.org/57899410:25
*** mvk has quit IRC10:35
*** gongysh has quit IRC11:24
*** aojea_ has joined #openstack-keystone11:37
*** alee has joined #openstack-keystone11:43
*** mvk has joined #openstack-keystone11:45
aleehey - anyone around that can help me with a devstack install on centos 7 -- I get an error about Unable to find 'uuid' driver in 'keystone.token.provider' when trying to bootstrap keystone11:46
*** amoralej is now known as amoralej|lunch11:46
aleehow do I just tell devstack to use fernet tokens?11:46
aleelbragstad, ^^ ?11:46
aleeah -- nm - bad setting in loacl,conf11:49
*** mchlumsky has joined #openstack-keystone11:57
*** voelzmo has joined #openstack-keystone11:59
*** aojea_ has quit IRC12:00
*** chrome0 has joined #openstack-keystone12:00
*** mchlumsky has quit IRC12:10
*** raildo has joined #openstack-keystone12:10
*** mchlumsky has joined #openstack-keystone12:11
*** aojea has joined #openstack-keystone12:32
fricklerwould it make sense to remove the v2 parts from paste.ini here by default? http://git.openstack.org/cgit/openstack/keystone/tree/etc/keystone-paste.ini#n8612:34
fricklerseems like that may be confusing for deployers12:35
fricklercurrently they are only dropped in devstack: http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/keystone#n21712:35
fricklerI could also see some value in dropping the admin endpoint completely12:36
*** rmascena has joined #openstack-keystone12:51
*** raildo has quit IRC12:51
*** edmondsw has joined #openstack-keystone13:01
*** ispp has quit IRC13:02
*** ispp has joined #openstack-keystone13:06
*** aojea has quit IRC13:06
*** edmondsw has quit IRC13:06
knikollao/13:10
*** rmascena__ has joined #openstack-keystone13:17
*** rmascena has quit IRC13:20
*** amoralej|lunch is now known as amoralej13:25
lbragstadalee: yep - i think you can tell devstack to override keystone's default, but the default token provider is fernet13:40
lbragstadfrickler: yeah - we considered doing that this release13:41
lbragstadi want to say kmalloc had a patch for it some where?13:41
aleelbragstad, yeah - I had overridden to uuid by mistake13:41
lbragstadaha13:41
fricklerlbragstad: oh, there's https://review.openstack.org/#/c/571979/6/etc/keystone-paste.ini , I was looking at an older checkout. so I think you are fine, just might want to amend the devstack code accordingly13:46
*** jmlowe has quit IRC13:51
lbragstadfrickler: i'm looking now, but does that cleanup need to happen in lib/keystone?13:52
kmalloclbragstad: hmm?13:55
kmallocfrickler: in this release paste-ini is gone13:56
kmalloclbragstad: ^ that already merged.13:56
kmallocwell, paste-ini is there, but it is no longer used at all13:57
lbragstadyeah13:57
kmallocfrickler: https://github.com/openstack/keystone/blob/master/etc/keystone-paste.ini#L1-L513:57
kmallocwe can fix devstack to not care about paste-ini for keystone too.13:58
kmalloci have not spun up a patch for that.13:58
kmalloclbragstad: sorry about the giant flask-restful testing patch.13:59
kmalloclbragstad: but we have full testing of flask bits now.14:00
kmalloclbragstad: but at this point i feel confident i can start converting APIs to flask.14:02
kmalloc(our testing will need a lot of cleanup too, but that can be done independantly)14:02
*** s10 has joined #openstack-keystone14:04
lbragstadawesome14:04
lbragstadi'll trade you some flask reviews for unified limit reviews :)14:04
kmallocyep14:07
kmalloci think we can land the flask stuff now, the only functionality impacting change is the json_home move to flask14:07
kmallocwhich was needed as the first step14:07
kmallocanyway, i'm drinking coffee and heat pad on shoulder, can review in a moment14:08
kmalloc(unified limits)14:08
s10http://lists.openstack.org/pipermail/openstack-dev/2018-May/130415.html — Hello. Will this issue be fixed until rocky release? This is an annoying blocker for the process of upgrading our clouds and some components to queens. We fixed it with reverting commit, but I'm not sure, that this is correct way to solve this issue.14:08
kmallocbut i think limits is mostly ready14:08
kmallocs10: i am reading that email. it's super long14:10
kmallocs10: iirc the keystoneauth bit was already fixed.14:10
fricklerkmalloc: yes, would be great if you could amend devstack to not deploy the paste file if it is not needed anymore. better testing and also folks use devstack as reference for other deployment methods14:11
kmallocs10: trying to remember what the result of the server side discussion was14:11
lbragstads10: i thought mordred had a patch for that14:11
kmalloclbragstad: ksa for sure.14:11
kmalloclbragstad: i think server was... maybe "doing an ok thing" when we talked about it.14:11
kmalloci'll try and refresh my memory here.14:11
kmallocfrickler: sure. yeah, we only kept the paste-ini in keystone's sdist so we didn't break triple-o for example.14:12
kmallocfrickler: i'll see about getting a fix to devstack here14:12
mordredwhat did I do?14:14
kmallocmordred: nothing, mostly me sucking at vacation ;)14:14
kmallocmordred: was the long email of doom regarding catalog and ksa and internal interfaces14:14
kmallocmordred: we fixed ksa iirc14:14
mordredcool. I'll go with that14:15
kmallocfrickler: https://review.openstack.org/#/c/579882/14:17
kmallocfrickler: don't know if it will work, but that is an initial stab at it.14:17
fricklerkmalloc: great, I'll be watching the results, thanks14:18
*** tonytan4ever has quit IRC14:18
s10lbragstad, kmalloc: keystoneauth wasn't fixed, I don't see anything in https://review.openstack.org/#/q/project:openstack/keystoneauth relevant to this issue14:18
*** jmlowe has joined #openstack-keystone14:18
kmallocfrickler: if it doesn't work let me know, or feel free to help fix the issues. i have zero issue with someone picking up and helping on a patch.14:19
kmallocs10: i was almost certain we did something about that.14:19
kmallocs10: aha, ok, so i've been rooting around in this code. when the value of public_endpoint is set in keystone.conf it overrides a lot of stuff14:22
kmallocs10: server side, keystone makes a best effort to know what the requesting URL is but for reasons (x-forwarded-for, etc) it doesn't always work.14:23
kmallocin most cases public_endpoint is not needed for keystone, but we also have eliminated the distinction between admin and public endpoints [they are the same wsgi app now, I get there is reason to have internal still though]14:24
*** rmascena__ has quit IRC14:24
cmurphyI think this is the relevant bug (still open) https://bugs.launchpad.net/keystoneauth/+bug/173305214:24
openstackLaunchpad bug 1733052 in keystoneauth "Usage of internal URL in clouds.yaml causes a 404" [Undecided,Confirmed]14:24
kmalloccmurphy: yep, i think that is the bug14:25
kmallocthe bulk of the issue is ksa14:25
*** wxy| has joined #openstack-keystone14:25
kmallocbut the "server bug" mordred was referencing is in-fact by design when using "public-endpoint"14:25
kmalloci think the only solution is to run a separate keystone process (same database) with a different "public_endpoint" value if the value must be set (discovery doc)14:26
kmallocthe WSGI environment doesn't contain all the knowledge we need to build the "what host did this client request via" all the time.14:26
mordredor to use relative paths and not full urls in the discovery doc14:27
kmallocmordred: unfortunately, that is an API Breaking Change(tm)14:27
mordred"/v3" is valid for the urls14:27
mordredkmalloc: it is? ksa completely supports it as a data value14:27
kmallocmordred: since behavior. - i'm happy to make that change.14:27
kmallocbut, would need signoff that we are allowed to break the behavior and implied current contract.14:27
kmallocin the discovery doc*14:28
kmallocserver side14:28
kmallocif the discovery doc behaves a certain way right now, it's a breaking change to change the data coming out :P14:28
kmalloclike i said, 100% ok changing it with the correct "yes, please do it" [I assume TC?]14:29
*** mvk has quit IRC14:29
kmalloci think it would be a good change (FTR) to use relative paths.14:30
kmalloci just don't want to run afoul of our API contracts (implied or explicit)14:30
*** raildo has joined #openstack-keystone14:30
lbragstadin case anyone is interested - https://review.openstack.org/#/c/579690/3 should enable some testing jobs for the oslo.limit library14:32
kmalloclbragstad: do you want to add keystone-core to oslo-limit?14:35
kmalloclbragstad: or are we already?14:35
kmallocnot related to the infra bits there, obviously14:35
*** aojea_ has joined #openstack-keystone14:39
*** kashyap has joined #openstack-keystone14:42
*** jmlowe has quit IRC14:43
kashyapHi folks, wonder if anyone has clues as to what this error could mean:14:43
kashyap2018-06-28 12:25:06.394 [./foobar.neutron-all/var/log/neutron/server.log-20180629] 1167 WARNING keystonemiddleware.auth_token [req-eac3ef0c-e50c-4f60-b895-fbea11ba6a39 afda1fc4262a4dc09190ce0c17e314bc b9d43f27231e4f3a9456f225f8b2c2e7 - - -] Identity response: {"error": {"message": "Could not find token: c779675e926a41f1b62184b15d63e0f5", "code": 404, "title": "Not Found"}}14:43
* kashyap should probably ask in a different forum, as this is a devel channel14:44
lbragstadkmalloc: that's already been done https://review.openstack.org/#/admin/groups/1885,members14:44
* kashyap wonders if "Could not find token" implies it is a time out error14:44
lbragstadi set that up with bnemec when we created the library, is it showing up properly for you?14:44
*** aojea_ has quit IRC14:45
openstackgerritMerged openstack/oslo.limit master: Convert tox.ini to using stestr  https://review.openstack.org/57968514:45
lbragstadkashyap: that means the token is either invalid or expired14:45
*** jmlowe has joined #openstack-keystone14:45
lbragstadyou should try reauthenticating for a new token14:46
kashyaplbragstad: Hmm, it is the one hour keystone token timeout, is it?14:46
lbragstadkashyap: that's configurable so it depends on your deployment14:46
lbragstadthe default is 1 hour though14:46
kashyaplbragstad: Yeah, saw it in the code - the 1 hr14:46
kashyaplbragstad: In what kinds of deployments people extend the time timeout?14:47
lbragstadi'm not quite sure, i would think most people don't extend it14:47
lbragstadwe don't recommend extending the token expiration time14:47
kashyaplbragstad: Nod; thanks for the explanation.14:47
kashyapWas debugging a random Nova bug report that trickled down to the above error14:48
lbragstadi believe you can configure services to validate tokens that are expired - if you're having issues with long running operations14:48
lbragstad(e.g. backups in cinder or uploading images in glance)14:49
kmallocs10: so, yes, we should fix KSA in Rocky, and if possible backport to Queens [it's a bug]. Keystone server is a bit harder to fix.14:49
kashyaplbragstad: Yeah, good guess -- it is a long-running operation, a live migration.14:49
kmallockashyap: yeah, we have a way [i don't know how well uspoorted it is14:50
kmallocto validate a token and ignore the expiration for just such a case14:50
cmurphyit is supported14:50
cmurphythis is what service tokens are for14:50
kashyapOh, interesting14:50
lbragstadkashyap: https://github.com/openstack/keystone/blob/e3d5da0f77e81542bb581936457929253e676508/keystone/conf/token.py#L11914:50
kmallocright, but is there something the service needs to do / be configred to do?14:50
* kashyap clicks14:50
*** edmondsw has joined #openstack-keystone14:51
kmalloccmurphy: ^ e.g. does Cinder need to know how to do that.14:51
kashyapcmurphy: Where can I read a bit more about service tokens?14:51
cmurphyhttps://specs.openstack.org/openstack/keystone-specs/specs/keystonemiddleware/implemented/service-tokens.html14:51
kmallocaha14:51
kmallocperfect14:51
cmurphywe don't see to have actual docs lol14:51
cmurphyseem*14:51
lbragstadallow_expired_window is the keystone configuration option, but it has a reasonable default already (2 days)14:51
kmalloclbragstad: right.14:52
kmalloccmurphy: phsaw, who needs docs! :P14:52
lbragstadjamielennox: did some work to incorporate that into keystonemiddleware14:52
kmalloclbragstad: +2 on the migrations for limits14:52
cmurphythe best docs are in the release notes https://docs.openstack.org/releasenotes/keystonemiddleware/ocata.html14:52
kmalloclbragstad: looking at the rest of the stack now14:53
s10kmalloc: should we write this resolution about bug fix and backport somewhere, so it will not be forgotten?14:53
kashyapcmurphy: Ah, thanks; /me clicks14:53
kmallocs10: we have the bug that cmurphy linked: https://bugs.launchpad.net/keystoneauth/+bug/1733052 can you confirm that is accurate?14:53
openstackLaunchpad bug 1733052 in keystoneauth "Usage of internal URL in clouds.yaml causes a 404" [Undecided,Confirmed]14:54
*** BlackDex has quit IRC14:54
kmallocs10: if so, we can prioritize it and get some eyes on it from the keystone team.14:54
kmallocs10: if that is the same bug, it looks like it.14:54
*** mvk has joined #openstack-keystone14:55
s10kmalloc: yes, this is a same bug14:55
kmallocs10: ah i see your comments there.14:55
*** edmondsw has quit IRC14:55
kmalloccool14:55
kmalloclbragstad: ^ that bug i've moved to "high" prio, we should get it fixed for rocky.14:56
kmalloclbragstad: and probably backport the fix to queens.14:56
kashyaplbragstad: Yeah, two days default is plenty14:57
kashyaplbragstad: But that config attribute is not _enabled_ by default, is it?14:58
kashyap(No, it isn't.)14:59
lbragstadkashyap: the two day time is the default15:00
kmalloclbragstad: the service needs to pass ?allow_expired=True when validating15:00
kmallochttps://github.com/openstack/keystone/blob/ccda249e4cb628a0fb8fd7832679a07732a3af3b/keystone/common/authorization.py#L8415:01
kmallocso...15:01
lbragstadaha - correct15:01
kmallocso, does cinder, nova, etc do that?15:01
lbragstadit's opt in, but it is enabled by default15:01
kmallocexactly. this may be a case of "we have the support" and the services just don't do it15:01
kashyapHow can "opt in" but "enabled by default" be true at the same time?15:01
* kashyap re-reads to ensure he isn't misreading15:01
kmallockeystone supports it by default15:02
kmallocturned on15:02
lbragstadkashyap: keystone server supports validating expired tokens from service users if and only if the call is made with allow_expired=True15:02
kmallocservices must opt into validating with expiration allowed15:02
lbragstadbut just because we turn it on doesn't mean other services are using it yet15:02
kashyaplbragstad: Ah, that sentence is much clearer15:03
*** peereb has quit IRC15:05
*** gyee has joined #openstack-keystone15:05
lbragstadkashyap: trying to not get into the weeds too much15:06
kashyapNod; thanks.15:06
lbragstadbut it looks like ksm determines whether or not it should set that by https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L39815:07
*** voelzmo has quit IRC15:07
lbragstadhttps://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L368-L37715:07
* kashyap clicks15:07
lbragstadwhich you should be able to tinker with through keystonemiddleware configuration https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_opts.py#L202-L21515:08
lbragstadso - i guess to enable that feature, you need to specify which roles are "service user roles"15:08
lbragstadwhich will be in your service configuration file in the [keystone_authtoken] section15:09
*** felipemonteiro_ has joined #openstack-keystone15:09
*** felipemonteiro__ has joined #openstack-keystone15:10
*** felipemonteiro_ has quit IRC15:14
*** felipemonteiro has joined #openstack-keystone15:16
*** s10 has quit IRC15:17
lbragstadthen you'll need to make sure the nova service user has that role assignment15:17
* lbragstad should probably write this stuff down15:18
lbragstadkashyap: https://bugs.launchpad.net/keystone/+bug/177988915:24
openstackLaunchpad bug 1779889 in OpenStack Identity (keystone) "Lack of documentation for validating expired tokens with service users" [Medium,Triaged]15:24
openstackgerritKristi Nikolla proposed openstack/keystone master: Added keystone identity provider installation to Devstack plugin  https://review.openstack.org/48412115:34
*** dklyle has joined #openstack-keystone15:41
*** nicolasbock has joined #openstack-keystone15:52
kmalloclbragstad: meeting today or cancelled?15:58
lbragstadit's still on15:59
kmallocok15:59
ayoungkmalloc, what room again?16:04
kmalloc-alt16:04
kmalloc#openstack-meeting-alt16:04
*** felipemonteiro__ has quit IRC16:11
*** felipemonteiro has quit IRC16:18
*** tesseract has quit IRC16:20
openstackgerritMerged openstack/keystone master: Add auto increase primary key for unified limit  https://review.openstack.org/57602516:22
*** ispp has quit IRC16:26
*** aojea has joined #openstack-keystone16:27
openstackgerritwangxiyuan proposed openstack/keystone master: Add registered_limit_id column for limit  https://review.openstack.org/57775116:28
*** aojea has quit IRC16:32
*** wxy| has quit IRC16:38
*** wxy| has joined #openstack-keystone16:39
*** amoralej is now known as amoralej|off16:45
openstackgerritwangxiyuan proposed openstack/keystone master: Delete project limits when deleting project  https://review.openstack.org/53837117:01
lbragstad#startmeeting keystone-office-hours17:01
openstackMeeting started Tue Jul  3 17:01:56 2018 UTC and is due to finish in 60 minutes.  The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot.17:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.17:01
*** openstack changes topic to " (Meeting topic: keystone-office-hours)"17:02
*** ChanServ changes topic to "Rocky release schedule: https://releases.openstack.org/rocky/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/wmyzbFq5/keystone-rocky-roadmap !!NOTE!! This Channel is Logged ( https://tinyurl.com/OpenStackKeystone )"17:02
openstackThe meeting name has been set to 'keystone_office_hours'17:02
*** wxy| has quit IRC17:06
openstackgerritMorgan Fainberg proposed openstack/keystone master: Make keystone.server.flask more interesting for importing  https://review.openstack.org/57992817:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix keystone.common.rbac_enforcer.__init__.py expoorting  https://review.openstack.org/57993017:14
*** felipemonteiro has joined #openstack-keystone17:17
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix keystone.common.rbac_enforcer.__init__.py exporting  https://review.openstack.org/57993017:19
*** felipemonteiro_ has joined #openstack-keystone17:21
*** felipemonteiro__ has joined #openstack-keystone17:23
*** felipemonteiro_ has quit IRC17:27
*** BlackDex has joined #openstack-keystone17:29
*** dklyle has quit IRC17:53
*** edmondsw has joined #openstack-keystone18:27
*** edmondsw has quit IRC18:32
*** pcichy has quit IRC18:46
*** pcichy has joined #openstack-keystone18:49
*** itlinux has joined #openstack-keystone18:50
*** felipemonteiro has quit IRC18:51
*** felipemonteiro__ has quit IRC19:06
*** felipemonteiro__ has joined #openstack-keystone19:06
*** dgonzalez has quit IRC19:14
*** dgonzalez has joined #openstack-keystone19:16
*** dgonzalez has quit IRC19:21
*** dgonzalez has joined #openstack-keystone19:26
*** felipemonteiro_ has joined #openstack-keystone19:31
*** felipemonteiro__ has quit IRC19:34
*** felipemonteiro_ has quit IRC19:37
*** felipemonteiro_ has joined #openstack-keystone19:37
*** felipemonteiro_ has quit IRC20:08
*** pcichy has quit IRC20:10
lbragstadkmalloc: i worked my way through all flask patches i think20:15
*** edmondsw has joined #openstack-keystone20:16
*** felipemonteiro has joined #openstack-keystone20:17
*** aojea has joined #openstack-keystone20:21
*** edmondsw has quit IRC20:21
*** jmlowe has quit IRC20:26
kmalloclbragstad: responded to comments20:42
kmalloclbragstad: specificall the one you -1'd. That is just a double down on policy-in-code20:42
kmalloclbragstad: if a rule isn't defined, we are locked down, it's a safety concern within keystone.20:42
kmallocfor security projects (we are one), default closed, open where needed20:43
lbragstadi agree about the concern, more or less questioning the backwards compatibility bit?20:43
kmalloci don't think it's backwards incompat20:43
kmallocthere is zero reason we have un-accounted for rules with policy-in-code20:43
kmallocor if we do, we should know about it fast20:43
kmallocif we want to reference an action, ensure it is registered20:45
kmallocprior to policy-in-code, the "default open" or "Default closed" was a more reasonable thing to reference20:45
*** felipemonteiro has quit IRC20:45
kmallocsince the definition of the policy itself was in the policy.json20:46
kmallocso, there was a high likelihood of a non-existant action20:46
kmallocwith policy-in-code it is impossible (short of a programming error) for a non-existent action20:46
kmalloc(an operator can no longer remove an action from policy.json causing a fallback to the default rule)20:47
*** felipemonteiro has joined #openstack-keystone20:53
*** raildo has quit IRC20:54
openstackgerritMorgan Fainberg proposed openstack/keystone master: Do not use flask.g imported as g  https://review.openstack.org/57998520:55
kmalloclbragstad, knikolla, wxy: ^20:59
*** felipemonteiro has quit IRC21:02
*** aojea has quit IRC21:10
openstackgerritLance Bragstad proposed openstack/oslo.policy master: Teach Enforcer.enforce to deal with context objects  https://review.openstack.org/57899521:11
*** martinus__ has quit IRC21:27
cmurphywow this mfa stuff is just completely undocumented http://git.openstack.org/cgit/openstack/keystone/tree/keystone/identity/backends/resource_options.py#n8521:38
cmurphyyou have to hunt through the code to find out it's there21:39
lbragstadyeah - outside of the original patch, i'm not sure the docs were ever amended https://review.openstack.org/#/c/274901/21:44
*** felipemonteiro has joined #openstack-keystone21:55
*** nicolasbock has quit IRC22:00
*** lbragstad is now known as lbragstad_50322:02
*** edmondsw has joined #openstack-keystone22:05
*** rcernin has joined #openstack-keystone22:09
*** edmondsw has quit IRC22:09
*** felipemonteiro has quit IRC22:20
*** dtruong has quit IRC22:30
*** jmlowe has joined #openstack-keystone22:36
*** rcernin has quit IRC22:49
*** rcernin has joined #openstack-keystone23:02
*** felipemonteiro has joined #openstack-keystone23:20
*** rcernin_ has joined #openstack-keystone23:23
*** rcernin has quit IRC23:24
*** felipemonteiro has quit IRC23:31
adriantcmurphy: nope, not at all. It doesn't exists outside of the circle of people who know it from the code :P23:32
adriantWhich honestly is a good thing until we get the auth receipts done, because using it as is was messy anyway23:33
*** felipemonteiro has joined #openstack-keystone23:36
*** felipemonteiro has quit IRC23:49
*** edmondsw has joined #openstack-keystone23:53
*** felipemonteiro has joined #openstack-keystone23:56
*** edmondsw has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!