Tuesday, 2018-02-27

*** AlexeyAbashkin has joined #openstack-keystone00:07
*** mvk has quit IRC00:08
*** mvk has joined #openstack-keystone00:11
*** AlexeyAbashkin has quit IRC00:11
*** lbragstad has joined #openstack-keystone00:30
*** ChanServ sets mode: +o lbragstad00:30
*** jmlowe has joined #openstack-keystone00:36
*** annp has quit IRC00:56
*** lbragstad has quit IRC01:00
*** threestrands has joined #openstack-keystone01:01
*** threestrands has quit IRC01:02
*** threestrands has joined #openstack-keystone01:02
*** oikiki has quit IRC01:04
*** oikiki has joined #openstack-keystone01:05
*** markvoelker has quit IRC01:12
*** dave-mccowan has quit IRC01:13
*** Anticime1 is now known as Anticimex01:14
*** namnh has joined #openstack-keystone01:16
*** itlinux has joined #openstack-keystone01:24
*** threestrands has quit IRC01:28
*** rcernin has quit IRC01:46
*** rcernin has joined #openstack-keystone01:47
*** oikiki has quit IRC01:49
*** oikiki has joined #openstack-keystone01:50
*** jmlowe has quit IRC01:52
*** edmondsw has joined #openstack-keystone01:55
*** annp has joined #openstack-keystone01:56
*** jmlowe has joined #openstack-keystone01:57
*** markvoelker has joined #openstack-keystone01:58
*** edmondsw has quit IRC02:00
*** markvoelker has quit IRC02:03
*** dave-mccowan has joined #openstack-keystone02:04
*** AlexeyAbashkin has joined #openstack-keystone02:07
*** AlexeyAbashkin has quit IRC02:11
*** jmlowe has quit IRC02:11
*** oikiki has quit IRC02:16
*** oikiki has joined #openstack-keystone02:19
*** oikiki has quit IRC02:45
*** oikiki has joined #openstack-keystone02:46
*** r-daneel has joined #openstack-keystone02:50
*** markvoelker has joined #openstack-keystone02:52
openstackgerritwangqi proposed openstack/keystoneauth master: fix minor typos in tox_install.sh  https://review.openstack.org/54812802:54
*** oikiki has quit IRC03:01
*** mvk has quit IRC03:04
*** r-daneel has quit IRC03:08
*** r-daneel has joined #openstack-keystone03:08
*** links has joined #openstack-keystone03:25
*** markvoelker has quit IRC03:27
*** edmondsw has joined #openstack-keystone03:43
*** edmondsw has quit IRC03:47
*** nicolasbock has quit IRC04:23
*** markvoelker has joined #openstack-keystone04:44
*** dave-mccowan has quit IRC05:04
*** markvoelker has quit IRC05:18
openstackgerritmelissaml proposed openstack/oslo.policy master: Update the invalid url for page  https://review.openstack.org/54814805:23
*** edmondsw has joined #openstack-keystone05:31
*** r-daneel has quit IRC05:32
*** edmondsw has quit IRC05:36
*** markvoelker has joined #openstack-keystone06:35
*** masuberu has quit IRC06:47
*** masber has joined #openstack-keystone07:08
*** markvoelker has quit IRC07:08
*** edmondsw has joined #openstack-keystone07:19
*** edmondsw has quit IRC07:24
*** pcaruana has joined #openstack-keystone07:30
*** martinus__ has joined #openstack-keystone07:39
*** masber has quit IRC07:39
*** AlexeyAbashkin has joined #openstack-keystone07:43
*** masber has joined #openstack-keystone07:52
*** namnh_ has joined #openstack-keystone08:01
*** namnh has quit IRC08:05
*** tesseract has joined #openstack-keystone08:14
*** namnh has joined #openstack-keystone08:22
*** rcernin has quit IRC08:23
*** namnh_ has quit IRC08:24
*** wangqiangbj_ has quit IRC08:27
*** markvoelker has joined #openstack-keystone08:27
*** markvoelker_ has joined #openstack-keystone08:29
*** markvoelker has quit IRC08:33
*** david-lyle has quit IRC08:36
*** david-lyle has joined #openstack-keystone08:36
*** jaosorior has joined #openstack-keystone08:37
*** lbragstad has joined #openstack-keystone08:54
*** ChanServ sets mode: +o lbragstad08:54
*** masber has quit IRC09:00
*** raildo has joined #openstack-keystone09:02
*** edmondsw has joined #openstack-keystone09:08
*** lbragstad_ has joined #openstack-keystone09:09
*** lbragstad has quit IRC09:10
*** r-daneel has joined #openstack-keystone09:10
*** jgr has joined #openstack-keystone09:11
*** edmondsw has quit IRC09:12
*** zhurong has joined #openstack-keystone09:14
*** masber has joined #openstack-keystone09:14
*** d0ugal has joined #openstack-keystone09:32
*** namnh_ has joined #openstack-keystone09:46
*** raildo has quit IRC09:46
*** namnh has quit IRC09:49
*** raildo has joined #openstack-keystone09:54
*** d0ugal has quit IRC10:00
*** jaosorior has quit IRC10:01
openstackgerritGage Hugo proposed openstack/keystone master: Add functional testing gate  https://review.openstack.org/53101410:07
*** namnh has joined #openstack-keystone10:15
*** namnh_ has quit IRC10:17
*** szaher_ has joined #openstack-keystone10:18
-openstackstatus- NOTICE: gerrit is being restarted due to extreme slowness10:22
*** d0ugal has joined #openstack-keystone10:27
*** david-lyle has quit IRC10:40
*** raildo has quit IRC10:42
*** d0ugal has quit IRC10:44
openstackgerritGage Hugo proposed openstack/keystone master: Add functional testing gate  https://review.openstack.org/53101410:52
*** r-daneel has quit IRC10:55
*** david-lyle has joined #openstack-keystone10:55
*** edmondsw has joined #openstack-keystone10:56
*** edmondsw has quit IRC11:00
*** AlexeyAbashkin has quit IRC11:04
*** namnh has quit IRC11:06
*** aloga has quit IRC11:10
*** aloga has joined #openstack-keystone11:10
*** aloga has quit IRC11:10
*** aloga has joined #openstack-keystone11:11
*** annp has quit IRC11:12
*** aloga has quit IRC11:14
*** aloga has joined #openstack-keystone11:15
*** links has quit IRC11:15
*** AlexeyAbashkin has joined #openstack-keystone11:15
openstackgerritwangxiyuan proposed openstack/keystone master: Api-ref: fix resource_limit format  https://review.openstack.org/54823111:21
zigohttps://stretch-queens.infomaniak.ch/job/keystone/5/console <--- Got 3 unit test errors when building in Stretch, could anyone help?11:23
*** david-lyle has quit IRC11:25
*** lbragstad_ has quit IRC11:26
gagehugozigo looking11:26
*** jrist has quit IRC11:27
*** links has joined #openstack-keystone11:28
openstackgerritGage Hugo proposed openstack/keystone master: Add functional testing gate  https://review.openstack.org/53101411:29
*** nicolasbock has joined #openstack-keystone11:31
openstackgerritGage Hugo proposed openstack/keystone master: Add functional testing gate  https://review.openstack.org/53101411:50
gagehugozigo let me spin up a debian stretch img and test it out11:52
*** jrist has joined #openstack-keystone11:53
*** jrist has quit IRC11:53
*** jrist has joined #openstack-keystone11:53
*** david-lyle has joined #openstack-keystone11:54
*** zhurong has quit IRC11:54
zigogagehugo: you can use my stretch backport repository: deb http://stretch-queens.infomaniak.ch stretch-queens-backports-nochange main12:02
zigodeb http://stretch-queens.infomaniak.ch stretch-queens-backports main12:02
zigoSource package is at https://salsa.debian.org/openstack-team/services/keystone12:03
zigoI don't have the issue in Sid.12:04
*** szaher_ has quit IRC12:07
*** david-lyle has quit IRC12:16
*** jrist has quit IRC12:16
*** jrist has joined #openstack-keystone12:20
*** edmondsw has joined #openstack-keystone12:24
*** markvoelker_ has quit IRC12:25
*** r-daneel has joined #openstack-keystone12:33
*** david-lyle has joined #openstack-keystone12:34
openstackgerritMerged openstack/keystone master: Remove unnecessary config overrides from fernet tests  https://review.openstack.org/54715612:37
*** dave-mccowan has joined #openstack-keystone13:13
*** mvk has joined #openstack-keystone13:28
*** markvoelker has joined #openstack-keystone13:28
openstackgerritMerged openstack/keystone master: Consolidate endpoint-filtering.rst  https://review.openstack.org/54729113:30
*** rarora has quit IRC13:31
*** lbragstad_ has joined #openstack-keystone13:33
*** lbragstad_ is now known as lbragstad13:33
*** ChanServ sets mode: +o lbragstad13:33
*** jaosorior has joined #openstack-keystone13:34
*** zhurong has joined #openstack-keystone13:34
*** r-daneel has quit IRC13:37
*** zhurong has quit IRC13:43
*** srf has joined #openstack-keystone13:45
srfhello i want to ask how to get tokens identity using curl13:46
openstackgerritColleen Murphy proposed openstack/keystone master: Work around deprecations for opportunistic tests  https://review.openstack.org/53157713:46
srfi follow this https://docs.openstack.org/keystone/pike/api_curl_examples.html, and get error curl: (7) Failed to connect to localhost port 5000: Connection refused13:47
*** jaosorior has quit IRC13:47
*** szaher_ has joined #openstack-keystone13:49
openstackgerritGage Hugo proposed openstack/keystone master: Add functional testing gate  https://review.openstack.org/53101413:58
*** david-lyle has quit IRC14:02
*** dklyle has joined #openstack-keystone14:02
*** dklyle has quit IRC14:06
*** zhurong has joined #openstack-keystone14:08
gagehugosrf is keystone listening on 5000?14:11
*** jmlowe has joined #openstack-keystone14:12
*** zhurong has quit IRC14:15
srfi follow https://docs.openstack.org/keystone/pike/api_curl_examples.html, is deferent?14:16
*** szaher_ has quit IRC14:27
*** srf has quit IRC14:28
gagehugosrf what happens when you curl "http://localhost:5000/v3/"?14:33
*** jrist has quit IRC14:33
*** d0ugal has joined #openstack-keystone14:35
*** charz has quit IRC14:36
*** szaher_ has joined #openstack-keystone14:36
*** charz has joined #openstack-keystone14:39
*** jrist has joined #openstack-keystone14:39
*** zhurong has joined #openstack-keystone14:43
*** robertomls has joined #openstack-keystone14:43
*** spilla has joined #openstack-keystone14:44
*** itlinux has quit IRC14:55
*** r-daneel has joined #openstack-keystone14:55
*** karthi has joined #openstack-keystone14:58
*** masber has quit IRC14:58
*** karthi has quit IRC14:59
gagehugozigo those failures are very weird15:08
zigogagehugo: Could you reproduce it?15:08
*** r-daneel has quit IRC15:08
gagehugozigo no15:08
zigogagehugo: Did you use my repository to pull all the dependencies /15:09
zigo?15:09
zigoYou should not attempt to use tox, that would defeat it.15:09
gagehugoah15:09
gagehugolooking at the tests that failed though makes me wonder15:09
*** jmlowe_ has joined #openstack-keystone15:09
gagehugosince there are others with project tags that use the same functionality which pass...15:10
zigoI just follow the requirements, but sometime they are just wrong.15:10
gagehugoother tests*15:10
zigoOh...15:10
zigogagehugo: You've seen I'm using Python 3, right?15:10
gagehugozigo ah15:11
gagehugohmm15:11
zigoI've switched all of the services to it.15:11
*** jmlowe has quit IRC15:11
zigoKeystone included.15:11
gagehugoit looks like it's failing on "self._create_project_and_tags"15:12
gagehugobut most of the project tags test use that and only 3 of them fail15:13
zigogagehugo: Does it look like broken test to you, or broken functionality?15:13
gagehugozigo not sure, we don't have debian images on the upstream openstack gate atm15:16
zigogagehugo: Again, I don't think that's related to what image, but the version of python libs, maybe.15:17
* zigo goes to fetch kids at school15:17
*** david-lyle has joined #openstack-keystone15:36
*** jaosorior has joined #openstack-keystone15:41
*** itlinux has joined #openstack-keystone15:42
*** dave-mccowan has quit IRC15:45
*** jaosorior has quit IRC15:51
*** d0ugal has quit IRC16:00
gagehugozigo maybe?16:02
*** links has quit IRC16:04
*** htruta has quit IRC16:06
*** pcaruana has quit IRC16:07
*** david-lyle has quit IRC16:15
*** dklyle has joined #openstack-keystone16:15
*** aloga_ has joined #openstack-keystone16:17
zigogagehugo: I'm back.16:21
gagehugozigo what is running the unit tests?16:22
gagehugosomething is putting the array into a string16:26
gagehugoand hitting this https://github.com/openstack/keystone/blob/stable/queens/keystone/resource/backends/sql.py#L335-L33716:27
gagehugowhich will throw the error shown in those 3 failing tests16:27
*** Supun has joined #openstack-keystone16:28
gagehugoonly the tests with >= 8 tags created will fail16:30
gagehugothey all use random uuids for the values, so technically 5 tags in an array will be less than 25516:31
gagehugoI wonder if whatever is running the tests is escaping things16:31
*** szaher_ has quit IRC16:32
*** zhurong has quit IRC16:45
*** r-daneel has joined #openstack-keystone16:46
*** markvoelker has quit IRC16:55
*** aloga_ has quit IRC17:01
*** lbragstad has quit IRC17:07
*** dave-mccowan has joined #openstack-keystone17:08
*** mvk has quit IRC17:14
*** AlexeyAbashkin has quit IRC17:15
*** gyee has joined #openstack-keystone17:16
*** Supun has quit IRC17:21
*** Supun has joined #openstack-keystone17:22
*** oikiki has joined #openstack-keystone17:31
*** dave-mccowan has quit IRC17:33
*** links has joined #openstack-keystone17:35
*** Supun has quit IRC17:40
*** Supun has joined #openstack-keystone17:41
*** Supun has quit IRC17:58
*** Supun has joined #openstack-keystone17:58
*** dave-mccowan has joined #openstack-keystone18:01
*** david-lyle_ has joined #openstack-keystone18:01
*** harlowja has joined #openstack-keystone18:03
*** dklyle has quit IRC18:05
*** AlexeyAbashkin has joined #openstack-keystone18:26
*** AlexeyAbashkin has quit IRC18:30
*** gyee has quit IRC18:31
*** tesseract has quit IRC18:31
*** david-lyle_ has quit IRC18:34
gagehugozigo oh it runs stestr under the hood18:37
gagehugoyour python lib version idea may be accurate...18:38
*** dave-mccowan has quit IRC18:56
*** david-lyle has joined #openstack-keystone18:58
zigogagehugo: Yes, in packaging, we can't run tox, so we just do what tox.ini says ...19:05
*** AlexeyAbashkin has joined #openstack-keystone19:08
*** AlexeyAbashkin has quit IRC19:13
*** dave-mccowan has joined #openstack-keystone19:13
gagehugoI'm not familiar with debian, but from the output logs it looks like something is escaping characters in the tags array19:14
gagehugo"String length exceeded. The length of string \\\'[\\\'f8d9333f7b8b4ba1b1d60e49b10132d2\\\' that is very weird19:15
*** Supun has quit IRC19:16
*** Supun has joined #openstack-keystone19:17
zigogagehugo: What you can do is just git clone https://salsa.debian.org/openstack-team/services/keystone ; cd keystone ; ./debian/rules gen-orig-xz ; dpkg-buildpackage19:17
zigoDependencies are where I showed you.19:17
zigoThanks a lot for investigating anyway.19:18
zigoThat's very nice of you.19:18
*** Supun has quit IRC19:19
*** Supun has joined #openstack-keystone19:19
*** Supun has quit IRC19:19
kmallocgagehugo: uhm. that @expression is bad19:29
kmalloclike... why are we doing .Name?19:29
kmallocthats... what the heck?19:29
kmallocwe need to stop applying hybrid properties randomly19:30
kmallocpeople don't seem to understand hybrid properties.19:30
kmalloczigo: ^ cc.19:30
zigokmalloc: Are you suggesting a patch? :)19:31
kmalloci am suggesting someone needs to produce a patch19:31
gagehugokmalloc I may have followed the password usage of @expression19:32
kmalloci don't understand why we're doing project.tags returns projecttag.Name19:32
kmallocyeah19:32
kmallocthat is broken19:32
kmallocyou're returning the name of a single project tag in some cases19:32
gagehugoah19:33
kmallocnamely when you're dealing with uninstantiated objects19:33
kmalloc@expression handles class like usage19:33
kmallocvs. instance like usage19:33
gagehugothat may be what is throwing the entire array into that19:33
kmallocin the case of Password you only ever have a single password19:33
kmallocso, we reference the password.19:33
kmallocit's the same kind of issue we're having with uhm... another feature19:34
gagehugoyeah19:34
gagehugoweird that this has only show up with zigo's debian build19:34
gagehugoshown*19:34
gagehugobut honestly that makes sense19:35
kmallocit is possibly something wonky with the non-tox environemtn19:36
kmalloctox does other magic sometimes.19:36
kmallocin fact we have the same issue with Password19:37
kmallocjust different represenation of the issue19:38
kmallocbasically, we need to drop the .expression for Password as well.19:38
kmallocextra long passwords are inappropriately being not-hashed.19:38
kmallocbefore being checked for length19:39
gagehugokmalloc so a @hybrid_property without an expression should be a @property then?19:42
kmallocno.19:43
kmalloci am not sure why you're doing an expression here.19:43
kmallocyou can probably just drop .expression19:43
kmallocmethod19:43
kmallocafaict19:43
gagehugoI think I ran into some issue when I didn't have it, lemme check19:44
kmallocsee http://docs.sqlalchemy.org/en/latest/orm/extensions/hybrid.html for what a hybrid is actually for19:44
kmallocit is mostly for cases when you need to handle a behavior difference19:46
kmallocfor say a difference between a default and not19:46
kmallocso, i think you can swap to plain @property19:47
kmallocfrom @hybrid19:47
kmallocand drop the .expression19:47
gagehugoah, tags wouldn't have a behavior difference19:47
kmallocthere is zero case you should have a project object not instanciated with tags19:47
gagehugoyeah19:48
kmallocthe key is like the length value, where by default you're doing return func.abs(cls.length) / 2 instead of return abs(self.length) / 219:48
kmalloclikewise we should never have a password without a hash...19:49
gagehugook19:49
gagehugoI'll take a look at it19:49
kmallocso i'd try swapping tags to @property19:49
kmallocand drop .expression19:49
kmallocit might need other things19:49
kmallocbut that would be where i start19:49
gagehugozigo I'll try to get a patch up somewhat quickly, currently 8 PM here19:50
gagehugokmalloc will do!19:50
zigogagehugo: Are you in Dublin ? :)19:50
kmallocthe other option is, you might need to make .expression simply return []19:50
gagehugozigo aye19:50
kmallocif you can't make the non-hybrid version work19:50
zigogagehugo: I wish I was there too...19:50
kmalloczigo: it's ok man, i'm not there either.19:50
zigoI miss seeing the OpenStack folks.19:50
gagehugozigo kmalloc we are supposed to get a lot of snow here...19:51
zigoLots of them, I consider friends.19:51
gagehugoyeah I miss seeing kmalloc here :(19:51
zigogagehugo: It was -15 C this morning where I live. :P19:51
gagehugoewww19:51
gagehugoit's been ~0C here19:52
zigo(I live at 1000m in the mountain)19:52
kmallocI live at ~50m over sea level19:52
kmallocit's been 0-2c today19:52
kmallocmaybe only 25m over sea level19:52
kmalloc:P19:52
kmallocwe got snow a few days ago19:53
* gagehugo gets ready to go get sushi19:53
gagehugokmalloc thanks, that was bothering me all day19:53
gagehugobut that honestly makes a lot of sense19:53
gagehugosince we've seen weird things with that password .expression19:54
openstackgerritGage Hugo proposed openstack/keystone master: WIP Remove @expression from tags  https://review.openstack.org/54839919:57
kmallocthe .expression part should only ever be called when in the "class" form, so if you can't make it work w/o .expression or with standard @property, make .expression return [] and we can troubleshoot from there19:59
kmallocanother option is possibly:     @balance.expression19:59
kmalloc    def balance(cls):19:59
kmalloc        return select([func.sum(SavingsAccount.balance)]).\19:59
kmalloc                where(SavingsAccount.user_id==cls.id).\19:59
kmalloc                label('total_balance')19:59
kmallocsomething like that19:59
kmallocwhere you do the explicit select20:00
*** ayushin78 has joined #openstack-keystone20:05
zigogagehugo: Thanks, will try the patch.20:11
*** ayushin78 has quit IRC20:17
*** links has quit IRC20:30
*** markvoelker_ has joined #openstack-keystone20:51
*** oikiki has quit IRC20:52
*** oikiki has joined #openstack-keystone20:52
kmalloczigo: it will fail pep821:07
kmallocbut that is because hybrid_property is imported there.21:08
*** panbalag has quit IRC21:11
zigokmalloc: I'm not sure if its my env that changed or what, but keystone builds in my stretch CI now ! :)21:24
zigo(with your patch)21:24
kmallocweird.21:24
kmallocbut sure.21:25
zigokmalloc: I don't run pep8 tests (that's useless for packaging...).21:25
kmalloczigo: fwiw, you should probably firewall off your jenkins... last i heard jenkins wasn't really secure to expose to the internet.21:25
kmalloceven w/ passwords and what not.21:25
zigokmalloc: I don't have much choice, it needs webhooks from salsa.debian.org.21:26
zigoBut you're probably right.21:26
zigoJenkins is a piece of junk ! :)21:26
kmallocyou might be able to isolate just the webhooks and from that source.21:26
zigoThough it's easy to setup.21:26
zigoYup.21:26
kmalloceh, it isn't junk, it does what it does ok21:26
kmallocit has limits21:26
kmallocthere are other options that are better in some cases.21:27
zigoLike buildbot ?21:27
zigoI only heard bad things about it.21:27
* kmalloc shrugs. 21:27
kmallocif it works, keep using it. but just work to limit exposure ;)21:27
kmallocanyway. that patch should pass everything but pep8 afict21:27
openstackgerritMorgan Fainberg proposed openstack/keystone master: WIP Remove @expression from tags  https://review.openstack.org/54839921:30
*** aloga_ has joined #openstack-keystone21:33
*** panbalag has joined #openstack-keystone21:51
*** martinus__ has quit IRC21:58
*** AlexeyAbashkin has joined #openstack-keystone22:05
*** AlexeyAbashkin has quit IRC22:09
*** mvk has joined #openstack-keystone22:36
*** oikiki has quit IRC22:38
*** oikiki has joined #openstack-keystone22:38
*** itlinux has quit IRC22:40
*** rcernin has joined #openstack-keystone22:59
*** spilla has quit IRC23:07
*** oikiki has quit IRC23:19
*** edmondsw has quit IRC23:32
*** edmondsw has joined #openstack-keystone23:32
*** edmondsw has quit IRC23:36
*** aloga_ has quit IRC23:41
*** edmondsw has joined #openstack-keystone23:43
*** edmondsw has quit IRC23:48
*** r-daneel has quit IRC23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!