| *** itlinux has joined #openstack-keystone | 00:16 | |
| *** edmondsw has quit IRC | 00:18 | |
| *** lbragstad has quit IRC | 00:22 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 00:37 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 00:40 | |
| *** links has joined #openstack-keystone | 00:40 | |
| *** AlexeyAbashkin has quit IRC | 00:44 | |
| openstackgerrit | Merged openstack/keystone master: Expose bug in system assignment when deleting users https://review.openstack.org/544067 | 00:49 |
|---|---|---|
| openstackgerrit | Merged openstack/keystone master: Delete system role assignments when deleting users https://review.openstack.org/543622 | 01:04 |
| *** Dinesh_Bhor has quit IRC | 01:08 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 01:10 | |
| *** agrebennikov has quit IRC | 01:15 | |
| *** itlinux has quit IRC | 01:19 | |
| *** Dinesh_Bhor has quit IRC | 01:25 | |
| *** gyee has quit IRC | 01:25 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 01:26 | |
| *** Dinesh_Bhor has quit IRC | 01:31 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 01:36 | |
| *** Dinesh_Bhor has quit IRC | 01:41 | |
| *** itlinux has joined #openstack-keystone | 01:44 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 01:45 | |
| *** edmondsw has joined #openstack-keystone | 01:46 | |
| *** rmcall has joined #openstack-keystone | 01:46 | |
| *** oikiki has quit IRC | 01:46 | |
| *** edmondsw has quit IRC | 01:51 | |
| *** itlinux has quit IRC | 02:10 | |
| *** Dinesh_Bhor has quit IRC | 02:23 | |
| *** itlinux has joined #openstack-keystone | 02:32 | |
| *** lbragstad has joined #openstack-keystone | 02:35 | |
| *** ChanServ sets mode: +o lbragstad | 02:35 | |
| lbragstad | kmalloc wxy thanks for reviewing those | 02:42 |
| *** itlinux has quit IRC | 02:44 | |
| *** d0ugal has quit IRC | 02:49 | |
| *** d0ugal has joined #openstack-keystone | 02:59 | |
| *** r-daneel has joined #openstack-keystone | 03:23 | |
| *** harlowja has quit IRC | 03:30 | |
| *** edmondsw has joined #openstack-keystone | 03:34 | |
| *** edmondsw has quit IRC | 03:39 | |
| *** links has quit IRC | 03:50 | |
| *** d0ugal has quit IRC | 03:55 | |
| *** d0ugal has joined #openstack-keystone | 03:59 | |
| *** lbragstad has quit IRC | 04:02 | |
| *** links has joined #openstack-keystone | 04:07 | |
| *** dave-mccowan has quit IRC | 04:10 | |
| *** harlowja has joined #openstack-keystone | 04:12 | |
| *** harlowja has quit IRC | 04:30 | |
| *** bhagyashri_s is now known as bhagyashris | 04:52 | |
| *** harlowja has joined #openstack-keystone | 05:14 | |
| *** lbragstad has joined #openstack-keystone | 05:42 | |
| *** ChanServ sets mode: +o lbragstad | 05:42 | |
| *** masber has joined #openstack-keystone | 06:22 | |
| *** harlowja has quit IRC | 06:24 | |
| openstackgerrit | Merged openstack/keystone master: Expose bug in /role_assignments API with system-scope https://review.openstack.org/544011 | 06:55 |
| openstackgerrit | Merged openstack/keystone master: Fix querying role_assignment with system roles https://review.openstack.org/544012 | 06:55 |
| openstackgerrit | Merged openstack/keystone master: Grant admin a role on the system during bootstrap https://review.openstack.org/530410 | 06:56 |
| *** belmoreira has joined #openstack-keystone | 07:01 | |
| *** edmondsw has joined #openstack-keystone | 07:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone master: Imported Translations from Zanata https://review.openstack.org/543826 | 07:12 |
| *** edmondsw has quit IRC | 07:15 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 07:16 | |
| *** lbragstad has quit IRC | 07:17 | |
| *** AlexeyAbashkin has quit IRC | 07:21 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 07:26 | |
| *** martinus__ has joined #openstack-keystone | 07:51 | |
| *** pcaruana has joined #openstack-keystone | 07:56 | |
| *** bhagyashri_s has joined #openstack-keystone | 07:56 | |
| *** bhagyashris has quit IRC | 07:59 | |
| *** masber has quit IRC | 08:05 | |
| *** tesseract has joined #openstack-keystone | 08:28 | |
| *** bhagyashris_ has joined #openstack-keystone | 08:28 | |
| *** bhagyashris_ has quit IRC | 08:28 | |
| *** bhagyashris has joined #openstack-keystone | 08:31 | |
| *** bhagyashri_s has quit IRC | 08:32 | |
| *** rcernin has quit IRC | 08:33 | |
| *** links has quit IRC | 08:53 | |
| *** links has joined #openstack-keystone | 09:06 | |
| openstackgerrit | Merged openstack/keystone master: Expose bug in system assignment when deleting groups https://review.openstack.org/544073 | 09:08 |
| openstackgerrit | Merged openstack/keystone master: Delete system role assignments when deleting groups https://review.openstack.org/544074 | 09:08 |
| *** pcaruana has quit IRC | 10:05 | |
| openstackgerrit | Murali Annamneni proposed openstack/keystone master: [WIP] Enables MySQL Cluster support for Keystone https://review.openstack.org/431229 | 10:14 |
| *** pcaruana has joined #openstack-keystone | 10:20 | |
| *** edmondsw has joined #openstack-keystone | 10:47 | |
| *** sambetts|afk is now known as sambetts | 10:48 | |
| *** edmondsw has quit IRC | 10:52 | |
| *** AlexeyAbashkin has quit IRC | 11:05 | |
| *** pcaruana has quit IRC | 11:30 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 11:38 | |
| *** pcaruana has joined #openstack-keystone | 11:42 | |
| *** dave-mccowan has joined #openstack-keystone | 11:56 | |
| *** raildo has joined #openstack-keystone | 11:57 | |
| *** edmondsw has joined #openstack-keystone | 12:36 | |
| *** edmondsw has quit IRC | 12:40 | |
| *** edmondsw has joined #openstack-keystone | 12:50 | |
| *** r-daneel has quit IRC | 12:54 | |
| *** mvk_ has quit IRC | 12:58 | |
| *** r-daneel has joined #openstack-keystone | 13:04 | |
| *** lbragstad has joined #openstack-keystone | 13:23 | |
| *** ChanServ sets mode: +o lbragstad | 13:23 | |
| *** mvk_ has joined #openstack-keystone | 13:24 | |
| *** rmcall has quit IRC | 13:43 | |
| *** r-daneel has quit IRC | 14:11 | |
| gagehugo | o/ | 14:19 |
| lbragstad | o/ | 14:20 |
| *** rmcall has joined #openstack-keystone | 14:24 | |
| *** r-daneel has joined #openstack-keystone | 14:29 | |
| *** spilla has joined #openstack-keystone | 14:29 | |
| *** links has quit IRC | 14:33 | |
| *** lbragsta_ has joined #openstack-keystone | 14:50 | |
| *** ChanServ sets mode: +o lbragsta_ | 14:50 | |
| *** bhagyashris has quit IRC | 14:50 | |
| *** lbragstad has quit IRC | 14:51 | |
| *** bhagyashris has joined #openstack-keystone | 14:52 | |
| -openstackstatus- NOTICE: Due to a race in stable/queens branch creation and some job removals, Zuul has reported syntax errors for the past hour; if you saw a syntax error reported for "Job tripleo-ci-centos-7-ovb-containers-oooq not defined" you can safely recheck now | 15:04 | |
| openstackgerrit | Merged openstack/keystone master: Imported Translations from Zanata https://review.openstack.org/543826 | 15:08 |
| knikolla | o/ | 15:11 |
| *** r-daneel has quit IRC | 15:14 | |
| *** AlexeyAbashkin has quit IRC | 15:17 | |
| *** lbragsta_ is now known as lbragstad | 15:19 | |
| *** r-daneel has joined #openstack-keystone | 15:22 | |
| *** Exhar has quit IRC | 15:29 | |
| lbragstad | easy stable/ocata review https://review.openstack.org/#/c/543379/2 | 15:29 |
| cmurphy | kmalloc: ^ | 15:30 |
| * lbragstad reboots | 15:30 | |
| *** lbragstad has quit IRC | 15:31 | |
| *** dklyle has joined #openstack-keystone | 15:33 | |
| *** lbragstad has joined #openstack-keystone | 15:33 | |
| *** ChanServ sets mode: +o lbragstad | 15:33 | |
| *** david-lyle has quit IRC | 15:33 | |
| *** links has joined #openstack-keystone | 15:40 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 15:42 | |
| *** ksavich has joined #openstack-keystone | 15:46 | |
| *** itlinux has joined #openstack-keystone | 15:50 | |
| *** agrebennikov has joined #openstack-keystone | 15:50 | |
| *** Justas__ has joined #openstack-keystone | 15:52 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 15:59 |
| *** Exhar has joined #openstack-keystone | 16:00 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove needs_persistence property from token providers https://review.openstack.org/544515 | 16:05 |
| *** pcaruana has quit IRC | 16:13 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove unused class variables from token provider https://review.openstack.org/544520 | 16:14 |
| kmalloc | cmurphy: looking | 16:21 |
| kmalloc | approved | 16:21 |
| * kmalloc stable-cores the hell out of that review :P | 16:22 | |
| cmurphy | :D | 16:24 |
| lbragstad | kmalloc you're the lone wolf :) | 16:26 |
| kmalloc | lbragstad: pushed the stab/queens stuff through now that master landed as well | 16:26 |
| kmalloc | the ones you had pending | 16:26 |
| lbragstad | kmalloc nice - there are a few others ready to go too https://goo.gl/fdNpTL | 16:27 |
| *** belmoreira has quit IRC | 16:28 | |
| kmalloc | looking but might be post dog walk | 16:29 |
| kmalloc | had to take care of a morning call before I could jump on the dog walkingness | 16:29 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Refactor token cache invalidation callbacks https://review.openstack.org/544528 | 16:35 |
| *** itlinux has quit IRC | 16:41 | |
| gagehugo | lbragstad did we decide to not allow release note changes after release? | 16:43 |
| lbragstad | i think we can still allow them things we haven't cut the release yet | 16:44 |
| lbragstad | s/things/since/ | 16:44 |
| lbragstad | my typing sucks recently | 16:44 |
| gagehugo | so for https://review.openstack.org/#/c/496323/ then kmalloc is right we shouldn't make changes then? | 16:45 |
| kmalloc | yep. | 16:45 |
| kmalloc | basically just don't ever change release notes | 16:45 |
| kmalloc | it makes for hell. | 16:45 |
| kmalloc | you can add them, but once they land, they should be assumed to be immutable | 16:45 |
| lbragstad | i believe so - i remember having a conversation with smginnis about that | 16:45 |
| lbragstad | until we release | 16:45 |
| lbragstad | one a release is out the door, modifying them is way harder | 16:46 |
| kmalloc | even across milestones just don't ever change release notes | 16:46 |
| kmalloc | it's a headache | 16:46 |
| kmalloc | get them right the first time. | 16:46 |
| * lbragstad loves waterfall | 16:46 | |
| kmalloc | reno has some oddities | 16:46 |
| kmalloc | but it solves more issues than it creates | 16:46 |
| lbragstad | it's strange, i don't remember all of it, but i did do some documentation about it somewhere | 16:47 |
| kmalloc | lbragstad: all stab/pike and stab/queens reviews have a score and are either approved OR marked as why they can't be | 16:47 |
| lbragstad | yeah - here | 16:47 |
| lbragstad | https://docs.openstack.org/keystone/latest/contributor/release-notes.html | 16:47 |
| kmalloc | tl;dr - please don't change release notes | 16:48 |
| lbragstad | what about https://review.openstack.org/#/c/544101/ ? | 16:48 |
| kmalloc | adding a release note | 16:49 |
| gagehugo | ok | 16:49 |
| kmalloc | that is fine, since it's a backport | 16:49 |
| kmalloc | adding a release note in a previous branch should have zero impact | 16:49 |
| kmalloc | afaiu | 16:49 |
| lbragstad | cmurphy we don't need this anymore do we? https://review.openstack.org/#/c/511061/ | 16:49 |
| kmalloc | because it doesn't change a note causing a re-publish | 16:49 |
| lbragstad | cmurphy because https://review.openstack.org/#/c/542483/ landed | 16:50 |
| lbragstad | right? | 16:50 |
| cmurphy | lbragstad: correct | 16:50 |
| lbragstad | cmurphy awesome | 16:51 |
| lbragstad | kmalloc gagehugo https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes | 16:51 |
| lbragstad | ^ that clarifies it | 16:51 |
| lbragstad | if changes absolutely have to be made, which is rare, they should be made directly against the branch | 16:52 |
| kmalloc | and, iirc, it still caused weirdness | 16:52 |
| lbragstad | and not follow the typical stable process | 16:52 |
| *** itlinux has joined #openstack-keystone | 16:52 | |
| gagehugo | hmm | 16:52 |
| kmalloc | even if URLs change, don't muck with the release notes. | 16:52 |
| kmalloc | i'd -2 any release note changes barring things to fix them if they have a render issue | 16:52 |
| kmalloc | simply to avoid issues with it | 16:53 |
| lbragstad | kmalloc samueldmq want to abandon https://review.openstack.org/#/c/511061/1 ? | 16:53 |
| kmalloc | yah. | 16:53 |
| kmalloc | done | 16:53 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Force SQLite to properly deal with foreign keys https://review.openstack.org/126030 | 16:54 |
| kmalloc | rebase ^ | 16:54 |
| kmalloc | ok, dog walking | 16:55 |
| kmalloc | back in a bit | 16:55 |
| *** rmcall has quit IRC | 16:58 | |
| *** rmcall has joined #openstack-keystone | 17:03 | |
| *** AlexeyAbashkin has quit IRC | 17:07 | |
| *** rmcall has quit IRC | 17:08 | |
| *** gyee has joined #openstack-keystone | 17:11 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 17:15 | |
| *** pcaruana has joined #openstack-keystone | 17:17 | |
| *** ksavich has quit IRC | 17:17 | |
| *** AlexeyAbashkin has quit IRC | 17:20 | |
| *** links has quit IRC | 17:21 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Have project get domain_id from parent https://review.openstack.org/489655 | 17:23 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Remove the TokenAuth middleware https://review.openstack.org/508412 | 17:29 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Remove the TokenAuth middleware https://review.openstack.org/508412 | 17:31 |
| *** jmlowe has quit IRC | 17:46 | |
| *** jmlowe has joined #openstack-keystone | 17:49 | |
| *** rmcall has joined #openstack-keystone | 17:56 | |
| *** sambetts is now known as sambetts|afk | 17:56 | |
| *** jmlowe has quit IRC | 18:00 | |
| *** hoonetorg has quit IRC | 18:05 | |
| *** mvk_ has quit IRC | 18:08 | |
| *** oikiki has joined #openstack-keystone | 18:13 | |
| *** hoonetorg has joined #openstack-keystone | 18:22 | |
| *** jmlowe has joined #openstack-keystone | 18:26 | |
| *** agrebennikov has quit IRC | 18:28 | |
| *** openstackgerrit has quit IRC | 18:33 | |
| *** agrebennikov has joined #openstack-keystone | 18:42 | |
| *** tesseract has quit IRC | 18:54 | |
| kmalloc | lbragstad: ./keystone/tests/unit/test_v3_assignment.py:451:6: F821 undefined name 'test_utils' | 19:04 |
| kmalloc | lbragstad: the stab/queens fix(es) | 19:05 |
| lbragstad | looking | 19:05 |
| lbragstad | kmalloc rebased | 19:10 |
| kmalloc | k | 19:10 |
| lbragstad | testing them locally with the rebase | 19:11 |
| kmalloc | nod | 19:11 |
| *** openstackgerrit has joined #openstack-keystone | 19:17 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 19:17 |
| lbragstad | kmalloc since that module is added and removed in a couple of those patches, i'm going to put them in a linear series and repropose them to stable/queens | 19:21 |
| kmalloc | ok | 19:21 |
| lbragstad | then we should have a race | 19:21 |
| lbragstad | shouldn't* | 19:21 |
| *** harlowja has joined #openstack-keystone | 19:21 | |
| lbragstad | kmalloc sweet - putting everything in a series locally passes tests, repushed | 19:25 |
| *** dklyle has quit IRC | 19:33 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add functional testing gate https://review.openstack.org/531014 | 19:33 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add docs for application credentials https://review.openstack.org/543643 | 19:34 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Use OSC in application credential documentation https://review.openstack.org/543644 | 19:34 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Simplify INVALIDATE_USER_TOKEN_PERSISTENCE callback https://review.openstack.org/544616 | 19:43 |
| *** oikiki has quit IRC | 19:45 | |
| *** oikiki has joined #openstack-keystone | 19:45 | |
| *** david-lyle has joined #openstack-keystone | 20:12 | |
| kmalloc | lbragstad: uhm | 20:40 |
| kmalloc | lbragstad: that cache change looks like it's missing something | 20:40 |
| kmalloc | "cache_dropped" is always false? | 20:40 |
| lbragstad | aha - yep, you're right | 20:42 |
| lbragstad | i can fix that in the next patch set, working on removing a separate callback | 20:43 |
| kmalloc | right. it probably doesn't work right now because of that | 20:43 |
| kmalloc | nbd | 20:43 |
| lbragstad | well - it will work | 20:43 |
| lbragstad | because it always drops the cache | 20:43 |
| lbragstad | it's an optimization | 20:44 |
| kmalloc | right | 20:44 |
| lbragstad | so right now it just drops the cache repeatedly, when it should just drop it once | 20:44 |
| kmalloc | just not working "right". | 20:44 |
| lbragstad | yeah - tests will pass | 20:44 |
| kmalloc | also you should ensure the cache drop is only at the END of any loops. | 20:44 |
| lbragstad | i should write a test for that though | 20:44 |
| kmalloc | otherwise you run into potential races | 20:44 |
| kmalloc | where something populated the cache in the middle of the loop and you end up broken. | 20:45 |
| kmalloc | because you dropped cache early | 20:45 |
| kmalloc | cache should be dropped at the latest part only, not earliest | 20:45 |
| lbragstad | yeah | 20:45 |
| lbragstad | so i probably don't need that boolean | 20:46 |
| kmalloc | yeah, unless you're setting it so you know you need to drop the cache at the end | 20:46 |
| *** mchlumsky_ has joined #openstack-keystone | 20:52 | |
| *** mchlumsky has quit IRC | 20:54 | |
| *** spilla has quit IRC | 20:57 | |
| *** spilla has joined #openstack-keystone | 20:57 | |
| *** kamix has joined #openstack-keystone | 21:00 | |
| *** kamix has left #openstack-keystone | 21:00 | |
| *** nkinder has joined #openstack-keystone | 21:01 | |
| *** nkinder has quit IRC | 21:01 | |
| *** spilla has quit IRC | 21:02 | |
| *** spilla has joined #openstack-keystone | 21:17 | |
| *** pcaruana has quit IRC | 21:28 | |
| *** mvk_ has joined #openstack-keystone | 21:38 | |
| openstackgerrit | Merged openstack/keystone master: Remove domains *-log-* from compile_catalog https://review.openstack.org/438875 | 21:41 |
| *** raildo has quit IRC | 21:42 | |
| *** martinus__ has quit IRC | 21:47 | |
| *** rcernin has joined #openstack-keystone | 22:00 | |
| *** rmcall has quit IRC | 22:05 | |
| *** agrebennikov has quit IRC | 22:12 | |
| *** dave-mccowan has quit IRC | 22:20 | |
| *** threestrands has joined #openstack-keystone | 22:31 | |
| lbragstad | https://review.openstack.org/#/c/544096/3 https://review.openstack.org/#/c/544097/3 and https://review.openstack.org/#/c/544101/2 should all be good to go | 22:34 |
| lbragstad | cmurphy proposed the backport for your docs patch - https://review.openstack.org/#/c/544718/ | 22:36 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Simplify token persistence callbacks https://review.openstack.org/544616 | 22:37 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Simplify token persistence callbacks https://review.openstack.org/544616 | 22:49 |
| *** itlinux has quit IRC | 22:53 | |
| *** agrebennikov has joined #openstack-keystone | 23:00 | |
| *** edmondsw has quit IRC | 23:12 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Simplify federation and oauth token callbacks https://review.openstack.org/544737 | 23:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!