| *** bigdogstl has joined #openstack-keystone | 00:03 | |
| *** rmcall_ has joined #openstack-keystone | 00:07 | |
| *** bigdogstl has quit IRC | 00:09 | |
| openstackgerrit | Merged openstack/keystone master: Add schema check for authorize request token https://review.openstack.org/526296 | 00:25 |
|---|---|---|
| *** bigdogstl has joined #openstack-keystone | 00:26 | |
| *** zhurong has joined #openstack-keystone | 00:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 00:46 |
| *** dave-mccowan has joined #openstack-keystone | 00:49 | |
| *** spzala has quit IRC | 00:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 01:06 |
| *** bigdogstl has quit IRC | 01:08 | |
| openstackgerrit | Shuo Liu proposed openstack/keystone master: Fix wrong url in domains-config-v3.inc https://review.openstack.org/534577 | 01:10 |
| *** bigdogstl has joined #openstack-keystone | 01:15 | |
| *** bigdogstl has quit IRC | 01:17 | |
| *** bigdogstl has joined #openstack-keystone | 01:17 | |
| *** bigdogstl has quit IRC | 01:19 | |
| *** bigdogstl has joined #openstack-keystone | 01:19 | |
| *** bigdogstl has quit IRC | 01:21 | |
| *** david-lyle has quit IRC | 01:23 | |
| *** markvoelker has quit IRC | 01:25 | |
| openstackgerrit | Shuo Liu proposed openstack/keystone master: Fix wrong url in domains-config-v3.inc https://review.openstack.org/534577 | 01:25 |
| *** bigdogstl has joined #openstack-keystone | 01:27 | |
| openstackgerrit | Shuo Liu proposed openstack/keystone master: Fix wrong url in domains-config-v3.inc https://review.openstack.org/534577 | 01:29 |
| openstackgerrit | Merged openstack/keystone master: Implement controller logic for system group assignments https://review.openstack.org/524017 | 01:30 |
| *** bigdogstl has quit IRC | 01:34 | |
| *** dave-mccowan has quit IRC | 01:42 | |
| *** dave-mccowan has joined #openstack-keystone | 01:43 | |
| *** edmondsw has joined #openstack-keystone | 01:45 | |
| *** abhi89 has joined #openstack-keystone | 01:47 | |
| *** edmondsw has quit IRC | 01:50 | |
| *** bigdogstl has joined #openstack-keystone | 02:00 | |
| ayoung | jamielennox, I got help from mordred | 02:01 |
| ayoung | jamielennox, the end state was this: | 02:01 |
| ayoung | https://paste.fedoraproject.org/paste/BW~CRCAiSYHNm0ISdYloLg | 02:01 |
| *** bigdogstl has quit IRC | 02:06 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Force SQLite to properly deal with foreign keys https://review.openstack.org/126030 | 02:12 |
| *** bigdogstl has joined #openstack-keystone | 02:13 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: remove _append_null_domain_id decorator https://review.openstack.org/527848 | 02:13 |
| lbragstad | wxy: oh - nice! | 02:19 |
| lbragstad | thanks for picking up that fk patch | 02:19 |
| *** dave-mccowan has quit IRC | 02:19 | |
| lbragstad | i'm not sure if dstanek has any bits locally not in review though | 02:20 |
| wxy | lbragstad: I'll pick up it. :) | 02:35 |
| wxy | lbragstad: Thanks for the information. I think the problem will be solved once we open the FK in sqlite. | 02:36 |
| wxy | Nova has a similar work. https://github.com/openstack/nova/blob/fdf50a1a6227f9a9a14dfffb64029649a02b354a/nova/tests/functional/db/test_archive.py#L44 | 02:38 |
| *** rmcall_ has quit IRC | 02:40 | |
| *** gyee has quit IRC | 02:41 | |
| *** dave-mccowan has joined #openstack-keystone | 02:52 | |
| lbragstad | wxy: good deal | 03:01 |
| *** itlinux has joined #openstack-keystone | 03:25 | |
| *** markvoelker has joined #openstack-keystone | 03:26 | |
| *** bigdogstl has quit IRC | 03:35 | |
| *** spzala has joined #openstack-keystone | 03:40 | |
| *** daidv has joined #openstack-keystone | 03:50 | |
| *** markvoelker has quit IRC | 04:01 | |
| *** bigdogstl has joined #openstack-keystone | 04:03 | |
| *** nicolasbock has quit IRC | 04:09 | |
| *** bigdogstl has quit IRC | 04:14 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Force SQLite to properly deal with foreign keys https://review.openstack.org/126030 | 04:14 |
| *** david-lyle has joined #openstack-keystone | 04:23 | |
| *** dave-mccowan has quit IRC | 04:32 | |
| *** bigdogstl has joined #openstack-keystone | 04:34 | |
| *** zhurong has quit IRC | 04:36 | |
| *** bigdogstl has quit IRC | 04:40 | |
| *** bigdogstl has joined #openstack-keystone | 04:43 | |
| *** bigdogstl has quit IRC | 04:47 | |
| *** links has joined #openstack-keystone | 04:49 | |
| *** markvoelker has joined #openstack-keystone | 04:57 | |
| *** bigdogstl has joined #openstack-keystone | 05:06 | |
| *** bigdogstl has quit IRC | 05:12 | |
| *** bigdogstl has joined #openstack-keystone | 05:14 | |
| openstackgerrit | Merged openstack/keystone master: Remove duplicated release note https://review.openstack.org/529900 | 05:15 |
| *** markvoelker has quit IRC | 05:16 | |
| *** spzala has quit IRC | 05:17 | |
| *** prashkre has joined #openstack-keystone | 05:17 | |
| *** bigdogstl has quit IRC | 05:20 | |
| *** edmondsw has joined #openstack-keystone | 05:21 | |
| *** edmondsw has quit IRC | 05:26 | |
| openstackgerrit | Merged openstack/keystone master: msgpack-python has been renamed to msgpack https://review.openstack.org/533768 | 05:30 |
| *** spzala has joined #openstack-keystone | 05:32 | |
| *** spzala has quit IRC | 05:32 | |
| *** spzala has joined #openstack-keystone | 05:34 | |
| *** bigdogstl has joined #openstack-keystone | 05:38 | |
| *** prashkre has quit IRC | 05:40 | |
| *** bigdogstl has quit IRC | 05:43 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 05:47 |
| *** zhurong has joined #openstack-keystone | 05:48 | |
| *** bigdogstl has joined #openstack-keystone | 05:50 | |
| *** annp has joined #openstack-keystone | 06:00 | |
| *** magicboiz has joined #openstack-keystone | 06:00 | |
| *** magicboiz has quit IRC | 06:00 | |
| *** bigdogstl has quit IRC | 06:01 | |
| *** spzala has quit IRC | 06:19 | |
| *** markvoelker has joined #openstack-keystone | 06:28 | |
| *** sapd__ has quit IRC | 06:38 | |
| *** sapd__ has joined #openstack-keystone | 06:39 | |
| *** spzala has joined #openstack-keystone | 06:50 | |
| *** spzala has quit IRC | 06:54 | |
| *** markvoelker has quit IRC | 07:02 | |
| *** bigdogstl has joined #openstack-keystone | 07:03 | |
| *** edmondsw has joined #openstack-keystone | 07:09 | |
| *** bigdogstl has quit IRC | 07:12 | |
| *** edmondsw has quit IRC | 07:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 07:16 |
| *** spzala has joined #openstack-keystone | 07:20 | |
| *** threestrands_ has quit IRC | 07:20 | |
| *** spzala has quit IRC | 07:25 | |
| *** spzala has joined #openstack-keystone | 07:33 | |
| *** spzala has quit IRC | 07:38 | |
| *** spzala has joined #openstack-keystone | 07:45 | |
| *** pcaruana has joined #openstack-keystone | 07:48 | |
| *** spzala has quit IRC | 07:50 | |
| *** spzala has joined #openstack-keystone | 07:51 | |
| *** pcaruana has quit IRC | 07:55 | |
| *** pcaruana has joined #openstack-keystone | 07:55 | |
| *** spzala has quit IRC | 07:56 | |
| *** spzala has joined #openstack-keystone | 07:57 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 07:57 | |
| *** markvoelker has joined #openstack-keystone | 07:58 | |
| *** spzala has quit IRC | 08:01 | |
| *** cristicalin has joined #openstack-keystone | 08:04 | |
| *** spzala has joined #openstack-keystone | 08:06 | |
| *** hoonetorg has quit IRC | 08:10 | |
| *** spzala has quit IRC | 08:11 | |
| *** bigdogstl has joined #openstack-keystone | 08:12 | |
| *** cristicalin has quit IRC | 08:14 | |
| *** cristicalin has joined #openstack-keystone | 08:14 | |
| *** spzala has joined #openstack-keystone | 08:19 | |
| *** bigdogstl has quit IRC | 08:21 | |
| *** cristicalin has quit IRC | 08:22 | |
| *** cristicalin has joined #openstack-keystone | 08:22 | |
| *** spzala has quit IRC | 08:24 | |
| *** hoonetorg has joined #openstack-keystone | 08:26 | |
| *** tesseract has joined #openstack-keystone | 08:29 | |
| *** spzala has joined #openstack-keystone | 08:31 | |
| *** markvoelker has quit IRC | 08:32 | |
| *** spzala has quit IRC | 08:35 | |
| *** cristicalin has quit IRC | 08:41 | |
| *** mvk has joined #openstack-keystone | 08:44 | |
| *** rcernin has quit IRC | 08:45 | |
| *** spzala has joined #openstack-keystone | 08:50 | |
| *** spzala has quit IRC | 08:54 | |
| *** abhi89 has quit IRC | 08:56 | |
| *** edmondsw has joined #openstack-keystone | 08:58 | |
| *** annp has quit IRC | 09:01 | |
| *** daidv has quit IRC | 09:01 | |
| *** spzala has joined #openstack-keystone | 09:01 | |
| *** annp has joined #openstack-keystone | 09:01 | |
| *** daidv has joined #openstack-keystone | 09:01 | |
| *** edmondsw has quit IRC | 09:02 | |
| *** spzala has quit IRC | 09:06 | |
| *** bigdogstl has joined #openstack-keystone | 09:19 | |
| *** markvoelker has joined #openstack-keystone | 09:29 | |
| *** bigdogstl has quit IRC | 09:30 | |
| *** rcernin has joined #openstack-keystone | 09:40 | |
| *** mvk has quit IRC | 09:55 | |
| *** bigdogstl has joined #openstack-keystone | 09:57 | |
| *** markvoelker has quit IRC | 10:02 | |
| *** bigdogstl has quit IRC | 10:06 | |
| *** spzala has joined #openstack-keystone | 10:07 | |
| *** annp has quit IRC | 10:09 | |
| *** spzala has quit IRC | 10:12 | |
| *** spzala has joined #openstack-keystone | 10:21 | |
| *** spzala has quit IRC | 10:26 | |
| *** sambetts|afk is now known as sambetts | 10:28 | |
| *** bigdogstl has joined #openstack-keystone | 10:33 | |
| *** spzala has joined #openstack-keystone | 10:33 | |
| *** spzala has quit IRC | 10:37 | |
| *** bigdogstl has quit IRC | 10:38 | |
| *** zhurong has quit IRC | 10:43 | |
| *** mvk has joined #openstack-keystone | 10:43 | |
| *** spzala has joined #openstack-keystone | 10:53 | |
| *** belmoreira has joined #openstack-keystone | 10:56 | |
| *** efried has quit IRC | 10:56 | |
| *** dims has quit IRC | 10:57 | |
| *** spzala has quit IRC | 10:58 | |
| *** dims has joined #openstack-keystone | 10:58 | |
| *** markvoelker has joined #openstack-keystone | 11:00 | |
| *** spzala has joined #openstack-keystone | 11:02 | |
| *** bigdogstl has joined #openstack-keystone | 11:04 | |
| *** spzala has quit IRC | 11:07 | |
| *** bigdogstl has quit IRC | 11:14 | |
| *** spzala has joined #openstack-keystone | 11:14 | |
| *** spzala has quit IRC | 11:19 | |
| *** spzala has joined #openstack-keystone | 11:23 | |
| *** spzala has quit IRC | 11:28 | |
| *** spzala has joined #openstack-keystone | 11:30 | |
| *** markvoelker has quit IRC | 11:32 | |
| *** nicolasbock has joined #openstack-keystone | 11:33 | |
| *** spzala has quit IRC | 11:34 | |
| *** AlexeyAbashkin has quit IRC | 11:36 | |
| *** spzala has joined #openstack-keystone | 11:39 | |
| *** spzala has quit IRC | 11:44 | |
| *** bigdogstl has joined #openstack-keystone | 11:45 | |
| *** bigdogstl has quit IRC | 11:52 | |
| *** spzala has joined #openstack-keystone | 11:53 | |
| *** spzala has quit IRC | 11:58 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 12:02 | |
| *** spzala has joined #openstack-keystone | 12:06 | |
| *** AlexeyAbashkin has quit IRC | 12:06 | |
| openstackgerrit | Merged openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/534011 | 12:07 |
| *** spzala has quit IRC | 12:11 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 12:12 | |
| *** bigdogstl has joined #openstack-keystone | 12:13 | |
| *** rcernin has quit IRC | 12:14 | |
| *** spzala has joined #openstack-keystone | 12:20 | |
| openstackgerrit | Merged openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/534012 | 12:25 |
| *** spzala has quit IRC | 12:26 | |
| *** bigdogstl has quit IRC | 12:29 | |
| *** mvenesio has joined #openstack-keystone | 12:29 | |
| *** markvoelker has joined #openstack-keystone | 12:29 | |
| *** spzala has joined #openstack-keystone | 12:30 | |
| *** bigdogstl has joined #openstack-keystone | 12:31 | |
| *** edmondsw has joined #openstack-keystone | 12:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 12:34 |
| *** spzala has quit IRC | 12:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 12:37 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 12:37 |
| *** edmondsw has quit IRC | 12:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 12:39 |
| *** bigdogstl has quit IRC | 12:42 | |
| *** dave-mccowan has joined #openstack-keystone | 12:45 | |
| *** spzala has joined #openstack-keystone | 12:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 12:48 |
| *** spzala has quit IRC | 12:50 | |
| *** spzala has joined #openstack-keystone | 12:55 | |
| *** spzala has quit IRC | 12:59 | |
| *** markvoelker has quit IRC | 13:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 13:05 |
| *** spzala has joined #openstack-keystone | 13:09 | |
| *** nicolasbock has quit IRC | 13:11 | |
| *** spzala has quit IRC | 13:13 | |
| *** jmlowe_ has quit IRC | 13:14 | |
| *** jmlowe has joined #openstack-keystone | 13:18 | |
| *** markvoelker has joined #openstack-keystone | 13:21 | |
| *** bigdogstl has joined #openstack-keystone | 13:29 | |
| *** jmlowe has quit IRC | 13:30 | |
| *** jmlowe has joined #openstack-keystone | 13:31 | |
| *** spzala has joined #openstack-keystone | 13:35 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Add support for application credentials https://review.openstack.org/534455 | 13:37 |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Use stestr in tox.ini https://review.openstack.org/534763 | 13:38 |
| *** spzala has quit IRC | 13:39 | |
| *** bigdogstl has quit IRC | 13:40 | |
| *** panbalag has joined #openstack-keystone | 13:42 | |
| *** edmondsw has joined #openstack-keystone | 13:45 | |
| *** jmlowe has quit IRC | 13:47 | |
| *** jmlowe has joined #openstack-keystone | 13:48 | |
| *** spzala has joined #openstack-keystone | 13:59 | |
| *** aojea_ has joined #openstack-keystone | 14:02 | |
| *** spzala has quit IRC | 14:03 | |
| *** spzala has joined #openstack-keystone | 14:05 | |
| *** panbalag has left #openstack-keystone | 14:06 | |
| *** bigdogstl has joined #openstack-keystone | 14:09 | |
| *** spzala has quit IRC | 14:10 | |
| *** spzala has joined #openstack-keystone | 14:16 | |
| *** bigdogstl has quit IRC | 14:19 | |
| *** belmoreira has quit IRC | 14:20 | |
| *** spzala has quit IRC | 14:21 | |
| *** spzala has joined #openstack-keystone | 14:23 | |
| *** spzala has quit IRC | 14:28 | |
| *** spzala has joined #openstack-keystone | 14:31 | |
| *** josecastroleon has joined #openstack-keystone | 14:32 | |
| *** belmoreira has joined #openstack-keystone | 14:33 | |
| *** bigdogstl has joined #openstack-keystone | 14:35 | |
| *** spzala has quit IRC | 14:36 | |
| *** david-lyle has quit IRC | 14:37 | |
| *** bigdogstl has quit IRC | 14:46 | |
| *** spzala has joined #openstack-keystone | 14:46 | |
| lbragstad | is anyone interested in putting together or participating in an interview at the PTG? https://wiki.openstack.org/wiki/PTG/Rocky/Etherpads | 14:48 |
| lbragstad | it could be about a new feature or something we've done in Queens, etc... | 14:49 |
| *** spzala has quit IRC | 14:52 | |
| *** spzala has joined #openstack-keystone | 14:52 | |
| *** jaosorior has quit IRC | 15:00 | |
| *** jmlowe has quit IRC | 15:01 | |
| cmurphy | lbragstad: the sphinx jobs are going to be broken until https://review.openstack.org/#/c/534779/ merges | 15:02 |
| lbragstad | ouch | 15:03 |
| lbragstad | cmurphy: thanks for the heads up | 15:03 |
| lbragstad | cmurphy: responded here - https://review.openstack.org/#/c/529665/4 | 15:03 |
| cmurphy | lbragstad: oh that's neat | 15:04 |
| lbragstad | the decorator? | 15:04 |
| cmurphy | yeah | 15:05 |
| cmurphy | another ksa change https://review.openstack.org/#/c/534455/ not sure if this should be rushed in though | 15:06 |
| lbragstad | oh - nice | 15:06 |
| lbragstad | i'll review that today for sure | 15:06 |
| *** spilla has joined #openstack-keystone | 15:07 | |
| *** itlinux has quit IRC | 15:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 15:09 |
| *** bigdogstl has joined #openstack-keystone | 15:10 | |
| *** links has quit IRC | 15:11 | |
| *** efried_ has joined #openstack-keystone | 15:14 | |
| *** jmlowe has joined #openstack-keystone | 15:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 15:20 |
| *** mvenesio has quit IRC | 15:28 | |
| gagehugo | o/ | 15:29 |
| *** bigdogstl has quit IRC | 15:32 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Add support for application credentials https://review.openstack.org/534455 | 15:35 |
| *** bigdogstl has joined #openstack-keystone | 15:40 | |
| lbragstad | gagehugo: o/ | 15:40 |
| *** bigdogstl has quit IRC | 15:45 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystoneauth master: Implement system scope https://review.openstack.org/529665 | 15:50 |
| *** jaosorior has joined #openstack-keystone | 15:50 | |
| *** efried_ is now known as efried | 15:53 | |
| *** itlinux has joined #openstack-keystone | 15:57 | |
| *** itlinux_ has joined #openstack-keystone | 16:04 | |
| *** belmoreira has quit IRC | 16:06 | |
| *** itlinux has quit IRC | 16:06 | |
| *** bigdogstl has joined #openstack-keystone | 16:11 | |
| *** aojea_ has quit IRC | 16:17 | |
| *** aojea_ has joined #openstack-keystone | 16:17 | |
| *** bigdogstl has quit IRC | 16:21 | |
| *** aojea_ has quit IRC | 16:22 | |
| *** gyee has joined #openstack-keystone | 16:39 | |
| *** AlexeyAbashkin has quit IRC | 16:41 | |
| *** pcaruana has quit IRC | 16:46 | |
| SamYaple | do fernet tokens have a revocation backend? | 16:48 |
| *** david-lyle has joined #openstack-keystone | 16:49 | |
| SamYaple | i see OS-PKI/revoke is being called with a fernet backend in some tests and im unsure if that is even usable for fernet | 16:49 |
| *** bigdogstl has joined #openstack-keystone | 16:50 | |
| lbragstad | SamYaple: it isn't | 16:53 |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Add support for application credentials https://review.openstack.org/534455 | 16:53 |
| lbragstad | it's a left over api from when we could actually store tokens | 16:53 |
| lbragstad | well we do store tokens still, but... | 16:53 |
| SamYaple | thought so, i figure its just a bug in testing | 16:53 |
| lbragstad | there is a revocation backend in keystone, but it's only used internally to keystone | 16:54 |
| SamYaple | panicing some people with low fortitude.... | 16:54 |
| SamYaple | portdirect: ^ | 16:54 |
| lbragstad | end users invoke it when they revoke a specific token or change their password | 16:54 |
| *** bigdogstl has quit IRC | 16:55 | |
| SamYaple | does changing a password revoke *all* tokens issues for that user with the old password? or just the one token they used to change the password? | 16:55 |
| lbragstad | SamYaple: it creates a revocation event with an issued_before property | 16:56 |
| lbragstad | and it catches any tokens issued before that timestampe | 16:56 |
| lbragstad | timestamp* | 16:56 |
| SamYaple | got it. cool. that was my understanding of it. glad it wasnt totally wrong | 16:56 |
| lbragstad | so if you generate tokens A, B, and C then change your password, A, B, and C will all be considered invalid tokens | 16:57 |
| SamYaple | perfect | 16:57 |
| *** david-lyle has quit IRC | 17:02 | |
| *** david-lyle has joined #openstack-keystone | 17:03 | |
| *** david-lyle has quit IRC | 17:03 | |
| *** dklyle has joined #openstack-keystone | 17:03 | |
| lbragstad | cmurphy: so application credentials store an id and an application_credential_id? | 17:09 |
| lbragstad | and we replace the appilcation_credential_id with the id on the way out of the driver | 17:09 |
| lbragstad | oh - wait... i might be missing something.. | 17:11 |
| lbragstad | look at this - https://review.openstack.org/#/c/524928/28/keystone/application_credential/backends/sql.py,unified@91 | 17:12 |
| lbragstad | so - we're just taking the id from the request and setting it to the application_credential_id (which is what i assume to be a uuid4) | 17:12 |
| lbragstad | and then the id of the actual reference is an integer determined by sql on the insert? | 17:12 |
| cmurphy | lbragstad: yeah i need to take another look at that, i'm sure there's a cleaner way to do it | 17:15 |
| cmurphy | but yes id is integer and application_credential_id is uuid | 17:15 |
| lbragstad | got it - | 17:15 |
| lbragstad | ok that makes sense | 17:15 |
| lbragstad | i was thinking i was looking at the get_application_credential part | 17:15 |
| cmurphy | wondering if there's a sensible thing to rename the primary key column to rather than id | 17:16 |
| cmurphy | because the switcharound is confusing | 17:16 |
| cmurphy | maybe local_id | 17:17 |
| cmurphy | internal_id | 17:17 |
| cmurphy | idk | 17:17 |
| lbragstad | internal_id | 17:17 |
| lbragstad | wouldn't be bad... | 17:17 |
| cmurphy | ok | 17:17 |
| lbragstad | but this also seems specific to sql | 17:17 |
| cmurphy | sql_id | 17:17 |
| lbragstad | or our implementation of the sql backend | 17:17 |
| lbragstad | are application_credential.id and application_credential.application_credential_id both returned to the manager? | 17:18 |
| cmurphy | right now they are, probably shouldn't be | 17:18 |
| lbragstad | yeah... i think if that bit was solely handled in the driver, it makes the name of the internal id less important? | 17:19 |
| lbragstad | trying to think about this if i were writing a different backend that isn't sql | 17:20 |
| *** tesseract has quit IRC | 17:21 | |
| lbragstad | and if the manager expected a uuid in application_credential_id and an integer in id, if that'd be weird if the backend i was writing for didn't need an integer index | 17:22 |
| * lbragstad is probably overthinking things | 17:22 | |
| cmurphy | no i don't think you're overthinking | 17:22 |
| cmurphy | i think there's probably no reason to expose the internal sql id | 17:22 |
| lbragstad | ok | 17:23 |
| * cmurphy will fix | 17:23 | |
| lbragstad | so, the sql backend should accept a reference | 17:23 |
| lbragstad | and the only thing guaranteed in the reference is application_credential_id or id? | 17:23 |
| cmurphy | the uuid | 17:24 |
| cmurphy | which i'll rename back to id | 17:24 |
| lbragstad | the sql backend would pop the application_credential.id into the application_credential_id | 17:24 |
| lbragstad | and self populate the application_credential.id when doing the insert | 17:24 |
| cmurphy | i think there is sqlalchemy magic where if it's a primary key and an integer then it autoincrements | 17:25 |
| lbragstad | but then when getting and listing application credentials, the application_credential.id is popped off, and replaced with the application_credential.application_credential_id | 17:25 |
| lbragstad | aha - that sounds right | 17:25 |
| cmurphy | i think i'm going to change it so the internal id never makes it out of the driver, it'll only be used for the foreign key reference for the role table | 17:26 |
| lbragstad | cool - that will help | 17:26 |
| *** bigdogstl has joined #openstack-keystone | 17:27 | |
| lbragstad | then the manager doesn't have to worry about scrubbing attributes based on different backends (if that were to happen if another backend implementation ever happened) | 17:27 |
| cmurphy | yeah now that i see it from that perspective that would be weird | 17:27 |
| lbragstad | but the migration looks good to go1 | 17:28 |
| cmurphy | cool | 17:28 |
| * cmurphy afk for a bit | 17:28 | |
| lbragstad | cool - i'll probably wait to kick that through until the sphinx fix.. | 17:28 |
| lbragstad | i assume it would fail that | 17:29 |
| *** r-daneel has joined #openstack-keystone | 17:31 | |
| *** bigdogstl has quit IRC | 17:36 | |
| *** mvenesio has joined #openstack-keystone | 17:45 | |
| *** rabel has joined #openstack-keystone | 17:46 | |
| *** aojea has joined #openstack-keystone | 17:50 | |
| openstackgerrit | David Rabel proposed openstack/keystone master: Fix indentation in docs https://review.openstack.org/534860 | 17:55 |
| *** aojea_ has joined #openstack-keystone | 17:55 | |
| *** aojea has quit IRC | 17:58 | |
| *** aojea has joined #openstack-keystone | 18:01 | |
| *** dklyle has quit IRC | 18:02 | |
| *** aojea_ has quit IRC | 18:03 | |
| *** aojea_ has joined #openstack-keystone | 18:05 | |
| *** bigdogstl has joined #openstack-keystone | 18:07 | |
| *** aojea has quit IRC | 18:08 | |
| *** itlinux_ has quit IRC | 18:10 | |
| *** itlinux has joined #openstack-keystone | 18:10 | |
| *** aojea has joined #openstack-keystone | 18:11 | |
| kmalloc | lbragstad: id should be filtered out | 18:11 |
| kmalloc | and should never make it to the end user | 18:11 |
| kmalloc | app_cred_id is like user_id | 18:11 |
| kmalloc | and usable externally as a reference | 18:11 |
| lbragstad | right | 18:12 |
| lbragstad | so - i think what cmurphy and i came to earlier was that application_credential.id is an implementation detail of the sql backend | 18:13 |
| *** aojea_ has quit IRC | 18:13 | |
| lbragstad | and all the logic to handle the marshalling of that attribute and application_credential.application_credential_id should be handled in the driver and not the manager | 18:14 |
| *** aojea_ has joined #openstack-keystone | 18:15 | |
| lbragstad | kmalloc: cmurphy and i have a couple ksa patches up if you'd like to take a look when you have time | 18:15 |
| kmalloc | ok | 18:16 |
| kmalloc | i would also not use "id" in the public facing REST bodys | 18:16 |
| *** bigdogstl has quit IRC | 18:16 | |
| kmalloc | i'd use application_credential_id or similar | 18:16 |
| kmalloc | and yes, id is an internal "implementation detail" | 18:16 |
| *** aojea has quit IRC | 18:19 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 18:20 | |
| *** aojea has joined #openstack-keystone | 18:21 | |
| cmurphy | kmalloc: you would not use "id" in the REST body? all of our api resources use "id" | 18:22 |
| *** bigdogstl has joined #openstack-keystone | 18:22 | |
| cmurphy | where by "id" i mean the uuid | 18:22 |
| kmalloc | ok *shrug* | 18:23 |
| kmalloc | be consistent | 18:23 |
| *** aojea_ has quit IRC | 18:23 | |
| *** AlexeyAbashkin has quit IRC | 18:25 | |
| *** aojea_ has joined #openstack-keystone | 18:25 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add application credentials db migration https://review.openstack.org/524927 | 18:28 |
| *** aojea has quit IRC | 18:28 | |
| *** bigdogstl has quit IRC | 18:31 | |
| *** aojea has joined #openstack-keystone | 18:31 | |
| *** sambetts is now known as sambetts|afk | 18:33 | |
| *** aojea_ has quit IRC | 18:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient master: Updated from global requirements https://review.openstack.org/534025 | 18:35 |
| *** bigdogstl has joined #openstack-keystone | 18:39 | |
| *** aojea has quit IRC | 18:39 | |
| *** openstackstatus has quit IRC | 18:40 | |
| *** openstackstatus has joined #openstack-keystone | 18:41 | |
| *** ChanServ sets mode: +v openstackstatus | 18:41 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add application credentials driver https://review.openstack.org/524928 | 18:44 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials manager https://review.openstack.org/524747 | 18:44 |
| *** AlexeyAbashkin has joined #openstack-keystone | 18:47 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add application credentials driver https://review.openstack.org/524928 | 18:48 |
| *** rmcall_ has joined #openstack-keystone | 18:51 | |
| *** AlexeyAbashkin has quit IRC | 18:52 | |
| *** mvenesio has quit IRC | 18:55 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Handle TODO for using new_user_ref https://review.openstack.org/534879 | 18:58 |
| *** mvk has quit IRC | 19:02 | |
| *** david-lyle has joined #openstack-keystone | 19:02 | |
| *** jmlowe has quit IRC | 19:06 | |
| *** jmlowe has joined #openstack-keystone | 19:07 | |
| *** david-lyle has quit IRC | 19:08 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Make entries in policy_mapping.rst consistent https://review.openstack.org/534885 | 19:17 |
| *** bigdogst_ has joined #openstack-keystone | 19:18 | |
| *** bigdogstl has quit IRC | 19:22 | |
| *** mvenesio has joined #openstack-keystone | 19:23 | |
| *** bigdogst_ has quit IRC | 19:26 | |
| *** bigdogstl has joined #openstack-keystone | 19:31 | |
| *** bigdogstl has quit IRC | 19:36 | |
| *** mvenesio has quit IRC | 19:40 | |
| *** mvenesio has joined #openstack-keystone | 19:40 | |
| *** david-lyle has joined #openstack-keystone | 19:43 | |
| *** bigdogstl has joined #openstack-keystone | 19:48 | |
| *** mvk has joined #openstack-keystone | 19:50 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add application credentials driver https://review.openstack.org/524928 | 19:57 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials manager https://review.openstack.org/524747 | 19:57 |
| *** bigdogstl has quit IRC | 19:59 | |
| lbragstad | once https://review.openstack.org/#/c/534779/ is through we should be able to start approving the application credential series pending everyone is ok with the id change bit | 20:00 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials manager https://review.openstack.org/524747 | 20:02 |
| openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Add support for application credentials https://review.openstack.org/534455 | 20:05 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials manager https://review.openstack.org/524747 | 20:08 |
| *** dstanek has quit IRC | 20:14 | |
| *** bigdogstl has joined #openstack-keystone | 20:15 | |
| *** rmascena has joined #openstack-keystone | 20:19 | |
| *** raildo has quit IRC | 20:21 | |
| *** bigdogstl has quit IRC | 20:28 | |
| -openstackstatus- NOTICE: Zuul will be offline for a few minutes; existing changes will be re-enqueued; approvals during the downtime will need to be re-added. | 20:39 | |
| *** KeithMnemonic has joined #openstack-keystone | 20:43 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Handle TODO notes for using new_user_ref https://review.openstack.org/534879 | 20:43 |
| gagehugo | dangit | 20:43 |
| *** bigdogstl has joined #openstack-keystone | 20:48 | |
| *** rmascena has quit IRC | 20:51 | |
| *** KeithMnemonic has quit IRC | 20:52 | |
| *** bigdogstl has quit IRC | 20:53 | |
| *** bigdogstl has joined #openstack-keystone | 20:56 | |
| *** aojea has joined #openstack-keystone | 21:00 | |
| *** bigdogstl has quit IRC | 21:04 | |
| *** aojea_ has joined #openstack-keystone | 21:05 | |
| *** aojea has quit IRC | 21:08 | |
| *** aojea has joined #openstack-keystone | 21:09 | |
| *** aojea_ has quit IRC | 21:13 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials manager https://review.openstack.org/524747 | 21:13 |
| *** aojea_ has joined #openstack-keystone | 21:15 | |
| *** aojea has quit IRC | 21:18 | |
| *** spilla has left #openstack-keystone | 21:19 | |
| *** spilla has joined #openstack-keystone | 21:19 | |
| *** bigdogstl has joined #openstack-keystone | 21:20 | |
| *** aojea has joined #openstack-keystone | 21:21 | |
| *** aojea_ has quit IRC | 21:23 | |
| *** aojea_ has joined #openstack-keystone | 21:25 | |
| *** bigdogstl has quit IRC | 21:27 | |
| *** aojea has quit IRC | 21:28 | |
| *** aojea has joined #openstack-keystone | 21:30 | |
| *** rmcall_ has quit IRC | 21:31 | |
| *** spilla has quit IRC | 21:32 | |
| *** aojea_ has quit IRC | 21:33 | |
| *** spilla has joined #openstack-keystone | 21:35 | |
| *** aojea_ has joined #openstack-keystone | 21:35 | |
| *** mvenesio has quit IRC | 21:36 | |
| *** aojea has quit IRC | 21:38 | |
| *** aojea has joined #openstack-keystone | 21:41 | |
| *** spilla has left #openstack-keystone | 21:42 | |
| *** spilla has joined #openstack-keystone | 21:42 | |
| lbragstad | https://review.openstack.org/#/c/524307/12 and https://review.openstack.org/#/c/524407/12 should be ready for some reviews | 21:43 |
| *** threestrands_ has joined #openstack-keystone | 21:44 | |
| *** aojea_ has quit IRC | 21:44 | |
| *** threestrands_ has quit IRC | 21:45 | |
| *** threestrands_ has joined #openstack-keystone | 21:45 | |
| *** threestrands_ has quit IRC | 21:45 | |
| *** threestrands_ has joined #openstack-keystone | 21:45 | |
| *** aojea_ has joined #openstack-keystone | 21:45 | |
| *** aojea_ has quit IRC | 21:45 | |
| * gagehugo takes a look | 21:48 | |
| *** aojea has quit IRC | 21:48 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add Application Credentials controller https://review.openstack.org/524423 | 21:49 |
| *** bigdogstl has joined #openstack-keystone | 21:56 | |
| *** david-lyle has quit IRC | 22:00 | |
| *** rcernin has joined #openstack-keystone | 22:02 | |
| lbragstad | gagehugo: i didn't even have to bribe you! | 22:03 |
| *** rmcall_ has joined #openstack-keystone | 22:06 | |
| gagehugo | lbragstad left a comment on https://review.openstack.org/#/c/524407/ | 22:06 |
| gagehugo | cmurphy haha I was confused as well, thought I was missing something re: 404 | 22:07 |
| *** bigdogstl has quit IRC | 22:08 | |
| lbragstad | gagehugo: awesome - thanks | 22:08 |
| gagehugo | is malformed url a 400? | 22:09 |
| gagehugo | but that's not directly tied to that call | 22:09 |
| cmurphy | i think a malformed url would cause a not found | 22:10 |
| cmurphy | i'm not sure what would cause a bad request other than malformed json | 22:11 |
| *** bigdogstl has joined #openstack-keystone | 22:11 | |
| * cmurphy gives up on using numbers | 22:11 | |
| gagehugo | yeah idk | 22:11 |
| *** rmcall_ has quit IRC | 22:14 | |
| *** bigdogstl has quit IRC | 22:16 | |
| *** itlinux has quit IRC | 22:17 | |
| gagehugo | does https://review.openstack.org/#/c/533880/ need to pass before the docs gate works? Not sure if upper-constraints has sphinx 1.6.6 blocked or not | 22:19 |
| cmurphy | the openstack/requirements fix updated upper-constraints so i think we're fine | 22:24 |
| gagehugo | ok cool | 22:36 |
| *** rmcall_ has joined #openstack-keystone | 22:50 | |
| *** david-lyle has joined #openstack-keystone | 22:51 | |
| openstackgerrit | Colleen Murphy proposed openstack/python-keystoneclient master: WIP Add CRUD support for application credentials https://review.openstack.org/534965 | 22:53 |
| *** spilla has quit IRC | 22:58 | |
| *** edmondsw has quit IRC | 23:02 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add system role assignment documentation https://review.openstack.org/524307 | 23:06 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add ability to list all system role assignments https://review.openstack.org/524407 | 23:06 |
| *** bigdogstl has joined #openstack-keystone | 23:07 | |
| lbragstad | gagehugo: cmurphy i addressed your comments in the first patch - but i'm still working on gagehugo's assertion comment | 23:07 |
| lbragstad | on the second patch | 23:07 |
| *** r-daneel has quit IRC | 23:11 | |
| *** bigdogstl has quit IRC | 23:15 | |
| cmurphy | lbragstad: mmk | 23:24 |
| cmurphy | lbragstad: will look first thing tomorrow | 23:24 |
| lbragstad | cmurphy: thanks and no worries | 23:25 |
| *** rmcall_ has quit IRC | 23:32 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add application credential auth plugin https://review.openstack.org/525346 | 23:47 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add ability to list all system role assignments https://review.openstack.org/524407 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Teach TokenFormatter how to handle system scope https://review.openstack.org/525330 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement system-scope in the token provider API https://review.openstack.org/525360 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Introduce assertions for system-scoped token testing https://review.openstack.org/528037 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement system-scoped tokens https://review.openstack.org/525687 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Add release note for system-scope https://review.openstack.org/528039 | 23:54 |
| lbragstad | gagehugo: fixed the assertions ^ | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Update documentation to reflect system-scope https://review.openstack.org/530133 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Grant admin a role on the system during bootstrap https://review.openstack.org/530410 | 23:54 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement GET /v3/auth/system https://review.openstack.org/530490 | 23:54 |
| * lbragstad runs away to find dinner | 23:55 | |
| gagehugo | cool | 23:57 |
| *** gyee has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!