| *** edmonds__ has joined #openstack-keystone | 00:00 | |
| *** edmondsw_ has quit IRC | 00:01 | |
| *** edmondsw_ has joined #openstack-keystone | 00:01 | |
| *** edmondsw_ has quit IRC | 00:01 | |
| *** edmondsw_ has joined #openstack-keystone | 00:02 | |
| *** edmonds__ has quit IRC | 00:04 | |
| *** edmondsw_ has quit IRC | 00:26 | |
| *** edmondsw has joined #openstack-keystone | 00:29 | |
| *** edmondsw has quit IRC | 00:31 | |
| *** edmondsw has joined #openstack-keystone | 00:31 | |
| *** edmondsw has quit IRC | 00:36 | |
| *** Shunli has joined #openstack-keystone | 00:49 | |
| *** thorst_afk has joined #openstack-keystone | 00:51 | |
| jamielennox | kmalloc: my opinion - part of the problem of the dependency manager ATM is the magic handling of all this stuff. There are not that many of them, and their dependencies are basically static. | 00:52 |
|---|---|---|
| jamielennox | just declare them somewhere and use them as normal objects that interact | 00:52 |
| jamielennox | if you are looking for somewhere semi-global to put them you can always hang them off the context object | 00:52 |
| *** zhurong has joined #openstack-keystone | 00:52 | |
| jamielennox | less magic in that area would be preferable to better magic | 00:53 |
| *** thorst_afk has quit IRC | 00:59 | |
| *** masber has quit IRC | 01:01 | |
| *** masber has joined #openstack-keystone | 01:02 | |
| kmalloc | jamielennox: right. so my *main* plan is just have anything that is an API use a metaclass that makes it an api | 01:18 |
| kmalloc | jamielennox: then either a decorator or inheritance for "can use APIs" | 01:18 |
| kmalloc | and it gets .<blah>_api as a property | 01:18 |
| kmalloc | no more "init has to happen first" | 01:18 |
| kmalloc | etc. | 01:19 |
| kmalloc | not more @dependency.provider() decorators | 01:19 |
| jamielennox | kmalloc: i'm still unsure why we just can't declare them as singletons or something | 01:19 |
| jamielennox | i mean they're basically globally defined singletons now, just wrapped behind some global dicts | 01:20 |
| jamielennox | it would be good to be a bit smarter than that - but not hugely so | 01:20 |
| kmalloc | well, that is effectively what i'm doing. just making it a property folks reference. | 01:20 |
| kmalloc | it could be something more global like server.manager_apis.<blah_api> | 01:21 |
| kmalloc | the question is, do we want things to be able to do still do self.<blah_api> | 01:21 |
| kmalloc | or really not care? | 01:21 |
| kmalloc | either way I can use a chunk of the code i wrote for this. | 01:21 |
| * kmalloc is trying to avoid needing to do something like @provider | 01:22 | |
| kmalloc | decorators we *can* just infer it is supposed to be a _manager_api by the nature of it being a manager ;) | 01:23 |
| jamielennox | kmalloc: ok, i mean i'm in favour of simplifying it and the self.X is fine - i just get nervous with the metaclasses and stuff | 01:24 |
| jamielennox | even when that code went it i was pretty sure we didn't really need java style dependency injection | 01:24 |
| jamielennox | and i'm still not sure there's a benefit to it | 01:25 |
| jamielennox | but simpler is better | 01:25 |
| *** mjax has quit IRC | 01:29 | |
| *** mjax has joined #openstack-keystone | 01:30 | |
| kmalloc | lets not do the self.X thing | 01:31 |
| kmalloc | we'll do it as a global thing | 01:32 |
| *** mjax has quit IRC | 01:33 | |
| *** aselius has quit IRC | 01:37 | |
| *** edmondsw has joined #openstack-keystone | 01:40 | |
| *** edmondsw has quit IRC | 01:44 | |
| *** mjax has joined #openstack-keystone | 01:46 | |
| *** aahh has quit IRC | 01:47 | |
| *** mjax has quit IRC | 01:48 | |
| *** spzala has quit IRC | 01:50 | |
| *** otleimat has quit IRC | 01:57 | |
| *** thorst_afk has joined #openstack-keystone | 02:00 | |
| *** thorst_afk has quit IRC | 02:06 | |
| *** dave-mccowan has quit IRC | 02:32 | |
| *** masber has quit IRC | 02:53 | |
| *** thorst_afk has joined #openstack-keystone | 03:01 | |
| *** thorst_afk has quit IRC | 03:06 | |
| *** itlinux has joined #openstack-keystone | 03:13 | |
| *** mjax has joined #openstack-keystone | 03:50 | |
| *** mjax has quit IRC | 03:52 | |
| *** thorst_afk has joined #openstack-keystone | 04:02 | |
| *** links has joined #openstack-keystone | 04:03 | |
| *** thorst_afk has quit IRC | 04:07 | |
| *** masber has joined #openstack-keystone | 04:08 | |
| *** gyee has quit IRC | 04:09 | |
| *** hoonetorg has quit IRC | 04:11 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 04:16 | |
| *** Dinesh_Bhor has left #openstack-keystone | 04:16 | |
| *** itlinux has quit IRC | 04:19 | |
| *** zhurong has quit IRC | 04:21 | |
| *** hoonetorg has joined #openstack-keystone | 04:23 | |
| *** zhurong has joined #openstack-keystone | 04:56 | |
| *** thorst_afk has joined #openstack-keystone | 05:03 | |
| *** kornicameister has quit IRC | 05:03 | |
| *** thorst_afk has quit IRC | 05:08 | |
| *** cfriesen has quit IRC | 05:10 | |
| *** burnz1 has joined #openstack-keystone | 05:14 | |
| *** burnz has quit IRC | 05:16 | |
| *** Shunli has quit IRC | 05:22 | |
| *** Shunli has joined #openstack-keystone | 05:22 | |
| *** thorst_afk has joined #openstack-keystone | 06:03 | |
| *** thorst_afk has quit IRC | 06:09 | |
| *** aojea has joined #openstack-keystone | 06:32 | |
| *** aojea has quit IRC | 06:32 | |
| *** aojea has joined #openstack-keystone | 06:32 | |
| *** pcaruana has joined #openstack-keystone | 06:39 | |
| *** thorst_afk has joined #openstack-keystone | 07:05 | |
| *** rcernin has joined #openstack-keystone | 07:10 | |
| *** thorst_afk has quit IRC | 07:10 | |
| *** zhurong has quit IRC | 07:15 | |
| *** aojea has quit IRC | 07:17 | |
| *** zhurong has joined #openstack-keystone | 07:17 | |
| *** tesseract has joined #openstack-keystone | 07:25 | |
| *** aojea has joined #openstack-keystone | 07:29 | |
| *** ioggstream has joined #openstack-keystone | 07:32 | |
| *** edmondsw has joined #openstack-keystone | 07:40 | |
| *** aojea has quit IRC | 07:41 | |
| *** edmondsw has quit IRC | 07:45 | |
| *** edmondsw has joined #openstack-keystone | 07:49 | |
| *** thorst_afk has joined #openstack-keystone | 08:05 | |
| *** alex_xu has quit IRC | 08:06 | |
| *** thorst_afk has quit IRC | 08:10 | |
| *** alex_xu has joined #openstack-keystone | 08:12 | |
| *** slunkad has quit IRC | 08:13 | |
| *** slunkad has joined #openstack-keystone | 08:14 | |
| *** edmondsw has quit IRC | 08:29 | |
| *** ioggstream has quit IRC | 08:45 | |
| *** aojea has joined #openstack-keystone | 08:47 | |
| *** ioggstream has joined #openstack-keystone | 09:00 | |
| *** thorst_afk has joined #openstack-keystone | 09:06 | |
| *** thorst_afk has quit IRC | 09:11 | |
| *** Shunli has quit IRC | 09:26 | |
| *** edmondsw has joined #openstack-keystone | 09:35 | |
| *** edmondsw has quit IRC | 09:47 | |
| *** sapd has quit IRC | 09:56 | |
| *** sapd has joined #openstack-keystone | 09:57 | |
| openstackgerrit | Sami Makki proposed openstack/oslo.policy master: Add JSON output option to sample generator https://review.openstack.org/491629 | 10:02 |
| *** sapd has quit IRC | 10:17 | |
| *** sapd has joined #openstack-keystone | 10:33 | |
| *** zhurong has quit IRC | 10:35 | |
| *** zxy has quit IRC | 10:47 | |
| *** zxy has joined #openstack-keystone | 10:48 | |
| *** thorst_afk has joined #openstack-keystone | 11:07 | |
| *** thorst_afk has quit IRC | 11:12 | |
| *** lwanderley has joined #openstack-keystone | 11:14 | |
| *** raildo has joined #openstack-keystone | 11:25 | |
| *** zhurong has joined #openstack-keystone | 11:34 | |
| *** edmondsw has joined #openstack-keystone | 11:48 | |
| *** edmondsw has quit IRC | 11:52 | |
| *** rmascena has joined #openstack-keystone | 12:00 | |
| *** Dave has quit IRC | 12:02 | |
| *** lwanderley has quit IRC | 12:02 | |
| *** raildo has quit IRC | 12:03 | |
| *** dave-mccowan has joined #openstack-keystone | 12:05 | |
| *** thorst_afk has joined #openstack-keystone | 12:06 | |
| *** lwanderley has joined #openstack-keystone | 12:15 | |
| *** lwanderley has quit IRC | 12:27 | |
| *** lwanderley has joined #openstack-keystone | 12:30 | |
| *** zhurong has quit IRC | 12:36 | |
| *** obre has quit IRC | 12:39 | |
| *** obre has joined #openstack-keystone | 12:40 | |
| *** obre has quit IRC | 12:42 | |
| *** obre has joined #openstack-keystone | 12:42 | |
| *** lucasxu has joined #openstack-keystone | 12:42 | |
| *** lwanderley has quit IRC | 12:44 | |
| *** obre has quit IRC | 12:45 | |
| *** obre has joined #openstack-keystone | 12:46 | |
| *** zhurong has joined #openstack-keystone | 12:50 | |
| *** lwanderley has joined #openstack-keystone | 12:55 | |
| *** hoonetorg has quit IRC | 13:08 | |
| *** hoonetorg has joined #openstack-keystone | 13:09 | |
| *** links has quit IRC | 13:18 | |
| *** catintheroof has joined #openstack-keystone | 13:19 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| catintheroof | guys, im having this error http://paste.openstack.org/show/619682/ when using keystoneauth1 == 3.1.0 and keystonemiddleware == 4.14.0 on python 3.5.4 (im using memcache_security_strategy=ENCRYPT and memcache_secret_key ) | 13:23 |
| catintheroof | any hint ? | 13:23 |
| *** belmoreira has joined #openstack-keystone | 13:26 | |
| *** rreimberg has joined #openstack-keystone | 13:40 | |
| *** dave-mccowan has joined #openstack-keystone | 13:41 | |
| *** edmondsw has joined #openstack-keystone | 13:49 | |
| *** edmondsw has quit IRC | 13:53 | |
| *** zhurong has quit IRC | 14:03 | |
| *** cfriesen has joined #openstack-keystone | 14:18 | |
| *** zxy has quit IRC | 14:21 | |
| *** rbrndt has joined #openstack-keystone | 14:25 | |
| lbragstad | catintheroof: that looks like it's isolated to keystonemiddleware? | 14:26 |
| catintheroof | lbragstad: looks like it, yes, if i switch to python 2.7 works | 14:27 |
| *** aojea has quit IRC | 14:30 | |
| lbragstad | catintheroof: there are differences between str and bytes and str and unicode between python 2 and 3 | 14:31 |
| lbragstad | catintheroof: we've had to fix parts of that in keystone before | 14:31 |
| lbragstad | it was something along the lines of https://github.com/openstack/keystone/blob/master/keystone/common/utils.py#L70 ? | 14:32 |
| *** chlong has joined #openstack-keystone | 14:41 | |
| *** jamesbenson has joined #openstack-keystone | 14:41 | |
| *** edmondsw has joined #openstack-keystone | 14:42 | |
| knikolla | o/ | 14:48 |
| *** itlinux has joined #openstack-keystone | 14:49 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement global scoping of tokens https://review.openstack.org/498577 | 14:53 |
| *** josecastroleon has joined #openstack-keystone | 14:54 | |
| *** edmondsw has quit IRC | 14:54 | |
| *** edmondsw has joined #openstack-keystone | 14:58 | |
| *** edmondsw has quit IRC | 15:02 | |
| *** lwanderley has quit IRC | 15:05 | |
| lbragstad | zzzeek: ping - i'm seeing something interesting with dogpile that i can't quite figure out | 15:11 |
| zzzeek | lbragstad: hi | 15:11 |
| lbragstad | zzzeek: have a minute for a quick question? | 15:11 |
| zzzeek | lbragstad: yes | 15:11 |
| lbragstad | zzzeek: awesome - so in keystone we do this https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L39-L45 | 15:12 |
| lbragstad | which builds cache region so that we can cache the assignments for a user based on various scopes | 15:12 |
| lbragstad | (project/domain) | 15:12 |
| lbragstad | like so - https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L94 | 15:12 |
| zzzeek | lbragstad: OK....is that...oslo.cache ? | 15:13 |
| lbragstad | zzzeek: yeah - we have a keystone.common.cache which uses oslo.cache which uses dogpile | 15:13 |
| lbragstad | when we delete a role, we invalidate the entire COMPUTED_ASSIGNMENTS_REGION - https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L1177 | 15:14 |
| *** itlinux has quit IRC | 15:15 | |
| lbragstad | but - regardless of caching being enabled or COMPUTED_ASSIGNMENTS_REGION being invalidated - the role assignments are still being returned | 15:16 |
| lbragstad | here's my test case | 15:16 |
| lbragstad | v | 15:16 |
| lbragstad | http://paste.openstack.org/show/619782/ | 15:16 |
| lbragstad | and this is my output http://paste.openstack.org/show/619783/ | 15:16 |
| zzzeek | lbragstad: this is many levels above what I can identify, is the basic issue you're trying to invalidate something and it's not invalidated ? | 15:18 |
| lbragstad | zzzeek: correct | 15:18 |
| zzzeek | lbragstad: how are you testing that it is invalidated ? | 15:18 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement global scoping of tokens https://review.openstack.org/498577 | 15:19 |
| lbragstad | zzzeek: i have test case in there | 15:19 |
| lbragstad | let me grab a link | 15:19 |
| lbragstad | https://review.openstack.org/#/c/498577/8/keystone/tests/unit/test_v3_auth.py at line 794 | 15:19 |
| zzzeek | lbragstad: your test is using various keystone API calls I'm unfamiliar with | 15:19 |
| zzzeek | lbragstad: also I dont see how you do the actual invalidate | 15:19 |
| lbragstad | the basic gist of the test is that i'm getting a token based on a role assignment | 15:20 |
| lbragstad | then i delete the role (which should invalidate the cache) | 15:20 |
| lbragstad | and then i try to validate the token and assert it is invalid | 15:20 |
| zzzeek | lbragstad: OK "invalidate the cache" how is that done | 15:20 |
| lbragstad | line 824 https://review.openstack.org/#/c/498577/8/keystone/tests/unit/test_v3_auth.py | 15:21 |
| lbragstad | makes a call to delete a role | 15:21 |
| *** gyee has joined #openstack-keystone | 15:21 | |
| lbragstad | which enters into this method https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L1171 | 15:21 |
| lbragstad | and right before we exit that method - we attempt to invalidate the COMPUTED_ASSIGNMENTS_REGION https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L1177 | 15:21 |
| lbragstad | cc kmalloc ^ | 15:22 |
| zzzeek | lbragstad: OK region.invalidate() is local to a single Python process, it sets a timestamp in the local region object. it will not carry over to other regions in other processes | 15:23 |
| lbragstad | ahhh | 15:24 |
| zzzeek | lbragstad: you can change the invalidation strategy, if for example you wanted to store the invalidation timestamp in the cache itself | 15:24 |
| lbragstad | is that timestamp read automatically when items are fetched from the cache? | 15:26 |
| kmalloc | zzzeek: oooh hi | 15:28 |
| kmalloc | zzzeek: looking at cache stuff? | 15:28 |
| kmalloc | zzzeek: we had a way that pushed that invalidate into the cache itself | 15:29 |
| lbragstad | kmalloc: he's giving me a hand with a few cache questions | 15:29 |
| kmalloc | i don't know if the code landed or not | 15:29 |
| lbragstad | kmalloc: it sounds like we need that | 15:29 |
| kmalloc | i am almost 100% we implemented it | 15:29 |
| lbragstad | kmalloc: see the test case implemented at line 794 https://review.openstack.org/#/c/498577/8/keystone/tests/unit/test_v3_auth.py | 15:29 |
| lbragstad | kmalloc: http://paste.openstack.org/show/619783/ is the resulting output | 15:30 |
| lbragstad | which clearly shows the role being returned after it was deleted | 15:30 |
| kmalloc | this was supposed to be it... https://github.com/openstack/keystone/blob/master/keystone/common/cache/core.py#L56 | 15:30 |
| kmalloc | i think | 15:30 |
| kmalloc | with https://github.com/openstack/keystone/blob/master/keystone/common/cache/core.py#L31 | 15:31 |
| kmalloc | but... that code looks off | 15:31 |
| lbragstad | kmalloc: that's what we seem to be using - https://github.com/openstack/keystone/blob/master/keystone/common/cache/core.py#L134 | 15:31 |
| kmalloc | like i said, something is a bit off there. | 15:32 |
| kmalloc | as in... i don't know how the heck that should ever work. | 15:32 |
| kmalloc | that kindof totally misses the point | 15:32 |
| kmalloc | someone did a poor job of implementing this | 15:33 |
| kmalloc | =/ | 15:33 |
| kmalloc | basically afaict that never actually invalidates anything | 15:34 |
| lbragstad | hmm | 15:35 |
| kmalloc | this looks half implemented | 15:36 |
| *** aojea has joined #openstack-keystone | 15:37 | |
| *** aojea has quit IRC | 15:41 | |
| *** lwanderley has joined #openstack-keystone | 15:44 | |
| lbragstad | i remember us talking about cache invalidation strategies in Austin during a midcycle | 15:44 |
| *** lwanderley has quit IRC | 15:45 | |
| *** aselius has joined #openstack-keystone | 15:48 | |
| * breton sees something about caches | 15:49 | |
| breton | what doesn't work? | 15:49 |
| *** burnz1 has quit IRC | 15:49 | |
| *** otleimat has joined #openstack-keystone | 15:49 | |
| *** burnz has joined #openstack-keystone | 15:50 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement global scoping of tokens https://review.openstack.org/498577 | 15:51 |
| breton | invalidation works by generating new region id | 15:51 |
| breton | and all queries to cache key go through key mangler, which inserts region id | 15:53 |
| breton | and that region id is stored in memcache | 15:54 |
| *** edmondsw has joined #openstack-keystone | 15:54 | |
| *** edmondsw_ has joined #openstack-keystone | 15:58 | |
| *** edmondsw has quit IRC | 15:58 | |
| *** edmondsw_ has quit IRC | 16:00 | |
| *** thorst_afk has quit IRC | 16:01 | |
| *** lwanderley has joined #openstack-keystone | 16:05 | |
| *** thorst_afk has joined #openstack-keystone | 16:05 | |
| *** lwanderley has quit IRC | 16:06 | |
| openstackgerrit | Omar Tleimat proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 16:14 |
| *** tesseract has quit IRC | 16:15 | |
| lbragstad | breton: so that test case should pass, but it doesn't | 16:18 |
| *** itlinux has joined #openstack-keystone | 16:23 | |
| *** lwanderley has joined #openstack-keystone | 16:25 | |
| *** lwanderley has quit IRC | 16:26 | |
| *** thorst_a_ has joined #openstack-keystone | 16:28 | |
| *** thorst_afk has quit IRC | 16:32 | |
| *** efried has quit IRC | 16:40 | |
| *** ioggstream has quit IRC | 16:42 | |
| *** lwanderley has joined #openstack-keystone | 16:44 | |
| *** rcernin has quit IRC | 16:46 | |
| *** belmoreira has quit IRC | 16:46 | |
| *** itlinux has quit IRC | 16:48 | |
| *** pcaruana has quit IRC | 16:48 | |
| *** itlinux has joined #openstack-keystone | 16:49 | |
| *** dave-mccowan has quit IRC | 16:50 | |
| *** thorst_a_ has quit IRC | 16:51 | |
| *** thorst_afk has joined #openstack-keystone | 16:52 | |
| *** efried has joined #openstack-keystone | 16:53 | |
| *** links has joined #openstack-keystone | 16:55 | |
| *** thorst_afk has quit IRC | 16:56 | |
| *** kbaegis has joined #openstack-keystone | 16:57 | |
| *** thorst_afk has joined #openstack-keystone | 17:04 | |
| *** mjax has joined #openstack-keystone | 17:08 | |
| *** kbaegis has quit IRC | 17:19 | |
| *** rbrndt has quit IRC | 17:21 | |
| efried | mordred Have you had a chance to look at the UT for https://review.openstack.org/#/c/491947/ yet? | 17:31 |
| *** kbaegis has joined #openstack-keystone | 17:32 | |
| *** links has quit IRC | 17:34 | |
| mordred | efried: no, sorry :( | 17:36 |
| lbragstad | kmalloc: breton ok - i have a new revision coming that updates the test and actually makes it pass circumstantially | 17:38 |
| lbragstad | I removed the ability to cache the response for getting global role assignments | 17:38 |
| kmalloc | lbragstad: okie | 17:39 |
| lbragstad | running all tests now | 17:39 |
| *** Dave has joined #openstack-keystone | 17:42 | |
| *** spilla has joined #openstack-keystone | 17:45 | |
| *** rreimberg has quit IRC | 17:47 | |
| *** catintheroof has quit IRC | 17:49 | |
| *** edmondsw has joined #openstack-keystone | 17:54 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Implement global scoping of tokens https://review.openstack.org/498577 | 17:55 |
| lbragstad | kmalloc: ^ | 17:55 |
| gagehugo | cmurphy we migrated the installation docs from openstack-manuals correct? | 17:57 |
| *** aojea has joined #openstack-keystone | 17:57 | |
| *** edmondsw_ has joined #openstack-keystone | 17:58 | |
| *** edmondsw has quit IRC | 17:59 | |
| *** edmondsw_ has quit IRC | 17:59 | |
| *** edmondsw has joined #openstack-keystone | 18:00 | |
| cmurphy | gagehugo: yes | 18:00 |
| *** lucasxu has quit IRC | 18:01 | |
| kmalloc | cmurphy: you'll be at PTG? | 18:06 |
| kmalloc | cmurphy: right? | 18:06 |
| cmurphy | kmalloc: yep | 18:07 |
| kmalloc | cmurphy: good. i hope to have some fun things to talk over that I want your input on | 18:07 |
| * kmalloc will also force lbragstad to join the convo ;) | 18:07 | |
| *** edmondsw has quit IRC | 18:07 | |
| cmurphy | kmalloc: yay | 18:08 |
| kmalloc | i have to write up a document (white paperish) and get some internal feedback. | 18:08 |
| kmalloc | hope to have that in order before the PTG. | 18:08 |
| kmalloc | ugh, why is it so hard to find 1300w-1600w PSUs for ... less than crazy $ | 18:09 |
| kmalloc | (i know why... just...) | 18:09 |
| *** rbrndt has joined #openstack-keystone | 18:12 | |
| *** catintheroof has joined #openstack-keystone | 18:23 | |
| *** edmondsw has joined #openstack-keystone | 18:23 | |
| *** edmondsw has quit IRC | 18:27 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 18:35 |
| *** edmondsw has joined #openstack-keystone | 18:41 | |
| *** lwanderley has quit IRC | 18:44 | |
| efried | mordred Well shit man, I've just banged my head against it for another hour and I can't follow all these mocks and nested calls. | 18:45 |
| *** edmondsw has quit IRC | 18:45 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Add new tags attribute to project https://review.openstack.org/470317 | 18:47 |
| gagehugo | ping amrith | 18:50 |
| *** aojea has quit IRC | 18:55 | |
| lbragstad | #startmeeting keystone-office-hours | 19:00 |
| openstack | Meeting started Tue Aug 29 19:00:04 2017 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 19:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 19:00 |
| openstack | The meeting name has been set to 'keystone_office_hours' | 19:00 |
| *** edmondsw has joined #openstack-keystone | 19:03 | |
| cmurphy | lbragstad: what's the link to your dashboard for bug related reviews? | 19:03 |
| *** edmondsw has quit IRC | 19:04 | |
| *** edmondsw has joined #openstack-keystone | 19:07 | |
| *** edmondsw has quit IRC | 19:08 | |
| gagehugo | I'm looking into what OSM did for https://review.openstack.org/#/c/498605/ | 19:14 |
| lbragstad | cmurphy: https://goo.gl/6137Q5 | 19:15 |
| hrybacki | lbragstad: okay it looks like the evening install guide bit didn't catch traction. But they are dedicating Thursday morning or afternoon to that topic alone | 19:24 |
| lbragstad | hrybacki: is there a schedule somewhere for Thursday? | 19:25 |
| hrybacki | lbragstad: https://etherpad.openstack.org/p/docs-i18n-ptg-queens | 19:25 |
| hrybacki | it's not quite as filled out as ours is atm | 19:26 |
| *** mjax has quit IRC | 19:27 | |
| *** catintheroof has quit IRC | 19:30 | |
| *** dave-mccowan has joined #openstack-keystone | 19:35 | |
| *** catintheroof has joined #openstack-keystone | 19:36 | |
| *** edmondsw has joined #openstack-keystone | 19:55 | |
| *** edmondsw has quit IRC | 19:56 | |
| *** mjax has joined #openstack-keystone | 20:01 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Copy specific distro pages for install guide https://review.openstack.org/498605 | 20:03 |
| *** belmoreira has joined #openstack-keystone | 20:04 | |
| gagehugo | cmurphy https://github.com/openstack/openstack-manuals/commit/c7bfdbb44f15ec481f256ba57724ff47f16b3e43 | 20:05 |
| gagehugo | looks like OSM has some scripts for handling the duplicate pages | 20:05 |
| cmurphy | gagehugo: ah so we are supposed to keep duplicates now? | 20:06 |
| gagehugo | I kinda hacked the one users page into an inc and included it rather than copying the same file 3 times in ^ | 20:08 |
| gagehugo | I wonder if we want to copy that script over | 20:08 |
| cmurphy | okay neat | 20:08 |
| *** edmondsw has joined #openstack-keystone | 20:08 | |
| *** edmondsw has quit IRC | 20:13 | |
| mjax | lbragstad: Do you know if domain specific token providers is a possibility? | 20:19 |
| gagehugo | cmurphy yeah I think I like the "pick your distro" approach better | 20:31 |
| lbragstad | mjax: not that i am aware of | 20:33 |
| *** rmascena has quit IRC | 20:33 | |
| otleimat | cmurphy: For this, https://review.openstack.org/#/c/408304/, are those changes redundant? Also tried to extend test coverage | 20:39 |
| lbragstad | mjax: there is only one token provider configured per keystone node | 20:40 |
| cmurphy | otleimat: i'm not sure, i don't see a whole lot of difference in the output with or without the change, with different combinations of parameters, but i may be misunderstanding something | 20:44 |
| otleimat | cmurphy: Yeah, thats's a good point. Since it doesn't fail silently, then the changes in cli.py don't really do anything extra except change the --help msg and subjectively clean up the code? | 20:48 |
| otleimat | cmurphy: The unit tests should probably be there in some form though | 20:49 |
| cmurphy | ++ to tests | 20:50 |
| otleimat | cmurphy: what do you prefer I do with it? Revert the changes in cli.py and then refactor the unit tests? | 20:58 |
| otleimat | actually unit tests don't need to be changed. Should all pass with original code | 21:00 |
| openstackgerrit | Samuel Pilla proposed openstack/python-keystoneclient master: Add project tags to keystoneclient https://review.openstack.org/481223 | 21:06 |
| *** aojea has joined #openstack-keystone | 21:12 | |
| cmurphy | otleimat: yeah that seems to me like the right way to go, it's definitely good to keep the MappingPurge tests | 21:17 |
| *** thorst_afk has quit IRC | 21:22 | |
| *** thorst_afk has joined #openstack-keystone | 21:23 | |
| *** thorst_afk has quit IRC | 21:27 | |
| *** spilla has quit IRC | 21:32 | |
| *** catintheroof has quit IRC | 21:34 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Copy specific distro pages for install guide https://review.openstack.org/498605 | 21:34 |
| lbragstad | gagehugo: ^ works for me locally | 21:45 |
| lbragstad | gagehugo: thanks | 21:45 |
| gagehugo | lbragstad I think it's kinda hacky, but it looks like the alternative is to copy over the tool scripts which also looks messy | 21:47 |
| lbragstad | yeah | 21:48 |
| lbragstad | let have cmurphy take another look | 21:48 |
| lbragstad | let's* | 21:48 |
| *** belmoreira has quit IRC | 21:49 | |
| *** thorst_afk has joined #openstack-keystone | 21:49 | |
| *** aojea has quit IRC | 21:51 | |
| *** thorst_afk has quit IRC | 21:53 | |
| *** jamesbenson has quit IRC | 21:57 | |
| cmurphy | gagehugo: lbragstad yep looks good to me | 21:57 |
| *** jamesbenson has joined #openstack-keystone | 21:58 | |
| lbragstad | #endmeeting | 21:59 |
| openstack | Meeting ended Tue Aug 29 21:59:08 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-29-19.00.html | 21:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-29-19.00.txt | 21:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2017/keystone_office_hours.2017-08-29-19.00.log.html | 21:59 |
| *** jamesben_ has joined #openstack-keystone | 22:00 | |
| *** jamesbenson has quit IRC | 22:02 | |
| *** edmondsw has joined #openstack-keystone | 22:02 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Refactor removal of duplicate projects/domains https://review.openstack.org/491574 | 22:03 |
| *** edmondsw has quit IRC | 22:04 | |
| *** edmondsw has joined #openstack-keystone | 22:04 | |
| *** jamesben_ has quit IRC | 22:04 | |
| *** cfriesen has quit IRC | 22:06 | |
| *** cfriesen has joined #openstack-keystone | 22:07 | |
| *** cfriesen has quit IRC | 22:12 | |
| *** itlinux has quit IRC | 22:14 | |
| *** dtroyer has quit IRC | 22:14 | |
| *** cfriesen has joined #openstack-keystone | 22:18 | |
| *** lbragstad has quit IRC | 22:20 | |
| *** edmondsw has quit IRC | 22:23 | |
| *** cfriesen_ has joined #openstack-keystone | 22:24 | |
| *** cfriesen has quit IRC | 22:24 | |
| *** edmondsw has joined #openstack-keystone | 22:41 | |
| *** dtroyer has joined #openstack-keystone | 22:44 | |
| *** edmondsw has quit IRC | 22:45 | |
| *** edmondsw has joined #openstack-keystone | 22:58 | |
| *** rbrndt has quit IRC | 22:59 | |
| *** edmondsw has quit IRC | 23:03 | |
| *** cfriesen_ has quit IRC | 23:11 | |
| *** cfriesen_ has joined #openstack-keystone | 23:17 | |
| *** feefifo has joined #openstack-keystone | 23:21 | |
| *** spzala has joined #openstack-keystone | 23:33 | |
| *** spzala has quit IRC | 23:33 | |
| *** jmlowe has joined #openstack-keystone | 23:43 | |
| *** kbaegis has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!