Thursday, 2017-06-08

*** adriant has quit IRC00:02
*** adriant has joined #openstack-keystone00:03
*** adriant has quit IRC00:16
*** matteus has joined #openstack-keystone00:18
*** matteus has quit IRC00:23
*** r-daneel has quit IRC00:26
*** adriant has joined #openstack-keystone00:26
*** adriant_ has joined #openstack-keystone00:26
*** adriant_ has quit IRC00:26
*** ayoung has joined #openstack-keystone00:30
*** masber has quit IRC00:32
*** masber has joined #openstack-keystone00:32
*** lbragstad has joined #openstack-keystone00:37
*** ChanServ sets mode: +o lbragstad00:37
*** Shunli has joined #openstack-keystone00:48
*** liujiong has joined #openstack-keystone01:04
*** thorst_afk has joined #openstack-keystone01:14
*** piliman974 has quit IRC01:15
*** piliman974 has joined #openstack-keystone01:17
*** thorst_afk has quit IRC01:19
*** shuyingya has joined #openstack-keystone01:32
*** shuyingya has quit IRC01:32
*** shuyingya has joined #openstack-keystone01:33
openstackgerritayoung proposed openstack/keystone-specs master: Application Credentials for application authn  https://review.openstack.org/45041501:35
*** xuhaigang has joined #openstack-keystone01:40
*** xuhaigang has quit IRC01:41
*** lbragstad has quit IRC01:42
*** xuhaigang has joined #openstack-keystone01:46
*** shuyingya has quit IRC01:46
*** shuyingya has joined #openstack-keystone01:47
*** thorst_afk has joined #openstack-keystone01:47
*** zhurong has joined #openstack-keystone01:48
*** xuhaigang has quit IRC01:58
*** shuyingya has quit IRC02:01
*** jamielennox is now known as jamielennox|away02:04
*** xuhaigang has joined #openstack-keystone02:11
*** thorst_afk has joined #openstack-keystone02:12
*** thorst_afk has quit IRC02:12
*** jamielennox|away is now known as jamielennox02:15
openstackgerritGage Hugo proposed openstack/keystone master: Prep for is_admin_project for scoped operations  https://review.openstack.org/46267002:16
*** xuhaigang has quit IRC02:24
gagehugoayoung ^02:26
*** gyee has quit IRC02:27
*** edmondsw has joined #openstack-keystone02:55
*** edmondsw has quit IRC02:59
*** ducttape_ has joined #openstack-keystone03:01
*** ducttape_ has quit IRC03:05
*** thorst_afk has joined #openstack-keystone03:13
*** dikonoor has joined #openstack-keystone03:17
*** thorst_afk has quit IRC03:32
*** links has joined #openstack-keystone03:34
*** zsli_ has joined #openstack-keystone03:36
*** Shunli has quit IRC03:39
*** zhurong has quit IRC03:45
*** dikonoor has quit IRC03:48
*** namnh has joined #openstack-keystone04:04
*** piliman974 has quit IRC04:12
*** dave-mccowan has quit IRC04:26
*** thorst_afk has joined #openstack-keystone04:29
*** pcaruana has joined #openstack-keystone04:31
*** aselius has quit IRC04:32
*** zhurong has joined #openstack-keystone04:34
*** thorst_afk has quit IRC04:37
*** pcaruana has quit IRC04:57
*** jaosorior_away is now known as jaosorior05:05
*** jamielennox is now known as jamielennox|away05:12
*** jamielennox|away is now known as jamielennox05:19
*** xuhaigang has joined #openstack-keystone05:24
*** aojea has joined #openstack-keystone05:26
*** shuyingya has joined #openstack-keystone05:38
*** jamielennox is now known as jamielennox|away05:56
*** tobberydberg has joined #openstack-keystone05:56
*** dikonoor has joined #openstack-keystone05:58
*** jamielennox|away is now known as jamielennox06:03
*** aojea has quit IRC06:07
*** rcernin has joined #openstack-keystone06:15
*** thorst_afk has joined #openstack-keystone06:29
*** shuyingya has quit IRC06:31
*** zhurong has quit IRC06:32
*** natanbro has joined #openstack-keystone06:33
*** sjain has joined #openstack-keystone06:33
*** thorst_afk has quit IRC06:34
*** shuyingy_ has joined #openstack-keystone06:38
*** natanbro has quit IRC06:40
*** namnh_ has joined #openstack-keystone06:45
*** namnh has quit IRC06:47
*** sjain has quit IRC06:47
*** namnh_ has quit IRC06:51
*** pcaruana has joined #openstack-keystone06:57
*** xuhaigang has quit IRC06:59
*** piliman974 has joined #openstack-keystone07:01
*** tesseract has joined #openstack-keystone07:12
*** aojea has joined #openstack-keystone07:22
*** thorst_afk has joined #openstack-keystone07:30
*** xuhaigang has joined #openstack-keystone07:31
*** piliman974 has quit IRC07:31
*** thorst_afk has quit IRC07:35
*** jaosorior has quit IRC07:42
*** nicolasbock has joined #openstack-keystone07:45
*** sjain has joined #openstack-keystone07:45
*** zhurong has joined #openstack-keystone07:47
*** jaosorior has joined #openstack-keystone07:54
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-keystone08:01
*** zhurong has quit IRC08:13
*** zhurong has joined #openstack-keystone08:14
*** namnh has joined #openstack-keystone08:25
*** links has quit IRC08:25
*** thorst_afk has joined #openstack-keystone08:31
*** frickler_ is now known as frickler08:36
*** shuyingy_ has quit IRC08:38
*** links has joined #openstack-keystone08:38
*** shuyingya has joined #openstack-keystone08:38
*** shuying__ has joined #openstack-keystone08:43
*** shuyingya has quit IRC08:47
*** odyssey4me_ is now known as odyssey4me08:49
*** thorst_afk has quit IRC08:50
*** mvk has joined #openstack-keystone09:02
*** sjain has quit IRC09:16
*** zsli_ has quit IRC09:32
*** gongysh has joined #openstack-keystone09:32
*** thorst_afk has joined #openstack-keystone09:47
*** thorst_afk has quit IRC09:51
*** liujiong has quit IRC10:06
*** shuying__ has quit IRC10:10
*** shuyingy_ has joined #openstack-keystone10:10
*** piliman974 has joined #openstack-keystone10:20
*** markvoelker has quit IRC10:27
*** markvoelker has joined #openstack-keystone10:27
*** nishaYadav has joined #openstack-keystone10:29
*** med_ has quit IRC10:31
*** cristicalin has joined #openstack-keystone10:31
*** cristicalin has quit IRC10:33
*** med_ has joined #openstack-keystone10:35
*** med_ is now known as Guest7261210:35
*** dikonoor has quit IRC10:43
*** raildo has joined #openstack-keystone10:51
*** nishaYadav has quit IRC10:54
*** sjain has joined #openstack-keystone10:59
*** shuying__ has joined #openstack-keystone11:00
*** shuyingy_ has quit IRC11:03
*** nishaYadav has joined #openstack-keystone11:08
ayounggagehugo, I think it has to.11:13
ayounggagehugo, pretty sure that the two patches touch the same code. But, with the merge of all the pre-req work, maybe no.11:13
ayoungOrder them as you see fit, so long as they can all land in some sequence.  It is often easier to have them depend on each other if they are touching the same subsystems, even if there is no strict dependency between them11:14
*** aojea has quit IRC11:15
*** mvk has quit IRC11:16
*** dikonoor has joined #openstack-keystone11:23
*** shuying__ has quit IRC11:24
*** shuyingy_ has joined #openstack-keystone11:24
*** dikonoor has quit IRC11:33
*** shuying__ has joined #openstack-keystone11:35
*** dikonoor has joined #openstack-keystone11:36
*** shuying__ has quit IRC11:36
*** shuyingy_ has quit IRC11:37
*** shuying__ has joined #openstack-keystone11:37
*** gongysh has quit IRC11:37
*** shuyingya has joined #openstack-keystone11:38
*** edmondsw has joined #openstack-keystone11:40
*** shuying__ has quit IRC11:41
*** dikonoor has quit IRC11:45
*** thorst_afk has joined #openstack-keystone11:46
*** mvk has joined #openstack-keystone11:47
*** shuyingya has quit IRC11:49
*** dikonoor has joined #openstack-keystone11:49
*** shuyingya has joined #openstack-keystone11:50
*** shuying__ has joined #openstack-keystone11:51
*** shuying__ has quit IRC11:53
*** shuyingy_ has joined #openstack-keystone11:53
*** shuyingya has quit IRC11:54
*** shuyin___ has joined #openstack-keystone12:03
*** piliman974 has quit IRC12:05
*** shuyin___ has quit IRC12:06
*** shuying__ has joined #openstack-keystone12:06
*** shuyingy_ has quit IRC12:06
*** piliman974 has joined #openstack-keystone12:07
*** pkoraca has quit IRC12:08
*** sjain has quit IRC12:13
*** piliman974 has quit IRC12:16
*** piliman974 has joined #openstack-keystone12:17
*** shuyingy_ has joined #openstack-keystone12:26
*** shuying__ has quit IRC12:29
*** catintheroof has joined #openstack-keystone12:32
*** namnh has quit IRC12:33
*** shuyingy_ has quit IRC12:34
*** shuyingya has joined #openstack-keystone12:35
*** shuyingya has quit IRC12:35
*** zhurong has quit IRC12:36
*** shuyingya has joined #openstack-keystone12:36
*** shuyingya has quit IRC12:37
*** shuyingya has joined #openstack-keystone12:37
*** shuyingya has quit IRC12:42
*** nishaYadav_ has joined #openstack-keystone12:45
*** nishaYadav has quit IRC12:47
*** piliman974 has quit IRC12:56
samueldmqgood13:01
samueldmqmorning!13:01
*** cristicalin has joined #openstack-keystone13:03
cmurphyo/13:04
*** aojea has joined #openstack-keystone13:08
*** ducttape_ has joined #openstack-keystone13:12
*** dave-mccowan has joined #openstack-keystone13:12
*** ducttap__ has joined #openstack-keystone13:14
*** links has quit IRC13:15
*** lucasxu has joined #openstack-keystone13:16
*** ducttape_ has quit IRC13:17
*** nishaYadav_ has quit IRC13:18
*** sjain has joined #openstack-keystone13:31
*** sjain has quit IRC13:35
*** lucasxu has quit IRC13:38
*** lucasxu has joined #openstack-keystone13:40
*** lucasxu has quit IRC13:51
*** ducttape_ has joined #openstack-keystone13:55
*** ducttap__ has quit IRC13:56
*** lucasxu has joined #openstack-keystone14:02
*** chlong has joined #openstack-keystone14:02
*** spzala has joined #openstack-keystone14:04
*** phalmos has joined #openstack-keystone14:05
*** phalmos_ has joined #openstack-keystone14:07
*** dikonoor has quit IRC14:09
*** spzala has quit IRC14:10
*** phalmos has quit IRC14:10
*** nishaYadav has joined #openstack-keystone14:10
*** aojea has quit IRC14:12
*** lbragstad has joined #openstack-keystone14:14
*** ChanServ sets mode: +o lbragstad14:14
*** r-daneel has joined #openstack-keystone14:17
gagehugoayoung ok14:25
*** shuyingya has joined #openstack-keystone14:26
openstackgerritLance Bragstad proposed openstack/keystone-specs master: Specification for global roles  https://review.openstack.org/46476314:26
*** aojea has joined #openstack-keystone14:34
*** aojea has quit IRC14:36
*** nishaYadav has quit IRC14:37
*** shuyingya has quit IRC14:39
*** aojea has joined #openstack-keystone14:40
*** shuyingya has joined #openstack-keystone14:40
openstackgerritPavlo Shchelokovskyy proposed openstack/keystoneauth master: Add 'none' identity plugin  https://review.openstack.org/46986314:42
*** aselius has joined #openstack-keystone14:46
*** tobberydberg has quit IRC14:46
*** shuyingya has quit IRC14:46
*** shuyingya has joined #openstack-keystone14:47
*** nishaYadav has joined #openstack-keystone14:49
*** nishaYadav is now known as Guest6570514:50
*** shuyingya has quit IRC14:51
*** spzala has joined #openstack-keystone14:54
openstackgerritLance Bragstad proposed openstack/keystone-specs master: Add policy roadmap for security  https://review.openstack.org/46273315:06
*** lbragstad has quit IRC15:08
*** aojea has quit IRC15:12
*** sjain has joined #openstack-keystone15:13
*** rcernin has quit IRC15:16
*** Guest65705 is now known as nishaYadav_15:16
*** aojea has joined #openstack-keystone15:32
sjainHi, I made this change https://review.openstack.org/#/c/471714/2 and I'm getting this jenkins failure http://logs.openstack.org/14/471714/2/check/gate-tempest-dsvm-py35-ubuntu-xenial/4f21a8a/console.html, can someone please have a look and help in debugging, thanks :)15:34
*** piliman974 has joined #openstack-keystone15:41
*** gyee has joined #openstack-keystone15:42
*** nishaYadav_ has quit IRC15:50
*** clayton has quit IRC15:51
*** aojea has quit IRC15:53
*** dikonoor has joined #openstack-keystone15:54
*** clayton has joined #openstack-keystone15:54
*** tobberydberg has joined #openstack-keystone15:55
*** lbragstad has joined #openstack-keystone15:57
*** ChanServ sets mode: +o lbragstad15:57
samueldmqsjain: just update the parent patch15:57
samueldmqthat failure seems to be unrelated15:57
samueldmq:-)15:57
*** gyee has quit IRC15:58
*** tobberydberg has quit IRC15:59
*** jaosorior has quit IRC16:00
knikollao/16:14
*** piliman974 has quit IRC16:16
*** gyee has joined #openstack-keystone16:16
mordredmorgan, cmurphy, samueldmq: https://review.openstack.org/#/q/status:open+project:openstack/keystoneauth+branch:master+topic:version-discovery is updated based on comments (didn't announce in channel for some reason)16:21
morganthnx16:22
cmurphythanks mordred16:22
mordredmorgan: great question on "are you sure you want this to be public" - I _think_ so - but lemme mull for a little bit16:23
samueldmqmordred: thanks! I owe you reviews16:23
morganmordred: i prefer to err on the side of private until it needs to be public16:23
mordredsamueldmq: also, you'll be happy to know we got identity version discovery landed in shade, so further work on ksc-ectomy is less painful now16:23
morganmordred: but i ask since new interfaces are very long lived in KSA16:24
mordredmorgan: yah. me too - in this case it was driven by "there is this powerful mechanism for fetching discovery documents that leverages a cache" but it was obscure to get to16:24
samueldmqmordred: oh great, with that work on ksa ? ^16:24
samueldmqmordred: or did it come by other means?16:24
mordredmorgan: otoh - if we finish this stack, people shouldn't need to do that16:24
cmurphymordred: do you have any thoughts on the latest revisions and comments on https://review.openstack.org/#/c/450415/ (api keys)?16:25
mordredsamueldmq: by other means - similar mechanism (it uses the existing ksa stuff) - but it should result in the same rest calls once we adopt the above stack16:25
mordredcmurphy: ooh, I should go read that16:25
cmurphythanks :)16:25
samueldmqmordred: which means samueldmq can finish restifying keystone calls in shade16:25
* samueldmq acknowledges that :)16:26
*** raildo has quit IRC16:28
dimslbragstad : don't see you on -release channel ... can you please +1 https://review.openstack.org/#/c/472259/16:29
*** tesseract has quit IRC16:32
lbragstadsamueldmq: sjain you were both working on documentation stuff recently, right?16:36
samueldmqlbragstad: yes16:37
lbragstadsamueldmq: sjain this is going to be useful for you then - https://review.openstack.org/#/c/472275/316:38
lbragstad^ that's the plan forward with docs and organization of various guides within each of the project repositories16:38
*** piliman974 has joined #openstack-keystone16:39
*** raildo has joined #openstack-keystone16:39
*** raildo has quit IRC16:42
*** raildo has joined #openstack-keystone16:42
*** clayton has quit IRC16:43
*** clayton has joined #openstack-keystone16:46
mordredcmurphy: thanks. responded16:48
*** sjain has quit IRC16:51
*** lwanderley has joined #openstack-keystone16:55
samueldmqlbragstad: awesome! it's great to have some direction in that front16:59
samueldmqthanks!!16:59
*** rderose has joined #openstack-keystone16:59
*** pcaruana has quit IRC17:00
*** lwanderley has quit IRC17:06
*** rderose has quit IRC17:07
*** lwanderley has joined #openstack-keystone17:08
openstackgerritSamriddhi proposed openstack/keystone master: Move role policies to DocumentedRuleDefault  https://review.openstack.org/44925117:09
*** raildo has quit IRC17:11
*** sjain has joined #openstack-keystone17:11
*** lwanderley has quit IRC17:12
lbragstadbreton: are you still interested in a pluggable fernet backend?17:13
*** lucasxu has quit IRC17:14
sjainthanks lbragstad, will surely look into it :)17:14
*** aojea has joined #openstack-keystone17:14
*** lwanderley has joined #openstack-keystone17:16
*** raildo has joined #openstack-keystone17:16
*** aojea has quit IRC17:19
*** nishaYadav has joined #openstack-keystone17:20
*** nishaYadav is now known as Guest6361817:20
*** lwanderley has quit IRC17:21
*** phalmos_ has quit IRC17:22
*** lwanderley has joined #openstack-keystone17:22
*** phalmos has joined #openstack-keystone17:22
samueldmqsjain: the patch is looking great, thanks17:22
samueldmqlbragstad: cmurphy: sjain updated  https://review.openstack.org/449251 for us :D17:23
*** Guest63618 has quit IRC17:25
*** sjain_ has joined #openstack-keystone17:25
cmurphyyay thanks sjain17:27
*** sjain has quit IRC17:28
*** sjain has joined #openstack-keystone17:29
*** sjain_ has quit IRC17:31
sjaincmurphy: no problem :)17:32
morganlbragstad: what is a "pluggable" fernet backend17:37
*** nicolasbock has quit IRC17:37
lbragstadmorgan: we had a spec proposed a while back to make the fernet key store pluggable17:37
lbragstadso that it was possible to put keys in something other than on disk17:37
morganoh17:38
morganthat17:38
lbragstadmorgan: it ended up going into a rabbit hole with all the different options and what-not17:39
lbragstadmorgan: but - i'm wondering if http://lists.openstack.org/pipermail/openstack-dev/2017-June/118074.html would be worth it17:39
*** p_arch has quit IRC17:46
*** ducttape_ has quit IRC17:53
*** nicolasbock has joined #openstack-keystone17:53
*** lucasxu has joined #openstack-keystone18:00
*** aojea has joined #openstack-keystone18:02
*** raildo has quit IRC18:03
*** raildo has joined #openstack-keystone18:12
*** aojea has quit IRC18:22
*** tobberydberg has joined #openstack-keystone18:22
*** mvk has quit IRC18:24
*** spzala has quit IRC18:29
*** spzala has joined #openstack-keystone18:29
*** spzala has quit IRC18:33
*** ducttape_ has joined #openstack-keystone18:35
*** dikonoor has quit IRC18:35
*** tobberydberg has quit IRC18:45
*** nicolasbock has quit IRC18:45
*** lwanderley has quit IRC18:47
*** nicolasbock has joined #openstack-keystone18:48
*** nicolasbock has quit IRC18:50
*** nicolasbock has joined #openstack-keystone18:50
*** spzala has joined #openstack-keystone18:53
*** dave-mccowan has quit IRC18:58
*** tobberydberg has joined #openstack-keystone19:00
*** cristicalin has quit IRC19:00
*** nicolasbock has quit IRC19:00
*** dave-mccowan has joined #openstack-keystone19:02
*** raildo has quit IRC19:03
*** raildo has joined #openstack-keystone19:03
*** nicolasbock has joined #openstack-keystone19:05
mordredcmurphy: so - your comment on patch one makes me realize that the method in question is added in patch one and had originally been removed in patch 2 until that looked like a breaking change19:15
mordredcmurphy: so Im gonna restack again19:15
cmurphymordred: lol okay19:15
*** nicolasbock has quit IRC19:18
*** ducttape_ has quit IRC19:18
*** ducttap__ has joined #openstack-keystone19:18
*** nicolasbock has joined #openstack-keystone19:18
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Expose getting EndpointData on adapter and session  https://review.openstack.org/46909119:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add support for version ranges  https://review.openstack.org/46909019:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Support explicitly requesting the 'latest' version  https://review.openstack.org/46908919:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add flags to turn discovery on and off  https://review.openstack.org/46908819:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Plumb endpoint_override through get_endpoint_data  https://review.openstack.org/46909219:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Rename discover_versions to fetch_version_info  https://review.openstack.org/47027519:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add returning EndpointData objects from discovery  https://review.openstack.org/46908419:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Optimize matching version no microversion needed  https://review.openstack.org/47027419:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Rework EndpointData construction to normalize catalog first  https://review.openstack.org/46908519:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Move version discovery logic to keystoneauth1.discover  https://review.openstack.org/46908619:19
openstackgerritMonty Taylor proposed openstack/keystoneauth master: Add url manipulation and microversion collection  https://review.openstack.org/46908719:19
mordredcmurphy: ok. there you go - that should be a bit cleaner to read now19:19
*** ducttape_ has joined #openstack-keystone19:19
cmurphymordred: cool19:20
*** matteus has joined #openstack-keystone19:20
*** ducttape_ has quit IRC19:21
openstackgerritLance Bragstad proposed openstack/keystone-specs master: Add backlogged spec for etcd support  https://review.openstack.org/47238519:22
*** ducttape_ has joined #openstack-keystone19:22
*** nicolasbock has quit IRC19:23
*** ducttap__ has quit IRC19:23
*** ducttape_ has quit IRC19:24
*** ducttape_ has joined #openstack-keystone19:25
*** mvk has joined #openstack-keystone19:41
openstackgerritGage Hugo proposed openstack/keystone master: Add project tags api-ref document  https://review.openstack.org/47239619:59
*** harlowja has quit IRC20:08
openstackgerritGage Hugo proposed openstack/keystone master: Add project tags api-ref document and reno  https://review.openstack.org/47239620:19
openstackgerritColleen Murphy proposed openstack/keystone-specs master: Application Credentials for application authn  https://review.openstack.org/45041520:19
*** cheran has joined #openstack-keystone20:23
cherangagehugo: Anyone working on implementing this spec https://review.openstack.org/#/c/431785/20:26
gagehugocheran yup, spilla has a WIP up right now20:33
gagehugohttps://review.openstack.org/#/c/470317/20:33
*** spilla has joined #openstack-keystone20:35
spillai heard talk of project tags from afar20:35
gagehugospilla felt a disturbance in the force?20:37
*** tobberydberg has quit IRC20:41
bretonlbragstad: i am interested, but i don't have time to code keystone now. I really hope it's gonna change in the next couple of months though.20:44
*** raildo has quit IRC20:44
*** piliman974 has quit IRC20:57
cherangagehugo: We have a similar implemenation as exactly as Tags proposed in that spec20:57
cheranIt's a keystone extension20:58
gagehugocheran oh nice20:59
*** piliman974 has joined #openstack-keystone20:59
*** thorst_afk has quit IRC21:02
*** thorst_afk has joined #openstack-keystone21:04
*** thorst_afk has quit IRC21:09
*** sjain has quit IRC21:10
*** lucasxu has quit IRC21:11
cherangagehugo So with some small changes we can actually upstream our implementation...21:16
*** thorst_afk has joined #openstack-keystone21:27
*** spilla has quit IRC21:29
*** thorst_afk has quit IRC21:31
*** spzala has quit IRC21:44
*** catintheroof has quit IRC21:50
*** chlong has quit IRC21:53
*** edmondsw has quit IRC22:02
*** timss has joined #openstack-keystone22:04
*** dave-mccowan has quit IRC22:05
*** cheran has quit IRC22:21
*** ducttape_ has quit IRC22:25
*** ducttape_ has joined #openstack-keystone22:26
*** ducttape_ has quit IRC22:30
*** piliman974 has quit IRC22:39
*** piliman974 has joined #openstack-keystone22:41
*** tobberydberg has joined #openstack-keystone22:42
*** tobberydberg has quit IRC22:46
openstackgerritMorgan Fainberg proposed openstack/keystoneauth master: Fix removed "Self"  https://review.openstack.org/47246923:02
openstackgerritMorgan Fainberg proposed openstack/keystoneauth master: Fix removed "Self"  https://review.openstack.org/47246923:02
morganmordred, cmurphy: ^23:03
morganfixed the "removed" self23:03
lbragstadmordred: cmurphy i went through the latest revision of the application credentials spec23:06
lbragstadmordred: cmurphy mostly minor nits, otherwise bang-up job getting that knocked out23:06
*** piliman974 has quit IRC23:11
*** piliman974 has joined #openstack-keystone23:13
morganmordred: ^ minor nit in the GETs23:23
morganotherwise just some simple comments and mostly agreeing with lbragstad23:23
openstackgerritJamie Lennox proposed openstack/keystoneauth master: Port the missing version data discovery tests from ksc  https://review.openstack.org/45828623:29
jamielennoxmorgan: i -1ed the self fix - how long's that been there? i consider it a broken implementation as is and so we can fix it23:30
morganif it has been released ever w/ self23:32
morgani'm going to say we can't fix, because someone may have implemented on top of it23:32
morganand relied on that23:32
morgansimple. the previous fix cannot land as is if we have *ever* released with that23:33
morganjamielennox: https://github.com/openstack/keystoneauth/blob/2.21.0/keystoneauth1/access/service_catalog.py#L55-L5623:34
morganit has been released like that23:34
morganKSA contract explicitly says we will not break public interfaces/behavior ever... except in a serious security fix23:34
morganjamielennox: so... we need to maintain the "brokeness"23:34
*** markvoelker has quit IRC23:34
jamielennoxmorgan: damn, it's old23:34
morganyeah23:35
jamielennoxhttps://github.com/openstack/keystoneauth/blob/2.1.0/keystoneauth1/access/service_catalog.py#L55-L5623:35
morganoh man23:35
morganjamielennox: https://github.com/openstack/keystoneauth/blob/1.0.0/keystoneauth1/access/service_catalog.py#L55-L5623:36
morganit was like that in 1.023:36
jamielennoxmorgan: however it's overriden in both catalogv2 and v3 right ?23:36
morganright. but someone may otherwise override it.23:36
morganit is a public interface23:36
morganas it sits23:36
morgan=/23:36
morganit's being really nit picky to not fix that stuff in ksa, but i don't want to start even small fixes like this where it could lead to an acceptance of bigger fixes23:37
jamielennoxmorgan: so i would argue that if you don't correctly override it you are broken: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/access/service_catalog.py#L8123:37
morganjamielennox: this is a case where we are multiple-ways broken23:38
morganftr, if we *are* going to fix this23:38
morgani recommend removing static method23:38
jamielennoxyea, i try not to use staticmethod23:38
jamielennoxbut get_endpoints is a function that is called frequently23:39
jamielennoxand normalize_method is overriden in all practical implementations23:39
jamielennoxhmm, what was that thing swiftclient did23:39
morgannow, regardless, i would say that change should absolutely NOT be bundled into some other patchset23:40
jamielennoxnah, they do it completely differently23:40
morganor it should be reverted like I did so we have a clear revert if it breaks folks.23:40
jamielennoxmorgan: sure, i don't mind that23:40
morganeither works for me23:41
*** gagehugo has quit IRC23:48
*** gagehugo has joined #openstack-keystone23:50
*** harlowja has joined #openstack-keystone23:57
*** jamielennox is now known as jamielennox|away23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!