Friday, 2017-01-06

rodrigodsgrr pep800:00
lbragstadwe could roll it all together00:00
lbragstadwhich would maintain the original author, too00:00
lbragstadrodrigods you could also assert each key is 32 bytes instead of greater than 000:01
lbragstadself.assertEqual(len(key), 32)00:01
lbragstad^ this probably makes more sense than self.assertGreater()00:01
lbragstador might be more readable00:01
rodrigodslbragstad, need to leave :(00:03
rodrigodsi can fix when i come back00:03
lbragstadrodrigods no worries00:03
lbragstadrodrigods i'm just about to wrap up for the day, too00:03
stevemarsamueldmq: rodrigods openstack will only support python 3.5.x00:04
samueldmqstevemar: nice, thanks!00:09
*** agrebennikov has quit IRC00:10
openstackgerritSteve Martinelli proposed openstack/keystone: listing revoke events should be admin only  https://review.openstack.org/41684100:10
dstanekwe should move to 3.6!00:11
samueldmqstevemar: there is also https://review.openstack.org/#/c/417238, just in the case you missed it :)00:11
dstaneklbragstad: great. just got done with dinner. i'll take a look in a sec00:11
dstaneksamueldmq: i would think we shouldn't be using that classifier anymore00:12
samueldmqdstanek: the 3.4 one ?00:13
dstaneksamueldmq: yeah, that supposed to indicate what we support and test for00:17
samueldmqdstanek: agreed, most of changes are on the gate already https://review.openstack.org/#/q/topic:rm_py3400:17
samueldmqstevemar: do services need to get the revocation list ?00:22
samueldmqstevemar: I guess no as fernet is default, just confirming00:22
samueldmqstevemar: nvm, commented in the patch00:29
openstackgerritSteve Martinelli proposed openstack/keystone: listing revoke events should be admin only  https://review.openstack.org/41684100:35
openstackgerritEric Brown proposed openstack/pycadf: Remove references to Python 3.4  https://review.openstack.org/41725500:37
*** dave-mccowan has joined #openstack-keystone00:37
openstackgerritMerged openstack/keystone: Use assertGreater(len(x), y) instead of assertTrue(len(x) > y)  https://review.openstack.org/41208300:40
samueldmqlbragstad: so, shadow mapping ...00:40
samueldmq:-)00:40
*** adrian_otto has joined #openstack-keystone00:41
samueldmqlbragstad: dstanek: I saw a couple of patches going up today, are all the bits up for review already?00:41
*** markvoelker has quit IRC00:41
*** spzala has joined #openstack-keystone00:44
*** adrian_otto has quit IRC00:49
*** guoshan has joined #openstack-keystone00:53
*** adrian_otto has joined #openstack-keystone00:55
*** guoshan has quit IRC00:57
samueldmqstevemar: dstanek: re: https://review.openstack.org/#/c/18265800:58
*** stingaci has joined #openstack-keystone00:58
samueldmqstevemar: dstanek: I propose creating a brand new manager in contrib/endpoint_group.py (new file) for endpoint_group CRUD00:59
samueldmqjust as it is for endpoints00:59
*** markvoelker has joined #openstack-keystone00:59
samueldmqand the endpoint_group/project relationship would be in contrib/endpoint_filter, just as it is for endpoint/project relationship00:59
*** jose-phillips has quit IRC01:00
*** stingaci has quit IRC01:03
*** lamt has quit IRC01:06
openstackgerritMerged openstack/python-keystoneclient: Updated from global requirements  https://review.openstack.org/41439701:13
*** samueldmq has quit IRC01:13
*** abhishekk has quit IRC01:13
*** gagehugo has quit IRC01:13
*** nikhil has quit IRC01:13
*** Dinesh_Bhor has quit IRC01:13
*** agarner has quit IRC01:13
*** robcresswell has quit IRC01:13
*** jlvillal has quit IRC01:13
*** flaper87 has quit IRC01:13
*** jlopezgu has quit IRC01:13
*** basilAB has quit IRC01:13
*** DuncanT has quit IRC01:13
*** andreaf has quit IRC01:13
*** baffle has quit IRC01:13
*** jlwhite has quit IRC01:13
*** mkoderer__ has quit IRC01:13
*** Kimmo_ has quit IRC01:13
*** bknudson has quit IRC01:13
*** timburke has quit IRC01:13
*** johnthetubaguy has quit IRC01:13
*** boris-42 has quit IRC01:13
*** pkoraca has quit IRC01:13
*** crinkle_ has quit IRC01:13
*** sc68cal has quit IRC01:13
*** aloga has quit IRC01:13
*** hugokuo has quit IRC01:13
*** dgonzalez has quit IRC01:13
*** evrardjp has quit IRC01:13
*** waj334 has quit IRC01:13
*** jamielennox has quit IRC01:13
*** pumaranikar has quit IRC01:13
*** NikitaKonovalov has quit IRC01:13
*** dolphm has quit IRC01:13
*** vern has quit IRC01:13
*** johnthetubaguy_ has joined #openstack-keystone01:14
*** baffle has joined #openstack-keystone01:14
*** dolphm_ has joined #openstack-keystone01:14
*** Kimmo_ has joined #openstack-keystone01:14
*** jlvillal has joined #openstack-keystone01:14
*** aleph1 has joined #openstack-keystone01:14
*** dgonzalez has joined #openstack-keystone01:14
*** evrardjp_ has joined #openstack-keystone01:14
*** jlwhite has joined #openstack-keystone01:14
*** Dinesh_Bhor has joined #openstack-keystone01:14
*** crinkle_ has joined #openstack-keystone01:14
*** aloga has joined #openstack-keystone01:14
*** ChanServ sets mode: +o dolphm_01:14
*** gagehugo has joined #openstack-keystone01:14
*** evrardjp_ is now known as evrardjp01:14
*** johnthetubaguy_ is now known as johnthetubaguy01:14
*** NikitaKonovalov has joined #openstack-keystone01:14
*** timburke has joined #openstack-keystone01:14
*** dolphm_ is now known as dolphm01:14
*** vern has joined #openstack-keystone01:14
*** mkoderer___ has joined #openstack-keystone01:15
*** adrian_otto has quit IRC01:15
*** hugokuo has joined #openstack-keystone01:15
*** bknudson has joined #openstack-keystone01:16
*** ChanServ sets mode: +v bknudson01:16
*** sc68cal has joined #openstack-keystone01:16
*** andreaf has joined #openstack-keystone01:16
*** AndyWojo has quit IRC01:17
*** serverascode has quit IRC01:17
*** jamielennox has joined #openstack-keystone01:18
*** ChanServ sets mode: +v jamielennox01:18
*** esp has quit IRC01:19
*** robcresswell has joined #openstack-keystone01:19
*** jlopezgu has joined #openstack-keystone01:19
*** dave-mccowan has quit IRC01:21
*** samueldmq has joined #openstack-keystone01:21
*** ChanServ sets mode: +v samueldmq01:21
openstackgerritMerged openstack/keystoneauth: Remove references to Python 3.4  https://review.openstack.org/41723601:21
*** liujiong has joined #openstack-keystone01:21
*** pumaranikar has joined #openstack-keystone01:22
*** dave-mccowan has joined #openstack-keystone01:23
*** waj334 has joined #openstack-keystone01:24
*** pkoraca has joined #openstack-keystone01:25
*** AndyWojo has joined #openstack-keystone01:25
*** boris-42 has joined #openstack-keystone01:25
*** DuncanT has joined #openstack-keystone01:26
*** nikhil has joined #openstack-keystone01:27
*** stingaci has joined #openstack-keystone01:29
*** stingaci has quit IRC01:33
*** browne has quit IRC01:43
*** serverascode has joined #openstack-keystone01:43
*** stingaci has joined #openstack-keystone01:48
*** guoshan has joined #openstack-keystone01:49
*** stingaci has quit IRC01:52
openstackgerritMerged openstack/keystone: Correct invalid rst in api docs  https://review.openstack.org/41671101:53
openstackgerritMerged openstack/keystone: Fix issues with keystone-dsvm-py35-functional-v3-only on py35  https://review.openstack.org/41250001:53
openstackgerritMerged openstack/keystonemiddleware: Remove references to Python 3.4  https://review.openstack.org/41723701:55
openstackgerritRodrigo Duarte proposed openstack/keystone: Improve assertion in test  https://review.openstack.org/41723901:56
*** dave-mccowan has quit IRC02:22
*** catintheroof has joined #openstack-keystone02:22
*** edtubill has joined #openstack-keystone02:24
openstackgerritMerged openstack/python-keystoneclient: Remove references to Python 3.4  https://review.openstack.org/41723802:28
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726302:38
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726302:40
*** catintheroof has quit IRC02:50
*** ravelar has joined #openstack-keystone02:51
*** ravelar has quit IRC02:51
*** davechen has quit IRC02:52
*** edtubill has quit IRC02:52
*** edtubill has joined #openstack-keystone02:52
*** edtubill has quit IRC03:02
*** edtubill has joined #openstack-keystone03:05
lbragstadsamueldmq should be!03:09
*** spzala has quit IRC03:13
*** edtubill has quit IRC03:19
*** spzala has joined #openstack-keystone03:52
*** guoshan has quit IRC03:55
*** itisha has quit IRC04:02
*** dikonoor has joined #openstack-keystone04:03
*** spzala has quit IRC04:07
*** nicolasbock has joined #openstack-keystone04:35
*** links has joined #openstack-keystone04:40
*** stingaci has joined #openstack-keystone04:55
*** stingaci has quit IRC05:02
*** davechen has joined #openstack-keystone05:04
*** gagehugo has quit IRC05:30
*** gagehugo has joined #openstack-keystone05:33
*** guoshan has joined #openstack-keystone05:38
*** guoshan has quit IRC05:45
*** guoshan has joined #openstack-keystone05:46
*** guoshan has quit IRC05:56
*** guoshan has joined #openstack-keystone06:00
*** spzala has joined #openstack-keystone06:08
*** spzala has quit IRC06:12
*** edtubill has joined #openstack-keystone06:14
*** edtubill has quit IRC06:30
openstackgerritMerged openstack/keystone: Improve assertion in test  https://review.openstack.org/41723906:30
openstackgerritMerged openstack/keystone: Fixed 7 tests running twice in v3 identity  https://review.openstack.org/41676506:37
*** richm has quit IRC06:41
*** adriant has quit IRC06:46
*** rcernin has quit IRC06:55
*** tesseract has joined #openstack-keystone07:09
*** pcaruana has joined #openstack-keystone07:10
*** udesale has joined #openstack-keystone07:12
*** rcernin has joined #openstack-keystone07:13
*** trananhkma has joined #openstack-keystone07:28
openstackgerritEric Brown proposed openstack/keystone: Remove references to Python 3.4  https://review.openstack.org/41723507:30
*** voelzmo has joined #openstack-keystone07:34
*** voelzmo has quit IRC07:42
openstackgerritAbhishek Kekane proposed openstack/keystoneauth: Log request-id for each api call  https://review.openstack.org/39244207:48
*** oomichi has quit IRC08:02
*** oomichi has joined #openstack-keystone08:03
*** voelzmo has joined #openstack-keystone08:11
*** voelzmo has quit IRC08:15
*** voelzmo has joined #openstack-keystone08:17
*** voelzmo has quit IRC08:20
*** EmilienM has quit IRC08:24
*** udesale has quit IRC08:31
*** waj334 has quit IRC08:31
*** robcresswell has quit IRC08:31
*** dolphm has quit IRC08:31
*** johnthetubaguy has quit IRC08:31
*** markvoelker has quit IRC08:31
*** harlowja has quit IRC08:31
*** g2 has quit IRC08:31
*** afazekas has quit IRC08:31
*** sheel has quit IRC08:31
*** davechen has quit IRC08:31
*** links has quit IRC08:31
*** AndyWojo has quit IRC08:31
*** jamielennox has quit IRC08:31
*** Dinesh_Bhor has quit IRC08:31
*** crinkle_ has quit IRC08:31
*** tlbr has quit IRC08:31
*** mtreinish has quit IRC08:31
*** rdo has quit IRC08:31
*** openstackgerrit has quit IRC08:31
*** charz has quit IRC08:31
*** oomichi has quit IRC08:31
*** serverascode has quit IRC08:31
*** pumaranikar has quit IRC08:31
*** samueldmq has quit IRC08:31
*** jlvillal has quit IRC08:31
*** sileht has quit IRC08:31
*** sudorandom has quit IRC08:31
*** ayoung has quit IRC08:31
*** trananhkma has quit IRC08:31
*** dikonoor has quit IRC08:31
*** nikhil has quit IRC08:31
*** DuncanT has quit IRC08:31
*** vern has quit IRC08:31
*** NikitaKonovalov has quit IRC08:31
*** rarora has quit IRC08:31
*** zeus has quit IRC08:31
*** timss has quit IRC08:31
*** mancdaz has quit IRC08:31
*** raj_singh has quit IRC08:31
*** slunkad has quit IRC08:31
*** woodburn has quit IRC08:31
*** Nakato has quit IRC08:31
*** nklenke has quit IRC08:31
*** gus has quit IRC08:31
*** fungi has quit IRC08:31
*** boris-42 has quit IRC08:31
*** masterjcool has quit IRC08:31
*** wolsen has quit IRC08:31
*** rm_work has quit IRC08:31
*** hyakuhei has quit IRC08:31
*** BlackDex has quit IRC08:31
*** rcernin has quit IRC08:31
*** guoshan has quit IRC08:31
*** gagehugo has quit IRC08:31
*** jlopezgu has quit IRC08:31
*** hugokuo has quit IRC08:31
*** jlwhite has quit IRC08:31
*** jgrassler has quit IRC08:31
*** bandrus has quit IRC08:31
*** nkinder has quit IRC08:31
*** _nonameentername has quit IRC08:31
*** Guest66666 has quit IRC08:31
*** dmellado_ has quit IRC08:31
*** dancn has quit IRC08:31
*** pkoraca has quit IRC08:31
*** Kimmo_ has quit IRC08:31
*** baffle has quit IRC08:31
*** d0ugal has quit IRC08:31
*** htruta has quit IRC08:31
*** tonyb has quit IRC08:31
*** lifeless has quit IRC08:31
*** eglute has quit IRC08:31
*** rodrigods has quit IRC08:31
*** Tahvok has quit IRC08:31
*** bknudson has quit IRC08:31
*** evrardjp has quit IRC08:31
*** mkoderer___ has quit IRC08:31
*** d34dh0r53 has quit IRC08:31
*** Anticimex has quit IRC08:31
*** zzzeek has quit IRC08:31
*** rha has quit IRC08:31
*** jrist_ has quit IRC08:31
*** yarkot has quit IRC08:31
*** r1chardj0n3s has quit IRC08:31
*** frickler has quit IRC08:31
*** peterstac has quit IRC08:31
*** arunkant has quit IRC08:31
*** alex_xu has quit IRC08:31
*** pcaruana has quit IRC08:31
*** tesseract has quit IRC08:31
*** nicolasbock has quit IRC08:31
*** andreaf has quit IRC08:31
*** aleph1 has quit IRC08:31
*** dgonzalez has quit IRC08:31
*** SamYaple has quit IRC08:31
*** topol_ has quit IRC08:31
*** rvba has quit IRC08:31
*** zhugaoxiao has quit IRC08:31
*** kevinbenton has quit IRC08:31
*** erhudy has quit IRC08:31
*** jidar has quit IRC08:31
*** akrzos has quit IRC08:31
*** clayton has quit IRC08:31
*** liujiong has quit IRC08:31
*** sc68cal has quit IRC08:31
*** timburke has quit IRC08:31
*** aloga has quit IRC08:31
*** sirushti has quit IRC08:31
*** gsilvis has quit IRC08:31
*** Trident has quit IRC08:31
*** cburgess has quit IRC08:31
*** haplo37_ has quit IRC08:31
*** jdennis has quit IRC08:31
*** ktychkova has quit IRC08:31
*** david-lyle has quit IRC08:31
*** toddnni has quit IRC08:31
*** hrybacki has quit IRC08:34
*** NikitaKonovalov has joined #openstack-keystone08:37
*** gagehugo has joined #openstack-keystone08:37
*** Nakato has joined #openstack-keystone08:37
*** EmilienM has joined #openstack-keystone08:37
*** mvk has joined #openstack-keystone08:37
*** oomichi has joined #openstack-keystone08:37
*** trananhkma has joined #openstack-keystone08:37
*** rcernin has joined #openstack-keystone08:37
*** udesale has joined #openstack-keystone08:37
*** pcaruana has joined #openstack-keystone08:37
*** tesseract has joined #openstack-keystone08:37
*** davechen has joined #openstack-keystone08:37
*** links has joined #openstack-keystone08:37
*** nicolasbock has joined #openstack-keystone08:37
*** serverascode has joined #openstack-keystone08:37
*** nikhil has joined #openstack-keystone08:37
*** boris-42 has joined #openstack-keystone08:37
*** AndyWojo has joined #openstack-keystone08:37
*** pkoraca has joined #openstack-keystone08:37
*** waj334 has joined #openstack-keystone08:37
*** pumaranikar has joined #openstack-keystone08:37
*** liujiong has joined #openstack-keystone08:37
*** samueldmq has joined #openstack-keystone08:37
*** jlopezgu has joined #openstack-keystone08:37
*** robcresswell has joined #openstack-keystone08:37
*** jamielennox has joined #openstack-keystone08:37
*** andreaf has joined #openstack-keystone08:37
*** sc68cal has joined #openstack-keystone08:37
*** bknudson has joined #openstack-keystone08:37
*** hugokuo has joined #openstack-keystone08:37
*** mkoderer___ has joined #openstack-keystone08:37
*** vern has joined #openstack-keystone08:37
*** timburke has joined #openstack-keystone08:37
*** aloga has joined #openstack-keystone08:37
*** crinkle_ has joined #openstack-keystone08:37
*** Dinesh_Bhor has joined #openstack-keystone08:37
*** jlwhite has joined #openstack-keystone08:37
*** evrardjp has joined #openstack-keystone08:37
*** dgonzalez has joined #openstack-keystone08:37
*** aleph1 has joined #openstack-keystone08:37
*** jlvillal has joined #openstack-keystone08:37
*** Kimmo_ has joined #openstack-keystone08:37
*** dolphm has joined #openstack-keystone08:37
*** tepper.freenode.net sets mode: +vvvo samueldmq jamielennox bknudson dolphm08:37
*** baffle has joined #openstack-keystone08:37
*** johnthetubaguy has joined #openstack-keystone08:37
*** markvoelker has joined #openstack-keystone08:37
*** SamYaple has joined #openstack-keystone08:37
*** sirushti has joined #openstack-keystone08:37
*** harlowja has joined #openstack-keystone08:37
*** d0ugal has joined #openstack-keystone08:37
*** d34dh0r53 has joined #openstack-keystone08:37
*** Anticimex has joined #openstack-keystone08:37
*** openstackgerrit has joined #openstack-keystone08:37
*** rarora has joined #openstack-keystone08:37
*** tlbr has joined #openstack-keystone08:37
*** sileht has joined #openstack-keystone08:37
*** g2 has joined #openstack-keystone08:37
*** mtreinish has joined #openstack-keystone08:37
*** Trident has joined #openstack-keystone08:37
*** gsilvis has joined #openstack-keystone08:37
*** topol_ has joined #openstack-keystone08:37
*** rvba has joined #openstack-keystone08:37
*** rdo has joined #openstack-keystone08:37
*** afazekas has joined #openstack-keystone08:37
*** zeus has joined #openstack-keystone08:37
*** htruta has joined #openstack-keystone08:37
*** jgrassler has joined #openstack-keystone08:37
*** sheel has joined #openstack-keystone08:37
*** zzzeek has joined #openstack-keystone08:37
*** rha has joined #openstack-keystone08:37
*** zhugaoxiao has joined #openstack-keystone08:37
*** charz has joined #openstack-keystone08:37
*** mancdaz has joined #openstack-keystone08:37
*** tonyb has joined #openstack-keystone08:37
*** jrist_ has joined #openstack-keystone08:37
*** bandrus has joined #openstack-keystone08:37
*** nkinder has joined #openstack-keystone08:37
*** raj_singh has joined #openstack-keystone08:37
*** yarkot has joined #openstack-keystone08:37
*** r1chardj0n3s has joined #openstack-keystone08:37
*** kevinbenton has joined #openstack-keystone08:37
*** lifeless has joined #openstack-keystone08:37
*** cburgess has joined #openstack-keystone08:37
*** slunkad has joined #openstack-keystone08:37
*** woodburn has joined #openstack-keystone08:37
*** _nonameentername has joined #openstack-keystone08:37
*** eglute has joined #openstack-keystone08:37
*** rodrigods has joined #openstack-keystone08:37
*** sudorandom has joined #openstack-keystone08:37
*** haplo37_ has joined #openstack-keystone08:37
*** Guest66666 has joined #openstack-keystone08:37
*** frickler has joined #openstack-keystone08:37
*** masterjcool has joined #openstack-keystone08:37
*** nklenke has joined #openstack-keystone08:37
*** jdennis has joined #openstack-keystone08:37
*** ayoung has joined #openstack-keystone08:37
*** wolsen has joined #openstack-keystone08:37
*** rm_work has joined #openstack-keystone08:37
*** Tahvok has joined #openstack-keystone08:37
*** hyakuhei has joined #openstack-keystone08:37
*** peterstac has joined #openstack-keystone08:37
*** fungi has joined #openstack-keystone08:37
*** gus has joined #openstack-keystone08:37
*** ktychkova has joined #openstack-keystone08:37
*** BlackDex has joined #openstack-keystone08:37
*** david-lyle has joined #openstack-keystone08:37
*** arunkant has joined #openstack-keystone08:37
*** alex_xu has joined #openstack-keystone08:37
*** erhudy has joined #openstack-keystone08:37
*** jidar has joined #openstack-keystone08:37
*** dancn has joined #openstack-keystone08:37
*** toddnni has joined #openstack-keystone08:37
*** akrzos has joined #openstack-keystone08:37
*** clayton has joined #openstack-keystone08:37
*** tepper.freenode.net sets mode: +v ayoung08:37
*** timss has joined #openstack-keystone08:38
*** EmilienM has quit IRC08:39
*** EmilienM has joined #openstack-keystone08:39
*** dmellado has joined #openstack-keystone08:39
*** jraim has quit IRC08:40
*** andrewbogott has quit IRC08:40
*** cargonza has quit IRC08:40
*** raddaoui has quit IRC08:40
*** ctracey has quit IRC08:40
*** AndyWojo has quit IRC08:40
*** serverascode has quit IRC08:41
openstackgerritTin Lam proposed openstack/keystone: [WIP] Filtering invalid resources should return 400 Bad Request  https://review.openstack.org/41731508:41
*** nikhil has quit IRC08:41
*** asettle has joined #openstack-keystone08:41
*** DuncanT has joined #openstack-keystone08:45
*** trananhkma has quit IRC08:45
*** guoshan has joined #openstack-keystone08:46
openstackgerritShan Guo proposed openstack/keystone: Retry on deadlock Transactions in backend  https://review.openstack.org/41687208:47
*** AndyWojo has joined #openstack-keystone08:48
*** raddaoui has joined #openstack-keystone08:49
*** cargonza has joined #openstack-keystone08:51
*** andrewbogott has joined #openstack-keystone08:52
*** hrybacki has joined #openstack-keystone08:54
*** nikhil has joined #openstack-keystone08:56
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-keystone09:00
*** ctracey has joined #openstack-keystone09:02
*** jraim has joined #openstack-keystone09:02
*** serverascode has joined #openstack-keystone09:02
*** guoshan has quit IRC09:07
*** spzala has joined #openstack-keystone09:09
*** spzala has quit IRC09:13
*** timss has quit IRC09:27
*** timss has joined #openstack-keystone09:27
*** evrardjp has quit IRC09:33
*** mvk has quit IRC09:33
*** evrardjp has joined #openstack-keystone09:33
*** nishaYadav has joined #openstack-keystone09:57
*** nishaYadav is now known as Guest9855009:58
*** Guest98550 is now known as nishaYadav_09:58
*** liujiong has quit IRC10:05
openstackgerritMerged openstack/pycadf: Remove references to Python 3.4  https://review.openstack.org/41725510:06
*** udesale has quit IRC10:08
*** mvk has joined #openstack-keystone10:20
*** dikonoor has joined #openstack-keystone10:21
nishaYadav_o/11:06
*** richm has joined #openstack-keystone11:14
nishaYadav_stevemar, hey!11:19
*** maestropandy has joined #openstack-keystone11:30
*** maestropandy has left #openstack-keystone11:31
*** dave-mccowan has joined #openstack-keystone12:03
*** edmondsw has joined #openstack-keystone12:05
*** edmondsw has quit IRC12:06
*** edmondsw has joined #openstack-keystone12:06
*** jamielennox is now known as jamielennox|away12:08
openstackgerritMerged openstack/keystone: Remove references to Python 3.4  https://review.openstack.org/41723512:13
stevemarnishaYadav_: o/12:13
rodrigodsstevemar, around for a couple of minutes to discuss the options for https://review.openstack.org/#/c/415906/10 ?12:15
nishaYadav_stevemar, hi12:15
nishaYadav_rodrigods, o/12:15
rodrigodshi nishaYadav_ :)12:15
stevemarrodrigods: yep, just booking some travel12:15
rodrigodsstevemar, so... the option there is to create a new fk(cascade=true) in the expand phase with triggers to avoid writes to the protocol and idp tables12:16
rodrigodslater, in the contract phase, we drop the old the fk12:16
rodrigodsthe doubt that i have is how to differ between the new fk and the old one12:17
rodrigodsor... we can leave it as it is and add an exempt for it12:18
stevemarrodrigods: yeah, i'm really not sure how to differ btwn the keys12:21
stevemaryou can file an exception, i'm OK with that12:21
rodrigodsstevemar, ok, maybe we can gather some feedback in the review itself12:22
*** catintheroof has joined #openstack-keystone12:32
*** catintheroof has quit IRC12:32
*** catintheroof has joined #openstack-keystone12:32
*** nishaYadav_ has quit IRC12:36
*** catintheroof has quit IRC12:36
*** catintheroof has joined #openstack-keystone12:37
*** maestropandy has joined #openstack-keystone13:04
*** maestropandy has left #openstack-keystone13:04
*** spzala has joined #openstack-keystone13:10
*** maestropandy1 has joined #openstack-keystone13:10
*** maestropandy1 has left #openstack-keystone13:10
*** maestropandy2 has joined #openstack-keystone13:13
*** maestropandy2 has left #openstack-keystone13:13
*** spzala has quit IRC13:14
edmondswtrying to help someone figure out a ci failure where 27 keystone tests around federation fail because they're policy forbidden. I'm assuming it's something to do with how they setup devstack. Tips on how to setup devstack for federation?13:17
*** maestropandy has joined #openstack-keystone13:27
rodrigodsedmondsw, we have a plugin for it13:28
rodrigodsedmondsw, you enable keystone's plugin via "enable_plugin ..."13:28
rodrigodsand enable the federation service13:28
rodrigods"enable_service keystone-saml2-federation"13:28
rodrigodswe have a bug that prevents all tests to pass, it is being addressed at https://review.openstack.org/#/c/415906/13:29
rodrigodsdstanek, around? i'm trying to run keystone's tests against a local mysql setup with no luck13:31
*** maestropandy has quit IRC13:32
edmondswrodrigods tx. And it's always been this way, right? No recent changes? This CI used to work fine...13:33
rodrigodsedmondsw, this is pretty new... I mean, ocata new13:33
edmondswhm, ok13:34
rodrigodsthis is for functional tests, unit tests should work without it13:34
edmondswsure... it's functional that is blowing up13:34
rodrigodsedmondsw, besides that... we had a problem yesterday due a change in tempest13:34
*** nklenke has quit IRC13:34
rodrigodsedmondsw, it was fixed here: https://review.openstack.org/#/c/417030/13:35
rodrigodsstevemar, is it ok to put URLs in our docstring? need to update the docstring at test_sql_upgrade13:43
*** thorst_ has joined #openstack-keystone13:46
edmondswrodrigods could you take a look at the failing CI's logs and see if it's the same issue you were seeing yesterday?  http://184.172.12.213/69/416969/3/check/nova-powervm-pvm-dsvm-tempest-full/0302777/13:48
rodrigodsedmondsw, yes, exactly the same issues13:51
edmondswrodrigods, thanks!13:51
edmondswthorst_ ^13:51
thorst_edmondsw rodrigods: Thank you much...scratched my head for hours on that one yesterday...13:51
rodrigodsthorst_, :)13:52
edmondswthorst_ helps to ask! :)13:52
thorst_+113:52
*** spzala has joined #openstack-keystone13:54
samueldmqmorning14:01
samueldmqkeystone working hours ?14:02
*** chlong has joined #openstack-keystone14:02
openstackgerritRodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk  https://review.openstack.org/41590614:09
openstackgerritRodrigo Duarte proposed openstack/keystone: Fix minor typo  https://review.openstack.org/41738814:09
rodrigods"Fix minor typo" should be easy to approve ^14:09
*** lamt has joined #openstack-keystone14:13
stevemarrodrigods: sure, put URLs in a docstring *shrug*14:15
stevemarrodrigods: put a damn poem if it makes sense :)14:15
dstaneksamueldmq: morning14:23
samueldmqdstanek: o/14:23
samueldmqstevemar: maybe the siphonaptera ?14:23
lbragstadbug day!14:28
*** jaugustine has joined #openstack-keystone14:29
*** dikonoor has quit IRC14:30
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726314:33
samueldmqlbragstad: dstanek: I will work to close this bug today ^14:34
openstackgerritDavid Stanek proposed openstack/keystoneauth: Add __ne__ built-in function  https://review.openstack.org/39829414:34
samueldmqwell, not really a bug, but add that support in ksc14:34
lbragstadsamueldmq cool - sounds good14:35
stevemarsamueldmq: i'll be happy to review it :)14:35
lbragstadsame her e14:35
samueldmqstevemar: lbragstad: nice, I will need help. I am not really a ninja in ksc yet14:36
samueldmqhehe14:36
stevemarsamueldmq: look at how i did the implied roles work if you need a pointer14:36
*** links has quit IRC14:37
stevemardstanek: funny, i was going to ask you about https://review.openstack.org/#/c/416830/14:37
samueldmqstevemar: kk will look for sure14:38
stevemardstanek: theres a KSC version of it14:38
dstanekstevemar: what about it? i don't get why it's being changed14:39
stevemardstanek: see the bug report14:39
stevemardstanek: someone thought it could be done using non private functions and without mock14:39
stevemarbut... looks like he was off a bit?14:39
*** edtubill has joined #openstack-keystone14:41
*** nklenke has joined #openstack-keystone14:41
*** Dave has quit IRC14:41
dstanekhmmm.... let me take a quick peek and see if it can now be done a different way14:41
dstanekthat run_check method is run by *all* tests and not just one of them14:42
*** topol_ is now known as topol14:44
*** ChanServ sets mode: +v topol14:44
openstackgerritRodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade  https://review.openstack.org/41740214:49
openstackgerritRodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade  https://review.openstack.org/41740214:49
*** nicolasbock has quit IRC15:04
*** chris_hultin|AWA is now known as chris_hultin15:07
*** voelzmo has joined #openstack-keystone15:14
*** jaugustine_ has joined #openstack-keystone15:14
*** phalmos has joined #openstack-keystone15:15
*** phalmos has quit IRC15:20
*** nicolasbock has joined #openstack-keystone15:20
*** voelzmo has quit IRC15:20
lbragstadDoes anyone here know if the owner of this patch hangs out in IRC at all? https://review.openstack.org/#/c/304489/15:25
lbragstaddoesn't look like that ^ patch has been touched in a long time15:26
lbragstadwith a little work - we could use it to close https://bugs.launchpad.net/keystone/+bug/155716615:27
openstackLaunchpad bug 1557166 in OpenStack Identity (keystone) "V2 Endpoint creation with missing region returns 500" [Undecided,In progress] - Assigned to Kanika Singh (kanikasingh-1490)15:27
*** phalmos has joined #openstack-keystone15:28
gagehugoo/15:30
lbragstadgagehugo o/15:31
*** jrist_ is now known as jrist15:33
*** jrist has quit IRC15:33
*** jrist has joined #openstack-keystone15:33
dstanekstevemar: i can 't see a good way to do it. maybe sigmavirus knows?15:34
sigmavirusThose words usually mean I should run and hide15:34
sigmavirusI mean, what's up?15:34
dstaneki just want to call checker.run_check(something) and have it work, but that means i'd have to replicate register_check(), check_ast() and others15:34
sigmavirusFlake8?15:34
dstaneksigmavirus: was trying to see if there was a better way to run my checks without mocking15:35
dstanekhttps://review.openstack.org/#/c/416830/115:35
dstanekhmmm....i may just be thinking about this backward though15:35
dstaneki could somehow attach the code to the classes and test based on that15:37
lbragstadstevemar do we document endpoint groups anywhere?15:38
*** andrewbogott has quit IRC15:38
*** andrewbogott has joined #openstack-keystone15:38
sigmavirusWhat if I take over that review from stevemar and dig around a bit more?15:38
sigmavirusI have a very unfortunate understanding of all this nonsense15:38
stevemarsigmavirus: you're more than welcome to15:39
dstaneksigmavirus: sure, if you have the free time.15:39
sigmavirusdstanek: that's a loaded statement, sir, and you know it15:40
stevemarsigmavirus: there are 2 patches up for the bug, the KSC one is a bit easier, the keystone one mocks something at the base class15:40
dstaneksigmavirus: i was just thinking that each class would have a new attribute 'CODES = []' that could be used in the select instead of hard coding the K33315:40
dstanekstevemar: keystone is what i am looking at now because it's a much more interesting case15:40
stevemarsigmavirus: dstanek i was actually thinking we could just remove the K333 hacking check from the code base, i don't think importing oslo.log will work any longer?15:40
sigmavirusdstanek: so here's the thing I'd like to accomplish by taking over the changes: making it easier for Keystone to transition to Flake8 3 when hacking does15:40
sigmavirusstevemar: it won't15:41
dstaneksigmavirus: whatever works15:41
dstaneki'll move on to the next thing in my list then15:41
stevemarsigmavirus: dstanek yeah, so for the keystoneclient side, we can remove that check15:41
sigmavirussounds then like you don't need me anyway?15:42
dstaneksigmavirus: for keystone we do15:42
dstanekwe have 6 or 7 checks there and when i did it i unfortunately patched some internals of the libs15:43
dstanekand had to use internals to get the reporting data i needed15:43
stevemarsigmavirus: so to clarify, we need you for https://review.openstack.org/#/c/416830/ :)15:44
stevemari will rework https://review.openstack.org/#/c/416829/ to remove the hacking check, it's no longer necessary15:44
sigmavirusroger, stevemar dstanek15:44
dstaneksigmavirus: have fun and many thanks!15:44
sigmavirusdstanek: for certain quantities of fun ... I will!15:45
sigmavirusand you're welcome15:45
*** Dave has joined #openstack-keystone15:49
*** ravelar has joined #openstack-keystone15:50
*** mvk has quit IRC15:50
openstackgerritSteve Martinelli proposed openstack/python-keystoneclient: remove hacking checks from keystoneclient  https://review.openstack.org/41682915:51
*** rcernin has quit IRC15:53
*** jvarlamova_ has quit IRC15:55
stevemardstanek: ^15:56
openstackgerritRon De Rose proposed openstack/keystone: Require domain_id when registering Identity Providers  https://review.openstack.org/39968416:05
*** Dave has quit IRC16:05
*** voelzmo has joined #openstack-keystone16:06
dstanekstevemar: great thanks!16:08
*** toddnni has quit IRC16:15
*** sheel has quit IRC16:17
*** agrebennikov has joined #openstack-keystone16:20
*** jaugustine_ has quit IRC16:28
*** adrian_otto has joined #openstack-keystone16:28
*** toddnni has joined #openstack-keystone16:28
*** diazjf has joined #openstack-keystone16:30
lbragstadstevemar ping - is this example right? http://developer.openstack.org/api-ref/identity/v3-ext/index.html#os-ep-filter-api16:32
openstackgerritSteve Martinelli proposed openstack/keystone: Retry on deadlock Transactions in backend  https://review.openstack.org/41687216:32
stevemarsamueldmq: ^16:33
stevemarlbragstad: hmmm16:33
stevemarlbragstad: what makes youthink its wrong?16:33
lbragstadstevemar the filters dictionary of the endpoint group has keys of 'interface' and 'service_id', but then it says that it will filter based on 'region_id'?16:33
lbragstadit's saying the service_id == region_id in the example?16:34
*** stingaci has joined #openstack-keystone16:34
*** diazjf has quit IRC16:35
stevemari guess it's poorly worded16:35
stevemaralso we dont need the ``'s on ``region_id = "1b501"``16:35
edmondswlbragstad doesn't appear to be on regularly: https://www.google.com/search?q=site%3Aeavesdrop.openstack.org+kanika&ie=utf-8&oe=utf-816:35
*** diazjf has joined #openstack-keystone16:36
lbragstadedmondsw gotcha - good to know... nice google query btw16:36
stevemarlbragstad: looks wrong to me :)16:36
stevemarlbragstad: https://github.com/openstack/keystone-specs/blob/master/attic/v3/identity-api-v3-os-ep-filter-ext.rst#endpoint-group16:36
stevemarlbragstad: i'll fix it up quickly16:37
lbragstadstevemar nice - thanks!16:37
lbragstadI was gonna say - i have no idea how that association makes sense16:37
lbragstadstevemar you could go ahead and remove the interface from that example too, since I don't think that is suppose to be there either.16:38
stevemaryep16:38
*** itisha has joined #openstack-keystone16:39
lbragstadstevemar that whole section needs love16:41
openstackgerritSteve Martinelli proposed openstack/keystone: [api] fix ep filter example  https://review.openstack.org/41744316:44
stevemarlbragstad: cooooming up16:44
*** mjb has quit IRC16:44
*** mjb has joined #openstack-keystone16:44
*** tesseract has quit IRC16:47
openstackgerritLance Bragstad proposed openstack/keystone: Remove endpoint_id parameter from EP-FILTER docs  https://review.openstack.org/41744516:47
*** jose-phillips has joined #openstack-keystone16:50
stevemarlamt: oh wow, i didn't know we even tested invalid filters https://review.openstack.org/#/c/417315/1/keystone/tests/unit/test_v3_filters.py16:51
samueldmqhey, we're getting things done ! o/16:51
stevemarlamt: thanks for picking it up!16:51
samueldmqlbragstad: want to give https://review.openstack.org/#/c/399684 another look ?16:52
lamtstevemar: Np. I didn't either, but right now it just siliently dropping bad query parameter.16:52
samueldmqlbragstad: I doing the last check before approving, if you are okay with it too16:52
openstackgerritLance Bragstad proposed openstack/keystone: Fix region_id responses and requests to be consistent  https://review.openstack.org/41744616:54
lbragstadstevemar well need those two patches, too ^16:54
dstanekok, today's meetings are now over!16:55
*** jaosorior has joined #openstack-keystone16:55
openstackgerritSteve Martinelli proposed openstack/python-keystoneclient: remove hacking checks from keystoneclient  https://review.openstack.org/41682916:56
stevemarlunch soon :)16:56
gagehugorderose ping: I'm not really sure what needs to be changed in the api-ref for https://review.openstack.org/#/c/404022/16:57
gagehugoyay lunch16:57
rderosegagehugo: somehow we need to document in our API that this method does not require token authentication16:58
gagehugorderose: ah ok, ty16:58
samueldmqlbragstad: want to approve that one too or just send another patch set to Steve's ?16:58
*** jaugustine_ has joined #openstack-keystone16:59
lbragstadsamueldmq which one?16:59
samueldmqlbragstad: https://review.openstack.org/#/c/41744616:59
samueldmqor just update https://review.openstack.org/#/c/41744316:59
lbragstadsamueldmq either way works for me - I can pull it into the previous one17:00
lbragstaddoesn't matter to me17:00
samueldmqlbragstad: I mean, that will cause a merge conflict, Steve's is gating17:02
samueldmqlbragstad: either submit another patchset to his or update yours17:02
samueldmqlbragstad: I don't mind either, let's just get it done :017:02
samueldmq:)17:02
lbragstadrderose https://review.openstack.org/#/c/399684/36 looks good to me17:03
lbragstadsamueldmq well - if stevemar's is gating lets not update it17:03
samueldmqlbragstad: ++17:03
rderoselbragstad: cool, thanks!17:04
lbragstadsamueldmq i'll just resolve the merge conflict later with a follow on - and i'm sure i'll have more fixes to the OS-EP-FILTER docs anyway17:04
samueldmqlbragstad: ++17:04
rderoseand thanks stevemar and samueldmq for your reviews on that patch :)17:04
*** esp has joined #openstack-keystone17:08
samueldmqrderose: np, approved, well done17:09
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726317:10
samueldmqstevemar: dstanek: lbragstad: I am getting errors like http://paste.openstack.org/show/594135/ on ^17:10
samueldmqrequests_mock.exceptions.NoMockAddress: No mock address: GET http://127.0.0.1:5000/v3/OS-EP-FILTER/endpoint_groups17:11
samueldmqmight be something really simple I am missing17:11
lbragstadsamueldmq i want to say the client uses inspection to create mock urls (?)17:11
lbragstadso you might need to add the path somewhere in the client?17:12
samueldmqlbragstad: hmm maybe, I will have a glance on that direction, thanks17:12
openstackgerritTin Lam proposed openstack/keystone: [WIP] Filtering invalid resources should return 400 Bad Request  https://review.openstack.org/41731517:16
dstaneksamueldmq: let me know if you need any help17:20
*** jaosorior has quit IRC17:21
*** nicolasbock has quit IRC17:23
lbragstadso - just to give people a status. I am going to be working on triaging bugs today, specifically the ones we have in progress17:24
lbragstadi want to make sure we keep the ball rolling on bugs we have patches in review for17:25
lbragstadand a side-effect of doing just on https://bugs.launchpad.net/keystone/+bug/1642985 - i am going through the OS-EP-FILTER documentation17:25
openstackLaunchpad bug 1642985 in OpenStack Identity (keystone) "Support for arrays of entities in endpoint group definition" [Wishlist,In progress] - Assigned to Jose Castro Leon (jose-castro-leon)17:25
lbragstadand just for some stats - this morning we had 116 open bugs17:27
samueldmqdstanek: kk thanks, I am trying a few things here17:28
openstackgerritGage Hugo proposed openstack/keystone: Allow user to change own expired password  https://review.openstack.org/40402217:29
openstackgerritRodrigo Duarte proposed openstack/keystone: Remove comment from previous migration  https://review.openstack.org/41745517:29
lbragstadstevemar looking through the OS-EP-FILTER examples again, and maybe we should change it back to service_id instead of region_id... all the responses are written to return projects based on the service_id filter17:34
openstackgerritRodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk  https://review.openstack.org/41590617:35
*** jaugustine_ has quit IRC17:38
openstackgerritRodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade  https://review.openstack.org/41740217:40
dstanekfg17:42
*** woodster_ has joined #openstack-keystone17:47
*** jerrygb has joined #openstack-keystone17:50
openstackgerritMerged openstack/keystone: Fix minor typo  https://review.openstack.org/41738817:54
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726317:59
*** browne has joined #openstack-keystone18:00
*** pcaruana has quit IRC18:01
openstackgerritRon De Rose proposed openstack/keystone: PCI-DSS Force users to immediately change their password upon first use  https://review.openstack.org/40391618:04
*** spzala has quit IRC18:05
*** spzala has joined #openstack-keystone18:06
*** thorst_ has quit IRC18:10
gagehugomany changes18:10
*** spzala has quit IRC18:10
stevemarlbragstad: oh?18:11
stevemarlbragstad: i'll fix it up then18:11
openstackgerritMerged openstack/keystoneauth: Add __ne__ built-in function  https://review.openstack.org/39829418:12
openstackgerritSteve Martinelli proposed openstack/keystone: Retry on deadlock Transactions in backend  https://review.openstack.org/41687218:14
*** mvk has joined #openstack-keystone18:20
*** jdennis has quit IRC18:22
*** jdennis has joined #openstack-keystone18:22
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726318:26
samueldmqdstanek: lbragstad: stevemar ^ it is reviewable now, tests passing and has docs18:27
samueldmqnotice I have not put it into the v3/contrib as OS-EP-FILTER it is not an extension in keystone server anymore18:28
samueldmqlet me know if you agree with that18:28
*** jaugustine_ has joined #openstack-keystone18:29
*** jaugustine_ has quit IRC18:34
*** jaugustine_ has joined #openstack-keystone18:41
*** thorst_ has joined #openstack-keystone18:42
stevemarsamueldmq: should be fine18:45
stevemarsamueldmq: i'll try it out18:49
openstackgerritRodrigo Duarte proposed openstack/keystone: Update docstring at test_sql_upgrade  https://review.openstack.org/41740218:49
samueldmqstevemar: nice, thanks!18:50
samueldmqstevemar: I will write a few functional tests in a follow up18:50
samueldmqcan't do that now :(18:50
*** jerrygb_ has joined #openstack-keystone18:57
*** jerrygb has quit IRC19:00
openstackgerritMerged openstack/keystone: Require domain_id when registering Identity Providers  https://review.openstack.org/39968419:03
samueldmqrderose: ^ \o/19:04
rderosesamueldmq: sweet! \o/19:09
openstackgerritRon De Rose proposed openstack/keystone: Update docs to require domain_id when registering Identity Providers  https://review.openstack.org/39915719:09
openstackgerritRodrigo Duarte proposed openstack/keystone: Cascade delete federated_user fk  https://review.openstack.org/41590619:11
stevemardstanek: around?19:13
stevemardstanek: this bug has been waiting for your final approval: https://review.openstack.org/#/c/380376/19:13
*** voelzmo has quit IRC19:20
*** voelzmo has joined #openstack-keystone19:21
*** raginbajin has quit IRC19:21
*** marekd has quit IRC19:22
*** voelzmo has quit IRC19:25
openstackgerritGage Hugo proposed openstack/keystone: Allow user to change own expired password  https://review.openstack.org/40402219:26
*** jaugustine_ has quit IRC19:28
*** jaugustine_ has joined #openstack-keystone19:31
openstackgerritMerged openstack/keystone: [api] fix ep filter example  https://review.openstack.org/41744319:33
lamtShould https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3_identity.py#L197 be ?domain_id= and not ?domain-id=?19:38
openstackgerritMerged openstack/keystone: Remove endpoint_id parameter from EP-FILTER docs  https://review.openstack.org/41744519:39
ayoungstevemar, any low hanging fruit for review?19:39
*** ravelar has quit IRC19:41
openstackgerritMerged openstack/python-keystoneclient: remove hacking checks from keystoneclient  https://review.openstack.org/41682919:41
stevemarlamt: i think we want to keep it as domain-id, but assert that it results in a 400 now19:41
stevemarayoung: ummm19:41
lamtstevemar: thanks19:41
*** spzala has joined #openstack-keystone19:42
stevemarayoung: i think we got the easy ones19:42
ayoungstevemar, I'm going to try and see why https://review.openstack.org/#/c/257636/ is failing, and resubmit, but could you please review the prereqs19:42
ayoungbe nice to at least close 968696 on the Keystone side19:43
stevemarayoung: wilco, it's been on my list of things to review for a while19:43
ayoungstevemar, thanks19:43
*** jerrygb_ has quit IRC19:43
*** voelzmo has joined #openstack-keystone19:47
*** nkinder has quit IRC19:53
*** nkinder has joined #openstack-keystone19:53
*** ravelar has joined #openstack-keystone19:54
*** voelzmo_ has joined #openstack-keystone19:59
*** jerrygb has joined #openstack-keystone20:02
*** voelzmo has quit IRC20:02
*** jerrygb has quit IRC20:03
*** jerrygb has joined #openstack-keystone20:03
*** voelzmo_ has quit IRC20:03
stevemarsamueldmq can you revisit https://review.openstack.org/#/c/413869/320:09
stevemaranyone feel like picking up https://review.openstack.org/#/c/416260/ ? it just needs one test to pass :\20:10
dstanekstevemar: i'll take a look at it20:11
stevemarsure, i'm looking at another bug, figured i'd spread the bug love20:11
lbragstadstevemar do we have a convention for controllers requiring a bunch of managers?20:12
*** ravelar has quit IRC20:12
lbragstador should the controllers only care about their respective managers and have the managers require other managers?20:12
stevemarlbragstad: i think we only create a manager when we need one20:12
*** jerrygb_ has joined #openstack-keystone20:13
lbragstadstevemar sure - let me grab an example20:13
stevemarya, might be easier that way :)20:13
*** jaugustine_ has quit IRC20:13
lbragstadstevemar https://github.com/openstack/keystone/blob/64dbcf159d5c164547885fa619b7e3c8fb5dc72f/keystone/catalog/controllers.py#L430-L44020:14
lbragstadstevemar take a look at that comment ^20:14
lbragstadstevemar that specific controller has a dependency on the resource_api in order to validate some piece of that request https://github.com/openstack/keystone/blob/64dbcf159d5c164547885fa619b7e3c8fb5dc72f/keystone/catalog/controllers.py#L40820:14
*** jerrygb has quit IRC20:15
lbragstadis that something we would consider business logic that should be handled by the manager?20:15
lbragstadstevemar I just stumbled across this as I'm working on the documentation and noticed that - I wasn't sure if we had a convention for that or not20:15
samueldmqstevemar: I will revisit that in a bit once I am on the laptop again20:16
dstaneklbragstad: i would say that's a manager thing20:17
*** jerrygb has joined #openstack-keystone20:17
lbragstaddstanek yeah - that's what i was thinking20:17
*** jaugustine_ has joined #openstack-keystone20:17
lbragstaddstanek it seems like a total nit - but i didn't know the answer20:17
*** voelzmo has joined #openstack-keystone20:19
*** jerrygb_ has quit IRC20:19
*** jaugustine_ has quit IRC20:21
*** ayoung_ has joined #openstack-keystone20:22
*** voelzmo has quit IRC20:23
openstackgerritGage Hugo proposed openstack/keystone: Fixed not in toctree warnings when building docs  https://review.openstack.org/41749720:24
*** ayoung_ has quit IRC20:25
ayoungstevemar, all of the failing tests in  https://review.openstack.org/#/c/257636/  have to do with domain scoped tokens20:26
ayoungI freaken hate domain scoped tokens20:26
ayoungI might need to update the policy.json so that some of the operations for domain stuff accepts domain scoped tokens for the default policy file...think that is safe?20:27
*** diazjf has quit IRC20:31
*** spzala has quit IRC20:37
samueldmqstevemar: about https://review.openstack.org/#/c/413869/3/20:38
samueldmqstevemar: I am fine with that as it is, however as per my comment I think 'this folder' would sound better than 'the following folder' since it's in that folder20:39
samueldmqI can do a quick edit/reply on that if you want20:39
*** nkinder has quit IRC20:42
*** jaugustine_ has joined #openstack-keystone20:42
*** stingaci has quit IRC20:43
dstaneksamueldmq: what's a folder?20:43
samueldmqdstanek: a directory ?20:44
samueldmqdstanek: if it is not the right naming, I am just re-using what's in https://review.openstack.org/#/c/413869/3/superseded/README.rst20:44
samueldmq:)20:44
*** spzala has joined #openstack-keystone20:45
samueldmqdstanek always asks me hard questions20:46
*** ravelar has joined #openstack-keystone20:47
dstaneklol, i don't use windows so i don't always remember the terminology20:49
*** spzala has quit IRC20:49
dstanekstevemar: i swear i saw a review that was using content-type to decide if something should be logged20:53
ayoungGAH!  so the cloudsample rule can't pass in the case of the test keystone.tests.unit.test_v3_identity.IdentityTestCase.test_create_user_without_domain  becasue we have nio domainid in the user object to check20:54
ayoungDo we have an "is none" check we can do?20:55
*** nkinder has joined #openstack-keystone20:55
*** voelzmo has joined #openstack-keystone20:56
*** Dave has joined #openstack-keystone21:00
*** voelzmo has quit IRC21:01
openstackgerritGage Hugo proposed openstack/keystone: Remove stevedore warning when building docs  https://review.openstack.org/41750821:02
samueldmqdstanek: hehe21:02
samueldmqdstanek: so there was one from me .. want a link ?21:02
dstaneksamueldmq: sure21:03
samueldmqdstanek: https://review.openstack.org/#/q/topic:bug/161610521:03
*** spzala has joined #openstack-keystone21:04
*** spzala has quit IRC21:05
*** spzala has joined #openstack-keystone21:05
*** dave-mccowan has quit IRC21:10
*** browne has quit IRC21:13
*** voelzmo has joined #openstack-keystone21:14
*** catintheroof has quit IRC21:18
*** voelzmo has quit IRC21:18
*** browne has joined #openstack-keystone21:19
*** chris_hultin is now known as chris_hultin|AWA21:22
*** jaugustine_ has quit IRC21:25
*** asettle has quit IRC21:25
ayoungstevemar, dstanek samueldmq I want to break backwards compatibility and I have a really good reason21:25
ayoungtest_create_user_without_domain21:26
ayounguses the domain from the token if not specified21:26
ayoungnone of our policy files yet would actually let that pass21:26
ayoungpretty sure that the cloudsample must not test it, as the check it has for that policy rule does not pass21:27
dstanekayoung: what do you want to do?21:27
ayoungin order to make it work, we need to enforce policy inside the create_user call, and default the value prior to passing to policy21:27
ayoungdstanek, drop the rule that says you can create a user without specifying a domain_id for the user21:28
ayoungor, stated better, start requiring a domain_id on a create user call21:28
openstackgerritMerged openstack/keystone: Wrap invalidation region to context-local cache  https://review.openstack.org/38037621:28
dstanekayoung: what do we do now? try to get the default domain?21:28
ayoungdstanek, I think that it matches the domain_id from the requesting user's token21:29
stevemardstanek: there were several fixes for content-type that went around21:29
dstanekthat's kinda weird21:29
stevemardstanek: we needed fixes for logging response and request, for both KSC and KSA21:30
*** dave-mccowan has joined #openstack-keystone21:30
dstanekstevemar: i have the test working...manually testing and looking for corner cases21:30
ayoungits a case of enforcing policy on the content of the request, which is OK, but that is the scope check, and in this case, there is no way to default the scope check:21:30
ayoungwe are asking policy to know that, in this case, if the domain_id is not specified, it is OK to let the call through21:30
ayoungbut in other cases, where the domain_id does not match, we should deny the request21:31
ayoungits icky21:31
*** voelzmo has joined #openstack-keystone21:32
dstanekayoung: so the options are to either enforce policy after the domain has been picked or to just for users to start using a domain?21:34
dstanekfor some reason i thought that v3 force you to supply a domain when creating a user21:35
ayoungdstanek, not according to the unit test21:35
ayoungdstanek, to make this work, here is what I would have to do:21:35
ayoung1.  replace the decorator code with inlie code that does the same thing (not a big deal, we want to head that way anyway)21:35
*** voelzmo has quit IRC21:36
ayoung2. validate the auth token, becuase right now that is done inside the validation logic.  Don't have the domiaiNid yet21:36
ayoung3.  check the user object from the request, and, if it is missing the domain_id, populate it from the token21:36
ayoungand...I think it wouild need logic to look for both the domain_id or the domain_name, based on other APIs21:37
openstackgerritSteve Martinelli proposed openstack/keystone-specs: add a README file to the superseded spec folder  https://review.openstack.org/41386921:37
ayoungdstanek, so, while it is do-able, it is ugly.  And, AFAICT, it has never really worked21:38
ayoungwell, it has if you used project scoped tokens, the v3 api with standard policy, and accepted role:admin for anything21:38
ayoungthe moment you try to enforce scope, it blows up21:38
ayoungdstanek, I'm almost tempted to work through it just to see how bad the code actually is21:39
ayoungits the token validation part that I don;t like ATM21:39
samueldmqayoung: lbragstad easy +A https://review.openstack.org/#/c/41386921:40
openstackgerritSteve Martinelli proposed openstack/keystone: Remove stevedore warning when building docs  https://review.openstack.org/41750821:40
ayoungsamueldmq, https://review.openstack.org/#/c/413869/4/superseded/README.rst  Does not list the spec you removed in this review21:41
samueldmqayoung: which one ?21:42
ayounghttps://review.openstack.org/#/c/413869/4/specs/keystone/ocata/token-provider-cleanup.rst samueldmq21:42
samueldmqayoung: that's true :( stevemar ^21:44
stevemaroh damn, nice catch ayoung21:46
stevemarumm, anyone know why i moved it there? :)21:46
*** nkinder has quit IRC21:48
*** voelzmo has joined #openstack-keystone21:50
*** thorst_ has quit IRC21:50
*** edtubill has quit IRC21:52
*** stingaci has joined #openstack-keystone21:52
lbragstadi think some of the tables we have in our api-ref contains lists and they don't render properly21:54
*** voelzmo has quit IRC21:54
lbragstadhttp://developer.openstack.org/api-ref/identity/v3/index.html?expanded=create-service-detail,create-endpoint-detail for example21:54
*** spzala has quit IRC21:56
samueldmqlbragstad: those are rendering okay to me21:56
samueldmqlbragstad: is there anything specific on the tables you think they're rendering wrongly ?21:57
lbragstadsamueldmq if you look closely at the 'Request Parameters' table21:57
samueldmqlbragstad: nvm, it's the lists, not the tables themselves21:57
* samueldmq facepalm21:57
lbragstadright - it looks like we're trying to use lists inside the table21:58
samueldmq++21:58
*** stingaci has quit IRC21:58
lbragstadand it's not rendering properly...21:58
lbragstadi had to re-read it 5 times to figure out what was going on21:58
samueldmq10 times here22:00
samueldmq:)22:00
*** catintheroof has joined #openstack-keystone22:01
openstackgerritSamuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add support for endpoint group CRUD  https://review.openstack.org/41726322:02
*** nkinder has joined #openstack-keystone22:02
*** thorst_ has joined #openstack-keystone22:05
*** jaugustine_ has joined #openstack-keystone22:09
samueldmqI can call it a day, I am checking out for the week22:09
samueldmqhave a great weekend, keystoners22:09
dstaneksamueldmq: you too22:09
lbragstadsamueldmq thanks for the help today - have a nice weekend!22:10
samueldmqdstanek: lbragstad o/22:10
*** thorst_ has quit IRC22:11
samueldmqlbragstad: suer22:11
*** jerrygb has quit IRC22:13
*** jaugustine_ has quit IRC22:13
*** jaugustine_ has joined #openstack-keystone22:17
*** dave-mccowan has quit IRC22:22
openstackgerritSamuel Pilla proposed openstack/keystone: Add password expiration queries for PCI-DSS  https://review.openstack.org/40389822:29
openstackgerritGage Hugo proposed openstack/keystone: Fixed not in toctree warnings when building docs  https://review.openstack.org/41749722:34
openstackgerritLance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER documentation  https://review.openstack.org/41752822:39
*** asettle has joined #openstack-keystone22:39
openstackgerritLance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER documentation  https://review.openstack.org/41752822:40
*** lamt has quit IRC22:43
*** jaugustine_ has quit IRC22:44
*** jaugustine has quit IRC22:44
*** asettle has quit IRC22:48
*** diazjf has joined #openstack-keystone22:57
*** diazjf has quit IRC22:59
*** thorst has joined #openstack-keystone23:00
*** thorst has quit IRC23:03
*** edmondsw has quit IRC23:06
openstackgerritLance Bragstad proposed openstack/keystone: [api-ref] Clean up OS-EP-FILTER association docs  https://review.openstack.org/41753323:08
lbragstadstevemar ok - i think i'm done with the OS-EP-FILTER docs ^23:08
*** blake has joined #openstack-keystone23:17
openstackgerritDavid Stanek proposed openstack/python-keystoneclient: Do not log binary data during request  https://review.openstack.org/41626023:31
*** jamielennox|away is now known as jamielennox23:39
*** spzala has joined #openstack-keystone23:41

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!