Thursday, 2016-09-01

rderosedstanek: saw your comment regarding 362501; there is a follow up patch just in case someone has already migrated 105.00:07
rderosedstanek: here is the follow up patch: https://review.openstack.org/#/c/362510/00:07
rderosedstanek: I'd also add that we've fixed migrations in the past00:08
dstanekrderose: yeah, i saw that. didn't get around to testing the behavior yet00:10
rderosedstanek: and I'm trying to think of the risks for operators, I think it would be fine00:11
openstackgerritAdrian Turjak proposed openstack/keystone-specs: Optional MFA via password + TOTP auth plugin  https://review.openstack.org/34511300:11
dstanekwhy would you need two commits for this?00:11
rderosedstanek: in case someone has migrated to 105 and then upgrades again00:11
rderoseupgrades from that point00:11
dstaneki mean what's the point of the first review? if they don't have it applied then both get applied at the same time. if the have 105 then they just get the second00:12
rderosedstanek: yeah, the first patch they get it applied and if applied, the second migration is ignored.00:13
rderoseAnd right, if they have 105, the second patch would fix that column00:13
rderosedstanek: I recognize this is not ideal, but we need to be able to make adjustments like this in the middle of a release.00:14
rderosedstanek: at least that's my opinion :)00:14
dstanekrderose: you did in a follow up00:15
rderosetrue00:15
dstaneki don't get why you need to change the original if you have a followup migration00:15
rderosebut thought I would fix the 105 migration00:15
dstanekthen you have two paths that a user could have use to migrate. makes debugging later harder00:16
rderosedstanek: good point, but the fix to the original patch is cleaner and less code00:16
rderosedstanek: and like I said, we've fixed migrations in the past00:16
dstaneki don't think we can if we want the ability to release close to master00:17
dstanekit's a side effect that we'll have to deal with00:17
rderosedstanek: yeah00:17
dstanekit's only less code if you didn't have to do the followup. since you do it's just more code00:17
*** rakhmerov has quit IRC00:18
dstanekto me this is like fixing a commit in git...you merged so now there is no fixing00:19
dstanekonly with a new commit00:19
rderosedstanek: so no need for the second patch?  is that your point00:20
rderosedstanek: okay, I see your point.  you saying there is no fixing the original migration00:21
dstaneki don't see the point00:23
*** rakhmerov has joined #openstack-keystone00:23
dstanekrderose: i'm interested to see other weigh in on that patch00:24
rderosedstanek: sounds good00:25
*** browne has quit IRC00:32
*** sto has quit IRC00:46
*** sto has joined #openstack-keystone00:46
*** gyee has quit IRC00:51
*** chrichip has quit IRC00:52
*** chrichip has joined #openstack-keystone00:53
*** Michaellaneous has quit IRC01:01
*** spzala has quit IRC01:02
*** chlong has joined #openstack-keystone01:18
*** tqtran has quit IRC01:19
*** wangqun has joined #openstack-keystone01:27
*** esp has quit IRC01:32
*** spzala has joined #openstack-keystone01:38
*** chrichip has quit IRC01:38
*** EinstCrazy has joined #openstack-keystone01:39
*** EinstCrazy has quit IRC01:39
*** EinstCrazy has joined #openstack-keystone01:39
*** chrichip has joined #openstack-keystone01:39
*** hockeynut has quit IRC01:43
*** spzala has quit IRC01:43
*** ayoung has joined #openstack-keystone01:43
*** ChanServ sets mode: +v ayoung01:43
*** spzala has joined #openstack-keystone01:45
*** davechen has joined #openstack-keystone01:53
*** esp has joined #openstack-keystone01:58
*** woodster_ has quit IRC01:59
*** itisha has quit IRC02:00
*** EinstCra_ has joined #openstack-keystone02:04
*** spzala has quit IRC02:05
*** esp has quit IRC02:05
*** sdake has quit IRC02:06
*** EinstCrazy has quit IRC02:08
*** chrichip has quit IRC02:16
*** chrichip has joined #openstack-keystone02:17
*** tqtran has joined #openstack-keystone02:18
*** tqtran has quit IRC02:22
*** rreimberg has quit IRC02:28
*** edtubill has joined #openstack-keystone02:28
*** EinstCra_ has quit IRC02:36
*** EinstCrazy has joined #openstack-keystone02:37
*** jamielennox|away is now known as jamielennox02:41
*** su_zhang has joined #openstack-keystone02:53
*** chrichip has quit IRC02:54
*** chrichip has joined #openstack-keystone02:55
*** esp has joined #openstack-keystone03:03
stevemarrderose: dstanek wheres that patch at now? i still think there should just be one migration to solve it :\03:14
stevemarlbragstad: o/03:14
rderosestevemar: fix the original patch?  Or, just have the follow up patch?03:15
stevemarrderose: have a migration 002 that fixes it, should never alter original migrations03:15
rderosestevemar: we've fixed migrations in the past, so that is what I was thinking03:15
rderosestevemar: okay, makes sense03:15
rderosestevemar: have the solution now, so it will be a piece of cake03:16
rderosestevemar: will take care of in the morning03:16
stevemarrderose: coolio03:16
rderose:)03:17
stevemarrderose: that can also go into rc-1, so no worries03:17
rderoseokay, cool03:17
rderoseI may way until early next week then (maybe)03:18
rderosestevemar: driving back home to phoenix tomorrow afternoon03:18
rderoserelocating home :)03:18
stevemarrderose: oooohhh that's goodness03:18
rderosestevemar: yeah, totally excited03:19
stevemarrderose: try to post whatever you have, someone else can take over if necessary03:19
stevemarwe're a team <303:19
rderosecool, will do03:19
stevemarfeenicks03:19
stevemarwhoever decided to spell feenicks as phoenix is just cruel03:19
rderoseyeah03:19
stevemarprobably the same person who decided to spell it quinoa03:19
stevemarkeynua, obviously03:20
rderosefeenicks ;) not my original home, but my home for the past 8 years03:20
rderoseprobably03:20
stevemarrderose: so next midcycle there right?03:20
stevemarso i can escape the cold03:20
rderoseyeah, already have approval03:20
rderosetotally, it will be perfect03:20
openstackgerritMerged openstack/keystone: Add documentation on how to set a user's tenant.  https://review.openstack.org/36329203:21
rderosebig campus in AZ, so there will be plenty of room03:21
stevemarsee what all the hoopla is about at intel03:21
rderosehahaha03:21
rderosehey and we've got hoops there03:21
rderosehave to get you on court03:21
rderosebig man03:22
openstackgerritMerged openstack/keystone: Update sample uwsgi config for lazy-apps  https://review.openstack.org/36392903:22
stevemarrderose: i'm great as long as no one else taller than me is playing03:22
rderoseyou Canadian guys do play ball don't you?03:22
rderosehahaha03:23
openstackgerritSteve Martinelli proposed openstack/keystone: Relax the requirement for mappings to result in group memberships  https://review.openstack.org/35811103:24
stevemarrderose: not well :P03:31
rderose:) it's all good03:32
rderosewe have volley ball courts as well, ping pong...03:32
*** davechen has quit IRC03:34
*** davechen has joined #openstack-keystone03:35
stevemarrderose: you all booked for barcelona?03:39
rderosestevemar: just got approval yesterday03:40
stevemarrderose: nice03:40
rderosestevemar: i'll be there03:40
rderoseyeah :)03:40
stevemarnow to submit expense reports :\03:42
rderosefun :)03:43
*** ayoung has quit IRC03:47
*** dikonoor has joined #openstack-keystone03:48
*** su_zhang has quit IRC03:48
*** chrichip has quit IRC03:48
*** su_zhang has joined #openstack-keystone03:48
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250103:53
*** su_zhang has quit IRC03:53
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250103:58
rderosestevemar: ^ this should be ready04:00
stevemarrderose: nice04:02
*** spzala has joined #openstack-keystone04:05
*** jamielennox is now known as jamielennox|away04:05
*** su_zhang has joined #openstack-keystone04:07
*** spzala has quit IRC04:10
*** edtubill has quit IRC04:24
*** su_zhang has quit IRC04:24
*** su_zhang has joined #openstack-keystone04:24
*** esp has quit IRC04:25
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250104:27
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250104:28
*** su_zhang has quit IRC04:28
*** links has joined #openstack-keystone04:32
openstackgerritMerged openstack/keystone: Pre-cache new tokens  https://review.openstack.org/30914604:33
*** Gorian has joined #openstack-keystone04:35
*** jraim has quit IRC04:36
*** jraim has joined #openstack-keystone04:36
*** esp has joined #openstack-keystone04:37
*** zhiyan has quit IRC04:38
*** nikhil has quit IRC04:38
*** samueldmq has quit IRC04:38
*** nikhil has joined #openstack-keystone04:40
*** zhiyan has joined #openstack-keystone04:40
*** samueldmq has joined #openstack-keystone04:42
*** ChanServ sets mode: +v samueldmq04:42
*** dtroyer has quit IRC04:44
*** spedione|AWAY has quit IRC04:44
*** dtroyer has joined #openstack-keystone04:44
*** esp has quit IRC04:45
*** spedione|AWAY has joined #openstack-keystone04:49
*** spedione|AWAY is now known as spedione04:49
*** roxanaghe has quit IRC04:56
*** pcaruana has quit IRC04:57
*** wangqun_ has joined #openstack-keystone04:59
*** wangqun has quit IRC05:00
*** cargonza has quit IRC05:04
*** jamielennox|away is now known as jamielennox05:04
*** cargonza has joined #openstack-keystone05:05
*** roxanaghe has joined #openstack-keystone05:11
*** AndyWojo has quit IRC05:13
*** wolsen has quit IRC05:13
*** andrewbogott has quit IRC05:13
*** AndyWojo has joined #openstack-keystone05:14
*** wolsen has joined #openstack-keystone05:14
*** andrewbogott has joined #openstack-keystone05:15
*** sdake has joined #openstack-keystone05:23
*** roxanaghe has quit IRC05:26
*** maestropandy has joined #openstack-keystone05:28
*** roxanaghe has joined #openstack-keystone05:31
*** roxanaghe has quit IRC05:38
*** richm has quit IRC05:39
*** adriant has quit IRC05:49
*** edmondsw has joined #openstack-keystone05:59
*** edmondsw has quit IRC06:00
*** maestropandy has left #openstack-keystone06:01
*** BharatK_ has joined #openstack-keystone06:06
*** rcernin has quit IRC06:08
*** amakarov_away has quit IRC06:09
*** rakhmerov has quit IRC06:10
*** tsufiev has quit IRC06:10
*** amakarov has joined #openstack-keystone06:12
*** rakhmerov has joined #openstack-keystone06:13
*** tsufiev has joined #openstack-keystone06:15
*** divyakkonoor has joined #openstack-keystone06:18
*** jlk` has joined #openstack-keystone06:21
*** jlk has quit IRC06:21
*** dikonoor has quit IRC06:21
*** pcaruana has joined #openstack-keystone06:30
*** rcernin has joined #openstack-keystone06:41
*** tsufiev has quit IRC06:41
*** amakarov has quit IRC06:41
*** rakhmerov has quit IRC06:42
*** rcernin has quit IRC06:45
*** rcernin has joined #openstack-keystone06:45
openstackgerritEric Brown proposed openstack/keystone: Correct typo in mapping_populate command's help  https://review.openstack.org/36409206:45
*** rakhmerov has joined #openstack-keystone06:49
*** tsufiev has joined #openstack-keystone06:53
*** amakarov has joined #openstack-keystone06:56
*** tesseract- has joined #openstack-keystone07:03
*** spzala has joined #openstack-keystone07:06
*** spzala has quit IRC07:10
*** jamielennox is now known as jamielennox|away07:17
*** jpena|off is now known as jpena07:18
*** BharatK_ has quit IRC07:18
*** nkinder has quit IRC07:21
*** jlvillal has quit IRC07:22
*** jlvillal has joined #openstack-keystone07:23
*** nkinder has joined #openstack-keystone07:24
openstackgerritMerged openstack/keystone: Relax the requirement for mappings to result in group memberships  https://review.openstack.org/35811107:38
*** sdake has quit IRC07:43
*** sdake has joined #openstack-keystone07:44
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-keystone08:00
*** jaosorior has joined #openstack-keystone08:04
*** BharatK has joined #openstack-keystone08:15
*** BharatK has quit IRC08:16
*** BharatK has joined #openstack-keystone08:17
bretono/08:18
*** BharatK has quit IRC08:24
*** asettle has joined #openstack-keystone08:26
*** BharatK has joined #openstack-keystone08:28
*** joerch has joined #openstack-keystone08:47
*** dobson` has joined #openstack-keystone08:53
*** jhesketh_ has joined #openstack-keystone08:54
*** HenryG_ has joined #openstack-keystone08:54
*** jlvillal_ has joined #openstack-keystone08:57
*** jlvillal has quit IRC08:58
*** afred312 has quit IRC08:58
*** jhesketh has quit IRC08:58
*** darrenc has quit IRC08:58
*** lamt has quit IRC08:58
*** bapalm has quit IRC08:58
*** dobson has quit IRC08:58
*** HenryG has quit IRC08:58
*** anteaya has quit IRC08:58
*** brad[] has quit IRC08:58
*** aloga has quit IRC08:58
*** Anticimex has quit IRC08:58
*** jidar has quit IRC08:58
*** bapalm has joined #openstack-keystone08:59
*** Anticimex has joined #openstack-keystone09:00
*** aloga has joined #openstack-keystone09:00
*** jlvillal_ is now known as jlvillal09:00
*** jlvillal is now known as Guest7795609:01
*** afred312 has joined #openstack-keystone09:03
*** darrenc has joined #openstack-keystone09:03
*** lamt has joined #openstack-keystone09:03
*** anteaya has joined #openstack-keystone09:03
*** brad[] has joined #openstack-keystone09:03
*** jidar has joined #openstack-keystone09:03
*** asettle has quit IRC09:08
*** asettle has joined #openstack-keystone09:12
*** mvk has joined #openstack-keystone09:13
*** HenryG_ is now known as HenryG09:17
*** BharatK has quit IRC09:20
*** namnh has joined #openstack-keystone09:21
*** HenryG has quit IRC09:29
*** HenryG has joined #openstack-keystone09:29
*** wangqun_ has quit IRC09:35
joerchHey guys, quick question: I tried to use auth type v3unscopedsaml with Keystone as IdP (=Keystone2Keystone-federation), but it does not accept the SP's SAML request @ v3/auth/OS-FEDERATION/saml2/ecp. Is that expected behavior? Is there another way (plugin?) to use K2K-Authentication with the openstack cli client? Thanks in advance!09:40
*** daemontool has joined #openstack-keystone09:45
*** davechen has left #openstack-keystone09:46
*** code-R has joined #openstack-keystone09:59
*** sdake has quit IRC10:01
*** asettle has quit IRC10:05
*** richm has joined #openstack-keystone10:09
openstackgerritDavanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c  https://review.openstack.org/31843510:10
openstackgerritDavanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c  https://review.openstack.org/31843510:10
*** code-R_ has joined #openstack-keystone10:13
*** namnh has quit IRC10:15
*** code-R has quit IRC10:16
*** asettle has joined #openstack-keystone10:16
*** jhesketh_ is now known as jhesketh10:20
*** tqtran has joined #openstack-keystone10:20
openstackgerritMikhail Nikolaenko proposed openstack/keystone: Block global roles implying domain specific roles  https://review.openstack.org/36421610:22
*** maestropandy1 has joined #openstack-keystone10:25
*** tqtran has quit IRC10:25
bretonwhy don't we emit notifications on login failure/success?10:35
*** sigmavirus|awa is now known as sigmavirus10:37
*** EinstCrazy has quit IRC10:40
*** asettle has quit IRC10:48
*** maestropandy1 has quit IRC10:50
openstackgerritMikhail Nikolaenko proposed openstack/keystone: Add domain check in domain-specific role implication  https://review.openstack.org/35126411:03
*** maestropandy has joined #openstack-keystone11:30
*** maestropandy has left #openstack-keystone11:31
*** NishaYadav has joined #openstack-keystone11:38
*** asettle has joined #openstack-keystone11:39
NishaYadavo/11:40
samueldmqmorning keystone11:42
amakarovhi!11:44
openstackgerritUkesh Kumar proposed openstack/keystone: check for user existence, for role add to user  https://review.openstack.org/36260611:44
marekdsamueldmq: morning.11:47
marekdsamueldmq: Identity API v2.0 is going to be removed in O or Q release?11:48
marekdcause release notes for mitaka claim it will be Q, not sure if typo or not.11:48
*** jpena is now known as jpena|lunch11:56
dstanekgood morning all12:02
*** jaosorior has quit IRC12:06
*** jaosorior has joined #openstack-keystone12:06
marekddstanek: hey!12:08
*** NishaYadav has quit IRC12:09
*** NishaYadav has joined #openstack-keystone12:13
*** BharatK has joined #openstack-keystone12:16
openstackgerritMikhail Nikolaenko proposed openstack/keystone: Block global roles implying domain specific roles  https://review.openstack.org/36421612:20
*** BharatK has quit IRC12:21
* NishaYadav waves hello \o12:24
samueldmqmarekd: I am not aware of removing v2.0 API in O or Q12:29
samueldmqmarekd: dstanek morning12:29
*** mvk has quit IRC12:30
*** raildo has joined #openstack-keystone12:30
odyssey4medolphm dstanek lbragstad FYI os_keystone now has nginx/uwsgi configuration options - and they're tested and voting for the role :)12:32
samueldmqmarekd: looks like some v2.0 APIs will be removed in Q, except for auth and ec212:42
samueldmqmarekd: https://review.openstack.org/#/c/251530/13/releasenotes/notes/deprecate-v2-apis-894284c17be881d2.yaml12:42
*** Kimmo___ is now known as Kimmo_12:44
openstackgerritAlexander Makarov proposed openstack/keystone: Unified delegation trust driver  https://review.openstack.org/29187112:45
NishaYadavI am really grateful to everyone for helping me complete Outreachy internship. Glad to inform that I got accepted for the Travel Support Program. Also, a pesentation submitted by samueldmq, vkmc and me - "A dice with several faces: Coordinators, mentors and interns on OpenStack Outreachy internships" got accepted for inclusion.12:46
NishaYadavA big thanks to samueldmq, vkmc, rodrigods, stevemar, dolphm, henrynash and all other contributors.12:46
NishaYadavTo share my journey and express gratitude, I recently wrote an article, https://nishayadavsite.wordpress.com/2016/08/31/wrapping-up-openstack-outreachy-internship/12:47
samueldmqNishaYadav: nice, congratulations :-)12:48
dstanekodyssey4me: nice12:49
NishaYadavsamueldmq, :D12:49
*** markvoelker has joined #openstack-keystone12:50
NishaYadavdstanek, thanks to you too ^^, sorry looked for your IRC nick using david :/12:50
*** links has quit IRC12:51
dstanekNishaYadav: your welcome and congrats12:52
dstanekthat's exciting12:52
NishaYadavdstanek, thank you :D12:52
*** jpena|lunch is now known as jpena12:55
*** spzala has joined #openstack-keystone12:59
*** andreykurilin has left #openstack-keystone13:02
*** jdennis has quit IRC13:06
*** rreimberg has joined #openstack-keystone13:07
*** markvoelker has quit IRC13:07
*** ezpz has joined #openstack-keystone13:07
*** arunkant has quit IRC13:08
*** su_zhang has joined #openstack-keystone13:15
raildocongrats NishaYadav!13:18
NishaYadavthanks raildo for help :D13:20
*** jdennis has joined #openstack-keystone13:21
raildoNishaYadav, np, you're doing an amazing work here, don't go away after your internship :)13:22
NishaYadavraildo, sure I want to keep contributing13:22
raildoNishaYadav, awesome13:22
NishaYadavraildo, thanks :D13:23
*** markvoelker has joined #openstack-keystone13:23
*** asettle is now known as asettle-afk13:26
*** markvoelker has quit IRC13:28
*** roxanaghe has joined #openstack-keystone13:33
marekdsamueldmq: exactly - i saw the same thing, was just wodering if this is really Q or just a typo and O should be there.13:37
marekddstanek: have knowledge on that? ^^13:37
*** roxanaghe has quit IRC13:37
marekddstanek: i was asking samueldmq whether V2 API are going to be removed in O or Q release.13:38
samueldmqmarekd: I think that's correct, we are giving a 4-release deprecation13:38
marekdsamueldmq: usually it was only 2 releases, but that's fine.13:39
samueldmqwe decided that 2 releases was too short for removing a set of APIs13:39
raildomarek, samueldmq actually I hope to make the v3-only jobs voting by Otaca13:41
raildoat least we can avoid to have new issues related to the v213:42
samueldmqraildo: yeah, but other services use auth13:42
raildoso, as we said in the v2-deprecation patch, we will remove on O or Q release13:42
samueldmqand we're not removing v2.0 auth and ec2 in Q13:42
raildosamueldmq, now on newton, we fixed a lot of issues to make this services use keystoneauth session13:43
stevemaro/13:43
*** ayoung has joined #openstack-keystone13:43
*** ChanServ sets mode: +v ayoung13:43
samueldmqraildo: nice, that's a great step13:43
*** gordc has joined #openstack-keystone13:44
raildoso, the core services doesn't have issues on this direction13:44
samueldmqraildo: I am just saying services using v3.0 or v2.0 auth is orthogonal to remove v2.0 deprecated APIs (not auth)13:44
raildoand we have this v3-only jobs, to find any problem related to it13:44
raildosamueldmq, ++13:44
marekdraildo: cool!13:44
samueldmqstevemar: morning13:44
stevemarNishaYadav: glad to hear you got travel support :)13:45
raildostevemar, do you believe we can make this v3-only jobs voting on Otaca?13:45
raildoI think it would be better talk to TC about this, and have an agreement in barcelona13:45
stevemarraildo: sure, why not, sounds like a reasonable expectation13:46
stevemarraildo: are the v3 only jobs passing or failing today?13:46
raildostevemar, they are passing, I'll generate some graphics with this jobs behavior13:46
stevemarraildo: coolio13:46
*** NishaYadav has quit IRC13:46
raildoin the last 2-3 months13:46
*** asettle-afk has quit IRC13:47
*** asettle-afk has joined #openstack-keystone13:48
lbragstaddstanek for key_hash - if we make it non-nullable13:48
lbragstadwhat would we want it to have for a default value?13:48
*** openstackgerrit has quit IRC13:49
*** openstackgerrit has joined #openstack-keystone13:49
samueldmqstevemar: raildo: so I think ppl want data to show the v3 jobs are stable13:50
samueldmqand will not increase the fail rate of their set of jobs13:50
stevemarsamueldmq: i would want that :)13:50
raildosamueldmq, exactly :)13:51
samueldmq:-)13:51
samueldmqraildo: so it might be intersting to watch the fail rate very close13:51
samueldmqand try to mitigate any issue13:51
raildostevemar, samueldmq I'll get this information and come back to talk about it, asap13:51
samueldmqthe fail rate of the job must be almost equal to 013:51
samueldmqraildo: nice13:52
*** asettle-afk has quit IRC13:52
samueldmqstevemar: is there anything that needs immediate attention today/tomorrow?13:53
stevemarsamueldmq: https://review.openstack.org/#/c/362501/ and https://review.openstack.org/#/c/355618/13:53
raildosamueldmq, stevemar for example this job on ceilometer http://status.openstack.org/openstack-health/#/job/gate-ceilometer-dsvm-functional-mongodb-identity-v3-only13:53
raildothe failure rate is close to 013:54
samueldmqstevemar: okay, so we're holding release on those ?13:54
stevemarsamueldmq: yes13:54
samueldmqstevemar: we go for triggers then?13:54
stevemarsamueldmq: well thats the choice :)13:54
samueldmqstevemar: ok, so we have until tomorrow?13:54
stevemari think i may propose to cut today, was waiting for lbragstad and dolphm to come online13:54
lbragstadstevemar i'13:54
lbragstadi'm here13:54
*** Guest77956 is now known as jlvillal13:55
stevemarsamueldmq: i think it's better to do something about it today...13:55
stevemarlbragstad: yo13:55
samueldmqstevemar: okay, I am on it now13:55
*** rodrigods has quit IRC13:55
*** rodrigods has joined #openstack-keystone13:55
lbragstaddolphm are you around?13:55
stevemarlbragstad: so i'm thinking about proposing the milestone3 driver based on current master13:55
samueldmqstevemar: lbragstad: is there a high risk of merging that in last minute and break things ?13:55
lbragstadsamueldmq I personally don't think so - but others might feel differently13:56
samueldmqlbragstad: do we have tests to make sure the rolling upgrade actually works ?13:56
samueldmqmaking requests during the upgrade process13:57
lbragstadsamueldmq rolling upgrades or credential encryption?13:57
lbragstador both?13:57
samueldmqlbragstad: both13:57
lbragstadno13:57
lbragstadwe don't have a rolling upgrade test framework yet13:57
lbragstadi did it manually13:58
lbragstadand documented it13:58
* lbragstad https://gist.github.com/lbragstad/ddfb10f9f9048414d1f781ba006e95d1#upgrade13:58
samueldmqlbragstad: cool13:58
samueldmqlbragstad: is it too bad if we don't get that in this release?13:59
dstaneklbragstad: why do you need a default? after the contract runs everything will be encrypted right?13:59
lbragstaddstanek a bunch of tests fail if you set nullable=False for key_hash13:59
dstaneklbragstad: are they valid tests?14:00
samueldmqmaybe we gotta figure out the cause of the failures14:00
lbragstadkeystone.tests.unit.test_sql_upgrade.SqlDataMigrationUpgradeTests.test_start_version_db_init_version14:00
lbragstadkeystone.tests.unit.test_sql_upgrade.PostgreSQLOpportunisticFullMigration.test_migration_002_migrate_unencrypted_credentials14:00
lbragstadand a bunch in test_backend_sql14:00
*** su_zhang has quit IRC14:01
lbragstadits probably because we are inserting things without key_hash set in the reference and the backend doesn't allow it to be null14:01
*** su_zhang has joined #openstack-keystone14:01
*** ddieterly has joined #openstack-keystone14:01
dstanekok, let me take a deeper look. post migration though there should be no way to get a null in there so those tests bad be broken14:01
dstaneki can see why the migration would fail though14:02
lbragstaddstanek correct - it should be nullable=False because Newton code would always pass in a key_hash14:02
lbragstaddstanek can we do alter tables in contract?14:02
lbragstadand switch it to null when we clean up the old rows?14:03
lbragstader - old columns?14:03
*** michauds has joined #openstack-keystone14:03
*** asettle-afk has joined #openstack-keystone14:03
*** jaosorior has quit IRC14:04
samueldmqlbragstad: I think that's reasonable, as it won't break any node14:04
*** asettle-afk is now known as asettle14:04
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561814:05
*** su_zhang has quit IRC14:06
lbragstaddstanek addressed all your other comments ^14:06
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250114:06
lbragstadstevemar what is your thought on the trigger stuff?14:08
stevemarlbragstad: its a lose-lose for me :)14:12
stevemarlbragstad: i either piss the keystone team off, or the rest of openstack :)14:12
*** ravelar has joined #openstack-keystone14:13
stevemarlbragstad: even with the code to make it optional that dolphm proposed, the bp is still not yet complete, the grenade and devstack work are not merged14:13
stevemarand i need to give the release team a hash today14:13
stevemarif i cut out the credential encryption work, i push the decision about triggers to whichever poor soul is the ptl after me14:14
samueldmqhehe14:14
stevemarlbragstad: and that is my summary about the situation14:15
lbragstadok - what about the technical details - how do you feel about it?14:15
*** itisha has joined #openstack-keystone14:15
samueldmqI'd tend to be conservative on merging things in the last minute14:16
samueldmqbut perhaps fixes could be backported if needed ?14:16
lbragstadit's a feature14:16
lbragstadit can't be backported14:16
samueldmqyes, I mean, if we merge it and we discover bugs14:16
samueldmqfixes could be backported14:17
lbragstadoh - right14:17
lbragstadstevemar the code left to propose to keystone is two change (docs and the implementation), the grenade change isn't going to merge until we merge the docs,14:20
stevemarlbragstad: in terms of the technical details, i think for the specific case we're looking at, triggers is fine.14:21
stevemarlbragstad: the credentials backend is barely used14:21
*** tqtran has joined #openstack-keystone14:22
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250114:24
dstanekstevemar: we're tying to make it more useful!14:25
*** spedione is now known as spedione|AWAY14:26
*** tqtran has quit IRC14:26
stevemardstanek: i know :)14:26
odyssey4melbragstad sooo... is the online keystone upgrade thing a go, or is the idea dying in a fire? has code for it actually been implemented yet, and is it ready to build out something to test it out in OSA?14:28
odyssey4meI see that the use of triggers is causing quite a conversation on the ML.14:28
*** spedione|AWAY is now known as spedione14:28
lbragstadodyssey4me we have an implementation that is based on the triggers approach up for review14:28
lbragstadodyssey4me the encryption of credentials at rest in keystone was a thing we wanted to land this cycle and i ended up picking up with work after we made the tentative decision to go with triggers14:29
lbragstadodyssey4me you can find the implementation here - https://review.openstack.org/#/c/355618/4114:30
lbragstadodyssey4me the documentation is here - https://review.openstack.org/#/c/354497/514:30
lbragstadodyssey4me and my informal walk-through of a rolling upgrade is here - https://gist.github.com/lbragstad/ddfb10f9f9048414d1f781ba006e95d1#upgrade14:30
odyssey4melbragstad thanks, I'll be keeping an eye on those14:31
lbragstadodyssey4me np14:31
*** NishaYadav has joined #openstack-keystone14:33
*** NishaYadav is now known as Guest1574314:33
*** ddieterly is now known as ddieterly[away]14:34
*** slberger has joined #openstack-keystone14:34
*** tonytan4ever has joined #openstack-keystone14:47
openstackgerritRichard Avelar proposed openstack/keystone: POC sql query revoked tokens  https://review.openstack.org/35937114:49
*** erhudy has joined #openstack-keystone14:49
lbragstadrderose congrats!!14:49
raildocongrats rderose!14:50
*** haplo37__ has joined #openstack-keystone14:52
rderosewhat?14:53
lbragstadrderose checkout the mailing list ;)14:53
stevemar:]14:55
*** ddieterly[away] is now known as ddieterly14:56
dstanekrderose: !14:57
*** edtubill has joined #openstack-keystone14:58
marekdstevemar:  got a question for ya. So, if nova,cinder, etc talks to keystone over identity api v2.0 and I as a user use v3, is it all going to work correctly?14:59
dstanekmarekd: yes believe it will be fine. the only thing i remember as being a problem is catalog things created with one version don't show up in the other, but i don't remember specifics there15:01
bknudsonwhy are nova, cinder, etc., talking to keystone?15:01
bknudsonif the auth token middleware is talking v2 then users that aren't in the default domain are going to fail15:01
marekdbknudson: say, uuid tokens and auth.15:01
marekdbknudson: ok, makes sense.15:02
marekdbknudson: thanks15:02
marekddstanek: ty15:03
*** pcaruana has quit IRC15:03
stevemarmarekd: what bknudson and dstanek said15:03
marekdstevemar: sure15:03
stevemarmarekd: when setting up auth token middleware, make sure you set it up to use v315:03
stevemarjust specify the default domain for service acounts15:04
dstanekmarekd: can you just turn v2 off? :-D15:04
samueldmqrderose: congrats! :)15:04
bknudsonthe version is optional for auth token. it'll do version discovery if you don't set it.15:04
stevemardstanek: "Contrats"15:05
dstanekstevemar: did i make a boo boo?15:06
stevemardstanek: a tiny one15:06
dstanekstevemar: i've had enough success for the week and i'm ok with that15:06
*** rcernin has quit IRC15:06
stevemardstanek: :)15:11
stevemardstanek: you can retire now that you've fixed the cache15:11
dstanekstevemar: i can't15:12
stevemardstanek: few more years15:13
dstanekdidn't get a golden parachute15:13
openstackgerritRichard Avelar proposed openstack/keystone: POC sql query revoked tokens  https://review.openstack.org/35937115:16
*** joerch has quit IRC15:17
ayoungdoes keystone-manage fernet_rotate not accept an external key?  How are Key synchronizations supposed to be done across multiple keystone servers?15:17
openstackgerritRichard Avelar proposed openstack/keystone: POC sql query revoked tokens  https://review.openstack.org/35937115:18
*** NishaYadav has joined #openstack-keystone15:18
*** NishaYadav is now known as Guest6710315:18
*** mvk has joined #openstack-keystone15:19
*** Guest15743 has quit IRC15:19
bknudsongolden parachute means you get paid when you're fired15:19
*** nisha_ has joined #openstack-keystone15:19
*** browne has joined #openstack-keystone15:20
lbragstadayoung key sync is current done by an external process15:21
lbragstadusually using configuration management15:21
*** Guest67103 has quit IRC15:23
ayounglbragstad, yeah, but we should have a tool it calls to import/export keys15:23
*** sdake has joined #openstack-keystone15:23
ayounglbragstad, thinking along these lines https://etherpad.openstack.org/p/keystone-fernet-token-cms15:23
dstanekayoung: the expectation is that your existing configuration management tools would push out the key15:26
dstanekayoung: i think you can generate your own key, assuming it's valid15:26
dstanekpush that out and run the migration step....but lbragstad would have to confirm15:26
*** esp has joined #openstack-keystone15:26
ayoungdstanek, we provide the init and the rotate functions, but they assume the keys never leave the container.  If their is a CMS component, either the CMS generates the keys and distributes, or we rotate on one server and sync.  Either way, we should provide a contract for the CMS15:27
lbragstadyeah - rotation can be approached a number of ways15:28
ayounglbragstad, I15:28
lbragstadrotation on a single node and syncing from that node is how osa approached the problem15:28
ayounglbragstad, I'd like to see it like this:15:28
ayoungcms gets a new key to the server and puts it in a staging location, ideally, still encrypted.  then meystone-manage fernet-rotate-external  reads that file, decrypts it, and puts it into rotation15:29
dstanekayoung: so encrypt the encryption key?15:30
ayoungmaybe keystone-manage fernet-import and keystone-manage fernet-export15:30
ayoungdstanek, for transport?  Absoluetely15:30
dstanekayoung: you can already make your CMS create and distribute a key if you want15:30
ayoungusing asymmetric crypto.15:30
lbragstadayoung your key repository could be encrypted source control15:30
*** rcernin has joined #openstack-keystone15:31
lbragstador even ansible-vault15:31
*** BharatK has joined #openstack-keystone15:34
odyssey4meoh by the way, could barbican be used for fernet key distribution/storage?15:36
* redrobot pokes head in at the mention of barbican15:37
stevemarodyssey4me: i think someone had a topic about that for the summit15:37
bknudsonredrobot: keystone has all sorts of keys, for tokens and for credentials15:40
bknudsonayoung: the fernet keys are stored in a certain directory on disk. Users just get them from there and put them there.15:41
*** roxanaghe has joined #openstack-keystone15:44
lbragstadodyssey4me we have a spec proposed to keystone's backlog to make the fernet backend pluggable15:44
lbragstadodyssey4me one option once that is implemented is to introduce a driver for barbican15:45
*** nisha_ has quit IRC15:45
dstaneklbragstad: odyssey4me: and someone has already posted an implementation https://review.openstack.org/#/c/356499/15:45
*** nisha_ has joined #openstack-keystone15:46
*** BharatK_ has joined #openstack-keystone15:47
*** BharatK has quit IRC15:47
*** BjoernT has joined #openstack-keystone15:49
*** markvoelker has joined #openstack-keystone15:51
*** chrisshattuck has joined #openstack-keystone15:53
*** gyee has joined #openstack-keystone15:58
*** roxanaghe has quit IRC15:58
odyssey4meoh neat!16:01
* odyssey4me adds this to his watch list16:01
*** andrewbogott has quit IRC16:05
*** andrewbogott has joined #openstack-keystone16:05
*** jlk` is now known as jlk16:06
*** jlk has quit IRC16:06
*** jlk has joined #openstack-keystone16:06
*** rreimberg has quit IRC16:07
*** GB21 has joined #openstack-keystone16:11
*** ezpz has quit IRC16:11
*** BharatK_ has quit IRC16:21
*** ezpz has joined #openstack-keystone16:22
*** BharatK has joined #openstack-keystone16:23
*** NishaYadav has joined #openstack-keystone16:27
*** NishaYadav is now known as Guest2715716:27
*** nisha_ has quit IRC16:30
*** BharatK has quit IRC16:31
stevemarlbragstad: can you bring in dolphm's changes into your encryption patch?16:33
stevemarlbragstad: i'd rather have it as one thing16:33
*** su_zhang has joined #openstack-keystone16:36
*** daemontool has quit IRC16:40
*** su_zhang has quit IRC16:41
*** su_zhang has joined #openstack-keystone16:41
*** woodster_ has joined #openstack-keystone16:42
openstackgerritDolph Mathews proposed openstack/keystone: Only create triggers during a rolling upgrade  https://review.openstack.org/36072316:45
*** asettle has quit IRC16:49
*** asettle has joined #openstack-keystone16:49
*** asettle has quit IRC16:54
*** nisha_ has joined #openstack-keystone16:55
*** su_zhang has quit IRC16:57
*** markvoelker has quit IRC16:58
*** su_zhang has joined #openstack-keystone16:58
*** Guest27157 has quit IRC16:58
*** su_zhang has quit IRC16:58
*** tesseract- has quit IRC17:01
openstackgerritRon De Rose proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250117:05
*** edtubill has quit IRC17:06
*** mvk has quit IRC17:07
*** tqtran has joined #openstack-keystone17:07
*** amakarov is now known as amakarov_away17:09
*** tqtran has quit IRC17:12
openstackgerritDavid Stanek proposed openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250117:15
*** tonytan4ever has quit IRC17:16
*** code-R_ has quit IRC17:17
*** pauloewerton has joined #openstack-keystone17:20
stevemardtroyer: any chance you can take another look at https://review.openstack.org/36245017:24
*** dobson` has quit IRC17:26
*** snecklifter has joined #openstack-keystone17:27
*** ddieterly is now known as ddieterly[away]17:27
dtroyerstevemar: sure...17:28
dtroyer+A17:28
snecklifterayoung: hello, can I ask you about fermet tokens on tripleo HA?17:29
snecklifterstore keys on shared storage and run keystone-manage fermet_setup on one controller?17:30
*** rakhmerov has quit IRC17:30
sneckliftergood way forward or there be dragons? :)17:30
*** snecklifter is now known as snecklifter|brb17:31
*** tsufiev has quit IRC17:31
stevemarthanks dtroyer17:32
stevemarheading out for 2 hours, dolphm don't let the house burn down17:32
*** tsufiev has joined #openstack-keystone17:32
*** rakhmerov has joined #openstack-keystone17:35
ayoungsnecklifter|brb, was just having that conversation17:40
ayoungI think the general approach is to do that, but on the undercloud, and then publish the keystone-fernet-keys from undercloud to overcloud17:40
lbragstadstevemar yeah - i can do that working on addressing a couple final comments and I'll push a new revision17:41
openstackgerritMikhail Nikolaenko proposed openstack/keystone: [WIP] Move fernet utils to backend  https://review.openstack.org/35649917:42
*** chrisshattuck has quit IRC17:42
*** jpena is now known as jpena|away17:46
*** mvk has joined #openstack-keystone17:53
openstackgerritMerged openstack/keystone: Correct typo in mapping_populate command's help  https://review.openstack.org/36409217:55
*** dobson has joined #openstack-keystone17:56
*** chrisshattuck has joined #openstack-keystone17:56
*** phalmos has joined #openstack-keystone17:57
*** harlowja_ has joined #openstack-keystone17:58
openstackgerritMerged openstack/keystone: Document credential encryption  https://review.openstack.org/35449717:58
*** joerch has joined #openstack-keystone17:59
*** harlowja has quit IRC18:00
*** phalmos_ has joined #openstack-keystone18:00
*** ravelar has quit IRC18:01
*** ravelar has joined #openstack-keystone18:02
*** amakarov_away has quit IRC18:02
*** phalmos has quit IRC18:03
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561818:05
*** ravelar1 has joined #openstack-keystone18:06
*** ravelar has quit IRC18:06
lbragstadI'll rebase ^ once the other migration merges18:07
lbragstadcc dstanek dolphm stevemar18:07
*** tqtran has joined #openstack-keystone18:09
dolphmlbragstad: is henry's gating?18:09
dolphmlbragstad: what other migration?18:09
lbragstaddolphm  https://review.openstack.org/#/c/362501/18:09
dolphmlbragstad: ah, so we need to abandon henry's then18:10
*** ravelar1 has quit IRC18:10
*** ravelar has joined #openstack-keystone18:10
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561818:10
lbragstaddolphm modified the primary_key_hash() method ^ too18:10
*** hoonetorg has quit IRC18:11
dolphmlbragstad: gotcha18:11
dolphmlbragstad: L742? self.18:12
dolphmlbragstad: err https://review.openstack.org/#/c/355618/43/keystone/cmd/cli.py18:12
lbragstaddolphm line 49 - 50 here - https://review.openstack.org/#/c/355618/43/keystone/credential/providers/fernet/core.py18:13
*** su_zhang has joined #openstack-keystone18:13
henrynashdolpm: yes, we don't need mine, i"ll kill iy18:13
henrynashiy18:13
henrynashit18:13
henrynash!18:13
dolphmhenrynash: d18:13
dolphmo18:13
dolphmne18:13
dolphmhenrynash:18:14
dolphm!18:14
henrynasho18:14
henrynashk18:14
*** phalmos_ has quit IRC18:14
dolphmhenrynash: i thought you'd be gone by now :)18:14
henrynashrderose: hey, one question on the infamous 105 re-make, this means that sqlite DBs are left with the created_at column nullable, yes?18:15
*** hoonetorg has joined #openstack-keystone18:16
*** tonytan4ever has joined #openstack-keystone18:16
*** ntpttr has joined #openstack-keystone18:16
*** awayne has quit IRC18:17
*** tonytan4ever has quit IRC18:17
dolphmhenrynash: i believe he's gone for the weekend18:17
henrynashrderose: I am not at all worried that we don't support rolling updated with sqlite, but a but worried that even if you do a standard new install with sqlite, the column is still nullable..whereas the otehr DBS would have it non-nullable..18:17
henrynashdolphm: ah18:18
dolphmhenrynash: that sounds like something we should fix though... dstanek ^18:18
*** openstackgerrit has quit IRC18:18
*** openstackgerrit has joined #openstack-keystone18:18
lbragstaddolphm i'm just going to rebase on rderose's commit so that I can do the rename now18:19
lbragstadfrom 002 to 00318:19
dolphmlbragstad: ++18:19
lbragstadrunning tests now18:19
dolphmlbragstad: i meant to say - go ahead and do it now18:19
lbragstadshould have a new patch up shortly18:20
henrynashdolphm: I'm not sure why in https://review.openstack.org/#/c/362501/27/keystone/common/sql/contract_repo/versions/002_password_created_at_not_nullable.py we set the column nullable for sqlite...since we know there only new code running in the contract phase18:20
*** GB21 has quit IRC18:21
dolphmhenrynash: rderose: dstanek: that had to be a mistake, right?18:22
dstanekdolphm: henrynash: no, it's because the default doesn't work there and since we have code that depends on the default being automatic he left it nullable18:24
dolphmdstanek: isn't the only code that depends on it being automatic in the data migration?18:24
dstanekwe talked about this before, but I don't remember the deets18:24
henrynashdstanek: ah, but now...the new code does not rely on the default....it always puts a value in there, the need for the default was becasue while there is old code running it doesn't know to put in a value for this column18:25
dstaneki'd have to look, but i thought no. otherwise we wouldn't need a default18:25
dolphmhenrynash: dstanek: i proposed a change to switch it to non-nullable, but only running tests now https://review.openstack.org/#/c/364491/18:26
henrynashdstanek: actually, I think the sql model in code has the default in there....but I was pretty sure the code always set the value...18:27
dstanekthe tests fails18:28
dstanekhttp://paste.openstack.org/show/565766/18:28
dstanekthis is a case where sqlite sucks18:28
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561818:28
henrynashdstanek: damn!18:29
dstanekhenrynash: ?18:29
*** harlowja_ has quit IRC18:31
*** harlowja has joined #openstack-keystone18:32
dolphmdstanek: sqlite.18:32
dstanekfailed us again18:33
samueldmqlbragstad: does 355618 now have the changes from 360723 added to it ?18:33
*** ddieterly[away] is now known as ddieterly18:34
dolphmdstanek: actually, the sqlite error makes sense to me... but mysql and postgres would allow this schema and reject non-compliant inserts?18:36
*** phalmos has joined #openstack-keystone18:37
henrynashdstanek: which test failed...sql_upgrade?...since our actual driver code always puts a value in there....18:37
dolphmlbragstad: woo, dtroyer +2/+A'd the grenade patch (thanks!)18:38
dstanekkeystone.tests.unit.test_sql_upgrade.SqlContractSchemaUpgradeTests.test_start_version_db_init_version for sure and i think there was one more18:38
dstanekhenrynash: actually 5 tests failed18:39
lbragstadsamueldmq yep18:39
dolphmdstanek: i had 4 tests fail18:39
dstaneklots of keystone.tests.unit.test_sql_upgrade stuff18:39
samueldmqlbragstad: are all the existing credentials migrated upon migration ?18:39
dolphmkeystone.tests.unit.test_sql_upgrade.SqlDataMigrationUpgradeTests.test_start_version_db_init_version18:39
dolphmkeystone.tests.unit.test_sql_upgrade.SqlContractSchemaUpgradeTests.test_start_version_db_init_version18:39
samueldmqlbragstad: or are they migrated on-demand?18:39
dolphmkeystone.tests.unit.test_sql_banned_operations.TestKeystoneContractSchemaMigrationsSQLite.test_walk_versions18:39
dolphmkeystone.tests.unit.test_sql_upgrade.FullMigration.test_migration_002_password_created_at_not_nullable18:40
dolphmdstanek: do you have a transient? ^18:40
dstanekdolphm: oh, it looks like i also failes because of a version conflict with oslo.context18:40
dolphmdstanek: sounds like a personal problem18:40
dstanekmaybe they released today? wasn't seeing this earlier today18:40
lbragstadsamueldmq they are migrated during the data migration18:40
lbragstadthen they are migrated at will by the operator18:41
henrynashdolphm: 002 contract failure is expected since that explicit tests to see if we set the column nullable not18:41
dolphmdstanek: nope18:41
dolphmdstanek: https://pypi.python.org/pypi/oslo.context18:41
dstanekweird18:41
samueldmqlbragstad: but after running 003 all credentials will be encrypted18:41
henrynashdolphm: ah, sorry, ignore that comment !18:41
samueldmqlbragstad: is that right?18:41
lbragstadsamueldmq yes18:41
henrynashdolphm: I'll see if I can play with that later18:41
dstanekgot one of these:     pkg_resources.ContextualVersionConflict: (oslo.context 2.8.0 (/opt/stack/keystone/.tox/py27/lib/python2.7/site-packages), Requirement.parse('oslo.context>=2.9.0'), set(['keystone']))18:41
lbragstadif this goes into Newton - you have to encrypt credentials if you're going to put them in keystone18:42
samueldmqlbragstad: operator run expand and can stay how long they want there18:42
dolphmdstanek: oh, maybe something else suddenly required >=2.918:42
samueldmqlbragstad: but once migrate is run, everything will be encrypted18:42
dstaneki'll have to -r my next test run18:42
dolphmsamueldmq: after the --migrate, you can still run both the previous and the next release18:43
dstaneksamueldmq: that's a good thing18:43
dolphmsamueldmq: after --migrate, the data exists in the database as both plaintext and ciphertext18:43
samueldmqyes18:43
dolphm--contract drops the plaintext, so it's *only* encrypted18:43
dstanekdolphm: i thought we were just not allowing writes18:43
dolphmdstanek: from the app18:44
lbragstadsamueldmq after you run expand you won't be able to create any more credentials18:44
lbragstaduntil you run the contract18:44
samueldmqwhat happens if the operator run `keystone-manage credential_migrate` when there is a mix of encrypted and plain text credentials in the database?18:44
lbragstadsamueldmq that won't work18:45
lbragstadbecause credential_migrate is designed to re-encrypt credentials, not migrate plaintext ones18:45
lbragstadthat what the data_migration piece of the migration does18:45
samueldmqlbragstad: ok, I am reading https://review.openstack.org/#/c/355618/45/keystone/cmd/cli.py18:46
lbragstadsamueldmq the gist i have walks through everything step by step18:46
lbragstaddoing a rolling upgrade while encrypting credentials18:46
samueldmqlbragstad: and L677-679 the operator is advised to run credential_migrate there, as credential_rotate just failed18:47
dolphmlbragstad: it'll work - because there can't be a mix :)18:47
dolphmit was a trick question :P18:47
lbragstadtrue18:47
lbragstadsamueldmq yes - we have to keep rotation and migration lock step in order to protect against over-rotation18:47
dolphmsamueldmq: the triggers reject writes to the new column, so you won't go into the migration with anything but plaintext18:47
lbragstadthe way we do that is by checking the key_hash attribute of each credential18:47
lbragstadagainst the key_hash of the current primary key18:48
samueldmqah okay, so there is no way to have a mix of them (plaintext and encrypted)18:48
lbragstadif any of them don't match - we know that there are credentials that need to be re-encrypted18:48
lbragstadso we should abort the rotation until we can be 100% sure we're not going to over-rotate18:48
*** david-lyle has quit IRC18:49
samueldmqlbragstad: yes, I was asking that because if we allowed it when there is a mix of plaintext and encrypted18:50
*** su_zhang has quit IRC18:50
samueldmqthe encrypted ones would be re-encrypted18:50
lbragstadyeah - credential_migrate will only re-encrypt existing credentials18:50
*** david-lyle has joined #openstack-keystone18:50
dstanekto that end. it is possible that the migration fails and gets restarted and thing are encrypted twice?18:51
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561818:54
*** ddieterly has quit IRC18:55
*** phalmos has quit IRC18:55
*** asettle has joined #openstack-keystone18:56
*** divyakkonoor has quit IRC18:56
*** dikonoor has joined #openstack-keystone18:57
*** dikonoo has joined #openstack-keystone18:57
dolphmdstanek: yeah, that's possible with the current implementation, because it's a blind select18:58
dolphmdstanek: ideally, it'd be like select .. where not_encrypted limit 10; or whatever18:59
samueldmqlbragstad: dolphm : if during the migration the credential API will be read-only, why do we need triggers copying the data back and forth ?18:59
dolphmsamueldmq: the triggers are not copying data18:59
dolphmsamueldmq: read the triggers :)18:59
samueldmqdolphm: will do, I am starting with lbragstad's gist :-)19:00
*** nisha_ is now known as nishaYadav19:02
*** ddieterly has joined #openstack-keystone19:05
samueldmqlbragstad: dolphm: if newton code verified that if can create credentials only when the 'blob' column does not exist19:06
samueldmqwe wouldn't need triggers19:06
samueldmqand the mitaka node could keep adding credentials through the proccess19:06
samueldmqI don't really see the value of triggers in this case if we are only using them to block writes19:10
*** jdennis has quit IRC19:10
samueldmqmaybe I am missing something19:10
*** jdennis has joined #openstack-keystone19:10
*** phalmos has joined #openstack-keystone19:12
*** gyee has quit IRC19:13
dstanekdolphm: ++19:13
*** harlowja_ has joined #openstack-keystone19:13
*** tonytan4ever has joined #openstack-keystone19:16
*** tonytan4ever has quit IRC19:16
*** harlowja has quit IRC19:17
*** arunkant has joined #openstack-keystone19:18
dolphmsamueldmq: then the application would - forever - have to inspect the state of the schema before operating on it19:18
dolphmsamueldmq: in this case, i think that'd be safe, but that can also lead to race conditions during a rolling upgrade19:19
*** nishaYadav has quit IRC19:20
samueldmqdolphm: well, not forever, but until next release when we remove the check19:20
*** su_zhang has joined #openstack-keystone19:20
dolphmsamueldmq: unless your schema checking statements are in a transaction with your inserts, for example19:20
*** arunkant_web has joined #openstack-keystone19:20
samueldmqdolphm: ++19:21
dolphmsamueldmq: right - that's a lot of time to be constantly querying the schema though :)19:21
dolphmsamueldmq: this is certainly not the best example of using triggers during a rolling upgrade19:21
samueldmqdolphm: yeah, if that could be done within the insert query it'd be ideal19:21
samueldmqdolphm: maybe, but if we didn't use it we would postpone our decision on triggers to the summit19:22
samueldmqat the same time we get this feature in19:22
samueldmqif that makes sense..19:22
dolphmsamueldmq: if we land this now, we'll have some feedback to discuss at the summit19:22
dolphmsamueldmq: if we don't ship triggers, we won't learn anything new between now and the summit19:22
dolphmsamueldmq: we'll just have the same "omg triggers" feedback that we've already heard19:23
samueldmqdolphm: and if we decide to not go with triggers anymore19:23
samueldmqdolphm: we just adapt those migration scripts ?19:24
dolphmby shipping them in newton as part of rolling upgrades, the operators that are super interested in rolling upgrades will be able to evaluate them as part of a real release, and we'll get real feedback. if they don't work for some deployers for some reason, we'll learn why and evolve from there19:24
dolphmand for those deployers where triggers are either objectionable or actually don't work for some reason (db2!), offline upgrades with db_sync is still an option that doesn't involve any triggers19:25
*** dikonoo has quit IRC19:25
*** dikonoor has quit IRC19:25
*** spzala has quit IRC19:25
dolphmif we decide not to go with triggers, we'll just stop adding new ones. i wouldn't want to go back and drop code like that or anything19:25
*** chrichip has joined #openstack-keystone19:25
*** su_zhang has quit IRC19:25
*** spzala has joined #openstack-keystone19:26
dolphmsamueldmq: so, if you consider rolling upgrades to be an experimental feature, then you're also opting into our experimental trigger-based approach. if you don't want to go the experimental route, db_sync still behaves the same old way19:27
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561819:27
lbragstaddstanek fixed the key_hash nullable problem ^19:27
samueldmqdolphm: ah okay, so rolling upgrade is experimental19:27
dolphmfundamentally, we'll need the --expand, --migrate, --contract options of db_sync no matter our rolling upgrade implementation, it's just that the order of operations around those commands will be different (i.e. when you can bring the next release online, how long things take, etc)19:28
samueldmqdolphm: I agree with you with trying and see what operators think about it19:28
samueldmqdolphm: ++19:28
dolphmsamueldmq: i'm happy to call it experimental myself. more importantly, i don't want to break deployers that want to continue with upgrading with downtime and vanilla db_sync19:28
samueldmqdolphm: ++19:28
samueldmqdolphm: adding it and gathering feedback is a good idea19:29
samueldmqtahnks for clarifying on the plans19:29
samueldmq:-)19:29
dolphmsamueldmq: happily19:29
dstaneklbragstad: in case i haven't said it recently...you rock!19:33
* lbragstad blushes19:34
*** ddieterly is now known as ddieterly[away]19:41
openstackgerritDavid Stanek proposed openstack/keystone: Fixes spelling mistakes  https://review.openstack.org/36452719:42
*** snecklifter|brb is now known as snecklifter19:43
snecklifterayoung: ok, thanks, that makes more sense19:44
*** asettle has quit IRC19:46
*** asettle has joined #openstack-keystone19:47
*** asettle has quit IRC19:48
*** su_zhang has joined #openstack-keystone19:54
ayoungsnecklifter, I wrote this:19:56
ayounghttps://etherpad.openstack.org/p/keystone-fernet-token-cms19:56
*** asettle has joined #openstack-keystone19:59
snecklifterayoung: sure, i see where you're going with that20:00
ayoungsnecklifter, so, assuming Tripleo is using swift artifacts to do the deployment, we would need to have the secrest encruypted in the tarball copied over to the controller nodes...otherwise, they are posted for all the world to see20:01
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561820:01
snecklifterayoung: yes exactly20:01
ayoungalternatively, with OSP10 and later, we have mistral, so we could do something where we do a direct communication with the node to push any new keys down20:01
snecklifterthis is testing with OSP920:02
ayoungsnecklifter, so no Mistral?20:02
snecklifterayoung: correct20:03
ayoungsnecklifter, is Ansible an option?20:04
snecklifterit is20:04
snecklifterin fact we're doing a lot of post install customization with it like ELK20:04
*** ddieterly[away] is now known as ddieterly20:04
snecklifterso if the keys are being copied over ssh then no problem?20:05
ayoungsnecklifter, I had something that would generate an ansible inventory from the undercloud openstack server list20:07
ayounglet me see...20:07
snecklifteroh thats not too much of a problem, we are using custom hostnames20:08
snecklifterand predictable IPs20:08
snecklifterayoung: actually ignore that, i see what you mean i think20:09
*** tonytan4ever has joined #openstack-keystone20:11
*** phalmos has quit IRC20:11
*** gyee has joined #openstack-keystone20:13
*** ChanServ sets mode: +v gyee20:13
ayoungsnecklifter, https://paste.fedoraproject.org/419316/14727608/20:13
snecklifterayoung: cool, thanks, i'm stuck in the bash scripting era20:15
ayoungsnecklifter, Python is the new bash20:15
snecklifterayoung: so i'm told... <sigh>20:15
*** tonytan_brb has joined #openstack-keystone20:16
ayoungsnecklifter, I just like using the python-keystone API and python-nova APIs from time to time to make sure I can remember how20:16
*** tonytan4ever has quit IRC20:17
snecklifterayoung: ok, thanks for help, so all three controllers reading same fernet keys from shared storage seems sane to you?20:18
ayoungsnecklifter, yeah, they have to be in sync.20:19
snecklifterayoung: sure20:19
ayoungsnecklifter, there is no advantage to keeping the keys distinct, as they are all symmetric20:19
ayoungthus, if you have the key, you can sign things20:19
ayoungso, what really matters is *who* can read that shared storage20:19
*** spzala has quit IRC20:19
ayoungand I think the answer is *keystone only*20:19
ayoungOvercloud process should probably be only able to write to it20:20
snecklifterayoung: sure but keystone is running as apache20:21
snecklifterbut still lock down to keystone uid/gid20:21
ayoungsnecklifter, no it is not20:21
ayoungkeystone is running as Keystone20:21
ayoungapache is running as apache20:21
ayoung$ ps -ef | grep keystone20:22
ayoungstack     2901 26815  0 20:21 pts/0    00:00:00 grep --color=auto keystone20:22
ayoungkeystone 18605 18604  0 18:08 ?        00:01:04 keystone-admin  -DFOREGROUND20:22
ayoungkeystone 18606 18604  1 18:08 ?        00:01:30 keystone-main   -DFOREGROUND20:22
ayoungkeystone is a wsgi process kicked off by apache, but it is a separate user20:22
snecklifterah ok, had not delved into this20:22
ayoungsnecklifter, list is my life20:22
snecklifterprviously all eventlet20:22
ayoungsuch as it is20:22
ayounghttps://adam.younglogic.com/2012/03/keystone-should-move-to-apache-httpd/  snecklifter look at the date.20:23
snecklifterayoung: wow20:23
snecklifterayoung: i read your blog but not the dates20:23
snecklifterayoung: let me guess, it happened but took 3 times longer than you expected, right?20:24
ayoung3 is probably a low estimate20:24
snecklifterayoung: well, the good news is that you can now explain process ownership to newbs like me :)20:25
snecklifteron channels like this20:25
snecklifterayoung: ok, thanks very much for help, much appreciated20:26
snecklifteron UK time so signing off20:26
ayoungsame here...kid duty20:27
*** ddieterly is now known as ddieterly[away]20:28
*** gordc has quit IRC20:30
*** ddieterly[away] is now known as ddieterly20:30
*** itisha has quit IRC20:30
*** jpena|away is now known as jpena|off20:35
stevemarlbragstad: dolphm back20:45
*** ayoung has quit IRC20:46
openstackgerritMerged openstack/keystone: Fixes migration where password created_at is nullable  https://review.openstack.org/36250120:50
*** phalmos has joined #openstack-keystone20:51
*** chrichip has quit IRC20:53
*** chrichip has joined #openstack-keystone20:54
*** browne has quit IRC20:59
*** arunkant_web has quit IRC21:00
*** ddieterly is now known as ddieterly[away]21:01
*** raildo has quit IRC21:01
*** ddieterly[away] is now known as ddieterly21:03
*** phalmos has quit IRC21:03
*** ezpz has quit IRC21:12
*** pauloewerton has quit IRC21:16
openstackgerritDavid Stanek proposed openstack/keystone: Fixes credential key rotation  https://review.openstack.org/36455721:20
*** rcernin has quit IRC21:24
samueldmqlbragstad: just left a few comments in the credential change21:26
openstackgerritDavid Stanek proposed openstack/keystone: Only cache callables in the base manager  https://review.openstack.org/36456221:29
openstackgerritSteve Martinelli proposed openstack/keystone: Fixes spelling mistakes  https://review.openstack.org/36452721:31
*** ddieterly has quit IRC21:31
*** chrisshattuck has quit IRC21:36
samueldmqdolphm: lbragstad: dstanek: btw, related to credentials, but in client side, see https://review.openstack.org/#/c/352567/21:41
*** adriant has joined #openstack-keystone21:42
*** adriant has quit IRC21:45
*** spedione is now known as spedione|AWAY21:47
*** su_zhang has quit IRC21:51
*** chrisshattuck has joined #openstack-keystone21:52
*** su_zhang has joined #openstack-keystone21:53
*** ddieterly has joined #openstack-keystone21:53
*** haplo37__ has quit IRC21:59
*** adriant has joined #openstack-keystone21:59
*** ravelar has quit IRC22:02
*** michauds has quit IRC22:04
*** chrisshattuck has quit IRC22:14
*** krotscheck has quit IRC22:15
*** krotscheck has joined #openstack-keystone22:15
*** ddieterly is now known as ddieterly[away]22:17
*** spzala has joined #openstack-keystone22:20
*** browne has joined #openstack-keystone22:20
*** erhudy has quit IRC22:22
*** spzala has quit IRC22:24
*** adriant has quit IRC22:25
*** phalmos has joined #openstack-keystone22:25
*** ayoung has joined #openstack-keystone22:30
*** ChanServ sets mode: +v ayoung22:30
*** ntpttr has quit IRC22:31
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561822:31
lbragstaddolphm new patch ^22:31
*** ntpttr has joined #openstack-keystone22:31
*** ddieterly[away] is now known as ddieterly22:38
*** ddieterly is now known as ddieterly[away]22:42
*** tonytan_brb has quit IRC22:43
stevemardolphm: lbragstad: i'll review that after dinner22:45
stevemardolphm: we have til eod to merge it ;)22:45
lbragstadstevemar cool - thanks22:45
stevemarteam code review on hangouts!22:45
*** adriant has joined #openstack-keystone22:45
lbragstadstevemar sounds good - ping me on google hangouts (so i get it on my phone) when you're ready?22:48
lbragstadi'm gonna try and step away for a bit22:48
*** BjoernT has quit IRC22:50
*** su_zhang has quit IRC22:50
*** su_zhang has joined #openstack-keystone22:52
*** ayoung has quit IRC23:05
*** ddieterly[away] has quit IRC23:05
*** markvoelker has joined #openstack-keystone23:11
*** slberger has left #openstack-keystone23:16
*** su_zhang has quit IRC23:16
*** chlong has quit IRC23:33
*** arunkant has quit IRC23:41
*** Guest99973 has quit IRC23:43
*** ravelar has joined #openstack-keystone23:48
*** markvoelker has quit IRC23:51
openstackgerritEric Brown proposed openstack/oslo.policy: Update reno for stable/newton  https://review.openstack.org/36237523:51
*** ravelar has quit IRC23:53
*** markvoelker has joined #openstack-keystone23:56
openstackgerritEric Brown proposed openstack/keystoneauth: Update reno for stable/newton  https://review.openstack.org/36241223:57
openstackgerritEric Brown proposed openstack/keystonemiddleware: Update reno for stable/newton  https://review.openstack.org/36241423:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!