Thursday, 2016-08-25

bknudsonI still wonder why I could never recreate in devstack.00:07
bknudsonbecause I can hit it all the time with this vagrant arrrsula install00:08
*** ddieterly has joined #openstack-keystone00:08
*** david-lyle has quit IRC00:08
notmorganyeaH, i dunno00:12
*** chlong has quit IRC00:13
*** roxanagh_ has joined #openstack-keystone00:19
*** chlong has joined #openstack-keystone00:26
*** ravelar has quit IRC00:32
openstackgerritMerged openstack/keystone: Doc fix: license rendered in published doc  https://review.openstack.org/35928400:37
openstackgerritMerged openstack/keystone: Add mapping_populate command  https://review.openstack.org/34302800:38
*** marekd2 has joined #openstack-keystone00:39
*** su_zhang has quit IRC00:42
*** su_zhang has joined #openstack-keystone00:42
*** marekd2 has quit IRC00:44
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/35951300:45
*** su_zhang has quit IRC00:46
*** markvoelker has joined #openstack-keystone00:55
*** gyee has quit IRC00:59
*** sdake has quit IRC01:06
*** jamielennox is now known as jamielennox|away01:11
*** jamielennox|away is now known as jamielennox01:11
*** atod has quit IRC01:11
*** esp has quit IRC01:18
*** ddieterly has quit IRC01:18
*** davechen has joined #openstack-keystone01:19
*** ravelar has joined #openstack-keystone01:25
*** roxanagh_ has quit IRC01:34
*** markvoelker has quit IRC01:36
*** sdake has joined #openstack-keystone01:36
*** code-R has joined #openstack-keystone01:36
*** sdake_ has joined #openstack-keystone01:39
*** sdake has quit IRC01:42
*** wangqun has joined #openstack-keystone01:47
*** ddieterly has joined #openstack-keystone01:49
*** code-R_ has joined #openstack-keystone01:52
*** sdake_ has quit IRC01:54
*** code-R has quit IRC01:55
*** ddieterly has quit IRC02:02
*** sdake has joined #openstack-keystone02:04
*** ddieterly has joined #openstack-keystone02:04
*** jrist has quit IRC02:05
*** gagehugo has joined #openstack-keystone02:05
*** gagehugo has quit IRC02:07
*** bigdogstl has joined #openstack-keystone02:12
*** jrist has joined #openstack-keystone02:18
*** ravelar has quit IRC02:26
*** thiagolib has quit IRC02:27
*** thiagolib has joined #openstack-keystone02:28
*** serverascode has quit IRC02:28
*** code-R_ has quit IRC02:29
*** code-R has joined #openstack-keystone02:30
*** ddieterly has quit IRC02:31
*** serverascode has joined #openstack-keystone02:31
*** sdake has quit IRC02:34
*** sdake has joined #openstack-keystone02:35
*** julim has quit IRC02:35
*** Ephur has quit IRC02:37
*** ddieterly has joined #openstack-keystone02:37
*** ddieterly has quit IRC02:37
*** sdake has quit IRC02:45
*** sdake has joined #openstack-keystone02:47
openstackgerritDave Chen proposed openstack/keystone: Handle the exception from creating access token properly  https://review.openstack.org/35979502:57
*** marekd2 has joined #openstack-keystone02:59
*** marekd2 has quit IRC03:04
*** code-R has quit IRC03:06
*** jamielennox is now known as jamielennox|away03:09
*** woodster_ has quit IRC03:09
*** sdake has quit IRC03:12
*** tonytan4ever has quit IRC03:13
*** Ephur has joined #openstack-keystone03:16
openstackgerritSteve Martinelli proposed openstack/python-keystoneclient: [WIP] Migrate to keystoneauth  https://review.openstack.org/35970803:22
*** chlong has quit IRC03:23
stevemarjamielennox|away: looks like ksm gate is broken03:23
stevemarwe somehow wedged ourselves03:23
*** jamielennox|away is now known as jamielennox03:23
jamielennoxstevemar: oh?03:25
jamielennoxi was just looking at an old review that was stalled and i wasn't sure why03:25
jamielennoxwhat are you seeing?03:25
openstackgerritJamie Lennox proposed openstack/keystonemiddleware: Refactor audit tests to use create_middleware  https://review.openstack.org/33697103:25
openstackgerritJamie Lennox proposed openstack/keystonemiddleware: Use oslo_messaging conf fixture  https://review.openstack.org/33697003:25
openstackgerritJamie Lennox proposed openstack/keystonemiddleware: Extract oslo_messaging specific audit tests  https://review.openstack.org/33429603:25
openstackgerritJamie Lennox proposed openstack/keystonemiddleware: Return and use an app wherever possible  https://review.openstack.org/33697203:25
openstackgerritJamie Lennox proposed openstack/keystonemiddleware: Use the mocking fixture in notifier tests  https://review.openstack.org/33429503:25
stevemarjamielennox: https://review.openstack.org/#/c/359675/ and https://review.openstack.org/#/c/359514/03:25
jamielennoxthat was just a rebase03:26
jamielennoxwhich i probably shouldn't have done because it was the same failure03:26
stevemareh ?03:26
jamielennoxnvm03:27
*** bigdogstl has quit IRC03:27
*** atod has joined #openstack-keystone03:27
jamielennoxoh - at least i can reproduce it seems03:29
jamielennoxthere's a new requests version about a week ago...03:29
jamielennoxoh, and there's a ksa more recent than that..03:30
*** Ephur has quit IRC03:30
*** dkehn_ has quit IRC03:31
*** bigdogstl has joined #openstack-keystone03:31
*** bigdogstl has quit IRC03:35
*** chlong has joined #openstack-keystone03:35
stevemarjamielennox: the ksa changes were tiny03:37
jamielennoxyea, but i think the relative one might have done something03:37
stevemarhttps://github.com/openstack/keystoneauth/compare/2.11.0...2.12.003:37
stevemarah03:38
stevemari was thinking requests-mock, but that didn't change03:38
*** chlong has quit IRC03:38
*** chlong has joined #openstack-keystone03:38
stevemarjamielennox: easy enough to test03:39
jamielennoxstevemar: yea, it's that one03:39
jamielennoxstevemar: previously get_endpoint would return None when it couldn't match something03:39
stevemarjamielennox: did you want to fix it or shall i revert and release?03:39
jamielennoxnow with the urljoin it does join(original_url, None)03:40
jamielennoxso it should be an easy fix03:40
*** bigdogstl has joined #openstack-keystone03:40
*** EinstCrazy has joined #openstack-keystone03:41
*** dkehn_ has joined #openstack-keystone03:43
jamielennoxstevemar: bug 161672003:45
openstackbug 1616720 in keystoneauth "get_endpoint returns URL where it should return None" [Undecided,New] https://launchpad.net/bugs/161672003:45
*** bigdogstl has quit IRC03:47
*** bigdogstl has joined #openstack-keystone03:49
*** bigdogstl has quit IRC03:51
openstackgerritJamie Lennox proposed openstack/keystoneauth: get_endpoint should return None when no version found  https://review.openstack.org/36020903:52
jamielennoxstevemar: ^^03:52
openstackgerritMerged openstack/keystone: Remove unnecessary __init__  https://review.openstack.org/35906303:53
*** bigdogstl has joined #openstack-keystone03:54
stevemarsamueldmq: one for you in the morning https://review.openstack.org/#/c/360209/1 and we'll need to release a new keystoneauth03:55
*** esp has joined #openstack-keystone03:56
openstackgerritJamie Lennox proposed openstack/keystoneauth: Allow specifying client and service info to user_agent  https://review.openstack.org/35763303:59
*** dikonoor has joined #openstack-keystone04:04
*** tonytan4ever has joined #openstack-keystone04:13
*** tonytan4ever has quit IRC04:18
*** davechen has left #openstack-keystone04:19
*** EinstCrazy has quit IRC04:24
*** esp has quit IRC04:25
openstackgerritMerged openstack/keystone: Doc fix: "keystone-manage upgrade" is not a thing  https://review.openstack.org/35928104:26
*** iurygregory_ has quit IRC04:28
*** bigdogstl has quit IRC04:30
*** links has joined #openstack-keystone04:37
*** aswadr_ has joined #openstack-keystone04:41
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/35951304:48
openstackgerritNam Nguyen Hoai proposed openstack/keystone: Cleaning imports in code  https://review.openstack.org/36022804:55
openstackgerritMerged openstack/keystone: Remove mox from test-requirements  https://review.openstack.org/35993105:00
openstackgerritMerged openstack/keystone: TrivialFix: Remove logging import unused  https://review.openstack.org/35976005:01
*** ayoung has quit IRC05:03
*** EinstCrazy has joined #openstack-keystone05:09
*** jaosorior has joined #openstack-keystone05:10
*** EinstCrazy has quit IRC05:11
*** ravelar has joined #openstack-keystone05:24
*** ravelar has quit IRC05:28
dikonoorstevemar:hi steve..are you around?05:29
*** richm has quit IRC05:40
*** david-lyle has joined #openstack-keystone05:43
stevemardikonoor: only for the next 2 minutes :P05:46
dikonoorstevemar:i will be quick..05:47
dikonoorstevemar: I am using fernet token with memcached and I am just wondering if it makes sense to restart memcahced service everytime we restart keystone05:48
*** davechen has joined #openstack-keystone05:48
dikonoorstevemar: would that be something recommended? (I understand that restarting memcache basically means cleaning up the cache and there's no direct correlation between restart keystone and memcached because both are different services altogether)05:49
dikonoorand restarting keystone is generally required only if some configuration parameters have changed or some code has changed etc..05:50
stevemardikonoor: thats a good question05:51
dikonoorbut isn't it possible that if we are using a sql identity backend and then switch to ldap, without restarting memcached , the old tokens are going to function for some more time when they actually shouldn;t be05:51
stevemardikonoor: i would think "switching to ldap" would be part of some scheduled down time or that would be expected05:52
stevemarit probably doesn't hurt to restart memcache when you restart keystone05:52
dikonooror perhaps some changes in assignments..for eg. some assignments are removed ..I saw some code related to assignments and id_mapping tables etc where the oslo_Cache regions are invalidated whenever there's a db change but I found that that's not reflected until memcahced service is restarted (in the usecase I tried)05:53
*** atod has quit IRC05:55
dikonoorstevemar: So, there are really no negative effects to restarting memcached while restarting keystone apart from the fact that the cache would get cleared05:55
stevemardikonoor: AFAIK, you are correct05:56
dikonoorstevemar: Thanks Steve..thanks for the extra min you spared :D05:56
stevemardikonoor: we've had a few bugs with cache lately, where weird things are being cached, so its probably best to take the performance hit and clear the cache instead of filling your logs with exceptions or just getting weird behaviour05:57
stevemardikonoor: if breton comes online while you're here i recommend bugging him, he's got hands-on experience05:58
dikonoorstevemar: ok.. I will try and talk to breton today05:59
stevemardikonoor: cool, sorry for running off, been on 4 flights in 3 days, i'm going to do this now: https://media.giphy.com/media/RkzJzW4xUm0X6/giphy.gif05:59
dikonoorstevemar : go ahead.. looks terrible ;-P06:00
*** atod has joined #openstack-keystone06:01
*** edtubill has quit IRC06:03
*** adriant has quit IRC06:03
*** david-lyle has quit IRC06:09
openstackgerritAnh Tran proposed openstack/keystone: api-ref: Splitting status lines in API v3.  https://review.openstack.org/36026406:19
openstackgerritAnh Tran proposed openstack/keystone: api-ref: Splitting status lines in API v3-ext.  https://review.openstack.org/36026706:23
*** rcernin has joined #openstack-keystone06:28
*** Gorian has joined #openstack-keystone06:32
*** nikhil has quit IRC06:36
*** nikhil has joined #openstack-keystone06:38
*** zhangjl has joined #openstack-keystone07:00
*** tesseract- has joined #openstack-keystone07:08
*** atod has quit IRC07:11
*** tonytan4ever has joined #openstack-keystone07:15
*** tonytan4ever has quit IRC07:20
*** AndyWojo has quit IRC07:29
*** AndyWojo has joined #openstack-keystone07:32
*** sheel has joined #openstack-keystone07:37
*** yarkot1 has quit IRC07:40
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-keystone08:00
*** jpena|away is now known as jpena08:09
openstackgerritDavanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c  https://review.openstack.org/31843508:10
*** asettle has joined #openstack-keystone08:20
*** dikonoor has quit IRC08:21
*** dikonoor has joined #openstack-keystone08:21
*** xiaoyang has joined #openstack-keystone08:28
openstackgerritNam Nguyen Hoai proposed openstack/keystone: Cleaning imports in code  https://review.openstack.org/36022808:37
bretonhuh?08:41
openstackgerritJamie Lennox proposed openstack/keystone: Use egg form of osprofiler in paste pipeline  https://review.openstack.org/36033708:41
*** marekd2 has joined #openstack-keystone08:42
openstackgerritMerged openstack/keystone: [api-ref]: Outdated link reference  https://review.openstack.org/35963108:42
bretondikonoor: yep, we have a bug with caching that has impact on assignments, catalog and even tokens. You definitely should restart memcached as a workaround for now.08:43
dikonoorbreton: thanks for pinging..Do you have the LP bug handy so that I can keep track?08:43
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-keystone08:48
*** atod has joined #openstack-keystone08:49
*** atod has quit IRC08:54
*** root has joined #openstack-keystone08:59
*** root is now known as Guest7398008:59
bretondikonoor: bug 159077909:04
openstackbug 1590779 in oslo.cache "Cache region invalidation works for local CacheRegion object only" [Undecided,In progress] https://launchpad.net/bugs/1590779 - Assigned to Alexander Makarov (amakarov)09:04
dikonoorbreton : Thanks !09:04
openstackgerritNam Nguyen Hoai proposed openstack/keystone: Cleaning imports in code  https://review.openstack.org/36022809:10
*** tonytan4ever has joined #openstack-keystone09:16
*** Guest73980 has quit IRC09:19
*** tonytan4ever has quit IRC09:20
*** dkehn_ has quit IRC09:22
*** xiaoyang has quit IRC09:24
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/35951309:24
openstackgerritDave Chen proposed openstack/keystone: Handle the exception from creating access token properly  https://review.openstack.org/35979509:37
*** dkehn_ has joined #openstack-keystone09:39
*** davechen has left #openstack-keystone09:39
*** mkoderer__ has joined #openstack-keystone09:49
*** wangqun has quit IRC10:05
*** richm has joined #openstack-keystone10:07
openstackgerritDavanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c  https://review.openstack.org/31843510:10
*** hockeynut has quit IRC10:23
*** zhangjl has quit IRC10:30
samueldmqstevemar: ack, approved, waiting on merge to propose a new release10:31
*** jed56 has quit IRC10:35
*** atod has joined #openstack-keystone10:38
*** newcomer25 has joined #openstack-keystone10:40
*** atod has quit IRC10:43
openstackgerritRon De Rose proposed openstack/keystone: Relax the requirement for mappings to result in group memberships  https://review.openstack.org/35811110:54
*** asettle has quit IRC11:01
*** asettle has joined #openstack-keystone11:02
*** tonytan4ever has joined #openstack-keystone11:17
*** rodrigods has quit IRC11:21
*** rodrigods has joined #openstack-keystone11:21
*** tonytan4ever has quit IRC11:22
*** sheel has quit IRC11:26
*** jaosorior has quit IRC11:52
*** jaosorior has joined #openstack-keystone11:52
*** asettle has quit IRC11:55
*** asettle has joined #openstack-keystone11:56
*** jpena is now known as jpena|lunch12:04
*** tonytan4ever has joined #openstack-keystone12:10
*** su_zhang has joined #openstack-keystone12:14
*** tonytan_brb has joined #openstack-keystone12:17
*** tonytan4ever has quit IRC12:19
*** sc68cal has quit IRC12:20
*** jaugustine has joined #openstack-keystone12:20
*** mfisch has quit IRC12:21
*** sc68cal has joined #openstack-keystone12:21
*** bradjones has quit IRC12:21
*** briancurtin has quit IRC12:23
*** vern has quit IRC12:23
*** vern has joined #openstack-keystone12:24
*** sigmavirus has quit IRC12:24
*** mfisch has joined #openstack-keystone12:25
*** mfisch has quit IRC12:25
*** mfisch has joined #openstack-keystone12:25
*** jaosorior is now known as jaosorior_away12:25
*** _sigmavirus24 has joined #openstack-keystone12:25
*** briancurtin has joined #openstack-keystone12:25
*** atod has joined #openstack-keystone12:26
*** bradjones has joined #openstack-keystone12:27
*** bradjones has quit IRC12:27
*** bradjones has joined #openstack-keystone12:27
*** mtreinish has quit IRC12:27
*** _sigmavirus24 is now known as sigmavirus12:30
*** sigmavirus has joined #openstack-keystone12:30
*** mtreinish has joined #openstack-keystone12:30
*** atod has quit IRC12:30
dstanekrderose: you around?12:32
*** edmondsw has joined #openstack-keystone12:34
samueldmqstevemar: https://review.openstack.org/#/c/360495/12:35
openstackgerrithenry-nash proposed openstack/keystone: Modify sql banned operations for each of the new repos  https://review.openstack.org/35872312:37
samueldmqstevemar: I saw there is a topic in next meeting to talk about versionedobjects vs triggers12:39
samueldmqstevemar: how does this impact current proposed code ? should we work for that discussion to merge 355618 and 357789 ?12:40
samueldmqstevemar: or perhaps we can work on merging them and refactoring later ?12:40
samueldmqstevemar: my only concern are the deadlines12:40
*** pauloewerton has joined #openstack-keystone12:43
dstaneksamueldmq: that is a great question12:44
dstanekafter the chat yesterday i had the feeling that we were full steam on triggers12:44
*** ddieterly has joined #openstack-keystone12:45
henrynashlbragstad: ping12:46
*** markvoelker has joined #openstack-keystone12:48
*** code-R has joined #openstack-keystone12:52
openstackgerritMikhail Nikolaenko proposed openstack/keystone: [WIP] Move fernet utils to backend  https://review.openstack.org/35649912:52
samueldmqdstanek: I missed the convo yesterday, but needing to write DDLs directly seems not ideal given we want to support multiple dbs12:53
henrynashlbragstad: I think I know what is going on with the trigger dopping not working with sqlite....it's because in each of our scrips we preceed the drop with a table alter...and sqlite doesn't really support table alter (it creates a new table, copies the data)...I'm betting that it has renamed the trigger in the process12:53
*** nkinder has joined #openstack-keystone12:54
*** mgagne_ is now known as mgagne12:54
*** ddieterly has quit IRC12:55
*** jpena|lunch is now known as jpena12:56
*** woodster_ has joined #openstack-keystone12:57
dstaneksamueldmq: we only want to support 2 so it's not terribad12:57
*** edtubill has joined #openstack-keystone12:58
samueldmqdstanek: postgresql & mysql?12:59
samueldmqwhat about galera?12:59
dstaneksamueldmq: yessir - galera is mysql12:59
samueldmqdstanek: hmm13:00
*** jrist has quit IRC13:00
samueldmqdstanek: it'd be nice if sqlalchemy supported triggers13:00
samueldmqso we wouldn't need to write in ddl13:00
dstanekit's a tradeoff. then our code might look horribly complex and hard to understand13:00
bknudsonsqlalchemy is open source13:01
bknudsonif you want it to support triggers go ahead and add it13:01
*** yarkot1 has joined #openstack-keystone13:03
samueldmqperhaps we could get the same effect with ORM events http://docs.sqlalchemy.org/en/latest/orm/events.html13:03
dstanekSQL is remarkably declarative and easy to write a DSL for. with triggers you can use many features of an imperative language13:04
dstanekeven with SQLA you may have to drop down to raw SQL for very complex queries or to make certain queries more performant13:04
bknudsonif you're going to do that then don't use sqla.13:06
samueldmqbknudson: why?13:07
bknudsonthe whole point of sqla is to give you a database abstraction so that you get a consistent interface for any db13:08
bknudsonso if you're going to do raw sql you don't have an abstract database layer anymore.13:09
*** julim_ has joined #openstack-keystone13:09
lbragstadhenrynash ah - interesting13:09
henrynashlbragstad: if I temporarily remove the alter in mine, it works without the "IF EXISTS"13:10
lbragstadhenrynash where is that?13:10
henrynashlbragstad: i just tested it locally by commenting out where I make a column non nullable13:11
henrynashlbragstad: in my 002 contract .py script13:11
dstanekbknudson: why would you not use it where applicable?13:11
*** su_zhang has quit IRC13:12
henrynashlbragstad: am trying to see if I can see if sqlite  really does do this by testing it outside keytsone13:12
*** jrist has joined #openstack-keystone13:13
bknudsondstanek: so some parts of the application are database-agnostic and some are database-specific? If that's the case then your application is database-specific anyways.13:13
lbragstadhenrynash so in your case it is line 2713:13
lbragstadin your contract script that is nuking the triggers13:13
samueldmqbknudson: I agree. I was hoping that we could write sqla-like code when using ORM events13:13
henrynashlbragstad: well, line 27 of my contract script13:14
bknudsonwe've seen a problem in the past where we or sqla made assumptions about the name of an index. Now we're going to have our own code making assumptions about what sqla does.13:14
henrynashlbragstad: ..but the 2nd active line, yes13:14
lbragstadhenrynash interesting - so i wonder what's doing that in my script?13:15
henrynashlbragstad: drop column13:15
*** julim_ has quit IRC13:15
lbragstadhenrynash ah....13:16
lbragstadthat sucks13:16
lbragstadso sqla will create a new table without the column being dropped13:17
lbragstadwhich is why the trigger doesn't exist.13:17
henrynashlbragstad: for sqlite only, I believe so,13:17
*** newcomer25 has quit IRC13:17
*** julim_ has joined #openstack-keystone13:17
henrynashlbragstad: I'd have thought it copies the trigger...maybe giving it a different name?13:17
henrynashlbragstad: this is still a theory....13:18
*** newcomer25 has joined #openstack-keystone13:18
henrynashlbragstad: sqlite only really properly supports column adding...any other alter results in the table dance13:19
bknudsonwe don't have to worry about people migrating sqlite databases.13:21
*** links has quit IRC13:22
*** Ephur has joined #openstack-keystone13:22
lbragstadhenrynash so this is actually a sqlalchemy + sqlite problem?13:24
dstanekbknudson: no, even when you have to support only a single DB using something like SQLA is benficial even if you have to dip into SQL for one specific case13:29
lbragstaddo we have docs on running keystone tests against mysql or postgres?13:30
*** newcomer25 has quit IRC13:30
lbragstadhenrynash doing ^ locally might help figure out is this is strictly an issue with sql-a + sqlite13:30
*** newcomer25 has joined #openstack-keystone13:31
*** roxanagh_ has joined #openstack-keystone13:32
henrynashlbragstad: yep, right now I'm not sure exactly what the issue is, but the gun is smoking....13:32
*** asettle has quit IRC13:35
*** asettle has joined #openstack-keystone13:35
*** newcomer25 has quit IRC13:35
*** roxanagh_ has quit IRC13:36
*** edtubill has quit IRC13:36
*** newcomer25 has joined #openstack-keystone13:38
openstackgerritMikhail Nikolaenko proposed openstack/keystone: [WIP] Move fernet utils to backend  https://review.openstack.org/35649913:41
lbragstaddo we not use ENABLE_LIVE_MYSQL_TEST anymore?13:42
*** newcomer25 has left #openstack-keystone13:45
*** jaosorior_away is now known as jaosorior13:48
*** code-R_ has joined #openstack-keystone13:49
openstackgerritDavid Stanek proposed openstack/keystone: Removes old, unused code  https://review.openstack.org/36056113:50
*** code-R_ has quit IRC13:51
*** code-R has quit IRC13:51
*** code-R_ has joined #openstack-keystone13:52
*** ddieterly has joined #openstack-keystone13:54
*** ddieterly has quit IRC13:56
*** ddieterly has joined #openstack-keystone13:57
*** su_zhang has joined #openstack-keystone13:59
*** jaosorior has quit IRC14:08
openstackgerritLance Bragstad proposed openstack/keystone: Remove unused global variable from unit tests  https://review.openstack.org/36057514:10
*** hockeynut has joined #openstack-keystone14:11
*** amakarov_away is now known as amakarov14:11
*** code-R has joined #openstack-keystone14:12
*** code-R_ has quit IRC14:16
*** ravelar has joined #openstack-keystone14:20
*** michauds has joined #openstack-keystone14:21
*** esp has joined #openstack-keystone14:23
*** slberger has joined #openstack-keystone14:26
dstaneklbragstad: are you talking about running all of the unit tests?14:27
lbragstaddstanek yeah - i'm having some issues with a combination of sqla and sqlite... I was going to try and test my credential encryption patch against a mysql database14:28
dstaneklbragstad: right now it's not great. a patch i'm working on now deals with the setup/cleanup. lots of fun14:29
*** dikonoor has quit IRC14:29
lbragstaddstanek got it14:33
lbragstaddstanek we test keystone on mysql and postgres in the gate don't we?14:33
dstaneklbragstad: not unit tests14:34
lbragstaddstanek what do we test?14:34
lbragstadwith postgres and mysql?14:34
dstanektempest14:34
lbragstadoh14:34
*** edtubill has joined #openstack-keystone14:35
dstanekour unit tests can't currently run against mysql14:35
*** spedione|AWAY is now known as spedione14:35
bknudsonthere are unit tests that run against mysql and postgresql in the gate14:35
bknudsonhttp://logs.openstack.org/41/359941/1/check/gate-keystone-python27-db-ubuntu-xenial/f4034c0/console.html#_2016-08-24_17_11_36_77097114:36
bknudsonhttp://logs.openstack.org/41/359941/1/check/gate-keystone-python27-db-ubuntu-xenial/f4034c0/console.html#_2016-08-24_17_11_43_82797914:36
bknudsonhttp://logs.openstack.org/41/359941/1/check/gate-keystone-python27-db-ubuntu-xenial/f4034c0/console.html#_2016-08-24_17_16_17_65342614:36
bknudsonwe only have tests for the database migrations as live tests.14:37
dstanekbknudson: i didn't realize that we ran any of them in the gate14:39
bknudsonI think the nova team got a live database set up for their own testing so it's available to us too.14:39
bknudsonand then oslo.db added a test fixture for it.14:40
*** sdake has joined #openstack-keystone14:42
*** spedione is now known as spedione|AWAY14:43
dstanekbknudson: i haven't seen anything useful so i started hacking up our database fixture14:44
bknudsonwe probably have some old "live" test code around that doesn't work14:46
*** openstackgerrit has quit IRC14:48
*** openstackgerrit has joined #openstack-keystone14:49
*** hockeynut has quit IRC14:51
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561814:52
*** david-lyle has joined #openstack-keystone14:53
*** ruoyu has joined #openstack-keystone14:59
*** david-lyle has quit IRC14:59
dstaneklbragstad: want to play with the mysql stuff in a little bit?15:02
lbragstaddstanek yeah - i would like to do that15:02
lbragstadi'm going to have to in order to move forward with credential encryption15:03
*** tonytan4ever has joined #openstack-keystone15:03
*** tonytan_brb has quit IRC15:06
*** spedione|AWAY is now known as spedione15:07
*** gb21 has joined #openstack-keystone15:14
*** su_zhang has quit IRC15:16
*** code-R has quit IRC15:19
ruoyuHello! My name is Ruoyu Chen. I am a newbie in openstack keystone. Our team want to get realtime user information from keystone logs. Logging_context_format_string should print user id in the logs but it doesn’t work. For an example, when I log in with a wrong password, in keystone I only got log message like “2016-08-22 17:00:15.396 2707 WARNING keystone.common.wsgi [req-c9ab9248-4f94-4ed0-9005-10fe3c5e5486 - -15:20
ruoyu- - -] Authorization failed. The request you have made requires authentication. from 10.14.37.215”. We think the user id should be next to the request id but we only got ‘-‘. Any instruction is greatly appreciated. Thank you very much!15:20
*** code-R has joined #openstack-keystone15:21
*** links has joined #openstack-keystone15:21
*** code-R has quit IRC15:26
openstackgerritAlexander Makarov proposed openstack/keystone: Unified delegation assignment driver  https://review.openstack.org/29131815:26
*** hockeynut has joined #openstack-keystone15:27
lbragstaddstanek dolphm see my note here - https://review.openstack.org/#/c/355618/18/keystone/common/sql/contract_repo/versions/002_remove_unencrypted_blob_column_from_credential.py15:30
*** hockeynu_ has joined #openstack-keystone15:37
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561815:38
openstackgerrithenry-nash proposed openstack/keystone: Fix issue of password created_at being left as nullable  https://review.openstack.org/35778915:39
mfischdolphm or lbragstad can you point me at the keystone tuning guide for the ops midcycle? I seem to have lost it15:40
henrynashlbragstad: I think we should prioritise your patch over mine (since yours is a feature and needs to be merged quick), while mine is a bug fix...I'll rebase mine on to yours to stop migration number clashes15:41
*** hockeynut has quit IRC15:41
lbragstadhenrynash works for me15:41
*** roxanagh_ has joined #openstack-keystone15:42
dolphmmfisch: http://docs.openstack.org/developer/keystone/performance.html15:43
mfischthanks15:43
dstanekbknudson: it looks like it runs all unit tests against the DB in gate-keystone-python27-db-ubuntu-xenial. is that the case?15:43
lbragstadhenrynash trying to get this running against mysql so we can test real triggers15:45
lbragstadversus sqlite15:45
henrynashlbragstad: I have all three running on my machine15:45
lbragstadhenrynash how are you testing all this locally?15:46
henrynashlbragstad: key is to add user/password combo of "openstack_citest" to each of your local dbs15:46
*** BjoernT has joined #openstack-keystone15:46
*** roxanagh_ has quit IRC15:46
henrynashlbragstad: then test_sql_upgrade will test on all three15:47
lbragstadhenrynash are there docs on that process?15:47
bknudsondstanek: the -db jobs set up the database servers for us and the keystone tests check to see if the database is there and run if it is.15:48
henrynashlbragstad: not really, there are a few lines in the oslo_db documentation.....but I had to deduce it by looking at the code15:48
dstanekbknudson: ah, i see. that makes sense15:48
bknudsonif you set up a database on your dev box it'll run the tests15:49
henrynashlbragstad: basically if ensure you have a user called 'openstack_citest' with a password of 'openstack_citest' in each db (mysql and postgresql) then they will get run15:49
bknudsonI might have an ansible script that sets it up...15:49
dstanekbknudson: i was just wondering how all the other tests would run without my patches...but they don't :-)15:49
henrynashlbragstad: (and that user has full writes to create a database)15:50
henrynash(rights!)15:50
bknudsonit would be pretty cool if all the functional-style tests ran with a live db, but there's only a few of them.15:50
henrynashbknudson: ++15:51
henrynashlbragstad: you are meant to also be able to set an env variable that oslo.db will pick up that gives alternative credentials, but I couldn't make that work15:51
henrynashlbragstad: OS_TEST_DBAPI_ADMIN_CONNECTION15:52
bknudsonit would probably slow the gate down too much15:52
dstanekbknudson: yes, orders of magnitude locally :-(15:55
*** chrisshattuck has joined #openstack-keystone15:56
*** ruoyu has quit IRC16:00
*** links has quit IRC16:00
stevemaro/16:03
*** dikonoor has joined #openstack-keystone16:04
*** Marcellin_ has joined #openstack-keystone16:04
*** chrisshattuck has quit IRC16:12
dstanekstevemar!16:14
stevemardstanek: yo16:15
*** tonytan_brb has joined #openstack-keystone16:15
lbragstaddolphm my new test - http://cdn.pasteraw.com/qmbrn5b5za0jz5w4b11ftymaj25l34t16:16
*** tonytan4ever has quit IRC16:17
*** michauds has quit IRC16:21
*** michauds has joined #openstack-keystone16:21
*** ruoyu has joined #openstack-keystone16:22
notmorganbknudson: everytjing looking better sans threads?16:22
notmorganill dig into threading issues with memcache later today if so16:22
bknudsonnotmorgan: I'm working on integrating the change into our deployment tool (arrrsula)16:23
bknudsonand then I'm going to try it out16:23
notmorganokie16:23
notmorganbut so far so good in the drv env?16:23
notmorgandev*16:23
bknudsonwhen I ran yesterday I didn't get the error.16:24
bknudsonmy first test today was setting threads=1 and enable-threds=true and that failed like before16:24
bknudsonso now I'm going to set enable-threads=false which should work16:24
notmorganok cool  ill do some synthetic tests with threadong specifically then16:25
openstackgerritBoris Bobrov proposed openstack/keystone: Faster id mapping lookup  https://review.openstack.org/33929416:25
bknudsonI was never able to recreate this in devstack.16:25
bknudsonif you want to try out the arrsula install, it's all open source.16:25
bknudsonnotmorgan: here's my test program: https://github.com/brantlk/keystone_samples/blob/master/revocation_event_test.py16:26
*** gyee has joined #openstack-keystone16:27
*** hockeynu_ has quit IRC16:28
*** dikonoor has quit IRC16:28
*** hockeynut has joined #openstack-keystone16:29
*** Gorian|work has joined #openstack-keystone16:29
*** lamt has quit IRC16:31
openstackgerritDolph Mathews proposed openstack/keystone: Let upgrade tests control all 4 repositories at once  https://review.openstack.org/36066716:31
*** roxanagh_ has joined #openstack-keystone16:43
openstackgerrithenry-nash proposed openstack/keystone: Fix issue of password created_at being left as nullable  https://review.openstack.org/35778916:45
*** rcernin has quit IRC16:45
*** roxanagh_ has quit IRC16:47
*** david-lyle has joined #openstack-keystone16:50
stevemarrderose: unit test for this patch? https://review.openstack.org/#/c/359675/3 really?16:54
*** ruoyu has quit IRC16:55
*** tesseract- has quit IRC16:56
rderosestevemar: alright, I live without it.  but...  it wouldn't be hard to add a unit test for that :)16:57
stevemarrderose: we've never added unit tests to make sure other things are translated16:57
*** su_zhang has joined #openstack-keystone16:58
stevemarmaybe create a hacking change that detects if you're printing a user facing message, then mark it for translation16:58
*** dikonoor has joined #openstack-keystone16:59
rderosestevemar: we should check (test) to make sure that it is i18n compatible16:59
*** marekd2 has quit IRC16:59
rderosestevemar: right, for user facing messages17:00
*** marekd2 has joined #openstack-keystone17:00
rderosestevemar: but I'm okay with letting that patch go17:00
*** edtubill has quit IRC17:01
*** marekd2 has quit IRC17:01
*** marekd2 has joined #openstack-keystone17:01
*** edtubill has joined #openstack-keystone17:01
*** chrisshattuck has joined #openstack-keystone17:03
*** hockeynut has quit IRC17:05
*** marekd2 has quit IRC17:06
*** hockeynut has joined #openstack-keystone17:08
*** asettle has quit IRC17:08
*** asettle has joined #openstack-keystone17:09
*** asettle has quit IRC17:13
*** hockeynut has quit IRC17:19
mfischstevemar: any value in me adding to the keystone docs on upgrading and adding a section on how to do an upgrade of a multinode cluster with minimal downtime?17:28
stevemarmfisch: of course!17:29
mfischok17:29
mfischI'll leave the existing stuff alone since it explains the base case17:29
stevemarmfisch: i guess you just saw our upgrade note on the mailing list?17:29
mfischyeah17:29
mfischid be horrified if anyone used that current process as gospel ;)17:29
*** code-R has joined #openstack-keystone17:29
bknudson"multinode cluster" -- is there any other kind?17:30
*** roxanaghe_ has joined #openstack-keystone17:30
*** roxanaghe__ has joined #openstack-keystone17:31
mfischbknudson: sure with docker you can do a cluster on 1 physical node ;)17:32
bknudsonyou can probably do ha too17:32
*** roxanaghe has quit IRC17:33
*** code-R has quit IRC17:34
*** roxanaghe_ has quit IRC17:34
*** dikonoor has quit IRC17:36
*** ddieterly is now known as ddieterly[away]17:37
*** roxanaghe_ has joined #openstack-keystone17:39
*** roxanaghe has joined #openstack-keystone17:41
*** roxanaghe__ has quit IRC17:42
*** roxanaghe_ has quit IRC17:43
rderosemfisch stevemar: http://docs.openstack.org/developer/keystone/upgrading.html17:48
rderosemfisch: Upgrading with downtime section17:49
mfischI am enhancing it17:49
rderosemfisch: cool17:49
*** Ephur has quit IRC17:49
*** roxanaghe_ has joined #openstack-keystone17:50
*** hockeynut has joined #openstack-keystone17:50
*** hockeynut has quit IRC17:51
*** roxanaghe__ has joined #openstack-keystone17:51
*** hockeynut has joined #openstack-keystone17:53
*** rcernin has joined #openstack-keystone17:54
*** roxanaghe has quit IRC17:54
*** roxanaghe_ has quit IRC17:54
*** roxanaghe has joined #openstack-keystone17:59
*** david-lyle has quit IRC18:00
*** roxanaghe_ has joined #openstack-keystone18:01
*** roxanaghe__ has quit IRC18:03
*** sdake has quit IRC18:03
*** gyee has quit IRC18:03
*** david-lyle has joined #openstack-keystone18:04
*** roxanaghe has quit IRC18:04
*** sdake has joined #openstack-keystone18:04
*** chrisshattuck has quit IRC18:04
*** lamt has joined #openstack-keystone18:05
*** tqtran has joined #openstack-keystone18:05
*** tqtran_ has joined #openstack-keystone18:07
*** ravelar has quit IRC18:07
*** tqtran has quit IRC18:10
*** david-lyle has quit IRC18:11
bretonUnfortunately, your submission was not chosen to be part of the official agenda this time around. You submitted:18:11
bretonPCI via Federation and Keystone18:11
breton:(18:11
bretonrderose:18:12
*** david-lyle has joined #openstack-keystone18:12
*** hockeynut has quit IRC18:13
*** david-lyle_ has joined #openstack-keystone18:15
*** julim_ has quit IRC18:15
*** david-lyle_ has quit IRC18:15
*** ravelar has joined #openstack-keystone18:17
gagehugo_:(18:17
jaugustineI think that's one I actually voted on !18:18
*** NishaYadav has joined #openstack-keystone18:19
*** NishaYadav is now known as Guest5967318:19
*** Guest59673 is now known as nisha_18:19
*** aswadr_ has quit IRC18:21
openstackgerritDolph Mathews proposed openstack/keystone: Only use triggers conditionally  https://review.openstack.org/36072318:22
* nisha_ waves hello 18:25
*** su_zhang has quit IRC18:25
*** su_zhang has joined #openstack-keystone18:26
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561818:26
openstackgerritLance Bragstad proposed openstack/keystone: Let upgrade tests control all 4 repositories at once  https://review.openstack.org/36066718:26
lbragstaddolphm ^18:26
dolphmlbragstad: ack18:26
lbragstaddolphm for example - checkout line 1656 here https://review.openstack.org/#/c/360667/2/keystone/tests/unit/test_sql_upgrade.py18:27
*** tqtran_ has quit IRC18:28
lbragstadthere are certain spots in the tests that assume they can make assertions on those values18:28
*** tqtran has joined #openstack-keystone18:28
lbragstadso - to make that happen, i added two helper methods to SqlMigrateBase18:28
lbragstadcalled get_max_version and get_initial_db_version that take the repository you want as an argument and return the values specific to that repository18:29
*** ruoyu has joined #openstack-keystone18:29
dolphmlbragstad: oh, gotcha18:29
lbragstaddolphm i guess repo_path falls into that category too18:30
*** spedione is now known as chris_hultin18:30
dolphmlbragstad: it looks like the repo_name is only used to get the repo's current version?18:31
*** roxanaghe has joined #openstack-keystone18:31
lbragstaddolphm looks like it is used to get the repo_path?18:32
lbragstadwhen a MigrationRepository object it initialized18:32
*** tqtran has quit IRC18:35
*** esp has quit IRC18:35
*** roxanaghe has quit IRC18:35
dolphmlbragstad: proposing a rev ...18:37
*** ddieterly[away] has quit IRC18:38
lbragstaddolphm with your patch i'm getting a couple more column assertion errors (wondering if it has something to do with how we are calling self.upgrade())18:38
*** asettle has joined #openstack-keystone18:38
*** asettle has joined #openstack-keystone18:39
lbragstaddolphm for example - http://cdn.pasteraw.com/i3ywj5pw57swpxb94i980w1hg65uxbx18:39
*** ddieterly has joined #openstack-keystone18:39
*** tqtran has joined #openstack-keystone18:45
lbragstaddolphm otherwise I only have three failures with your patch - http://cdn.pasteraw.com/dz1bkjaojq1dad71meufpvjv8dt97e018:49
dolphmlbragstad: that's where i'm at too18:50
openstackgerritDolph Mathews proposed openstack/keystone: Let upgrade tests control all 4 repositories at once  https://review.openstack.org/36066718:50
lbragstadawesome18:50
dolphmlbragstad: did some other refactors ^18:50
lbragstaddolphm looking18:50
*** su_zhang has quit IRC18:51
*** krotscheck has left #openstack-keystone18:51
openstackgerritMatt Fischer proposed openstack/keystone: New notes on advanced upgrade/fallback for cluster  https://review.openstack.org/36073318:52
*** su_zhang has joined #openstack-keystone18:53
*** su_zhang has quit IRC18:53
stevemarthanks fishy mfisch18:57
openstackgerritAlexander Makarov proposed openstack/keystone: Moving dependency-related trust logic to manager  https://review.openstack.org/36073519:00
*** Gorian|work has quit IRC19:01
amakarovstevemar, good day! Are we going to merge token pre-caching patch into Newton?19:03
lbragstaddolphm ++ to the refactors19:03
*** Gorian|work has joined #openstack-keystone19:03
*** esp has joined #openstack-keystone19:05
stevemaramakarov: you need someone else to +2 it :)19:05
*** esp has quit IRC19:05
stevemardolphm: lbragstad henrynash ^ ?19:05
stevemaramakarov: i am +2 on it right?19:06
*** esp has joined #openstack-keystone19:06
amakarovstevemar, yes. It has -1 from Haneef Ali but I can contact him: looks like in his opinion we don't need it :)19:07
stevemaramakarov: lets hope dolphm has a few minutes to spare today19:08
dolphmamakarov: performance is not really a subjective thing19:09
*** david-lyle has quit IRC19:10
* stevemar needs food19:11
amakarovdolphm, hi! A bit of history: you asked for shared cache for v2 and v3 - I could do it for v3->v2 only as it's token data, that gets cached19:11
amakarovLeft a note about it in the code19:11
dolphmamakarov: stevemar benchmarked that token "issue" time went down with this patch -- how is that possible?19:11
amakarovstevemar, ^19:12
dolphmshouldn't this patch only improve validation performance?19:12
amakarovdolphm, I don't know )19:12
dolphmstevemar: what does benchmark.sh do?19:12
amakarovMy result was as expected19:12
openstackgerritRon De Rose proposed openstack/keystone: Add check that minimum password age is less than password expires days  https://review.openstack.org/36073719:13
amakarovdolphm, downloads patch, checks out HEAD^ runs token issue+validate token N times, gets average timings for both, then does the same for the patch itself19:14
amakarovdolphm, restarts apache in the process - here may be the volatility19:14
openstackgerritRon De Rose proposed openstack/keystone: Adds check that minimum password age is less than password expires days  https://review.openstack.org/36073719:14
stevemari did run it with devstack, so ....19:14
stevemaramakarov: dolphm: maybe issue time is now increased because we have to store the token?19:15
amakarovstevemar, I've written it with devstack :)19:15
amakarovstevemar, yes - it's the expected thing19:15
dolphmstevemar: it went *down*, not up (as i would have expected, slightly)19:16
dolphmstevemar: Average issue time .20173809523809523809 to .0433333333333333333319:16
amakarovstevemar, are you sure you copy-pasted the line WITH 1st symbol? ;)19:17
amakarovotoh it will kill the idea if token issue will start to take seconds...19:18
lbragstaddolphm I wonder if those 3 failing tests are because we are sharing metadata?19:18
lbragstadacross all the repositories?19:18
dolphmlbragstad: oh, maybe?19:19
lbragstadi can confirm that 109 runs completely19:19
lbragstadbut the column assertion afterwords doesn't seem to think one of those columns exists19:19
*** Ephur has joined #openstack-keystone19:23
*** Gorian|work has quit IRC19:23
dolphmlbragstad: could definitely be metadata19:24
*** NishaYadav has joined #openstack-keystone19:24
amakarovstevemar, dolphm I've added my results if it'll help19:24
*** su_zhang has joined #openstack-keystone19:24
*** NishaYadav is now known as Guest8805719:24
*** Gorian|work has joined #openstack-keystone19:26
*** nisha_ has quit IRC19:27
openstackgerritRon De Rose proposed openstack/keystone: Adds check that minimum password age is less than password expires days  https://review.openstack.org/36073719:27
*** amakarov is now known as amakarov_away19:27
*** su_zhang has quit IRC19:29
*** code-R has joined #openstack-keystone19:31
*** ruoyu has quit IRC19:33
*** nisha_ has joined #openstack-keystone19:34
*** edtubill has quit IRC19:35
*** slberger has quit IRC19:35
*** code-R has quit IRC19:36
*** Guest88057 has quit IRC19:38
lbragstaddolphm wait - each MigrationRepository has it's own metadata19:39
lbragstadthey just share an engine19:39
lbragstadso is it the engine that's the problem?19:40
*** Gorian|work has quit IRC19:40
dolphmlbragstad: uhh19:40
dolphmlbragstad: i don't know but i made the tests pass19:40
lbragstad?!19:41
openstackgerritDolph Mathews proposed openstack/keystone: Let upgrade tests control all 4 repositories at once  https://review.openstack.org/36066719:41
dolphmlbragstad: ^19:41
dolphmlbragstad: just keep pushing delete until it works19:42
*** Gorian|work has joined #openstack-keystone19:42
lbragstadhumf19:43
lbragstadinteresting19:43
dolphmlbragstad: but yes, 1 engine and now millions of metadatas19:44
lbragstadit looks the other way around/19:44
lbragstadit looks like we're using the same self.metadata everywhere19:45
lbragstadgdi19:45
lbragstadgerrit throwing a fit for me19:45
lbragstadgerrit is*19:45
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to implement some performance tuning adjustments, and should return to working order momentarily.19:46
bknudsonnotmorgan: finally figured out how to get my dev system deployed with use-threads=False ... still got an error19:47
bknudsonhttp://paste.openstack.org/show/563451/19:48
bknudsonAttributeError: 'RevokeEvent' object has no attribute 'user_id'19:48
bknudsonDiffferent error this time.19:48
*** slberger has joined #openstack-keystone19:51
notmorganbknudson: wtf.19:51
notmorganno really.. what the hell is going on here.19:52
notmorganthis makes no sense to me.19:52
dolphmbknudson: is that the cache bug?19:53
dolphmlbragstad: me too - i changed the definition for self.metadata, check it out19:53
bknudsondolphm: yes, these errors are seen when caching is on.19:53
notmorganfwiw, we never saw these errors with caching on until the massive cache refactor.19:54
dolphmbknudson: then it's probably the same underlying cause as the bugs that eric brown opened?19:54
notmorgani'm just baffled what happened along the way that is causing this19:54
lbragstaddolphm oh - got it!19:54
* lbragstad https://review.openstack.org/#/c/360667/4/keystone/tests/unit/test_sql_upgrade.py19:54
dolphmnotmorgan: good to know, i've been wondering if this was a problem in mitaka19:54
dolphmdstanek: fyi ^19:54
bknudsondolphm: I think they're all related.19:55
lbragstadyou get a metadata and you get a metadata! http://i2.kym-cdn.com/entries/icons/original/000/012/809/oprah-free-car.gif19:55
notmorganbknudson: ... stupid question, if we use pylibmc or something similar does it go away?19:56
notmorganbknudson: (basically anything but python-memcache)19:56
notmorgani'm still wondering if there is some stupid interaction happening there.19:57
bknudsonnotmorgan: that was something I was thinking about trying at some point. The docs seem to say that pylibmc is better.19:57
notmorgandolphm: the unpack values seems to have crept in during mitaka19:57
openstackgerritRon De Rose proposed openstack/keystone: Adds password regular expression checks to doctor  https://review.openstack.org/36075719:57
notmorganbknudson: because my debugging has led me to guessing at socket errors/re-used sockets when not all data is pulled off them in the python-memcache library19:58
notmorganbknudson: and that feels like a weird place to be.19:58
openstackgerritDolph Mathews proposed openstack/keystone: Let upgrade tests control all 4 repositories at once  https://review.openstack.org/36066719:58
dolphmlbragstad: updated19:58
dolphmnotmorgan: ooh, i like the pylibmc idea19:59
lbragstaddolphm sweet - thanks19:59
lbragstadupdating my patch19:59
openstackgerritRon De Rose proposed openstack/keystone: Adds password regular expression checks to doctor  https://review.openstack.org/36075720:00
*** tonytan_brb is now known as tonytan4ever20:02
lbragstaddolphm so i guess the lessoned learned is that sharing engines is cool - but sharing metadata isn't?20:02
openstackgerritMerged openstack/keystone: Use egg form of osprofiler in paste pipeline  https://review.openstack.org/36033720:02
*** su_zhang has joined #openstack-keystone20:03
*** sdake has quit IRC20:03
bknudsonwith sqlite in-memory you need to share the engine20:03
*** sdake has joined #openstack-keystone20:04
bknudsonok, switching to pylibmc if I can.20:04
* notmorgan nods.20:05
*** cheran has joined #openstack-keystone20:05
notmorganlbragstad: don't share metadata if you expect the schema or anything else to change20:05
notmorganlbragstad: it aggressively caches20:05
lbragstadnotmorgan huh - interesting20:05
lbragstadnotmorgan that would explain what dolphm and I were seeing20:06
notmorganlbragstad: the engine is the connection. Share that where needed - absolutely needed for in-mem-sqlite as bknudson said20:06
cheran@here When I tried to give access to list_user_projects to member role in policy.json, it's still picking up the default `admin_required` rule20:06
notmorganlbragstad: in non-in-mem (process space store) you can use separate engine instantations as needed20:06
notmorganbut since the in-mem stuff is tied to that specific connection, and vaporizes when it's gone, need to share it20:07
*** ruoyu has joined #openstack-keystone20:11
bknudsonoh, I forgot to change the backend from memcache_pool. Let me try that first.20:12
*** tqtran has quit IRC20:12
*** NishaYadav has joined #openstack-keystone20:13
*** NishaYadav is now known as Guest5271220:13
notmorganbknudson: hehe ok20:14
notmorganbknudson: if it all works after that, yay threads and pool20:14
*** slberger has quit IRC20:15
notmorganif it is still b0rked, pylibmc would be thge next test20:15
*** lamt has quit IRC20:15
notmorganif that still is an issue, it's something we're doing in keystone, dogpile, or oslo_cache20:15
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/35951320:15
notmorganbut really we aren't doing much fancy stuff at this point20:15
*** nisha_ has quit IRC20:15
ruoyuHello! Our team want to get realtime user information from keystone logs. Logging_context_format_string should print user id in the logs but it doesn’t work. For an example, when I log in with a wrong password, in keystone I only got log message like “2016-08-22 17:00:15.396 2707 WARNING keystone.common.wsgi [req-c9ab9248-4f94-4ed0-9005-10fe3c5e5486 - - - - -] Authorization failed. The request you have made requi20:16
ruoyures authentication. from 10.14.37.215”. We think the user id should be next to the request id but we only got ‘-‘. Any instruction is greatly appreciated. Thank you very much!20:16
*** Marcellin_ has quit IRC20:17
*** roxanaghe has joined #openstack-keystone20:19
*** lamt has joined #openstack-keystone20:21
*** roxanaghe has quit IRC20:24
bknudsonnotmorgan: dolphm: http://paste.openstack.org/show/563462/20:25
bknudsonmaybe it's uwsgi?20:25
notmorganmaybe20:25
bknudsonor apache-uwsgi. I was seeing errors there when I tried to use it a while back.20:26
notmorganhuh20:26
notmorgancan you fire up uwsgi in HTTP (non-proxy) mode on the right ports?20:26
bknudsonshould be able to .20:26
notmorganapache-uwsgi is fairly new compared to the rest of the stack20:26
notmorganbut still, that feels like a red herring20:26
notmorgani hope it's not uwsgi.20:27
bknudsony, and I know there's bugs in older versions of apache-uwsgi.20:27
bknudsonit's talking over a pipe to uwsgi so that shouldn't be it.20:27
bknudsonshouldn't mess with talking to memcached.20:27
*** slberger has joined #openstack-keystone20:27
*** tqtran has joined #openstack-keystone20:28
dolphmbknudson: i doubt eric brown was using uwsgi20:28
notmorganbknudson: exactly20:28
*** su_zhang has quit IRC20:29
*** sdake has quit IRC20:29
*** su_zhang has joined #openstack-keystone20:29
openstackgerritMerged openstack/keystone: Support new osprofiler API  https://review.openstack.org/34140120:30
bknudsonfor some reason we're using uwsgi packages from ubuntu and not pypi.20:30
bknudsonii  uwsgi-core                        1.9.17.1-5build5                 amd64        fast, self-healing application container server (core)20:30
bknudsonvs uWSGI 2.0.13.120:31
bknudsonold-school20:31
notmorgani've never used the distro uwsgi package20:31
notmorganalways pypi20:31
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561820:31
*** Guest52712 is now known as nisha_20:31
bknudsonI can't imagine why jamielennox decided to break everything and use uwsgi from packages!20:31
lbragstaddolphm ^ the sqlite trigger there work now20:31
lbragstadtriggers*20:31
*** Ephur has quit IRC20:32
lbragstadaccording to the special update read only case20:32
*** nisha_ has quit IRC20:32
*** asettle has quit IRC20:32
*** sdake has joined #openstack-keystone20:35
dolphmlbragstad: wewt!20:36
*** asettle has joined #openstack-keystone20:36
lbragstaddolphm gonna run the tests with mysql and postgres in a minute20:36
*** Gorian|work has quit IRC20:40
openstackgerritRon De Rose proposed openstack/keystone: Adds password regular expression checks to doctor  https://review.openstack.org/36075720:41
*** gyee has joined #openstack-keystone20:42
*** ChanServ sets mode: +v gyee20:42
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements  https://review.openstack.org/35951320:45
*** asettle has quit IRC20:45
stevemarbknudson: sounds like something jamielennox would deliberately do20:45
stevemarhe's an anarchist like that20:45
*** chris_hultin is now known as spedione|AWAY20:46
bknudsonwell, maybe he's just smarter than everyone because new uwsgi didn't help.20:47
bknudsonhere's what I got this time: http://paste.openstack.org/show/563464/20:49
*** nkinder has quit IRC20:50
ruoyuHello! Our team want to get realtime user information from keystone logs. Logging_context_format_string should print user id in the logs but it doesn’t work. For an example, when I log in with a wrong password, in keystone I only got log message like “2016-08-22 17:00:15.396 2707 WARNING keystone.common.wsgi [req-c9ab9248-4f94-4ed0-9005-10fe3c5e5486 - - - - -] Authorization failed. The request you have made requi20:52
ruoyures authentication. from 10.14.37.215”. We think the user id should be next to the request id but we only got ‘-‘. Any instruction is greatly appreciated. Thank you very much!20:52
knikollastevemar: ^^ ruoyu is an intern working in our monitoring team20:52
*** tqtran has quit IRC20:53
bknudsonnotmorgan: here's a different error from pylibmc: http://paste.openstack.org/show/563466/20:53
bknudson2016-08-25 20:52:05.710 19409 ERROR keystone.common.wsgi Exception: get keystone.revoke.core:_list_events|None as 1921523d6734d44e88ed58dfc76ef681a36b8e9b failed: error 26 from memcached_get(1921523d6734d44e88ed58dfc76ef681): Operation now in progress20:53
notmorganblink20:55
notmorganwut20:55
notmorganok i am ready to say we're doing something stupid somewhere20:55
*** tqtran has joined #openstack-keystone20:57
openstackgerritSteve Martinelli proposed openstack/keystone: Reduce log level of Fernet key count message  https://review.openstack.org/35994120:57
openstackgerritSteve Martinelli proposed openstack/keystone: Removes old, unused code  https://review.openstack.org/36056120:57
bknudsonwell, one way to do this is start digging and get more debug info.20:59
notmorganyeah =/21:00
bknudsonI'll switch back to pure python. The protocol is so simple there shouldn't be any need for a C lib.21:00
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561821:00
bknudsonhttps://github.com/lericson/pylibmc/issues/89 -- says they used libmemcached 1.0-15 and that helped.21:04
bknudsonstill, seems like there's something going on since it's every driver has the problem.21:05
notmorganright21:05
*** sdake_ has joined #openstack-keystone21:05
*** sdake has quit IRC21:08
*** ravelar has quit IRC21:15
*** sdake_ has quit IRC21:20
*** sdake has joined #openstack-keystone21:22
lbragstadhenrynash ping21:22
bknudsonthis latest test I was seeing keystone clients hanging, and one of them eventually got the 500 error. Then I saw apache2 process was spinning.21:22
bknudsonthis is why everyone uses nginx now21:22
*** marekd2 has joined #openstack-keystone21:23
bretonwhat's being debugged?21:24
*** david-lyle has joined #openstack-keystone21:26
*** esp has quit IRC21:26
*** marekd2 has quit IRC21:27
*** esp has joined #openstack-keystone21:28
bknudsonbreton: https://bugs.launchpad.net/keystone/+bug/160039421:29
openstackLaunchpad bug 1600394 in OpenStack Identity (keystone) "memcache raising "too many values to unpack"" [Critical,Confirmed] - Assigned to David Stanek (dstanek)21:29
*** david-lyle has quit IRC21:31
breton> Also, I was never able to recreate on a devstack system, so maybe it's got a fixed version of something memcache related.21:33
bretonbknudson: have you tried it on devstack with apache2 or with uwsgi?21:34
bknudsonbreton: I haven't been able to track it down. The configuration I'm running with is quite a bit different than what devstack sets up.21:34
breton(sorry for taking your attention from debugging)21:34
bknudsondevstack was with uwsgi21:34
*** pauloewerton has quit IRC21:35
openstackgerritLance Bragstad proposed openstack/keystone: Implement encryption of credentials at rest  https://review.openstack.org/35561821:36
*** esp has quit IRC21:36
lbragstaddolphm dstanek henrynash stevemar ^ passes locally running against sqlite, mysql, and postgres21:37
lbragstadI also added the opportunistic tests to run FullMigration if postgres or mysql is enabled to do so21:38
dolphmlbragstad: ++!21:39
*** ruoyu has quit IRC21:52
jamielennoxbknudson: because uwsgi is not actually a python thing and comes with C libraries :(22:01
jamielennoxbknudson: it seemed ilke the right idea22:01
jamielennoxalso because i expected it to be a good idea to be using the same apache plugin version as uwsgi runner22:02
*** BjoernT has quit IRC22:03
*** ddieterly is now known as ddieterly[away]22:05
*** michauds has quit IRC22:05
*** slberger has left #openstack-keystone22:06
*** roxanaghe has joined #openstack-keystone22:07
*** ddieterly[away] is now known as ddieterly22:10
*** roxanagh_ has joined #openstack-keystone22:12
*** roxanaghe has quit IRC22:12
*** lamt has quit IRC22:16
*** roxanagh_ has quit IRC22:16
*** sdake has quit IRC22:24
*** ntpttr has quit IRC22:31
*** esp has joined #openstack-keystone22:32
*** ntpttr has joined #openstack-keystone22:36
*** sdake has joined #openstack-keystone22:37
*** tqtran has quit IRC22:55
*** tqtran has joined #openstack-keystone22:55
*** adriant has joined #openstack-keystone22:55
*** ddieterly has quit IRC22:56
*** chlong has quit IRC22:58
*** hockeynut has joined #openstack-keystone22:59
*** tqtran has quit IRC22:59
*** tqtran has joined #openstack-keystone23:00
bknudsonjamielennox: do we need apache? we've already got haproxy23:00
jamielennoxbknudson: you would still need apache for any federation modules23:01
jamielennoxbknudson: i'm also not sure you can go direct from haproxy to uwsgi, it's not a straight HTTP redirect i don't think23:01
bknudsonjamielennox: we're not supporting any federation now, and there's no tests in place anyways23:03
bknudsonuwsgi supports http23:03
*** tqtran has quit IRC23:04
jamielennoxthen yea, i guess it could be done, i don't know if there are issues about exposing uwsgi directly23:06
jamielennoxit'll make the ursula equivalent harder though23:06
jamielennoxbecause there is federation support there23:06
*** tqtran has joined #openstack-keystone23:09
*** hockeynut has quit IRC23:10
*** chlong has joined #openstack-keystone23:12
*** tqtran_ has joined #openstack-keystone23:13
*** tqtran has quit IRC23:13
*** chlong has quit IRC23:35
*** marekd2 has joined #openstack-keystone23:44
*** esp has quit IRC23:46
*** marekd2 has quit IRC23:48
*** david-lyle has joined #openstack-keystone23:52
*** rcernin has quit IRC23:53
*** roxanaghe has joined #openstack-keystone23:57
*** roxanaghe_ has quit IRC23:58
*** woodster_ has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!