| *** adu has quit IRC | 00:00 | |
| *** adu has joined #openstack-keystone | 00:05 | |
| *** rcernin has quit IRC | 00:12 | |
| *** BjoernT has joined #openstack-keystone | 00:18 | |
| *** dan_nguyen has quit IRC | 00:20 | |
| *** BjoernT has quit IRC | 00:23 | |
| *** edtubill has joined #openstack-keystone | 00:24 | |
| *** raddaoui has quit IRC | 00:27 | |
| *** agrebennikov has quit IRC | 00:28 | |
| *** edtubill has quit IRC | 00:28 | |
| *** dan_nguyen has joined #openstack-keystone | 00:29 | |
| openstackgerrit | Dolph Mathews proposed openstack/keystone: Replace keystone.common.config with keystone.conf package https://review.openstack.org/325604 | 00:31 |
|---|---|---|
| *** dan_nguyen has quit IRC | 00:35 | |
| *** spzala has joined #openstack-keystone | 00:36 | |
| *** daemontool has quit IRC | 00:38 | |
| *** spzala has quit IRC | 00:42 | |
| openstackgerrit | Sam Leong proposed openstack/keystoneauth: Auth plugin for X.509 tokenless authz https://review.openstack.org/283905 | 00:49 |
| *** edtubill has joined #openstack-keystone | 00:50 | |
| *** edtubill has quit IRC | 00:52 | |
| *** roxanaghe has quit IRC | 00:52 | |
| *** spzala has joined #openstack-keystone | 00:59 | |
| *** spzala has quit IRC | 01:01 | |
| *** spzala has joined #openstack-keystone | 01:01 | |
| *** davechen has joined #openstack-keystone | 01:01 | |
| *** ayoung has joined #openstack-keystone | 01:02 | |
| *** ChanServ sets mode: +v ayoung | 01:02 | |
| *** julim has joined #openstack-keystone | 01:08 | |
| *** EinstCrazy has joined #openstack-keystone | 01:31 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Don't mock the session.request function https://review.openstack.org/333648 | 01:31 |
| *** tqtran has quit IRC | 01:31 | |
| *** EinstCrazy has quit IRC | 01:33 | |
| *** jefrite has quit IRC | 01:34 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Don't mock the session.request function https://review.openstack.org/333648 | 01:34 |
| *** EinstCrazy has joined #openstack-keystone | 01:45 | |
| *** TxGVNN has joined #openstack-keystone | 01:47 | |
| *** dave-mccowan has quit IRC | 01:56 | |
| *** woodster_ has quit IRC | 02:09 | |
| *** spandhe has quit IRC | 02:16 | |
| *** henrynash has joined #openstack-keystone | 02:22 | |
| *** ChanServ sets mode: +v henrynash | 02:22 | |
| *** tqtran has joined #openstack-keystone | 02:29 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Support local config options https://review.openstack.org/321882 | 02:32 |
| openstackgerrit | gecong proposed openstack/keystone: Fix some spelling mistakes in keystone Donmain should be domain prvider should be provider boudary should be boundary convesion should be conversion inteface should be interface projcets should be projects sensistive should be sens https://review.openstack.org/333659 | 02:34 |
| *** tqtran has quit IRC | 02:34 | |
| *** dave-mccowan has joined #openstack-keystone | 02:37 | |
| openstackgerrit | Merged openstack/keystone: exception sensitive cache/audit changes https://review.openstack.org/273218 | 02:43 |
| *** gyee has quit IRC | 02:51 | |
| openstackgerrit | Merged openstack/keystoneauth: oidc: refactor unit tests https://review.openstack.org/330966 | 02:52 |
| *** M00nr41n has joined #openstack-keystone | 02:53 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Fix a few spelling mistakes https://review.openstack.org/333659 | 02:53 |
| *** spzala has quit IRC | 02:55 | |
| *** spzala has joined #openstack-keystone | 02:56 | |
| *** spzala has quit IRC | 02:56 | |
| *** spzala has joined #openstack-keystone | 02:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements https://review.openstack.org/333429 | 02:57 |
| henrynash | stevemar: ping | 03:11 |
| stevemar | henrynash: pong | 03:11 |
| stevemar | henrynash: whats going on there? i need to come rescue you? | 03:11 |
| henrynash | yeah, I know…going to hell in a handbasket (or whatever the expression is) | 03:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/333683 | 03:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystoneauth: Updated from global requirements https://review.openstack.org/333429 | 03:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/333430 | 03:12 |
| henrynash | away from crazy referendums… | 03:12 |
| henrynash | I noticed we merged: I noticed we merged https://review.openstack.org/#/c/314284/ | 03:12 |
| patchbot | henrynash: patch 314284 - keystone - PCI-DSS Password SQL model changes (MERGED) | 03:12 |
| henrynash | this will (I think) fail on a rolling upgrade (if you create a user before all servers are upgraded) | 03:13 |
| stevemar | henrynash: yeah. i saw that merge today -- haven't have a chance to look at it -- was going to today | 03:13 |
| stevemar | henrynash: oh? dammit | 03:13 |
| stevemar | henrynash: what makes you say that | 03:13 |
| stevemar | migration 105 looks okay | 03:13 |
| stevemar | create columns and set defaults for them | 03:14 |
| henrynash | so the created_at attrinute is non nullable…but old s/w won’t know about the attribute so won’t put anything in it | 03:14 |
| henrynash | ahh, oops , sorry…loooks like we backed of that | 03:15 |
| henrynash | aorry, false alarm…Ron did do what I was suggesting and revert that part | 03:15 |
| stevemar | henrynash: *phew* | 03:16 |
| stevemar | henrynash: this part: password_table.c.created_at.alter(nullable=False) ? | 03:16 |
| henrynash | damn, gerrit….had realized I was looking at the older version! | 03:16 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.policy: Updated from global requirements https://review.openstack.org/333445 | 03:16 |
| henrynash | yep, that would have caused the issue | 03:16 |
| stevemar | henrynash: good job catching the issue, did the unit test catch it? | 03:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/333448 | 03:17 |
| henrynash | yes | 03:17 |
| stevemar | nice | 03:17 |
| stevemar | henrynash: everything is peachy then, you can go back to your handbasket | 03:17 |
| henrynash | rather not... | 03:18 |
| stevemar | henrynash: i didn't realize you guys had your own dtrump lookin figure up there :P | 03:18 |
| stevemar | he's got the hair | 03:18 |
| henrynash | yep, he’s a piece of work | 03:18 |
| henrynash | actually that one is a smart guy, if a little wacky | 03:19 |
| stevemar | i can always recommend you for canadian citizenship :P | 03:19 |
| henrynash | NIgel Farage is the one that a piece of work | 03:19 |
| stevemar | its just like living in the UK, only colder | 03:19 |
| henrynash | time my tell, time may tell…. | 03:19 |
| *** rm_work has quit IRC | 03:22 | |
| *** rm_work has joined #openstack-keystone | 03:25 | |
| *** davechen has quit IRC | 03:25 | |
| *** spzala has quit IRC | 03:27 | |
| *** spzala has joined #openstack-keystone | 03:27 | |
| *** spzala has quit IRC | 03:27 | |
| *** spzala has joined #openstack-keystone | 03:28 | |
| *** richm has quit IRC | 03:28 | |
| *** rcernin has joined #openstack-keystone | 03:34 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Support local config options https://review.openstack.org/321882 | 03:42 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Use oslo.config fixture in audit tests https://review.openstack.org/333714 | 03:42 |
| *** edtubill has joined #openstack-keystone | 03:50 | |
| *** edtubill has quit IRC | 03:58 | |
| *** sdake_ has joined #openstack-keystone | 04:00 | |
| *** sdake has quit IRC | 04:02 | |
| *** M00nr41n has quit IRC | 04:03 | |
| *** edtubill has joined #openstack-keystone | 04:08 | |
| *** markvoelker has quit IRC | 04:11 | |
| *** spzala has quit IRC | 04:15 | |
| *** GB21 has joined #openstack-keystone | 04:15 | |
| *** spzala has joined #openstack-keystone | 04:16 | |
| *** spzala has quit IRC | 04:20 | |
| *** david-lyle has quit IRC | 04:20 | |
| *** david-lyle has joined #openstack-keystone | 04:20 | |
| *** spandhe_ has joined #openstack-keystone | 04:20 | |
| *** sdake_ has quit IRC | 04:22 | |
| *** walharthi has joined #openstack-keystone | 04:30 | |
| *** tqtran has joined #openstack-keystone | 04:31 | |
| *** tqtran has quit IRC | 04:35 | |
| *** links has joined #openstack-keystone | 04:37 | |
| *** sdake has joined #openstack-keystone | 04:38 | |
| *** edtubill has quit IRC | 04:40 | |
| *** EinstCrazy has quit IRC | 04:40 | |
| *** edtubill has joined #openstack-keystone | 04:42 | |
| *** EinstCrazy has joined #openstack-keystone | 04:47 | |
| *** spandhe_ has quit IRC | 04:48 | |
| *** edtubill has quit IRC | 04:50 | |
| *** links has quit IRC | 04:50 | |
| *** edtubill has joined #openstack-keystone | 04:50 | |
| *** links has joined #openstack-keystone | 04:50 | |
| *** dave-mccowan has quit IRC | 04:50 | |
| *** spandhe has joined #openstack-keystone | 04:51 | |
| *** edtubill has quit IRC | 04:54 | |
| openstackgerrit | Merged openstack/keystone: Fix a few spelling mistakes https://review.openstack.org/333659 | 04:56 |
| *** M00nr41n has joined #openstack-keystone | 05:04 | |
| *** GB21 has quit IRC | 05:05 | |
| *** edtubill has joined #openstack-keystone | 05:08 | |
| *** spandhe has quit IRC | 05:08 | |
| *** spandhe has joined #openstack-keystone | 05:09 | |
| *** julim has quit IRC | 05:10 | |
| *** markvoelker has joined #openstack-keystone | 05:11 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Pop oslo_config_config before doing paste convert https://review.openstack.org/333734 | 05:13 |
| *** edtubill has quit IRC | 05:15 | |
| *** markvoelker has quit IRC | 05:16 | |
| openstackgerrit | Merged openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/333430 | 05:17 |
| *** edtubill has joined #openstack-keystone | 05:19 | |
| *** adu has quit IRC | 05:21 | |
| openstackgerrit | Merged openstack/keystoneauth: Updated from global requirements https://review.openstack.org/333429 | 05:23 |
| *** links has quit IRC | 05:25 | |
| *** ramishra has joined #openstack-keystone | 05:27 | |
| ramishra | hey guys it seems heat gate is broken by https://review.openstack.org/#/c/314284/ | 05:28 |
| patchbot | ramishra: patch 314284 - keystone - PCI-DSS Password SQL model changes (MERGED) | 05:28 |
| ramishra | http://logs.openstack.org/76/333676/1/check/gate-heat-dsvm-functional-orig-mysql-lbaasv2/516afaa/logs/apache/keystone.txt.gz?#_2016-06-24_03_34_02_273 | 05:28 |
| ramishra | jamielennox: hi would you be able to have a look and confirm? | 05:29 |
| *** edtubill has quit IRC | 05:30 | |
| *** sdake has quit IRC | 05:32 | |
| jamielennox | stevemar: ^ | 05:34 |
| *** sdake has joined #openstack-keystone | 05:34 | |
| *** rcernin has quit IRC | 05:35 | |
| *** links has joined #openstack-keystone | 05:39 | |
| *** ramishra has quit IRC | 05:42 | |
| jamielennox | i'm not entirely sure what's causing that, but i don't know the dss changes well | 05:43 |
| *** sheel has quit IRC | 05:45 | |
| *** ramishra has joined #openstack-keystone | 05:47 | |
| openstackgerrit | Merged openstack/keystone: Updated from global requirements https://review.openstack.org/333683 | 05:49 |
| *** walharthi has quit IRC | 05:56 | |
| *** josecastroleon has joined #openstack-keystone | 06:00 | |
| *** EinstCrazy has quit IRC | 06:02 | |
| *** GB21 has joined #openstack-keystone | 06:04 | |
| *** links has quit IRC | 06:05 | |
| *** spandhe has quit IRC | 06:06 | |
| *** edtubill has joined #openstack-keystone | 06:08 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Use oslo.config fixture in audit tests https://review.openstack.org/333714 | 06:11 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Support local config options https://review.openstack.org/321882 | 06:11 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Move audit into its own folder https://review.openstack.org/333755 | 06:11 |
| *** rcernin has joined #openstack-keystone | 06:11 | |
| *** GB21 has quit IRC | 06:12 | |
| *** edtubill has quit IRC | 06:12 | |
| *** markvoelker has joined #openstack-keystone | 06:13 | |
| *** ramishra has quit IRC | 06:16 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Don't mock the session.request function https://review.openstack.org/333648 | 06:16 |
| *** EinstCrazy has joined #openstack-keystone | 06:16 | |
| *** ramishra has joined #openstack-keystone | 06:17 | |
| *** markvoelker has quit IRC | 06:17 | |
| *** links has joined #openstack-keystone | 06:18 | |
| *** ramishra has quit IRC | 06:22 | |
| *** davechen has joined #openstack-keystone | 06:23 | |
| *** ramishra has joined #openstack-keystone | 06:27 | |
| *** ramishra has quit IRC | 06:28 | |
| *** ramishra has joined #openstack-keystone | 06:31 | |
| ramishra | jamielennox, stevemar: Should we wait for a quick fix/revert for the issue? Else we would have to disable the relevant failing tests. | 06:31 |
| *** tqtran has joined #openstack-keystone | 06:32 | |
| jamielennox | ramishra: i'm going to have to pass this one off, we can do a quick revert particularly if other services are affected | 06:32 |
| jamielennox | ramishra: but i'd also really like to know what is causing it | 06:33 |
| openstackgerrit | yangweiwei proposed openstack/keystone: Error in get revoke_list https://review.openstack.org/333765 | 06:33 |
| jamielennox | it looks like something is creating a user without a password? | 06:33 |
| jamielennox | or something.. | 06:33 |
| jamielennox | i'm not sure | 06:33 |
| ramishra | jamielennox: I had the same unserstanding, what heat is trying is to disable and existing user, but this seems to be trying to insert a row in the password table with None value. | 06:35 |
| ramishra | s/and/an | 06:35 |
| *** tqtran has quit IRC | 06:37 | |
| *** links has quit IRC | 06:37 | |
| *** GB21 has joined #openstack-keystone | 06:43 | |
| openstackgerrit | yangweiwei proposed openstack/keystone: Error in get revoke_list https://review.openstack.org/333765 | 06:44 |
| *** links has joined #openstack-keystone | 06:49 | |
| jamielennox | stevemar: can you make sure to get on this early tomorrow? | 06:53 |
| jamielennox | ron isn't online | 06:54 |
| openstackgerrit | Jamie Lennox proposed openstack/keystonemiddleware: Use createfile fixture in audit test https://review.openstack.org/333775 | 06:56 |
| *** tesseract- has joined #openstack-keystone | 06:57 | |
| *** jbell8 has joined #openstack-keystone | 07:03 | |
| *** yolanda has joined #openstack-keystone | 07:04 | |
| *** jbell8 has quit IRC | 07:05 | |
| *** jbell8 has joined #openstack-keystone | 07:06 | |
| *** sdake_ has joined #openstack-keystone | 07:12 | |
| *** markvoelker has joined #openstack-keystone | 07:13 | |
| *** jbell8 has quit IRC | 07:14 | |
| *** sdake has quit IRC | 07:15 | |
| *** EinstCrazy has quit IRC | 07:17 | |
| *** markvoelker has quit IRC | 07:19 | |
| *** EinstCrazy has joined #openstack-keystone | 07:20 | |
| *** jbell8 has joined #openstack-keystone | 07:20 | |
| *** ebarrera has joined #openstack-keystone | 07:22 | |
| *** EinstCrazy has quit IRC | 07:27 | |
| *** EinstCrazy has joined #openstack-keystone | 07:28 | |
| *** EinstCrazy has quit IRC | 07:28 | |
| *** EinstCrazy has joined #openstack-keystone | 07:29 | |
| *** EinstCrazy has quit IRC | 07:29 | |
| *** amoralej|off is now known as amoralej | 07:29 | |
| *** jbell8 has quit IRC | 07:30 | |
| *** jbell8 has joined #openstack-keystone | 07:31 | |
| *** jbell8 has quit IRC | 07:32 | |
| *** jbell8 has joined #openstack-keystone | 07:32 | |
| *** pnavarro has joined #openstack-keystone | 07:37 | |
| *** ramishra has quit IRC | 07:37 | |
| *** EinstCra_ has joined #openstack-keystone | 07:38 | |
| *** ramishra has joined #openstack-keystone | 07:38 | |
| *** EinstCrazy has joined #openstack-keystone | 07:40 | |
| *** EinstCra_ has quit IRC | 07:43 | |
| *** EinstCra_ has joined #openstack-keystone | 07:43 | |
| *** EinstCrazy has quit IRC | 07:44 | |
| *** josecastroleon has quit IRC | 07:45 | |
| *** josecastroleon has joined #openstack-keystone | 07:48 | |
| *** EinstCrazy has joined #openstack-keystone | 07:49 | |
| *** EinstCra_ has quit IRC | 07:50 | |
| *** ramishra has quit IRC | 07:50 | |
| *** ramishra has joined #openstack-keystone | 07:51 | |
| *** EinstCra_ has joined #openstack-keystone | 07:54 | |
| *** EinstCrazy has quit IRC | 07:54 | |
| *** rcernin has quit IRC | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-keystone | 08:00 | |
| *** pnavarro has quit IRC | 08:00 | |
| *** sdake_ has quit IRC | 08:02 | |
| *** davechen has left #openstack-keystone | 08:04 | |
| *** EinstCra_ has quit IRC | 08:04 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c https://review.openstack.org/318435 | 08:10 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c https://review.openstack.org/318435 | 08:10 |
| *** EinstCrazy has joined #openstack-keystone | 08:12 | |
| *** pnavarro has joined #openstack-keystone | 08:13 | |
| *** dmk0202 has joined #openstack-keystone | 08:17 | |
| *** pnavarro has quit IRC | 08:17 | |
| *** daemontool has joined #openstack-keystone | 08:17 | |
| *** ramishra has quit IRC | 08:20 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: WIP - oidc: fix OpenID Connect authorization code grant_type https://review.openstack.org/330006 | 08:27 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: move scope into _OidcBase https://review.openstack.org/330463 | 08:27 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: add discovery document support https://review.openstack.org/330464 | 08:27 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: remove grant_type argument https://review.openstack.org/330465 | 08:27 |
| *** ramishra has joined #openstack-keystone | 08:30 | |
| *** GB21 has quit IRC | 08:45 | |
| *** d0ugal has quit IRC | 08:46 | |
| *** d0ugal has joined #openstack-keystone | 08:46 | |
| *** d0ugal has quit IRC | 08:46 | |
| *** d0ugal has joined #openstack-keystone | 08:46 | |
| *** ramishra has quit IRC | 09:01 | |
| *** ramishra has joined #openstack-keystone | 09:03 | |
| *** jbell8 has quit IRC | 09:12 | |
| *** spzala has joined #openstack-keystone | 09:16 | |
| *** markvoelker has joined #openstack-keystone | 09:16 | |
| *** markvoelker has quit IRC | 09:20 | |
| *** spzala has quit IRC | 09:21 | |
| *** nisha_ has joined #openstack-keystone | 09:23 | |
| nisha_ | Hey all :) | 09:40 |
| *** fawadkhaliq has joined #openstack-keystone | 09:42 | |
| *** fawadkhaliq has quit IRC | 09:42 | |
| *** ramishra has quit IRC | 09:45 | |
| *** nisha__ has joined #openstack-keystone | 09:50 | |
| *** ramishra has joined #openstack-keystone | 09:52 | |
| *** henrynash has quit IRC | 09:54 | |
| *** markvoelker has joined #openstack-keystone | 09:54 | |
| *** nisha_ has quit IRC | 09:55 | |
| *** rmizuno has quit IRC | 09:59 | |
| *** nisha__ is now known as nisha_ | 09:59 | |
| *** pcaruana has joined #openstack-keystone | 10:09 | |
| *** ramishra has quit IRC | 10:13 | |
| *** ramishra has joined #openstack-keystone | 10:13 | |
| aloga | jamielennox: are you around? | 10:22 |
| *** ramishra has quit IRC | 10:30 | |
| *** ramishra has joined #openstack-keystone | 10:30 | |
| *** josecastroleon has quit IRC | 10:33 | |
| *** nisha_ has quit IRC | 10:43 | |
| *** nisha_ has joined #openstack-keystone | 10:43 | |
| *** EinstCrazy has quit IRC | 10:48 | |
| *** TxGVNN has quit IRC | 10:48 | |
| *** nisha_ has quit IRC | 10:53 | |
| *** nisha_ has joined #openstack-keystone | 10:54 | |
| *** ramishra has quit IRC | 11:01 | |
| *** ramishra has joined #openstack-keystone | 11:02 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: WIP - oidc: fix OpenID Connect authorization code grant_type https://review.openstack.org/330006 | 11:07 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: move scope into _OidcBase https://review.openstack.org/330463 | 11:07 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: add discovery document support https://review.openstack.org/330464 | 11:07 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: fix OpenID Connect scope option https://review.openstack.org/333261 | 11:07 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: remove grant_type argument https://review.openstack.org/330465 | 11:07 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/keystoneauth: oidc: add tests for plugin loader https://review.openstack.org/333850 | 11:07 |
| *** ramishra has quit IRC | 11:14 | |
| *** M00nr41n has quit IRC | 11:20 | |
| *** josecastroleon has joined #openstack-keystone | 11:22 | |
| *** bjornar_ has joined #openstack-keystone | 11:30 | |
| *** ramishra has joined #openstack-keystone | 11:32 | |
| *** tqtran has joined #openstack-keystone | 11:34 | |
| stevemar | jamielennox: on it | 11:34 |
| stevemar | dolphm: heads up about https://bugs.launchpad.net/bugs/1595819 i subbed you and ron | 11:35 |
| openstack | Launchpad bug 1595819 in heat "functional.test_autoscaling.AutoScalingSignalTest failure" [High,New] | 11:35 |
| *** nisha_ has quit IRC | 11:36 | |
| *** ramishra has quit IRC | 11:36 | |
| *** nisha_ has joined #openstack-keystone | 11:37 | |
| *** bjornar_ has quit IRC | 11:39 | |
| *** tqtran has quit IRC | 11:39 | |
| *** nisha_ has quit IRC | 11:39 | |
| *** samueldmq has joined #openstack-keystone | 11:45 | |
| *** ChanServ sets mode: +v samueldmq | 11:45 | |
| samueldmq | morning | 11:45 |
| *** nisha_ has joined #openstack-keystone | 11:51 | |
| *** ddieterly has joined #openstack-keystone | 11:53 | |
| *** bjornar_ has joined #openstack-keystone | 11:54 | |
| *** ddieterly has quit IRC | 11:59 | |
| *** rcernin has joined #openstack-keystone | 12:04 | |
| *** ddieterly has joined #openstack-keystone | 12:11 | |
| *** dave-mccowan has joined #openstack-keystone | 12:13 | |
| aloga | hi samueldmq | 12:25 |
| samueldmq | aloga: hi | 12:26 |
| *** ddieterly has quit IRC | 12:26 | |
| *** hughsaunders has left #openstack-keystone | 12:31 | |
| stevemar | good evening aloga :) | 12:36 |
| aloga | stevemar: afternoon ;) | 12:36 |
| stevemar | so close! | 12:36 |
| aloga | hehe | 12:36 |
| *** gordc has joined #openstack-keystone | 12:37 | |
| *** khmcgill has joined #openstack-keystone | 12:37 | |
| khmcgill | Can anyone tell me if there is special permissions or scenario needed to make this API call? http://developer.openstack.org/api-ref-identity-v3.html#listUsers | 12:37 |
| khmcgill | It fails for me even as 'admin' user in 'Default' domain | 12:37 |
| samueldmq | brb | 12:41 |
| *** samueldmq has quit IRC | 12:41 | |
| *** alex_xu has quit IRC | 12:46 | |
| *** ddieterly has joined #openstack-keystone | 12:46 | |
| aloga | khmcgill: I guess so https://github.com/openstack/keystone/blob/master/etc/policy.json#L45 | 12:46 |
| *** alex_xu has joined #openstack-keystone | 12:48 | |
| khmcgill | hmm but I do have an admin role | 12:48 |
| khmcgill | Scenario is, 2 Domains: Default and Test-Domain. Test-Domain is configured to use LDAP | 12:49 |
| khmcgill | what impacts could/would that have? | 12:50 |
| *** samueldmq has joined #openstack-keystone | 12:54 | |
| *** ChanServ sets mode: +v samueldmq | 12:54 | |
| samueldmq | khmcgill: did you get help about the permissions you were asking for ? | 12:55 |
| *** nisha__ has joined #openstack-keystone | 12:55 | |
| samueldmq | (I had to go afk) | 12:55 |
| samueldmq | stevemar: o/ | 12:55 |
| *** edmondsw has joined #openstack-keystone | 12:55 | |
| khmcgill | aloga pointed me to this https://github.com/openstack/keystone/blob/master/etc/policy.json#L45 which states to make the list-users call I want I need to be an admin however I am making the api calls as admin so i'm stil confused by this one | 12:57 |
| khmcgill | also, i have 2 Domains: Default and Test-Domain. Test-Domain is configured to use LDAP. I didn't configure the setup and am not a keystone expert so I'm not sure what the impact that makes | 12:58 |
| *** nisha_ has quit IRC | 12:58 | |
| khmcgill | before changing the setup and there was only 1 'Default' domain,...that api call worked | 12:58 |
| khmcgill | now it doesn't | 12:58 |
| khmcgill | not matter what I get a 401 | 12:59 |
| *** nisha__ is now known as nisha_ | 13:00 | |
| *** links has quit IRC | 13:00 | |
| *** darosale has joined #openstack-keystone | 13:00 | |
| *** ddieterly has quit IRC | 13:02 | |
| *** dave-mccowan has quit IRC | 13:08 | |
| *** spzala has joined #openstack-keystone | 13:17 | |
| *** sdake has joined #openstack-keystone | 13:21 | |
| *** spzala has quit IRC | 13:21 | |
| *** richm has joined #openstack-keystone | 13:22 | |
| *** amoralej is now known as amoralej|lunch | 13:29 | |
| *** kfox1111_away is now known as kfox1111 | 13:29 | |
| *** dmk0202 has quit IRC | 13:31 | |
| *** ddieterly has joined #openstack-keystone | 13:33 | |
| *** woodster_ has joined #openstack-keystone | 13:37 | |
| *** dave-mccowan has joined #openstack-keystone | 13:39 | |
| *** dmellado_ is now known as dmellado | 13:40 | |
| *** ddieterly is now known as ddieterly[away] | 13:40 | |
| *** rderose has joined #openstack-keystone | 13:40 | |
| *** dave-mcc_ has joined #openstack-keystone | 13:40 | |
| *** spzala has joined #openstack-keystone | 13:40 | |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Add project functional tests https://review.openstack.org/332871 | 13:42 |
| *** dave-mccowan has quit IRC | 13:44 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystonemiddleware: use local config options if available in audit middleware https://review.openstack.org/321882 | 13:47 |
| *** nisha_ has quit IRC | 13:47 | |
| *** ddieterly[away] is now known as ddieterly | 13:47 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystonemiddleware: Move audit into its own folder https://review.openstack.org/333755 | 13:47 |
| *** cleong has joined #openstack-keystone | 13:51 | |
| *** walharthi has joined #openstack-keystone | 13:58 | |
| *** khmcgill has quit IRC | 13:59 | |
| *** ametts has joined #openstack-keystone | 14:00 | |
| *** afred312 has quit IRC | 14:05 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes failure when password is null https://review.openstack.org/333919 | 14:07 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes failure when password is null https://review.openstack.org/333919 | 14:07 |
| *** bjornar_ has quit IRC | 14:12 | |
| stevemar | rderose: do you know why the column was made not nullable in 105? | 14:14 |
| *** julim has joined #openstack-keystone | 14:16 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystonemiddleware: Use createfile fixture in audit test https://review.openstack.org/333775 | 14:17 |
| openstackgerrit | Steve Martinelli proposed openstack/keystonemiddleware: Use createfile fixture in audit test https://review.openstack.org/333775 | 14:18 |
| rderose | stevemar: it wasn't made not nullable in 105, actually in 90 | 14:18 |
| rderose | stevemar: in the sql model changes we're now keeping a history of passwords, which caused the error | 14:20 |
| rderose | stevemar: however, I'm sure we had a test for this, looking into that now | 14:20 |
| *** amoralej|lunch is now known as amoralej | 14:22 | |
| stevemar | rderose: if it happened in 90 that would mean mitaka has the bug too | 14:23 |
| stevemar | but only exposed if using multiple passwords | 14:23 |
| rderose | stevemar: no, because we only set a single password | 14:23 |
| stevemar | rderose: isn't that what i said :) | 14:23 |
| stevemar | rderose: i suppose that is where the "conflict" comes from? we're setting multiple things to null? | 14:24 |
| rderose | stevemar: :) | 14:24 |
| *** tonytan4ever has joined #openstack-keystone | 14:24 | |
| rderose | stevemar: didn't see your 2nd comment | 14:24 |
| rderose | stevemar: in mitaka, I'm checking for null password and not saving if null. Whereas, now with multiple passwords, I removed the check and set the password regardless if null. | 14:26 |
| rderose | stevemar: totally forgot that, that column was not nullable | 14:26 |
| stevemar | mitaka should be fine, even newton-1 is fine | 14:26 |
| rderose | stevemar: yeah | 14:26 |
| *** nisha_ has joined #openstack-keystone | 14:36 | |
| stevemar | rderose: ksc gate is also affected: http://logs.openstack.org/48/333448/2/check/gate-keystoneclient-dsvm-functional/e73b0f4/testr_results.html.gz | 14:37 |
| rderose | stevemar: okay | 14:38 |
| stevemar | rderose: just an fyi | 14:38 |
| rderose | stevemar: thx, dam | 14:39 |
| *** KevinE has joined #openstack-keystone | 14:40 | |
| *** KevinE has quit IRC | 14:41 | |
| *** KevinE has joined #openstack-keystone | 14:41 | |
| rderose | stevemar: btw we do have tests for this, but because nullable wasn't set in the sql model for password, it defaults to nullable | 14:44 |
| rderose | stevemar: https://github.com/openstack/keystone/blob/master/keystone/identity/backends/sql_model.py#L157 | 14:44 |
| *** julim has quit IRC | 14:44 | |
| rderose | stevemar: anyway, setting the password column to nullable will fix this | 14:44 |
| dstanek | wow, test_backend_ldap is crazy | 14:46 |
| *** dave-mcc_ has quit IRC | 14:48 | |
| *** jefrite has joined #openstack-keystone | 14:51 | |
| *** dan_nguyen has joined #openstack-keystone | 14:52 | |
| *** timcline has joined #openstack-keystone | 14:55 | |
| *** raddaoui has joined #openstack-keystone | 14:57 | |
| *** ddieterly is now known as ddieterly[away] | 14:58 | |
| *** dave-mccowan has joined #openstack-keystone | 15:02 | |
| *** josecastroleon has quit IRC | 15:02 | |
| *** lucas____ has joined #openstack-keystone | 15:02 | |
| *** lucas____ has quit IRC | 15:02 | |
| *** kfox1111 is now known as kfox1111_away | 15:07 | |
| edmondsw | dstanek yeah it is | 15:10 |
| dstanek | edmondsw: i'm trying to get some of my old cleanup patches/stashes to apply and i'm not having fun | 15:11 |
| *** tesseract- has quit IRC | 15:12 | |
| *** ebarrera has quit IRC | 15:12 | |
| *** nisha_ has quit IRC | 15:16 | |
| *** tonytan4ever has quit IRC | 15:19 | |
| stevemar | bknudson_: dstanek want to chime in on this: https://review.openstack.org/#/c/333490/1/ -- i'm on the fence for it | 15:22 |
| patchbot | stevemar: patch 333490 - keystone - Do not spam the log with uncritical stacktraces | 15:22 |
| stevemar | i wanted a few other opinions before pushing | 15:22 |
| dstanek | stevemar: looking... | 15:22 |
| stevemar | dstanek: it's more of an opinion than a fix :) | 15:22 |
| dstanek | stevemar: we are logging stacktraces? | 15:22 |
| dstanek | oh, not for just error auths... hmmm | 15:23 |
| *** d0ugal has quit IRC | 15:25 | |
| *** spandhe has joined #openstack-keystone | 15:26 | |
| *** jbell8 has joined #openstack-keystone | 15:27 | |
| *** spandhe_ has joined #openstack-keystone | 15:29 | |
| dstanek | stevemar: generally i'm OK with not doing a traceback, but i'm not sure about all the extra warnings in there | 15:29 |
| dstanek | will a deployer really care that a user specified a project/domain scope and it wasn't found? | 15:30 |
| *** spandhe has quit IRC | 15:30 | |
| *** spandhe_ is now known as spandhe | 15:30 | |
| stevemar | dstanek: probably not | 15:32 |
| *** ddieterly[away] is now known as ddieterly | 15:32 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 15:33 |
| dstanek | stevemar: the logging hints are also wrong too | 15:35 |
| *** pushkaru has joined #openstack-keystone | 15:35 | |
| *** tqtran has joined #openstack-keystone | 15:36 | |
| *** darosale has quit IRC | 15:37 | |
| *** sdake has quit IRC | 15:38 | |
| *** sdake has joined #openstack-keystone | 15:38 | |
| *** sdake has quit IRC | 15:38 | |
| *** sdake has joined #openstack-keystone | 15:38 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** rcernin has quit IRC | 15:39 | |
| *** tqtran has quit IRC | 15:40 | |
| *** roxanaghe has joined #openstack-keystone | 15:41 | |
| *** roxanaghe has quit IRC | 15:42 | |
| stevemar | dstanek: want to look at this chain from jamie: https://review.openstack.org/#/c/333714/ :) | 15:48 |
| patchbot | stevemar: patch 333714 - keystonemiddleware - Use oslo.config fixture in audit tests | 15:48 |
| *** real56 has joined #openstack-keystone | 15:48 | |
| dstanek | stevemar: sure. i'll look in a few. once i start a full test run | 15:49 |
| stevemar | danke | 15:50 |
| *** itisha has quit IRC | 15:50 | |
| *** daemontool_ has joined #openstack-keystone | 15:52 | |
| *** walharthi has quit IRC | 15:54 | |
| *** daemontool has quit IRC | 15:54 | |
| *** walharthi has joined #openstack-keystone | 15:54 | |
| *** ddieterly is now known as ddieterly[away] | 15:55 | |
| *** alex_xu has quit IRC | 15:55 | |
| *** ddieterly[away] is now known as ddieterly | 15:58 | |
| *** alex_xu has joined #openstack-keystone | 15:58 | |
| *** henrynash has joined #openstack-keystone | 16:00 | |
| *** ChanServ sets mode: +v henrynash | 16:00 | |
| henrynash | hi…hello from the Internation Space Station, to where I have now relocated | 16:02 |
| *** spandhe has quit IRC | 16:04 | |
| *** spandhe has joined #openstack-keystone | 16:07 | |
| dstanek | henrynash: you killed by 401k | 16:08 |
| *** kfox1111_away is now known as kfox1111 | 16:09 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 16:11 |
| *** henrynash has quit IRC | 16:12 | |
| *** rderose has quit IRC | 16:13 | |
| *** roxanaghe has joined #openstack-keystone | 16:16 | |
| *** nisha_ has joined #openstack-keystone | 16:17 | |
| *** spandhe has quit IRC | 16:19 | |
| samueldmq | nisha_: I am still not sure what's causing the issue there | 16:20 |
| *** shaleh has joined #openstack-keystone | 16:20 | |
| samueldmq | nisha_: but I left a suggestion there, try it locally and see if it works | 16:21 |
| nisha_ | samueldmq, sure i will try | 16:21 |
| *** TxGVNN has joined #openstack-keystone | 16:21 | |
| *** rderose has joined #openstack-keystone | 16:29 | |
| *** dan_nguyen has quit IRC | 16:32 | |
| *** alex_xu has quit IRC | 16:32 | |
| *** dmk0202 has joined #openstack-keystone | 16:34 | |
| *** alex_xu has joined #openstack-keystone | 16:35 | |
| *** pushkaru has quit IRC | 16:37 | |
| *** ddieterly has quit IRC | 16:44 | |
| *** dan_nguyen has joined #openstack-keystone | 16:45 | |
| *** rderose_ has joined #openstack-keystone | 16:46 | |
| nisha_ | samueldmq, still getting the same error | 16:47 |
| nisha_ | samueldmq, any other test that can verify the same idea? | 16:47 |
| nisha_ | samueldmq, I mean any other approach we can use | 16:48 |
| *** rderose has quit IRC | 16:49 | |
| *** pgbridge has joined #openstack-keystone | 16:52 | |
| samueldmq | nisha_: don't know yet | 16:53 |
| samueldmq | looking again | 16:53 |
| *** BjoernT has joined #openstack-keystone | 16:53 | |
| stevemar | henrynash_: ya dun caused ibm to fall like a sack of bricks: https://www.google.com/finance?q=NYSE%3AIBM&ei=mmVtV8jEC9afjAGZ-ov4CQ | 16:54 |
| samueldmq | nisha_: oh I got it | 16:55 |
| samueldmq | nisha_: for subtree and parents as ids you still need to do that change we discussed | 16:56 |
| nisha_ | samueldmq, getting project type object? | 16:57 |
| samueldmq | nisha_: see my comments inline | 16:57 |
| samueldmq | nisha_: this is a great benefit of these tests .... subtree_as_list and parents_as_list aren't documented at all in the client | 16:58 |
| samueldmq | and their behavior of only returning the proejcts the current user has access to is not obvious/intuitive at all | 16:59 |
| samueldmq | stevemar: ^ | 16:59 |
| samueldmq | :) | 16:59 |
| nisha_ | samueldmq, interesting :D | 17:01 |
| samueldmq | nisha_: does that make sense ? we'll also need to update the docs, because we haven't included that info about those options | 17:02 |
| openstackgerrit | Dolph Mathews proposed openstack/keystone: Replace keystone.common.config with keystone.conf package https://review.openstack.org/325604 | 17:02 |
| dolphm | stevemar: being super massive and touching nearly every file in keystone... think we could merge this over the weekend while the gate is quiet before i have to rebase it? :P ^^ | 17:03 |
| samueldmq | dolphm: wow that's huge | 17:04 |
| nisha_ | samueldmq, but then why does the get call, doesn't have an attribute named user for specifying the current user | 17:04 |
| nisha_ | samueldmq, Is this what I need to update? | 17:04 |
| *** TxGVNN has quit IRC | 17:05 | |
| samueldmq | no | 17:05 |
| samueldmq | nisha_: see my comments to the _as_ids test | 17:05 |
| samueldmq | nisha_: apply it and verify it works | 17:05 |
| samueldmq | nisha_: for the other tests, there is something called role assignment you need to know | 17:05 |
| samueldmq | nisha_: other tests = _as_list test | 17:06 |
| nisha_ | samueldmq, I don't know how to add role assignments for a project | 17:07 |
| *** sdake_ has joined #openstack-keystone | 17:07 | |
| dolphm | samueldmq: stevemar: i'm leaving some review comments to highlight the interesting bits of the change that are worth reviewing. most of the patch was made with sed / awk | 17:07 |
| dstanek | dolphm: is your patch all done now? | 17:07 |
| samueldmq | nisha_: I will tell you how to do it :) | 17:07 |
| dolphm | and lots of vim macros | 17:07 |
| samueldmq | nisha_: have you fixed the _ids test already? | 17:08 |
| dolphm | dstanek: it passes pep8 and py27 on my box | 17:08 |
| samueldmq | dolphm: nice | 17:08 |
| dolphm | hoping it'll pass jenkins by end of day, if we don't approve a merge conflict :P | 17:08 |
| nisha_ | samueldmq, no not yet, one min plz | 17:08 |
| nisha_ | samueldmq, will reconnect to IRC | 17:08 |
| *** nisha_ has quit IRC | 17:09 | |
| dstanek | dolphm: k... if you don't expect many changes i'm going rebase a long chain to test changes on top of it | 17:09 |
| *** nisha_ has joined #openstack-keystone | 17:09 | |
| *** sdake has quit IRC | 17:09 | |
| samueldmq | dolphm: it's just splitting the huge config file, and updating imports right ? | 17:10 |
| nisha_ | samueldmq, done | 17:11 |
| samueldmq | nisha_: cool, so role assignments is what give users permissions on resources | 17:12 |
| nisha_ | samueldmq, hmm | 17:12 |
| samueldmq | nisha_: a role assignment is composed by: a role assigned to an actor (user or group) on a resource (domain or project) | 17:12 |
| samueldmq | nisha_: so you have role + user + project, in that case | 17:13 |
| dolphm | dstanek: stevemar: samueldmq: just posted lots of inline comments posted to help reviewers navigate the diff | 17:14 |
| dolphm | samueldmq: there's a few other small changes noted - mostly moving code and changing the way keystone.conf is initialized (options are registered on import automatically) | 17:14 |
| nisha_ | samueldmq, ++ understood so far | 17:14 |
| * dolphm running to lunch | 17:15 | |
| *** jed56 has quit IRC | 17:15 | |
| *** dmk0202 has quit IRC | 17:15 | |
| *** catintheroof has joined #openstack-keystone | 17:16 | |
| *** dmk0202 has joined #openstack-keystone | 17:16 | |
| samueldmq | dolphm: nice, I saw your comments.. the change looks neat at a glance, I am running tests locally | 17:17 |
| samueldmq | nisha_: cool, so you will basically have to have a role fixture too in that change :) | 17:18 |
| samueldmq | nisha_: I just left another comment there explaining what's necessary | 17:21 |
| *** roxanaghe has quit IRC | 17:24 | |
| *** roxanaghe has joined #openstack-keystone | 17:24 | |
| stevemar | dolphm: i'll look at it soon | 17:24 |
| stevemar | dolphm: i was waiting f or it to passjenkins | 17:24 |
| * notmorgan lurks off in the corner now that stevemar is back. | 17:25 | |
| stevemar | notmorgan: when was i gone :P | 17:26 |
| stevemar | notmorgan: go work on zuul v3, we don't want you here! | 17:26 |
| stevemar | just kidding, we love you | 17:26 |
| notmorgan | stevemar: fine | 17:26 |
| *** notmorgan has left #openstack-keystone | 17:26 | |
| *** notmorgan has joined #openstack-keystone | 17:26 | |
| notmorgan | :P | 17:26 |
| stevemar | notmorgan: we'll page you when we have caching questions lol | 17:27 |
| notmorgan | stevemar: rm -rf keystone/common/cache | 17:27 |
| notmorgan | clearly the right answer | 17:27 |
| stevemar | :) | 17:28 |
| nisha_ | samueldmq, I will try running it | 17:28 |
| *** tqtran has joined #openstack-keystone | 17:30 | |
| *** henrynash has joined #openstack-keystone | 17:30 | |
| *** ChanServ sets mode: +v henrynash | 17:30 | |
| *** GB21 has joined #openstack-keystone | 17:30 | |
| *** nisha__ has joined #openstack-keystone | 17:30 | |
| nisha__ | samueldmq, why do we have to write self.assertItemsEqual([parent_project.id], project_ret.parents) in test_get_hierarchy_as_ids | 17:33 |
| nisha__ | samueldmq, but parent_project.entity in test_get_hierarchy_as_list | 17:33 |
| *** nisha_ has quit IRC | 17:33 | |
| samueldmq | nisha__: ah that's a good quesiton! | 17:34 |
| *** daemontool_ has quit IRC | 17:34 | |
| samueldmq | nisha__: parents_as_list returns a list of the full representation of parent projects, as you were doing a get(parent.id) | 17:35 |
| samueldmq | nisha__: so it requires you to have assignments on those projects (because it may contain not public information in the name/description or extras!) | 17:35 |
| *** dmk0202 has quit IRC | 17:35 | |
| samueldmq | nisha__: on the other hand, parents_as_ids returns only the ids, so that's not an issue | 17:36 |
| *** roxanaghe has quit IRC | 17:38 | |
| *** woodster_ has quit IRC | 17:39 | |
| *** dmk0202 has joined #openstack-keystone | 17:39 | |
| nisha__ | samueldmq, nice, thanks | 17:41 |
| samueldmq | nisha__: are my comments in the review clear ? It shouldn't be too much effort to get that done :) | 17:41 |
| *** roxanaghe has joined #openstack-keystone | 17:42 | |
| nisha__ | samueldmq, yeah, test_get_hierarchy_as_ids is successfully running now | 17:42 |
| samueldmq | nisha__: nice! | 17:42 |
| nisha__ | samueldmq, the other test as_list is throwing an exception | 17:43 |
| nisha__ | namely role not found | 17:43 |
| samueldmq | nisha__: can you paste it ? | 17:43 |
| nisha__ | yeah, one sec | 17:43 |
| samueldmq | nisha__: did you see my comments ? you need to create a role fixture, etc | 17:43 |
| nisha__ | samueldmq, in the client_fixtures.py? | 17:44 |
| samueldmq | nisha__: yes | 17:44 |
| samueldmq | nisha__: role is an entity as any other, you need fixture and instantiate it in the tests, i left a suggestion in the test | 17:44 |
| samueldmq | nisha__: on how to instantiate the role and create the role assignment (grant) | 17:44 |
| nisha__ | samueldmq, I will do that | 17:44 |
| nisha__ | samueldmq, got confused looking at this, role = fixtures.Project(self.client) | 17:45 |
| nisha__ | it should be role = fixtures.Role(self.client) ? | 17:45 |
| samueldmq | nisha__: yes, you just -1'ed my suggestion | 17:45 |
| samueldmq | nisha__: indeed it should be fixtures.Role, sorry | 17:45 |
| nisha__ | samueldmq, np, so, I will work on this, give me 5-10 min | 17:46 |
| samueldmq | nisha__: sure, take your time | 17:46 |
| openstackgerrit | Merged openstack/keystonemiddleware: Use oslo.config fixture in audit tests https://review.openstack.org/333714 | 17:48 |
| *** dan_nguyen has quit IRC | 17:57 | |
| *** henrynash has quit IRC | 17:57 | |
| openstackgerrit | Merged openstack/keystonemiddleware: use local config options if available in audit middleware https://review.openstack.org/321882 | 17:59 |
| *** real56 has quit IRC | 18:01 | |
| *** walharthi has quit IRC | 18:01 | |
| nisha__ | samueldmq, getting a different error | 18:02 |
| stevemar | dstanek: the patch chain isn't done :O | 18:02 |
| nisha__ | samueldmq, will paste the code as well | 18:02 |
| dstanek | stevemar: :-P | 18:02 |
| stevemar | dstanek: oh nice, the one above it is already approved | 18:02 |
| dstanek | i'm looking at 333755 now | 18:03 |
| stevemar | you get a +3, -4 change | 18:03 |
| dstanek | stevemar: yep | 18:03 |
| *** openstackgerrit has quit IRC | 18:03 | |
| *** openstackgerrit has joined #openstack-keystone | 18:03 | |
| dstanek | stevemar: i'm reviewing while i wait for my tests to complete | 18:03 |
| stevemar | dstanek: you run a lot of tests | 18:03 |
| *** rderose has joined #openstack-keystone | 18:03 | |
| dstanek | stevemar: yup | 18:03 |
| dstanek | actually the chain i'm rebasing should cut the execution time down by about 30% | 18:04 |
| nisha__ | samueldmq, please look http://paste.openstack.org/show/522013/ | 18:04 |
| *** sdake_ has quit IRC | 18:04 | |
| *** nisha__ is now known as nisha_ | 18:04 | |
| stevemar | dstanek: rumor has it lebron was a good football player and wanted to play for the browns | 18:04 |
| *** rderose_ has quit IRC | 18:04 | |
| stevemar | dstanek: basically, i'm saying, there exists an alternate universe where the browns just won the superbowl | 18:05 |
| dstanek | stevemar: there was a similar rumor about Jordan and baseball :-) and look how that turned out | 18:05 |
| samueldmq | nisha_: do you know what's wrong there ? | 18:05 |
| samueldmq | nisha_: look at the types it's comparing | 18:05 |
| stevemar | nisha_: samueldmq btw there is a failure in ksc functional tests failure cause of bug 1595819 | 18:06 |
| openstack | bug 1595819 in OpenStack Identity (keystone) "cannot create (or set) a user with no password" [Critical,In progress] https://launchpad.net/bugs/1595819 - Assigned to Ron De Rose (ronald-de-rose) | 18:06 |
| nisha_ | samueldmq, oooh | 18:06 |
| nisha_ | samueldmq, but then how were you creating users using fixtures | 18:07 |
| *** jbell8 has quit IRC | 18:08 | |
| samueldmq | stevemar: thanks, looks like rderose is on it, I will review it ! | 18:08 |
| samueldmq | nisha_: it's about the type that comes in project_ret.parents | 18:08 |
| samueldmq | nisha_: it is a dict representing a project, rather than keystoneclient.v3.projects.Project | 18:09 |
| nisha_ | stevemar, thanks | 18:09 |
| nisha_ | so, (project_ret.id).parents | 18:09 |
| samueldmq | nisha_: no | 18:10 |
| nisha_ | samueldmq, hmm, we already use self.client.projects.get | 18:11 |
| nisha_ | :( | 18:11 |
| samueldmq | nisha_: it's not about the way you get things | 18:11 |
| samueldmq | nisha_: it's just the comparison that is wrong | 18:11 |
| rderose | samueldmq: thanks | 18:11 |
| samueldmq | rderose: we introduced a regression right ? | 18:11 |
| rderose | samueldmq: a regression? | 18:12 |
| samueldmq | rderose: that behavior was right before from what I can see | 18:12 |
| samueldmq | rderose: so we introduced a bug | 18:13 |
| rderose | samueldmq: this patch introduced the bug: https://review.openstack.org/#/c/314284/ | 18:13 |
| patchbot | rderose: patch 314284 - keystone - PCI-DSS Password SQL model changes (MERGED) | 18:13 |
| rderose | samueldmq: specifically, in the sql_model code where we set the password | 18:14 |
| rderose | samueldmq: previously, I was checking if the password value was null and if so, not setting it | 18:14 |
| rderose | samueldmq: in the latest patch, we're supporting multiple passwords for password history validation | 18:15 |
| rderose | samueldmq: in that code, I removed checking if the value was null and instead, create a new password entry regardless if null or not | 18:16 |
| samueldmq | rderose: ah so it was skipping the passwd entry creation | 18:16 |
| rderose | samueldmq: mistakenly forgot the password column was not nullable (and it should be) | 18:16 |
| rderose | samueldmq: correct | 18:16 |
| nisha_ | samueldmq, should i try converting the dict in a project? | 18:17 |
| samueldmq | rderose: commented on that patch | 18:17 |
| nisha_ | to* | 18:17 |
| samueldmq | nisha_: or the opposite :) | 18:17 |
| samueldmq | nisha_: you got it ! | 18:17 |
| nisha_ | samueldmq, oki | 18:17 |
| rderose | samuelmq: we already have a test for this | 18:18 |
| rderose | samueldmq: ^ | 18:18 |
| samueldmq | nisha_: you can do <project>.to_dict() for the <project> that is of the type keystoneclient.v3.projects.Project | 18:18 |
| samueldmq | nisha_: because it inherits from this base class that implements a to_dict mehtod https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/base.py#L532-L533 | 18:19 |
| nisha_ | samueldmq, thank you, that should run the test I guess | 18:19 |
| rderose | samueldmq: it passed because the sql_model did not set the nullable attribute for the password column, so defaulted to nullable | 18:19 |
| samueldmq | rderose: so why didn't it fail ? | 18:19 |
| samueldmq | rderose: do we have a _v3 test for that ? | 18:19 |
| samueldmq | nisha_: so you will be comparing python dicts | 18:19 |
| samueldmq | :) | 18:19 |
| rderose | samueldmq: it's under test_backend_sql | 18:20 |
| rderose | samueldmq: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_sql.py#L229 | 18:21 |
| rderose | samueldmq: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_backend_sql.py#L239 | 18:21 |
| rderose | samueldmq: because the sql_model already allows the password column to be nullable, these tests are correct now | 18:22 |
| samueldmq | rderose: if the tests were passing with the bug, then they're not protecting us from that bug | 18:24 |
| *** GB21 has quit IRC | 18:24 | |
| samueldmq | rderose: we need tests to shield us against that issue coming again | 18:24 |
| rderose | samueldmq: good point | 18:24 |
| ayoung | stevemar, notmorgan, when did we kill the Keystone client CLI? | 18:24 |
| samueldmq | ayoung: this cycle ? https://github.com/openstack/python-keystoneclient/blob/master/releasenotes/notes/remove_cli-d2c4435ba6a09b79.yaml | 18:25 |
| *** ntpttr has joined #openstack-keystone | 18:30 | |
| samueldmq | rderose: I am not getting why those tests were not failing | 18:30 |
| *** seldenr has joined #openstack-keystone | 18:30 | |
| rderose | samueldmq: because in the sql_model, there wasn't a nullable attribute set on the password column, so it defaulted to nullable = true | 18:32 |
| rderose | https://github.com/openstack/keystone/blob/master/keystone/identity/backends/sql_model.py#L157 | 18:32 |
| seldenr | Hi All - I was looking at https://bugs.launchpad.net/keystone/+bug/1244423 and noticed it doesn't seem to be an issue anymore. Does anyone have any objections to closing it? See my comment on launchpad - two other patches added checks for this issue | 18:32 |
| openstack | Launchpad bug 1244423 in OpenStack Identity (keystone) "Inconsistency in the keystone api "enabled" field" [Wishlist,Triaged] | 18:32 |
| rderose | samueldmq: but in the migration (90 I think) it was set to false | 18:32 |
| rderose | samueldmq: adding a test for this now | 18:33 |
| rderose | samueldmq: for the migration | 18:33 |
| samueldmq | rderose: I got it, I mean now | 18:33 |
| samueldmq | rderose: right now, it isn't possible to create/update a user who has no passwd | 18:33 |
| samueldmq | rderose: right ? | 18:34 |
| rderose | samueldmq: right | 18:34 |
| samueldmq | rderose: so why are those tests passing on master? | 18:34 |
| dstanek | dolphm: we need to get your patch through just so that i don't ever have to see it again :-) | 18:34 |
| roxanaghe | dolphm: can you please review this stable/mitaka backport: https://review.openstack.org/#/c/332956/? | 18:35 |
| patchbot | roxanaghe: patch 332956 - keystone (stable/mitaka) - /services?name=<name> API fails when using list_limit | 18:35 |
| samueldmq | roxanaghe: we need a keystone stable core to approve that | 18:36 |
| samueldmq | roxanaghe: perhaps bknudson_ or dolphm | 18:36 |
| *** rfinn has joined #openstack-keystone | 18:36 | |
| roxanaghe | samueldmq: I thougt dolphm enters that category | 18:36 |
| dstanek | you guys seem to be talking right past each other | 18:37 |
| nisha_ | samueldmq, the second list contains an extra {u'project': in the beginning of list | 18:37 |
| rderose | samueldmq: hmm... let me test something out and get back to you | 18:38 |
| samueldmq | rderose: sure, but you got my point right ? | 18:38 |
| samueldmq | nisha_: can you paste it ? | 18:38 |
| samueldmq | nisha_: but the elements in the first list inside a {''project": } too | 18:39 |
| notmorgan | ayoung: uhmmm... 3.0? | 18:39 |
| rderose | samueldmq: yeah, it must be that the model is overriding the nullable setting, but should still fail... | 18:39 |
| nisha_ | samueldmq, http://paste.openstack.org/show/522021/ | 18:39 |
| notmorgan | ayoung: whenever that was released. | 18:39 |
| ayoung | notmorgan, was that Mitaka or after? | 18:39 |
| samueldmq | nisha_: so yes, add {'proejct':....} to the first | 18:39 |
| samueldmq | nisha_: so it will look like : {'project': <my_project>.to_dict()} | 18:40 |
| samueldmq | nisha_: something like that | 18:40 |
| nisha_ | samueldmq, I was trying to do it, give me some hint? | 18:40 |
| samueldmq | nisha_: this ^ | 18:40 |
| notmorgan | uhmmmmmmmmmm........ | 18:40 |
| nisha_ | samueldmq, thanks | 18:40 |
| notmorgan | ayoung: i dunno i have to go look. sec | 18:40 |
| *** openstackstatus has quit IRC | 18:40 | |
| *** openstack has joined #openstack-keystone | 18:41 | |
| samueldmq | ayoung: notmorgan: I think it was removed this cycle (Newton) https://github.com/openstack/python-keystoneclient/blob/master/releasenotes/notes/remove_cli-d2c4435ba6a09b79.yaml | 18:41 |
| notmorgan | ayoung: post mitaka | 18:41 |
| samueldmq | release note says it was deprecated in LIberty | 18:41 |
| notmorgan | ayoung: http://releases.openstack.org/mitaka/index.html | 18:41 |
| *** openstackstatus has joined #openstack-keystone | 18:42 | |
| *** ChanServ sets mode: +v openstackstatus | 18:42 | |
| nisha_ | samueldmq, finally :) | 18:42 |
| nisha_ | samueldmq, uploading the patch again. Thank you so much | 18:43 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes failure when password is null https://review.openstack.org/333919 | 18:45 |
| samueldmq | nisha_: yw, you're doing an excellent job | 18:45 |
| nisha_ | samueldmq, should I add any other comments in the test_projects.py | 18:45 |
| nisha_ | samueldmq, or should I create follow up patch for the projects doc | 18:46 |
| samueldmq | nisha_: create a followup | 18:47 |
| samueldmq | dstanek: did you see my comment in https://review.openstack.org/#/c/325604/8/keystone/assignment/V8_backends/sql.py? | 18:47 |
| patchbot | samueldmq: patch 325604 - keystone - Replace keystone.common.config with keystone.conf ... | 18:47 |
| samueldmq | notice I appended ? at the end :/ | 18:47 |
| samueldmq | appended/added | 18:48 |
| samueldmq | dstanek: is there any convention on doing 'from keystone import config' VS 'import keystone.config' ? | 18:48 |
| dstanek | samueldmq: for this patch here there osm | 18:50 |
| dstanek | isn't any difference | 18:50 |
| dstanek | the main benefit is keystone.conf is clearer than conf in the rest of the code | 18:50 |
| samueldmq | cool, I agree | 18:50 |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Add project functional tests https://review.openstack.org/332871 | 18:52 |
| openstackgerrit | Alexander Makarov proposed openstack/keystone-specs: Complete RBAC in keystone https://review.openstack.org/325326 | 18:52 |
| rderose | samueldmq: it looks like the model is overriding the nullable setting when the tests; again, migration nullable was false, but model nullable is true | 18:57 |
| samueldmq | nisha_: see minor comments inline | 18:57 |
| nisha_ | samueldmq, sure | 18:57 |
| notmorgan | oh wow, alembic is so much easier to work with than SQL-A Migrate | 18:58 |
| rderose | samueldmq: if in the model, I set nullable to False, the tests fail | 18:58 |
| notmorgan | it really should be easy to convert keystone over :P | 18:58 |
| rderose | samueldmq: I added a migration test btw | 18:58 |
| samueldmq | rderose: so your migration broke the behavior ? | 18:59 |
| samueldmq | rderose: but the model was kept right ? | 18:59 |
| samueldmq | rderose: this way old deployments that go through the migration process break, but master don't ? | 18:59 |
| rderose | samueldmq: the password setter broke the behavior because it allowed null values | 18:59 |
| rderose | samueldmq: yeah, if the model is different than the migration, bugs could slip through | 19:01 |
| *** rvba has quit IRC | 19:02 | |
| rderose | samueldmq: and again, if you change the model to match the migration, the tests fail | 19:03 |
| *** sdake has joined #openstack-keystone | 19:03 | |
| samueldmq | rderose: can you point me to where the migration changed the password to be not nullable ? | 19:03 |
| samueldmq | rderose: (the migration that introduced the bug) | 19:03 |
| openstackgerrit | Alexander Makarov proposed openstack/keystone-specs: Complete RBAC in keystone https://review.openstack.org/325326 | 19:04 |
| rderose | samueldmq: migration: https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/090_add_local_user_and_password_tables.py#L41 | 19:05 |
| rderose | samueldmq: model: https://github.com/openstack/keystone/blob/master/keystone/identity/backends/sql_model.py#L157 | 19:05 |
| rderose | samueldmq: you'll notice the model doesn't set nullable, but by default nullable is set to true | 19:06 |
| samueldmq | rderose: in the model, nullable=True is the default right ? | 19:06 |
| rderose | samueldmq: right | 19:06 |
| samueldmq | rderose: because it isn't explicitly set | 19:06 |
| samueldmq | rderose: cool | 19:06 |
| samueldmq | rderose: gotcha | 19:06 |
| *** amakarov is now known as amakarov_away | 19:06 | |
| rderose | samueldmq: yeah, missed on my part | 19:07 |
| samueldmq | rderose: if we had a test to make sure the results of our migrations match with our current model | 19:07 |
| samueldmq | rderose: this kind of bug could be avoided | 19:07 |
| rderose | samueldmq: yeah, we need that | 19:07 |
| openstackgerrit | Merged openstack/keystonemiddleware: Move audit into its own folder https://review.openstack.org/333755 | 19:08 |
| nisha_ | samueldmq, adding this comment, # Only parents and subtree projects that the current user or group has | 19:09 |
| nisha_ | # role assingments on are returned. | 19:09 |
| samueldmq | rderose: could you confirm those things on the patch (I left comments) | 19:10 |
| samueldmq | rderose: so it's clear for others too | 19:10 |
| openstackgerrit | Merged openstack/keystonemiddleware: Use createfile fixture in audit test https://review.openstack.org/333775 | 19:10 |
| rderose | samueldmq: sure | 19:10 |
| samueldmq | nisha_: doesn't need "or group" | 19:10 |
| samueldmq | nisha_: it's just user in that case | 19:10 |
| nisha_ | samueldmq, but we could have done this using a group instead of user too, right? | 19:11 |
| samueldmq | nisha_: yes, but you'd need to add the user to the group first | 19:11 |
| samueldmq | nisha_: and then create the role assignment for the group, instead of the user | 19:12 |
| nisha_ | samueldmq, hmm, right | 19:12 |
| samueldmq | nisha_: but yes, that's correct | 19:12 |
| samueldmq | rderose: could you also expand on the commit message what was creating the issue ? | 19:13 |
| rderose | samueldmq: yes | 19:14 |
| samueldmq | rderose: (the fact the migration had turned that to nullable=False, while in the model it was true, so our tests running on master were passing) | 19:14 |
| samueldmq | rderose: nice, +2 after that, thnaks | 19:14 |
| rderose | samueldmq: perfect | 19:14 |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Add project functional tests https://review.openstack.org/332871 | 19:18 |
| samueldmq | nisha_: one more minor comment | 19:21 |
| samueldmq | nisha_: and should be a +2 :D | 19:21 |
| nisha_ | samueldmq, sure | 19:21 |
| nisha_ | :) | 19:21 |
| *** velopez has joined #openstack-keystone | 19:22 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes failure when password is null https://review.openstack.org/333919 | 19:23 |
| rderose | samueldmq: ^ | 19:23 |
| dstanek | 'git rebase -R' is what you use when you put your crap on somebody else's crap and don't want to push an update of theirs right? | 19:26 |
| *** nisha__ has joined #openstack-keystone | 19:26 | |
| samueldmq | rderose: done, thanks you did a great job addressing this quickly | 19:26 |
| samueldmq | stevemar: I am fine with https://review.openstack.org/#/c/333919/ | 19:27 |
| patchbot | samueldmq: patch 333919 - keystone - Fixes failure when password is null | 19:27 |
| rderose | samueldmq: thanks :) | 19:28 |
| *** nisha_ has quit IRC | 19:28 | |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Add project functional tests https://review.openstack.org/332871 | 19:28 |
| shaleh | dstanek: I do not see -R as an option to rebase in my help | 19:29 |
| samueldmq | nisha__: just in the case you wonder why there is no need to self.addCleanup for the role assignments | 19:29 |
| rderose | samueldmq: perfect description of the bug in launchpad | 19:30 |
| samueldmq | nisha__: they're deleted when the project is deleted :) | 19:30 |
| samueldmq | automatically | 19:30 |
| dstanek | shaleh: crap....i meant git review | 19:30 |
| *** nisha__ has quit IRC | 19:30 | |
| shaleh | dstanek: ah, yes the -R aka no rebase option is what you want | 19:30 |
| *** nisha__ has joined #openstack-keystone | 19:30 | |
| samueldmq | rderose: glad you liked it :) I wanted to make it very clear what was the issue happening | 19:31 |
| dstanek | shaleh: that's what i thought.....i think i was doing something wrong because now it appears to be working | 19:31 |
| shaleh | dstanek: extra annoyance. You have to use it every single time you invoke review | 19:31 |
| *** ametts has quit IRC | 19:31 | |
| openstackgerrit | David Stanek proposed openstack/keystone: Removes outdate comment from a test https://review.openstack.org/334056 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Allow auth plugins to be setup more than once https://review.openstack.org/334057 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Moves auth plugin test setup closer to its use https://review.openstack.org/334058 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Remove unused test code https://review.openstack.org/334059 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Adds a backend test fixture https://review.openstack.org/334060 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Group test_backend_ldap skips for readability https://review.openstack.org/334061 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Reduce domain specific config setup duplication https://review.openstack.org/334062 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Extracted common ldap setup from the filter tests https://review.openstack.org/334063 | 19:31 |
| openstackgerrit | David Stanek proposed openstack/keystone: Removes duplicate ldap test setup https://review.openstack.org/334064 | 19:31 |
| samueldmq | dstanek: wow | 19:32 |
| dstanek | stevemar: round 1 ^ that decreases a full test run by about 22% for me | 19:32 |
| shaleh | dstanek: sweet | 19:32 |
| samueldmq | dstanek: unit tests 22% faster ? | 19:33 |
| dstanek | shaleh: i've got another 20% coming soon | 19:33 |
| dstanek | samueldmq: yes | 19:33 |
| nisha__ | samueldmq, done :) | 19:33 |
| dstanek | some of it is that i'm not runn duplicate tests, but the vast majority is that i reduced the duplicate setup | 19:34 |
| shaleh | dstanek: yeah, setup() is the killer. Good that you kept up with it. | 19:34 |
| dstanek | obviously the % will vary across other developer's environments, but i'm seeing this http://paste.openstack.org/show/522029/ | 19:34 |
| samueldmq | dstanek: taht's great | 19:35 |
| dstanek | ok, off the to the gym for a super late lunch. my arms aren't going to work themselves out | 19:35 |
| *** sdake has quit IRC | 19:36 | |
| *** woodster_ has joined #openstack-keystone | 19:36 | |
| *** sdake has joined #openstack-keystone | 19:36 | |
| *** rfinn has quit IRC | 19:39 | |
| samueldmq | dstanek: bon apetit | 19:43 |
| *** dave-mcc_ has joined #openstack-keystone | 19:43 | |
| *** dave-mccowan has quit IRC | 19:46 | |
| *** nisha__ has quit IRC | 19:47 | |
| *** dave-mccowan has joined #openstack-keystone | 19:48 | |
| *** nisha_ has joined #openstack-keystone | 19:48 | |
| openstackgerrit | Merged openstack/keystoneauth: Don't mock the session.request function https://review.openstack.org/333648 | 19:50 |
| *** dave-mcc_ has quit IRC | 19:50 | |
| *** rfinn has joined #openstack-keystone | 19:50 | |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Follow up patch for Improve docs for v3 projects https://review.openstack.org/334071 | 19:53 |
| nisha_ | samueldmq, ^ please | 19:54 |
| samueldmq | nisha_: on it | 19:55 |
| nisha_ | samueldmq, cool | 19:55 |
| samueldmq | nisha_: see comment | 19:57 |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Follow up patch for Improve docs for v3 projects https://review.openstack.org/334071 | 20:06 |
| nisha_ | samueldmq, ^ | 20:10 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 20:11 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 20:11 |
| samueldmq | nisha_: just a nit (role assignments on) | 20:11 |
| nisha_ | samueldmq, sure | 20:12 |
| samueldmq | nisha_: I can do it for you if you want | 20:12 |
| nisha_ | samueldmq, np | 20:12 |
| openstackgerrit | Dolph Mathews proposed openstack/keystone: Fix nits related to the new keystone.conf package https://review.openstack.org/334080 | 20:12 |
| nisha_ | samueldmq, you looking it is enough for me :) | 20:12 |
| dolphm | samueldmq: dstanek: fixed nits in https://review.openstack.org/#/c/334080/ -- anything holding us back from merging https://review.openstack.org/#/c/325604/ ? | 20:13 |
| patchbot | dolphm: patch 334080 - keystone - Fix nits related to the new keystone.conf package | 20:13 |
| patchbot | dolphm: patch 325604 - keystone - Replace keystone.common.config with keystone.conf ... | 20:13 |
| *** velopez has quit IRC | 20:14 | |
| nisha_ | samueldmq, It only includes the projects in which the current user has role assignments on. | 20:14 |
| samueldmq | dolphm: done | 20:14 |
| samueldmq | nisha_: works for me | 20:14 |
| nisha_ | samueldmq, cool | 20:14 |
| samueldmq | nisha_: yes I agree even minor changes are better to let you do, since you keep practicing | 20:15 |
| samueldmq | nisha_: I normally update myself when there is already a +2 and it's a nit, so we cna quickly fix it and approve | 20:15 |
| *** dave-mcc_ has joined #openstack-keystone | 20:15 | |
| samueldmq | nisha_: but yes, you're on it :) | 20:15 |
| nisha_ | samueldmq, hmm | 20:16 |
| openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Follow up patch for Improve docs for v3 projects https://review.openstack.org/334071 | 20:17 |
| *** dave-mccowan has quit IRC | 20:17 | |
| nisha_ | samueldmq, actually, in most cases, I have observed that, you often point out at things where I have a doubt already. I should ask on IRC first maybe | 20:17 |
| nisha_ | samueldmq, like I was having doubt here too, with 'on' thing, but I thought it won't be required because of 'in' before | 20:18 |
| nisha_ | samueldmq, anyways, hope it looks good now | 20:18 |
| samueldmq | nisha_: well, I don't know, maybe it was better before, let's see what others think about it (that was just my view) | 20:19 |
| nisha_ | samueldmq, np :) | 20:19 |
| nisha_ | samueldmq, so, I guess we are nearly done with projects, right? | 20:19 |
| samueldmq | nisha_: LGTM thanks | 20:19 |
| samueldmq | nisha_: yes | 20:19 |
| samueldmq | nisha_: you're doing an awesome job, congrats | 20:20 |
| samueldmq | nisha_: have a nice weekend | 20:20 |
| nisha_ | samueldmq, so I will start with roles next week? | 20:20 |
| samueldmq | nisha_: sure | 20:20 |
| samueldmq | ! | 20:20 |
| nisha_ | samueldmq, thanks ,wish you and all the the same | 20:20 |
| samueldmq | nisha_: thanks | 20:20 |
| *** dave-mccowan has joined #openstack-keystone | 20:20 | |
| samueldmq | have a good weekend keystone | 20:21 |
| *** samueldmq has quit IRC | 20:21 | |
| nisha_ | the channel keeps busy on weekdays :D | 20:21 |
| *** velopez has joined #openstack-keystone | 20:22 | |
| *** nisha_ has quit IRC | 20:23 | |
| *** dave-mcc_ has quit IRC | 20:23 | |
| *** sdake has quit IRC | 20:26 | |
| *** cleong has quit IRC | 20:31 | |
| *** roxanaghe has quit IRC | 20:39 | |
| *** rvba has joined #openstack-keystone | 20:45 | |
| *** rvba has quit IRC | 20:45 | |
| *** rvba has joined #openstack-keystone | 20:45 | |
| *** dmk0202 has quit IRC | 20:46 | |
| *** shaleh has quit IRC | 20:47 | |
| *** velopez has quit IRC | 20:47 | |
| *** rfinn has quit IRC | 20:53 | |
| dstanek | dolphm: awesome...looking | 20:57 |
| dstanek | pep8: i hate you | 21:00 |
| openstackgerrit | David Stanek proposed openstack/keystone: Extracted common ldap setup from the filter tests https://review.openstack.org/334063 | 21:10 |
| openstackgerrit | David Stanek proposed openstack/keystone: Reduce domain specific config setup duplication https://review.openstack.org/334062 | 21:10 |
| openstackgerrit | David Stanek proposed openstack/keystone: Group test_backend_ldap skips for readability https://review.openstack.org/334061 | 21:10 |
| openstackgerrit | David Stanek proposed openstack/keystone: Adds a backend test fixture https://review.openstack.org/334060 | 21:10 |
| openstackgerrit | David Stanek proposed openstack/keystone: Removes duplicate ldap test setup https://review.openstack.org/334064 | 21:10 |
| *** jbell8 has joined #openstack-keystone | 21:20 | |
| *** Ephur has quit IRC | 21:21 | |
| *** Ephur has joined #openstack-keystone | 21:21 | |
| dstanek | if anyone has the time i'd love to see how the test improvements work in your dev environment | 21:23 |
| *** Ephur has quit IRC | 21:23 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 21:26 |
| stevemar | dolphm: hooooly mackerel | 21:29 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 21:30 |
| *** jbell8 has quit IRC | 21:50 | |
| *** jbell8 has joined #openstack-keystone | 21:51 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Change password requirements https://review.openstack.org/333360 | 21:53 |
| *** roxanaghe has joined #openstack-keystone | 21:56 | |
| *** roxanaghe has quit IRC | 21:56 | |
| *** roxanaghe has joined #openstack-keystone | 21:59 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Password expires validation https://review.openstack.org/333360 | 22:01 |
| dstanek | stevemar: ? | 22:01 |
| *** rderose has quit IRC | 22:08 | |
| *** spzala has quit IRC | 22:13 | |
| *** spzala has joined #openstack-keystone | 22:14 | |
| *** rdo has quit IRC | 22:14 | |
| *** rdo has joined #openstack-keystone | 22:16 | |
| *** BjoernT has quit IRC | 22:17 | |
| *** harlowja has quit IRC | 22:17 | |
| *** spzala has quit IRC | 22:18 | |
| *** catintheroof has quit IRC | 22:18 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: PCI-DSS Password expires validation https://review.openstack.org/333360 | 22:22 |
| stevemar | dstanek: che pasa | 22:29 |
| *** harlowja has joined #openstack-keystone | 22:30 | |
| *** edmondsw has quit IRC | 22:32 | |
| *** timcline has quit IRC | 22:40 | |
| *** spzala has joined #openstack-keystone | 22:44 | |
| openstackgerrit | Sam Leong proposed openstack/keystoneauth: Auth plugin for X.509 tokenless authentication https://review.openstack.org/283905 | 22:47 |
| *** spzala has quit IRC | 22:49 | |
| *** KevinE has quit IRC | 22:53 | |
| *** gordc has quit IRC | 22:55 | |
| *** BjoernT has joined #openstack-keystone | 22:58 | |
| *** rvba has quit IRC | 22:58 | |
| *** spzala has joined #openstack-keystone | 23:00 | |
| *** BjoernT_ has joined #openstack-keystone | 23:00 | |
| *** BjoernT has quit IRC | 23:01 | |
| *** markvoelker has quit IRC | 23:01 | |
| *** markvoelker has joined #openstack-keystone | 23:02 | |
| openstackgerrit | Merged openstack/keystone: Replace keystone.common.config with keystone.conf package https://review.openstack.org/325604 | 23:06 |
| *** itlinux has quit IRC | 23:09 | |
| openstackgerrit | Merged openstack/keystone: Fix nits related to the new keystone.conf package https://review.openstack.org/334080 | 23:12 |
| *** jbell8 has quit IRC | 23:13 | |
| *** jbell8 has joined #openstack-keystone | 23:15 | |
| *** pgbridge has quit IRC | 23:20 | |
| *** BjoernT_ is now known as BjoernT | 23:21 | |
| *** markvoelker has quit IRC | 23:26 | |
| *** seldenr has quit IRC | 23:30 | |
| *** jbell8 has quit IRC | 23:37 | |
| *** jbell8 has joined #openstack-keystone | 23:39 | |
| *** roxanaghe has quit IRC | 23:46 | |
| *** woodster_ has quit IRC | 23:49 | |
| *** adam_g has quit IRC | 23:50 | |
| *** sdake has joined #openstack-keystone | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!