Wednesday, 2016-03-02

*** morgan changes topic to "mitaka-3 done, no more features (you missed your chance) until Newton | Tag bugs as rc-potential - fix more bugs!"00:01
dstanekgyee: it's used to pass into the session right?00:02
gyeedstanek, right, let me look at that code again, I may've missed something00:03
*** spandhe has quit IRC00:03
openstackgerritLance Bragstad proposed openstack/keystone: Refactor TestFernetTokenProvider unscoped token tests  https://review.openstack.org/28690600:04
openstackgerritLance Bragstad proposed openstack/keystone: Refactor TestFernetTokenProvider domain-scoped tests  https://review.openstack.org/28690700:04
openstackgerritLance Bragstad proposed openstack/keystone: Refactor TestFernetTokenProvider project-scoped tests  https://review.openstack.org/28690800:04
openstackgerritLance Bragstad proposed openstack/keystone: Refactor TestFernetTokenProvider trust-scoped tests  https://review.openstack.org/28690900:04
openstackgerritLance Bragstad proposed openstack/keystone: Remove TestFernetTokenProvider  https://review.openstack.org/28691000:04
lbragstadugh - i've wanted to do that ^ for a while00:06
dstanekgyee: my thought is that we wanted to start pushing people toward the newer *Method way of doing things, but maybe we like the shorthand classes00:08
dstanekgyee: http://docs.openstack.org/developer/keystoneauth/authentication-plugins.html#v3-identity-plugins is, i think, the best reference for my current state of mind :-)00:10
*** tellesnobrega is now known as tellesnobrega_af00:12
*** spandhe has joined #openstack-keystone00:14
openstackgerritMerged openstack/keystoneauth: Update test run instructions  https://review.openstack.org/28681300:15
openstackgerritMerged openstack/keystoneauth: Add links to federation plugins  https://review.openstack.org/28682400:15
*** josecastroleon has joined #openstack-keystone00:15
gyeedstanek, right, you can instantiate either TOTPMethod or TOTP00:15
dstanekgyee: having multiple ways to do that same this is not cool00:16
gyeedstanek, why not, TOTPMethod is for multiple methods in a single auth00:16
*** mylu has quit IRC00:17
gyeewhile TOTP includes the entire payload00:17
dstanekgyee: this isnt' perl :-) having one way to do it is much better. you could just use the Method and call it a day00:17
openstackgerritMerged openstack/keystoneauth: Editorial nits for docs  https://review.openstack.org/28681500:18
openstackgerritMerged openstack/keystoneauth: Improve usability of docs  https://review.openstack.org/28681600:18
gyeebut Method does not include {"auth": {"methods": ["totp"]: {" part00:18
openstackgerritMerged openstack/keystoneauth: Fix exported symbol in identity.v3  https://review.openstack.org/28681400:18
gyeedstanek, this is the same pattern as the existing auth plugins00:19
*** mylu has joined #openstack-keystone00:19
dstanekgyee: i'm not disagreeing. i though i read somewhere that we would prefer that people use the new *Methods. so my thought is why add thing to support the old way. maybe that was a one-off opinion that isn't actually true.00:20
dstanekgyee: in any event having multiple ways to do the same thing usually isn't a create experience00:21
gyeedstanek, the only distinction between TOTP and TOTPMethod is that the latter is not the entire auth payload00:22
gyeerather it is used in conjunction with other methods in an auth payload00:22
dstanekgyee: *Methods are used when you automatically create the Auth object (because you can provide a list of methods). the AuthConstructor is a shortcut when you only need one method00:23
gyeeright00:23
dstanekgyee: so there are multiple ways to create a session00:24
gyeedstanek, I do like your suggestion of having a single interface to create the auth payload though00:24
gyeemaybe in the future we have one static method to create the auth payload?00:24
gyeelike, create_auth(auth_url, auth_methods, scope)00:25
dstanekgyee: i like just use the AuthMethod approach from the link00:25
*** mylu has quit IRC00:25
gyeedstanek, nm, v3.Auth does the same thing00:26
gyeedstanek, I am not even sure if stevedore works with TOTPMethod00:31
dstanekgyee: what do you mean?00:32
gyeedstanek, say I remove TOTP and keep just TOTPMethod00:32
*** mylu has joined #openstack-keystone00:32
gyeehow do I  make it construct the entire auth payload00:33
gyeelike 'openstack --os-auth-type totp'00:33
*** ninag has quit IRC00:34
dstanekgyee: no idea00:34
gyeedstanek, I am not even sure if we can specify auth methods with --os-auth-type right now00:34
gyeemultiple auth methods00:34
dstanekgyee: unfortunately that wouldn't surprise me. i'd have to look closer at what os-auth-type is actually doing00:35
openstackgerritMerged openstack/keystoneauth: Generate FederationBaseAuth constructor parameters  https://review.openstack.org/28682600:36
*** mylu has quit IRC00:37
*** mylu has joined #openstack-keystone00:41
*** josecastroleon has quit IRC00:45
*** mylu has quit IRC00:47
*** mylu has joined #openstack-keystone00:47
*** bjornar has quit IRC00:48
openstackgerritSean Perry proposed openstack/keystone: Adding 'domain_id' filter to list_user_projects()  https://review.openstack.org/18256900:48
*** phalmos has quit IRC00:50
openstackgerritguang-yee proposed openstack/keystoneauth: Support TOTP auth plugin  https://review.openstack.org/28108600:54
openstackgerritMerged openstack/keystoneauth: Remove unavailable parameter  https://review.openstack.org/28682500:54
*** fpatwa_ has joined #openstack-keystone01:01
*** sdake has joined #openstack-keystone01:03
*** EinstCrazy has joined #openstack-keystone01:09
*** josecastroleon has joined #openstack-keystone01:10
*** sdake has quit IRC01:16
*** mylu has quit IRC01:19
*** fpatwa_ has quit IRC01:22
*** jasonsb has joined #openstack-keystone01:25
openstackgerritSteve Martinelli proposed openstack/keystone: Fixes the templated backend tests for Python3  https://review.openstack.org/28067301:28
stevemargyee: still around?01:30
gyeestevemar, yes sir01:30
stevemargyee: dstanek has a bunch of py3 patches that should be ready to go: https://review.openstack.org/#/q/topic:bp/python3+status:open except the notification one01:30
openstackgerritfengzhr proposed openstack/keystone: The name can be just white character except project and user  https://review.openstack.org/27235801:30
*** tellesnobrega_af is now known as tellesnobrega01:30
gyeestevemar, looking01:31
*** sdake has joined #openstack-keystone01:31
stevemargyee: i think this is the easiest to start at: https://review.openstack.org/#/c/280673/101:32
patchbotstevemar: patch 280673 - keystone - Fixes the templated backend tests for Python301:32
stevemarerr https://review.openstack.org/#/c/280673/201:32
patchbotstevemar: patch 280673 - keystone - Fixes the templated backend tests for Python301:32
*** sdake has quit IRC01:33
*** rk4n has quit IRC01:34
*** davechen has joined #openstack-keystone01:34
gyeehah, python3, you do b'..' or encode('utf8'), pick your poison01:36
gyeemakes you want to love and hate it at the same time01:37
*** josecastroleon has quit IRC01:42
*** fawadkhaliq has quit IRC01:42
*** rk4n has joined #openstack-keystone01:43
openstackgerritfengzhr proposed openstack/keystone: The name can be just white character except project and user  https://review.openstack.org/27235801:52
*** sheel has joined #openstack-keystone01:56
*** gokrokve has quit IRC02:01
*** woodster_ has quit IRC02:06
*** rk4n has quit IRC02:07
stevemarbknudson: did you want to do something with https://review.openstack.org/#/c/222729/ ?02:08
patchbotstevemar: patch 222729 - keystone (stable/kilo) - Do not revoke all of a user's tokens when a role a...02:08
openstackgerritSteve Martinelli proposed openstack/keystone: Fixes to get cert tests running in Py3  https://review.openstack.org/28067402:11
openstackgerritSteve Martinelli proposed openstack/keystone: Fixes hacking for Py3 tests  https://review.openstack.org/28067502:11
*** dan_nguyen has quit IRC02:11
openstackgerritSteve Martinelli proposed openstack/keystone: Fix keystone.common.wsgi to explicitly use bytes  https://review.openstack.org/28067202:15
*** gokrokve has joined #openstack-keystone02:29
*** josecastroleon has joined #openstack-keystone02:33
*** gokrokve has quit IRC02:34
openstackgerritSteve Martinelli proposed openstack/keystone: add hints to list_services for templated backend  https://review.openstack.org/28614202:43
*** gokrokve has joined #openstack-keystone02:45
*** marg7175 has joined #openstack-keystone02:45
ayoungstevemar, leave that alone...it will be covered by work I am doing02:52
stevemarayoung: ?02:53
ayoungstevemar, https://review.openstack.org/#/c/285134/  is the way to go, but we need to iron out some details...02:53
patchbotayoung: patch 285134 - keystone - Remove unneeded revocation events02:53
stevemarayoung: did you get affected by my sweep of abandoned changes?02:54
ayoungstevemar, almost certainly, but that is ok02:54
ayoungstevemar, I was referring to  patch 222729 - keystone (stable/kilo) - Do not revoke all of a user's tokens when a role a...02:54
patchbotayoung: https://review.openstack.org/#/c/222729/ - keystone (stable/kilo) - Do not revoke all of a user's tokens when a role a...02:54
ayoungit touches so many files, that it keeps getting broken by rebases02:55
stevemarayoung: oh, but that's a kilo change02:55
ayoungstevemar, and are we still doing Kilo changes?02:55
stevemarayoung: it's now in phase 2 of support, only critical/security related fixes02:56
ayoungyeah..doesn't count, I think02:56
stevemarayoung: http://docs.openstack.org/project-team-guide/stable-branches.html02:57
stevemaryeah, i don't think it makes the cut02:57
*** lightshadow has joined #openstack-keystone02:57
ayoungstevemar, I was pushing to get my patch into Mitaka, but it is too big a change, I think03:00
ayoungI'm going to try to instead get it in to the start of Newton03:01
*** josecastroleon has quit IRC03:02
*** lhcheng has quit IRC03:02
openstackgerritSteve Martinelli proposed openstack/keystone: clean up test_resource_uuid  https://review.openstack.org/28154603:05
stevemarayoung: good calll03:08
*** lightshadow has quit IRC03:10
*** gokrokve has quit IRC03:12
*** dims has quit IRC03:15
*** sdake has joined #openstack-keystone03:15
*** gyee has quit IRC03:16
openstackgerritSteve Martinelli proposed openstack/keystone: fix sample config link that 404s  https://review.openstack.org/27771603:19
openstackgerritSteve Martinelli proposed openstack/keystone: fix sample config link that 404s  https://review.openstack.org/27771603:22
stevemarayoung: dstanek, jamielennox, others? :) easy fix at ... https://review.openstack.org/#/c/277716/03:22
patchbotstevemar: patch 277716 - keystone - fix sample config link that 404s03:22
ayoungstevemar, looks good03:23
*** gokrokve has joined #openstack-keystone03:23
stevemarayoung: oh, can you also comment on https://review.openstack.org/#/c/271135/ - i don't know if i should proceed on that one...03:24
patchbotstevemar: patch 271135 - keystone - remove deprecated revoke_by_expiration function03:24
stevemari've abandoned and restored it twice now03:24
ayoungstevemar, I need to get back to the lance patch for Trusts in Fernete.  It has some strnage Py34 error03:24
ayoungstevemar, we can yank it03:24
*** david-lyle has joined #openstack-keystone03:24
ayoungstevemar, my patch probably would not fly for the same reason03:25
ayoungI am yanking all those03:25
stevemarayoung: great, more than happy to abandon it03:25
ayoungall except the user and audit and token revoke evetns03:25
ayoungstevemar, that one can go in03:25
stevemardoh03:25
ayoungstevemar, it is not important03:26
ayoungif anyone is using that, they are crazy03:26
stevemarhehe03:26
ayoungmost of the other revoke-bys will be changed to liveness checks:03:26
stevemari'll rebase it one more time then03:26
ayoungnow damnit, I need to \figure oout the params for virt-install03:27
*** richm has quit IRC03:27
*** gokrokve has quit IRC03:27
*** spandhe has quit IRC03:28
*** Ephur has quit IRC03:33
*** sigmavirus24 is now known as sigmavirus24_awa03:34
*** sdake has quit IRC03:39
*** lhcheng_ has joined #openstack-keystone03:41
*** fawadkhaliq has joined #openstack-keystone03:43
*** gokrokve has joined #openstack-keystone03:51
*** sdake has joined #openstack-keystone03:53
*** gokrokve has quit IRC03:55
*** diazjf has joined #openstack-keystone04:03
*** gokrokve has joined #openstack-keystone04:15
openstackgerritSteve Martinelli proposed openstack/keystone: remove deprecated revoke_by_expiration function  https://review.openstack.org/27113504:15
*** ianw has joined #openstack-keystone04:29
*** lhcheng_ has quit IRC04:29
*** diazjf has quit IRC04:31
*** diazjf has joined #openstack-keystone04:32
*** gokrokve_ has joined #openstack-keystone04:44
*** gokrokve has quit IRC04:47
*** lhcheng has joined #openstack-keystone04:50
*** ChanServ sets mode: +v lhcheng04:50
*** links has joined #openstack-keystone04:51
*** fpatwa_ has joined #openstack-keystone04:53
*** fawadkhaliq has quit IRC04:58
*** GB21 has joined #openstack-keystone05:02
*** Nirupama has joined #openstack-keystone05:06
*** sdake has quit IRC05:09
*** fpatwa_ has quit IRC05:16
*** jorge_munoz has joined #openstack-keystone05:23
*** jorge_munoz has quit IRC05:33
*** pcaruana has joined #openstack-keystone05:36
*** ayoung has quit IRC05:38
*** pcaruana has quit IRC05:49
*** gokrokve has joined #openstack-keystone05:50
*** rcernin has joined #openstack-keystone05:51
*** dave-mccowan has quit IRC05:51
*** gokrokve_ has quit IRC05:53
*** gokrokve_ has joined #openstack-keystone05:53
*** gokrokve has quit IRC05:55
*** gokrokve has joined #openstack-keystone05:56
openstackgerritMerged openstack/keystone: Update developer docs for ubuntu 15.10  https://review.openstack.org/28630705:56
*** gokrokve_ has quit IRC05:57
*** GB21 has quit IRC05:57
*** jaosorior has joined #openstack-keystone06:06
jamielennoxbknudson: so i spent a few hours on swagger client, it can be done but would require a fair bit of work and would probably not end  up looking like the current clients (not necessarily a bad thing)06:13
jamielennoxthe generator is java, plugins are customizable but the generator is still fairly limited so it doesn't really end up that nice06:13
jamielennoxit appears you can override the generator as well as language so maybe that would get us there but more work06:14
jamielennoxmy question would end up how would we want to use swagger on the server? assuming we want to actually tie it in to the server does the code generate a yml file or does the yml file create code/routes?06:15
jamielennoxi would think we have the yml file as the start and in which case we are already parsing swagger and could reuse that library for our client generation, but bigger effort again06:16
jamielennoxanyway, interesting and i have the start of a client generator if you want to see06:16
stevemarjamielennox: using it for the server would be a crazy amount of work06:19
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656506:19
*** spandhe has joined #openstack-keystone06:23
openstackgerritSteve Martinelli proposed openstack/keystone: Fix keystone.common.wsgi to explicitly use bytes  https://review.openstack.org/28067206:31
*** jamielennox is now known as jamielennox|away06:38
*** diazjf has left #openstack-keystone06:48
*** jamielennox|away is now known as jamielennox06:49
*** marg7175 has quit IRC06:51
*** gokrokve has quit IRC06:56
openstackgerritMerged openstack/keystone: Remove unused domain driver method in legacy wrapper  https://review.openstack.org/28669906:59
morganstevemar: poke07:01
morganstevemar: i think we're safe since we're multi-process and each process runs a single request through to the end... but07:02
* stevemar pokes morgan back07:02
morganstevemar: py3 list(dict.[keys|items|values]())07:02
morganis not atomic07:02
stevemarmorgan: oh07:02
morganso conversion to the list() could actually change in threaded pyton07:02
morganpython*07:02
stevemarmorgan: that was the only way i could easily get it to pass on py307:03
morganyou have to do list(dict.copy().items())07:03
morganor use a lock to ensure atomicity07:03
morganhttp://blog.labix.org/2008/06/27/watch-out-for-listdictkeys-in-python-307:03
morganit's all sorts of ick.07:03
morganbut basically bad idea to index the values of an iter()07:03
morganalso it's only in our unit tests07:04
morganbut just as an FYI07:04
stevemarmorgan: yeah, that was going to be my next counter :)07:04
stevemar*meh* tests07:04
morganalso. that test seems insane07:05
*** LZ has joined #openstack-keystone07:05
morgansince dicts are explicitly NOT ordered07:05
morganso it seemslike you could probably avoid casting to a list, this is where **kwargs is just awful07:06
*** e0ne has joined #openstack-keystone07:06
morganyou *could* pass to _build_auth( secret_type, secret_value explicitly07:07
morganand you could eliminate the assertequal(1, len(kwargs))07:07
openstackgerritDivya K Konoor proposed openstack/keystone: (WIP)Race condition in keystone domain config  https://review.openstack.org/28702007:07
*** jamielennox is now known as jamielennox|away07:08
bretono/07:09
morganstevemar: also.. https://twitter.com/SwiftOnSecurity/status/704925447738531840 @swiftonsecurity is brilliant07:09
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656507:09
stevemarmorgan: as a non-us person, i enjoy the politics07:12
morganso... https://review.openstack.org/#/c/277198/07:13
patchbotmorgan: patch 277198 - keystone - Default caching to on for request-local caching.07:13
morganit's awful, but... no good other way... and is *probably* what we want07:14
morganso all deployments automatically get the request local caching.07:15
*** fpatwa_ has joined #openstack-keystone07:16
morganstevemar: also https://github.com/fulldecent/system-bus-radio07:20
*** fpatwa_ has quit IRC07:21
stevemarmorgan: that is super weird07:22
morganstevemar: did you try it? ;)07:23
stevemarmorgan: nope!07:23
stevemarmorgan: nothing to receive it07:23
morgani am disappoint07:23
*** spandhe has quit IRC07:24
*** sbezverk has quit IRC07:29
*** sbezverk has joined #openstack-keystone07:30
*** lhcheng_ has joined #openstack-keystone07:37
*** lhcheng has quit IRC07:37
*** belmoreira has joined #openstack-keystone07:38
*** lhcheng_ has quit IRC07:42
*** sbezverk has quit IRC07:44
*** sbezverk has joined #openstack-keystone07:44
*** sbezverk has quit IRC07:44
*** sbezverk has joined #openstack-keystone07:44
*** markvoelker has quit IRC07:58
*** e0ne has quit IRC07:59
*** pcaruana has joined #openstack-keystone08:02
*** GB21 has joined #openstack-keystone08:06
*** lhcheng has joined #openstack-keystone08:18
*** ChanServ sets mode: +v lhcheng08:18
*** LZ has quit IRC08:21
*** LZ has joined #openstack-keystone08:21
*** GB21 has quit IRC08:21
*** GB21 has joined #openstack-keystone08:23
*** esp has joined #openstack-keystone08:25
*** jamielennox|away is now known as jamielennox08:25
*** lhcheng_ has joined #openstack-keystone08:31
*** esp has quit IRC08:32
*** lhcheng has quit IRC08:35
*** lhcheng_ has quit IRC08:35
*** permalac has joined #openstack-keystone08:42
*** permalac has quit IRC08:42
*** marg7175 has joined #openstack-keystone08:43
davechenstevemar: still around?08:51
*** markvoelker has joined #openstack-keystone08:58
*** permalac has joined #openstack-keystone09:00
*** gokrokve has joined #openstack-keystone09:05
*** daemontool_ has joined #openstack-keystone09:08
*** daemontool_ is now known as daemontool09:08
*** gokrokve has quit IRC09:09
*** daemontool__ has quit IRC09:11
openstackgerritDina Belova proposed openstack/keystone: Integrate OSprofiler in Keystone  https://review.openstack.org/10336809:11
openstackgerritDina Belova proposed openstack/keystone: Integrate OSprofiler in Keystone  https://review.openstack.org/10336809:12
*** jasonsb has quit IRC09:16
*** fpatwa_ has joined #openstack-keystone09:17
*** mhickey has joined #openstack-keystone09:18
*** jistr has joined #openstack-keystone09:19
*** fpatwa_ has quit IRC09:21
*** e0ne has joined #openstack-keystone09:28
*** rk4n has joined #openstack-keystone09:29
*** Nirupama has quit IRC09:34
*** e0ne has quit IRC09:37
*** jasonsb has joined #openstack-keystone09:43
*** GB21 has quit IRC09:47
*** huats_ has quit IRC09:49
*** marg7175 has quit IRC09:50
*** GB21 has joined #openstack-keystone09:50
*** huats_ has joined #openstack-keystone09:50
*** Nirupama has joined #openstack-keystone09:50
*** dancn has quit IRC09:54
*** dancn has joined #openstack-keystone09:55
*** davechen has left #openstack-keystone09:57
*** GB21 has quit IRC09:57
*** rk4n has quit IRC09:57
*** GB21 has joined #openstack-keystone10:00
*** e0ne has joined #openstack-keystone10:00
*** rk4n has joined #openstack-keystone10:02
*** Nirupama has quit IRC10:13
*** mvk has quit IRC10:20
*** lhcheng has joined #openstack-keystone10:23
*** ChanServ sets mode: +v lhcheng10:23
*** Nirupama has joined #openstack-keystone10:27
*** lhcheng has quit IRC10:29
openstackgerritMerged openstack/keystone: V2 operations create default domain on demand  https://review.openstack.org/28477810:32
*** rk4n has quit IRC10:34
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656510:35
*** mvk has joined #openstack-keystone10:35
*** dikonoor has joined #openstack-keystone10:36
*** dikonoor has quit IRC10:40
*** rk4n has joined #openstack-keystone10:48
*** d0ugal has quit IRC10:50
*** nisha_ has joined #openstack-keystone10:50
*** d0ugal has joined #openstack-keystone10:50
*** d0ugal has quit IRC10:50
*** d0ugal has joined #openstack-keystone10:50
*** nisha_ is now known as join10:51
*** dims_ has joined #openstack-keystone10:51
openstackgerritMerged openstack/keystone: remove pyc files before running tests  https://review.openstack.org/28668711:06
*** GB21 has quit IRC11:09
openstackgerritMerged openstack/keystone: Stop using oslotest.BaseTestCase  https://review.openstack.org/28157911:15
*** daemontool_ has joined #openstack-keystone11:15
*** rk4n has quit IRC11:17
*** daemontool has quit IRC11:17
*** fpatwa_ has joined #openstack-keystone11:18
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656511:20
*** henrynash has quit IRC11:21
*** GB21 has joined #openstack-keystone11:21
*** fpatwa_ has quit IRC11:22
*** EinstCrazy has quit IRC11:24
*** henrynash has joined #openstack-keystone11:26
*** ChanServ sets mode: +v henrynash11:26
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656511:27
*** henrynash has quit IRC11:32
*** daemontool_ has quit IRC11:39
*** daemontool_ has joined #openstack-keystone11:39
*** Nirupama has quit IRC11:46
*** rk4n has joined #openstack-keystone11:51
*** dave-mccowan has joined #openstack-keystone11:53
*** doug-fish has joined #openstack-keystone11:56
*** Nirupama has joined #openstack-keystone12:02
*** sdake has joined #openstack-keystone12:03
*** gokrokve has joined #openstack-keystone12:04
*** gokrokve has quit IRC12:09
*** rodrigods has quit IRC12:12
*** rodrigods has joined #openstack-keystone12:12
*** sdake has quit IRC12:13
*** GB21 has quit IRC12:13
*** pauloewerton has joined #openstack-keystone12:17
samueldmqdstanek: hi12:21
samueldmqdstanek: you around?  re: keystone bugs12:21
dstaneksamueldmq: here12:22
samueldmqdstanek: hi12:22
samueldmqdstanek: so, I am looking for keystone low-hanging-fruit bugs12:22
dstaneksamueldmq: just waiting for my coffee to be done :-)12:23
samueldmqdstanek: there is a student willing to apply for next Outreachy round, and she will participate of a bug smash meetup12:23
samueldmqdstanek: oh sure, coffee!12:23
joinhi samueldmq , dstanek12:25
*** join has quit IRC12:25
*** nisha_ has joined #openstack-keystone12:26
dstaneksamueldmq: nice12:26
nisha_hi samueldmq , dstanek :D12:26
nisha_it would be great if you could help me a bit12:27
samueldmqnisha_: hi, welcome12:27
samueldmqdstanek: nisha_ is the outreachy aspirant12:28
samueldmqwe have tried last round of Outrachy, but unfortunatelly we didn't meet one of the criterias12:28
samueldmqnow we will be trying again :)12:28
dstanekhi nisha_12:29
*** kiran-r has joined #openstack-keystone12:29
samueldmqnisha_: another way to help with bug smash is to review bugs; donwload the proposed solution to bugs and test it also helps12:29
dstaneksamueldmq: what is Outreachy?12:29
dstaneknisha_: are you having trouble or just looking to get started?12:30
*** subscope has joined #openstack-keystone12:30
samueldmqdstanek: Outreachy is a program like GSoC12:30
nisha_dstanek, I want to contribute as much as I can to increase my chances of getting selected in the upcoming round.12:30
samueldmqdstanek: but it focuses in a different public, including women12:31
*** raildo-afk is now known as raildo12:31
samueldmqdstanek: https://wiki.gnome.org/Outreachy and https://wiki.openstack.org/wiki/Outreachy12:32
samueldmqone of the ways nisha_ found to get involved is to participate of the bug smash12:33
samueldmqwhich is great12:33
*** subscope has quit IRC12:36
samueldmqdstanek: issue is that it's hard to find low-hanging-fruit bugs in keystone atm!12:37
*** GB21 has joined #openstack-keystone12:37
*** lhcheng has joined #openstack-keystone12:37
*** ChanServ sets mode: +v lhcheng12:37
samueldmqdstanek: we're running out of bugs! :-)12:37
*** jaosorior has quit IRC12:37
*** jaosorior has joined #openstack-keystone12:38
dstaneksamueldmq: yeah, soon we'll be at zero12:38
samueldmqdstanek: ++12:39
dstaneknisha_: there are probably still a good amount of reviews that fix bugs that need some help12:39
samueldmqdstanek: another way I found to nisha_ to contribute is by reviewing patches closing bugs12:39
*** jaosorior has quit IRC12:39
*** jaosorior has joined #openstack-keystone12:40
nisha_dstanek, samueldmq that's pretty good too. I am willing to work.12:41
*** lhcheng has quit IRC12:41
dstaneknisha_: start at an old one like https://review.openstack.org/#/c/210456/ ; make sure the bug hasn't been fixed and is valid. then just figure out what do to12:42
patchbotdstanek: patch 210456 - keystone - IdP deletion triggers token revocation12:42
samueldmqdstanek: http://bit.ly/1nhQdVo is a good list right?12:43
dstaneksamueldmq: sure12:43
*** subscope has joined #openstack-keystone12:43
samueldmqnisha_: look at this link http://bit.ly/1nhQdVo12:43
samueldmqnisha_: you must be logged in the review dashboard12:43
*** GB21 has quit IRC12:44
samueldmqnisha_: you will see patches that propose bug fixes12:44
samueldmqnisha_: use 'git review -d <patch-number>' to download the code12:44
*** subscope has quit IRC12:44
samueldmqnisha_: test the proposed code, this will allow you to learn a lot12:45
samueldmqnisha_: look for missing test cases, look at the diff in the review system12:45
samueldmqnisha_: leave comments and a +1 or -1 in the patch, even if it's just a 'I tested and it works' it's a great help12:45
*** subscope has joined #openstack-keystone12:46
*** edmondsw has joined #openstack-keystone12:46
openstackgerritJacek Tomasiak proposed openstack/python-keystoneclient: Fix invalidation of tokens stored by DefaultCLI plugin  https://review.openstack.org/28623612:46
*** marg7175 has joined #openstack-keystone12:48
*** markvoelker has quit IRC12:48
*** markvoelker has joined #openstack-keystone12:49
nisha_samueldmq, Is that an exhaustive list, which I can review ?12:49
samueldmqnisha_: tehre are others, but they got filtered out, as they had not passed Jenkins (tests) or were marked as work in progress, etc12:50
samueldmqnisha_: that is an exhaustive list of what's for sure worth it to review12:50
nisha_Oh, alright12:51
samueldmqnisha_: or better saying, what is ready to be reviewed :)12:51
nisha_:D12:51
samueldmqnisha_: you may switch to other patch if one is too hard12:52
samueldmqnisha_: and always feel free to come here and ask12:52
nisha_ok, one more thing, can you please elaborate a bit on the testing part?12:53
openstackgerritAlexander Makarov proposed openstack/keystone: Closure table for HMT  https://review.openstack.org/28552112:53
nisha_does that mean "going through the code, dry run " or actually performing tests12:53
samueldmqnisha_: oh sure12:53
samueldmqnisha_: last time we had setup a keystone environment, do you still have it ?12:54
samueldmqnisha_: you could run tests with 'tox -e py27', for example, you remember?12:54
*** fawadkhaliq has joined #openstack-keystone12:54
nisha_yes, I still have it , working12:54
nisha_yeah the tox command12:55
samueldmqgo to your keystone local repo and do 'git pull' to update it12:55
samueldmqnisha_: then you get a change, for example https://review.openstack.org/#/c/286142/12:56
patchbotsamueldmq: patch 286142 - keystone - add hints to list_services for templated backend12:56
samueldmqnisha_: and do 'git review -d 286142' (see that 286142 is the change number in the URL above)12:56
nisha_samueldmq, Sir updated12:57
samueldmqnisha_: it will download the latest patchset of that change12:57
samueldmqnisha_: each time the commiter submit a new version of the proposed solution, that's called a patchset12:57
samueldmqnisha_: you can see at the history (patchset 1, 2, etc)12:57
samueldmqnisha_: once you downlaod the code with git review -d, you can just run the tests and mke sure they work12:58
samueldmqnisha_: look at the proposed solution in the gerrit interface and review the new proposed code too12:58
nisha_ohhh, that's nice, I need to go through all the patchests to learn more right, but suggest changes in the latest one?12:59
*** links has quit IRC12:59
samueldmqnisha_: not necessarily you need to go through all patchsets, but understanding previous discussions and and comments in previous patchsets will help13:02
nisha_samueldmq, Got it :)13:02
samueldmqnisha_: to understand the change and see how things get suggested :)13:03
samueldmqnisha_: don't be afraid of commenting on patches, you may even leave questions if you want13:03
nisha_oh, thanks samueldmq, I will try doing that as well13:04
samueldmqnisha_: np, let me know if you need anything else13:04
samueldmqdstanek: thanks for the help :)13:04
nisha_Sure :)13:07
dstaneksamueldmq: np13:10
dstaneknisha_: those older ones (weeks old) may need you to to some updating of the review and re-push. not just a review of the code13:11
samueldmqdstanek: ++13:13
*** Nirupama has quit IRC13:15
nisha_might sound silly to ask but how will I know if patch needs that?13:16
samueldmqnisha_: if patch is proposing something wrong and you know how to fix; or if it is on merge conflict13:17
samueldmqnisha_: you may simply fix it and submit a new patchset13:17
samueldmqnisha_: for that, git review -d the patches, do the changes, then "git commit -a --amend" and then 'git review' to post it again13:18
*** rk4n_ has joined #openstack-keystone13:19
nisha_samueldmq, so then it will be like solving a bug :)13:20
*** fawadkhaliq has quit IRC13:21
*** rk4n has quit IRC13:22
samueldmqnisha_: yes, if you change the code, you may add your self as co-author13:24
samueldmqnisha_: adding it in the commit message with "Co-Authored-By: name <name@example.com>" in a line alone13:26
dstaneksamueldmq: nisha_: I usually only add myself as a co-author if i didn't something significant. i don't bother for small corrects or to resolve simple merge conflicts13:28
nisha_hmm, thanks got it :)13:28
dstaneksamueldmq: nisha_: but there's no real rule. you have to do what you feel is right13:28
samueldmqdstanek: yes, I agree13:29
*** pleia2 has quit IRC13:33
*** josecastroleon has joined #openstack-keystone13:33
openstackgerritMerged openstack/keystone: Fixes the templated backend tests for Python3  https://review.openstack.org/28067313:35
*** vivekd has joined #openstack-keystone13:37
nisha_haha, okie , thanks dstanek :)13:38
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656513:39
bknudsonjamielennox: it would also be neat to use swagger on the server side, not sure it's worth it.13:44
bknudsonjamielennox: also, I'd be fine if the swagger client wasn't the same as the keystoneclient.13:44
bknudsonstevemar: I don't remember why I restored https://review.openstack.org/#/c/222729/ ... maybe someone asked me to13:46
patchbotbknudson: patch 222729 - keystone (stable/kilo) - Do not revoke all of a user's tokens when a role a...13:46
*** jed56 has joined #openstack-keystone13:46
*** Ephur has joined #openstack-keystone13:47
*** richm has joined #openstack-keystone13:47
*** dikonoor has joined #openstack-keystone13:48
*** rk4n has joined #openstack-keystone13:49
*** dikonoor has quit IRC13:51
*** nisha_ has quit IRC13:52
*** rk4n_ has quit IRC13:53
*** doug-fish has quit IRC13:55
*** daemontool_ is now known as daemontool13:59
*** slberger has joined #openstack-keystone14:00
openstackgerritMerged openstack/keystone: Fixes to get cert tests running in Py3  https://review.openstack.org/28067414:02
openstackgerritMerged openstack/keystone: Fixes hacking for Py3 tests  https://review.openstack.org/28067514:02
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656514:04
*** tjcocozz has quit IRC14:05
*** bapalm has quit IRC14:05
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656514:05
*** bapalm has joined #openstack-keystone14:06
*** EinstCrazy has joined #openstack-keystone14:06
*** dikonoor has joined #openstack-keystone14:08
*** dikonoo has joined #openstack-keystone14:09
*** dikonoo has quit IRC14:09
*** dikonoor has quit IRC14:09
*** dikonoor has joined #openstack-keystone14:10
*** henrynash has joined #openstack-keystone14:10
*** ChanServ sets mode: +v henrynash14:10
*** dikonoo has joined #openstack-keystone14:10
*** dikonoor has quit IRC14:10
*** dikonoo has quit IRC14:10
*** doug-fish has joined #openstack-keystone14:13
*** rodrigods has quit IRC14:14
*** rodrigods has joined #openstack-keystone14:14
*** petertr7_away is now known as petertr714:15
openstackgerritAlexander Makarov proposed openstack/keystone: Closure table for HMT  https://review.openstack.org/28552114:16
*** subscope has quit IRC14:20
*** tjcocozz has joined #openstack-keystone14:20
*** subscope has joined #openstack-keystone14:21
*** subscope has quit IRC14:21
*** subscope has joined #openstack-keystone14:22
*** subscope has quit IRC14:27
*** mylu has joined #openstack-keystone14:35
*** jsavak has joined #openstack-keystone14:36
*** josecastroleon has quit IRC14:36
openstackgerrithenry-nash proposed openstack/keystone: Add release notes for projects acting as domains.  https://review.openstack.org/28723314:37
*** ayoung has joined #openstack-keystone14:39
*** ChanServ sets mode: +v ayoung14:39
*** GB21 has joined #openstack-keystone14:43
*** mylu has quit IRC14:46
*** gokrokve has joined #openstack-keystone14:47
*** subscope has joined #openstack-keystone14:48
*** jsavak has quit IRC14:48
*** knikolla has joined #openstack-keystone14:49
*** alejandrito has joined #openstack-keystone14:49
*** jsavak has joined #openstack-keystone14:50
*** sdake has joined #openstack-keystone14:51
*** gokrokve has quit IRC14:52
*** doug-fish has quit IRC14:52
*** GB21 has quit IRC14:53
*** doug-fish has joined #openstack-keystone14:54
*** josecastroleon has joined #openstack-keystone14:55
*** doug-fish has quit IRC14:56
*** doug-fish has joined #openstack-keystone14:57
*** GB21 has joined #openstack-keystone15:05
*** spandhe has joined #openstack-keystone15:08
*** sigmavirus24_awa is now known as sigmavirus2415:08
rodrigodshenrynash, the API supports the creation of projects acting as domains?15:10
*** jsavak has quit IRC15:10
henrynashrodigods: yes15:10
rodrigodshenrynash, cool15:10
henrynashset is_domain=True15:11
rodrigodshenrynash, reviewed 28723315:11
*** spandhe has quit IRC15:12
henrynashrodigods: thx, will update accordingly15:13
openstackgerrithenry-nash proposed openstack/keystone: Add release notes for projects acting as domains.  https://review.openstack.org/28723315:16
*** jaosorior has quit IRC15:16
*** henrynash has quit IRC15:16
*** mylu has joined #openstack-keystone15:18
*** pushkaru has joined #openstack-keystone15:21
*** GB21 has quit IRC15:22
openstackgerritAlexander Makarov proposed openstack/keystone: Closure table for HMT  https://review.openstack.org/28552115:23
*** josecastroleon has quit IRC15:25
*** jsavak has joined #openstack-keystone15:25
*** woodster_ has joined #openstack-keystone15:27
*** jsavak has quit IRC15:29
*** jsavak has joined #openstack-keystone15:30
*** roxanaghe has joined #openstack-keystone15:30
*** gordc has joined #openstack-keystone15:31
*** jorge_munoz has joined #openstack-keystone15:34
*** gokrokve has joined #openstack-keystone15:42
*** gokrokve has quit IRC15:47
*** belmoreira has quit IRC15:50
*** jistr has quit IRC15:51
*** josecastroleon has joined #openstack-keystone15:51
*** sdake_ has joined #openstack-keystone15:51
*** sdake has quit IRC15:52
*** gokrokve has joined #openstack-keystone15:53
*** gokrokve has quit IRC15:53
*** gokrokve has joined #openstack-keystone15:53
*** sdake has joined #openstack-keystone15:55
*** sdake_ has quit IRC15:58
lbragstadis anyone here able to validate dave-chen's concerns? https://review.openstack.org/#/c/277436/1215:58
patchbotlbragstad: patch 277436 - keystone - Return 404 instead of 401 for tokens w/o roles15:58
lbragstadI pulled down the patch locally and tested it out but I get the intended response (404). I just want to make sure we're not glossing over something Dave is seeing.15:59
*** ninag has joined #openstack-keystone16:00
*** pcaruana has quit IRC16:05
*** fawadkhaliq has joined #openstack-keystone16:06
*** BigWillie has joined #openstack-keystone16:10
*** sdake_ has joined #openstack-keystone16:12
*** daemontool_ has joined #openstack-keystone16:12
*** daemontool has quit IRC16:13
*** ctracey_ has joined #openstack-keystone16:14
*** fawadkhaliq has quit IRC16:14
*** odyssey4me_ has joined #openstack-keystone16:15
*** slberger has quit IRC16:15
*** smurke_ has quit IRC16:15
*** sudorandom has quit IRC16:15
*** ctracey has quit IRC16:15
*** odyssey4me has quit IRC16:15
*** briancurtin has quit IRC16:15
*** johnthetubaguy has quit IRC16:15
*** sdake has quit IRC16:15
*** johnthetubaguy has joined #openstack-keystone16:15
*** slberger has joined #openstack-keystone16:15
*** sudorandom has joined #openstack-keystone16:15
*** smurke has joined #openstack-keystone16:15
*** briancurtin has joined #openstack-keystone16:16
*** ctracey_ is now known as ctracey16:16
*** phalmos has joined #openstack-keystone16:18
openstackgerritClenimar Filemon proposed openstack/keystoneauth: Add is_domain to keystoneauth token  https://review.openstack.org/28237716:19
*** EinstCrazy has quit IRC16:19
*** sdake_ is now known as sdake16:21
*** josecastroleon has quit IRC16:21
openstackgerritBrant Knudson proposed openstack/keystone-specs: WIP - Swagger definition  https://review.openstack.org/28686516:22
morganDinaBelova: just commented on osprofiler, a few things to cleanup as well as your change to not use engine16:23
morganDinaBelova: but you're close.16:23
*** jorge_munoz has quit IRC16:24
*** jorge_munoz has joined #openstack-keystone16:26
*** mylu has quit IRC16:28
*** josecastroleon has joined #openstack-keystone16:28
*** phalmos has quit IRC16:28
*** phalmos has joined #openstack-keystone16:30
*** mylu has joined #openstack-keystone16:32
*** mylu has quit IRC16:33
*** odyssey4me_ is now known as odyssey4me16:33
*** jsavak has quit IRC16:33
DinaBelovamorgan thanks!16:34
*** sdake has quit IRC16:35
*** david-lyle has quit IRC16:36
*** david-lyle has joined #openstack-keystone16:38
*** sdake has joined #openstack-keystone16:40
*** nisha_ has joined #openstack-keystone16:43
*** mylu has joined #openstack-keystone16:44
*** subscope has quit IRC16:44
*** BigWillie has quit IRC16:45
*** mylu has quit IRC16:45
*** jsavak has joined #openstack-keystone16:45
*** henrynash has joined #openstack-keystone16:50
*** ChanServ sets mode: +v henrynash16:50
*** belmoreira has joined #openstack-keystone16:53
*** nisha_ has quit IRC16:55
*** josecastroleon has quit IRC16:58
openstackgerritSteve Martinelli proposed openstack/keystone: Minor edits to the developing doc  https://review.openstack.org/28512017:00
openstackgerritSteve Martinelli proposed openstack/keystone: Minor edits to the developing doc  https://review.openstack.org/28512017:01
*** gema has quit IRC17:01
*** gema has joined #openstack-keystone17:02
*** subscope has joined #openstack-keystone17:02
openstackgerritMerged openstack/keystone: Fix keystone.common.wsgi to explicitly use bytes  https://review.openstack.org/28067217:02
*** gyee has joined #openstack-keystone17:03
*** ChanServ sets mode: +v gyee17:03
*** anush has joined #openstack-keystone17:06
morganstevemar: closed a chunk more bugs for you.17:07
openstackgerritMerged openstack/keystone: Simplify use of secure_proxy_ssl_header  https://review.openstack.org/28328817:08
*** dan_nguyen has joined #openstack-keystone17:08
ayoungstevemar, morgan I want to deprecate as much of the revocation event stuff as possible now17:09
ayoungI just realized that we need to deprecate before I can yank out:17:09
ayoungrevoke by project, by domain, roles assign etc17:10
ayoungwe don't need them17:10
ayounglong term17:10
ayoungis that something that has to be done by Friday if it is going in to Mitaka?17:10
morganayoung: m3 is already proposed/cut, this is all RC stuff now17:11
morganayoung: so friday isn't the target17:11
ayoungmorgan, ah17:11
*** e0ne has quit IRC17:11
ayoungmorgan, so quiestion still stands17:11
morganayoung: if it's RC ok, it has a bit more rnuway17:11
ayoungdeprecations only in RC OK?17:11
morganif it isn't RC ok, then newton17:11
morganstevemar: ^17:12
ayoungno change of function, just contract17:12
morgani don't think a deprecation is an issue, but i defer to steve17:12
morganstupid stemless wine glass shattered in my hand last night :(17:12
*** rk4n_ has joined #openstack-keystone17:13
*** sdake has quit IRC17:13
morganglad it was crystal and not regular glass, the glass would have been *everywhere*17:14
stevemarmorgan: <3 for your bug triaging17:14
*** mylu has joined #openstack-keystone17:14
ayoungstevemar, can I deprecate more functions in Mitaka still?17:16
*** rk4n has quit IRC17:16
*** sdake has joined #openstack-keystone17:17
*** pleia2 has joined #openstack-keystone17:18
lupinea-ha, pip v6 is no good17:19
*** mylu has quit IRC17:19
openstackgerritJorge Munoz proposed openstack/keystone: Fix trust chain tests  https://review.openstack.org/27816317:19
ayoungmorgan, did something happen to gerrit?17:20
morganayoung: hm?17:20
ayoungmorgan, I can't fetch or post a review17:20
morganayoung: working for me.17:20
morganayoung: i did have to re-clone my repo for some reason17:21
morgangit.openstack.org hung for a short bit17:21
*** fawadkhaliq has joined #openstack-keystone17:21
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656517:21
*** marg7175_ has joined #openstack-keystone17:22
*** subscope has quit IRC17:22
ayounggit clone ssh://ayoung@review.openstack.org:29418/openstack/keystone17:24
ayoungCloning into 'keystone'...17:24
ayoungssh_exchange_identification: Connection closed by remote host17:24
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656517:25
ayoungjorge_munoz, so I assume you saw the latest https://review.openstack.org/#/c/285134/17:25
patchbotayoung: patch 285134 - keystone - Remove unneeded revocation events17:25
*** marg7175 has quit IRC17:25
ayoungThat was working before rebase...but there is still something wonky with the logic in the tests.17:25
*** jorge_munoz has quit IRC17:25
ayoungand it is very fragile17:26
*** petertr7 is now known as petertr7_away17:26
*** kiran-r has quit IRC17:28
*** jasonsb has quit IRC17:30
*** rk4n_ has quit IRC17:30
*** jasonsb has joined #openstack-keystone17:32
openstackgerritMorgan Fainberg proposed openstack/keystone: IPV6 test unblacklist  https://review.openstack.org/28733917:35
*** boris-42 has joined #openstack-keystone17:36
*** jasonsb has quit IRC17:36
*** itlinux has joined #openstack-keystone17:36
*** vivekd has quit IRC17:37
*** jbell8 has joined #openstack-keystone17:39
*** browne has joined #openstack-keystone17:43
*** bjornar has joined #openstack-keystone17:43
*** sdake has quit IRC17:43
*** tellesnobrega is now known as tellesnobrega_af17:49
*** tellesnobrega_af is now known as tellesnobrega17:50
*** browne has quit IRC17:53
*** gokrokve has quit IRC17:58
*** browne has joined #openstack-keystone17:59
*** henrynash has quit IRC18:00
*** josecastroleon has joined #openstack-keystone18:00
*** josecastroleon has quit IRC18:00
*** jsavak has quit IRC18:02
*** jsavak has joined #openstack-keystone18:03
*** belmoreira has quit IRC18:03
*** e0ne has joined #openstack-keystone18:04
*** jsavak has quit IRC18:04
*** jsavak has joined #openstack-keystone18:04
*** phalmos has quit IRC18:07
stevemarayoung: morgan i'm assuming deprecating things is still cool to do in mitaka18:07
morganstevemar: your call!18:08
stevemarmorgan: ayoung that was meant to be more of a "yeah, it's cool"18:08
*** roxanaghe has quit IRC18:09
openstackgerritSteve Martinelli proposed openstack/keystone: IPV6 test unblacklist  https://review.openstack.org/28733918:10
stevemarmorgan: that was confusing me so much ^18:10
stevemarmorgan: i rebased it18:10
*** spzala has joined #openstack-keystone18:11
*** lhcheng has joined #openstack-keystone18:12
*** ChanServ sets mode: +v lhcheng18:12
*** david-lyle has quit IRC18:12
*** sigmavirus24 is now known as sigmavirus24_awa18:12
stevemarmorgan: dstanek we'll be down to 10 tests that aren't py3 friendly :)18:12
morganstevemar: hehe18:12
*** david-lyle has joined #openstack-keystone18:13
*** jbell8 has quit IRC18:16
*** petertr7_away is now known as petertr718:18
*** pgbridge has joined #openstack-keystone18:19
ayoungI can't talk to gerrit via ssh18:20
*** spandhe has joined #openstack-keystone18:22
morganayoung: something wonky is up: fatal: unable to access 'https://git.openstack.org/openstack/keystone/': GnuTLS recv error (-54): Error in the pull function.18:22
ayoungmorgan, just tried  ssh -vvvv ayoung@review.openstack.org:2941818:23
dstanekstevemar: i have most of them done already. once the current set of patches is all merged i'll push the rest.18:24
ayoungcould it be a ....what is this weeeks heartbleed called?18:24
lupinedrown18:24
*** jbell8 has joined #openstack-keystone18:24
ayounglupine, thanks18:24
lupineslash cachebleed18:24
ayoungcould it be drown patching going on?18:24
stevemarmorgan: want to punt this one through?18:24
morganayoung: ssh mdrnstm@review.openstack.org -p 2941818:25
morganstevemar: -p 29418, does : work?18:25
morganstevemar: not you ayoung18:25
morganayoung: :29418 doesn't work for me fyi18:25
morganstevemar: which one?18:25
*** jsavak has quit IRC18:25
*** mylu has joined #openstack-keystone18:25
stevemarmorgan: https://review.openstack.org/#/c/285120/ ?18:25
patchbotstevemar: patch 285120 - keystone - Minor edits to the developing doc18:25
stevemarmorgan: thought i copied it, doh18:26
stevemarmorgan: it'll close another bug \o/18:26
morganstevemar: hah18:26
stevemardstanek: down to 130 bugs in keystone :)18:26
*** mhickey has quit IRC18:27
morganstevemar: i looked at moving use from eventlet to wsgiref and multiprocessing in our unit tests... ugh it's more work than i am willing to do today18:27
morganstevemar: it really is just retrofitting the AppServer fixture for multiprocessing and wsgiref then moving to use it instead of what we currently do.18:27
morganstevemar: but... i am not that motivated.18:28
*** subscope has joined #openstack-keystone18:28
morganstevemar: but with about ~120 lines of code we could break our dependency on eventlet in our unit tests18:28
*** e0ne has quit IRC18:29
*** e0ne has joined #openstack-keystone18:30
*** doug-fish has quit IRC18:30
*** jsavak has joined #openstack-keystone18:30
*** doug-fish has joined #openstack-keystone18:31
*** e0ne has quit IRC18:31
*** e0ne has joined #openstack-keystone18:32
dstanekmorgan: i have something like that already. i'll have to see if it still applies18:32
morgandstanek: yeah i thought you did, but didn't see it in gerrit18:33
*** prosun has joined #openstack-keystone18:33
morgandstanek: but it would be nice to be on wsgiref for our tests even with the current model of standup/teardown per test18:33
*** petertr7 is now known as petertr7_away18:33
morgandstanek: we can work on minimizing that ick once we don't rely on eventlet for our unit tests18:33
morgandstanek: because it means that when we drop eventlet support we can rm -rf the whole eventlet environment thing and not even keep it as test-requires :)18:34
*** doug-fis_ has joined #openstack-keystone18:34
*** mylu has quit IRC18:35
*** doug-fish has quit IRC18:35
*** mylu has joined #openstack-keystone18:35
morgandstanek: https://review.openstack.org/#/c/266914/ can likely be abandoned, it is only testing the .set_defaults works18:38
patchbotmorgan: patch 266914 - keystone - Use an in memory database for tests18:38
dstanekmorgan: i'll polish that off and let you know if it works18:38
morgandstanek: we already use *only* in-memory db for testing except when we mock out set_defaults to test that oslo_db.set_defaults works18:38
*** doug-fis_ has quit IRC18:39
dstanekmorgan: not true. at least not when i wrote that. i constantly get a keystone.db after running the tests18:39
morganthen something is calling, erroneously the reflection bits18:39
morganif it isn't using in-memory db someone broke something because we were18:40
morganoh except on the migration tests i think18:40
morgani *think* those had to be stable-storage18:40
morganwe should probably not globally set sqlite as the "default"18:41
morganmake it so a deployer *must* configure a sql-connection string18:41
*** sdake has joined #openstack-keystone18:41
*** alejandrito has quit IRC18:43
dstanekmorgan: i can fix it to go more that route18:43
dstanekmorgan: i'm not sure why we set the default there anyway18:43
morgandstanek: that would be better. then we can error/know if a test is using stable storage.18:43
morgandstanek: historical18:43
*** petertr7_away is now known as petertr718:43
morgandstanek: but if someone wants to use sqlite for their kyesotne, i vote we make them set the connection string :P18:44
morgan"here you go, shoot yourself in the foot, but you loaded the gun and aimed it"18:44
dstanekCONF.i_really_dont_care_about_my_data = True18:44
morgandstanek: also is sqlite://:memory correct or IN_MEM_DB_CONN_STRING = 'sqlite://' correct?18:45
morgancause we use sqlite:// for our tests in most cases18:45
*** henrynash has joined #openstack-keystone18:45
*** ChanServ sets mode: +v henrynash18:45
morgandstanek: so we do use stable storage keystone.db (in a custom tmpdir) for migration tests, and i don't remember why. you shouldn't endup with a keystone.db file ever afaict18:47
dstanekmorgan: i thought that sqlite:// would break18:47
morgandstanek: SQL-A might do magic with it. but we use that extensively18:47
morgandstanek: look at ksfixtures.database line 5118:48
morgandstanek:     db_options.set_defaults(18:48
morgan        CONF,18:48
*** subscope has quit IRC18:48
morgan        connection=unit.IN_MEM_DB_CONN_STRING)18:48
morganso if it is breaking, it's breaking in a way we can't see ;)18:48
*** subscope has joined #openstack-keystone18:48
*** subscope has quit IRC18:49
*** anush has quit IRC18:49
dstanekmorgan: yay! it's possible that we are doing db work without that fixture18:50
morgandstanek: which i expect in the migration tests atm.18:50
morgandstanek: but those files are using tmpdir/tmpfile fixtures and should be cleaned up18:51
morgandstanek: so - yeah lets break things that don't set the connection string ;)18:51
*** subscope has joined #openstack-keystone18:56
*** ninag has quit IRC18:56
*** ninag has joined #openstack-keystone18:57
openstackgerritBrant Knudson proposed openstack/keystone-specs: WIP - Swagger definition  https://review.openstack.org/28686518:58
bknudsonI wrote a little application that uses the generated python client from the swagger ^18:59
bknudsonthe generator could use some work, but it's ok I guess18:59
*** jsavak has quit IRC19:04
*** ninag has quit IRC19:04
*** ninag has joined #openstack-keystone19:05
*** jsavak has joined #openstack-keystone19:06
*** anush has joined #openstack-keystone19:09
*** daemontool_ has quit IRC19:10
*** doug-fish has joined #openstack-keystone19:12
*** ninag has quit IRC19:13
*** ninag has joined #openstack-keystone19:13
*** rk4n has joined #openstack-keystone19:15
*** ninag has quit IRC19:17
*** rcarrillocruz has joined #openstack-keystone19:20
*** rk4n has quit IRC19:21
*** sigmavirus24_awa is now known as sigmavirus2419:22
*** jed56 has quit IRC19:23
rcarrillocruzhi folks19:26
*** jorge_munoz has joined #openstack-keystone19:26
rcarrillocruzis it possible with the keystone api to do authed user capabilities introspection ?19:26
rcarrillocruzlike returning the resources from policy.json the user is granted to19:27
rcarrillocruze.g. identity:list_domains19:27
rcarrillocruzand all the user can get19:27
jorge_munozayoung: Reviewing it now. One question, how are we going to validate a fernet is not valid after a revoke by id?19:27
rcarrillocruzanyone knows? wandering the docs but not finding anything like that, maybe not using good keywords19:27
ayoungjorge_munoz, I think you are confusing two of the ids19:29
ayoungaccess_token_id is for Oauth19:30
ayoungtoken_id is still supported19:30
ayoungas is revoke by audit id19:30
ayoungjorge_munoz, but the oauth stuff can all be checked against the database, so we don't need explicit revokes for it19:30
ayoungrcarrillocruz, you are not the first person to ask that19:31
*** anush has quit IRC19:31
ayoungrcarrillocruz, so...practically speaking, no.19:31
*** mvk has quit IRC19:31
rcarrillocruz(sadpanda)19:32
ayoungrcarrillocruz, the problem is that, while we have an API for distributing policy, none of the other services use it, and they don't provide a way to query it either19:32
ayoungrcarrillocruz, its why I was pushing for Dynamic policy, which we are going to restart in Austin, but in a more feasable manner19:32
rcarrillocruzright, i was checking the policy stuff and that seems to be for adding new policy from a file19:32
rcarrillocruzbut doesn't seem to be for the runtime policy in place19:32
rcarrillocruzalright,19:32
ayoungrcarrillocruz, https://review.openstack.org/#/c/279379/19:33
patchbotayoung: patch 279379 - keystone-specs - Dynamic RBAC Policy19:33
rcarrillocruzthanks for the answer ayoung19:33
ayoungrcarrillocruz, so, there is nothing that says that you cannot upload the policy files from nova to Keystone, but you still need some way to correlate them19:33
ayoungideally, we would have a unified set of policy rules so it really would not matter.  The way the rules are written, you should be able to have a single policy file with all of them in there19:34
rcarrillocruznod19:34
ayoungif, OTOH, you just uploaded them, you could just iterate through each file and fine the rule you are after , then execute the policy check against it19:34
ayoungI had proposed a tool...let me see19:34
*** doug-fis_ has joined #openstack-keystone19:35
ayoungrcarrillocruz, https://review.openstack.org/#/c/170978/19:35
patchbotayoung: patch 170978 - oslo.policy - Add oslopolicy-checker command-line tool (MERGED)19:36
ayoungit merged!19:36
*** doug-fish has quit IRC19:36
rcarrillocruzhmm19:36
rcarrillocruzlet me see...19:36
*** mylu has quit IRC19:36
*** mylu has joined #openstack-keystone19:36
*** anush has joined #openstack-keystone19:41
*** phalmos has joined #openstack-keystone19:43
*** fangxu has joined #openstack-keystone19:45
*** doug-fish has joined #openstack-keystone19:46
*** phalmos has quit IRC19:47
*** doug-fis_ has quit IRC19:47
*** belmoreira has joined #openstack-keystone19:50
*** belmoreira has quit IRC19:51
openstackgerritSean Perry proposed openstack/keystonemiddleware: use the same context across a request  https://review.openstack.org/21688919:52
*** shaleh has joined #openstack-keystone19:53
*** ninag has joined #openstack-keystone19:54
openstackgerritSam Leong proposed openstack/keystoneauth: Auth plugin for X.509 tokenless authz  https://review.openstack.org/28390519:54
*** ninag has quit IRC19:55
*** ninag has joined #openstack-keystone19:55
*** pushkaru has quit IRC19:58
jorge_munozayoung: Yes, I just tested it, you were right. I left some minor comments on your inital patch. Its looking good.19:58
*** sdake_ has joined #openstack-keystone19:59
ayoungjorge_munoz, so, I don't think we can merge that whole patch anytime soon19:59
*** rk4n has joined #openstack-keystone19:59
ayoungjorge_munoz, I'm trying to submit a patch that deprecates the functions removed in that patch19:59
ayoungjorge_munoz, but I can't get to gerrit.  Can you?19:59
*** sdake has quit IRC20:00
*** tqtran has joined #openstack-keystone20:00
jorge_munozayoung: Yea, we also need to get some performance numbers to ensure it will actually improve performance.20:01
jorge_munozayoung: checking20:01
jorge_munozayoung: Yes, I can reach gerrit.20:01
ayoungjorge_munoz, so long as it does not hurt performance, I want to move this way.  A perf gain is hoped for, but it is swapping the tree operations for the backend lookup operations, which will really be multiple cached hits.20:02
ayoungjorge_munoz, can you submit a patch to deprecate those functions, so we can at least get it up for review20:02
ayoungI can past what I have20:02
*** sdake has joined #openstack-keystone20:03
ayoungjorge_munoz, http://paste.fedoraproject.org/332410/14569489/  just those, I think20:03
jorge_munozayoung: sure20:03
ayoungjorge_munoz, TYVM20:03
shalehdo we have a mechanism to mark reviews for "should be abandoned"?20:06
*** sdake_ has quit IRC20:06
openstackgerritJorge Munoz proposed openstack/keystone: Deprecated revocation functions  https://review.openstack.org/28741320:10
jorge_munozayoung: ^20:11
ayoungjorge_munoz, thanks.  See any others that should be removed?20:11
jorge_munozayoung: Are there any revocation events for disabling users?20:14
ayoungjorge_munoz, I think we need to leave that anyway20:14
ayoungif a user changes their password, we add a revocation event.20:14
ayoungAlthough I guess we could deprecated it and make it internal only, I think that is one we want to leave20:15
*** jsavak has quit IRC20:16
*** doug-fis_ has joined #openstack-keystone20:17
jorge_munozayoung: Ok cool, so removing revocation events for grants, project, domains, and role assignments should be good.20:17
ayoungjorge_munoz, that was my logic, yes20:18
*** doug-fish has quit IRC20:18
ayoungjorge_munoz, I need to find out if that requires a release note.  morgan stevemar, does a deprecation need a release note?20:18
*** jsavak has joined #openstack-keystone20:20
*** mylu has quit IRC20:22
*** mylu has joined #openstack-keystone20:23
*** mylu has quit IRC20:25
*** mylu has joined #openstack-keystone20:27
*** jbell8 has quit IRC20:27
*** fangxu has quit IRC20:28
bknudsonwrite up a release note and we'll clean them up at the end20:29
*** permalac has quit IRC20:30
*** doug-fish has joined #openstack-keystone20:31
*** jsavak has quit IRC20:32
*** ninag has quit IRC20:32
*** ninag has joined #openstack-keystone20:32
*** jsavak has joined #openstack-keystone20:33
*** doug-fis_ has quit IRC20:33
morganayoung: easier to add one now20:35
stevemarayoung: you betcha20:35
ayoungmorgan, bknudson except I can't make changes to things on Gerrit right now, but jorge_munoz can....20:36
ayoungjorge_munoz, I'll send you copy20:36
*** rcernin has quit IRC20:36
bknudsonyou can't get to the gui?20:36
morganayoung: try: ssh -p <port> ayoung@review.openstack.org the ':<port>' notation does not work for ssh20:37
ayoungbknudson, I can get to the GUI, just not the CLI20:38
ayoungmorgan, same failure20:38
bknudsonthere's an edit button on the gui20:38
morganayoung: what is the failure?20:38
ayoungmorgan, well, actually, hmmm20:38
ayoungwhat should I see if I do that?20:38
morganyou should see .. sec20:38
morganhttp://paste.openstack.org/show/489047/20:39
morgansomething like that20:39
openstackgerritJacek Tomasiak proposed openstack/python-keystoneclient: Fix invalidation of tokens stored by DefaultCLI plugin  https://review.openstack.org/28623620:42
*** david-lyle has quit IRC20:45
*** david-lyle has joined #openstack-keystone20:47
*** roxanaghe has joined #openstack-keystone20:49
*** gyee has quit IRC20:52
*** henrynash has quit IRC20:54
*** henrynash has joined #openstack-keystone20:55
*** ChanServ sets mode: +v henrynash20:55
morganstevemar: ^ i -2 and "wont fixed" that bug - ksc is dead CLI/Session wise20:55
morganstevemar: i asked for it to be re-opened against keystoneauth and/or openstackclient if needed20:55
*** rcarrillocruz has left #openstack-keystone20:56
jamielennoxmorgan: that plugin is designed to be used by others as well20:57
jamielennoxmorgan: it was originally designed for OSC20:57
morganjamielennox: it shouldn't be in KSC though20:57
morganjamielennox: if it needs to be fixed we need it fixed in KSA20:57
morgan;)20:58
morganjamielennox: thats all i'm -2/wont fixing the ksc version20:58
jamielennoxits an interesting case to support, not sure yet, it seems easy20:58
morgansince it should just disappear when we rip out the rest of session/cli stuff in ksc20:58
morganwe should totally fix it if it is in KSA20:58
morganand/or if openstackclient is affected (which uses KSA)20:58
*** mhickey has joined #openstack-keystone20:59
jamielennoxopenstackclient doesn't use ksa unless i missed something21:00
*** anush has quit IRC21:00
jamielennoxsomeone was working on it21:00
morganjamielennox: iirc it uses KSA now21:00
*** mylu has quit IRC21:01
morganjamielennox: openstackclient/common/session.py:from keystoneauth1 import session21:01
*** mylu has joined #openstack-keystone21:01
*** browne has quit IRC21:02
morganjamielennox: it looks like it uses a mix of things, but it's def. moved mostly to KSA21:02
*** raildo is now known as raildo-afk21:02
morganayoung: i'll be in boston from like 9am until... uhmm...21:03
morganayoung: my flight leaves at 1710 so whatever that means to get to the airport.21:03
morganayoung: on the 7th21:03
ayoungmorgan, is that monday?21:03
morganayoung: yeah21:03
ayoungmorgan, cool.  I'm not that far outside the city.  You have the day free-ish?21:04
morganyeah.21:05
morganas long as i get back to the airport21:05
morgan;)21:05
ayoungmorgan, wanna come work at my cowork space:  http://brooklynboulders.com/somerville/21:05
morgani can toss my rock shoes into my bag21:06
morgani'm way out of shape though21:06
ayoungSo am I21:06
morganlike... man. =/21:06
morganI'll toss my rock shoes into the bag, that sounds like a fun thing to do while in boston21:06
*** anush has joined #openstack-keystone21:07
*** doug-fish has quit IRC21:09
stevemaropenstackclient does not use ksa yet21:12
stevemarhttps://review.openstack.org/#/c/225318/221:13
patchbotstevemar: patch 225318 - python-openstackclient - WIP - Rework everything to just use ksa/occ21:13
lbragstadstevemar I thought that was something navidp was working on?21:13
stevemarlbragstad: yeah, he has a patch too https://review.openstack.org/#/c/276350/21:13
patchbotstevemar: patch 276350 - python-openstackclient - Moving authentication from keystoneclient to keyst...21:13
stevemarlbragstad: but it's a tangled mess for mordred and he's familiar with all this21:14
mordreduhoh21:14
mordredwhat did I do now?21:14
mordredoh21:14
mordredyeah21:14
mordredit's a bit of a mess21:14
mordredI almost rage-coded something yesterday21:14
mordredbut then I lost my rage21:15
*** doug-fish has joined #openstack-keystone21:15
*** doug-fis_ has joined #openstack-keystone21:16
*** jbell8 has joined #openstack-keystone21:17
morganmordred: ooooh rage code?21:17
morganmordred: oh hah21:18
* morgan goes back to lurking.21:18
*** jbell8 has quit IRC21:18
navidpstevemar, I am actually finishing it up today21:19
morganmordred: Raaaaaaagggeeeeeeee code... it's what plants want... -- no wait.. that's another thing.21:19
shalehlbragstad: I have been annotating the Keystone Office hours with reviews that need guidance or abandoning from the query of Reviews that need Help.21:19
*** doug-fish has quit IRC21:20
lbragstadshaleh nice - did you build another dashboard?21:20
*** fangxu has joined #openstack-keystone21:21
shalehlbragstad: no, I just followed your "bug related patches that need love"21:21
shalehlbragstad: I updated 2, smartinelli abandoned one yesterday21:21
stevemarshaleh: it's stevemar !21:21
shalehstevemar: whatever :-)21:21
stevemarshaleh: though i do use smartinelli sometimes :)21:22
stevemarmordred: i did rebase that hot mess21:22
shalehI thought if we could mark the reviews that clearly need to be dropped we could focus on the ones remaining. Might be able to pass on their attached bugs too.21:22
shalehfor instance, a fair number of v2 issues that are kind of moot.21:23
morganshaleh: i did a pass on the open bugs, most are at least "valid" at this point, the v2 ones are likely ignorable.21:23
*** doug-fish has joined #openstack-keystone21:23
morganbut it doesn't really make them "invalid" per-say21:23
shalehmorgan: it might make sense to en masse mark the v2 as "won't fix" or something21:24
morganmaybe wont.. yeah21:24
*** Ephur has quit IRC21:24
*** mhickey has quit IRC21:24
morganstevemar: i can do a mass "wont fix" on v2 specific bugs if we want to go that direction21:24
* morgan kindof enjoys playing the bad guy in these scenarios21:24
morgancause.. i mean.. whats anyone going to do :P21:24
morgancomplain at me? ;)21:25
shalehMMOORRGAANNN21:25
lbragstadshaleh makes sense - so do we start with going through the "needs love" list?21:25
morganshaleh: WONT FIX21:25
* shaleh shakes fist at sky21:25
morganshaleh: oh sorry, trained response (learned fast!)21:25
*** doug-fis_ has quit IRC21:25
shalehheh :-)21:25
shalehlbragstad: I am doing that currently21:25
*** pauloewerton has quit IRC21:25
lbragstadshaleh sweet21:25
morganstevemar, bknudson: also are we really interested in doing a clean ldap3 driver instead of "converting the current thing" to ldap3?21:26
shalehlbragstad: the annotations on the office hours are where I need help21:26
shalehlbragstad: hopefully it will make your and others work go faster21:26
morganbknudson: because... if we agree on that, we can close out a chunk of other ldap-related bugs as "this doesn't make sense"21:26
lbragstadshaleh like what  specifically?21:26
bknudsonmorgan: I could try to do a clean ldap3 driver.21:26
shalehlbragstad: some need to be abandoned, they are long gone21:26
morganbknudson: do you think it's an easier prospect?21:26
lbragstadoh21:26
shalehlbragstad: others have lots of -1 with opinions but no real, current guidance21:27
bknudsonmorgan: yes, I think it would be easier than trying to convert the existing ldap21:27
morganbknudson: personally i like the idea because it could be read-only and optimised as such out the gate21:27
shalehlbragstad: others are v2 stuff which have been derelict for a while21:27
morganbknudson: ok cool i'll de-prio and mark the current LDAP bugs as "legacy-ldap" tagged21:27
bknudsonmorgan: right, it should be pretty simple read-only. The writing is the complicated part.21:27
morganso we can close them / find them easily21:27
morganwhen we officially deprecate the "ldap" r/w/icky/gross driver in favour of ldap3 shiney21:28
bknudsonthe existing tests would be hard to modify to work with the new one21:28
morganexactly21:28
morganand ldap3 really is much more pythonic21:28
morganusing dicts correctly vs dicts on read and tuple (WTF?!) on write?!?21:28
lbragstadshaleh sounds like what we really need is a true "needs love" list - which we'll probably get to once we abandon various patches21:28
shalehlbragstad: pretty much21:29
morganayoung: i am de-prioing this bug openstackclient/common/session.py:from keystoneauth1 import session21:29
morganayoung: erm21:29
morganayoung: https://bugs.launchpad.net/keystone/+bug/126875121:29
openstackLaunchpad bug 1268751 in OpenStack Identity (keystone) "Potential token revocation abuse via group membership" [High,Triaged] - Assigned to Lance Bragstad (lbragstad)21:29
lbragstadshaleh what I think "needs love" should be is a list of patches that we are happy with the direction on that close a bug.. agree?21:29
morganayoung: it's "high" but... has been "high" for 2 years21:29
morganclearly it's not "high"21:29
morgangoing to knock it down to medium21:30
ayoungmorgan, agreed21:30
ayounglow21:30
morganor low...21:30
shalehlbragstad: yes. Perhaps with recent comments saying what the direction should be if there is not clarity.21:30
morganyeah21:30
morganayoung: wishlist?21:30
morganayoung: ;)21:30
ayoungmorgan, with revocation events...I think it might actually be dealt with21:30
morganayoung: tossed it as wishlist21:30
morganayoung: it's really not a priority21:30
ayoungthat was only a problem when there were revoke by ID issues...it will get cleaned up as a side effect of going Fernet21:30
morganit has impacted... a net of nobody in the wild21:30
morganyeah21:30
morganfeel free to mark it as "invalid cause Fernet is awesome"21:31
morgan;)21:31
ayoungWill do21:31
shaleh:-)21:31
morgani like that kind of "invalid"21:31
lbragstadshaleh as you go through these would you be open to putting ones that need to be abandon in an etherpad?21:31
*** doug-fis_ has joined #openstack-keystone21:35
shalehlbragstad: I have been putting them on the office hours etherpad21:35
* ayoung thinks shaleh is bucking for PTL21:35
shalehlbragstad: if you want them somewhere else, I can do that21:35
shalehayoung: let me get +2 privs first :-)21:36
lbragstadshaleh that's perfect21:36
morganayoung: https://bugs.launchpad.net/keystone/+bug/1290625 i .. once you've cleaned up rev events, we can turn it into direct SQL query and eliminate a lot of this bug21:36
openstackLaunchpad bug 1290625 in OpenStack Identity (keystone) "keystone.contrib.revoke.backends.sql contains several glaring performance problems" [Medium,Triaged] - Assigned to Ron De Rose (ronald-de-rose)21:36
*** doug-fish has quit IRC21:38
shalehlbragstad: a collection of reviews that have been dropped by their original authors but are still worth pursuing would be a handy thing to advertise on our "how do I get started with Keystone" page.21:40
morganstevemar: are we really goin to fix https://bugs.launchpad.net/keystone/+bug/1376937 ?21:43
openstackLaunchpad bug 1376937 in OpenStack Identity (keystone) "No way to prevent duplicates in endpoints" [Medium,In progress] - Assigned to Raildo Mascena de Sousa Filho (raildo)21:43
*** doug-fish has joined #openstack-keystone21:43
lbragstadshaleh dstanek so maybe every week we go through and check the "needs love" section21:44
shalehlbragstad: that is what I have been doing when I have time on Friday to help out21:45
dstaneklbragstad: ?21:45
lbragstadevery review should fall into one of two categories. The first is that we should still pursue the fix/implementation but we should make sure leave a comment for the author asking if they need help or if something else can pick it up. The second is if the fix goes against what keystone should be doing and we choose to abandon it.21:46
morganlbragstad: is https://bugs.launchpad.net/keystone/+bug/1459483 still valid?21:46
openstackLaunchpad bug 1459483 in OpenStack Identity (keystone) "able to validate a Fernet token with garbage at the end" [Medium,Confirmed]21:46
morganlbragstad: or did we address that?21:46
shalehlbragstad: +++21:46
*** browne has joined #openstack-keystone21:46
*** doug-fis_ has quit IRC21:46
*** jsavak has quit IRC21:47
lbragstaddstanek shaleh wants to make it so that the "needs love" section is pruned of things that are stale - https://review.openstack.org/#/c/238160/321:47
patchbotlbragstad: patch 238160 - keystone - Add schema validation to fix v2 code error returns21:47
lbragstadah - wrong link21:47
*** jsavak has joined #openstack-keystone21:47
lbragstadhttps://goo.gl/GhxWi421:47
*** jorge_munoz has quit IRC21:47
morganlbragstad: https://bugs.launchpad.net/keystone/+bug/1476329 that looks like it'll be addressed when we merge the uuid and fernet token handling?21:48
openstackLaunchpad bug 1476329 in OpenStack Identity (keystone) "v2 tokens validated on the v3 API are missing timezones" [Medium,Confirmed]21:48
lbragstadmorgan I would have to double check the cryptography patch/bug referenced in that report21:48
morganlbragstad: ++21:48
dstaneklbragstad: ah, i see.21:48
openstackgerritBrant Knudson proposed openstack/keystone-specs: WIP - Swagger definition  https://review.openstack.org/28686521:49
lbragstaddstanek so maybe as part of bug friday - if you're reviewing bug fixes and you come across one that is stale but still valuable ping the author?21:49
openstackgerritMerged openstack/keystone: fix sample config link that 404s  https://review.openstack.org/27771621:50
shalehdstanek: I am currently reading the list of "needs love" and annotating a list on the office hours page with items that could be abandoned or that need guidance due to passage of time or lots of reviews but no clarity.21:50
morganmfisch: hows https://bugs.launchpad.net/keystone/+bug/1489061 looking with the current code base? (cc dolphm )21:50
openstackLaunchpad bug 1489061 in OpenStack Identity (keystone) "fernet token validation is slow" [Medium,In progress] - Assigned to Dolph Mathews (dolph)21:50
dstaneklbragstad: i often ping in the bug, but i rarely go back if they don't respond. at least until i circle through the rest of my list.21:51
mfischmorgan: I'm doing the magic now in puppet so we can upgrade keystone, but its taking awhile because we're dockerizing at the same time21:51
morganmfisch: heh21:52
*** neophy has joined #openstack-keystone21:52
mfischmorgan: which didnt answer your question, I think its better but have no data yet21:52
mfischI'd say close it and I will get data as soon as I can21:52
morganmfisch: we landed request-local cache as well21:52
mfischmitake?21:52
mfischmitaka21:52
morganmfisch: yeah before m321:52
lbragstadyep21:52
mfischim likely to start with liberty stable + docker, run some numbers then compare mitaka21:52
morganmfisch: so - i'll mark it incomplete with a "waiting more data"21:52
lbragstaddstanek that makes sense21:52
mfischsure21:52
mfischim not sure if I will go out the door with docker+L or docker+M21:53
*** jbell8 has joined #openstack-keystone21:59
openstackgerritOpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file  https://review.openstack.org/28656522:01
morgansamueldmq: https://bugs.launchpad.net/keystone/+bug/1367740 is this still a concern?22:01
openstackLaunchpad bug 1367740 in OpenStack Identity (keystone) "Assignment backends raise non-suggestive exception in grant CRUD" [Low,Triaged] - Assigned to Samuel de Medeiros Queiroz (samueldmq)22:01
*** jsavak has quit IRC22:06
*** rk4n has quit IRC22:07
*** ninag has quit IRC22:08
*** ninag has joined #openstack-keystone22:08
*** henrynash has quit IRC22:10
morganshaleh: ok i think i closed a few bugs and de-prioed a few22:10
*** doug-fis_ has joined #openstack-keystone22:10
shalehmorgan: ++22:11
morganshaleh: need to hop on a phone call. ugh brain is hurting but almost done with the first 75 bugs (most v2 ones are closed / patches abandoned)22:11
shalehno worries22:11
morganthere were only 2 or 3 legit v2-only bugs that had patches22:11
morgani bet we'll be down to ~110 bugs after this pass22:11
*** doug-fish has quit IRC22:11
*** henrynash has joined #openstack-keystone22:13
*** ChanServ sets mode: +v henrynash22:13
*** ninag has quit IRC22:13
*** e0ne has quit IRC22:14
*** rk4n has joined #openstack-keystone22:15
*** mylu has quit IRC22:15
*** sdake_ has joined #openstack-keystone22:15
*** mylu has joined #openstack-keystone22:15
*** henrynash has quit IRC22:16
*** petertr7 is now known as petertr7_away22:17
*** e0ne has joined #openstack-keystone22:17
*** sdake has quit IRC22:18
*** jorge_munoz has joined #openstack-keystone22:18
*** jorge_munoz has quit IRC22:18
morgan125 bugs.22:19
morganand another 40 to review.22:19
*** rk4n_ has joined #openstack-keystone22:22
*** rk4n has quit IRC22:24
*** e0ne has quit IRC22:27
*** edmondsw has quit IRC22:32
*** anush has quit IRC22:36
*** ayoung has quit IRC22:37
*** doug-fis_ has quit IRC22:39
*** doug-fish has joined #openstack-keystone22:42
*** ninag has joined #openstack-keystone22:42
*** doug-fis_ has joined #openstack-keystone22:44
*** jbell8 has quit IRC22:46
*** doug-fish has quit IRC22:47
*** ninag has quit IRC22:47
*** knikolla has quit IRC22:48
*** doug-fis_ has quit IRC22:48
*** mylu has quit IRC22:49
*** yarkot_ has joined #openstack-keystone22:53
*** dims_ has quit IRC22:56
*** yarkot_ has quit IRC22:57
*** yarkot_ has joined #openstack-keystone22:57
*** mylu has joined #openstack-keystone22:58
*** yarkot_ has quit IRC22:59
*** richm has quit IRC23:02
dstanekmorgan: nice23:03
*** browne has quit IRC23:04
*** spandhe has quit IRC23:05
*** neophy has quit IRC23:06
*** ThomasHsiao has joined #openstack-keystone23:06
*** browne has joined #openstack-keystone23:06
*** browne has quit IRC23:06
*** ThomasHsiao has quit IRC23:08
*** rk4n_ has quit IRC23:08
*** browne has joined #openstack-keystone23:08
*** ThomasHsiao has joined #openstack-keystone23:08
bknudsonI need to stop telling people keystone doesn't have any bugs.23:09
*** gordc has quit IRC23:09
openstackgerritBrant Knudson proposed openstack/keystone: WIP - Generate swagger  https://review.openstack.org/28749923:11
*** spandhe has joined #openstack-keystone23:12
*** jorge_munoz has joined #openstack-keystone23:13
*** sigmavirus24 is now known as sigmavirus24_awa23:15
*** mylu has quit IRC23:15
*** sheel has quit IRC23:17
morganstevemar, dstanek, bknudson: 117 bugs now23:20
morganrapidly approaching the magic sub-100 mark23:20
morganannnd. no high-prio bugs23:20
morganand almost all v2-specific bugs are now closed.23:21
*** jorge_munoz has quit IRC23:21
morganshaleh: ^ cc23:23
*** mylu has joined #openstack-keystone23:27
*** mylu has quit IRC23:27
*** mylu has joined #openstack-keystone23:27
openstackgerritBrant Knudson proposed openstack/keystone: WIP - Generate swagger  https://review.openstack.org/28749923:28
*** richm has joined #openstack-keystone23:32
*** mylu has quit IRC23:33
*** browne has quit IRC23:36
*** subscope has quit IRC23:37
*** browne has joined #openstack-keystone23:39
*** spzala has quit IRC23:41
*** spzala has joined #openstack-keystone23:42
*** spzala has quit IRC23:42
*** spzala has joined #openstack-keystone23:42
*** spzala_ has joined #openstack-keystone23:43
*** slberger has left #openstack-keystone23:45
*** spzala has quit IRC23:47
*** ayoung has joined #openstack-keystone23:50
*** ChanServ sets mode: +v ayoung23:50
*** spzala_ has quit IRC23:52
*** spzala has joined #openstack-keystone23:52
*** shoutm has joined #openstack-keystone23:55
*** spzala has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!