| *** chlong has quit IRC | 00:11 | |
| *** hrou has joined #openstack-keystone | 00:13 | |
| *** chlong has joined #openstack-keystone | 00:24 | |
| *** jiaxi has joined #openstack-keystone | 00:43 | |
| jiaxi | Good moring,everyone | 00:43 |
|---|---|---|
| dstanek | jiaxi: hi | 00:52 |
| jiaxi | David | 00:52 |
| jiaxi | Would you please help me review my patch set ? | 00:53 |
| dstanek | jiaxi: there are lots of things to review. you have to be patient. | 00:53 |
| dstanek | jiaxi: we get notifications for patch updates so there is no reason to email or poke the room about it | 00:53 |
| jiaxi | oh,I know. | 00:54 |
| jiaxi | A little worry. | 00:54 |
| dstanek | jiaxi: worry? | 00:54 |
| jiaxi | My boss require us to submit patch set. | 00:55 |
| dstanek | jiaxi: just any patchset? | 00:56 |
| jiaxi | Yes | 00:56 |
| jiaxi | except docment. | 00:56 |
| dstanek | jiaxi: have you addressed my comment about copying the whitelist? | 00:57 |
| dstanek | jiaxi: i also think the only thing you need to validate is the % operation. no protocol/host/etc checks | 00:57 |
| jiaxi | Why ? | 00:57 |
| jiaxi | And space in url | 00:58 |
| jiaxi | also should be check | 00:58 |
| jiaxi | You can't use www.g oo gl e .com | 00:58 |
| dstanek | jiaxi: the space is probably fine, but the rest should go | 00:59 |
| jiaxi | Why? | 00:59 |
| jiaxi | 1. a url which is None74 2. a url which has space, you can't use www.go o gle.com to search75 3. a url whose scheme is not 'http' or 'https'76 4. a url whose host in not valid77 5. a url whose port is greater than 65535(if the url has port) | 01:00 |
| jiaxi | The netloc | 01:00 |
| jiaxi | port | 01:00 |
| *** christx2 has quit IRC | 01:00 | |
| *** christx2 has joined #openstack-keystone | 01:00 | |
| dstanek | we don't need to check 3,4 or 5 | 01:01 |
| dstanek | i definitely don't want to hit the network to check the hostname | 01:01 |
| dstanek | the bug is simply about the substitutions not working so you should just fix that. we loosened out URL definition on purpose and i don't think we want to tighten it just yet | 01:02 |
| jiaxi | Yes, you are right. | 01:03 |
| jiaxi | I just google about how to validate url. So many cases have been taken into cnsideration | 01:03 |
| jiaxi | consideration. | 01:04 |
| jiaxi | I'm chinese. English is not so well. sorry. | 01:04 |
| dstanek | jiaxi: that's not a problem | 01:04 |
| jiaxi | I will remove 3, 4 ,5 | 01:05 |
| dstanek | jiaxi: just concentrate on fixing on just the bug. strict validation will likely be rejected. | 01:05 |
| jiaxi | left 1 and 2 only | 01:05 |
| dstanek | jiaxi: you may want to see if it's possible to submit a url as null or '' in our API contract because if it is then you can't change that either | 01:06 |
| dstanek | jiaxi: and remove the copy of the whitelist. we can't maintain that in two places | 01:06 |
| jiaxi | oh,no. | 01:06 |
| jiaxi | I use the whitelist as a dict | 01:07 |
| jiaxi | here | 01:07 |
| jiaxi | so I can use it very convinient. | 01:07 |
| jiaxi | very smart | 01:07 |
| jiaxi | https://review.openstack.org/#/c/200512/15/keystone/clean.py | 01:07 |
| dstanek | jiaxi: did you fix it to use the same whitelist we already have defined or did you copy it? | 01:07 |
| jiaxi | The other place is a list. I use it as a dict. | 01:08 |
| dstanek | jiaxi: right, use the list to create the dict. if we add something to the list how will we remember to add it to the dict? | 01:08 |
| dstanek | jiaxi: always try to avoid defining things in two different places | 01:09 |
| jiaxi | So you want me to import that one. And use it to construct a dict. | 01:10 |
| jiaxi | Right ? | 01:10 |
| dstanek | yes | 01:10 |
| *** ankita_wagh has quit IRC | 01:11 | |
| jiaxi | I got it. Thank you. | 01:11 |
| *** ankita_wagh has joined #openstack-keystone | 01:12 | |
| dstanek | jiaxi: no, problem | 01:17 |
| breton | 264K test_backend.py | 01:25 |
| breton | 6k lines | 01:25 |
| breton | oh my. | 01:25 |
| *** stevemar has joined #openstack-keystone | 01:25 | |
| *** ChanServ sets mode: +v stevemar | 01:25 | |
| dstanek | breton: good times | 01:26 |
| *** browne has joined #openstack-keystone | 01:27 | |
| *** browne1 has quit IRC | 01:29 | |
| *** stevemar has quit IRC | 01:29 | |
| *** ankita_wagh has quit IRC | 01:45 | |
| *** piyanai has joined #openstack-keystone | 02:04 | |
| *** piyanai has quit IRC | 02:27 | |
| *** hakimo_ has joined #openstack-keystone | 02:52 | |
| *** hakimo has quit IRC | 02:54 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: List projects filtering by is_domain flag https://review.openstack.org/158398 | 02:57 |
| openstackgerrit | jiaxi proposed openstack/keystone: Invalid URLs are not suppressed when creating endpoint https://review.openstack.org/200512 | 03:36 |
| *** flwang has quit IRC | 03:49 | |
| *** flwang has joined #openstack-keystone | 04:16 | |
| *** flwang has quit IRC | 04:27 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraint https://review.openstack.org/158372 | 04:27 |
| *** stevemar has joined #openstack-keystone | 05:01 | |
| *** ChanServ sets mode: +v stevemar | 05:01 | |
| *** htruta_ has quit IRC | 05:32 | |
| *** flwang has joined #openstack-keystone | 05:36 | |
| *** ankita_wagh has joined #openstack-keystone | 05:46 | |
| *** ankita_wagh has quit IRC | 05:50 | |
| *** stevemar has quit IRC | 06:06 | |
| *** stevemar has joined #openstack-keystone | 06:07 | |
| *** ChanServ sets mode: +v stevemar | 06:07 | |
| *** stevemar has quit IRC | 06:09 | |
| *** ankita_wagh has joined #openstack-keystone | 06:16 | |
| *** stevemar has joined #openstack-keystone | 06:24 | |
| *** ChanServ sets mode: +v stevemar | 06:24 | |
| openstackgerrit | Merged openstack/keystone: Remove unnecessary executable permission https://review.openstack.org/202372 | 06:27 |
| *** browne has quit IRC | 06:27 | |
| *** flwang has quit IRC | 06:28 | |
| openstackgerrit | Merged openstack/keystone: Updated from global requirements https://review.openstack.org/203307 | 06:29 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/202282 | 06:31 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/202282 | 06:32 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: move clean.py into keystone/common https://review.openstack.org/203297 | 06:32 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Move backends.py to keystone.server https://review.openstack.org/203301 | 06:32 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Create a version package https://review.openstack.org/203262 | 06:34 |
| *** flwang has joined #openstack-keystone | 06:44 | |
| *** stevemar has quit IRC | 06:44 | |
| *** stevemar has joined #openstack-keystone | 06:44 | |
| *** ChanServ sets mode: +v stevemar | 06:44 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Create a version package https://review.openstack.org/203262 | 06:47 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Remove unnecessary ldap imports https://review.openstack.org/203402 | 06:51 |
| *** ankita_wagh has quit IRC | 06:59 | |
| *** flwang has quit IRC | 07:18 | |
| *** hrou has quit IRC | 07:25 | |
| *** flwang has joined #openstack-keystone | 07:39 | |
| *** btully has joined #openstack-keystone | 07:57 | |
| *** stevemar has quit IRC | 08:20 | |
| *** stevemar has joined #openstack-keystone | 08:20 | |
| *** ChanServ sets mode: +v stevemar | 08:20 | |
| *** e0ne has joined #openstack-keystone | 08:36 | |
| *** e0ne has quit IRC | 08:43 | |
| *** stevemar has quit IRC | 09:14 | |
| *** stevemar has joined #openstack-keystone | 09:15 | |
| *** ChanServ sets mode: +v stevemar | 09:15 | |
| *** flwang has quit IRC | 09:20 | |
| *** jiaxi has quit IRC | 09:23 | |
| openstackgerrit | liusheng proposed openstack/keystone: Remove the unused config_files parameter of service entry https://review.openstack.org/186987 | 09:32 |
| *** bradjones has quit IRC | 10:10 | |
| *** bradjones has joined #openstack-keystone | 10:11 | |
| *** bradjones has quit IRC | 10:11 | |
| *** bradjones has joined #openstack-keystone | 10:11 | |
| *** christx2 has quit IRC | 10:20 | |
| *** btully has quit IRC | 10:24 | |
| *** stevemar has quit IRC | 11:06 | |
| *** stevemar has joined #openstack-keystone | 11:07 | |
| *** ChanServ sets mode: +v stevemar | 11:07 | |
| *** flwang has joined #openstack-keystone | 11:07 | |
| *** geoffarnold has joined #openstack-keystone | 11:09 | |
| *** geoffarnold has quit IRC | 11:09 | |
| *** geoffarnold has joined #openstack-keystone | 11:10 | |
| *** flwang has quit IRC | 11:15 | |
| *** btully has joined #openstack-keystone | 11:18 | |
| *** btully has quit IRC | 11:23 | |
| *** ayoung has quit IRC | 11:26 | |
| *** jiaxi has joined #openstack-keystone | 11:36 | |
| jiaxi | Hello, everyone. | 11:36 |
| *** ayoung has joined #openstack-keystone | 11:38 | |
| *** ChanServ sets mode: +v ayoung | 11:38 | |
| *** stevemar has quit IRC | 11:53 | |
| *** stevemar has joined #openstack-keystone | 11:53 | |
| *** ChanServ sets mode: +v stevemar | 11:53 | |
| *** btully has joined #openstack-keystone | 12:19 | |
| *** christx2 has joined #openstack-keystone | 12:22 | |
| *** btully has quit IRC | 12:24 | |
| *** geoffarnold has quit IRC | 12:32 | |
| *** christx2 has quit IRC | 12:43 | |
| *** dims_ has joined #openstack-keystone | 12:49 | |
| *** jiaxi has quit IRC | 13:15 | |
| *** dims_ has quit IRC | 13:21 | |
| *** stevemar has quit IRC | 13:29 | |
| *** stevemar has joined #openstack-keystone | 13:30 | |
| *** ChanServ sets mode: +v stevemar | 13:30 | |
| *** bradjones has quit IRC | 13:32 | |
| *** bradjones has joined #openstack-keystone | 13:34 | |
| *** bradjones has quit IRC | 13:34 | |
| *** bradjones has joined #openstack-keystone | 13:34 | |
| *** christx2 has joined #openstack-keystone | 13:40 | |
| *** topol has joined #openstack-keystone | 13:42 | |
| *** ChanServ sets mode: +v topol | 13:42 | |
| *** bknudson has joined #openstack-keystone | 13:54 | |
| *** ChanServ sets mode: +v bknudson | 13:54 | |
| *** christx2 has quit IRC | 13:55 | |
| *** e0ne has joined #openstack-keystone | 14:01 | |
| *** dims_ has joined #openstack-keystone | 14:08 | |
| *** e0ne has quit IRC | 14:08 | |
| *** e0ne has joined #openstack-keystone | 14:18 | |
| *** e0ne has quit IRC | 14:20 | |
| *** dims_ has quit IRC | 14:20 | |
| *** dims_ has joined #openstack-keystone | 14:21 | |
| *** stevemar has quit IRC | 14:22 | |
| *** stevemar has joined #openstack-keystone | 14:22 | |
| *** ChanServ sets mode: +v stevemar | 14:22 | |
| *** dims_ has quit IRC | 14:23 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Document policy target for operation https://review.openstack.org/168521 | 14:23 |
| *** e0ne has joined #openstack-keystone | 14:24 | |
| *** stevemar has quit IRC | 14:26 | |
| *** e0ne has quit IRC | 14:29 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Document default value for tree_dn options https://review.openstack.org/189027 | 14:29 |
| *** e0ne has joined #openstack-keystone | 14:32 | |
| *** e0ne has quit IRC | 14:32 | |
| *** e0ne has joined #openstack-keystone | 14:33 | |
| *** e0ne has quit IRC | 14:35 | |
| *** e0ne has joined #openstack-keystone | 14:38 | |
| *** piyanai has joined #openstack-keystone | 14:39 | |
| *** e0ne has quit IRC | 14:43 | |
| *** dan is now known as Guest28847 | 14:45 | |
| *** dan| has joined #openstack-keystone | 14:46 | |
| *** e0ne has joined #openstack-keystone | 14:47 | |
| openstackgerrit | Brant Knudson proposed openstack/python-keystoneclient: Prevent attempts to "filter" list() calls by globally unique IDs https://review.openstack.org/182752 | 14:50 |
| *** e0ne has quit IRC | 14:50 | |
| *** chenhong has joined #openstack-keystone | 14:52 | |
| *** e0ne has joined #openstack-keystone | 14:54 | |
| *** browne has joined #openstack-keystone | 14:54 | |
| *** e0ne has quit IRC | 14:56 | |
| openstackgerrit | Brant Knudson proposed openstack/python-keystoneclient: Stop using .keys() on dicts where not needed https://review.openstack.org/194894 | 14:56 |
| *** e0ne has joined #openstack-keystone | 15:00 | |
| *** hrou has joined #openstack-keystone | 15:02 | |
| *** chenhong has quit IRC | 15:02 | |
| *** chenhong has joined #openstack-keystone | 15:03 | |
| *** e0ne has quit IRC | 15:05 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Clean up code to use .items() https://review.openstack.org/200734 | 15:07 |
| *** e0ne has joined #openstack-keystone | 15:09 | |
| *** e0ne has quit IRC | 15:14 | |
| *** chenhong has quit IRC | 15:17 | |
| *** e0ne has joined #openstack-keystone | 15:17 | |
| *** dims_ has joined #openstack-keystone | 15:20 | |
| *** e0ne has quit IRC | 15:20 | |
| openstackgerrit | Brant Knudson proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/197254 | 15:20 |
| openstackgerrit | Brant Knudson proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/197254 | 15:22 |
| *** e0ne has joined #openstack-keystone | 15:24 | |
| *** e0ne has quit IRC | 15:26 | |
| *** e0ne has joined #openstack-keystone | 15:30 | |
| *** stevemar has joined #openstack-keystone | 15:32 | |
| *** ChanServ sets mode: +v stevemar | 15:32 | |
| *** geoffarnold has joined #openstack-keystone | 15:38 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Docs link to ACTIONS https://review.openstack.org/203433 | 15:39 |
| *** e0ne has quit IRC | 15:42 | |
| *** geoffarnold has quit IRC | 15:44 | |
| *** e0ne has joined #openstack-keystone | 15:45 | |
| *** e0ne has quit IRC | 15:47 | |
| *** e0ne has joined #openstack-keystone | 15:51 | |
| *** e0ne has quit IRC | 15:53 | |
| *** geoffarnold has joined #openstack-keystone | 15:55 | |
| *** geoffarnold has quit IRC | 15:57 | |
| *** e0ne has joined #openstack-keystone | 15:57 | |
| *** stevemar has quit IRC | 16:00 | |
| *** e0ne has quit IRC | 16:00 | |
| *** stevemar has joined #openstack-keystone | 16:01 | |
| *** ChanServ sets mode: +v stevemar | 16:01 | |
| *** e0ne has joined #openstack-keystone | 16:04 | |
| *** browne has quit IRC | 16:05 | |
| *** dims_ has quit IRC | 16:05 | |
| *** jecarey has joined #openstack-keystone | 16:10 | |
| *** btully has joined #openstack-keystone | 16:10 | |
| *** e0ne has quit IRC | 16:13 | |
| *** e0ne has joined #openstack-keystone | 16:17 | |
| *** jecarey has quit IRC | 16:20 | |
| *** e0ne has quit IRC | 16:21 | |
| *** e0ne has joined #openstack-keystone | 16:25 | |
| *** dims_ has joined #openstack-keystone | 16:26 | |
| *** e0ne has quit IRC | 16:28 | |
| *** hrou has quit IRC | 16:29 | |
| *** e0ne has joined #openstack-keystone | 16:32 | |
| *** e0ne has quit IRC | 16:34 | |
| *** e0ne has joined #openstack-keystone | 16:38 | |
| *** e0ne has quit IRC | 16:45 | |
| *** e0ne has joined #openstack-keystone | 16:49 | |
| *** piyanai has quit IRC | 16:52 | |
| *** e0ne has quit IRC | 16:52 | |
| *** ankita_wagh has joined #openstack-keystone | 16:53 | |
| *** dims_ has quit IRC | 16:56 | |
| *** e0ne has joined #openstack-keystone | 16:57 | |
| *** e0ne has quit IRC | 16:58 | |
| *** e0ne has joined #openstack-keystone | 17:02 | |
| *** stevemar has quit IRC | 17:04 | |
| *** stevemar has joined #openstack-keystone | 17:04 | |
| *** ChanServ sets mode: +v stevemar | 17:04 | |
| *** e0ne has quit IRC | 17:06 | |
| *** stevemar has quit IRC | 17:06 | |
| *** stevemar has joined #openstack-keystone | 17:07 | |
| *** ChanServ sets mode: +v stevemar | 17:07 | |
| *** e0ne has joined #openstack-keystone | 17:10 | |
| *** e0ne has quit IRC | 17:15 | |
| *** e0ne has joined #openstack-keystone | 17:19 | |
| *** e0ne has quit IRC | 17:21 | |
| *** e0ne has joined #openstack-keystone | 17:25 | |
| *** e0ne has quit IRC | 17:28 | |
| *** stevemar has quit IRC | 17:28 | |
| *** stevemar has joined #openstack-keystone | 17:29 | |
| *** ChanServ sets mode: +v stevemar | 17:29 | |
| *** e0ne has joined #openstack-keystone | 17:32 | |
| *** e0ne has quit IRC | 17:33 | |
| *** stevemar has quit IRC | 17:35 | |
| *** _afazekas has joined #openstack-keystone | 17:35 | |
| *** geoffarnold has joined #openstack-keystone | 17:54 | |
| *** geoffarnold has quit IRC | 18:02 | |
| *** geoffarnold has joined #openstack-keystone | 18:04 | |
| *** dims_ has joined #openstack-keystone | 18:15 | |
| *** ankita_wagh has quit IRC | 18:18 | |
| *** dims_ has quit IRC | 18:25 | |
| *** dims_ has joined #openstack-keystone | 18:25 | |
| *** dims_ has quit IRC | 18:31 | |
| *** e0ne has joined #openstack-keystone | 18:36 | |
| *** btully has quit IRC | 18:37 | |
| *** geoffarnold has quit IRC | 18:40 | |
| *** e0ne has quit IRC | 18:43 | |
| *** e0ne has joined #openstack-keystone | 18:47 | |
| *** e0ne has quit IRC | 18:51 | |
| *** geoffarnold has joined #openstack-keystone | 18:52 | |
| *** e0ne has joined #openstack-keystone | 18:53 | |
| *** geoffarnold has quit IRC | 18:54 | |
| *** geoffarnold has joined #openstack-keystone | 18:54 | |
| *** e0ne has quit IRC | 18:58 | |
| *** htruta has joined #openstack-keystone | 18:59 | |
| *** e0ne has joined #openstack-keystone | 19:02 | |
| *** geoffarnold has quit IRC | 19:06 | |
| *** dobson has quit IRC | 19:08 | |
| *** dobson has joined #openstack-keystone | 19:10 | |
| *** e0ne has quit IRC | 19:16 | |
| *** e0ne has joined #openstack-keystone | 19:21 | |
| *** e0ne has quit IRC | 19:25 | |
| *** e0ne has joined #openstack-keystone | 19:29 | |
| *** e0ne has quit IRC | 19:31 | |
| *** e0ne has joined #openstack-keystone | 19:35 | |
| *** hrou has joined #openstack-keystone | 19:36 | |
| *** geoffarnold has joined #openstack-keystone | 19:43 | |
| *** e0ne has quit IRC | 19:48 | |
| *** e0ne has joined #openstack-keystone | 19:52 | |
| *** e0ne has quit IRC | 19:55 | |
| *** boris-42 has joined #openstack-keystone | 19:55 | |
| *** e0ne has joined #openstack-keystone | 19:58 | |
| *** e0ne has quit IRC | 20:00 | |
| *** ankita_wagh has joined #openstack-keystone | 20:00 | |
| *** e0ne has joined #openstack-keystone | 20:05 | |
| *** e0ne has quit IRC | 20:07 | |
| *** stevemar has joined #openstack-keystone | 20:08 | |
| *** ChanServ sets mode: +v stevemar | 20:08 | |
| *** e0ne has joined #openstack-keystone | 20:12 | |
| *** e0ne has quit IRC | 20:14 | |
| *** e0ne has joined #openstack-keystone | 20:18 | |
| openstackgerrit | Henrique Truta proposed openstack/keystone: Change project name constraint https://review.openstack.org/158372 | 20:21 |
| *** e0ne has quit IRC | 20:23 | |
| *** christx2 has joined #openstack-keystone | 20:37 | |
| *** geoffarnold has quit IRC | 20:40 | |
| *** stevemar has quit IRC | 20:42 | |
| *** stevemar has joined #openstack-keystone | 20:43 | |
| *** ChanServ sets mode: +v stevemar | 20:43 | |
| *** ankita_wagh has quit IRC | 21:16 | |
| *** stevemar has quit IRC | 21:19 | |
| *** ankita_wagh has joined #openstack-keystone | 21:21 | |
| *** marzif has quit IRC | 21:27 | |
| *** piyanai has joined #openstack-keystone | 21:28 | |
| *** stevemar has joined #openstack-keystone | 21:29 | |
| *** ChanServ sets mode: +v stevemar | 21:29 | |
| *** marzif_ has quit IRC | 21:34 | |
| *** stevemar has quit IRC | 22:05 | |
| *** stevemar has joined #openstack-keystone | 22:06 | |
| *** ChanServ sets mode: +v stevemar | 22:06 | |
| *** btully has joined #openstack-keystone | 22:13 | |
| *** hrou has quit IRC | 22:16 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Create a version package https://review.openstack.org/203262 | 22:19 |
| *** uvirtbot has joined #openstack-keystone | 22:20 | |
| *** ankita_wagh has quit IRC | 22:26 | |
| *** dims_ has joined #openstack-keystone | 22:34 | |
| *** christx2 has quit IRC | 22:49 | |
| *** chlong has quit IRC | 22:51 | |
| *** dims_ has quit IRC | 22:55 | |
| *** piyanai has quit IRC | 23:07 | |
| *** piyanai has joined #openstack-keystone | 23:14 | |
| *** darrenc is now known as darrenc_afk | 23:14 | |
| *** stevemar has quit IRC | 23:15 | |
| *** boris-42 has quit IRC | 23:22 | |
| *** ankita_wagh has joined #openstack-keystone | 23:27 | |
| *** darrenc_afk is now known as darrenc | 23:49 | |
| *** stevemar has joined #openstack-keystone | 23:59 | |
| *** ChanServ sets mode: +v stevemar | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!