| *** rwsu has quit IRC | 00:18 | |
| *** joesavak has quit IRC | 00:26 | |
| *** browne has joined #openstack-keystone | 00:34 | |
| *** browne has left #openstack-keystone | 00:35 | |
| *** henrynash has quit IRC | 00:37 | |
| morganfainberg | jamielennox, RC is targeted for the 27th iirc | 00:48 |
|---|---|---|
| jamielennox | morganfainberg: yea, i'll fix it anyway the comment is minor | 00:48 |
| jamielennox | i just heard talk of a string freeze and it would violate that | 00:48 |
| jamielennox | unfortunately i got so much gerrit email that that -1 got lost, and when i look at my reviews overview page it shows +2 from dolph so i never saw the -1 | 00:49 |
| *** wchrisj has quit IRC | 00:50 | |
| *** devlaps has quit IRC | 00:51 | |
| jamielennox | however just figured out: https://review.openstack.org/#/q/owner:jamielennox+%28CodeReview-1+OR+CodeReview-2%29+status:open,n,z so now i need to put that somewhere i click often | 00:51 |
| *** david-lyle has joined #openstack-keystone | 00:54 | |
| *** stevemar has joined #openstack-keystone | 00:57 | |
| *** marcoemorais has quit IRC | 01:04 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/keystone: Change the default version discovery URLs https://review.openstack.org/78068 | 01:04 |
| *** wchrisj has joined #openstack-keystone | 01:05 | |
| *** jamielennox has quit IRC | 01:11 | |
| *** ayoung has quit IRC | 01:16 | |
| * gtt116 is away: 我很忙 | 01:20 | |
| *** jamielennox has joined #openstack-keystone | 01:22 | |
| *** ayoung has joined #openstack-keystone | 01:31 | |
| *** stevemar has quit IRC | 01:35 | |
| *** ayoung has quit IRC | 01:41 | |
| *** wchrisj has quit IRC | 01:54 | |
| *** gokrokve has joined #openstack-keystone | 01:55 | |
| *** ayoung has joined #openstack-keystone | 01:57 | |
| *** amcrn has quit IRC | 02:02 | |
| *** wchrisj has joined #openstack-keystone | 02:04 | |
| *** wchrisj has quit IRC | 02:12 | |
| *** stevemar has joined #openstack-keystone | 02:20 | |
| *** daneyon has joined #openstack-keystone | 02:26 | |
| *** mberlin1 has joined #openstack-keystone | 02:54 | |
| *** mberlin has quit IRC | 02:56 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/identity-api: Introduce a path for accessing the current user https://review.openstack.org/81973 | 03:10 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/identity-api: Add service name to service catalog https://review.openstack.org/81975 | 03:29 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/identity-api: Allow scoping endpoints to a project or domain https://review.openstack.org/81977 | 03:47 |
| *** zhiyan_ is now known as zhiyan | 03:50 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/identity-api: Add service name to service catalog https://review.openstack.org/81975 | 03:55 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add request/access token and consumer support for keystoneclient https://review.openstack.org/81980 | 03:56 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Authenticate via oauth https://review.openstack.org/81981 | 04:01 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add example script for oauth1 functions https://review.openstack.org/80193 | 04:05 |
| stevemar | jamielennox, i still need to keep some of oauth logic in _factory right? | 04:16 |
| stevemar | jamielennox, just dump the authConstructor and authMethod into it's own file ? | 04:16 |
| jamielennox | stevemar: you shouldn't need factory at all | 04:21 |
| jamielennox | that's for the older clients and i'm intending to remove it | 04:21 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Authenticate via oauth https://review.openstack.org/81981 | 04:30 |
| stevemar | jamielennox, cool, done | 04:30 |
| *** wchrisj has joined #openstack-keystone | 04:30 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add example script for oauth1 functions https://review.openstack.org/80193 | 04:32 |
| *** stevemar has quit IRC | 04:38 | |
| *** morganfainberg is now known as morganfainberg_Z | 04:39 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Remove _factory methods from auth plugins https://review.openstack.org/81985 | 04:41 |
| *** morganfainberg_Z is now known as morganfainberg | 04:44 | |
| morganfainberg | wheee | 04:45 |
| jamielennox | morganfainberg: quick nap at the keyboard there | 04:45 |
| morganfainberg | nah, system crashed | 04:45 |
| morganfainberg | and in the process i also lost my backup drive | 04:45 |
| morganfainberg | looks like encrypted backups bit me this time | 04:46 |
| morganfainberg | =/ | 04:46 |
| jamielennox | ah, i was coming up with cool scenarios about how maybe your irc is hooked up to a kinect tracker that knows when you passed out | 04:46 |
| jamielennox | ouch | 04:46 |
| jamielennox | gone? | 04:46 |
| morganfainberg | jamielennox, unrecoverable partition | 04:46 |
| morganfainberg | jamielennox, this just solidifies i need to fix my @home backups | 04:46 |
| morganfainberg | jamielennox, so i have this machine backed up in 2 places. | 04:46 |
| jamielennox | in theory i definetly understand encrypted backups - in practice i'm way more likely to loose the keys than i am to care about someone else finding my photos | 04:47 |
| jamielennox | obvoiusly that depends on what you're backing up | 04:47 |
| morganfainberg | i use bad encryption keys | 04:47 |
| morganfainberg | well bad encryption passphrases | 04:48 |
| jamielennox | morganfainberg: heh, the equivalent of hiding your house keys behind a rock | 04:48 |
| morganfainberg | yeah yeah | 04:49 |
| jamielennox | but we all still do it | 04:49 |
| morganfainberg | jamielennox, i think i'm going to have bandwidth to do ksc reviews next week | 04:50 |
| jamielennox | morganfainberg: sweet! | 04:50 |
| morganfainberg | jamielennox, and yours are the top of my list over there | 04:50 |
| morganfainberg | i'm still trying to duplicate an RC bug. | 04:50 |
| morganfainberg | but ... eh | 04:50 |
| jamielennox | i've been trying to find ways of increasing my bullying | 04:50 |
| morganfainberg | there is some really odd edge case going on here https://bugs.launchpad.net/keystone/+bug/1294862 | 04:51 |
| uvirtbot | Launchpad bug 1294862 in keystone "Token expiration time with memcache->kvs->dogpile is wrong" [Medium,New] | 04:51 |
| morganfainberg | but i'm not finding it easy to duplicate. | 04:51 |
| morganfainberg | i'm getting the feeling we have some clock skew issues there. or a system didn't DST jump | 04:51 |
| morganfainberg | so i need to sync up w/ the reporter, other than that... | 04:52 |
| jamielennox | nah DST is too obvious | 04:52 |
| morganfainberg | yeah | 04:52 |
| morganfainberg | damn it. | 04:52 |
| jamielennox | but it makes sense with him being UTC+1 that the tokens are expired immediately with a 1 hour timeout | 04:53 |
| morganfainberg | yeah | 04:53 |
| jamielennox | it just means that something in there is not correctly doing a utc calculation | 04:53 |
| morganfainberg | but even if the machine didn't jump DST it shouldn't break our setup | 04:53 |
| jamielennox | no, UTC shouldn't react to DST (in theory) | 04:53 |
| morganfainberg | we coerce everything to naive (non-offset utc time) values | 04:53 |
| morganfainberg | unless the system thinks it's an hour offf. | 04:54 |
| morganfainberg | and he's getting token data back, so it tells me it isn't memcache being dumb | 04:54 |
| jamielennox | is this an auth_token failure? where is he seeing the problem? | 04:54 |
| jamielennox | oh, purely keystone token validatoin | 04:54 |
| morganfainberg | well | 04:54 |
| morganfainberg | it seems like keystone is working | 04:55 |
| morganfainberg | but other APIs aren't | 04:55 |
| morganfainberg | so, auth_token | 04:55 |
| jamielennox | o - right | 04:55 |
| morganfainberg | PKI tokens | 04:55 |
| jamielennox | meh - it has been one of those fridays | 04:55 |
| morganfainberg | yeah. | 04:55 |
| jamielennox | interesting, we had a bug like that fixed in KSC a while ago | 04:56 |
| jamielennox | but it was definitely fixed | 04:56 |
| morganfainberg | yeah | 04:56 |
| morganfainberg | this is an odd one | 04:56 |
| jamielennox | so first guess is clock skew between client and server | 04:56 |
| * morganfainberg taps foot and waits for bug 1295261 to pass gate | 04:57 | |
| uvirtbot | Launchpad bug 1295261 in keystone "test_v3_os_revoke.OSRevokeTests: invalid event issued_before time; Too early" [Critical,In progress] https://launchpad.net/bugs/1295261 | 04:57 |
| morganfainberg | nothing else seems to be passing without that. | 04:57 |
| morganfainberg | i'm amazed a test ran fast enough to fall between ticks | 04:58 |
| jamielennox | so i can only guess at that bug, but i would like him to check his clocks first | 05:00 |
| jamielennox | he says that expiry is UTC+conf.token.expiration and that is correct | 05:00 |
| morganfainberg | jamielennox, it would make sense | 05:01 |
| morganfainberg | so yeah tomorrow going to have him chase down the last few things | 05:01 |
| jamielennox | but if that was an issue in auth_token we would know about it by now | 05:01 |
| morganfainberg | well, perhaps | 05:01 |
| morganfainberg | we just moved default token expiry to 3600 | 05:01 |
| morganfainberg | this release | 05:01 |
| morganfainberg | and most people don't run UTC+1 | 05:02 |
| jamielennox | yea | 05:02 |
| morganfainberg | i'm willing to go the extra distance in this case because of this change. | 05:02 |
| morganfainberg | it could really bite us otherwise | 05:02 |
| jamielennox | by most people you mean the US right | 05:02 |
| morganfainberg | no i mean, a minority of servers i know run TZ aware | 05:03 |
| morganfainberg | most people run servers UTC that i know these days | 05:03 |
| jamielennox | really? didn't know that | 05:03 |
| morganfainberg | except on of my recent companies it's been the standard we've used a lot of places | 05:04 |
| jamielennox | it would definetly solve some problems | 05:04 |
| morganfainberg | it just doesn't make sense to fight DST stuff twice a year | 05:04 |
| morganfainberg | it's why we go so far out of our way to convert everything to UTC in keystone | 05:04 |
| morganfainberg | actuallty.. all over openstack | 05:04 |
| jamielennox | alright, commenting on that bug | 05:05 |
| morganfainberg | but it's much easier to just run servers in UTC | 05:05 |
| morganfainberg | jamielennox, sure thing :) | 05:05 |
| morganfainberg | jamielennox, and forgive his bad bug report, i talked to him before on irc | 05:05 |
| morganfainberg | jamielennox, went over a bunch of stuff and it seems at least based upon the chat a legit edge case | 05:06 |
| jamielennox | morganfainberg: oh, ok - so you did do a clock check on his clients and servers | 05:07 |
| morganfainberg | jamielennox, i think i did | 05:07 |
| morganfainberg | jamielennox, feel free to ask | 05:08 |
| jamielennox | done, but yea i don't think it's a dogpile issue | 05:11 |
| jamielennox | unless you're not serializing the time back and forth correctly | 05:11 |
| *** gokrokve has quit IRC | 05:12 | |
| *** gokrokve has joined #openstack-keystone | 05:12 | |
| jamielennox | which might be possible.... | 05:14 |
| jamielennox | morganfainberg: is it a problem that you use isotime() rather than strtime()? | 05:14 |
| morganfainberg | timeutiles.isotime? | 05:14 |
| jamielennox | yea | 05:15 |
| morganfainberg | timeutils.isotime is strftime | 05:15 |
| morganfainberg | just makes it ISO8601 | 05:15 |
| morganfainberg | https://github.com/openstack/keystone/blob/master/keystone/openstack/common/timeutils.py#L38 | 05:15 |
| jamielennox | just looking at line 41 | 05:16 |
| morganfainberg | hmm | 05:16 |
| morganfainberg | i think we'd have bigger issues if that didn't work | 05:16 |
| jamielennox | just looking at sql - it lets sqlalchemy do the conversion | 05:17 |
| morganfainberg | SQLAlchemy doesn't convert it to a string | 05:17 |
| morganfainberg | well... not exactly | 05:17 |
| *** gokrokve has quit IRC | 05:17 | |
| morganfainberg | i guess maybe it's VARCHAR under the hood in sqlite | 05:18 |
| morganfainberg | jamielennox, hmm. | 05:18 |
| morganfainberg | jamielennox, ok the difference between isotime and strtime, iostime will make UTC tz aware explicitly | 05:19 |
| morganfainberg | well all time tz aware | 05:19 |
| morganfainberg | i think that is much safer | 05:19 |
| morganfainberg | it means we don't worry about one system being UTC and another being UTC+1 | 05:20 |
| morganfainberg | strtime will omit TZ info | 05:20 |
| jamielennox | morganfainberg: it shouldn't matter though, what is returned from create_token is a datetime object | 05:20 |
| morganfainberg | jamielennox, but we json serialize | 05:20 |
| morganfainberg | jamielennox, PKI tokens are not transmitting datetime objects | 05:21 |
| morganfainberg | nor are validate calls | 05:21 |
| jamielennox | yea, but i mean that the serialization won't be different between kvs/sql | 05:21 |
| morganfainberg | it would be in the case of auth_token | 05:21 |
| jamielennox | i was thinking there was some string transition differences there | 05:21 |
| morganfainberg | oh oh yeah | 05:21 |
| morganfainberg | no | 05:21 |
| morganfainberg | should be 100% the same. | 05:21 |
| jamielennox | yea, even if the stored form is different from SQL so long as the in and out are correct it won't matter | 05:22 |
| morganfainberg | and crapola. i lost my vagrant file =/ | 05:22 |
| morganfainberg | and we already know he's using memcache | 05:22 |
| morganfainberg | so, i'm not worried about the SQL server doing something strange | 05:22 |
| morganfainberg | (not that i really was in either case) | 05:22 |
| jamielennox | get_token in kvs *may* be different thogh | 05:23 |
| morganfainberg | looking now | 05:23 |
| morganfainberg | but i think i use the native datetiem object | 05:23 |
| morganfainberg | which in the case of memcache just gets pickeled | 05:23 |
| jamielennox | you don't really do anything - you just return the ref | 05:23 |
| jamielennox | line 75 gets returned | 05:24 |
| morganfainberg | yeah then it's native datetime.datetime() | 05:24 |
| morganfainberg | if that didn't work, we'd have larger issues | 05:24 |
| jamielennox | why? | 05:24 |
| jamielennox | i'm sure you're right just following through | 05:24 |
| morganfainberg | jamielennox, why serialize to str just to deserialize later? | 05:24 |
| morganfainberg | i mean it wouldn't be hard to do it. | 05:25 |
| jamielennox | no thats ok, i see what i was missing there | 05:25 |
| jamielennox | you are letting the dogpile driver do the serialization | 05:25 |
| morganfainberg | yeah. | 05:25 |
| jamielennox | i saw the expires_str = and thought it was you | 05:26 |
| morganfainberg | jamielennox, yeah expires_str is used for the index only | 05:27 |
| jamielennox | ok, was trying to figure that out cause i can't see where it's used again | 05:27 |
| morganfainberg | if you look at the user_index | 05:27 |
| morganfainberg | thats the relevant part | 05:27 |
| jamielennox | but again all this doesn't matter because its a PKI token that won't ever try to retrieve this | 05:27 |
| morganfainberg | exactly | 05:28 |
| jamielennox | also there is way to much replicatoin between the drivers that should be done at a higher leve | 05:28 |
| jamielennox | l | 05:28 |
| morganfainberg | jamielennox, if we can get revoke_api up to snuff, i want these to go away | 05:28 |
| morganfainberg | targeting L for removal of token persistence | 05:28 |
| morganfainberg | K being default to ephermeral tokens | 05:29 |
| jamielennox | oh right, yea i was thinking it coudl be done for K | 05:29 |
| morganfainberg | Juno optionally use ephermeral tokens | 05:29 |
| morganfainberg | i wish :( | 05:29 |
| morganfainberg | but that ship has sailed | 05:29 |
| morganfainberg | *eyes RC barreling down on us* | 05:29 |
| *** gyee has quit IRC | 05:30 | |
| *** gokrokve has joined #openstack-keystone | 05:43 | |
| *** gokrokve has quit IRC | 05:56 | |
| *** wchrisj has quit IRC | 06:02 | |
| *** gokrokve has joined #openstack-keystone | 06:04 | |
| openstackgerrit | Jenkins proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/78525 | 06:07 |
| *** gokrokve has quit IRC | 06:10 | |
| gtt116 | morganfainberg, around? | 06:10 |
| morganfainberg | gtt116, hi | 06:11 |
| gtt116 | morganfainberg, remeber the bug which lots of token can hit the memcache limit? | 06:12 |
| morganfainberg | gtt116, yes | 06:12 |
| gtt116 | morganfainberg, it is here https://bugs.launchpad.net/bugs/1251123 | 06:12 |
| uvirtbot | Launchpad bug 1251123 in keystone/havana "_update_user_list_with_cas causes significant overhead (when using memcached as token store backend)" [Critical,Fix released] | 06:12 |
| morganfainberg | gtt116, yep, did you hit the memcache page size limit? | 06:13 |
| gtt116 | morganfainberg, nope, this time I hit revocation-list hit memcache item limit | 06:13 |
| morganfainberg | gtt116, it's an unfortunate limit of that driver :( | 06:14 |
| gtt116 | morganfainberg, from google, memcache item limit is 1MB, right? | 06:14 |
| morganfainberg | gtt116, it's why we're looking to deprecate it in lieu of using ephemeral tokens (no stable storage needed) | 06:14 |
| morganfainberg | gtt116, by default | 06:14 |
| gtt116 | morganfainberg, so I'm thinking about using more keys to store these tokens | 06:15 |
| gtt116 | morganfainberg, like revocation_key_0, revocation_key_1 .... | 06:15 |
| morganfainberg | gtt116, you can typically increase at start time of memcache, but it increases the slab for all pages (e.g. an element takes more ram) | 06:16 |
| gtt116 | morganfainberg, when hit the limit, we increase the key id | 06:16 |
| morganfainberg | gtt116, that was one solution i was working on at one point | 06:16 |
| morganfainberg | gtt116, but the detection and use of overflow pages was exceptionally complex to do cleanly | 06:17 |
| gtt116 | morganfainberg, yep, but if keystone can tolerate the limit sounds good | 06:17 |
| morganfainberg | gtt116, ideally i want to move to ephemeral tokens (no need to store them or index them) | 06:17 |
| morganfainberg | gtt116, but that wont be for icehouse. | 06:17 |
| gtt116 | morganfainberg, so when that finished, the usage of token will change? | 06:18 |
| morganfainberg | gtt116, when that is finished you wont need to use SQL or memcache or anything to store tokens | 06:18 |
| gtt116 | morganfainberg, cool | 06:19 |
| morganfainberg | gtt116, yeah :) | 06:19 |
| morganfainberg | gtt116, the feature should be ready for Juno for sure | 06:19 |
| gtt116 | morganfainberg, and the user will notice this change? | 06:19 |
| morganfainberg | gtt116, the deployer will need to make some config changed, but it should have no impact on the user | 06:19 |
| morganfainberg | gtt116, and it'll remove all these issues we have w/ the memcache backend (since it wont be used) | 06:19 |
| gtt116 | morganfainberg, lol | 06:20 |
| gtt116 | morganfainberg, but the problem is in I, even in havana | 06:21 |
| gtt116 | morganfainberg, I think a quick fix may help | 06:22 |
| morganfainberg | gtt116, honestly, i recommend no one use memcache for tokens | 06:22 |
| gtt116 | morganfainberg, prefer mysql? | 06:22 |
| morganfainberg | gtt116, it's not a good storage, if you restart the memcache server you lose your revocation list and if that happens any PKI tokens are now valid again until they expire | 06:23 |
| morganfainberg | gtt116, yeah + caching ([cache] section in the keystone.conf) so it still uses memcache. | 06:23 |
| morganfainberg | gtt116, you need to flush expired tokens out semi-regularly, but that iseems to have less issues overall | 06:23 |
| gtt116 | morganfainberg, yeah, that was the reason why we now using memcache | 06:24 |
| gtt116 | morganfainberg, another reason is update the password is really show .. =( | 06:25 |
| morganfainberg | gtt116, because of invalidating the tokens. | 06:25 |
| gtt116 | morganfainberg, yep | 06:25 |
| morganfainberg | gtt116, are you making efforts to re-use tokens? | 06:26 |
| morganfainberg | gtt116, or new token for every action? | 06:26 |
| gtt116 | morganfainberg, in action, no | 06:26 |
| gtt116 | morganfainberg, our users alway create new token if they like | 06:27 |
| morganfainberg | gtt116, hm.. oh can't stop silly users from doing silly things | 06:27 |
| morganfainberg | gtt116, we had (my company) a customer churning ~million tokens a day | 06:27 |
| gtt116 | morganfainberg, excatly! that was the problem | 06:27 |
| morganfainberg | or was it 250k | 06:27 |
| morganfainberg | something absurd | 06:27 |
| gtt116 | morganfainberg, =( | 06:28 |
| morganfainberg | gtt116 are you running keystone under httpd? | 06:28 |
| morganfainberg | or just a single keystone? | 06:28 |
| gtt116 | morganfainberg, just a single keystone | 06:28 |
| morganfainberg | gtt116, if you do a deployment under mod_wsgi it should help a lot overall | 06:28 |
| gtt116 | morganfainberg, but we have two keystone servers behind a haproxy | 06:29 |
| morganfainberg | gtt116, ah thats another way to solve it | 06:29 |
| gtt116 | morganfainberg, but when keystone eating 100% CPU, our system administrator go crazy.. | 06:30 |
| morganfainberg | gtt116, hopefully you're not having that happen as much now. | 06:30 |
| openstackgerrit | A change was merged to openstack/keystone: explicitly import gettext function https://review.openstack.org/81903 | 06:30 |
| gtt116 | morganfainberg, BTW are you using mysql backend? | 06:30 |
| morganfainberg | gtt116, yes | 06:30 |
| morganfainberg | gtt116 we use mysql backend. | 06:30 |
| morganfainberg | gtt116, and we flush un-used tokens once per hour | 06:31 |
| morganfainberg | erm, expired tokens | 06:31 |
| gtt116 | morganfainberg, emm.. by cron? | 06:31 |
| morganfainberg | yeah | 06:31 |
| morganfainberg | maybe we moved it to 15 mins | 06:31 |
| morganfainberg | but we did something via cron | 06:31 |
| morganfainberg | i'd need to look at the specific interval | 06:31 |
| morganfainberg | let me check on something for you really quickly i might have a solution that could help | 06:31 |
| gtt116 | morganfainberg, ok, thanks very much! | 06:32 |
| morganfainberg | but i want to check before making the recommendation | 06:32 |
| gtt116 | morganfainberg, =) | 06:33 |
| *** daneyon has quit IRC | 06:34 | |
| *** rwsu has joined #openstack-keystone | 06:35 | |
| morganfainberg | need to rebuild my vagrant vm first | 06:35 |
| morganfainberg | gtt116, i think we can make some of the revocation logic better (and backport that) | 06:45 |
| morganfainberg | gtt116, running my test now. | 06:45 |
| gtt116 | morganfainberg, this is a good news | 06:45 |
| gtt116 | morganfainberg, compressing the token object? | 06:47 |
| morganfainberg | gtt116, nope using a different kvs backend | 06:47 |
| morganfainberg | gtt116 instead of using memcache | 06:47 |
| gtt116 | morganfainberg, emm.. but we have two keystone servers | 06:48 |
| morganfainberg | gtt116, the new KVS system supports more than memcache :) | 06:48 |
| morganfainberg | would work the same | 06:48 |
| gtt116 | morganfainberg, you mean the KVS logic is better than raw memcache backend? right? | 06:49 |
| morganfainberg | gtt116, KVS system is based on dogpile.cache | 06:49 |
| morganfainberg | so you can use a number of options such as memcache, redis, (in icehouse mongodb) | 06:50 |
| gtt116 | morganfainberg, havana already has KVS system? | 06:50 |
| morganfainberg | gtt116, oooh no | 06:51 |
| morganfainberg | gtt116, doh! | 06:51 |
| morganfainberg | gtt116, sorry :( | 06:51 |
| gtt116 | morganfainberg, oh! that is great, let me do some investigation | 06:51 |
| morganfainberg | gtt116, KVS is new in icehouse | 06:51 |
| morganfainberg | gtt116, but i did just confirm i have a list w/ 100k tokens in it | 06:52 |
| morganfainberg | gtt116, it's not speedy, but it doesn't have the same memcache limit issue | 06:52 |
| gtt116 | morganfainberg, is it easy backport to havana? | 06:52 |
| morganfainberg | gtt116, i'll mull over how to make this better, but honestly it's a tough nut to crack | 06:52 |
| gtt116 | morganfainberg, I means in our private repo | 06:52 |
| morganfainberg | gtt116 the KVS system? no. | 06:52 |
| morganfainberg | gtt116 it is a large restructure of a number of things | 06:53 |
| openstackgerrit | A change was merged to openstack/keystone: Comparisons should account for instantaneous test execution https://review.openstack.org/81879 | 06:53 |
| gtt116 | morganfainberg, =< | 06:53 |
| morganfainberg | gtt116, we are looking at supporting compressed tokens (again juno timeline) | 06:53 |
| morganfainberg | gtt116, i'll see if i can figure out something interesting to help you out. might take me a bit to mull on this. | 06:54 |
| morganfainberg | gtt116, not sure how much using multiple pages will help, eventually you'll spend a lot of time collecting the pages and putting them into memory | 06:55 |
| morganfainberg | gtt116, the real long term solution will be to stop storing tokens | 06:55 |
| gtt116 | morganfainberg, yep, yep | 06:55 |
| gtt116 | morganfainberg, please let me know if I can do something | 06:56 |
| morganfainberg | gtt116, will do. | 06:56 |
| gtt116 | morganfainberg, thank you again =) | 06:56 |
| morganfainberg | gtt116, sure thing. :) | 06:56 |
| morganfainberg | gtt116, i just wish i could say Icehouse had all the fixes... though if we're lucky the ephemeral token work will be easy for you to backport | 06:57 |
| morganfainberg | gtt116, to icehouse that is. | 06:57 |
| morganfainberg | gtt116, but by then hopefiully you'll be upgraded :) | 06:57 |
| gtt116 | morganfainberg, yeah, if it is indeed, we have to upgrade to IceHouse. | 06:58 |
| morganfainberg | gtt116, anyway, it's late here. | 07:01 |
| morganfainberg | gtt116, i need to go. | 07:01 |
| gtt116 | morganfainberg, ok bye :) | 07:01 |
| gtt116 | morganfainberg, good night | 07:01 |
| morganfainberg | just as a quick check, i'm seeing no problem w/ 448000 bytes in a single redis key | 07:02 |
| morganfainberg | erm | 07:03 |
| morganfainberg | ~680k | 07:04 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Don't use a connection pool unless provided https://review.openstack.org/82007 | 07:05 |
| *** gokrokve has joined #openstack-keystone | 07:06 | |
| morganfainberg | yeah redis scales better | 07:06 |
| morganfainberg | up to 2MB in a single key and it def is slowing down, but still is better | 07:06 |
| morganfainberg | this would be a cpu grind. | 07:07 |
| morganfainberg | anyway | 07:07 |
| morganfainberg | night | 07:07 |
| *** gokrokve has quit IRC | 07:10 | |
| *** jamielennox is now known as jamielennox|away | 07:12 | |
| *** henrynash has joined #openstack-keystone | 07:39 | |
| openstackgerrit | A change was merged to openstack/keystone: expires_at should be in a tuple not turned into one https://review.openstack.org/81894 | 07:42 |
| openstackgerrit | A change was merged to openstack/keystone: Filter LDAP dumb member when listing role assignments https://review.openstack.org/73935 | 07:42 |
| *** henrynash has quit IRC | 07:44 | |
| *** gokrokve has joined #openstack-keystone | 08:05 | |
| *** flaper87|afk is now known as flaper87 | 08:07 | |
| *** gokrokve has quit IRC | 08:09 | |
| openstackgerrit | A change was merged to openstack/keystone: Make domain_id immutable by default https://review.openstack.org/81499 | 08:22 |
| *** gokrokve has joined #openstack-keystone | 09:05 | |
| openstackgerrit | wanghong proposed a change to openstack/python-keystoneclient: use v3 api to get certificates https://review.openstack.org/82032 | 09:06 |
| *** bvandenh has quit IRC | 09:08 | |
| *** gokrokve has quit IRC | 09:10 | |
| *** bvandenh has joined #openstack-keystone | 09:13 | |
| *** leseb has joined #openstack-keystone | 09:13 | |
| *** henrynash has joined #openstack-keystone | 09:17 | |
| *** andreaf has joined #openstack-keystone | 09:18 | |
| *** YorikSar_ has joined #openstack-keystone | 09:29 | |
| *** YorikSar has quit IRC | 09:32 | |
| *** morganfainberg is now known as morganfainberg_Z | 09:48 | |
| *** saju_m has joined #openstack-keystone | 09:55 | |
| *** david-lyle has quit IRC | 10:05 | |
| *** gokrokve has joined #openstack-keystone | 10:06 | |
| *** gokrokve has quit IRC | 10:10 | |
| *** YorikSar_ has quit IRC | 10:30 | |
| *** YorikSar has joined #openstack-keystone | 10:31 | |
| *** fabiomorais has quit IRC | 11:03 | |
| *** gokrokve has joined #openstack-keystone | 11:07 | |
| *** gokrokve has quit IRC | 11:11 | |
| *** saju_m has quit IRC | 11:22 | |
| *** leseb has quit IRC | 11:24 | |
| *** leseb has joined #openstack-keystone | 11:25 | |
| *** leseb has quit IRC | 11:29 | |
| *** saju_m has joined #openstack-keystone | 11:38 | |
| *** gokrokve has joined #openstack-keystone | 12:07 | |
| *** gokrokve has quit IRC | 12:12 | |
| *** leseb has joined #openstack-keystone | 12:25 | |
| *** leseb has quit IRC | 12:29 | |
| dstanek | dolphm: i've been slow to approve reviews and are not directly bugs targeted at RC1 - is it OK to +A this one https://review.openstack.org/#/c/81720/? | 12:38 |
| *** dims has quit IRC | 12:41 | |
| *** jagee_ has joined #openstack-keystone | 12:42 | |
| *** dims has joined #openstack-keystone | 12:48 | |
| *** saju_m has quit IRC | 12:57 | |
| dolphm | dstanek: that one seems fine, but with the gate failure in the patch it's dependent on, i'm not sure it will/should land? | 12:59 |
| dolphm | dstanek: it looks like a transient failure in https://review.openstack.org/#/c/65870/ - if so, we definitely shouldn't be introducing that risk right nwo | 13:00 |
| dolphm | dstanek: unless something else landed 12:30am and 4:38am today that would have caused that... | 13:01 |
| dstanek | dolphm: https://review.openstack.org/73935 maybe | 13:01 |
| dolphm | dstanek: hmm... definitely suspect | 13:03 |
| dstanek | looking at the code I can't see how it would cause that failure, but the title make me wonder | 13:03 |
| ayoung | dstanek, I think that "instantiate once and only once" is the correct semantics for managers. It was not when they were origianlly written. | 13:04 |
| dstanek | ayoung: i mostly agree, but in tests i'd really like to create them without DI | 13:05 |
| dolphm | dstanek: i've run morgan's patch rebased onto master a few times, and haven't been able to repro the failure in jenkins (yet) | 13:05 |
| ayoung | dstanek, I don't think that is practicable for all tests. It should be the case for simple unit tests though | 13:05 |
| ayoung | dstanek, in fact, that might be the litmus test for "uni tests" if the manager can be directly instatiated | 13:06 |
| dstanek | dolphm: that's the problem with parallel anything :-( | 13:06 |
| dolphm | dstanek: yeah... hence my paranoia landing it now :( | 13:06 |
| ayoung | dumb member only gets tested against fake LDAP, would highly doubt that would cause an intermittent | 13:07 |
| dolphm | dstanek: i'm just running tox -e py27 test_backend_ldap though | 13:07 |
| *** saju_m has joined #openstack-keystone | 13:07 | |
| dolphm | ayoung: it looks like there's a race to me though | 13:07 |
| ayoung | where? | 13:07 |
| dolphm | ayoung: http://logs.openstack.org/70/65870/8/check/gate-keystone-python27/60bbe04/console.html | 13:07 |
| dolphm | shit | 13:08 |
| dolphm | repro'd on sixth run | 13:08 |
| *** gokrokve has joined #openstack-keystone | 13:08 | |
| ayoung | "keystone/tests/test_backend_ldap.py", line 1389, in setUp | 13:09 |
| ayoung | dolphm, the fact that the cert stuff is mixed in with the stack trace indicates that we don't do multithreaded logging well | 13:10 |
| dolphm | ayoung: ++ | 13:11 |
| dolphm | ayoung: dstanek: -2'ing the parallel patch until juno :( | 13:11 |
| dstanek | dolphm: that's the right thing to do | 13:11 |
| ayoung | ++ | 13:12 |
| dolphm | dstanek: i imagine the subsequent patch could be rebased onto master itself? | 13:12 |
| dstanek | we should rework it to enable running in parallel so that more of us can start using parallel tests daily an look for these issues | 13:12 |
| dolphm | dstanek: the one you wanted to approve | 13:12 |
| ayoung | dolphm, was the stack trace in your last repro in the same place? | 13:12 |
| dolphm | dstanek: i.e. land it now with parallel disabled by default? | 13:12 |
| *** gokrokve has quit IRC | 13:13 | |
| ayoung | dolphm, dstanek yeah, disabled by default | 13:13 |
| dstanek | dolphm: right | 13:13 |
| dolphm | ayoung: this is my local log http://paste.openstack.org/raw/73993/ | 13:14 |
| ayoung | dolphm, same point | 13:15 |
| ayoung | File "keystone/common/ldap/core.py", line 240, in get_connection | 13:15 |
| ayoung | chase_referrals=self.chase_referrals) is triggering | 13:15 |
| ayoung | UnexpectedMethodCallError: Unexpected method call FakeLdap.__call__('fake://memory', 0, alias_dereferencing=None, chase_referrals=None, tls_cacertdir=None, tls_cacertfile=None, tls_req_cert=2, use_tls=False) -> None | 13:15 |
| ayoung | dolphm, github is not responding to my web request right now, so I can't post the link, but to me it looks like that is a call to | 13:16 |
| ayoung | user = self.LDAP_USER | 13:16 |
| ayoung | that is what I have on line 240...don't think I have any local changes to that patch that won't match master | 13:16 |
| ayoung | dolphm, can you confirm that your line 240 is the same? | 13:23 |
| *** joesavak has joined #openstack-keystone | 13:24 | |
| ayoung | ah, no | 13:24 |
| ayoung | just got a rebase through | 13:24 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: update sample conf https://review.openstack.org/82090 | 13:24 |
| ayoung | dolphm, its two lines up... | 13:24 |
| *** bknudson has joined #openstack-keystone | 13:25 | |
| *** leseb has joined #openstack-keystone | 13:26 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: update sample conf https://review.openstack.org/82090 | 13:26 |
| ayoung | dolphm, are you autogenerating those changes? | 13:26 |
| dolphm | ayoung: this one - yes. i was having trouble with the config generator before | 13:27 |
| dolphm | ayoung: also http://git.openstack.org/cgit/openstack/keystone/tree/keystone | 13:27 |
| dolphm | ayoung: instead of github ^ | 13:27 |
| ayoung | dolphm, excellent. | 13:27 |
| dolphm | ayoung: this patch fixes my own stupid when i was having trouble with generate_sample_conf.sh https://review.openstack.org/#/c/82090/ | 13:28 |
| *** leseb has quit IRC | 13:30 | |
| ayoung | dolphm, so the above problem doesn't happen everytime? Just 1 in 6? | 13:42 |
| ayoung | and just with parallel? | 13:43 |
| dolphm | ayoung: i believe so | 13:43 |
| *** vhoward has joined #openstack-keystone | 13:43 | |
| ayoung | dolphm, my understanging then, is that setup is being called on a random test, but the backend for that test has been set to LDAP instead of whatever it was expecting, and with mock in there. Mock is expecting one call, and getting another. This means that the parallel test runs are happening in the same process, and I think that is a mistake | 13:45 |
| dstanek | i've tried at least 6 run without parallel and haven't reprod yet | 13:45 |
| *** marekd|away is now known as marekd | 13:52 | |
| dolphm | anyone know if yuriy has an update in the works for this? https://review.openstack.org/#/c/81235/ | 13:59 |
| dolphm | wondering if i should post a revision | 14:00 |
| *** wchrisj has joined #openstack-keystone | 14:00 | |
| ayoung | dolphm, I've got one, I'm tox ing now | 14:00 |
| dolphm | ayoung: awesome | 14:00 |
| dolphm | YorikSar: didn't realize you were in the channel! yu<tab> did not produce the success i was expecting :P | 14:01 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Cleanup config.py https://review.openstack.org/81671 | 14:03 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Clean up config help text https://review.openstack.org/78497 | 14:03 |
| *** leseb has joined #openstack-keystone | 14:04 | |
| dstanek | i see no luck yesterday on the token expiration issue - morganfainberg_Z couldn't reproduce on devstack? | 14:06 |
| *** gokrokve has joined #openstack-keystone | 14:09 | |
| *** gokrokve has quit IRC | 14:13 | |
| dolphm | dstanek: https://bugs.launchpad.net/keystone/+bug/1294862 ? | 14:19 |
| uvirtbot | Launchpad bug 1294862 in keystone "Token expiration time with memcache->kvs->dogpile is wrong" [Medium,Incomplete] | 14:19 |
| dstanek | dolphm: yeah | 14:19 |
| dstanek | looks like maybe just a deployment issue with clocks reporting the wrong time? | 14:20 |
| dolphm | dstanek: i can't even guess :( hopefully that's the case | 14:20 |
| dolphm | dstanek: if it's the last standing RC-blocker and it's still incomplete, then we'll cut an RC without addressing it | 14:21 |
| dstanek | i'll be out of the office for a few hours starting soon | 14:22 |
| dolphm | dstanek: rubber stamp this one before you go :P https://review.openstack.org/#/c/82090/ | 14:22 |
| *** joesavak has quit IRC | 14:23 | |
| *** joesavak has joined #openstack-keystone | 14:24 | |
| dstanek | done. pretty small diff | 14:24 |
| *** jsavak has joined #openstack-keystone | 14:25 | |
| dstanek | this there a target for cutting the release? | 14:26 |
| *** joesavak has quit IRC | 14:28 | |
| dolphm | dstanek: ASAP / when it's ready | 14:31 |
| dolphm | dstanek: we'll wait for a good 24 hours or so of no alarming bug reports and then make the cut | 14:31 |
| dolphm | dstanek: here's the overall race to RC-readyness: http://old-wiki.openstack.org/rc/ | 14:32 |
| openstackgerrit | ayoung proposed a change to openstack/keystone: is_revoked check all viable subtrees https://review.openstack.org/81235 | 14:32 |
| ayoung | dolphm, gerrit needs an option: when diffing two versions of a patch to only show lines from files in either patch | 14:33 |
| dolphm | ayoung: i just flip back and forth between two tabs- the last patchset with comments and the latest patchset | 14:36 |
| dolphm | ayoung: and sort of manually diff | 14:36 |
| YorikSar | dolphm: Yeah, I'm somewhere around. | 14:36 |
| YorikSar | dolphm: Did I miss something? | 14:36 |
| dolphm | YorikSar: ayoung just posted a patchset to https://review.openstack.org/#/c/81235/ | 14:36 |
| dolphm | ayoung: in this case it seems you changed for more than the comments asked for, so there's not much use in comparing against a previous version -- must review from scratch! | 14:38 |
| *** david-lyle has joined #openstack-keystone | 14:38 | |
| YorikSar | ayoung: Some time ago I actually did smth like vimdiff <(git diff onepatch~..onepatch) <(git diff otherpatch~..otherpatch) | 14:40 |
| YorikSar | ayoung: And it even did get me something useful :) | 14:40 |
| YorikSar | dolphm, ayoung: It looks like there's not much changes compared to what we've discussed some time ago. | 14:41 |
| dolphm | YorikSar: i wasn't deeply involved in that conversation though, so i don't have much context to review from | 14:41 |
| dolphm | ... for better or worse | 14:42 |
| *** browne has joined #openstack-keystone | 14:42 | |
| dstanek | YorikSar: that's a good idea | 14:43 |
| openstackgerrit | A change was merged to openstack/keystone: Do not expose internal data on UnexpectedError https://review.openstack.org/81385 | 14:43 |
| *** daneyon has joined #openstack-keystone | 14:44 | |
| *** thedodd has joined #openstack-keystone | 14:45 | |
| dstanek | alrighty, i'm targeting being back online between 3 and 4 PM EST. | 14:47 |
| dstanek | dolphm: why is that the old wiki? | 14:47 |
| *** jaosorior has joined #openstack-keystone | 14:47 | |
| *** raildo has joined #openstack-keystone | 14:47 | |
| dstanek | dolphm: there looks to be some interesting stuff there still | 14:47 |
| ayoung | YorikSar, you can do that with gitreview , too | 14:48 |
| ayoung | just that when you upload to the website, sometime you want to do a quick visual and the current UI doens't make it easy | 14:48 |
| ayoung | YorikSar, this is the real diff between your version and my latest https://review.openstack.org/#/c/81235/2..4/keystone/contrib/revoke/model.py | 14:52 |
| *** zhiyan is now known as zhiyan_ | 14:52 | |
| *** dstanek has quit IRC | 14:53 | |
| ayoung | YorikSar, yeah. I think my main objection to the filter was due to the effects I was seeing in the debugger. I still don't like that looking at the result changes what happens under the covers | 14:57 |
| ayoung | I'm sure there is a cleaner way to say "append only if there is something to append" | 14:58 |
| ayoung | but all the alternatives seem equally obtuse | 14:58 |
| *** joesavak has joined #openstack-keystone | 15:01 | |
| *** jsavak has quit IRC | 15:04 | |
| ayoung | YorikSar, anyway, +1 it if you approve of the changes, please | 15:04 |
| *** saju_m has quit IRC | 15:05 | |
| *** dstanek has joined #openstack-keystone | 15:07 | |
| YorikSar | ayoung: Here you go. | 15:10 |
| *** gokrokve has joined #openstack-keystone | 15:10 | |
| *** gokrokve has quit IRC | 15:14 | |
| *** gokrokve has joined #openstack-keystone | 15:15 | |
| ayoung | YorikSar, I'm going to make some changes from dolphm 's review | 15:19 |
| dolphm | ayoung: if you want to use filter(), then i think you must use lambda x: x is not None? | 15:19 |
| ayoung | dolphm, Seems like the worst of both worlds: Filter and a function call | 15:21 |
| ayoung | and don't think it is necessary | 15:21 |
| dolphm | ayoung: get it correct, then optimize | 15:21 |
| ayoung | filter(None, ['a', '', True, False, 1, 0, None]) as you point out, removes the Falsy values | 15:21 |
| ayoung | the nodes we are adding to bundle are lists. If they are empty, it would actually be correct to remove them | 15:22 |
| ayoung | but I am pretty sure we never add even an empty list | 15:22 |
| ayoung | actually, the are dictionsaris, but still | 15:22 |
| ayoung | dolphm, agreed on "get it right then optimize" but pretty sure this is right | 15:24 |
| *** devlaps has joined #openstack-keystone | 15:29 | |
| *** david-lyle has quit IRC | 15:29 | |
| YorikSar | dolphm: We have concrete data model. All these dicts can contain only other dicts. | 15:33 |
| dolphm | YorikSar: how is that concrete? lol | 15:34 |
| YorikSar | dolphm: So replacing it with lambda won't give any profit neither from code readability side nor from performance side. | 15:34 |
| *** mlemay has joined #openstack-keystone | 15:34 | |
| *** dstanek has quit IRC | 15:34 | |
| dolphm | YorikSar: so just use an explicit list comprehension? [x for x in bundle if x is not None] | 15:34 |
| YorikSar | dolphm: It's no different from filter with lambda... | 15:35 |
| dolphm | YorikSar: it's explicit and behaves differently | 15:36 |
| YorikSar | dolphm: btw, that filter will exclude empty dicts as well and those are of no use to us. | 15:36 |
| dolphm | YorikSar: if you want to write a test that would make filter()'s behavior more useful than something more verbose, then by all means do so | 15:38 |
| dolphm | YorikSar: until then, we need to be in the business of not writing surprising code, especially when it conflicts with the inline comment describing it, because that will only result in bugs in the future | 15:39 |
| openstackgerrit | ayoung proposed a change to openstack/keystone: is_revoked check all viable subtrees https://review.openstack.org/81235 | 15:39 |
| YorikSar | dolphm: Ok. Don't see a point in arguing about it. | 15:40 |
| ayoung | YorikSar, I had actually replaced the filter with that exact code when I was debugging | 15:46 |
| ayoung | so...I can support it. | 15:46 |
| ayoung | YorikSar, this code is dense, and hard for people to understand. The easier we can make it to seee what is going on, the less likely someone will feel the need to rewrite it once we've moved on to other projects | 15:47 |
| ayoung | YorikSar, I'm making that change and resubmitting. OK? | 15:47 |
| YorikSar | ayoung: Sure. | 15:47 |
| YorikSar | ayoung: I just wonder how much will my original code morph in the direction of "slow and not pretty" before it finally can be read by everyone. | 15:49 |
| ayoung | YorikSar, when we get this done, and moved over to the client, and used in place of the current revocation list, the performance benefit will far outweigh any slight slowdown to the native call | 15:50 |
| ayoung | YorikSar, to real ugliness is in appending the None's to the collection. I suspect that setting those to a local variable and only adding if it is not None would be even more performant | 15:51 |
| ayoung | the filter(None syntax is awkward. | 15:52 |
| YorikSar | ayoung: I don't have a benchmark in my pocket but I think that doing filter(None, ...) is faster than adding lots of if's. | 15:53 |
| YorikSar | ayoung: Just because of less bytecode and more native methods. | 15:53 |
| ayoung | YorikSar, I suspect you are wrong. Its not the ifs that are slow, it is the append(None) | 15:53 |
| YorikSar | ayoung: Ah... I don't want to benchmark it anyway. At least not now. | 15:54 |
| ayoung | YorikSar, http://c2.com/cgi/wiki?PrematureOptimization | 15:55 |
| YorikSar | ayoung: I have other, more pleasing thing to benchmark - rootwrap daemon :) | 15:55 |
| ayoung | ++ | 15:55 |
| ayoung | YorikSar, WTF do we have rootwrap anyways? | 15:56 |
| YorikSar | Although Keystone won't get any benefit from that. | 15:56 |
| ayoung | YorikSar, cuz we are smart enough not to use it! | 15:56 |
| YorikSar | ayoung: Keystone just doesn't need it ;) | 15:56 |
| YorikSar | ayoung: Unfortunatelly all low-level components do. | 15:57 |
| ayoung | YorikSar, rootwrap is one of those things that, each time it comes up, I get shivers and think "If you don't look closely at it, people won't blame you for it." | 15:57 |
| ayoung | YorikSar, I've seen how the Rest of OpenStack treat security. And it has encouraged me to increase my alcohol consumption. | 15:58 |
| YorikSar | I'm currently migrating to other department and will have more time (all of it) to spend on community tasks. So I hope to start fixing such things like rootwrap (its slowness and insecure use). | 15:59 |
| ayoung | YorikSar, ++ lets talk in Atlanta | 16:00 |
| YorikSar | ayoung: I won't be there | 16:00 |
| ayoung | YorikSar, is there a list of what people use rootwrap to do? | 16:00 |
| ayoung | :( | 16:00 |
| ayoung | YorikSar, that is unfortunate | 16:00 |
| YorikSar | ayoung: I'm purely remote contributor :) | 16:00 |
| openstackgerrit | ayoung proposed a change to openstack/keystone: is_revoked check all viable subtrees https://review.openstack.org/81235 | 16:01 |
| *** gyee has joined #openstack-keystone | 16:01 | |
| *** david-lyle has joined #openstack-keystone | 16:02 | |
| *** dstanek has joined #openstack-keystone | 16:05 | |
| *** marcoemorais has joined #openstack-keystone | 16:06 | |
| YorikSar | ayoung: It is in every project's filters.d dir. | 16:07 |
| ayoung | http://git.openstack.org/cgit/openstack/nova/tree/etc/nova/rootwrap.d YorikSar | 16:08 |
| YorikSar | ayoung: And those should be carefully audited. | 16:08 |
| YorikSar | ayoung: Yeah... And there's a lot of plain CommandFilter's | 16:09 |
| ayoung | YorikSar, I'm going to stop looking. Its not something I can affect at this point, and getting worked up about it will do me no good. | 16:10 |
| *** andreaf has quit IRC | 16:10 | |
| *** dstanek has quit IRC | 16:18 | |
| *** jsavak has joined #openstack-keystone | 16:29 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Sync test_migrations https://review.openstack.org/80618 | 16:30 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Comparision of database models and migrations. https://review.openstack.org/80630 | 16:30 |
| *** mlemay has quit IRC | 16:32 | |
| *** joesavak has quit IRC | 16:32 | |
| *** richm has joined #openstack-keystone | 16:32 | |
| gyee | ayoung, jamielennox, is this for the use case where we will not be maintaining a global user_id? https://review.openstack.org/#/c/81973 | 16:33 |
| *** anteaya is now known as cyan | 16:36 | |
| *** cyan is now known as Guest20064 | 16:36 | |
| *** Guest20064 is now known as anteaya-who-was- | 16:37 | |
| *** anteaya-who-was- is now known as anteaya | 16:37 | |
| *** gokrokve has quit IRC | 16:38 | |
| *** gokrokve has joined #openstack-keystone | 16:38 | |
| *** jogo is now known as flashgordon | 16:39 | |
| openstackgerrit | A change was merged to openstack/keystone: update sample conf https://review.openstack.org/82090 | 16:42 |
| *** gokrokve has quit IRC | 16:42 | |
| *** marcoemorais1 has joined #openstack-keystone | 16:46 | |
| *** marcoemorais1 has quit IRC | 16:46 | |
| *** marcoemorais has quit IRC | 16:48 | |
| *** browne has quit IRC | 16:48 | |
| *** prad has joined #openstack-keystone | 16:49 | |
| *** prad has left #openstack-keystone | 16:49 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Sync test_migrations https://review.openstack.org/80618 | 16:54 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Comparision of database models and migrations. https://review.openstack.org/80630 | 16:54 |
| *** marcoemorais has joined #openstack-keystone | 16:59 | |
| bknudson | I'm going to propose for juno that we don't take sync of modules, only all openstack-incubator | 16:59 |
| bknudson | oslo-incubator | 16:59 |
| openstackgerrit | ayoung proposed a change to openstack/keystone: Remember the DN https://review.openstack.org/47441 | 17:00 |
| dolphm | jamielennox|away: ping me when you get in | 17:00 |
| *** gokrokve has joined #openstack-keystone | 17:06 | |
| *** YorikSar has quit IRC | 17:06 | |
| *** david_lyle_ has joined #openstack-keystone | 17:07 | |
| *** david-lyle has quit IRC | 17:09 | |
| *** gokrokve_ has joined #openstack-keystone | 17:09 | |
| gyee | dolphm, do you recall why auth_token middleware store the token information in the headers as oppose to the request environment? | 17:09 |
| dolphm | gyee: you mean why they appear as HTTP headers in the cgi/wsgi environment, rather than as python objects in the cgi/wsgi environment? | 17:10 |
| gyee | right | 17:10 |
| gyee | that design was way before I got involved in Keystone | 17:11 |
| dolphm | gyee: for backwards-compatibility with the approach taken by auth_token's predecessor(s) -- so that it could be used as a drop-in replacement | 17:11 |
| *** gokrokve has quit IRC | 17:11 | |
| *** browne has joined #openstack-keystone | 17:11 | |
| gyee | ahh | 17:11 |
| dolphm | gyee: for bonus points, it means that auth can be done by something else entirely -- there's no expectation in auth_token's contract that it actually be implemented in python | 17:12 |
| gyee | dolphm, got it, thanks :) | 17:12 |
| *** gokrokve has joined #openstack-keystone | 17:12 | |
| dolphm | gyee: or it could be in python but not be in the same wsgi pipeline, etc | 17:13 |
| *** leseb has quit IRC | 17:13 | |
| gyee | dolphm, yeah, I was think from that angle | 17:13 |
| gyee | I mean I wasn't | 17:13 |
| *** gokrokve_ has quit IRC | 17:14 | |
| gyee | dolphm, I am trying to improve the performance of ec2 -> auth_token | 17:14 |
| gyee | today ec2 sets the token in X-Auth-Token header, then auth_token validates again | 17:15 |
| gyee | trying to figure out if we can do this in one go | 17:15 |
| gyee | but auth_token clears the token info headers everytime | 17:15 |
| *** leseb has joined #openstack-keystone | 17:16 | |
| gyee | if we don't stash to token info in the headers to solution would be much simpler | 17:17 |
| gyee | s/to/the/ | 17:17 |
| *** thedodd has quit IRC | 17:26 | |
| *** leseb has quit IRC | 17:29 | |
| *** leseb has joined #openstack-keystone | 17:29 | |
| *** joesavak has joined #openstack-keystone | 17:31 | |
| *** leseb has quit IRC | 17:33 | |
| *** jsavak has quit IRC | 17:33 | |
| *** saju_m has joined #openstack-keystone | 17:39 | |
| *** marekd is now known as marekd|away | 17:44 | |
| *** YorikSar has joined #openstack-keystone | 17:45 | |
| *** saju_m has quit IRC | 17:58 | |
| *** leseb has joined #openstack-keystone | 17:59 | |
| *** leseb has quit IRC | 18:05 | |
| *** amcrn has joined #openstack-keystone | 18:09 | |
| *** thedodd has joined #openstack-keystone | 18:10 | |
| *** morganfainberg_Z is now known as morganfainberg | 18:11 | |
| morganfainberg | dolphm, doh, parallel transient?! | 18:12 |
| morganfainberg | dolphm, ah well | 18:12 |
| dolphm | morganfainberg: dstanek/ayoung suggested we land it anyway with it disabled | 18:13 |
| dolphm | morganfainberg: by default | 18:13 |
| morganfainberg | dolphm, thats an easy fix | 18:13 |
| dolphm | morganfainberg: ++ i'm good with that if you want to rev | 18:13 |
| ayoung | morganfainberg, yeah, I want people to be able to easily beat on it | 18:13 |
| *** leseb has joined #openstack-keystone | 18:13 | |
| morganfainberg | just make the echo line return a 1 instead | 18:13 |
| morganfainberg | of 0 | 18:13 |
| morganfainberg | dolphm, adding that in now | 18:14 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add support for parallel testr workers in Keystone https://review.openstack.org/65870 | 18:16 |
| morganfainberg | dolphm, ^ should run 1 worker unless you set TEST_RUN_CONCURRENCY to 0 (1 per core) or N for N workers | 18:17 |
| *** YorikSar has quit IRC | 18:17 | |
| *** leseb has quit IRC | 18:17 | |
| dolphm | morganfainberg: bknudson: +2 | 18:18 |
| dolphm | ayoung: ^ | 18:18 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/python-keystoneclient: add pooling for cache references https://review.openstack.org/81078 | 18:18 |
| *** YorikSar has joined #openstack-keystone | 18:18 | |
| ayoung | gah, read that wrong | 18:20 |
| ayoung | thought it had already made it through check | 18:21 |
| ayoung | just dropping the +A will stop it, right? | 18:21 |
| morganfainberg | ayoung, it wont go to gate untiul check is done | 18:21 |
| ayoung | ++ | 18:21 |
| morganfainberg | ayoung, gate doesn't let that happen anymore | 18:21 |
| ayoung | whew | 18:21 |
| morganfainberg | ayoung, usually i am adverse to pre-empting gate still, but it is useful for getting things moving over night | 18:22 |
| ayoung | morganfainberg, so... | 18:22 |
| morganfainberg | i'm going to see if i can get that failure to occur (transient) so we can smash it. | 18:22 |
| morganfainberg | once i reconstruct my VM. | 18:22 |
| * ayoung needs to add you to adraft | 18:22 | |
| morganfainberg | ayoung, ok | 18:22 |
| ayoung | https://review.openstack.org/#/c/79411/ | 18:23 |
| ayoung | morganfainberg, I'm working on that ^^...I'm going to post a nother version that is slightly ahead | 18:23 |
| ayoung | I need this for compressed tokens | 18:23 |
| morganfainberg | ayoung, oh yeah | 18:24 |
| ayoung | morganfainberg, so version 2 shows one that runs in Python33 (at least the unit tests) | 18:24 |
| morganfainberg | ayoung, thats a good start! | 18:25 |
| ayoung | I know I need to use six somehow...can you shorten the learning curve for me here? | 18:25 |
| ayoung | this version fails on 27 with | 18:25 |
| morganfainberg | hehe sure | 18:25 |
| ayoung | File "keystoneclient/common/cms.py", line 109, in cms_verify | 18:25 |
| ayoung | data = bytes(formatted, 'UTF-8') | 18:25 |
| ayoung | TypeError: str() takes at most 1 argument (2 given) | 18:25 |
| ayoung | I thought it was safe_encode? | 18:26 |
| *** amcrn has quit IRC | 18:27 | |
| ayoung | but that is, I think, now redundant here | 18:27 |
| morganfainberg | hmm. | 18:28 |
| ayoung | and, in fact, I can safely remove it on line 108 now | 18:28 |
| morganfainberg | ayoung, realized i don't have py33 on my laptop | 18:29 |
| ayoung | morganfainberg, heh | 18:29 |
| morganfainberg | give me a sec | 18:29 |
| morganfainberg | setting it up | 18:29 |
| morganfainberg | this weekend i'm going to bootcamp up this lapto w/ a native linux boot to help w/ some of this stuff | 18:30 |
| ayoung | the bytes(formatted,'utf-8') looks like it is just a str() call in py27 | 18:30 |
| morganfainberg | ayoung, binary_type in py27 is str() | 18:30 |
| ayoung | so there needs to be a six call to wrap bytes | 18:30 |
| dolphm | ayoung: six.text_type? | 18:30 |
| dolphm | ayoung: oh i see nevermind | 18:31 |
| ayoung | dolphm, yeah, the opposite | 18:31 |
| morganfainberg | dolphm, that would be the equivalent of unicode in py27 | 18:31 |
| ayoung | something that produces str on 27 but bytes on 33 | 18:31 |
| dolphm | ayoung: 27 has bytes() though, right? | 18:31 |
| dolphm | bytearray() ? | 18:31 |
| morganfainberg | dolphm, bytes = str in py27 | 18:32 |
| ayoung | dolphm, yeah, it just doesn't take the 'utf-8' param | 18:32 |
| dolphm | ayoung: bytearray(formatted, encoding='utf-8') ? | 18:32 |
| ayoung | http://pythonhosted.org//six/#six.b | 18:33 |
| ayoung | but that is latin | 18:33 |
| ayoung | dolphm, trying your suggestion | 18:33 |
| morganfainberg | ayoung, you might need to do if six.PY3 | 18:33 |
| dolphm | ayoung: http://pythonhosted.org//six/#six.binary_type | 18:33 |
| morganfainberg | ayoung, and just handle it differently | 18:33 |
| morganfainberg | dolphm, except encoding works differently (i think) in py33 vs py27 | 18:34 |
| morganfainberg | str().encode vs bytes(str, encoding) | 18:34 |
| ayoung | dolphm, I think that bytearray(formatted, encoding='utf-8') worked | 18:35 |
| morganfainberg | ayoung, be careful, bytearray is mutable | 18:37 |
| *** dstanek has joined #openstack-keystone | 18:38 | |
| morganfainberg | ayoung, behavior wise, using if six.PY3: bytes(thing, encoding) else: bytes(thing).encode might be better | 18:40 |
| bknudson | what does bytes with encoding do? | 18:41 |
| bknudson | vs bytes w/o encoding | 18:41 |
| morganfainberg | bknudson, bytes in py33 needs encoding | 18:42 |
| morganfainberg | bknudson, it's a binary type vs a byte_str | 18:42 |
| morganfainberg | bknudson in py27, bytes = str | 18:42 |
| bknudson | http://docs.python.org/3/library/functions.html#bytes -- encoding is optional | 18:43 |
| bknudson | oh, if it's a string it needs an encoding | 18:44 |
| bknudson | str.encode('utf-8') returns bytes | 18:45 |
| morganfainberg | bknudson, yeah | 18:46 |
| morganfainberg | bknudson, that's what ayoung's running into | 18:46 |
| *** haneef_ has quit IRC | 18:47 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove extraenous instantiations of managers https://review.openstack.org/81720 | 18:47 |
| morganfainberg | bknudson, should we remove the need to instantiate credential api here: https://review.openstack.org/#/c/81720/3/keystone/tests/test_sql_upgrade.py ? | 18:48 |
| bknudson | seems like could use str.encode() on either py27 or py33? | 18:48 |
| morganfainberg | bknudson, ++ | 18:49 |
| morganfainberg | ayoung, ^ | 18:49 |
| morganfainberg | bknudson, yeah str.encode() in py33 returns a bytes() | 18:50 |
| *** mlemay has joined #openstack-keystone | 18:51 | |
| bknudson | morganfainberg: the creation of credential.Manager() there is ugly but it makes sense why we would have it... | 18:52 |
| *** amcrn has joined #openstack-keystone | 18:52 | |
| bknudson | morganfainberg: you don't have managers when you do keystone-manage db_sync. | 18:52 |
| morganfainberg | bknudson, it is, i think we could just check the db structure and do the same query | 18:52 |
| morganfainberg | bknudson, but i'm not opposed to leaving that one as is | 18:52 |
| ayoung | morganfainberg, can't you @depends that one instead? | 18:52 |
| bknudson | morganfainberg: yes, that's what I was thinking... maybe should rewrite the test to not use the manager. | 18:52 |
| ayoung | that test is also not future proof | 18:54 |
| ayoung | if we futher morph the credentials object, that test will fail | 18:54 |
| openstackgerrit | Diane Fleming proposed a change to openstack/identity-api: Clean up naming to match new conventions https://review.openstack.org/81076 | 19:00 |
| morganfainberg | ayoung, correct it should look at DB structure not the manager | 19:01 |
| morganfainberg | ayoung, @depends is the wrong approach there | 19:01 |
| ayoung | morganfainberg, yep...remove the manager check | 19:01 |
| morganfainberg | ayoung, ++ was leaning that way but wanted to check w/ someone else (2nd pair of eyes first) | 19:02 |
| dolphm | bknudson: still around? | 19:11 |
| *** mlemay has quit IRC | 19:12 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/python-keystoneclient: add functional test for cache pool https://review.openstack.org/82172 | 19:13 |
| bknudson | dolphm: yes, still around | 19:13 |
| dolphm | bknudson: added some functional tests for the cache pool per morgan's suggestion https://review.openstack.org/#/c/82172/1/keystoneclient/tests/test_auth_token_middleware.py | 19:13 |
| dolphm | morganfainberg: ^ | 19:13 |
| dolphm | morganfainberg: this also needs a re-review https://review.openstack.org/#/c/81235/ | 19:22 |
| *** leseb has joined #openstack-keystone | 19:24 | |
| dolphm | morganfainberg: also left this as incomplete based on jamie's comment https://bugs.launchpad.net/keystone/+bug/1294862 - wasn't sure if you had made progress there? | 19:25 |
| uvirtbot | Launchpad bug 1294862 in keystone "Token expiration time with memcache->kvs->dogpile is wrong" [Medium,Incomplete] | 19:25 |
| dolphm | morganfainberg: if a check run fails due to a known transient but otherwise succeeds, recheck *and* +A? | 19:36 |
| morganfainberg | dolphm, i would | 19:38 |
| dolphm | morganfainberg: doned https://review.openstack.org/#/c/81078/ | 19:38 |
| morganfainberg | dolphm, yeah i was going to circle back w/ the guy on irc next week and see if i can chase anything else down | 19:38 |
| morganfainberg | dolphm, he's UTC+1 so, on weekend now | 19:38 |
| morganfainberg | dolphm, but incomplete seems reasonable | 19:39 |
| morganfainberg | dolphm, i also had someone run into more memcache issues w/ token drivers, going to see if i can come up with some magic to help limp us to ephemeral tokens. | 19:39 |
| morganfainberg | dolphm, something trivial we can backport to make quality of life better for them | 19:40 |
| morganfainberg | but more and more i think ephemeral tokens really is a must have for juno | 19:40 |
| morganfainberg | so in L we can make it the "only way"™ | 19:40 |
| dolphm | morganfainberg: +++ | 19:52 |
| *** saju_m has joined #openstack-keystone | 20:05 | |
| ayoung | Wow, this "work in both python 27 and 33" thing is a pain | 20:13 |
| *** marcoemorais has quit IRC | 20:15 | |
| *** marcoemorais has joined #openstack-keystone | 20:16 | |
| *** openstackgerrit has quit IRC | 20:22 | |
| *** openstackgerrit has joined #openstack-keystone | 20:23 | |
| *** Nathan255 has quit IRC | 20:27 | |
| *** marcoemorais has quit IRC | 20:33 | |
| *** saju_m has quit IRC | 20:35 | |
| dolphm | jenkins +1 on https://review.openstack.org/#/c/81235/ | 20:38 |
| dolphm | morganfainberg: lbragstad: ^ | 20:38 |
| morganfainberg | dolphm, yep reading it over. it's dense code | 20:38 |
| dolphm | morganfainberg: very | 20:38 |
| morganfainberg | but i think the list comprehension is better than filter in this case | 20:38 |
| *** dstanek has quit IRC | 20:41 | |
| *** dstanek has joined #openstack-keystone | 20:41 | |
| * morganfainberg avoids premature optimization comments | 20:41 | |
| *** Nathan255 has joined #openstack-keystone | 20:42 | |
| *** leseb has quit IRC | 20:43 | |
| morganfainberg | dolphm, ok so i think this is fine as is, but the whole list comprehension could have been avoided if a simple if is none check was done on tree.get | 20:44 |
| morganfainberg | dolphm, rather than blindly appending and then having to cleanup later. | 20:44 |
| morganfainberg | dolphm, not sure which is faster, but with enough nested for loops, iteration becomes the bottleneck | 20:45 |
| morganfainberg | or make bundle a subclass of list that .append throws away None vs adding it | 20:45 |
| dolphm | morganfainberg: weren't there multiple places where you'd have to add if-conditions then? | 20:45 |
| dolphm | morganfainberg: or were those factored back out | 20:45 |
| morganfainberg | dolphm, 2 | 20:45 |
| dolphm | morganfainberg: oh that's not bad | 20:45 |
| dolphm | morganfainberg: test it and share a diff? | 20:45 |
| morganfainberg | dolphm, one in the role_id section and one in the alt_name section | 20:46 |
| morganfainberg | dolphm, give me a sec. | 20:46 |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/identity-api: Update to clouddocs-maven-plugin 1.15 https://review.openstack.org/82196 | 20:50 |
| morganfainberg | dolphm, building VENV but should have results shortly | 20:51 |
| *** raildo has quit IRC | 20:57 | |
| openstackgerrit | A change was merged to openstack/keystone: Add support for parallel testr workers in Keystone https://review.openstack.org/65870 | 20:59 |
| *** leseb has joined #openstack-keystone | 21:02 | |
| dolphm | yay ^ | 21:02 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Always include 'enabled' field in service response https://review.openstack.org/82205 | 21:02 |
| dolphm | bknudson: working to get the service side of this moving ^ but ran into a weird issue with the downgrade path in the new migration | 21:04 |
| dolphm | bknudson: if it runs for sqlite, every subsequent test fails with DatabaseAlreadyVersionControlled | 21:05 |
| morganfainberg | ayoung, correct me if i'm wrong but does partial matches being none in need to be backdented one more time? | 21:10 |
| morganfainberg | https://review.openstack.org/#/c/81235/6/keystone/contrib/revoke/model.py | 21:10 |
| morganfainberg | dolphm, ^ | 21:10 |
| morganfainberg | it looks like we're bailing out on the first item in _names | 21:10 |
| morganfainberg | if bundle is empty | 21:10 |
| *** joesavak has quit IRC | 21:11 | |
| morganfainberg | or does that imply revoke_map is subsequently also empty? | 21:11 |
| morganfainberg | actually i see that, nvm | 21:11 |
| morganfainberg | partial matches would be completely empty in that case anyway | 21:12 |
| morganfainberg | dolphm, it turns out you'd need to check for is none in 3 places. | 21:13 |
| bknudson | dolphm: I'll give it a try myself. | 21:13 |
| morganfainberg | dolphm, http://pasteraw.com/bjtnj1wfxgmf1pyj76cyhf3nsxg2fo3 | 21:14 |
| *** leseb has quit IRC | 21:14 | |
| ayoung | morganfainberg, line? | 21:15 |
| dolphm | bknudson: found the problem! | 21:15 |
| morganfainberg | ayoung, strike my concern, misread earlier in the code | 21:15 |
| ayoung | cool. | 21:15 |
| *** ayoung is now known as ayoung_dadmode | 21:15 | |
| bknudson | dolphm: I got MismatchError: ['id', 'type', 'extra'] != [u'id', u'type', u'extra', u'enabled']: service table | 21:18 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Always include 'enabled' field in service response https://review.openstack.org/82205 | 21:18 |
| dolphm | bknudson: fixed ^ should pass tests now | 21:19 |
| *** dstanek has quit IRC | 21:20 | |
| *** dstanek has joined #openstack-keystone | 21:21 | |
| dolphm | bknudson: oops, let a debuggy statement slip into review - one sec | 21:21 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Always include 'enabled' field in service response https://review.openstack.org/82205 | 21:21 |
| bknudson | it doesn't look like there's a way to turn off notifications? | 21:27 |
| *** marcoemorais has joined #openstack-keystone | 21:27 | |
| bknudson | maybe only by setting the rpc_backend to a fake driver | 21:27 |
| *** dstanek_afk has joined #openstack-keystone | 21:31 | |
| *** jamielennox|away is now known as jamielennox | 21:38 | |
| *** marcoemorais has quit IRC | 21:38 | |
| *** dstanek has quit IRC | 21:41 | |
| *** dstanek has joined #openstack-keystone | 21:41 | |
| *** dstanek has quit IRC | 21:42 | |
| *** dstanek_afk is now known as dstanek | 21:42 | |
| *** thedodd has quit IRC | 21:43 | |
| jamielennox | dolphm: i'm here for about 5 minutes | 21:44 |
| dolphm | jamielennox: just wanted to give you a heads up that https://review.openstack.org/#/c/81078/ was going in, and that i'll be intended to release 0.7.0 ASAP | 21:45 |
| morganfainberg | dolphm, howabout http://pasteraw.com/mm6v3fohxx8c1jgpleuittx79om2zyk | 21:45 |
| morganfainberg | ok ok i'll stop and +2 that review | 21:45 |
| morganfainberg | it eliminates 3 possible code paths, but it uses lambdas to get there | 21:46 |
| *** marcoemorais has joined #openstack-keystone | 21:46 | |
| jamielennox | dolphm: ahhh, i've got about 5 reviews i wanted in that release | 21:47 |
| dolphm | jamielennox: i'm going to try and wait until monday | 21:47 |
| morganfainberg | not sure if that is really any more readable or better. | 21:48 |
| jamielennox | dolphm: this is important for horizon: https://review.openstack.org/#/c/82007/ | 21:48 |
| jamielennox | this i've been pushing for ages and is the one i need to start getting other clients up to scratch: https://review.openstack.org/#/c/60752/ | 21:48 |
| dolphm | jamielennox: the first one could be a minor release anytime | 21:50 |
| jamielennox | there's a bunch more, but if we are going to do a client release then i really need people to do some client reviews | 21:50 |
| jamielennox | i would like: https://review.openstack.org/#/c/77026/ | 21:50 |
| jamielennox | and the follow up so i'm not stuck with a bunch of new mismatchin args/kwargs | 21:51 |
| morganfainberg | jamielennox, i def have the bandwidth to do reviews next week | 21:51 |
| jamielennox | i can be around again in about 90 minutes to hand hold some reviews, but some of those have been up there for weeks | 21:52 |
| dolphm | jamielennox: we'll probably need to be doing a release before the next keystone meeting, but i put them on the agenda anyway https://wiki.openstack.org/wiki/Meetings/KeystoneMeeting | 21:53 |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: add pooling for cache references https://review.openstack.org/81078 | 21:53 |
| jamielennox | i think this will save us pain in the long run: https://review.openstack.org/#/c/76733/ but i have no justification for it at the moment as it's only my plugins | 21:55 |
| dstanek | jamielennox: is there any way to know which ones are the most important? | 21:55 |
| jamielennox | dstanek: i've gotta do an airport run now - but i'll be back in about an hour and i'll do a list of the ones that are compatibility issues | 21:55 |
| jamielennox | but the couple mentioned above would be good | 21:56 |
| dstanek | i'll start taking a look - i'm in and out of connectivity, but i'll download the patches and take local notes if i'm not connected | 21:57 |
| jamielennox | ok: so the two positional reviews | 21:57 |
| jamielennox | https://review.openstack.org/#/c/77026/ and https://review.openstack.org/#/c/77055/ | 21:58 |
| *** marcoemorais has quit IRC | 21:58 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Always include 'enabled' field in service response https://review.openstack.org/82205 | 21:58 |
| jamielennox | arg passing: https://review.openstack.org/#/c/76733/ | 21:58 |
| dolphm | dstanek: traveling? | 21:59 |
| dstanek | dolphm: just in the car right now :-) | 21:59 |
| jamielennox | i think that will do for compat | 21:59 |
| jamielennox | other's i'd like but those need to happen pre-release | 22:00 |
| jamielennox | /aren't possible post release | 22:00 |
| *** Nathan255 has quit IRC | 22:00 | |
| *** marcoemorais has joined #openstack-keystone | 22:01 | |
| jamielennox | back later | 22:02 |
| dolphm | i'm about to pass out for now... | 22:04 |
| *** dstanek has quit IRC | 22:04 | |
| dolphm | morganfainberg: just a reminder that you never +2'd on https://review.openstack.org/#/c/81235/ -- not sure if you're still looking at it | 22:04 |
| morganfainberg | dolphm, eliminating for loops: http://pasteraw.com/mm6v3fohxx8c1jgpleuittx79om2zyk but yeah i hadn't +2'd because i was seeing if we could clean it up easily... i think we'd lose readability | 22:05 |
| morganfainberg | dolphm, any thoughts / concerns before i +2/+A | 22:07 |
| dolphm | morganfainberg: not for icehouse, i don't think | 22:07 |
| morganfainberg | +2/+a | 22:08 |
| morganfainberg | done | 22:08 |
| dolphm | morganfainberg: looking forward to seeing that code in 6 months ;P | 22:08 |
| morganfainberg | but yeah i think this is a case where using generators is worthwile. | 22:08 |
| morganfainberg | but lambdas make a lot of people cry | 22:08 |
| morganfainberg | dolphm, LOL | 22:09 |
| morganfainberg | you can do evil things with itertools >.> | 22:09 |
| *** bknudson has quit IRC | 22:09 | |
| *** dstanek has joined #openstack-keystone | 22:14 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove extraenous instantiations of managers https://review.openstack.org/81720 | 22:19 |
| *** browne has quit IRC | 22:19 | |
| morganfainberg | now will less credential_api manager instantiation | 22:20 |
| morganfainberg | s/will/with | 22:20 |
| *** daneyon has quit IRC | 22:22 | |
| *** gokrokve has quit IRC | 22:24 | |
| *** gokrokve has joined #openstack-keystone | 22:24 | |
| openstackgerrit | Jenkins proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/82231 | 22:27 |
| *** browne has joined #openstack-keystone | 22:29 | |
| *** gokrokve has quit IRC | 22:29 | |
| *** wchrisj has quit IRC | 22:34 | |
| openstackgerrit | Jenkins proposed a change to openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/79695 | 22:34 |
| *** marcoemorais1 has joined #openstack-keystone | 22:39 | |
| *** marcoemorais has quit IRC | 22:39 | |
| *** marcoemorais1 has quit IRC | 22:45 | |
| *** marcoemorais has joined #openstack-keystone | 22:54 | |
| *** browne has left #openstack-keystone | 22:54 | |
| *** dims has quit IRC | 22:59 | |
| *** devlaps has quit IRC | 22:59 | |
| *** marcoemorais1 has joined #openstack-keystone | 23:03 | |
| *** marcoemorais has quit IRC | 23:03 | |
| *** gokrokve has joined #openstack-keystone | 23:03 | |
| *** marcoemorais has joined #openstack-keystone | 23:06 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Add a positional decorator https://review.openstack.org/77026 | 23:06 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Start using positional decorator https://review.openstack.org/77055 | 23:06 |
| *** marcoemorais1 has quit IRC | 23:07 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Add a positional decorator https://review.openstack.org/77026 | 23:08 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Start using positional decorator https://review.openstack.org/77055 | 23:08 |
| *** marcoemorais has quit IRC | 23:13 | |
| *** dims has joined #openstack-keystone | 23:14 | |
| *** gokrokve has quit IRC | 23:21 | |
| *** gokrokve has joined #openstack-keystone | 23:21 | |
| *** gokrokve has quit IRC | 23:25 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Allow passing a req.Session object to old client https://review.openstack.org/82258 | 23:28 |
| *** marcoemorais has joined #openstack-keystone | 23:28 | |
| *** wchrisj has joined #openstack-keystone | 23:38 | |
| ayoung_dadmode | dolphm, if I have a string but it was populated with binary data origianlly, it blows up if I do: data = bytearray(uncompressed, encoding='UTF-8') is there some encoding that implies "NONE"? | 23:38 |
| *** arunkant has quit IRC | 23:39 | |
| *** marcoemorais has quit IRC | 23:41 | |
| *** marcoemorais has joined #openstack-keystone | 23:41 | |
| *** browne has joined #openstack-keystone | 23:41 | |
| nkinder | ayoung_dadmode: "dadmode" means no coding.... | 23:42 |
| *** browne has quit IRC | 23:42 | |
| ayoung_dadmode | nkinder, 3 Ninjas Playing upstairs says otherwise...I got a bout 20 minutes | 23:42 |
| *** david_lyle_ has quit IRC | 23:44 | |
| *** browne has joined #openstack-keystone | 23:45 | |
| nkinder | ayoung_dadmode: just when you think they're playing nicely on their own, all hell will break loose from my experience | 23:46 |
| ayoung_dadmode | nkinder, TV is a very powerful drug, and only is administrered with a prescription in this house. I told them that they might not get to watch the whole movie due to the late hour...so they are not going to disturb me, hoping that I will forget. | 23:47 |
| ayoung_dadmode | nkinder, I'm working on the compressed token thing...python libraries suck for binary data | 23:47 |
| ayoung_dadmode | I get back a "string" | 23:47 |
| ayoung_dadmode | http://docs.python.org/2/library/zlib.html#zlib.decompress | 23:48 |
| *** dstanek has quit IRC | 23:48 | |
| *** jagee_ has quit IRC | 23:54 | |
| nkinder | ayoung_dadmode: can't you make it a bytestring? | 23:57 |
| jamielennox | ayoung_dadmode: headers are ascii anyway right, cant you just decode to bytes | 23:58 |
| nkinder | ayoung_dadmode: it's been a while since I've had to mess with that sort of stuff in python, but I remember having to use binascii for a few things | 23:58 |
| nkinder | http://docs.python.org/2/library/binascii.html | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!