Friday, 2014-03-07

*** henrynash has quit IRC00:01
*** marcoemorais has quit IRC00:02
*** marcoemorais has joined #openstack-keystone00:02
*** shortic has joined #openstack-keystone00:22
*** browne has joined #openstack-keystone00:22
*** browne has quit IRC00:27
morganfainbergjamielennox, back00:30
*** david-lyle has quit IRC00:30
jamielennoxmorganfainberg: i think i got them00:30
jamielennoxmorganfainberg: they might need to be brought back00:30
morganfainbergjamielennox, well let me know it's not hard to do00:31
morganfainbergjamielennox, unless you want to do it :)00:31
morganfainbergeither way00:31
*** leseb has joined #openstack-keystone00:31
jamielennoxi don't mind who does it, just want to get this finally sorted00:31
*** rwsu has quit IRC00:31
morganfainbergisn't it on a feature branch now?00:31
jamielennoxmorganfainberg: longer term00:31
morganfainbergor is that not sufficient?00:31
morganfainbergoh00:32
morganfainberggot it00:32
morganfainbergand i assume we still have no idea if barbican is going ot pick this up00:32
jamielennoxmorganfainberg: just had a talk with them00:32
jamielennoxthey don't want it as part of barbican itself - it doesn't fit, but they are happy to take it under the barbican-core team/project00:32
morganfainbergyep, figured as much00:33
morganfainbergheh00:34
*** andreaf2 has quit IRC00:34
*** openstackgerrit has joined #openstack-keystone00:35
*** leseb has quit IRC00:35
*** bknudson has quit IRC00:37
*** henrynash has joined #openstack-keystone00:38
*** amcrn has quit IRC00:38
*** mlemay has quit IRC00:46
*** stevemar has joined #openstack-keystone00:50
*** gokrokve_ has quit IRC00:50
*** devlaps has quit IRC01:01
*** marcoemorais has quit IRC01:02
*** marcoemorais has joined #openstack-keystone01:02
*** bknudson has joined #openstack-keystone01:03
*** bknudson1 has joined #openstack-keystone01:04
*** bknudson1 has quit IRC01:05
*** bknudson has quit IRC01:07
*** henrynash has quit IRC01:10
*** bknudson has joined #openstack-keystone01:11
*** wchrisj__ has quit IRC01:13
*** shortic has quit IRC01:16
*** gokrokve has joined #openstack-keystone01:25
*** wchrisj has joined #openstack-keystone01:29
openstackgerritBrant Knudson proposed a change to openstack/keystone: Use oslo db.sqlalchemy.session.EngineFacade.from_config  https://review.openstack.org/7845901:30
openstackgerritBrant Knudson proposed a change to openstack/keystone: Sync db, db.sqlalchemy from oslo-incubator c6a57f  https://review.openstack.org/7842901:30
*** gokrokve has quit IRC01:31
*** gokrokve has joined #openstack-keystone01:36
*** wchrisj has quit IRC01:42
dstanekthat's cool01:43
*** marcoemorais has quit IRC01:43
*** wchrisj has joined #openstack-keystone01:48
openstackgerritA change was merged to openstack/keystone: Fix docstrings in federation related modules  https://review.openstack.org/7814201:54
*** harlowja has quit IRC01:56
morganfainbergdstanek, yeah02:01
*** richm1 has joined #openstack-keystone02:05
*** richm has quit IRC02:06
*** ayoung has joined #openstack-keystone02:08
*** morganfainberg is now known as morganfainberg_Z02:09
ayoungjamielennox, have you made an effort into enabling V3 for the CLI part of keystoneclient?02:09
jamielennoxayoung: no, we aren't doing that02:10
ayoungjamielennox, of course we are02:10
ayoungheh02:11
jamielennoxoh you mean OSC?02:11
ayoungno I mean I need a way to test some V3 functionality02:11
ayoungI don't necessarily want to support it02:11
jamielennoxnot happening in CLI, use the cilent directly to test it02:11
ayoungis the OSC going to be usable any time in the near future?02:12
ayoungfor Keystone that is?02:12
jamielennoxit should be ok now, stevemar?02:13
openstackgerritZhang Yang proposed a change to openstack/keystone: Fix dict wrong use in ec2 auth  https://review.openstack.org/7883702:15
*** gokrokve has quit IRC02:17
*** YorikSar has quit IRC02:18
*** YorikSar has joined #openstack-keystone02:20
*** dolphm_ has joined #openstack-keystone02:24
stevemarjamielennox, catching up...02:24
stevemarayoung, it's totally usable02:24
*** ayoung_ has joined #openstack-keystone02:26
*** openstackgerrit has quit IRC02:35
*** nkinder has quit IRC02:35
*** dims has quit IRC02:35
*** YorikSar has quit IRC02:35
*** richm1 has quit IRC02:35
*** stevemar has quit IRC02:35
*** dstanek has quit IRC02:35
*** gyee has quit IRC02:35
*** koolhead17 has quit IRC02:35
*** ayoung has quit IRC02:35
*** bknudson has quit IRC02:35
*** haneef_ has quit IRC02:35
*** sudorandom has quit IRC02:35
*** dolphm has quit IRC02:35
*** jamielennox has quit IRC02:35
*** dolphm_ has quit IRC02:35
*** chandan_kumar has quit IRC02:35
*** d0ugal has quit IRC02:35
*** jordant has quit IRC02:35
*** lbragstad has quit IRC02:35
*** jraim has quit IRC02:35
*** zhiyan_ has quit IRC02:35
*** wchrisj has quit IRC02:35
*** dtroyer has quit IRC02:35
*** Daviey has quit IRC02:35
*** mfisch has quit IRC02:35
*** chmouel has quit IRC02:35
*** zigo has quit IRC02:35
*** mhu has quit IRC02:35
*** ChanServ has quit IRC02:35
*** morganfainberg_Z has quit IRC02:35
*** marekd|away has quit IRC02:35
*** anteaya has quit IRC02:35
*** luisbg has quit IRC02:35
*** gokrokve has joined #openstack-keystone02:36
*** nkinder has joined #openstack-keystone02:41
*** ayoung_ has quit IRC02:45
*** haneef_ has joined #openstack-keystone03:02
*** bknudson has joined #openstack-keystone03:02
*** sudorandom has joined #openstack-keystone03:02
*** lbragstad has joined #openstack-keystone03:03
*** jordant has joined #openstack-keystone03:03
*** sudorandom has quit IRC03:06
*** bknudson has quit IRC03:06
*** haneef_ has quit IRC03:06
*** haneef_ has joined #openstack-keystone03:11
*** bknudson has joined #openstack-keystone03:11
*** sudorandom has joined #openstack-keystone03:11
*** dolphm has joined #openstack-keystone03:21
*** jraim has joined #openstack-keystone03:27
*** zhiyan has joined #openstack-keystone03:31
lbragstadbknudson: quick question on database migrations if you have a minute03:31
bknudsonlbragstad: shoot!03:31
lbragstadis one wants to modify and *existing* column in a table, do you recreate the table or do you jsut change that one column's attributes?03:32
lbragstads/is/if03:32
bknudsonlbragstad: change the columns attributes03:32
lbragstadok03:32
lbragstadthanks03:32
bknudsonthere's an alter table03:32
bknudsonI'm pretty sure we've got some examples where we alter the columns...03:33
bknudsonthere was one in oauth1 that was failing on db2.03:33
lbragstadbknudson: yeah. that's where i am looking03:33
lbragstadI can't imagine it would be too tough03:33
lbragstadbknudson: bingo https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/032_username_length.py#L2303:33
bknudsonlbragstad: easy peasy03:34
*** saju_m has joined #openstack-keystone07:01
*** zhiyan is now known as zhiyan_07:04
*** andreaf has joined #openstack-keystone07:17
*** derek_c has joined #openstack-keystone07:45
*** derek_c has quit IRC07:47
*** derek_c has joined #openstack-keystone07:53
*** henrynash has joined #openstack-keystone07:53
*** bvandenh has joined #openstack-keystone07:53
*** david-lyle has joined #openstack-keystone07:53
*** d0ugal has joined #openstack-keystone07:53
*** chandan_kumar has joined #openstack-keystone07:53
*** ayoung-ZZZZZzzz_ has joined #openstack-keystone07:53
*** dims_ has joined #openstack-keystone07:53
*** redgard has joined #openstack-keystone07:53
*** jamielennox|away has joined #openstack-keystone07:53
*** YorikSar has joined #openstack-keystone07:53
*** dstanek has joined #openstack-keystone07:53
*** marekd|away has joined #openstack-keystone07:53
*** koolhead17 has joined #openstack-keystone07:53
*** luisbg has joined #openstack-keystone07:53
*** mfisch has joined #openstack-keystone07:53
*** anteaya has joined #openstack-keystone07:53
*** Daviey has joined #openstack-keystone07:53
*** dtroyer has joined #openstack-keystone07:53
*** chmouel has joined #openstack-keystone07:53
*** zigo has joined #openstack-keystone07:53
*** mhu has joined #openstack-keystone07:53
*** morganfainberg has joined #openstack-keystone07:53
*** ChanServ has joined #openstack-keystone07:53
*** dickson.freenode.net sets mode: +vo morganfainberg ChanServ07:53
*** jraim has quit IRC07:56
*** jraim has joined #openstack-keystone07:56
*** henrynash has quit IRC07:56
*** gokrokve has quit IRC07:59
*** morganfainberg is now known as morganfainberg_Z08:07
*** leseb has joined #openstack-keystone08:08
*** gokrokve has joined #openstack-keystone08:30
*** gokrokve_ has joined #openstack-keystone08:32
*** gokrokve has quit IRC08:35
*** gokrokve_ has quit IRC08:37
*** andreaf has quit IRC08:43
*** derek_c has quit IRC08:43
*** derek_c has joined #openstack-keystone08:43
*** derek_c has joined #openstack-keystone08:44
*** derek_c has quit IRC08:46
*** derek_c has joined #openstack-keystone08:46
*** derek_c has quit IRC08:46
*** derek_c has joined #openstack-keystone08:46
*** derek_c has quit IRC08:47
*** derek_c has joined #openstack-keystone08:47
*** derek_c has quit IRC08:47
*** derek_ has joined #openstack-keystone08:48
*** derek_ has quit IRC08:48
*** henrynash has joined #openstack-keystone08:49
*** marekd|away is now known as marekd08:54
*** gokrokve has joined #openstack-keystone09:33
*** gokrokve has quit IRC09:38
*** saju_m has quit IRC10:19
*** gokrokve has joined #openstack-keystone10:33
*** gokrokve has quit IRC10:38
*** jaosorior has joined #openstack-keystone10:47
*** saju_m has joined #openstack-keystone11:30
*** gokrokve has joined #openstack-keystone11:33
*** gokrokve_ has joined #openstack-keystone11:35
*** gokrokve has quit IRC11:38
*** gokrokve_ has quit IRC11:40
*** david-lyle has quit IRC12:12
*** bvandenh has quit IRC12:19
*** gokrokve has joined #openstack-keystone12:33
*** gokrokve has quit IRC12:38
*** saju_m has quit IRC12:49
*** mlemay has joined #openstack-keystone12:59
*** gokrokve has joined #openstack-keystone13:33
*** mberlin has joined #openstack-keystone13:33
*** gokrokve has quit IRC13:37
*** raildo has joined #openstack-keystone13:52
*** bowdengl has joined #openstack-keystone14:06
*** wchrisj has joined #openstack-keystone14:11
*** ayoung-ZZZZZzzz_ is now known as ayoung14:17
*** redgard has quit IRC14:20
*** stevemar has joined #openstack-keystone14:29
dstanekmorning all14:32
*** lbragstad has quit IRC14:33
*** wchrisj has quit IRC14:33
*** browne has joined #openstack-keystone14:33
*** gokrokve has joined #openstack-keystone14:33
*** dims_ has quit IRC14:36
*** gokrokve has quit IRC14:38
stevemarmorning dstanek !14:43
stevemarall, propose new session topics! http://summit.openstack.org/14:43
dstanekso...help strings. end in period. or not?14:44
*** dims_ has joined #openstack-keystone14:49
*** wchrisj has joined #openstack-keystone14:54
*** topol has joined #openstack-keystone14:54
*** lbragstad has joined #openstack-keystone15:00
*** mlemay has quit IRC15:05
*** nkinder has quit IRC15:15
bknudsondstanek: if the help string can be read as a sentence then end in a .15:20
*** gordc has joined #openstack-keystone15:21
*** openstackgerrit has joined #openstack-keystone15:22
*** gokrokve has joined #openstack-keystone15:26
dstanekbknudson: was looking at https://review.openstack.org/#/c/77443 - looked to other libraries for guidance, but it seems like everybody is inconsistent15:29
ayoungstevemar, I've proposed 5.  I now have half of the proposed sessions15:29
ayoung:)15:29
stevemarayoung, jeez15:30
ayoungbut...lets treat those a buckets15:30
ayoungstevemar, they are going to break down into buckets anyway...tokens, RBAC, Federation ...15:30
bknudsondstanek: https://review.openstack.org/#/c/77443/1/keystoneclient/shell.py could update the keystone man page.15:30
ayoungfigure we can look at the last summit for the breakdown and shift from there15:30
stevemarayoung, aye15:30
bknudsonis there an identity ABI?15:31
stevemarayoung, you have your soapbox ready?15:31
ayoungstevemar, I don't need a soap box.  I have a "parade ground voice."15:32
dstanekbknudson: really?15:32
ayoungbknudson, PAM?15:33
bknudsondstanek: I think it's just a typo.15:33
stevemarbknudson, ABI was put there intentionally, because it's casual nick friday15:35
stevemaror not15:35
*** ayoung is now known as admiyo15:35
admiyoNow I just feel incogneeeto!15:35
*** admiyo is now known as ayoung15:35
*** bowdengl has quit IRC15:38
*** stevemar is now known as stevedoor15:39
*** david-lyle has joined #openstack-keystone15:40
lbragstadstevedoor: ++15:41
*** raildo has quit IRC15:59
*** thedodd has joined #openstack-keystone16:04
stevedoordolphm, ping16:09
*** prad_ has joined #openstack-keystone16:12
*** marekd is now known as marekd|email-me16:15
*** nkinder has joined #openstack-keystone16:16
*** stevedoor has quit IRC16:31
prad_ayoung: bknudson: After many tries i'm still not successful getting ssl enabled.. i opened a bug listing my details https://bugs.launchpad.net/keystone/+bug/1289343 if you can take a look and see if i missed anything or if its indeed a bug, i would appreciate it16:34
openstackgerritAndreas Jaeger proposed a change to openstack/python-keystoneclient: Improve help strings  https://review.openstack.org/7744316:34
bknudsonprad_: did you ever try connecting with openssl s_client or a web browser?16:35
prad_bknudson: yea it failed with openssl s_client as well.. so i'm wondering if the certs generated are the issue16:36
prad_bknudson: this is havana btw16:36
bknudsonI don't see how it's keystone's problem if the certs aren't valid?16:37
prad_bknudson: the certs are generated with ssl_setup command.. so could the issue be there?16:37
bknudsonI didn't think the ssl_setup tool was meant to be used with a production server16:38
bknudsonbut it's worked for me for testing...16:38
bknudsontry openssl s_server with the certificates.16:38
prad_bknudson: that connects and i see ACCEPT16:41
*** gyee has joined #openstack-keystone16:41
*** raildo has joined #openstack-keystone16:43
openstackgerritDolph Mathews proposed a change to openstack/python-keystoneclient: increase default revocation_cache_time  https://review.openstack.org/7870016:49
*** chandan_kumar has quit IRC16:51
ayoungooh, we're going to be getting those now?16:51
nkinderbknudson: ping, re - https://review.openstack.org/#/c/73935/316:51
nkinderbknudson: I was wondering if you had some time to look at ayoung's comments.16:52
bknudsonnkinder: I haven't looked at them.16:52
nkinderbknudson: I'd like to move this one along before it gets too stale, and it seems like there is some disagreement on how to handle some things in the unit test.16:52
bknudsonnkinder: I don't know how long it's going to take to write up responses to the comments... will have to gather all the info.16:54
bknudsonso then it winds up being a lower priority item for me.16:54
bknudsonyou can get others to review it too16:54
nkinderbknudson: ok, I can ask others, but you had pointed out some concerns in your earlier review that ayoung responded to.  I wanted to see if the concerns were still valid in light of what ayoung said.16:56
nkinderbknudson: I can see if anyone else has time.  Thanks.16:56
ayounglet me take a look...I forget more than I ever knew about LDAP16:57
nkinderayoung: this was really more about using entries from the fixture vs adding our own in the testcase16:58
ayoungRight.,  Yeah, stop using fixtures16:58
ayoungor, standard values from the fixtures16:58
ayoungbknudson, we want to stop setting up all of the fixtures everytime16:58
nkinderbasically, I used the same logic and style that we already use in other tests16:59
bknudsonis there a blueprint or proposed code?16:59
ayoungbknudson, no and no16:59
ayoungbknudson, probably should be just a bug17:00
ayoung"unit tests take too dang long."17:00
ayoungThis was identified a long while ago...back when dolphm was working on the tests for the V3 API17:00
ayoungand you can see the pattern he established there.17:00
bknudsonwell, I don't disagree with that policy... it's just a new one for me.17:01
bknudsonI always hate to hear the excuse that the other tests are doing it wrong so this new code should continue to do it wrong.17:02
ayoungbknudson, yeah....thought it was well understood, but I guess there has been some new blood on the core team.17:10
ayoungbknudson, what do you mean by "self.opt_in_group() to set config options."17:11
bknudsonayoung: morganfainberg_Z had a review in progress to change all those17:11
ayoungwhat is the issue?17:11
bknudsonayoung: it wasn't sticky across config reloads or something... caused a problem with some ldap tests.17:12
ayoungBut in this case it is set in the test_case itself.  That should be appropriate17:12
*** rwsu has joined #openstack-keystone17:12
*** harlowja has joined #openstack-keystone17:13
*** daneyon has joined #openstack-keystone17:13
ayoungah..all the load_backends stuff...ok.  Example of how to do it?17:13
daneyonAnyone deploy Havana Keystone with SSL (using ssl_setup)? Official docs are based on G.  I am following these instructions, but still no luck:  https://github.com/kjtanaka/deploy_havana/wiki/How-to-enable-ssl-on-keystone.  I am seeing the same thing as this bug, but changing the permissions for the .pem files doesn't fix the problem: https://bugs.launchpad.net/keystone/+bug/119400117:14
bknudsonhere it is -- abandoned now https://review.openstack.org/#/c/70514/17:14
ayoungso self.config_fixture.config(group='os_inherit', enabled=True)  is what nkinder should be using, not  self.opt_in_group(17:15
bknudsonwell, we don't have the config_fixture yet.17:15
bknudsonayoung: morganfainberg_Z had made an earlier pass to switch to opt_in_group17:16
bknudsonnot sure what happened to that one.17:16
ayoungbknudson, ah, so  the goal is to get a single way to do it?17:16
bknudsonayoung: yes, he'd made a pass to do all the config setting with opt_in_group...17:17
bknudsonthen ran into an issue with dynamic options...17:17
*** gokrokve has quit IRC17:17
ayoungbknudson, ok...so what can we do for this review?17:17
bknudsondo the opt_in_group17:17
bknudsondo self.opt_in_group('ldap', <whatever>)17:18
*** gokrokve has joined #openstack-keystone17:29
*** gokrokve has quit IRC17:31
nkinderbknudson, ayoung: ok, I can make that change and submit a new patch17:41
raildoI noticed that the keystone v3, you can only filter users by domain_id, but it is not possible for project_id. To accomplish this it is necessary to consult the role assignemnts, filtering by project, which is only returned the user_id, For more details, he should make another query on users by this user_id. In my opinion, it is more complicated for a user OpenStack.17:50
openstackgerritA change was merged to openstack/python-keystoneclient: improve configuration help text in auth_token  https://review.openstack.org/7865017:50
raildoThinking about it, I implemented a solution where you can filter users by project_id, using the command, "v3/users?project_id={project_id}" and would create a blueprint for this.17:50
raildo  I wonder if someone shares the same opinion as mine.17:51
*** gordc has quit IRC18:00
*** d0ugal has quit IRC18:01
*** gordc has joined #openstack-keystone18:05
ayoungnkinder, BTW...I filed this: http://summit.openstack.org/cfp/details/818:08
*** harlowja has quit IRC18:08
ayounggyee, this is for you http://summit.openstack.org/cfp/details/918:08
*** Yash_ has joined #openstack-keystone18:10
Yash_Hi..I am trying to implement a timer function  which disables the user after a few minutes of instance usage...can anyone give me some advice?18:11
gyeeayoung, thanks, yeah we have the need to do https authentication18:11
*** tellesnobrega has joined #openstack-keystone18:12
ayounggyee, that should work for Basic, Kerbers, and X50918:13
ayoungYash_, How about "Don't do it"18:13
ayoung:)18:13
Yash_ayoung, why?18:14
* ayoung feeling curmudgeonly18:14
ayoungYash_, seriously, though, what is your use case?18:14
*** harlowja has joined #openstack-keystone18:15
ayoungcuz I think we have something that will make your life easier, if I guess correctly....18:15
Yash_ayoung, want to give user an offer to use an instance free for some time and once the time is up..i want him to come out of the system and pay if he wants to use it further18:15
ayoungYash_, Use HEAT18:15
Yash_ayoung, anything specific in HEAT that I should look at? I am new18:16
*** mlemay has joined #openstack-keystone18:16
ayoungYash_, it is the orchestration engine, so it is the piece for doing things like "make this change three days from now"18:17
Yash_ayoung, on nice..let me havea  look at it18:17
Yash_ayoung, thanks a lot :)18:17
ayoungYou'll want to do a bunch of custom stuff and it will be far simpler to do it all in one place18:17
ayoungYash_, NP18:17
* ayoung figured our a nice way to say -2 "Its a feature"18:18
*** amcrn has joined #openstack-keystone18:37
*** nkinder has quit IRC18:37
ayoungWe don't have a region API in the client yet, right?18:40
*** topol has quit IRC18:48
*** nkinder has joined #openstack-keystone18:48
*** stevemar has joined #openstack-keystone18:51
*** gordc has quit IRC18:54
*** zhiyan_ is now known as zhiyan18:55
*** topol has joined #openstack-keystone18:57
*** zhiyan is now known as zhiyan_18:58
*** leseb has quit IRC19:04
*** leseb has joined #openstack-keystone19:05
bknudsonthe change to use opt_in_group actually merged already -- https://review.openstack.org/#/c/69080/19:06
bknudsonapparently will have to do it again.19:06
bknudsonor maybe missed some19:06
*** devlaps has joined #openstack-keystone19:08
*** leseb has quit IRC19:09
*** stevemar has quit IRC19:12
*** stevemar2 has joined #openstack-keystone19:12
*** morganfainberg_Z is now known as morganfainberg19:26
morganfainbergbknudson, config fixture19:27
morganfainbergbknudson, it's why we didn't go further with opt_in_group19:28
morganfainbergthe config fixture should replace opt_in_group now.19:28
* morganfainberg tries and wakes up19:28
*** ellakoz has joined #openstack-keystone19:32
stevemar2dolphm, ping?19:37
*** stevemar2 is now known as stevemarrmatey19:37
bknudsonmorganfainberg: I've been -1 on reviews that didn't use opt_in_group... not sure if it's necessary19:39
morganfainbergbknudson, before it was absolutely the right way, now people should still use it, or config fixture19:40
bknudsonmorganfainberg: and it seems like every time I -1 I wind up having to explain why.19:40
morganfainbergbknudson, you're doing it right19:40
morganfainbergbknudson, people don't understand how loading config files could overwrite your options19:40
morganfainbergbknudson, and it has bitten me in refactors a bunch19:40
*** gordc has joined #openstack-keystone19:43
ayounggit log --author=bknudson --oneline --since=5-may-2013 | wc -l19:47
ayoung17319:47
ayoung$ git log --author=dolph --oneline --since=5-may-2013 | wc -l19:47
ayoung7719:47
ayounggit log --author=ayoung --oneline --since=5-may-2013 | wc -l19:48
ayoung3719:48
bknudsonthis is why you split up your patches.19:48
ayounggit log --author=m@metacloud.com --oneline --since=5-may-2013 | wc -l19:48
ayoung5619:48
morganfainbergyep19:49
ayoungbknudson, its cuz you are not allowed to review your own patches19:49
bknudsonmine are all "Remove unused method" ... "cleanup" this or that19:49
ayoungyeah, no line counts in there19:50
*** richm has joined #openstack-keystone19:50
bknudsonthey don't ask our group to write new features... that's for other teams.19:50
bknudsonwe're just supposed to know what's going on and discuss bugs or usage19:50
ayounggit log --author=bknudson --oneline --since=5-may-2013  --log-size | awk '/log size/ {sum+=$4} END {print "sum = ", sum}'19:52
ayoungsum =  636219:52
ayounggit log --author=ayoung --oneline --since=5-may-2013  --log-size | awk '/log size/ {sum+=$4} END {print "sum = ", sum}'19:52
ayoungsum =  117419:52
ayoungright19:52
ayounggit log --author=m@metacloud.com  --oneline --since=5-may-2013  --log-size | awk '/log size/ {sum+=$4} END {print "sum = ", sum}'19:52
ayoungsum =  265219:52
ayoungNot sure what log size is19:52
ayoung2e51473 log size 2619:53
ayoungToken Revocation Extension19:53
morganfainbergayoung number of files?19:56
ayoungmorganfainberg, nah, think it is just log message...fun one coming up though19:56
morganfainbergayoung, hehe19:57
openstackgerritA change was merged to openstack/python-keystoneclient: Improve help strings  https://review.openstack.org/7744319:57
openstackgerritDavid Stanek proposed a change to openstack/keystone: Start using to oslotest  https://review.openstack.org/7906819:58
openstackgerritDavid Stanek proposed a change to openstack/keystone: Allows override of stdout/stderr/log capturing  https://review.openstack.org/7906919:58
ayounggit log --author=ayoung --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '19:59
ayoungfile_changed =  506 added= 17081 removed= 810519:59
ayounggit log --author=bknudson --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '20:00
ayoungfile_changed =  478 added= 5349 removed= 348620:00
morganfainberglol20:00
ayounggit log --author=m@metacloud.com --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '20:01
ayoungfile_changed =  288 added= 12217 removed= 397620:01
ayoungI'm sure I could do that cleaner....20:01
bknudsonyou have +9000 lines and I have +90020:01
bknudsonmine are probably oslo sync20:01
ayoungwait, that last one had no 'since'20:01
ayounggit log --author=bknudson --since=5-may-2013  --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '20:02
ayoungfile_changed =  472 added= 5282 removed= 348220:02
ayounggit log --author=ayoung --since=5-may-2013  --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '20:02
ayoungfile_changed =  202 added= 8984 removed= 538020:02
ayoungwith no author filter:  file_changed =  4230 added= 359115 removed= 15234920:03
bknudsonno author? scary20:03
bknudsonoh, that's all of them.20:04
ayoungheh,  yeah, that is total for the year20:04
morganfainberghehe20:04
ayoungok, much more complex and I'm going to have to switch to python20:04
*** leseb has joined #openstack-keystone20:05
bknudsonadded= 359115 removed= 152349 -- that's a lot of churn20:05
ayounggit log  --since=5-may-2013  | grep "^Author:" | sort -u | wc -l20:07
ayoung13820:07
ayoungcouple dupes in there20:08
ayoung13320:09
ayounggit log  --since=5-may-2013  | grep "^Author:"  |  sed -e 's!Author: !!'   -e 's!<.*!!'      | sort -u | wc -l20:09
*** leseb has quit IRC20:09
bknudsonthat's pretty impressive that we can get 133 contributors20:10
ayoungbknudson, that is just the server.  Client is much smaller20:11
morganfainbergstill20:11
morganfainbergthats is a good number of contributors20:11
ayoung git log --author=jamielennox --since=5-may-2013  --stat | awk '/ files changed/ {files_changed += $1; added+=$4; removed+=$6} END {print "file_changed = ",files_changed, "added=", added ,"removed=",removed     } '20:13
ayoungfile_changed =  219 added= 13313 removed= 1118520:13
ayoungNo surprise there20:13
bknudsonthat's in the client?20:13
ayoungyep20:13
ayoung git log  --since=5-may-2013  | grep "^Author:"  |  sed -e 's!Author: !!'   -e 's!<.*!!'      | sort -u | wc -l20:13
ayoung9120:13
ayoungWow20:13
bknudsonI didn't think there was 13313 lines in the client.20:13
ayounglots of client contributors20:14
ayoungfind keystoneclient/ -name \*py | xargs wc -l20:14
ayoung 24171 total20:14
ayoungwe've changed over have the number of lines in the client20:14
ayoungin the last year20:14
*** leseb has joined #openstack-keystone20:22
*** leseb has quit IRC20:24
*** leseb has joined #openstack-keystone20:24
*** jimbaker has joined #openstack-keystone20:27
*** leseb has quit IRC20:29
*** gokrokve has joined #openstack-keystone20:30
*** nkinder has quit IRC20:35
*** andreaf has joined #openstack-keystone20:37
openstackgerritA change was merged to openstack/identity-api: Cleanup Domain V3 documentation  https://review.openstack.org/7689920:52
openstackgerritA change was merged to openstack/identity-api: Cleanup Project V3 documentation  https://review.openstack.org/7690020:52
*** ellakoz has quit IRC21:08
ayoungmorganfainberg, do you have the slightest clue about how our client tests are supposed to work?21:08
ayoungI mean the tests in the client for the APIs?21:09
*** jaosorior has quit IRC21:10
*** mlemay has quit IRC21:12
bknudsonayoung: I think they just record the request that was made and simulate a response.21:15
bknudsonthen you can validate that the request was as expected21:16
ayoungbknudson, that seems to be the case, but some sort of logic is involved beyond that21:16
ayoungfor example,  I'm working on a region API module, and it should be pretty simple21:16
ayoungdef create(self, id, description=None, enabled=True,21:17
ayoung               parent_region_id=None, **kwargs):21:17
ayoungbut...somehwo the response drps the description21:17
bknudsonayoung: doesn't the test have to essentially hardcode the response?21:18
ayoungbknudson, no using httppretty21:18
ayoungif I don't perform all of the steps of the test manually I get21:18
ayoungTypeError: create() takes at least 2 arguments (3 given)21:19
ayoungthere is a  parameterize(ref): function that21:19
ayoung"""Rewrites attributes to match the kwarg naming convention in client.21:19
ayoungthe description field is a required field, but not sure if that is what is making the difference21:20
bknudsonLooks like you do a self.stub_entity and set entity= to the response you want: http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/tests/v3/test_groups.py#n4121:21
bknudsonbtw, wtf "self.assertTrue(len(ref_list), len(returned_list))"21:21
bknudsonhttp://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/tests/v3/test_groups.py#n5921:21
bknudsonthis is why I have 173 commits21:22
dstanekdid you guys see the LDAP queston on the mailing list?21:22
*** leseb has joined #openstack-keystone21:25
bknudson11G     .testrepository/21:26
bknudsonyikes21:26
ayoungdstanek, which one?21:27
dstanekayoung: "All LDAP users returned using keystone v3/users API"21:28
ayoungdstanek, known issue21:28
ayoungdstanek, LDAP itself should be limiting the number of records returned21:28
dstaneksounds like they are working on the issue, but it doesn't mention where the code is21:28
ayoungnot doing that is a known bad-practice21:28
dstanekayoung: do we have a bug for it?21:29
ayoungdstanek, I forget...it might have been filed and close for all I recall21:29
ayounglist all users is dumb21:29
ayoungand should never have been part of the api in the first place21:29
*** leseb has quit IRC21:30
dstanekayoung: agreed21:30
bknudsonI think it was hp complained about it at one point21:30
ayoungdstanek, its not like LDAP implements "limit and offset" either21:30
morganfainbergdstanek, ayoung ++++++++21:30
ayoungdoing windowed queries in LDAP is ....21:30
* morganfainberg wants it to go away.21:30
ayoungyou just don't do that21:30
ayounghp had a query that took 2 hours to return21:30
openstackgerritDavid Stanek proposed a change to openstack/keystone: Start using to oslotest  https://review.openstack.org/7906821:31
openstackgerritDavid Stanek proposed a change to openstack/keystone: Allows override of stdout/stderr/log capturing  https://review.openstack.org/7906921:31
dstaneki'm going to write a script to change my name to 'yo mama' before i git review21:31
ayoungbknudson, note that the groups link you set does not explicit;ly implement list, get, or creat, but there are all tested implicitly21:32
ayoungits that new_ref that makes it all work21:32
bknudsonayoung: the tests make a lot of assumptions about how the server processes the request.21:32
ayoungyep21:32
ayoungbut...21:32
ayoungthat is actually OK21:32
ayoungI mean, it is kindof irrelevant, but it does keep our response IAW the standard21:33
ayoungI just don't get what is happening with my 'description" field, nor why it is required in the regions API21:33
bknudsonseems a little late since we're lucky if the client gets implemented.21:33
bknudsonayoung: you're wondering why description is required for what?21:34
ayoungregions21:34
dstanekayoung: i think i remember seeing a bug about that21:34
bknudsonI think lbragstad was looking at that21:35
ayoungdescription = sql.Column(sql.String(255))21:35
dstanekhttps://bugs.launchpad.net/keystone/+bug/127245921:35
ayoungvs parent_region_id = sql.Column(sql.String(64), nullable=True)21:35
ayoungbut, I'm ok working around that21:36
bknudsonayoung: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/sql/migrate_repo/versions/037_add_region_table.py#n2621:36
lbragstadoh, the region stuff?21:36
ayoungthat is fine,  I just can't seem to get the client test to pass21:36
ayoungI'' post a draft21:36
lbragstadkinda of started addressing some of that here:21:37
bknudsonI didn't notice that the migration doesn't match the model... the model doesn't say it's required.21:37
lbragstadhttps://review.openstack.org/#/c/78658/ (note) this is going to be replaced for the most part with a migration fix,21:37
lbragstadwhich should in turn fix this: https://review.openstack.org/#/c/76444/21:38
lbragstadwhich is just enforcing the V3 API spec for regions21:38
dstaneklbragstad: it looks like your bug is a dup of the one jaypipes posted21:38
lbragstaddstanek: yeah it doesn, I didn't know jaypipes opened one21:38
lbragstaddoes*21:39
*** dstanek is now known as dstanek_afk21:40
ayoungSo we are doing away with "required descritpion"21:41
ayoungugh21:41
morganfainbergrequired description how?21:41
ayoungin regions21:42
morganfainbergoh21:42
*** nkinder has joined #openstack-keystone21:42
bknudsonmorganfainberg: sql.Column('description', sql.String(255), unique=True, nullable=False),21:42
morganfainbergbknudson, nod21:42
bknudsonayoung: also make sure you description is unique21:42
bknudsoncan have 2 regions with the same description21:43
ayoungbknudson, well, I won't bother if we are dropping that restriction21:43
morganfainbergUniqueConstraint, Required, Foreign Key to something in nova21:43
morganfainberg:P21:43
bknudsonor something in identity, that would be as bad.21:43
ayoungOh..um, so unique and required is staying?21:43
*** harlowja has quit IRC21:43
* morganfainberg is being silly21:44
bknudsonwe need a migration to fix it? lbragstad -- do you have a migration written?21:44
lbragstadI think dolphm said we should keep the 'required' part.. so that means nullable=False for the migration (untouched) but we would need to modify the unique contraint21:44
lbragstadif the user doesn't provide a description in the request for creating a region, in the manager we can set it to an empty string21:45
bknudsonlbragstad: also fix the model to match the migration: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/catalog/backends/sql.py#n3421:45
lbragstadbknudson: ok, I have a migration, just making a couple tweaks to the tests for the upgrades21:46
morganfainbergbknudson, dstanek_afk, what were the config files we _needed_ to keep for testing? (e.g. we'd break if we tried to run some alternative test, like live sql tests?)21:49
ayoungif we just default in the front end, isn't that good enough?21:49
morganfainbergi think only the SQL backend and ldap one.21:49
morganfainbergs21:49
bknudsonayoung: if we default to '' then it's going to fail because it's not unique.21:50
bknudsonwe'd have to default to a uuid or something21:51
*** ChanServ sets mode: -v morganfainberg21:51
lbragstadright21:51
bknudsonmorganfainberg: deprecated.conf and deprecated_override.conf21:52
morganfainbergbknudson, ++ thanks21:52
bknudsonmight be nice to have a conf/ directory for these21:53
morganfainbergbknudson, I'll do that in the review i consolidate down the options21:56
morganfainbergbknudson, 2 reviews: remove opt/opt_in_group in lieu of config_fixture21:56
morganfainberg2nd remove most of the .conf test files21:56
morganfainbergi'll move the conf files in the 2nd one as well21:57
ayoungI think the difference in the region API is that we pass in the id22:00
ayoungBut maybe even that is negotiable22:00
ayoungIf I drop the Id it works22:01
lbragstadayoung: you mean here: https://github.com/openstack/keystone/blob/master/keystone/catalog/controllers.py#L14522:22
*** harlowja has joined #openstack-keystone22:23
*** leseb has joined #openstack-keystone22:26
*** gordc has left #openstack-keystone22:26
*** gordc has quit IRC22:26
*** leseb has quit IRC22:30
ayounglbragstad, I was just "requiring" the ID, but if it is optiona;l, and assigned by the server, it all works, so  I am good.22:35
lbragstadyeo22:35
lbragstadyep22:35
lbragstadtechincally we should be able to create regions with nothing...22:35
lbragstadthe spec says we don't 'require' anything22:35
lbragstadfor region creation22:35
*** stevemarrmatey has quit IRC22:36
lbragstadhttps://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#regions-v3regions22:36
openstackgerritayoung proposed a change to openstack/python-keystoneclient: Regions Management  https://review.openstack.org/7909622:38
ayoungOK, that is annoying22:38
lbragstadayoung:  so you're doing the client stuff for regions V322:40
lbragstad?22:40
ayounglbragstad, yep22:40
lbragstadok,22:40
lbragstadI'll be sure to review since I'm validating the API on the server side22:40
ayounglbragstad, here's how it happend;  I need to do the client stuff for revocation events.  BUt I wiped out my database, so I started using the client code to repopulate it, and I realized that there was no region API when I went to create an endpoint22:41
ayoungso, now there is a region API22:41
lbragstadayoung: yeah.. did you come across any other gaps22:42
lbragstad?22:42
ayounglbragstad, not yet22:42
ayounglbragstad, I need to figure out how to create the endpoints correctly.  I never quite got that working22:42
lbragstadok, I was kind ofin the process of doing some of that -- V3 API validation22:42
*** lbragstad has quit IRC22:45
wchrisjhey dolphm:22:49
wchrisjCould someone tell me what the canonical reference is for what specific API calls Keystone implements based on the docs? I found a call yesterday that had not been implemented in Keystone, and would like to know how to discover that for myself.22:51
wchrisjdtroyer: Would you know the answer to this? ^^22:53
wchrisjIf the answer is "read the source", is that https://github.com/openstack/keystone22:55
*** leseb has joined #openstack-keystone22:58
*** leseb has quit IRC22:59
*** leseb has joined #openstack-keystone22:59
*** andreaf has quit IRC22:59
dtroyerwchrisj: if it's the v2 API, then yes, read the source is the only accurate answer, and that's a good mirror repo to use.23:02
wchrisjReading tis now: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v2_0/client.py23:03
dtroyerthe v3 API docs are in good shape and if there's a mis-match I'm sure dolphm & co want to know about it23:03
wchrisjeasier to follow than the server/api code23:03
dtroyeractually, that might be a better strategy for now ;)23:03
*** leseb has quit IRC23:03
wchrisjI'm new(er) to python, which is prob a contributor to that ;-)23:03
*** daneyon has quit IRC23:05
*** bknudson has quit IRC23:06
*** david-lyle has quit IRC23:08
*** leseb has joined #openstack-keystone23:10
*** topol has quit IRC23:10
*** rwsu has quit IRC23:15
*** zigo has quit IRC23:17
openstackgerritMorgan Fainberg proposed a change to openstack/keystone: Use config fixture  https://review.openstack.org/7910423:20
morganfainbergdstanek_afk, ^23:21
openstackgerritMorgan Fainberg proposed a change to openstack/keystone: Use config fixture  https://review.openstack.org/7910423:22
*** leseb has quit IRC23:34
*** leseb has joined #openstack-keystone23:36
*** amcrn has quit IRC23:37
*** niconoff has joined #openstack-keystone23:40
*** dims_ has quit IRC23:53
*** henrynash has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!