| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 00:01 |
|---|---|---|
| *** MentalSiege has quit IRC | 00:02 | |
| *** ianychoi__ has joined #openstack-ironic | 00:14 | |
| *** tosky has quit IRC | 00:15 | |
| *** ianychoi_ has quit IRC | 00:17 | |
| *** lmcgann has quit IRC | 00:28 | |
| TheJulia | rloo: commented on the spec. If you wouldn't mind take a quick look and see if I've clarified some of your questions. | 00:34 |
| *** cp-- has quit IRC | 00:50 | |
| *** cp- has joined #openstack-ironic | 00:51 | |
| *** xinliang has joined #openstack-ironic | 00:51 | |
| *** tzumainn has quit IRC | 01:59 | |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 02:06 |
| *** paras333 has quit IRC | 02:08 | |
| *** paras333 has joined #openstack-ironic | 02:09 | |
| *** zzzeek has quit IRC | 02:12 | |
| *** zzzeek has joined #openstack-ironic | 02:12 | |
| *** lbragstad_ has joined #openstack-ironic | 02:14 | |
| *** k_mouza has joined #openstack-ironic | 02:15 | |
| *** lbragstad has quit IRC | 02:17 | |
| *** k_mouza has quit IRC | 02:19 | |
| *** paras333 has quit IRC | 02:23 | |
| *** paras333_ has joined #openstack-ironic | 02:23 | |
| *** paras333 has joined #openstack-ironic | 02:24 | |
| *** rcernin has quit IRC | 02:37 | |
| *** rloo has quit IRC | 02:46 | |
| *** rcernin has joined #openstack-ironic | 02:51 | |
| openstackgerrit | Merged openstack/bifrost master: Add release version to release notes https://review.opendev.org/c/openstack/bifrost/+/773318 | 03:06 |
| *** pmannidi has quit IRC | 03:11 | |
| *** pmannidi has joined #openstack-ironic | 03:12 | |
| openstackgerrit | Merged openstack/ironic master: Add release version to release notes https://review.opendev.org/c/openstack/ironic/+/773314 | 03:19 |
| *** dustinc has joined #openstack-ironic | 03:29 | |
| openstackgerrit | Merged openstack/bifrost master: Automatically configure the idrac hardware type https://review.opendev.org/c/openstack/bifrost/+/772562 | 03:33 |
| openstackgerrit | Merged openstack/bifrost master: Trivial: remove a duplicate variable https://review.opendev.org/c/openstack/bifrost/+/772557 | 03:33 |
| TheJulia | lbragstad_: on endpoints that return lists, are projects querying the db with the project ID and just allowing readers to hit the endpoint... or... are they doing something else?!? I can see applying a policy after getting an object and being able to compare the policy versus the object, but yeah | 03:49 |
| *** lbragstad_ is now known as lbragstad | 03:51 | |
| lbragstad | i think i depends on the project | 03:51 |
| lbragstad | some projects have db methods or driver methods that return object for a project | 03:52 |
| lbragstad | which is pretty clean (IMO) after the policy check passes | 03:52 |
| lbragstad | others will fetch the entire list of references after the policy check succeeds and then filter it | 03:52 |
| lbragstad | i think it* | 03:53 |
| lbragstad | in keystone - we fetch the object before we call enforcement | 03:53 |
| TheJulia | I mean at that poin thte policy is basically "are they a reader" | 03:54 |
| TheJulia | which is kind of what I'm thinking I'm going to have to do to get the list of objects, no need to constantly re-apply and re-evaluate, I'd rather push database searches to something that is indexed and that knows how to do that REALLY fast :) | 03:55 |
| lbragstad | yep - that makes sense | 03:55 |
| TheJulia | now, inside that list if your not system scoped, that will be another aspect to consider, but not at the moment | 03:56 |
| lbragstad | you mean instead of doing db.get_all_resources() then filtering by project | 03:56 |
| * TheJulia sighs at what seems to be a race condition in the test runner | 03:56 | |
| lbragstad | do something like db.get_resource_for_project(project_id) | 03:56 |
| TheJulia | lbragstad: I mean stripping entire fields | 03:56 |
| TheJulia | like "oh, you shouldn't be able to see this, nope!" | 03:56 |
| lbragstad | ok - so sanitizing information? | 03:58 |
| TheJulia | less sanitizing, more "there is zero need to expose information that may help you do things your not supposed to ever do" | 03:58 |
| TheJulia | but I heed to look at that specifically, just trying to get the basic stuff sorted for access | 03:59 |
| lbragstad | ok - so you're removing objects from the list response, and not removing attributes from the object, based on the policy | 03:59 |
| TheJulia | not objects from the list, but like | 03:59 |
| TheJulia | there is no need a lessee would ever need to see the internal_info field | 03:59 |
| TheJulia | if they are trying to troubleshoot things, that is different, but it begins to reveal internal structural data like the last Ip address the agent heartbeated from | 04:00 |
| lbragstad | ah - and internal_info is an attribute of a baremetal host | 04:00 |
| TheJulia | yes | 04:00 |
| TheJulia | owner on the other hand, it is likely okay | 04:00 |
| lbragstad | ok | 04:00 |
| TheJulia | system scoped, perfectly fine | 04:00 |
| lbragstad | right | 04:00 |
| lbragstad | yeah - i'm following you line of thinking | 04:01 |
| lbragstad | your* | 04:01 |
| lbragstad | if you have database/backend methods to give you that, then that's cool and faster than doing it in python at a higher layer i'm sure | 04:02 |
| TheJulia | yeah, unfortunately since it is an object we're converting, it is in the object we're handing back out, so it has to be done higher up | 04:02 |
| * TheJulia signs and wonders why we're getting 3 records when we should only be able to see two... 50% of the time | 04:03 | |
| *** paras333 has quit IRC | 04:05 | |
| *** uzumaki has joined #openstack-ironic | 04:08 | |
| lbragstad | i'm not sure i can help with the race condition, but does that help with the policy enforcement bit? | 04:09 |
| TheJulia | heh | 04:10 |
| TheJulia | It does | 04:10 |
| TheJulia | I think I see what it is with the race | 04:11 |
| TheJulia | I think | 04:11 |
| *** paras333_ has joined #openstack-ironic | 04:12 | |
| TheJulia | Yeah, its the same data being exposed to the test runner and my return results not being filtered it seems | 04:15 |
| *** paras333_ has quit IRC | 04:16 | |
| TheJulia | hmm, maybe ot | 04:18 |
| TheJulia | not | 04:18 |
| * TheJulia digs more | 04:18 | |
| * lbragstad nods | 04:19 | |
| lbragstad | good luck! | 04:19 |
| *** xinliang has quit IRC | 04:22 | |
| openstackgerrit | Merged openstack/ironic-python-agent-builder master: Update requirements for diskimage-builder https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/771820 | 04:26 |
| openstackgerrit | Merged openstack/ironic master: Fix Mis-Ordering of Bash Variable Definition in DevStack https://review.opendev.org/c/openstack/ironic/+/773272 | 04:26 |
| openstackgerrit | Merged openstack/metalsmith master: Change metalsmith to centos8+uefi job by default https://review.opendev.org/c/openstack/metalsmith/+/773701 | 04:28 |
| TheJulia | okay, yeah, I need to dig deep into it in the morning | 04:40 |
| TheJulia | In the mean time, enough of the computers for today | 04:40 |
| *** pmannidi has quit IRC | 04:49 | |
| *** pmannidi has joined #openstack-ironic | 04:50 | |
| openstackgerrit | Merged openstack/ironic stable/victoria: For Supermicro BMCs set enable when changing boot device https://review.opendev.org/c/openstack/ironic/+/773656 | 04:54 |
| *** pmannidi has quit IRC | 05:13 | |
| *** dustinc has quit IRC | 05:39 | |
| *** pmannidi has joined #openstack-ironic | 05:39 | |
| *** uzumaki has quit IRC | 06:07 | |
| *** rcernin has quit IRC | 06:08 | |
| *** rcernin has joined #openstack-ironic | 06:08 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-ironic | 06:17 | |
| *** rcernin has quit IRC | 06:17 | |
| *** rcernin has joined #openstack-ironic | 06:19 | |
| *** k_mouza has joined #openstack-ironic | 06:26 | |
| *** k_mouza has quit IRC | 06:30 | |
| openstackgerrit | ankit proposed openstack/sushy stable/victoria: Fixes issue of redfish firmware update https://review.opendev.org/c/openstack/sushy/+/771604 | 06:52 |
| *** uzumaki has joined #openstack-ironic | 06:52 | |
| *** moshiur has joined #openstack-ironic | 07:24 | |
| arne_wiebalck | Good morning, ironic! | 07:42 |
| openstackgerrit | Merged openstack/ironic master: Apply force_persistent_boot_device to all boot interfaces https://review.opendev.org/c/openstack/ironic/+/773382 | 07:51 |
| arne_wiebalck | The foundation has created a playlist for the bare metal SIG on their Youtube channel uploaded the first videos: https://www.youtube.com/playlist?list=PLKqaoAnDyfgoBFAjUvZGjKXQjogWZBLL_ | 07:55 |
| *** anuradha1904 has joined #openstack-ironic | 07:56 | |
| *** Qianbiao has joined #openstack-ironic | 08:06 | |
| openstackgerrit | Devendra Kulkarni proposed x/sushy-oem-idrac master: Fix for bugs related to virtual media boot https://review.opendev.org/c/x/sushy-oem-idrac/+/773848 | 08:39 |
| *** tosky has joined #openstack-ironic | 08:40 | |
| *** rpittau|afk is now known as rpittau | 08:41 | |
| rpittau | good morning ironic! o/ | 08:41 |
| arne_wiebalck | hey rpittau o/ | 08:42 |
| rpittau | hey arne_wiebalck :) | 08:43 |
| ajya | morning, ironic | 08:56 |
| ajya | iurygregory: yes, that's exactly how that error looks, and also can see in message that non-default port is used. For now either setup to use default or switch back to HTML4 plugin | 08:56 |
| ajya | *HTML5 | 08:56 |
| *** ociuhandu has joined #openstack-ironic | 09:06 | |
| *** lucasagomes has joined #openstack-ironic | 09:11 | |
| *** ociuhandu has quit IRC | 09:28 | |
| *** ociuhandu has joined #openstack-ironic | 09:33 | |
| *** derekh has joined #openstack-ironic | 09:39 | |
| *** ociuhandu has quit IRC | 09:45 | |
| openstackgerrit | Devendra Kulkarni proposed x/sushy-oem-idrac master: Fix virtual media boot constants and retry count https://review.opendev.org/c/x/sushy-oem-idrac/+/773848 | 09:46 |
| *** dougsz has joined #openstack-ironic | 09:56 | |
| *** ociuhandu has joined #openstack-ironic | 10:19 | |
| *** ociuhandu has quit IRC | 10:24 | |
| *** rcernin has quit IRC | 10:24 | |
| *** k_mouza has joined #openstack-ironic | 10:27 | |
| *** k_mouza has quit IRC | 10:31 | |
| openstackgerrit | Mark Goddard proposed openstack/tenks master: Test idempotence of deploy and teardown in CI https://review.opendev.org/c/openstack/tenks/+/660964 | 10:34 |
| *** sshnaidm|afk is now known as sshnaidm|ruck | 10:35 | |
| *** ociuhandu has joined #openstack-ironic | 10:36 | |
| *** ociuhandu has quit IRC | 10:41 | |
| *** ociuhandu has joined #openstack-ironic | 10:42 | |
| openstackgerrit | Mark Goddard proposed openstack/networking-generic-switch master: Create and delete networks in parallel https://review.opendev.org/c/openstack/networking-generic-switch/+/692404 | 10:44 |
| *** dtantsur|afk is now known as dtantsur | 10:49 | |
| dtantsur | morning ironic | 10:49 |
| dtantsur | in case you, like me, are craving for any good news: the ironic-agent element has been dropped from DIB | 10:51 |
| dtantsur | on the negative side, we need to make sure it does not affect stable/train (I think no) | 10:51 |
| rpittau | good morning dtantsur :) | 10:52 |
| rpittau | that is a good news indeed | 10:52 |
| *** k_mouza has joined #openstack-ironic | 10:52 | |
| iurygregory | good morning Ironic o/ | 10:53 |
| iurygregory | ajya, tks! | 10:53 |
| rpittau | hey iurygregory :) | 10:53 |
| rpittau | dtantsur: I was looking at the hardware module in IPA for... reasons and I found your note https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L431 | 10:55 |
| rpittau | can't we just point that to utils.LSBLK_COLUMNS ? Or we want to exclude PARTUUID on purpose for some reason? | 10:55 |
| *** rcernin has joined #openstack-ironic | 10:55 | |
| * dtantsur is trying to remember | 10:56 | |
| rpittau | :D | 10:56 |
| dtantsur | rpittau: whatever the reason was, I cannot remember it, and the decision no longer makes sense to me | 10:56 |
| dtantsur | I definitely recall that I did have *some* reasoning behind it | 10:57 |
| dtantsur | but I guess we can try changing it | 10:57 |
| rpittau | ok, I'll propose a test patch with that | 10:58 |
| rpittau | I have a couple more changes, but I'll keep them separate for now | 10:58 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic-specs master: Pre-defined system hw configuration in single step https://review.opendev.org/c/openstack/ironic-specs/+/740721 | 10:59 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: [WIP] Use variable for lsblk columns device info https://review.opendev.org/c/openstack/ironic-python-agent/+/773871 | 11:02 |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 11:15 |
| *** rcernin has quit IRC | 11:15 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Add a workaround for openSUSE https://review.opendev.org/c/openstack/bifrost/+/773872 | 11:16 |
| dtantsur | let's hope this helps | 11:16 |
| openstackgerrit | Monica Pardhi proposed openstack/ironic stable/ussuri: DRAC: Fix a failure to create virtual disk https://review.opendev.org/c/openstack/ironic/+/773874 | 11:16 |
| openstackgerrit | Monica Pardhi proposed openstack/ironic stable/ussuri: DRAC: Fix a failure to create virtual disk https://review.opendev.org/c/openstack/ironic/+/770277 | 11:26 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: docs: explain OS support in terms of two tiers https://review.opendev.org/c/openstack/bifrost/+/773875 | 11:27 |
| *** ociuhandu has quit IRC | 11:27 | |
| dtantsur | TheJulia: added your "operating systems evolve" point to ^^^ | 11:27 |
| * dtantsur is pondering promoting Debian to voting | 11:29 | |
| iurygregory | if is "stable" why not? =) | 11:35 |
| *** uzumaki has quit IRC | 11:39 | |
| ajya | dtantsur: can you clarify on this comment thread - https://review.opendev.org/c/openstack/ironic/+/768353/4/ironic/conductor/rpcapi.py#427 | 11:40 |
| dtantsur | ajya: I think you can skip can_send_version('1.22') and just use version='1.52' if deploy_steps are provided | 11:56 |
| dtantsur | I think the failure will happen anyway | 11:56 |
| ajya | dtantsur: ok, will look into that. | 11:57 |
| ajya | dtantsur: and about this comment - https://review.opendev.org/c/openstack/ironic/+/768353/6/ironic/api/controllers/v1/node.py#87 which common.py do you mean? Create a new one? Can't see anything suitable | 11:58 |
| *** ociuhandu has joined #openstack-ironic | 11:59 | |
| openstackgerrit | Jacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning https://review.opendev.org/c/openstack/ironic-python-agent/+/771904 | 11:59 |
| dtantsur | ajya: I think there v1.common or v1.utils | 12:00 |
| *** rcernin has joined #openstack-ironic | 12:01 | |
| *** ociuhandu_ has joined #openstack-ironic | 12:12 | |
| *** ociuhandu has quit IRC | 12:15 | |
| *** mkowalski_ has joined #openstack-ironic | 12:22 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/victoria: Fix memcached host address. https://review.opendev.org/c/openstack/ironic-inspector/+/773675 | 12:36 |
| *** rcernin has quit IRC | 12:43 | |
| dtantsur | the suse workaround passed the CI: https://review.opendev.org/c/openstack/bifrost/+/773872 | 12:44 |
| iurygregory | \o/ | 12:45 |
| *** ociuhandu_ has quit IRC | 12:46 | |
| *** ociuhandu has joined #openstack-ironic | 12:47 | |
| *** mkowalski_ has quit IRC | 12:53 | |
| *** mkowalski_ has joined #openstack-ironic | 12:54 | |
| openstackgerrit | Merged openstack/ironic-prometheus-exporter master: Reconfigure tox.ini https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/772161 | 12:54 |
| *** mkowalski_ has quit IRC | 13:00 | |
| *** mkowalski_ has joined #openstack-ironic | 13:01 | |
| *** uzumaki has joined #openstack-ironic | 13:05 | |
| *** mkowalski_ has quit IRC | 13:07 | |
| *** mkowalski_ has joined #openstack-ironic | 13:08 | |
| *** mkowalski_ has quit IRC | 13:09 | |
| *** mkowalski_ has joined #openstack-ironic | 13:10 | |
| *** ociuhandu has quit IRC | 13:10 | |
| *** mkowalski_ has quit IRC | 13:10 | |
| *** ociuhandu has joined #openstack-ironic | 13:11 | |
| *** mkowalski_ has joined #openstack-ironic | 13:11 | |
| *** mkowalski_ has quit IRC | 13:18 | |
| *** mkowalski_ has joined #openstack-ironic | 13:18 | |
| openstackgerrit | Merged openstack/bifrost master: Add a workaround for openSUSE https://review.opendev.org/c/openstack/bifrost/+/773872 | 13:20 |
| *** mkowalski_ has joined #openstack-ironic | 13:20 | |
| *** mkowalski_ has quit IRC | 13:20 | |
| *** mkowalski_ has joined #openstack-ironic | 13:21 | |
| *** mkowalski_ has quit IRC | 13:22 | |
| *** mkowalski_ has joined #openstack-ironic | 13:22 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost stable/victoria: Add a workaround for openSUSE https://review.opendev.org/c/openstack/bifrost/+/773896 | 13:24 |
| openstackgerrit | Merged openstack/sushy master: Automatically retry HTTP 5xx on GET requests https://review.opendev.org/c/openstack/sushy/+/773711 | 13:32 |
| *** rloo has joined #openstack-ironic | 13:37 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/sushy stable/victoria: Automatically retry HTTP 5xx on GET requests https://review.opendev.org/c/openstack/sushy/+/773897 | 13:38 |
| iurygregory | I have a fix for the IPA, had to add some mocks to get_node_boot_mode | 13:40 |
| dtantsur | nice! | 13:42 |
| iurygregory | dtantsur, do I need a release note? | 13:42 |
| iurygregory | only unit tests (so I don't think it would be necessary) | 13:43 |
| dtantsur | then no | 13:47 |
| iurygregory | let's see how it goes | 13:48 |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic-python-agent master: Mock tests to return bios boot mode https://review.opendev.org/c/openstack/ironic-python-agent/+/773891 | 13:48 |
| iurygregory | 20sec to send the patch \o/ | 13:48 |
| *** tosin has joined #openstack-ironic | 13:51 | |
| rpittau | it's super slow for me too since last week | 13:52 |
| *** lbragstad has quit IRC | 13:57 | |
| *** zaneb has quit IRC | 13:58 | |
| iurygregory | for me it's since the update XD | 14:01 |
| *** ociuhandu has quit IRC | 14:08 | |
| *** ociuhandu has joined #openstack-ironic | 14:09 | |
| *** lmcgann has joined #openstack-ironic | 14:15 | |
| * TheJulia had the worst migraine in years last night | 14:24 | |
| *** paras333_ has joined #openstack-ironic | 14:24 | |
| dtantsur | ouch | 14:26 |
| dtantsur | morning TheJulia, take it easy today | 14:26 |
| *** ociuhandu has quit IRC | 14:27 | |
| *** ociuhandu has joined #openstack-ironic | 14:28 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: Use variable for lsblk columns device info https://review.opendev.org/c/openstack/ironic-python-agent/+/773871 | 14:29 |
| TheJulia | dtantsur: yeah, I think I need to find my glasses too. I think that made things so much worse yesterday starting to dig an issue in our api code | 14:31 |
| TheJulia | in nodes.py :( | 14:31 |
| *** ociuhandu has quit IRC | 14:32 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent master: Use variable for lsblk columns device info https://review.opendev.org/c/openstack/ironic-python-agent/+/773871 | 14:32 |
| *** akahat|rover is now known as akahat | 14:34 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Consistent pip_opts handling + drop --no-cache-dir https://review.opendev.org/c/openstack/bifrost/+/773918 | 14:35 |
| *** lbragstad has joined #openstack-ironic | 14:35 | |
| *** uzumaki has quit IRC | 14:40 | |
| openstackgerrit | Merged openstack/ironic master: Redfish secure boot management https://review.opendev.org/c/openstack/ironic/+/771493 | 14:43 |
| TheJulia | \o/ | 14:45 |
| TheJulia | now we just need to review redfish raid | 14:45 |
| *** tzumainn has joined #openstack-ironic | 14:45 | |
| TheJulia | o/ tzumainn | 14:46 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent stable/victoria: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/770746 | 14:46 |
| tzumainn | TheJulia, hi! | 14:46 |
| openstackgerrit | Merged openstack/ironic master: Raw image size estimation improved https://review.opendev.org/c/openstack/ironic/+/544839 | 14:49 |
| openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Remove grenade jobs from old stable branches https://review.opendev.org/c/openstack/ironic-inspector/+/773332 | 14:49 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent stable/victoria: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/770746 | 14:53 |
| TheJulia | tzumainn: so I'm seeming to encounter a race in testing project scope with owner + admin role :\ | 15:01 |
| TheJulia | err, encountering | 15:01 |
| *** MentalSiege has joined #openstack-ironic | 15:02 | |
| tzumainn | TheJulia, ah, what's happening? | 15:02 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent stable/victoria: Prevent broken partition image UEFI deploys https://review.opendev.org/c/openstack/ironic-python-agent/+/770746 | 15:04 |
| *** MentalSiege has quit IRC | 15:06 | |
| *** ociuhandu has joined #openstack-ironic | 15:06 | |
| TheJulia | tzumainn: I'm not quite sure yet | 15:08 |
| tzumainn | TheJulia, do you have a patch up? I'm happy to take a look | 15:09 |
| TheJulia | I think there is a mix of a test runner race and the project id filtered view not working as expected | 15:09 |
| TheJulia | coming right up | 15:10 |
| * TheJulia waits for gerrit to do its thing | 15:11 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: RBAC System Scope: observer -> reader https://review.opendev.org/c/openstack/ironic/+/772450 | 15:12 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Initial Project scoped tests https://review.opendev.org/c/openstack/ironic/+/772451 | 15:12 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: Project Scoping Node endpoint https://review.opendev.org/c/openstack/ironic/+/773924 | 15:12 |
| *** k_mouza has quit IRC | 15:14 | |
| *** ociuhandu has quit IRC | 15:15 | |
| TheJulia | tzumainn: that very last patch | 15:17 |
| tzumainn | yep, taking a look! | 15:17 |
| *** ociuhandu has joined #openstack-ironic | 15:18 | |
| TheJulia | if you run all of test_acl, you can easily kind of see it | 15:25 |
| TheJulia | but finding why seems to be the troublemaker | 15:26 |
| tzumainn | it's TestRBACProjectScoped.test_project_scoped_00007_owner_admin_can_get_node, correct? | 15:27 |
| TheJulia | yup | 15:27 |
| TheJulia | should only be able to see two nodes not 3.. | 15:27 |
| TheJulia | oh | 15:29 |
| TheJulia | it looks like somehow the first policy is permitting it | 15:29 |
| TheJulia | but it shouldn't.... | 15:29 |
| * TheJulia wonders if the config is toggling in the test run | 15:31 | |
| tzumainn | TheJulia, I suspect it's because of the settings on baremetal:node:list_all, which I believe allows someone to see *all* nodes regardless of whether they're the owner or lessee | 15:38 |
| TheJulia | yeah, I'm thinking the same thing | 15:39 |
| TheJulia | I think somehow without a target being passed to resolve the the node/target association, the policy check is still passing | 15:39 |
| TheJulia | so I think listing everything is just going to need a scope restricted policy | 15:40 |
| TheJulia | which kind of makes sense in a way | 15:40 |
| * TheJulia restricts the policy and reruns | 15:41 | |
| tzumainn | what did you change the policy to? I updated baremetal:node:list to match baremetal:node:get, and reduced the scope of list_all to SYSTEM_READER, and got... different errors | 15:42 |
| tzumainn | but I may be misunderstanding how this works | 15:42 |
| TheJulia | list_all to system_reader and scope of system only | 15:42 |
| TheJulia | because the fallback doesn't also fallback on a 500 error | 15:43 |
| openstackgerrit | Riccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues https://review.opendev.org/c/openstack/bifrost/+/766742 | 15:44 |
| tzumainn | okay, yeah, I tried that and got 500s | 15:44 |
| rloo | TheJulia: commented on rbac spec. Might be useful to let me know how high level you want the spec to be at. That'll give me an idea as to how much info might be needed for me to grok it. At the end of the day, each policy & setting is really what I want to see, but having guidelines etc on how those are derived (and so that they are also consistent) is very useful. | 15:44 |
| openstackgerrit | Riccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues https://review.opendev.org/c/openstack/bifrost/+/766742 | 15:45 |
| *** moshiur has quit IRC | 15:46 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Prevent redfish-virtual-media from being used with Dell nodes https://review.opendev.org/c/openstack/ironic/+/771619 | 15:51 |
| *** k_mouza has joined #openstack-ironic | 15:52 | |
| tzumainn | TheJulia, so the test is still failing after I changed the policy; looking at the output, it looks like when the API request fails the baremetal:node:list_all check, it returns a 500 instead of HTTPForbidden | 15:55 |
| tzumainn | the latter is what's caught in the API code to fallback to the 'baremetal:node:list' check | 15:55 |
| tzumainn | I'm not sure if there may be an issue mocking, or if this is just new policy behavior to adjust code around? | 15:56 |
| *** ociuhandu_ has joined #openstack-ironic | 16:00 | |
| *** Qianbiao has quit IRC | 16:02 | |
| *** ociuhandu has quit IRC | 16:03 | |
| tzumainn | TheJulia, I think I figured it out | 16:04 |
| tzumainn | it's because on list operations, there's no concept of node.owner or anything, because there's no singular node | 16:05 |
| tzumainn | but SYSTEM_OR_PROJECT_READER assumes that there is | 16:05 |
| tzumainn | if you change the list policy to simply check if a user has the reader role, then the tests pass | 16:07 |
| tzumainn | TheJulia, oh, and I also changed https://opendev.org/openstack/ironic/src/branch/master/ironic/api/controllers/v1/utils.py#L1578 to no longer be selective about exceptions; I'm not entirely sure what's going on there | 16:10 |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add 'deploy steps' parameter for provisioning API https://review.opendev.org/c/openstack/ironic/+/768353 | 16:26 |
| openstackgerrit | Dmitry Tantsur proposed openstack/sushy-tools master: Populate System Manufacturer https://review.opendev.org/c/openstack/sushy-tools/+/773940 | 16:29 |
| *** ociuhandu_ has quit IRC | 16:30 | |
| *** tosin has quit IRC | 16:30 | |
| openstackgerrit | Merged openstack/ironic-inspector stable/victoria: Fix memcached host address. https://review.opendev.org/c/openstack/ironic-inspector/+/773675 | 16:31 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Trivial: log the newly detected vendor https://review.opendev.org/c/openstack/ironic/+/773942 | 16:32 |
| openstackgerrit | ankit proposed openstack/ironic stable/victoria: Fixes issue of redfish firmware update https://review.opendev.org/c/openstack/ironic/+/773910 | 16:33 |
| *** ociuhandu has joined #openstack-ironic | 16:38 | |
| openstackgerrit | Aija Jauntēva proposed openstack/ironic master: Add 'deploy steps' parameter for provisioning API https://review.opendev.org/c/openstack/ironic/+/768353 | 16:48 |
| *** sshnaidm|ruck is now known as sshnaidm | 16:52 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Don't mark an agent as alive if rebooted https://review.opendev.org/c/openstack/ironic/+/773949 | 17:06 |
| *** uzumaki has joined #openstack-ironic | 17:18 | |
| *** juanoterocas has joined #openstack-ironic | 17:29 | |
| *** dougsz has quit IRC | 17:30 | |
| *** lucasagomes has quit IRC | 17:31 | |
| *** ociuhandu_ has joined #openstack-ironic | 17:34 | |
| *** k_mouza has quit IRC | 17:35 | |
| *** ociuhandu has quit IRC | 17:37 | |
| *** ociuhandu_ has quit IRC | 17:38 | |
| *** juanoterocas has quit IRC | 17:39 | |
| openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: [WIP] Collect firewalld info if present https://review.opendev.org/c/openstack/bifrost/+/773953 | 17:40 |
| *** k_mouza has joined #openstack-ironic | 17:41 | |
| openstackgerrit | Merged openstack/ironic master: Update python packages to python3 in quickstart.rst https://review.opendev.org/c/openstack/ironic/+/764868 | 17:42 |
| TheJulia | tzumainn: I had basically came to the same conclusion while I was looking at it during my last meeting. Part of it is the 500 is expected I think becasue it makes sense, different mode of use should map to different controls | 17:46 |
| *** k_mouza has quit IRC | 17:52 | |
| *** ociuhandu has joined #openstack-ironic | 17:56 | |
| arne_wiebalck | bye everyone o/ | 17:56 |
| *** ociuhandu has quit IRC | 18:01 | |
| *** derekh has quit IRC | 18:02 | |
| iurygregory | yay edit hashtag patch got a +W \o/ | 18:06 |
| rpittau | good night! o/ | 18:08 |
| *** rpittau is now known as rpittau|afk | 18:08 | |
| *** dtantsur is now known as dtantsur|afk | 18:16 | |
| TheJulia | \o/ | 18:20 |
| TheJulia | tzumainn: needed to catch the exception from the policy checck code | 18:20 |
| tzumainn | ahhh | 18:22 |
| TheJulia | blah | 18:49 |
| TheJulia | now /v1/nodes/detail is matching baremetal:node:get | 18:49 |
| iurygregory | wow | 18:59 |
| TheJulia | lbragstad: is there anything regarding ordering rules that we should be aware of? | 19:00 |
| TheJulia | yeah, it gets routed to get_one instead of detail | 19:02 |
| TheJulia | interesting.... | 19:02 |
| TheJulia | I guess something is wrong with the request routing | 19:02 |
| * TheJulia makes lunch | 19:02 | |
| iurygregory | habemus edit hashtag \o/ | 19:06 |
| iurygregory | <insert happy dance> | 19:06 |
| TheJulia | \o/ | 19:06 |
| iurygregory | we probably need to discuss monday what hashtags we will use | 19:07 |
| TheJulia | ++ | 19:07 |
| *** ayoung has joined #openstack-ironic | 19:09 | |
| *** k_mouza has joined #openstack-ironic | 19:15 | |
| openstackgerrit | Merged openstack/ironic master: Swap Metalsmith job out for centos8-uefi https://review.opendev.org/c/openstack/ironic/+/773702 | 19:15 |
| *** k_mouza has quit IRC | 19:19 | |
| TheJulia | I see the deal, the format is deprecated | 19:23 |
| TheJulia | ugh | 19:26 |
| TheJulia | no, a typo | 19:26 |
| *** k_mouza has joined #openstack-ironic | 19:35 | |
| *** k_mouza has quit IRC | 19:40 | |
| *** rcernin has joined #openstack-ironic | 19:49 | |
| *** ociuhandu has joined #openstack-ironic | 20:04 | |
| *** rcernin has quit IRC | 20:20 | |
| *** rcernin has joined #openstack-ironic | 20:20 | |
| *** sshnaidm is now known as sshnaidm|afk | 20:52 | |
| *** SpamapS has quit IRC | 20:52 | |
| *** juanoterocas has joined #openstack-ironic | 21:03 | |
| *** uzumaki has quit IRC | 21:06 | |
| *** nam-est has quit IRC | 21:06 | |
| *** paras333_ has quit IRC | 21:07 | |
| *** paras333_ has joined #openstack-ironic | 21:08 | |
| *** paras333_ has quit IRC | 21:12 | |
| *** rcernin has quit IRC | 21:22 | |
| *** anuradha1904 has quit IRC | 21:32 | |
| *** ociuhandu has quit IRC | 21:36 | |
| *** k_mouza has joined #openstack-ironic | 21:44 | |
| *** k_mouza has quit IRC | 21:48 | |
| *** SpamapS has joined #openstack-ironic | 21:54 | |
| trandles | today's edition of dumb question from trandles: I have an image that deployed successfully (at least IPA thinks it was successful) but it doesn't look like it ran grub-install because the system falls through booting from disk on a reboot. Any hints? | 21:59 |
| *** rcernin has joined #openstack-ironic | 22:05 | |
| *** rcernin has quit IRC | 22:06 | |
| *** rcernin has joined #openstack-ironic | 22:07 | |
| *** openstackgerrit has quit IRC | 22:11 | |
| *** juanoterocas has quit IRC | 22:20 | |
| *** paras333_ has joined #openstack-ironic | 22:27 | |
| *** bfournie has quit IRC | 22:37 | |
| *** rcernin has quit IRC | 22:45 | |
| janders | hey trandles | 22:57 |
| janders | it's hard to tell without more details, however I had issues like this when I accidentally swapped full disk image vs partition image | 22:57 |
| trandles | Answering my own question: It was a BIOS problem on the hardware. Frustrating part is switching the BIOS from BIOS->UEFI->BIOS "fixed" it? | 22:57 |
| janders | oh dear | 22:57 |
| janders | sounds like something failed to re-read something | 22:58 |
| trandles | We didn't redeploy anything. It just magically started working. | 22:58 |
| janders | frustrating indeed | 22:58 |
| *** paras333_ has quit IRC | 22:59 | |
| trandles | we have another half dozen of these systems, so we're going to deploy them and "see what happens" | 23:03 |
| *** pmannidi has quit IRC | 23:21 | |
| *** pmannidi has joined #openstack-ironic | 23:21 | |
| TheJulia | trandles: weeeeirdddddddd | 23:27 |
| *** rloo has quit IRC | 23:33 | |
| *** tosky has quit IRC | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!