Monday, 2018-03-19

*** hjensas has joined #openstack-ironic00:01
*** aoxen has joined #openstack-ironic00:12
openstackgerritShangXiao proposed openstack/ironic master: [api-ref] Add fault names for the error response codes  https://review.openstack.org/53871700:27
*** hshiina has joined #openstack-ironic00:28
openstackgerritfupingxie proposed openstack/ironic-lib master: Add attemps for the partprobe command  https://review.openstack.org/54203500:55
*** liuzz has joined #openstack-ironic00:55
*** phuongnh has joined #openstack-ironic00:56
*** r-daneel has joined #openstack-ironic01:06
*** tiendc has joined #openstack-ironic01:14
*** r-daneel_ has joined #openstack-ironic01:32
*** r-daneel has quit IRC01:33
*** r-daneel_ is now known as r-daneel01:33
*** yufei has joined #openstack-ironic01:45
*** pmannidi has joined #openstack-ironic02:33
openstackgerritJinxing Fang proposed openstack/sushy master: Add system status field  https://review.openstack.org/55066902:46
openstackgerritJinxing Fang proposed openstack/sushy master: Add system status field  https://review.openstack.org/55066903:03
*** hjensas has quit IRC03:08
*** hjensas has joined #openstack-ironic03:08
*** rbudden has joined #openstack-ironic03:20
*** namnh has joined #openstack-ironic03:21
*** rcernin_ has joined #openstack-ironic03:23
*** rcernin has quit IRC03:25
openstackgerritwangqi proposed openstack/ironic master: Duplicate explicit target name: "statsd"  https://review.openstack.org/55409503:25
*** rcernin_ has quit IRC03:29
*** rcernin has joined #openstack-ironic03:29
*** rcernin has quit IRC03:33
*** zhangfei has joined #openstack-ironic03:37
*** pmannidi has quit IRC03:38
*** pmannidi has joined #openstack-ironic03:42
*** rcernin has joined #openstack-ironic03:49
*** zhangfei has quit IRC03:55
openstackgerritJinxing Fang proposed openstack/sushy master: Add system status field  https://review.openstack.org/55066903:55
*** Nisha_Agarwal has joined #openstack-ironic04:17
*** rwsu has joined #openstack-ironic04:24
*** rwsu has quit IRC04:25
openstackgerritzenghui.shi proposed openstack/ironic master: BIOS Settings: Add DB model  https://review.openstack.org/51116204:31
openstackgerritzenghui.shi proposed openstack/ironic master: BIOS Settings: Add DB API  https://review.openstack.org/51140204:31
openstackgerritzenghui.shi proposed openstack/ironic master: BIOS Settings: Add RPC API  https://review.openstack.org/51220004:31
*** zshi_ has quit IRC04:33
*** zshi_ has joined #openstack-ironic04:33
*** zshi_ is now known as zshi04:34
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode standalone tests  https://review.openstack.org/53811904:36
*** itlinux has quit IRC04:39
openstackgerritDao Cong Tien proposed openstack/ironic master: Update CI jobs for rescue mode  https://review.openstack.org/52870404:40
*** dpawar has joined #openstack-ironic05:23
*** rbudden has quit IRC05:34
*** rbartal has joined #openstack-ironic05:46
*** openstackgerrit has quit IRC05:49
*** dpawar_ has joined #openstack-ironic06:02
*** dpawar has quit IRC06:02
*** marios has joined #openstack-ironic06:12
*** Nisha_Agarwal has quit IRC06:16
*** zhangfei has joined #openstack-ironic06:22
*** ianychoi__ has joined #openstack-ironic06:26
*** ianychoi_ has quit IRC06:29
*** zhangfei has quit IRC06:32
*** jaganathan has joined #openstack-ironic06:42
*** fragatina has quit IRC06:42
*** openstackgerrit has joined #openstack-ironic06:46
openstackgerritTuan Luong-Anh proposed openstack/ironic master: [WIP] Implement iRMC BIOS configuration  https://review.openstack.org/53459506:46
openstackgerritDao Cong Tien proposed openstack/ironic master: Update CI jobs for rescue mode  https://review.openstack.org/52870406:49
*** jcoufal has joined #openstack-ironic06:57
*** pmannidi has quit IRC06:58
*** d0ugal has joined #openstack-ironic07:00
*** d0ugal has quit IRC07:00
*** d0ugal has joined #openstack-ironic07:00
*** rcernin has quit IRC07:07
*** mjura has joined #openstack-ironic07:20
*** yolanda_ is now known as yolanda07:21
*** zhangfei has joined #openstack-ironic07:22
*** zhangfei has quit IRC07:26
*** pcaruana has joined #openstack-ironic07:39
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381307:47
*** e0ne has joined #openstack-ironic07:52
*** AlexeyAbashkin has joined #openstack-ironic07:54
*** OctopusZhang_ has joined #openstack-ironic07:55
openstackgerritNguyen Hai proposed openstack/ironic master: Follow the new PTI for document build  https://review.openstack.org/55347307:57
*** yufei has quit IRC07:59
openstackgerritNguyen Hai proposed openstack/python-ironicclient master: Follow the new PTI for document build  https://review.openstack.org/55415708:01
*** dpawar_ has quit IRC08:09
*** zhangfei has joined #openstack-ironic08:16
*** tesseract has joined #openstack-ironic08:17
*** racedo has joined #openstack-ironic08:20
*** jaganathan has quit IRC08:25
*** jaganathan has joined #openstack-ironic08:26
*** zhangfei has quit IRC08:27
*** dpawar has joined #openstack-ironic08:34
openstackgerritNguyen Hai proposed openstack/python-ironicclient master: Follow the new PTI for document build  https://review.openstack.org/55415708:36
*** jaganathan_ has joined #openstack-ironic08:38
*** jaganathan has quit IRC08:38
*** jaganathan_ has quit IRC08:42
*** stendulker has joined #openstack-ironic08:45
*** jaganathan_ has joined #openstack-ironic08:54
*** jtomasek has joined #openstack-ironic09:02
*** athomas has joined #openstack-ironic09:11
*** hshiina has quit IRC09:13
*** MattMan has quit IRC09:15
*** MattMan has joined #openstack-ironic09:15
*** zhangfei has joined #openstack-ironic09:17
*** hoonetorg has quit IRC09:19
*** ajya has joined #openstack-ironic09:27
*** mgoddard has joined #openstack-ironic09:29
*** hoonetorg has joined #openstack-ironic09:32
*** OctopusZhang_ has quit IRC09:37
*** exodusftw has quit IRC09:37
openstackgerritShivanand Tendulker proposed openstack/ironic master: Fix ``agent`` deploy interface to call ``boot.prepare_instance``  https://review.openstack.org/49905009:38
*** exodusftw has joined #openstack-ironic09:39
*** OctopusZhang_ has joined #openstack-ironic09:44
*** OctopusZhang_ has quit IRC09:48
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode standalone tests  https://review.openstack.org/53811909:51
*** namnh has quit IRC10:05
*** sambetts_ is now known as sambetts10:08
*** zhangfei has quit IRC10:09
skazihi guys10:11
skaziif anyone has a spare minute please take a look at https://review.openstack.org/#/c/553330/10:11
patchbotpatch 553330 - ironic (stable/pike) - Use internal Swift endpoint by default10:11
skaziespecially I'd like to know your opinion about the conf option vs hardcoded 'internal'10:12
*** dtantsur|afk is now known as dtantsur10:19
dtantsurmorning ironic10:19
dtantsursambetts, stendulker, hi, please check https://review.openstack.org/553841 it fixes the inspector CI10:19
patchbotpatch 553841 - ironic - Gate: stop setting IRONIC_ENABLED_INSPECT_INTEFACE...10:19
*** e0ne has quit IRC10:19
dtantsurin combination with https://review.openstack.org/55379710:20
patchbotpatch 553797 - ironic-inspector - devstack: enable "fake" inspection implementation10:20
pas-haskazi: how will it work with internal? If this code is used when constructing the tempurl, I presume there generally should not be any routing from the provisioning network to the network holding internal API endpoints10:21
skazipas-ha: currently it uses public endpoints in pike and internal,public in later releases10:22
skaziafaik in newton it was also internal10:23
sambettspas-ha: actually generally in the deployments I do the provisioning network has access to the control plane but no route to the outside world or the public endpoints10:23
skazinote that the exact bug we hit was with iLO not being able to pull the vmedia images from public endpoints10:24
skaziso it's not really about provisioning network but the iLO network not having routing to public10:24
skaziit might overlap but doesn't have to I guess10:24
*** e0ne has joined #openstack-ironic10:25
skazithis is the only case I know where we need to worry about connecting from bmc network to openstack control plane10:25
skazinormally e.g. for power control you only need the other way around10:25
*** jcoufal_ has joined #openstack-ironic10:32
*** phuongnh has quit IRC10:33
*** ajya has quit IRC10:33
*** zhangfei has joined #openstack-ironic10:33
*** jcoufal has quit IRC10:35
*** jcoufal has joined #openstack-ironic10:35
*** jcoufal_ has quit IRC10:38
*** tiendc has quit IRC10:39
*** jcoufal_ has joined #openstack-ironic10:40
*** jcoufal has quit IRC10:42
*** e0ne has quit IRC10:51
*** zhangfei has quit IRC10:51
*** stendulker has quit IRC11:17
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381311:22
*** e0ne has joined #openstack-ironic11:23
*** e0ne has quit IRC11:40
openstackgerritDmitry Tantsur proposed openstack/ironic stable/queens: Rework logic handling reserved orphaned nodes in the conductor  https://review.openstack.org/55420211:41
*** e0ne has joined #openstack-ironic11:44
*** logan- has quit IRC11:52
*** logan- has joined #openstack-ironic11:52
*** bfournie has quit IRC11:53
*** bfournie has joined #openstack-ironic11:53
*** bfournie has quit IRC11:58
*** jlabarre has joined #openstack-ironic12:08
*** trown|outtypewww is now known as trown|ruck12:12
*** gyankum has joined #openstack-ironic12:22
*** dmellado has quit IRC12:24
*** bfournie has joined #openstack-ironic12:25
*** dmellado has joined #openstack-ironic12:27
openstackgerritNguyen Hai proposed openstack/ironic master: Follow the new PTI for document build  https://review.openstack.org/55347312:35
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381312:36
*** mjturek has joined #openstack-ironic12:45
openstackgerritMerged openstack/networking-generic-switch master: Remove config.get_config()  https://review.openstack.org/55390212:49
*** rloo has joined #openstack-ironic12:55
*** dprince has joined #openstack-ironic12:57
*** baha has joined #openstack-ironic13:03
*** milan_ has joined #openstack-ironic13:03
*** dpawar has quit IRC13:11
*** cdearborn has joined #openstack-ironic13:15
*** cdearborn has quit IRC13:16
*** cdearborn has joined #openstack-ironic13:17
openstackgerritMerged openstack/ironic-ui stable/pike: Imported Translations from Zanata  https://review.openstack.org/54878013:22
openstackgerritMerged openstack/ironic-ui stable/queens: Imported Translations from Zanata  https://review.openstack.org/54789613:22
*** patchbot has quit IRC13:23
*** patchbot has joined #openstack-ironic13:23
*** Goneri has joined #openstack-ironic13:29
*** mjturek has quit IRC13:35
*** rbartal has quit IRC13:36
*** rbudden has joined #openstack-ironic13:37
*** jroll has quit IRC13:42
*** jroll has joined #openstack-ironic13:43
*** hamzy__ is now known as hamzy13:43
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381313:47
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: Rename tempest plugin folder  https://review.openstack.org/55423313:47
*** rbartal has joined #openstack-ironic13:48
*** rbartal has quit IRC13:54
*** dtantsur is now known as dtantsur|brb13:56
jrollmorning y'all14:01
*** beekneemech is now known as bnemec14:02
TheJuliaGood Morning everyone!14:02
* TheJulia begins warming up the espresso machine14:02
rlooGood monday morning TheJulia, jroll, pas-ha, dtantsur|brb14:11
*** mjturek has joined #openstack-ironic14:11
* etingof wishes TheJulia to enjoy her espresso ;)14:12
*** rbartal has joined #openstack-ironic14:13
openstackgerritMerged openstack/ironic master: change python-libguestfs to python-guestfs for ubuntu  https://review.openstack.org/55183414:15
openstackgerritMerged openstack/ironic-inspector master: Updated from global requirements  https://review.openstack.org/55318214:15
openstackgerritMerged openstack/python-ironicclient master: Updated from global requirements  https://review.openstack.org/55325114:15
*** namnh has joined #openstack-ironic14:20
*** mjturek has quit IRC14:21
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: Rename tempest plugin folder  https://review.openstack.org/55423314:26
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381314:26
rloojroll: wrt the healthcheck endpoint -- we're not going to add a CLI for it, right?14:26
jrollrloo: correct14:26
jrollor rather, "please no"14:27
rloojroll: i am going to update the rfe/bug with that. to record it :)14:27
TheJulia++ to please no14:27
rloo:D14:27
jrollthanks14:27
rloojroll: but would be good to update api-ref?14:27
TheJuliadoes the heathcheck plugin not have it's own api ref?14:28
jrollrloo: I don't think so, it's an optional middleware, the docs for it are available in oslo14:28
jrollhttps://docs.openstack.org/oslo.middleware/latest/reference/healthcheck_plugins.html14:28
jroller14:28
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381314:28
jrollno, that's right14:28
rlooso we assume users of ironic can figure that out, that there is a healthcheck option? i think the only place is in code/release note.14:28
rlooconfig option i guess.14:29
jrollconfig, yeah14:29
jrollhttps://github.com/openstack/ironic/blob/master/ironic/conf/healthcheck.py#L2314:30
jrollwhich points to docs :)14:30
*** zshi has quit IRC14:30
*** mjturek has joined #openstack-ironic14:30
rloojroll: guess it is better than nothing.14:31
*** crushil has joined #openstack-ironic14:31
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: Rename tempest plugin folder  https://review.openstack.org/55423314:35
openstackgerritPavlo Shchelokovskyy proposed openstack/networking-generic-switch master: WIP Use native Zuul job  https://review.openstack.org/55381314:35
*** gyankum has quit IRC14:36
*** mjturek has quit IRC14:39
*** mjturek has joined #openstack-ironic14:42
rloowe have ngs documentation being published now: https://docs.openstack.org/networking-generic-switch/latest/14:43
*** zshi has joined #openstack-ironic14:43
pas-harloo: yay! :-)14:44
TheJulia\o/14:44
TheJuliaI was really surprised they were not being published last week, considering I remember goign to them at one point14:45
rlooTheJulia: yeah, me too. That's why I submitted the patch to do it :)14:45
*** hjensas has quit IRC14:58
*** itlinux has joined #openstack-ironic15:00
radezbfournie: hey could you help me work through double checking my aggregate setup? I'm getting this in my nova logs: 'AggregateInstanceExtraSpecsFilter: (start: 1, end: 0)'15:05
radezand a No host found error15:05
*** dtantsur|brb is now known as dtantsur15:10
dtantsurmorning jroll, TheJulia, rloo15:11
openstackgerritNguyen Hai proposed openstack/python-ironicclient master: Follow the new PTI for document build  https://review.openstack.org/55415715:11
jroll\o dtantsur15:11
rloodtantsur: :)15:12
*** ElCoyote_ has joined #openstack-ironic15:15
*** zhangfei has joined #openstack-ironic15:15
dtantsurjroll: opinion from pov of a bigger cloud needed: https://review.openstack.org/#/c/553308/1/specs/approved/power-fault-recovery.rst@5215:20
patchbotpatch 553308 - ironic-specs - Support power fault recovery15:20
jrollsure, will put it on my list15:20
NobodyCamGood Morning Ironic'ers15:46
dtantsurhappy Monday NobodyCam15:47
*** rbartal has quit IRC15:47
NobodyCamHappy Monday dtantsur :)15:47
NobodyCam:p15:47
*** zhangfei has quit IRC15:49
*** mjturek has quit IRC15:51
*** hw_wutianwei has quit IRC15:51
*** mjturek has joined #openstack-ironic15:53
*** r-daneel has quit IRC15:54
* jlvillal assumes lucas-pto is recovering from St Patrick's Day :)15:57
*** gyankum has joined #openstack-ironic15:59
dtantsurheh16:00
*** gyankum has quit IRC16:00
*** namnh has quit IRC16:02
*** pcaruana has quit IRC16:07
*** hjensas has joined #openstack-ironic16:09
*** hjensas has quit IRC16:09
*** hjensas has joined #openstack-ironic16:09
rloodtantsur: those inspector-related patches, do they address failures with ironic-tempest-dsvm-ironic-inspector? the etherpad doesn't say much16:09
*** mjturek has quit IRC16:10
*** mjturek has joined #openstack-ironic16:11
dtantsurrloo: they do16:13
dtantsursorry, detected the issue late on Friday, forgot to update the etherpad16:14
rloodtantsur: ok, so we need to merge them. otherwise, our gate is broken.16:14
rloodtantsur: no worries. which patches still need to be reviewed?16:14
dtantsurrloo: we're good as soon as https://review.openstack.org/#/c/553841/ and https://review.openstack.org/#/c/553797/ merge16:15
patchbotpatch 553841 - ironic - Gate: stop setting IRONIC_ENABLED_INSPECT_INTEFACE...16:15
patchbotpatch 553797 - ironic-inspector - devstack: enable "fake" inspection implementation16:15
* TheJulia kind of wonders if slicing/dicing a whiteboard is like cutting onions16:15
TheJuliahttps://etherpad.openstack.org/p/IronicWhiteBoard has had lots of updating16:15
*** mjturek has quit IRC16:15
jlvillalI just learned that for Depends-On: we should now use URLs. For example: Depends-On: https://review.openstack.org/53615916:16
patchbotpatch 536159 - openstack-infra/shade - Add devel branches and override-checkout for ansib... (MERGED)16:16
rlooTheJulia: :) Just don't cry.16:16
*** fragatina has joined #openstack-ironic16:16
TheJuliarloo: of course not! sulfuric acid is bad for the eyes!16:17
*** skazi has quit IRC16:17
rlooTheJulia: :D16:18
* dtantsur tries to do something refarch-related before the meeting16:19
TheJulia:)16:19
*** crushil has quit IRC16:20
rloook, i updated the whiteboard wrt gate16:21
*** mjura has quit IRC16:21
mordredjlvillal: yah - the new syntax allows folks to do multi-source depends-on - such as an ansible patch depending on a shade-patch - or a patch from one gerrit depending on a patch from a different gerrit16:21
dtantsurwhat a time to be alive!16:21
jlvillalmordred, cool16:22
jlvillalmordred, Hey I've been having a big discussion about PTI in a patch I added you to :)16:23
* TheJulia goes and makes more coffee16:23
mordredjlvillal: oh fun! looking now16:25
jlvillalmordred, Basically I think that if changing the tox.ini to use "sphinx_build" then should remove the [pbr]/auto_index_modules=True at the same time.16:26
jlvillalmordred, We had a little discussion about it over on #openstack-docs about an hour ago.16:27
jlvillal#openstack-doc not plural16:27
*** r-daneel has joined #openstack-ironic16:27
jlvillalmordred, http://eavesdrop.openstack.org/irclogs/%23openstack-doc/%23openstack-doc.2018-03-19.log.html#t2018-03-19T15:36:5916:28
mordredjlvillal: yeah ... this one is a fun one - and it occurs to me we might should add a note to the PTI docs about this case16:30
openstackgerritDmitry Tantsur proposed openstack/ironic master: Rework Bare Metal service overview in the install guide  https://review.openstack.org/55428416:30
dtantsurTheJulia, jroll ^^^16:30
jlvillalmordred, That would be a good idea, IMHO. Thanks!16:30
mordredjlvillal: tl;dr - autodoc_index_modules is a thing we added to pbr ages ago to provide a way to autodoc all of the modules in a project but it's only sporadically used and it adds a pile of complexity that we'd like to see go away16:32
mordredthe gate will handle projects that haven't migrated to the new sphinx-build version of the pti because they still need the pbr autodoc16:33
mordredfor those projects, updating the tox docs env to run sphinx-build should only be done at the same time as removing the autodoc pbr config (and fixing the doc build to not need it)16:34
mordredotherwise things will be weird16:34
*** rpioso|afk is now known as rpioso16:35
jlvillalmordred, Thanks. Makes sense!16:38
*** rwsu has joined #openstack-ironic16:38
sambettsmordred: is autodoc being replaced by anything?16:38
clarkbsambetts: you can configure autodoc directly in sphinx rather than having pbr do it for you16:40
sambettsclarkb: oh interesting I didn't know that, is that a recent addition to sphinx? we ended up doing this https://github.com/openstack/networking-cisco/blob/master/doc/source/conf.py#L22-L34 in networking cisco to make the pbr autodoc work on read the docs :(16:41
*** stendulker has joined #openstack-ironic16:42
clarkbsambetts: you may have to spell out all the .. automodule:: s?16:43
*** trown|ruck is now known as trown|lunch16:44
sambettsoh :(16:46
TheJulia:(16:47
*** hshiina has joined #openstack-ironic16:48
mordredclarkb: yes. that is the thing that pbr autodoc does - it generates all the automodule statements16:48
*** e0ne has quit IRC16:48
rlooTheJulia: are we ready to update subteam status in whiteboard? /me looks...16:49
TheJuliarloo: update!16:49
mordredsambetts: as of right now nobody is working on a replacement that I know of - although it should be fairly easy to take the pbr logic and extract it to a sphinx plugin - which I'll do at some point but it's currently too far down on my stack16:49
rlooTheJulia: :) doin' it now!16:49
TheJuliaupdate all the things!16:49
*** gyee has joined #openstack-ironic16:49
*** hshiina has quit IRC16:50
openstackgerritNguyen Hai proposed openstack/ironic master: Follow the new PTI for document build  https://review.openstack.org/55347316:51
johnthetubaguyrloo: can I sync up about deploy steps and what we do next, I think it was me revising the spec?16:51
openstackgerritNguyen Hai proposed openstack/ironic master: Follow the new PTI for document build  https://review.openstack.org/55347316:51
*** hshiina has joined #openstack-ironic16:51
*** AlexeyAbashkin has quit IRC16:51
rloojohnthetubaguy: no. well, i suspect those specs are on hold until after we get the basic framework one done/agreed upon.16:52
johnthetubaguyrloo: I was thinking about the spec for the basic framework really, were you planing on doing that, as I think I said I would make sure it gets done16:52
rloojohnthetubaguy: the only thing we agreed on at the ptg, was to do the deploy steps framework.16:52
johnthetubaguyyeah16:52
rloojohnthetubaguy: oh. i already wrote the spec, but you can work on it too! https://review.openstack.org/#/c/549493/16:53
patchbotpatch 549493 - ironic-specs - Deployment steps framework16:53
*** fragatina has quit IRC16:53
rloojohnthetubaguy: basically a subset of the other spec i had been working on16:53
johnthetubaguyrloo: perfect, I will review that16:53
rloojohnthetubaguy: thx. jroll has some good feedback already.16:53
johnthetubaguyrloo: I was thinking of rebasing the traits thing on top of that16:53
rloojohnthetubaguy: you could but my suggestion is to wait til this is close/approved.16:54
rloojohnthetubaguy: we still have to address/agree on the tougher questions :)16:54
johnthetubaguyrloo: that's fair, its certainly the more important fundamental bit16:54
rloojohnthetubaguy: or maybe that is :-(16:54
johnthetubaguyrloo: I blame the weather16:55
*** marios has quit IRC16:55
rloojohnthetubaguy: the beast from the east.  i am sure there will be jokes etc about that beast...16:55
johnthetubaguyrloo: something about it catching a train from denver?16:55
rloojohnthetubaguy: yeah, like that! wondering if there was anything from pre-denver ptg that is memorable/add to the train wreck.16:56
* johnthetubaguy scratches head16:56
rloofor BIOS config -- doesn't anyone know if the code patches are ready for review, or are they still in development?16:57
rloos/doesn't/does/16:57
*** fragatina has joined #openstack-ironic16:58
TheJuliarloo: looks like there is a whole list16:58
TheJuliajust not an ordered list yet for us to consume16:58
TheJuliazshi: ^^^^16:58
*** jcoufal has joined #openstack-ironic16:58
rlooTheJulia: yeah, would like someone to comment. until they are sure the patches are good, not sure it is worth starting to review.16:59
TheJuliaditto16:59
*** jcoufal_ has quit IRC17:00
openstackgerritJohn Garbutt proposed openstack/ironic-specs master: Deploy Templates  https://review.openstack.org/50495217:00
TheJulia#startmeeting ironic17:00
dtantsurmmmmeeting time?17:00
openstackMeeting started Mon Mar 19 17:00:48 2018 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.17:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.17:00
TheJuliao/17:00
*** openstack changes topic to " (Meeting topic: ironic)"17:00
jroll\o/17:00
dtantsuro/17:00
openstackThe meeting name has been set to 'ironic'17:00
etingofo/17:00
rpiosoo/17:00
sambettso/17:00
rlooo/17:01
jlvillalo/17:01
TheJuliaEveryone ready for an ironic meeting?!17:01
jlvillalUh....yeah...yeah!!!17:01
hshiinao/17:01
TheJuliaExcellent!17:01
TheJuliaOur agenda is on the wiki, as always17:01
TheJulia#link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting17:01
TheJuliaI made a couple changes this morning.17:02
*** hjensas has quit IRC17:02
TheJulia#topic Announcements / Reminders17:02
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)"17:02
*** mjturek has joined #openstack-ironic17:02
mjtureko/17:02
TheJulia#info Rocky Cycle Community Priorities have merged https://specs.openstack.org/openstack/ironic-specs/priorities/rocky-priorities.html17:02
rlooyay!17:03
TheJulia#info Regarding the Oneview driver, HPE has indicated they are aware of the requirement to remain in-tree. No other update at this time.17:04
*** weshay is now known as weshay_brb17:05
TheJulia#info XClarity driver CI may be delayed, to be determined.17:05
TheJuliatl;dr Someone new will be picking up the 3rd party CI work, contact unknown at present but I'm in communication with Lenovo.17:06
TheJuliaAnyone else have any announcements or reminders to bring up?17:06
*** crushil has joined #openstack-ironic17:07
TheJuliao/ crushil17:07
crushilTheJulia, \o17:07
rpiosoDid an ML message go out re: lifecycle management discussions?17:07
TheJuliarpioso: That is on my calendar for thursday17:07
rpiosoTheJulia: Cool17:08
TheJuliarpioso: I'll try to get it done sooner :)17:08
TheJuliaWell, if there is nothing else announcement wise, we can move on...17:08
vdroko/17:08
TheJuliaOne last thing, the reason for XClarity CI being delayed is that crushil will be moving on. I would like to thank him for his efforts, and hopes that he stays in touch with the community.17:10
dtantsurcrushil++ good luck17:10
crushilTheJulia, dtantsur Thanks17:10
rloothanks crushil, sorry that you're moving on17:11
crushilThanks rloo. It was pleasure working with the Ironic community17:11
TheJuliaMoving on...17:11
TheJulia#topic Reviewing Action Items from the last meeting17:11
*** openstack changes topic to "Reviewing Action Items from the last meeting (Meeting topic: ironic)"17:11
TheJuliaWe had three action items last week17:12
stendulkero/17:12
TheJulia(TheJulia) Reorganize the whiteboard17:12
TheJulia(TheJulia) Get the community a taste of storyboard17:12
TheJuliaAnd finally17:12
* jlvillal waits...17:13
TheJulia(mjturek) Leading bug triaging.17:13
TheJuliaSorry, slight interruption17:13
jlvillalheh. I thought it was a dramatic pause :)17:13
TheJuliaAs everyone has hopefully seen, the whiteboard has been reorganized.17:14
TheJulia#link https://etherpad.openstack.org/p/IronicWhiteBoard17:14
TheJuliaI also provided a taste of storyboard with ironic data17:14
TheJulia#link https://nuc.mirroruniverse.org17:14
TheJuliamjturek: how were the bugs?17:14
mjturekdid not get a lot done on the triage. Reviewed some of the New bugs but nothing too interesting17:14
TheJuliaSounds good17:14
TheJuliaTime to move on to our next topic then!17:14
TheJulia#topic Review subteam status reports17:15
*** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)"17:15
TheJulia#link https://etherpad.openstack.org/p/IronicWhiteBoard17:15
TheJuliaStarting at line 14817:16
rloosorry this is an aside, but i am looking at the 3rd party CI and it needs to be updated. Maybe an action item for next week TheJulia? L6817:16
TheJuliaPerfectly valid :)17:16
rloodtantsur: do you know what the critical ironic bug is?17:17
TheJulia#action TheJulia to review/update 3rd party CI section of the whiteboard17:17
rloodtantsur: forget it, i see it is sushy17:17
dtantsuryep17:17
rloogood work on approving bios config spec. for next week -- would be good to know if the code patches are ready for reviewing.17:18
TheJuliazshi or yolanda, are either of you around?17:18
* dtantsur remembers reviewing something17:18
TheJuliavdrok: Regarding neutron event processing, it looks like the spec likey needs an update.17:19
rloovdrok: wrt neutron event processing L213. is that the latest status (from today, vs sept)?17:19
yolandahi TheJulia17:19
yolandayep, the patches should be ready17:19
jrollawesome17:19
*** hjensas has joined #openstack-ironic17:19
*** hjensas has quit IRC17:19
*** hjensas has joined #openstack-ironic17:19
vdrokrloo: will update the whiteboard, tldr rewriting the code17:19
rlooare we 2018 or 2019? L222...17:19
TheJuliayolanda: we would like someone to create an ordered list for us to begin reviewing from.17:19
rloothx vdrok!17:19
TheJuliavdrok: thanks!17:19
yolandaok... let me work on that tomorrow17:20
TheJuliayolanda: thanks, is it okay if I note it as an action item?17:20
yolandasure17:20
openstackgerritMichael Turek proposed openstack/ironic master: Add OpenBMC class for accessing nodes using OpenBMC  https://review.openstack.org/42983617:20
jrollTheJulia: the patches are already in order on the branch, right?17:20
* jroll sees 5 in one chain17:20
rlooTheJulia: wrt nova virt/REST API. there were some questions in the priority spec; should we discuss at some point?17:20
jrollrloo: ++17:21
TheJulia#action yolanda to update list of bios interface patches in the whiteboard to represent review order.17:21
*** d0ugal has quit IRC17:21
TheJuliajroll: rloo: we can discuss it during the discussion or open discussion If that works17:22
yolandaTheJulia,  there have been some reviews from Hironori as well. I'll talk with zshi tomorrow and we'll let you know17:22
jrollsure17:22
TheJuliayolanda: thanks17:22
yolandathx, is great to see progress on that feature!17:22
TheJuliaEveryone done reviewing the whiteboard?17:22
rlooTheJulia: wrt storyboard. what is the plan? can we just DO IT?17:23
TheJuliaI was going to bring that during discussion :)17:23
rlooTheJulia: okey dokey; i can wait :)17:23
TheJuliashort answer yes, long answer, I can have them do it this week and we can start using it say... monday?17:23
TheJuliaAnyway, Moving on to priorities for this week17:24
TheJulia#topic Priorities for this next week17:24
*** openstack changes topic to "Priorities for this next week (Meeting topic: ironic)"17:24
rloofix sushy critical bug17:24
dtantsuryep17:25
rloodtantsur: you know what needs to be done to ^^ ?17:25
dtantsurrloo: review17:25
TheJuliadtantsur: link?17:25
dtantsur#link https://review.openstack.org/#/c/552817/17:25
patchbotpatch 552817 - sushy - Mark Systems/Managers/SessionService optional17:25
rloowhere are we wrt rescue work?17:25
TheJuliaLooks like were in disagreement land with regards to interface methods17:26
TheJuliaand design... again17:26
dtantsur\o/17:26
rlooTheJulia: with rescue?17:26
TheJuliarloo: yup17:27
TheJuliaand deploy17:27
openstackgerritLenny Verkhovsky proposed openstack/ironic master: Infiniband Port Configuration update[1]  https://review.openstack.org/55340017:27
jrollI thought we got rescue done last cycle, except the nova side?17:27
rlooTheJulia: which part/patch of rescue are we talking about, that is in disagreement?17:28
jroll+1, I'm curious17:28
dtantsuradding a new method because for $weird_reason deploy interfaces don't always call boot.prepare_instance..17:29
rlooTheJulia: is it https://review.openstack.org/#/c/546919/?17:29
patchbotpatch 546919 - ironic - Prepare instance to unrescue by deploy interface17:29
TheJulia^that17:29
rloook -- so what needs to be done to move forward. do we need to meet/agree on something?17:29
TheJuliaThere is some inline discussion, I'd like to keep it as a priority this week to see if we can just get some consensus and move forward.17:30
dtantsur++17:30
rlooTheJulia: ok, I'll make a note to look at that. thx.17:30
TheJuliastendulker: In this discussion your patch on fixing for basically fixing the same thing for agent deployments was raised, do you think we can get that revised?17:30
TheJuliaIt is noted as the "better fix" https://review.openstack.org/#/c/499050/  :)17:30
stendulkerTheJulia: I have posted revised patch17:30
patchbotpatch 499050 - ironic - Fix ``agent`` deploy interface to call ``boot.prep...17:30
TheJuliaHeh, that you have17:31
* TheJulia updates priorites list17:31
*** hjensas has quit IRC17:31
stendulkerTheJulia: But one test related to ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode fails. Not able to get exact reason for the failure17:32
rloojroll, others: is that still a critical bug in nova? L11217:32
rloojroll: the importance is 'low' in the bug17:32
TheJuliastendulker: Ugh, I can try to take a look this week17:32
stendulkerTheJulia: Thanks17:33
TheJuliafor nova it's importance may be low, for us it is higher17:33
jrollrloo: I'm not sure I'd call it critical, it's probably high from our perspective (because CI gets into this situation). I updated the patch friday and will poke people today/tomorrow17:33
rloojroll: ok thx17:33
TheJuliaDoes anyone have any other items they would like to see reviewed this week?17:33
rlooTheJulia: i've got another question, wrt L117, 'Required Queens Backport'. do we still need that?17:33
TheJuliarloo: I thought I had deleted that...17:34
TheJuliaetingof: would you be able to revise https://review.openstack.org/#/c/526773/ in the next day or so?17:34
patchbotpatch 526773 - ironic - Add boot mode support to ManagementInterface17:34
* etingof looking17:35
rpiosoTheJulia, etingof: I offered to take another look at that patch.17:35
etingofTheJulia, yes, but I'd like to engage rpioso as well17:35
TheJuliaAny objection to adding it to the priority list so we can make some progress in that direction?17:35
rpioso+117:36
etingof+1!17:36
dtantsurno objections17:36
TheJuliaEveryone good with that list of priorites?17:36
jrollI'm happy17:37
dtantsurLGTM17:37
rloo+117:37
TheJuliaMoving on then!17:37
TheJulia#topic Appointing a bug triaging lead for the coming week17:37
*** openstack changes topic to "Appointing a bug triaging lead for the coming week (Meeting topic: ironic)"17:37
TheJuliaAnyone want to be the vict^Wvolunteer this week?17:38
*** etingof is now known as etingof|afk17:38
* jroll has to step away for a few, sorry - consider me fine with moving the meeting or keeping it as is when we get to that topic17:38
dtantsurI can try getting some time for bug triaging17:39
*** mjturek has quit IRC17:39
dtantsuractually, I do some before every meeting anyway17:39
rloooh, sorry, related to rescue work -- are we planning on doing client release any time soon?17:39
TheJuliaIf we can get some done before thursday, it will help us out. I'll see about getting them to push the buttons for storyboard migration on Friday17:39
rloothx dtantsur!17:39
TheJuliarloo: already done17:39
rlooTheJulia: sweet. thx!17:39
TheJuliano problem17:40
TheJuliaSeems like we should all try to spend time on bugs this week...17:40
*** mjturek has joined #openstack-ironic17:40
TheJuliaAnyway, I'm going to move on to discussion since we really all should try and spend some time looking at launchpad bugs this week17:41
TheJulia#topic Discussion17:41
*** openstack changes topic to "Discussion (Meeting topic: ironic)"17:41
TheJuliaWe have two items... well three, maybe. :)17:41
TheJuliaThe first is do we move the meeting to 2PM or 3PM UTC?17:42
TheJuliaThe results from the time poll can be found at https://doodle.com/poll/6kuwixpkkhbwsibk17:42
*** etingof|afk has quit IRC17:42
dtantsurthis is great for Europe, but I guess we exclude west coast?17:43
TheJuliaAnd those times are friendly-er to Japan in that it may be 11PM or 12PM. We don't have any New Zealand contributors, but it would also mean that the west coast of the united states would have to get up early :)17:43
TheJuliaI am willing to get up for a 7AM meeting, because I <3 you all17:43
dtantsurlike, really early :)17:43
TheJuliaEh, not that early17:44
jlvillalhttps://www.timeanddate.com/worldclock/fixedtime.html?msg=Ironic+meeting&iso=20180327T02&p1=1440&ah=117:44
jlvillalOh wait wrong17:44
jlvillalhttps://www.timeanddate.com/worldclock/fixedtime.html?msg=Ironic+meeting&iso=20180327T14&p1=1440&ah=117:45
*** hjensas has joined #openstack-ironic17:45
*** hjensas has quit IRC17:45
*** hjensas has joined #openstack-ironic17:45
TheJuliaI think the time should also be a little more friendly to stendulker17:45
jlvillalSo 7am here on the west coast of the USA17:45
TheJuliaThoughts/objections? Shall we just vote on it?17:45
stendulkerTheJulia: yes17:45
* dtantsur cannot seriously ask people to wake up at 7am, which is deep night for him17:45
rpiosojlvillal: That's during daylight savings time. It'll change in the fall.17:46
jlvillalSo 2PM UTC is 7AM pacific now. When Daylight Savings Times end it will be 6AM17:46
TheJuliaIt is worth noting that I don't think we have any active contributors in .au or .nz who the time would be the most unfriendly to17:46
TheJuliaI like 6AM less than 7 AM17:46
TheJuliaPerhaps we vote on 3PM UTC or not changing then?17:46
jlvillal3PM times: https://www.timeanddate.com/worldclock/fixedtime.html?msg=Ironic+meeting&iso=20180327T15&p1=1440&ah=117:47
jlvillalFind your location :)17:47
* TheJulia finds it amusing that the website knows I'm in Palm Springs, CA area17:47
rlooso based on the poll, we are talking about 2pm vs 3pm, right? the only diff is jlvillal or hjensas if I read it correctly.17:48
rlooand any future west coast US folks.17:48
rlooso between the two times, much as I'd like hjensas, it seems like 3pm is the saner one?17:48
dtantsurit feels so...17:48
dtantsurso, essentially, move 1 hour earlier?17:49
jlvillalTwo hours17:49
rloois hjensas here?17:49
TheJuliaYes, two hours, we are presently 5PM UTC17:50
rloo(I guess i am wondering if hjensas would like to attend the meeting if he could attend the meeting)17:50
*** weshay_brb is now known as weshay17:50
dtantsurrly?17:50
dtantsurhmm, maybe you're right /me hates timezones17:50
jlvillaldtantsur, https://www.timeanddate.com/worldclock/fixedtime.html?msg=Ironic+meeting&iso=20180327T15&p1=1440&ah=1  Find Berlin :)17:50
dtantsurjlvillal: this link is wrong, that's the problem.. Berlin is not UTC+217:51
dtantsurthat's what confused me17:51
jlvillaldtantsur, Ah, so not 7PM-ish right now where you are?17:51
TheJuliaI know this meeting is presently ?2 AM? for hshiina, so if we would like to vote we can now, or we can defer until next week.17:51
dtantsurah, 27 Mar will be after daylight switch17:51
TheJuliadtantsur: I think we all dislike time zones17:51
jlvillaldtantsur, Sorry I made it for next week :(17:52
dtantsurI think we can vote, his vote is on the poll17:52
* TheJulia tries to remember voting syntax17:52
jlvillal#vote17:52
TheJulia#vote 3pm nochange17:53
* jlvillal is ignored as not meeting operator17:53
dtantsurTheJulia: #startvote Description Options17:53
dtantsuror maybe even #startvote Description? Options17:53
jlvillalyes no. I assume for options17:53
jlvillal#help startvote17:53
rlooSo the choices are 2pm or 3pm, right?17:53
TheJulia#startvote Move_The_Meeting 3PM KeepTheSame17:53
dtantsur#startvote Should we move this meeting to 3pm UTC? Yes, No17:53
openstackUnable to parse vote topic and options.17:53
openstackOnly the meeting chair may start a vote.17:53
jlvillalmeh. Maybe I should submit a patch...17:53
dtantsurTheJulia: copy my message17:53
TheJulia#startvote Should we move this meeting to 3pm UTC? Yes, No17:54
openstackBegin voting on: Should we move this meeting to 3pm UTC? Valid vote options are Yes, No.17:54
openstackVote using '#vote OPTION'. Only your last vote counts.17:54
TheJulia\o/17:54
dtantsur:)17:54
TheJulia#vote Yes17:54
dtantsur#vote Yes17:54
rlooif we say no, then 2pm or we keep it at 5pm?17:54
sambetts#vote Yes17:54
TheJuliano would keep it at this point17:54
rpioso#vote Yes17:54
rloo#vote Yes17:54
rlooi think jroll would also vote yes17:54
hshiina#vote Yes17:54
*** jcoufal has quit IRC17:55
stendulker#vote Yes17:55
TheJuliaSay I'll close voting in about 1 minute17:55
*** jcoufal has joined #openstack-ironic17:56
jlvillal#vote yes17:56
TheJuliaOur next discussion topic is storyboard. If there are no objections, I'll tell infra to push the buttons later this week and we can start using storyboard next monday. There will naturally be an adjustment period, and we may want to have a call to discuss use/patterns next week.17:56
TheJulia#endvote17:56
openstackVoted on "Should we move this meeting to 3pm UTC?" Results are17:56
openstackYes (8): TheJulia, rloo, jlvillal, stendulker, rpioso, dtantsur, sambetts, hshiina17:56
TheJuliaSo, I guess we move the meeting17:56
dtantsuryep17:56
hjensasSorry, I just came in. But 3pm UTC is good for me. :)17:56
TheJulia#action TheJulia to reschedule and send out email.17:56
TheJuliaAwesome, thanks hjensas17:57
TheJuliaAny objections/issues/questions regarding storyboard?17:57
jlvillalTheJulia, So that means you will submit patch?17:57
rloohjensas: great17:57
TheJuliajlvillal: Yes17:57
jlvillalThanks!17:57
TheJuliarloo: jroll: I guess we can discuss nova virt driver stuff in channel when jroll returns.17:57
rlooTheJulia: yup17:57
TheJulia3 Minute Warning17:57
dtantsuranyway 3 minutes is not enough for a nova discussion :)17:58
rloowho else is interested in the nova virt discussion besides dtantsur, TheJulia, jroll, me?17:58
dtantsurI will have to leave soon17:58
rlooadn wrt storyboard, action item TheJulia?17:58
dtantsuryeah, and #agreed on the meeting :)17:58
rloodtantsur: so maybe tomorrow instead, to talk about nova virt17:58
TheJulia#agreed Moving meeting to 3pm UTC17:59
dtantsurdon't wait for me, I guess17:59
TheJulia#action TheJulia to start storyboard migration17:59
jrolltomorrow wfm, sorry about leaving abruptly17:59
dtantsurI'll read the scrollback17:59
rlooTheJulia: do we need to hold off opening/updating bugs during xsition to storyboard?17:59
TheJuliarloo: Only on friday I guess17:59
TheJuliaI'll follow-up18:00
rlooTheJulia: ok, just give us some notice :)18:00
TheJuliaThanks everyone!18:00
dtantsurthanks TheJulia18:00
TheJuliarloo: will do!18:00
TheJulia#endmeeting18:00
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic"18:00
openstackMeeting ended Mon Mar 19 18:00:17 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)18:00
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-03-19-17.00.html18:00
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-03-19-17.00.txt18:00
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-03-19-17.00.log.html18:00
TheJuliadtantsur: jroll: rloo: okay, tomorrow morning US timeframe once we're all awake then? I don't want to move forward on this sooner rather than later this cycle because we had easy consensus from nova and don't want the opinions to shift again18:01
dtantsuryep18:02
jrollTheJulia: I'm free til 1300 EST18:02
jrolland agree18:02
rlooTheJulia: agree on both counts. tomorrow. everyone is invited! :)18:02
TheJuliaSo was the concern why were not just hacking support to do the explicit microversion calls into python-ironicclient?18:02
dtantsurI guess we'll have to do it eventually18:03
openstackgerritMerged openstack/ironic master: Gate: stop setting IRONIC_ENABLED_INSPECT_INTEFACES=inspector  https://review.openstack.org/55384118:03
openstackgerritMerged openstack/ironic-inspector master: devstack: enable "fake" inspection implementation  https://review.openstack.org/55379718:03
TheJuliaI kind of don't think we'll have to18:03
TheJuliathe object based mocking just makes it easy to break interactions and it hides a lot.... and we have a lot of code that is not needed that does special things18:04
TheJuliaAlso there is the whole growing consensus to stop using the client libraries for service to service communication because it turns out that it actually makes it harder18:04
dtantsurthe gate should be back to norm now18:04
TheJulia\o/18:04
pas-haheya, new setuptools!18:06
pas-haand it broke nova and neutron on Pike (at least)18:06
pas-hawe should check our tests as well18:06
dtantsurugh18:06
dtantsurfolks, two simple patches for your review stats: https://review.openstack.org/#/c/543989/ and https://review.openstack.org/#/c/548971/18:06
patchbotpatch 543989 - ironic-tempest-plugin - Add a full set of tests for the IPMI hardware type...18:06
jrollTheJulia: so I agree with you, my thoughts are: 1) I think application developers using the ironic sdk will eventually want per-call microversion support, and 2) the less code we churn, the quicker we can get this done and keep moving. I'm hoping we can get the per-call microversion things done, and then do the rest as a refactor18:06
patchbotpatch 548971 - ironic-inspector - Correct Queens release notes versions18:07
pas-hathe broken part is common though - version comparison in oslo.versionedobjects18:07
*** mjturek has quit IRC18:07
jrollTheJulia: I'm curious if you have some links or something that show this growing consensus about this, I personally haven't seen much of that18:07
*** tesseract has quit IRC18:07
TheJuliajroll: Largely hallway track discussion combined with denver api-sig discussion.18:08
pas-hafwiw setuptools 39.0.0 started process of moving pkg_resources to a separate package... and it seems this does not work as expected anymore18:08
TheJuliadtantsur: Do you remember where those discussions ended up at?18:08
dtantsurI don't, unfortunately18:08
jrollgotcha.18:09
dtantsursee you tomorrow18:09
TheJuliaI do very distinctly remember that it was brought up, and that there was consensus from the api-sig. Also there was a call to NOT use openstacksdk for service to service communication in dublin18:09
*** dtantsur is now known as dtantsur|afk18:09
dtantsur|afko/18:09
TheJuliagoodnight dtantsur|afk18:09
jrollI do recall the latter18:09
TheJuliajroll: I guess I'm not afraid of just doing rest calls with the session client directly at this point because we did it with shade... Rewriting a ton of unit tests and finding broken tests built upon not great assumptions about behavior is going to be a bit more of a headache.18:11
rloopas-ha: :-(. We fix one thing, then something else crops up...18:11
* sambetts --> home 18:12
sambettsnight all o/18:12
TheJuliagoodnight sambetts18:12
*** sambetts is now known as sambetts|afk18:12
rloobye dtantsur|afk, sambetts|afk18:12
jrollTheJulia: yeah, my main thing is that the less code we have to change in nova, the quicker we can get it done. we can get the primary goal done much quicker and then refactor the rest as we go18:13
TheJuliaI think the clean refactor has higher value, even if it is more code. Doing it in two steps should also make it an easier review even if it is a lot of code for the initial testing changes. :\18:15
TheJuliamelwitt: thoughts^18:15
jrollok18:15
jrollwe're low on people-time so I have to ask :)18:15
TheJuliaregardless of what we do, with the object based mocking, the testa re going to have to get blown up and rewritten18:16
rloopas-ha: you think this is broken cuz of what you mentioned? https://review.openstack.org/#/c/545297/18:16
patchbotpatch 545297 - ironic-tempest-plugin - Validate scheduling fields in basic ops scenario18:16
jrollI don't think the tests would change much if we just add the microversion to the call, honestly18:16
rloopas-ha: not the inspector one, the pike ones18:16
TheJulias/testa\ /tests a/18:16
TheJuliajroll: that is correct, but to actually do the right thing and an eventual refactor is still a complete partial detonation of the tests18:17
TheJuliaon a plus side, we'll find all the testing assumptions that are not great if we do it18:17
jrollyes, but it's easier to say "we'll definitely ship this in rocky"18:17
jrollyep18:17
TheJuliaI'll try and discuss with melwitt and we can kind of go from there.18:18
* melwitt is reading18:18
jrollnod18:18
TheJuliabecause I do agree with you, the whole idea is to stop bandaiding and shooting ourselves in the foot18:18
melwittare you discussing whether or not to refactor the tests in a first step change then put the REST call stuff on top?18:18
jrollmelwitt: the question is should we do that, or, should we continue using the object-based stuff, add per-call microversions, and then later refactor to straight REST18:19
TheJuliamelwitt: discussing if it is valuable enough to do. We have no real choice with how the tests are written but to do that, so it would be a bulk test rewrite in a single patch or two, then we could piecemeal routes of the code to be rest based18:19
TheJuliamelwitt: I have a wip you can look at if you want to cry18:20
TheJulia:)18:20
melwittheh18:20
* jroll thinks we're on two different topics, maybe :/18:20
*** AlexeyAbashkin has joined #openstack-ironic18:20
*** stendulker has quit IRC18:20
TheJuliajroll: same topic, two different angles18:20
melwittjroll: I thought we couldn't add per-call microversions to the object-based stuff bc ironicclient doesn't let us?18:20
jrollmelwitt: well yes, we'd fix ironicclient first :)18:20
TheJuliawe would have to wire it completely through, we would keep the dependency18:20
TheJuliathe assumption during the meeting is that we had already gutted our special logic and were just a keystoneauth1 session wrapper18:21
TheJuliawhich is not the case18:21
melwittyeah, okay. fixing ironicclient would be the ideal state, right? and the REST call stuff was just to bridge the gap until that happens (or just leave it as converting back to ironicclient would be a pain)18:21
TheJuliamelwitt: reverse that18:21
openstackgerritNguyen Hai proposed openstack/python-ironicclient master: Follow the new PTI for document build  https://review.openstack.org/55415718:22
TheJuliaThere is the whole desire to do away with client libraries so restification becoes ideal18:22
melwittI see18:22
TheJuliawiring in microversion specific call logic and try/expect catching woudl be the workaround for now I guess18:23
TheJuliasince there was huge resistance to if version x do y logic....18:23
* TheJulia doesn't understand why there was that resistance when discussing in dublin18:23
*** AlexeyAbashkin has quit IRC18:24
* TheJulia feels like we needed more than an hour... and Guinness to be delivered while discussing.18:25
*** trown|lunch is now known as trown18:25
melwittI don't think I caught the details of that. you're suggesting querying ironic version at startup and then "if version X, do Y, else do Z?"18:25
*** trown is now known as trown|compassing18:25
TheJuliamelwitt: we built in revised negotiation logic last cycle to do the if version x, do y else z logic based upon a list of "supported versions"18:26
TheJuliaalthough api-sig guidance is now going towards per call microversioning18:26
*** hshiina has quit IRC18:27
*** anupn has left #openstack-ironic18:27
jrollI'm apathetic to both what order we do the code in, and how the logic works, fwiw18:28
melwittTheJulia: sorry, I'm afraid I'm not following. you're saying last cycle in the ironic driver logic was added to do the "if version x" thing already? then what are we trying to solve this cycle?18:28
jrollI just want to make sure we get it done, and wanted to ask the question if it's worth doing the rest thing now or wait for later18:29
TheJuliamelwitt: sorry, in python-ironicclient we added logic to help expose what the remote server was speaking version wise18:29
TheJuliawhat we're trying to solve this cycle is the horrible habit of a singular microversion pin that breaks upgrade testing... ever... single... cycle18:29
TheJuliawell, not direclty, but it prevents us from being able to route aroudn it so we're in a situation were we have to make a job non-voting just to make progress on completely unrelated areas until we get our grenade job working again18:30
*** rama_y has joined #openstack-ironic18:31
melwittokay, so the choices are, 1) leverage the version exposure from ironicclient in the ironic driver to behave differently based on version, 2) "fix" ironicclient to do per-call microversions, 3) raw REST calls18:31
TheJuliaSo going back to discussion around Denver timeframe was that we would create a list of known supported microversions, update the ironic virt driver to know about that list. That list would be sent to python-ironicclient which would then negotiate the higest available version, and expose a property (which is done)18:31
TheJuliathat property could have then been used for if x version do y, else z18:31
TheJuliamelwitt: basically, yes and that is also in order of easy to difficult18:32
pas-harloo: does not seems so, until now we've seen only broken unit tests18:33
pas-ha(all related to versioned objects)18:34
*** serlex has joined #openstack-ironic18:34
rloopas-ha: ok. then something else is broke.n. maybe.18:34
*** serlex has quit IRC18:34
pas-hamight be :-(18:34
rloopas-ha: i'll wait a bit to see if things 'settle down'...18:34
melwittTheJulia: yeah. it seems like 2) would be the most practical option, IMHO. and as jroll mentioned earlier would have utility beyond this particular issue (allowing client users to request specific microversions)18:35
pas-harloo: on the other hand there is this http://logs.openstack.org/97/545297/10/check/ironic-dsvm-standalone-pike/33c79bb/logs/screen-q-agt.txt.gz18:35
melwitt*per-call18:36
*** e0ne has joined #openstack-ironic18:36
rloopas-ha: ouch.18:36
TheJuliathere is another issue with per-call being problematic18:37
* TheJulia goes and finds lunch to try and remember18:38
*** milan_ has quit IRC18:38
*** Goneri has quit IRC18:41
*** openstackgerrit has quit IRC18:48
*** openstackgerrit has joined #openstack-ironic18:52
openstackgerritNguyen Hai proposed openstack/ironic master: Follow the new PTI for document build  https://review.openstack.org/55347318:52
openstackgerritMerged openstack/sushy-tools master: Abstract away the virtualization management interface  https://review.openstack.org/52332118:57
*** krtaylor has joined #openstack-ironic18:59
TheJuliamelwitt: So I think that belief that per-call couldn't be done came out of a belief that sessionclient just gave it to us for free over this past cycle, and that in reality ironic had a lot of code between the the entry into the client and the http request going out the back-end of the client. It looks like it could be done with work on python-ironicclient where we could wire it all in to all the individual method19:04
TheJuliacalls. The downside is we would need to either abandon the default microversion behavior upon connection/initial negotiation, or treat it as an override, or keep the "pin" but use latest" which allows the client to try to speak the most highest known version. I'm not sure how well IRONIC_API_VERSION="latest" and versions on each call would be received by nova reviewers.19:04
* TheJulia wonders if we just bump the minor and remove the hard pin internally19:06
jrollhas anyone noticed that our specs pages look (IMHO) terrible with the openstackdocstheme that we switched to last week? e.g. http://specs.openstack.org/openstack/ironic-specs/specs/9.0/boot-from-volume-reference-drivers.html19:09
* TheJulia blinks19:10
TheJuliaNot pretty on a mobile device :(19:10
jrolleven on a computer :(19:10
jrollthe commit message and bug don't say why the switch, though oslosphinx's README implies it's dead19:11
melwittTheJulia: yeah, not sure what the best practice is there. dansmith, do you happen to know what would be recommended for ironicclient version (if per-call microversion support is added) when initializing the client object upon startup?19:13
*** zshi has quit IRC19:13
dansmithmelwitt: I'm not sure what you're asking.. if it's per-call, then you don't need to initialize it at startup right?19:14
dansmithI mean, you could look for the max of all the minimums across all the calls and make sure the server has at least that value I guess19:14
TheJuliathats a good point, resource tracking will still cause the client to connect19:15
dansmithbut, we don't do that in, for example, novaclient AFAIK19:15
melwittthat's what I wasn't sure about. I think when you initialize the client object, you have to pass a version also, maybe to act as the default. at least it looks like novaclient python API works that way19:15
TheJuliawe would still need to gut our default out19:15
dansmithI would just check for some sane minimum if you want, and then fail per-call if you can't do something because of a versions19:15
dansmith*version19:15
TheJuliaor disregard all of that logic19:15
dansmithif you version per call, there's really no default19:15
TheJuliawell, that would require all calls to be called with their specific default19:16
TheJuliaa global overarching default though would still exist19:16
dansmithit just depends on how much you hide in the client19:17
melwittunderneath yeah, there will be a default because AFAIK you can't not have one. just if you specify on every call, it'll never fall back to the default19:18
TheJuliaThat is what I'm thinking19:18
dansmithdidn't you say you were going to convert to raw requests for this stuff?19:18
jrolloh my, what did I start19:19
dansmithor is this that the keystone session has to have something for the default?19:19
melwittwe were talking through the options because the raw request stuff will be a very large change19:19
TheJuliabasically the unit tests would be a complete initial rewrite19:20
openstackgerritAleksandra Bezborodova proposed openstack/sushy-tools master: Add unit tests for emulator  https://review.openstack.org/55432619:20
*** AlexeyAbashkin has joined #openstack-ironic19:20
TheJuliaI say that because we would want unit tests that could tell us if the new rest statements are working as expected and presently we mock ironicclient completely so all behavior is masked19:22
melwittyeah. so we were thinking maybe ironicclient per-call microversion support might be a good stepping stone and the raw request refactor could be a later thing to take more time on19:23
dansmithyou don't really need to pass a microversion to ironicclient then do you?19:24
*** fragatina has quit IRC19:24
TheJuliadansmith: what do you mean?19:24
dansmithif you have abstract methods you just call with arguments, it knows what version(s) it supports for that call, and tries to do them against the server, or fails if you ask for something it can't do?19:24
*** AlexeyAbashkin has quit IRC19:24
TheJuliaThat would be a maintenance nightmare for something intended to be lightweight19:25
*** zshi has joined #openstack-ironic19:26
dansmithum, okay19:26
TheJuliaI thought, in the discussion at least my perception of the discusison in dublin was that visibility was desired by nova19:26
dansmithsounds like ya'll don't need my help19:26
jrollTheJulia: I think what dansmith is saying is put the version handling logic in the thing doing the REST call (whether that's in nova or ironicclient), assuming that we do the try/except catching logic and not the if/else logic19:30
jrolleither way you have to know the version and fail if you can't, just a matter of where that code lives19:30
* jroll hopes that makes sense, words are hard19:30
melwittisn't TheJulia saying that ironicclient already does that? and the decision point is whether or not it's "okay" for ironic driver to react differently based on the return/error from ironicclient?19:31
TheJuliajroll: I guess my frustration there is we've gone completely full circle with the slight change now, we declare it in the caller and hope the remote side has a sufficent version19:31
jrollgotcha.19:32
TheJuliamelwitt: Essentially yes, our support policy is 1.1->whatever our latest version is at present, if we start ripping out stuff... well.. then it gets complicated19:32
*** crushil has quit IRC19:32
TheJuliaand that actually still wouldn't solve the problem as to why we ended up being pinned on version 1.919:33
TheJuliaThe method did not change, but the resulting behavior changed and the community decision was to attempt to mask the breaking change as much as possible19:33
*** dprince has quit IRC19:33
* TheJulia feels like beer is required19:33
jrollTheJulia: like I said, I'm fine however we get it done, I'm just trying to understand if the options are equally good, and if so, which is the path of least resistance. AIUI at the moment, pure rest is the better solution, and at least one person (you) thinks that we can still accomplish that this cycle. so unless we have a reason not to do that, let's go that route19:34
*** e0ne has quit IRC19:34
TheJuliajroll: you've not realized I'm super optimistic.... right?19:35
melwittI'm concerned if there's a misunderstanding blocking the easiest solution 1) we mentioned earlier19:35
melwitttbh, it's not clear to me if/why anyone opposes it19:35
TheJuliaI feel like the opposition to easy is the desire for perfection19:36
TheJuliaI'm fine with easy, in fact I prefer it19:36
TheJuliaas long as it makes sense and doesn't shoot us in the foot19:36
jrollTheJulia: about getting it done? I didn't get that from this conversation. if we don't think we can do (3) this cycle, then I think we should aim for (2)19:36
TheJuliajroll: I was super confident it could be done in like a week until I started digging in the virt driver unit tests last week and lost a day to what was actually bad test assumptions19:37
jrollmy problem with (1) is it requires instantiating a new ironicclient instance to go try a different microversion, which is fine, just feels hacky (and makes calls to keystone and such)19:37
TheJuliajroll: we now support downgrading the request without a new client...19:37
jrollorly19:38
TheJuliabut only for a list of versions19:38
TheJuliayarly19:38
jrollah, we pass versions to try?19:38
TheJuliawe can pass a list to the os_ironic_api_version now19:38
jrollgotcha19:38
jrollthat's... interesting, but if you need to change the arguments (e.g. decide whether to pass configdrive to rebuild), it doesn't help, right19:38
TheJuliaand should we somehow hit an even older version, it should then downgrade further19:39
TheJuliajroll: that is why we added the ability to get the version out of the existing client19:39
jrollnod19:39
jrollso it does seem we have a really easy path, then, we just want 'better'19:40
TheJuliaIt wouldn't be hard to provide a reset mechanism to that, but the cleaner thing would be a kwarg of microversion that we pickup on and act upon19:40
jrollagree19:40
jrollso we have done, better, and best options, in order of amount of work19:41
TheJuliathat is a good way of putting it, done seemed to be not liked, so better seems logical. I guess I'll start hacking on that in the morning19:42
*** deadnull has joined #openstack-ironic19:42
jrollif you think best is right, don't let me stop you, I'm just waving my hands around and trying to be pragmatic19:43
jroll:)19:43
jrollat any rate, thank you for taking this on19:43
melwittTheJulia, jroll: fwiw, I think it would be fine to do option 1) for the version stuff we discussed earlier. if ironicclient has version negotiation built in and will return/error based on what it tried to do, ironic driver can react to that and do the right thing19:44
jrollright on, thanks melwitt. I'm also cool with that19:45
melwittthe thing people were opposed to was, the suggestion to change the upgrade order to "solve the problem"19:45
melwittwhich is totally not related to option 1)19:45
jroll++19:45
*** openstackgerrit has quit IRC19:48
TheJuliaI would absolutely love to be able to change the order as the underlying openstack tooling for upgrade testing is no longer cutting it and anything to make the pain less would be appreciated. But at the same time, at least offering the ability to be a little more tolerant seems reasonable (which amazingly enough, there was agreement on), as long as we don't change the default testing order.19:50
TheJuliaThe reality, as I understand it, of changing that upgrade order, is it is never going to happen short of replacing grenade.19:51
melwittyeah, to be clear, we don't want to change the upgrade order. but option 1) for updating ironic driver to handle the already supported ironicclient version negotiation is cool19:51
jrollI don't think everyone is opposed to changing the upgrade order, I just think they want ops to have lots of notice and noise before it happens. or at least that's the camp I'm in.19:52
melwittack19:52
TheJuliajroll: agreed, and really it should be moving forward as much about upgrade order, but declared interoperability between component versions. At least in a perfect universe... which might exist in the theoretical multiverse.19:53
jroll:)19:54
*** slagle has quit IRC19:56
*** milan has joined #openstack-ironic19:56
TheJuliaSomeone posted a really funny clip of what each MCU/Xmen character would say upon meeting and Beast says he created a device to cross the multiverse... and the very last line is deadpool saying "Fox and Disney made a deal"19:57
TheJulias/clip/picture/19:57
*** slagle has joined #openstack-ironic19:58
*** deadnull has quit IRC20:03
jrollheh20:05
*** jcoufal has quit IRC20:18
*** AlexeyAbashkin has joined #openstack-ironic20:21
*** openstackgerrit has joined #openstack-ironic20:22
openstackgerritNguyen Hai proposed openstack/python-ironicclient master: Follow the new PTI for document build  https://review.openstack.org/55415720:22
*** jcoufal has joined #openstack-ironic20:23
*** Sukhdev_ has joined #openstack-ironic20:25
*** livelace has joined #openstack-ironic20:25
*** AlexeyAbashkin has quit IRC20:26
*** jcoufal_ has joined #openstack-ironic20:33
*** jcoufal has quit IRC20:35
*** jcoufal_ has quit IRC20:38
*** trown|compassing is now known as trown|ruck20:43
*** Goneri has joined #openstack-ironic20:43
*** fragatina has joined #openstack-ironic20:52
*** jcoufal has joined #openstack-ironic20:54
*** anupn has joined #openstack-ironic20:59
*** jtomasek has quit IRC21:00
*** trown|ruck is now known as trown|outtypewww21:01
*** itlinux has quit IRC21:06
*** livelace has quit IRC21:08
*** e0ne has joined #openstack-ironic21:09
*** mgoddard has quit IRC21:14
*** jcoufal_ has joined #openstack-ironic21:18
*** jcoufal has quit IRC21:18
*** jcoufal_ has quit IRC21:28
*** jcoufal has joined #openstack-ironic21:29
*** jcoufal_ has joined #openstack-ironic21:34
*** jcoufal has quit IRC21:35
*** jcoufal has joined #openstack-ironic21:37
*** ribe has joined #openstack-ironic21:37
openstackgerritLin Yang proposed openstack/sushy master: Fix wrong message of invalid boot "enabled" parameter  https://review.openstack.org/54950321:38
*** jcoufal_ has quit IRC21:39
*** jcoufal has quit IRC21:41
*** jcoufal has joined #openstack-ironic21:43
*** gyee has quit IRC21:50
*** bfournie has quit IRC21:50
*** baha has quit IRC21:50
*** jcoufal has quit IRC22:01
*** e0ne has quit IRC22:12
*** AlexeyAbashkin has joined #openstack-ironic22:20
openstackgerritMerged openstack/ironic-inspector master: Switch documentation to hardware types  https://review.openstack.org/54528522:22
*** AlexeyAbashkin has quit IRC22:25
*** rcernin has joined #openstack-ironic22:34
*** Goneri has quit IRC22:37
*** milan has quit IRC22:41
*** bfournie has joined #openstack-ironic23:07
*** rpioso is now known as rpioso|afk23:07
*** cdearborn has quit IRC23:18
*** AlexeyAbashkin has joined #openstack-ironic23:20
*** AlexeyAbashkin has quit IRC23:24
*** masber has joined #openstack-ironic23:27
*** rbudden has quit IRC23:40
*** Sukhdev_ has quit IRC23:44
*** rama_y has quit IRC23:46
*** r-daneel has quit IRC23:49

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!