| *** ysandeep|away is now known as ysandeep | 05:36 | |
| *** abhishekk is now known as akekane|home | 06:00 | |
| *** akekane|home is now known as abhishekk | 06:00 | |
| *** rpittau|afk is now known as rpittau | 07:07 | |
| *** jpena|off is now known as jpena | 07:38 | |
| *** mgoddard- is now known as mgoddard | 07:58 | |
| *** ykarel is now known as ykarel|lunch | 08:24 | |
| *** ysandeep is now known as ysandeep|lunch | 09:12 | |
| *** ysandeep|lunch is now known as ysandeep | 09:36 | |
| *** ykarel|lunch is now known as ykarel | 10:04 | |
| *** jpena is now known as jpena|lunch | 11:34 | |
| sean-k-mooney | fungi: clarkb hi could ye take a look at https://review.opendev.org/c/openstack/project-config/+/787523 when ye have time. we would like to start using the review priority lable in nova for FF and RC period if we can | 12:18 |
|---|---|---|
| fungi | sean-k-mooney: so this is the first use of copyAnyScore persistence in our acls, i guess? | 12:21 |
| fungi | does this mean other projects are resetting review-priority votes after revisions are pushed? | 12:22 |
| sean-k-mooney | fungi: i guess so or they are using copyMinScore and copyMaxScore | 12:23 |
| sean-k-mooney | what we were trying to do was make it so its sticky | 12:23 |
| sean-k-mooney | e.g. the core team can set a review priorty on something and have it stay until its removed by them | 12:23 |
| fungi | yeah, it seems reasonable, i'm mostly just wondering how it's working for other teams at this point who weren't using copyAnyScore | 12:24 |
| fungi | i'll find some examples | 12:24 |
| sean-k-mooney | cinder have min and max set to true so i guess that is providing the same behavior | 12:24 |
| sean-k-mooney | if you think i should do it differently let me know an ill update it. thanks for taking a look | 12:25 |
| fungi | yeah, i guess copyMaxScore+copyMinScore is equivalent to copyAnyScore when the range is -1..+1 or smaller | 12:26 |
| sean-k-mooney | i guess the difference would show up if you had muliple review priorities | 12:27 |
| sean-k-mooney | im not really sure | 12:27 |
| *** jpena|lunch is now known as jpena | 12:31 | |
| *** rpittau is now known as rpittau|afk | 13:42 | |
| opendevreview | Merged openstack/project-config master: New project: OVN BGP Agent https://review.opendev.org/c/openstack/project-config/+/805802 | 13:54 |
| *** ysandeep is now known as ysandeep|away | 14:41 | |
| *** ykarel is now known as ykarel|away | 14:43 | |
| clarkb | sean-k-mooney: fungi: I think copyAnyScore wasn't available on old gerrit which is why it wasn't used | 15:04 |
| fungi | makes sense | 15:10 |
| clarkb | I've confirmed our 3.2 docs say copyAnyScore is valid there at lest | 15:12 |
| clarkb | which is sufficient for landing this change | 15:12 |
| clarkb | sean-k-mooney: fungi: one thing I'm not sure about is if we need to copyAllScoresIfNoCodeChange and copyAllScoresonTrivialRebase since copyAnyScore should be sufficient? | 15:13 |
| fungi | yeah, i didn't consider that but it should be covering those behaviors as a superset anyway | 15:13 |
| fungi | so the result will be a lot more concise than existing acls which implement this label, which makes it a good template for adjusting them to be consistent in the future | 15:14 |
| clarkb | yup I just left a soft -1 on the change asking for that cleanup to avoid unnecessary cargo culting in the future | 15:15 |
| clarkb | If we really want to land it today I think we can do that as is, but would prefer to land it iwthout the unnecessary bits | 15:15 |
| fungi | agreed, and a change to fix up the other acls later if this works out would be cool too | 15:17 |
| *** jpena is now known as jpena|off | 15:39 | |
| sean-k-mooney | clarkb: i was unsure about that also | 15:54 |
| sean-k-mooney | clarkb: i can proably respin this quickly we would like to have this avaiable before FF just to help organise things but it does not have to be today | 15:55 |
| fungi | sean-k-mooney: i'm happy to go ahead and approve it if you remove those additional lines | 15:56 |
| sean-k-mooney | ok let me grab a clean terminal and ill update it shortly | 15:57 |
| fungi | i can also revise it if you want | 15:58 |
| sean-k-mooney | its ok i have it open i just have a differnt rebase ongoing in my other window | 16:00 |
| opendevreview | sean mooney proposed openstack/project-config master: Add review priority label to nova deliverables https://review.opendev.org/c/openstack/project-config/+/787523 | 16:02 |
| fungi | heh, i get it. i usually have a dozen or more terminal sessions going at the same time | 16:02 |
| clarkb | looks like fungi beat me to approving it. Thanks | 16:06 |
| opendevreview | Merged openstack/project-config master: Add review priority label to nova deliverables https://review.opendev.org/c/openstack/project-config/+/787523 | 16:23 |
| *** odyssey4me is now known as Guest5585 | 18:56 | |
| *** sshnaidm is now known as sshnaidm|afk | 19:12 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!