Friday, 2019-04-19

*** yamamoto has joined #openstack-infra00:02
*** mattw4 has quit IRC00:02
clarkbcorvus: we also need an update to the zuul tenant config right?00:03
clarkbyour zuul key file moves made me think of that00:03
*** igordc has quit IRC00:04
fungioh, great point00:04
*** yamamoto has quit IRC00:08
*** yamamoto has joined #openstack-infra00:08
*** samueldmq has quit IRC00:08
fungii've now got to the point where it's producing `git diff` outputs like this per project+branch: http://paste.openstack.org/show/749517/00:12
*** eernst has quit IRC00:16
*** eernst has joined #openstack-infra00:16
fungiso the basic pattern matching and tempfile handling seems to be working00:16
corvusclarkb: yes... fungi maybe we can just add "zuul/main.yaml" to the list of files to rewrite? :)00:16
fungiyep00:16
fungiadded00:19
*** diablo_rojo has quit IRC00:22
fungiis there one true and canonical mailing list archive entry i should link in commit messages?00:25
fungiseems like http://lists.openstack.org/pipermail/openstack-infra/2019-April/006314.html may have been the first announcement to the infra ml?00:26
corvushrm.  or perhaps at least reasonably truthy?  :)00:26
corvushttp://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html  has more background but is less current00:26
corvusand http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html is relevant to some (most?) repositories00:28
corvusfungi: i think the answer to your question is "of course not"  :)00:28
fungii'll link both for good measure00:28
corvusyeah, i think multiple links is the way to go here00:29
fungiis https://opendev.org/ broken for anyone else?00:29
corvusfungi: no, but i'm on ipv4, are you using v6 now?00:29
funginope, i'm tethered to a wireless modem using ipv400:29
fungii'll just blame t-mobile00:30
fungiour broadband is still offline00:30
* fungi mutters00:30
fungican someone who has a real internet connection remind me whether we have contact info displayed at that homepage?00:30
corvusperhaps they object to the magenta logo?00:30
fungithat's likely it00:30
corvusfungi: yes, mailing list and irc00:31
fungiexcellent, thanks!00:31
corvusit's even under a section headed "Contact info"00:31
fungii'll just link to the main url for now but we can tweak in review00:31
*** gyee has quit IRC00:31
corvushttps://opendev.org/#contact-info if you want to deep-link  (we do have anchors!)00:32
corvusalso, we should update that page, since it says we're going to move gerrit later.00:32
*** markvoelker has quit IRC00:37
mordredcorvus: time is relative?00:41
corvustime is an illusion.  lunchtime doubly so.00:41
* corvus saves fungi from typing that over the wireless modem00:41
fungithank you h2g200:42
funginearly done now. i think all that's left is the gerrit acl file moves00:51
*** eernst has quit IRC00:54
*** eernst has joined #openstack-infra00:55
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add triggers information to pipeline list  https://review.openstack.org/63767000:55
openstackgerritTristan Cacqueray proposed openstack/diskimage-builder master: openssh-server: enforce sshd config  https://review.openstack.org/65389000:58
*** mriedem has quit IRC00:59
*** michael-beaver has quit IRC01:00
*** nicolasbock has quit IRC01:09
*** ricolin has joined #openstack-infra01:09
*** zhangfei has joined #openstack-infra01:17
*** zhangfei has quit IRC01:23
*** zhangfei has joined #openstack-infra01:25
openstackgerritJeremy Stanley proposed openstack-infra/system-config master: Add a opendev migration repo rename scripts  https://review.openstack.org/65313801:33
fungithere it is now minus the git mv logic for the acl files01:34
fungiclarkb: corvus: mordred: ^01:34
fungii'm doing a benchmark run on it to see how long to expect it to take tomorrow01:34
clarkbfungi: for the run now should we go aheadandpush up the projects.yaml and zuul tenant config changes?01:36
clarkbthat way they can go through ci and all that?01:36
clarkbif we need a new ps tomorrow we can do that01:36
fungithat's certainly an option01:37
fungionce i get the acl file moves added i can push a copy of the result up for review01:37
fungithough spot checks of the entire corpus are probably easier done locally on review.o.o01:37
fungii'm rsyncing a fresh copy into /opt/fungi-testing/ now and will start the opendev-patching run for it once it concludes, though i need to generate a more updated repos.yaml with the opendev-migrate script first01:39
fungiokay, test run is underway01:43
*** hwoarang has quit IRC01:46
*** hwoarang has joined #openstack-infra01:48
fungiand i've got the acl mover routine written now too, just waiting for the current test run to complete so we can get some metrics01:56
fungii also tweaked the regex not consider _ and - as possible separators for repository names, just in case we end up with any unwanted substring matches from that (though they're likely to be benign if we do, easy to include at least, unlike . which also tends to get used as a separator in filenames, like for extensions)01:58
*** bhavikdbavishi1 has joined #openstack-infra01:59
*** bhavikdbavishi has quit IRC01:59
*** bhavikdbavishi1 is now known as bhavikdbavishi01:59
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: honor allowed-labels setting in the REST API  https://review.openstack.org/65389502:01
clarkbfungi: not sure I grok the thing about _/-02:04
clarkbwe split on / right?02:04
fungiif we're moving (made-up example) openstack/nova and not openstack/nova-tempest-plugin then the regex seeing - as a possible boundary for the match could result in the latter getting the former's rules applied02:05
clarkbah02:05
fungi([^a-z0-9_-]|^)(%s)([^a-z0-9_-]|$)02:06
fungiis what we're searching for in lines of text02:07
fungiwhere %s is a list of possible repository name02:07
fungis02:07
fungipreviously i had ([^a-z0-9]|^)(%s)([^a-z0-9]|$)02:08
fungiand in an even earlier iteration is was something like ([ /]|^)(%s)([ /]|$)02:09
fungibefore i realized i was missing lines where there was a = before the repository name (for example in .gitreview files)02:09
fungiokay, not too shabby... 32m34.109s (real)02:16
fungiso we should plan tomorrow for roughly half an hour to patch all the repos02:16
clarkband is the plan to push all that into gerrit or do it in place or?02:16
fungipush it locally on the filesystem02:17
clarkbbypassing gerrit?02:17
fungithe script clones from the /home/gerrit2/review_site/git bare repos into temporary directories (context-managed so there's only one existing at a time) and then pushes directly back to the corresponding branches of the bare repos after committing edits for them02:18
fungibypassing the gerrit software, right02:18
*** roman_g has quit IRC02:18
fungiall local file i/o on the review server02:19
clarkbok so we need to plan to do that with gerrit off, to avoid any races02:20
clarkbthough zuul is unlikely to merge anything before hand anyway :)02:20
fungiyes, that was the expectation02:20
fungibasically do this as part of the rename outage for the gerrit service02:21
clarkbgot it02:21
fungialong with running the rename_repos playbook02:21
fungii'm just testing the acl file moves now and then will push up the project-config change for preliminary review02:22
clarkbsounds good tha ks02:26
openstackgerritJeremy Stanley proposed openstack-infra/system-config master: Add a opendev migration repo rename scripts  https://review.openstack.org/65313802:36
openstackgerritJeremy Stanley proposed openstack-infra/project-config master: OpenDev Migration Patch  https://review.openstack.org/65390002:38
fungiclarkb: corvus: mordred: ^ that's the change the script would push locally for project-config on the gerrit server02:38
fungizuul is, of course, instantly unhappy with it because of the zuul configuration changes02:39
mordredsilly zuul02:41
fungii mean, understandably unhappy as we're renaming a ton of projects in zuul/main.yaml to things which are not (yet) present on gerrit02:42
fungimy faculties are waning... anybody know why the environment variables i set in https://review.openstack.org/653138 tools/opendev-patching line 30 aren't used by git commit?02:48
*** jamesmcarthur has joined #openstack-infra02:48
fungiyay! looks like my real internet connection finally returned to its definition of operational02:49
*** rosmaita has left #openstack-infra02:50
mordredfungi: yay!02:51
mordredfungi: mine has gone away, along with the power02:51
fungi:/02:51
mordredyay for tethering laptops to phones!02:51
funginideed02:52
*** jamesmcarthur has quit IRC02:53
clarkbfungi: not at first glance02:58
*** jamesmcarthur has joined #openstack-infra02:58
clarkbarethey the right env vars for git?02:59
mnaserclarkb: on my googling it seems like they are03:00
fungiyeah, i'm trying to figure out which manpage covers those03:00
mnaserapparently03:00
mnaserPopen starts a new process so it maybe doesn't super properly inherit the env03:01
mnasermaybe subprocess.call might work better, I dunno.03:01
mordredthe use of env should make that work03:01
mnaser"If env is not None, it must be a mapping that defines the environment variables for the new process; these are used instead of inheriting the current process’ environment, which is the default behavior."03:02
mnaseryeah..03:02
mordredmnaser, fungi: maybe you can't use update like that03:02
mnaseroh maybe os.environ is weird like that03:03
fungioh! i think you may be right03:03
mordredupdate is in place modification, it doesn't return anything03:03
fungii'll move the update out to a named dict03:03
mordredyeah03:03
fungihurr03:03
mnaserthere is a relationship between the type of mistakes you do and how much experience in software dev you have :p03:04
mnaserthe more you do, the less likely you consider fundamental stuff as solutions :p03:04
* mordred thinks update should return the dict it's updating03:04
fungifor some reason i assumed it did, but yeah03:05
mnaserit's the logical thing03:05
*** irclogbot_2 has quit IRC03:05
mnaserbut then again words.join(' ') is the logical thing too but python be python03:05
*** edmondsw has quit IRC03:08
*** irclogbot_0 has joined #openstack-infra03:08
openstackgerritJeremy Stanley proposed openstack-infra/system-config master: Add a opendev migration repo rename scripts  https://review.openstack.org/65313803:14
fungiyep, updating a named dict and then using that seems to have solved it, as expected03:14
fungialso i put a few more comments in03:14
clarkbwith that weshould be quite ready now?03:17
fungii believe so03:18
fungii'm leaving comments on that change indicating how i've been invoking it03:18
clarkblooking at the project config acl moves I wouldve expected more03:19
clarkbjjb/jenkins-job-builder for example03:19
fungihrm, yeah03:21
fungioh!03:21
fungii need to ensure the parent directories for new namespaces are created03:22
fungifix coming03:22
clarkbskimming the gerrit/projects.yaml and zuul.d/projects.yaml things look as I expect them03:25
clarkbwe may have to disable the sort checkers on some of these files03:27
clarkbor plan to do followups that sort things03:28
fungiyeah, likely so03:28
clarkbbut I'm not seeing any other errors03:28
*** eernst has quit IRC03:28
*** jamesmcarthur has quit IRC03:32
*** markvoelker has joined #openstack-infra03:33
*** d34dh0r53 has joined #openstack-infra03:36
*** cloudnull has joined #openstack-infra03:37
*** eglute has joined #openstack-infra03:39
openstackgerritJeremy Stanley proposed openstack-infra/system-config master: Add a opendev migration repo rename scripts  https://review.openstack.org/65313803:42
openstackgerritJeremy Stanley proposed openstack-infra/project-config master: OpenDev Migration Patch  https://review.openstack.org/65390003:42
funginow with more acl!03:42
clarkbwoo03:43
fungii added a bunch of notes in a review comment on https://review.openstack.org/653138 too03:50
fungisince i likely won't be around when these scripts get run, i want to make sure i have provided adequate guidance (as well as sufficient code comments to aid in debugging, should that become necessary)03:51
fungialso feel free to take over the change and make adjustments to commit message wording, author/committer info or whatever else03:53
fungiit's approaching midnight here, so i really need to disappear03:53
*** bhavikdbavishi has quit IRC03:58
*** bhavikdbavishi has joined #openstack-infra04:00
*** jamesmcarthur has joined #openstack-infra04:01
clarkbgood night04:01
fungithanks! you too04:04
fungii'll likely already be out of the house doing anniversary things by 15:00z, but i'll try to check in before i leave and whenever possible when i'm back04:05
fungiand plan to be around all weekend/week to fix all the things04:06
*** imacdonn has quit IRC04:08
*** jamesmcarthur has quit IRC04:08
*** imacdonn has joined #openstack-infra04:08
*** kjackal has joined #openstack-infra04:34
*** mujahidali has joined #openstack-infra04:36
*** bhavikdbavishi1 has joined #openstack-infra04:36
*** bhavikdbavishi has quit IRC04:37
*** bhavikdbavishi1 is now known as bhavikdbavishi04:37
*** jamesmcarthur has joined #openstack-infra04:44
*** kjackal has quit IRC04:45
*** jamesmcarthur has quit IRC04:48
*** lpetrut has joined #openstack-infra05:12
*** mujahidali has quit IRC05:19
*** jamesmcarthur has joined #openstack-infra05:21
*** jamesmcarthur has quit IRC05:27
*** mujahidali has joined #openstack-infra05:34
*** kjackal has joined #openstack-infra05:44
openstackgerritMasayuki Igawa proposed openstack/os-testr master: Deprecate ostestr command  https://review.openstack.org/57363605:56
openstackgerritMasayuki Igawa proposed openstack/os-testr master: Deprecate ostestr command  https://review.openstack.org/57363605:58
*** kjackal has quit IRC06:14
*** kjackal has joined #openstack-infra06:14
*** whoami-rajat has joined #openstack-infra06:15
*** ykarel|away has joined #openstack-infra06:15
*** pgaxatte has joined #openstack-infra06:16
*** jamesmcarthur has joined #openstack-infra06:23
*** e0ne has joined #openstack-infra06:26
*** markvoelker has quit IRC06:27
*** e0ne has quit IRC06:28
*** jamesmcarthur has quit IRC06:28
*** sajauddin has joined #openstack-infra06:29
sajauddinI am from PowerKVM team, working on Openstack CI for Power hardware.06:30
sajauddinI am trying to setup ZuulV3 so that we can upgrade existing ZuulV2 node to ZuulV306:30
sajauddinInstallation part is done. Trying to configure dependent nodes like nodepool, gerrit and setup few pipelines/jobs for testing06:32
sajauddinCan anyone help me with any documentation for reference? Anyway I am using zuul official documentation.06:32
*** lpetrut has quit IRC06:34
*** e0ne has joined #openstack-infra06:36
*** e0ne has quit IRC06:38
*** e0ne has joined #openstack-infra06:38
*** chandankumar is now known as raukadah06:40
*** mujahidali has quit IRC06:42
*** apetrich has quit IRC06:44
*** jamesmcarthur has joined #openstack-infra06:45
*** sajauddin has quit IRC06:51
*** jamesmcarthur has quit IRC06:51
*** rpittau|afk is now known as rpittau06:52
*** pcaruana has joined #openstack-infra07:12
*** yolanda_ has joined #openstack-infra07:24
*** bhavikdbavishi has quit IRC07:25
*** bhavikdbavishi has joined #openstack-infra07:25
*** jamesmcarthur has joined #openstack-infra07:27
*** markvoelker has joined #openstack-infra07:27
*** dciabrin_ has joined #openstack-infra07:29
*** jamesmcarthur has quit IRC07:32
*** lpetrut has joined #openstack-infra07:34
*** e0ne has quit IRC07:37
*** liuyulong has quit IRC07:39
*** e0ne has joined #openstack-infra07:43
*** ykarel|away has quit IRC07:50
*** ykarel has joined #openstack-infra07:50
*** slaweq has quit IRC07:53
*** bhavikdbavishi has quit IRC07:54
*** e0ne has quit IRC07:55
*** helenafm has joined #openstack-infra07:59
*** bhavikdbavishi has joined #openstack-infra08:00
*** markvoelker has quit IRC08:01
*** e0ne has joined #openstack-infra08:04
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Sort gerrit/projects.yaml  https://review.openstack.org/65391808:05
*** kjackal has quit IRC08:06
*** e0ne has quit IRC08:07
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Sort zuul/main.yaml again  https://review.openstack.org/65391908:09
*** jamesmcarthur has joined #openstack-infra08:12
*** e0ne has joined #openstack-infra08:15
*** jamesmcarthur has quit IRC08:17
*** bhavikdbavishi has quit IRC08:18
*** sajauddin has joined #openstack-infra08:18
*** tkajinam has quit IRC08:19
*** whoami-rajat has quit IRC08:24
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Sort zuul.d/projects.yaml  https://review.openstack.org/65392208:25
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Fix starlingx queue  https://review.openstack.org/65392308:25
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Add system-required back for repos  https://review.openstack.org/65392408:25
AJaegerinfra-root, above are a couple of cleanups on top of fungi's large change 653900 to allow linters to work again. I thought it easier to make them separate changes...08:26
*** ykarel is now known as ykarel|away08:27
*** kjackal has joined #openstack-infra08:28
*** electrofelix has joined #openstack-infra08:32
*** e0ne has quit IRC08:35
*** yamamoto has quit IRC08:41
*** e0ne has joined #openstack-infra08:41
*** e0ne has quit IRC08:43
*** ykarel|away has quit IRC08:44
*** yamamoto has joined #openstack-infra08:44
sajauddinCan anyone help me in setting up ZuulV3? Already installed Zuul, looking for documentation which can help me in configuring dependent modules like ansible playbooks, nodepool, pipeline/jobs etc08:44
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Sort gerritbot/channels.yaml  https://review.openstack.org/65392808:46
sajauddinCurrently following Zuul official documentation... it is a bit confusing. If anyone has any documentation related to Zuul V3, please share.08:48
AJaegersajauddin: I doubt anybody is around today - and we have a huge maintenance task today as well. For Zuul v3, I suggest to  ask on #zuul channel but since this is a 3rd party question, #openstack-third-party-ci is the better choice. The folks on #zuul won't have time either today.08:48
sajauddinThanks Ajaeger. I work for Openstack CI for Power (PowerKVM CI). Will connect to #openstack-third-party-ci.08:51
*** dikonoor has quit IRC08:54
*** eumel8 has quit IRC08:55
*** whoami-rajat has joined #openstack-infra08:55
*** kjackal has quit IRC09:01
*** kjackal has joined #openstack-infra09:01
*** Basante has joined #openstack-infra09:08
*** Basante is now known as basante09:12
basantehello09:15
*** raukadah has quit IRC09:15
*** chandankumar has joined #openstack-infra09:16
*** markvoelker has joined #openstack-infra09:58
*** yamamoto has quit IRC09:59
*** larainema has quit IRC10:09
*** jamesmcarthur has joined #openstack-infra10:11
*** pcaruana has quit IRC10:17
*** kjackal has quit IRC10:18
*** jamesmcarthur has quit IRC10:18
*** e0ne has joined #openstack-infra10:18
*** jamesmcarthur has joined #openstack-infra10:23
*** jamesmcarthur has quit IRC10:27
*** bhavikdbavishi has joined #openstack-infra10:30
*** yamamoto has joined #openstack-infra10:30
*** markvoelker has quit IRC10:31
*** yamamoto has quit IRC10:41
*** nicolasbock has joined #openstack-infra10:45
tristanCGood luck everybody with the opendev migration!10:46
*** yamamoto has joined #openstack-infra10:49
*** kjackal has joined #openstack-infra10:50
*** yboaron_ has quit IRC10:50
*** yamamoto has quit IRC10:54
*** jamesmcarthur has joined #openstack-infra10:54
*** jamesmcarthur has quit IRC10:59
*** raissa has joined #openstack-infra11:01
*** e0ne has quit IRC11:04
*** yamamoto has joined #openstack-infra11:27
*** markvoelker has joined #openstack-infra11:29
*** lpetrut has quit IRC11:40
*** Lucas_Gray has joined #openstack-infra11:42
*** edmondsw has joined #openstack-infra11:50
*** yamamoto has quit IRC11:57
*** yamamoto has joined #openstack-infra12:00
*** markvoelker has quit IRC12:02
*** whoami-rajat has quit IRC12:05
*** yamamoto has quit IRC12:07
*** Lucas_Gray has quit IRC12:08
*** e0ne has joined #openstack-infra12:08
*** Lucas_Gray has joined #openstack-infra12:10
*** dikonoor has joined #openstack-infra12:22
*** yamamoto has joined #openstack-infra12:31
*** raissa has quit IRC12:33
*** bhavikdbavishi has quit IRC12:40
*** sajauddin has quit IRC12:40
*** bhavikdbavishi has joined #openstack-infra12:41
*** ricolin has quit IRC12:41
*** e0ne has quit IRC12:41
*** e0ne has joined #openstack-infra12:42
*** jamesmcarthur has joined #openstack-infra12:55
mordredtristanC: thanks!12:56
*** mriedem has joined #openstack-infra12:56
*** markvoelker has joined #openstack-infra12:58
fungiokay, heading out for a while but will be back later to see how the migration's going and what i can do to help (but possibly not until 1900z or so)12:59
*** aaronsheffield has joined #openstack-infra12:59
*** jamesmcarthur has quit IRC13:00
fungilooks like things are pretty well prepared, so hopefully the unanticipated factors won't be overwhelming13:00
fungito be honest, i mostly worried about the volume of questions we're going to get from folks who can't push changes to gerrit because they need to clear/update their git remotes on their systems13:00
*** jamesmcarthur has joined #openstack-infra13:01
mordredfungi: yeah13:02
mnaserwouldn’t pointing review.o.o by dns to OpenDev server solve that?13:07
*** eernst has joined #openstack-infra13:07
*** Lucas_Gray has quit IRC13:07
*** eernst has quit IRC13:08
*** jamesmcarthur has quit IRC13:11
openstackgerritMatt Riedemann proposed openstack-infra/elastic-recheck master: Update query for bug 1825435  https://review.openstack.org/65394313:16
openstackbug 1825435 in OpenStack Compute (nova) "TestRPC unit tests intermittently fail with "'>' not supported between instances of 'NoneType' and 'datetime.datetime'"" [Undecided,Confirmed] https://launchpad.net/bugs/182543513:16
*** dims has quit IRC13:21
*** ykarel|away has joined #openstack-infra13:22
*** e0ne has quit IRC13:23
*** jamesmcarthur has joined #openstack-infra13:24
*** efried is now known as fried_rice13:25
*** basante has quit IRC13:26
*** ykarel|away is now known as ykarel13:27
ykarelis the issue around too much RETRY_LIMIT already known?13:27
ykarelhttp://zuul.openstack.org/builds?result=RETRY_LIMIT13:27
ykarelfungi, AJaeger , clarkb ^^13:29
*** whoami-rajat has joined #openstack-infra13:31
*** markvoelker has quit IRC13:31
*** jamesmcarthur has quit IRC13:35
*** e0ne has joined #openstack-infra13:36
mnaserykarel: I disabled ovh-bhs1 yesterday as it was causing a lot of these issues13:43
mnasermaybe infra-root can check where those VMs were running13:44
mnaserbut yeah I see a lot of our jobs being hit by RETRY_LIMIT too13:44
ykarelmnaser, okk, if it was disabled yesterday, then may be some other host/hosts have issue today13:44
mnaserI am indeed seeing a high # of retry_limit too13:45
mnaserand we can't get much logs out of them13:45
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Update opendev website to be more present tense  https://review.openstack.org/65394613:46
mordredinfra-root: ^^ corvus mentioned yesterday that we should update the website text, so there's a stab at that13:47
*** jamesmcarthur has joined #openstack-infra13:47
*** dims has joined #openstack-infra13:48
*** larainema has joined #openstack-infra13:48
mordredinfra-root: I'm going to disable ansible/puppet cron13:51
mordredoh - nevermind. looks like it's already disabled13:51
*** jamesmcarthur has quit IRC13:52
corvusmordred: good morning!13:54
mordredcorvus: morning!13:54
*** jamesmcarthur has joined #openstack-infra13:55
mnaserI know everyone is busy preparing for opendev, but I'd really appreciate a quick look to see if there's a specific provider that is having issues with the high # of retry_limits in gate13:55
mnaserit's causing a lot of churn13:55
corvusoh, it's retry limits with no logs13:57
mordredyeah13:58
corvusi'll dig13:58
mordredI'm looking at one in rax-ord13:58
mnaseryeah I'd dig into those but the no logs make it hard13:59
corvusmy goodness there are a lot13:59
mordredcorvus: on ze01, grep 4d3c695030434c5b936df9f47218d728 executor-debug.log has stuff13:59
*** jamesmcarthur has quit IRC13:59
mordredI don't see any smoking gun - it looks like it was happily running devstack commands13:59
mordredthen we get an unreachable14:00
mordred2019-04-19 13:28:22,512 DEBUG zuul.AnsibleJob: [build: 4d3c695030434c5b936df9f47218d728] Ansible exit code: 414:00
mnaseris it possible that this whole time, the issue is the Zuul-executors and not the clouds? :X14:00
corvusmnaser: well, they are in the clouds14:01
mnaseryes there's that too I guess :)14:01
corvusthey are all in rax-dfw, so if that has a network issue, then the whole system would appear unstable14:01
mnaserhttps://status.apps.rackspace.com shows nothing14:02
mordredcorvus: in the one I'm looking at, the last run command is 2019-04-19 12:59:14,536 DEBUG zuul.AnsibleJob: [build: 4d3c695030434c5b936df9f47218d728] Ansible output: b'./safe-devstack-vm-gate-wrap.sh'14:02
mordredwhich then runs for 30 minutes before we get ansible unhappy about unreachable14:02
corvusnone of the jobs in the build list are short14:03
corvusthe failures appear to be grouped by time14:04
mordredcorvus: another one I looked at, 3f199b2f59b44926932b7acfd98c2170 on ze06, is not running devstack-gate (so rule that part out) but is also in rax - in dfw14:05
corvusfailures: http://paste.openstack.org/show/749534/14:05
mnaseroh I think this is the right status page https://rackspace.service-now.com/system_status/14:05
mordredcorvus: and in this one, the last thing before unreachable is starting to run tox - which runs for 40 minutes14:05
*** nicolasbock has quit IRC14:06
corvuswe should really log provider in the zuul log :(14:06
mordredcorvus: yeah. I've been looking at the ansible hostname14:07
mordredcorvus: oh - you can grep for provider:14:07
mordredgrep 3f199b2f59b44926932b7acfd98c2170 executor-debug.log | grep Provider:14:07
mordred2019-04-19 09:47:22,846 DEBUG zuul.AnsibleJob: [build: 3f199b2f59b44926932b7acfd98c2170] Ansible output: b'    "msg": "# Node Information\\nHostname: ubuntu-bionic-rax-dfw-0005349268\\nProvider: rax-dfw\\nLabel: ubuntu-bionic\\nInterface IP: 104.239.150.58\\n"'14:07
mordredoh - but yeah - on the scheduler side14:08
mnaserspeaking of potential neat features too, statsd logging per provider would be nice14:08
mnaserlike job status => provider mapping can help identify those things easiler14:08
corvusyeah, i'll get awk to give us a list of shas and we can run that grep on bridge across all the executors14:08
mnasereasily*14:09
mordredcorvus: awk-lover14:09
corvusbridge:~corvus/jobs14:10
* dtroyer recalls that the path from awk + sed + grep leads to …… perl14:11
*** jamesmcarthur has joined #openstack-infra14:13
corvussjc1 ord ord ord iad iad dfw ord gra1 iad gra1 ord ord ord iad dfw iad ord gra114:16
corvusthat's the last several14:16
mordredcorvus: that unfortunately looks like all of them14:16
corvusya14:16
corvusso there may be a network problem in dfw, or transiting out of dfw, or the whole internet14:17
*** jamesmcarthur has quit IRC14:18
mordredyeah. and we haven't landed any changes to the executors recently that seem likely to have screwed up ansible return code processing or timeouts or anything14:18
*** nicolasbock has joined #openstack-infra14:18
corvuswe also haven't even restarted them since march 2114:18
mordredyeah14:19
*** ykarel is now known as ykarel|away14:20
*** dims has quit IRC14:20
corvuswe should set up monitoring from a server in dfw to all of our mirrors14:21
corvusso we can see if pings from dfw -> any provider fail14:21
*** e0ne has quit IRC14:21
mordredcorvus: yeah - although also these do all seem to be long-running remote ansible ssh commands14:21
mnaserI saw this REALLY weird behavior btw14:23
mordredso maybe also something to run a really long ssh command?14:23
mnaserwhere a job would complete in ansible, but *post* would fail14:23
mnaserpart of why I ended up disabling ovh-bhs1, the whole job would run successfully (and log everything)14:23
mnaserbut when the jobs ends and post starts running, it fails to ssh to the server / times out14:24
corvusmordred: maybe, but the failures appear to be clustered suggesting that they may all happen at the same time (ie, the problem happens at 6:30UTC regardless of when the job started not after running for 30 minutes)14:24
mordredcorvus: you know - maybe we should still try running post playbooks even if we get unrechable - since the log upload playbook still might work14:24
openstackgerritMerged openstack-infra/elastic-recheck master: Update query for bug 1825435  https://review.openstack.org/65394314:24
openstackbug 1825435 in OpenStack Compute (nova) "TestRPC unit tests intermittently fail with "'>' not supported between instances of 'NoneType' and 'datetime.datetime'" - maybe due to "Fatal Python error: Cannot recover from stack overflow."" [High,Confirmed] https://launchpad.net/bugs/182543514:24
corvusmordred: it won't upload many logs14:24
corvus(since it also fetches them)14:25
mordredno - but it would have the console log14:25
mnaserhttp://logs.openstack.org/92/649892/13/check/openstack-ansible-deploy-aio_distro_metal-centos-7/0e486a2/job-output.txt.gz14:25
mnaserhere's a job that ran fine, streamed all log fine, but when it tried to re-ssh to the machine, it timed out14:25
corvusmordred: i think you could probably put an "ignore_errors" on the rsync task14:25
mordredyeah - the one to fetch things in teh log upload playbook14:26
*** e0ne has joined #openstack-infra14:26
mordredoh - wait- duh14:26
mordredthese hit unreachable, so we return so that zuul will re-run them14:26
*** Lucas_Gray has joined #openstack-infra14:27
corvusmordred: these are exiting with exit code 414:27
*** michael-beaver has joined #openstack-infra14:28
mordredyeah. that's aborted14:28
corvus        elif ret == 4:14:28
corvus            # Ansible could not parse the yaml.14:28
corvus?14:28
mordredwell - that's not what the log output looks like - the log output says 218d728] Ansible output: b'primary                    : ok=6    changed=6    unreachable=1    failed=0'14:29
corvusoh, maybe this is the issue with the wrong return code and tobiash's unreachable file is in play14:30
mordredoh yeah14:30
corvusyeah, exit code 4 and RESULT_UNREACHABLE is that case14:34
corvusit's happening now14:34
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Ensure config is always validated  https://review.openstack.org/65395314:35
*** dims has joined #openstack-infra14:35
corvusit is curious that dfw is in the list of hits14:38
mordredyeah14:40
clarkbhello14:40
*** ykarel|away has quit IRC14:41
clarkbone thing I realized in my sleep is that we may need to run fungi's script while zuul is off and before we run our migrate playbook14:41
clarkbbecause I think it operates on the old side repos?14:41
clarkbalso I think we may want to merge the project-config change that fungi pushed up last night before we stop gerrit so that it can be replicated14:42
corvusclarkb: i think fungi's script generates the input for the migrate playbook?14:42
clarkbcorvus: the other script14:42
clarkbcorvus: there is the input to migrate playbook one and then there is the modify all the git repos in place script14:43
*** e0ne has quit IRC14:43
* clarkb is double checking that14:43
corvusi've started several pings on ze01, i see notable packet loss in ipv6 routes, but not v4.  as we learned yesterday, we should be using v4 for all the rax regions14:44
corvusand the recent surge of failures seems to be over, last was at 14:4114:44
corvusso there was a rash from 14:34 to 14:4114:44
corvus(it's possible the event was shorter than that, it does take zuul a variable amount of time to clean up after a job)14:45
clarkbalso the other thing I thought of was kick.sh would reinstall the cron in the past14:46
clarkbwe should double check it won't do that on us today14:46
* mordred goes to verify14:46
corvusmnaser, mordred: the last 100 failures: http://paste.openstack.org/show/749536/14:47
*** helenafm has quit IRC14:47
mordredclarkb: ansible-cron is in the bridge.yaml playbook14:47
mordredclarkb: that is run by run_all but not by kick14:48
mnaserbe nice if we have region-local executors but im not the one who has the time :p14:48
clarkbmordred: thanks for checking14:49
clarkbreading fungi's script it doesn't actually care if the repos on disk on review have been moved yet or not14:49
corvusmnaser: not sure that would solve this problem14:49
mordredmnaser: yeah - although the scheduler would still need to talk to them - so if it's networking issues that might just move the ball14:49
corvusthat14:49
clarkbit lists what the repos are on disk and then clones them and applies the ruleset against that14:49
*** yamamoto has quit IRC14:49
clarkbso I think we are fine there too14:49
mordredhowever, it might be helpful for certain classes of problems14:50
clarkbI do think we should get any changes we want to be replicated early merged prior to stopping gerrit though14:50
corvusclarkb: can you paste the etherpad link?14:50
mordredhttps://etherpad.openstack.org/p/the-great-opendev-git-migration14:50
*** yamamoto has joined #openstack-infra14:50
mordredcorvus: ^^14:50
corvusthx14:50
clarkbhttps://etherpad.openstack.org/p/the-great-opendev-git-migration14:50
*** yamamoto has quit IRC14:51
*** e0ne has joined #openstack-infra14:52
corvusclarkb: i'm not sure we need to worry about replication there14:52
corvusclarkb: i don't think we'll start up any ansible crons until replication after restart has completed14:53
clarkband we can manually apply things otherwise?14:53
*** dims has quit IRC14:53
clarkbthat works for me14:53
*** e0ne has quit IRC14:53
corvusand in fact, i doubt we'd even want to start zuul until startup replication has finished14:54
clarkboh thats a good point14:54
clarkbit will just thrash otherwise14:54
clarkb(and may thrash after but less so)14:54
*** jamesmcarthur has joined #openstack-infra14:55
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Update opendev website to be more present tense  https://review.openstack.org/65394614:55
clarkbmordred: corvus the bridge crontab seems to be enabled?14:55
mordredclarkb: it does?14:55
clarkbya no # prefix on the crontab -l entries14:56
*** dims has joined #openstack-infra14:56
mordredthe only thing I see in crontab is cloud launcher14:56
mordredoh - nope14:56
mordredI simply cannot see things14:56
clarkband the run started at 14:45UTC so it won't be done until about 15:30 unless we kill it14:57
mordreddisabling now14:57
clarkbk14:57
clarkbprobably want to disable both14:57
clarkbjust to keep ansible out of ps14:57
mordreddone14:57
clarkbthat looks better14:57
corvusstatus alert Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html14:58
clarkblgtm14:59
*** nicolasbock has quit IRC14:59
clarkbmordred: can we safely stop the run_all.sh on bridge too?14:59
corvusthink alert is appropriate? (sets topic, etc)14:59
clarkbcorvus: probably especially if it will help cut down on questions in here14:59
mordredclarkb: I think so? I can't think of anything that would be broken by it14:59
mnasermaybe suggesting using openstack-infra-incident to help remove noise from y'all work :)14:59
mnasersurely there will be questions15:00
clarkbmordred: more just thinking if we stopped ansible halfway through but most of our stuff is idempotent so it should be fine15:00
corvusoom killer occasinoally does that anyway15:00
clarkbha15:00
clarkbmnaser: ya I expect if it becomes a problem we'll move15:00
mordredyeah. ok - I'm going to kill run_all.sh first - then will kill ansible-playbook processes. yes?15:00
corvus#status alert Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html15:00
openstackstatuscorvus: sending alert15:00
clarkbmordred: ++15:01
*** dims has quit IRC15:01
mordredok. no more ansible-playbook processes15:01
*** Goneri has joined #openstack-infra15:01
mordredclarkb: there's still a few thing in ps with ansible in them - you wanna look and see what you think?15:02
mordredit's mostly control persist stuff I thnik15:02
clarkbya looks like ssh processes. Those should be fine (and claen up themselves after a timeout)15:03
mordredkk15:03
-openstackstatus- NOTICE: Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html15:03
*** ChanServ changes topic to "Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html"15:03
*** e0ne has joined #openstack-infra15:03
*** lpetrut has joined #openstack-infra15:04
*** ykarel|away has joined #openstack-infra15:05
clarkbso next steps. Stop gerrit, perform db backups, run fungi's first script to get the todo list, run corvus' rename playbook, then fungi's second script to rename everything in place ?15:05
*** jamesmcarthur has quit IRC15:05
*** nicolasbock has joined #openstack-infra15:05
mordredyes. I'll take db backups15:05
*** jamesmcarthur has joined #openstack-infra15:06
clarkbfungis notes are in gerrit so I'm copying those elsewhere now15:06
clarkbsince well gerrit will be off15:06
corvushrm15:06
corvuspeople were not consistent with the topics15:06
*** gyee has joined #openstack-infra15:06
openstackstatuscorvus: finished sending alert15:07
corvusi should have everything in gertty if we need something15:07
*** dims has joined #openstack-infra15:07
clarkbk15:07
corvusalso, should we rsync a backup copy of the repos before running the script?15:08
zbr🙏 that everything will go smooth.15:08
clarkbcorvus: ++15:08
mordredcorvus: ++15:09
mordredzbr: ++ :)15:09
corvusi think i can do that as a normal user too (that's what fungi was doing)15:09
corvusi'll get that started now15:09
corvus(and obvs run again after stopping)15:09
clarkbI can stop gerrit whenever we are ready15:10
corvusready15:10
clarkbok stopping gerrit now15:10
corvusi'll stop zuul15:10
corvusshould i bother saving the zuul queues?15:11
corvus(some project names will change)15:11
clarkbya I don't think so15:11
corvusthat's how i lean15:11
clarkbchances are good they won't have working jobs initially too15:11
clarkbgerrit is stopped15:12
mordredk. I'm running the db backups15:12
corvussecond pass of rsync is done15:13
mordredstoryboard db backup done - still waiting on gerrit15:13
clarkbgerrit takes ~4 minutes iirc15:13
mordredwaiting for mysqldump is boring15:16
corvusbrb15:17
mordredstill running15:18
corvus3 executors have stopped15:19
clarkbI've compared review.openstack.org:/home/fungi/opendev-migrate against a local up to date copy and they match15:20
clarkbshould I go ahead and run that to get our repos.yaml file?15:20
mordredyeah. that can go in parallel to mysqldump15:21
clarkbok doing that now15:21
mordredremind me I really need to make us a new db cluster for gerrit ...15:21
mordredthis would have been so much quicker if we could have just copied the ibdata file :)15:22
mordredok. mysqldump is finished15:22
clarkbok that broke /me figuring out why15:22
clarkbit loads the projects list from the gerrit api15:23
clarkband gerrit is off :)15:23
mordredyeah. we shoudl have run it before turning off gerrit15:23
corvuswe all reviewed that15:23
mordredyup15:23
clarkbwe did, but fungi's notes said do it before turning off gitea not gerrit and that replaced in my head15:23
clarkbwe can generate a list from the on disk contents. Or start gerrit and do it again15:24
mordredprobably starting gerrit and running it tehn stopping is the least likely to involve quick dev work we might get wrong15:24
clarkbya15:24
corvuswell, if we restart gerrit we will have to do db and disk backups again15:24
clarkbalso yes15:25
mordredyeah15:25
corvuswe might be able to firewall it off and restart it15:25
corvusthen avoid the backup cost15:25
mordredgerrit db backup took 10 minutes15:26
clarkbstopping apache would cover the http blockage15:26
clarkbbut would have to do sshd still15:26
*** yamamoto has joined #openstack-infra15:26
mordredbut not git-review submissions15:26
corvusthe firewall is easy to do; let's do that?15:26
clarkbcorvus: ++15:26
*** pgaxatte has quit IRC15:27
corvusdone15:27
corvusclarkb: if iptables lgty, you want to restart gerrit?15:28
clarkbcorvus: yup was just checking. iptables and ip6tables -L -n lgtm and I cannot connect to webserver over ipv415:28
clarkbcorvus: mordred ^ ready to start gerrit?15:28
mordredclarkb: ++15:28
clarkbok starting it now15:29
corvusthen the script will need an update to hit localhost:808115:29
clarkbyup was just realizing that15:30
clarkbgerrit says it is ready but usually it needs a minute before it actually is15:30
*** jamesmcarthur has quit IRC15:30
clarkband to double check I still cant hit it from home via https15:30
corvusmy gertty is still offline15:31
*** jamesmcarthur has joined #openstack-infra15:31
mordredI also cannot hit it over 2941815:32
clarkbI have 820 entries in ~clarkb/repos.yaml15:32
mordredwhich host?15:32
clarkbreview.o.o15:32
clarkbthere were 820 in fungis last repos.yaml file too15:32
mordredyes. I agree with you15:33
clarkbif that looks good to you I'll stop gerrit again15:33
mordredit's passing the eyeball test15:33
clarkbzuul and jjb look good and I see a variety of opendev15:34
mordredyeah15:34
clarkbcorvus: ^ you ready for me to stop gerrit again?15:34
corvus++15:34
clarkbok stopping it now15:34
mordredI thnik it's as good as it's possible for me to manually verify15:34
*** yamamoto has quit IRC15:35
*** dims has quit IRC15:35
clarkbgerrit is stopped15:36
clarkbare we ready to run corvus' rename playbook? review.o.o:~clarkb/repos.yaml is the input to that15:37
mordredI can't think of any reason why not15:37
corvuswait15:37
clarkbwaiting15:37
corvusfungi did not squash https://review.openstack.org/65388115:38
corvuswhich means we don't have the zuul file moves15:38
corvusis that correct?15:38
* clarkb looks at local copies15:38
clarkbhmr that wasn't on the etherpad.15:39
corvusit was supposed to be squashed15:39
*** tjgresha has joined #openstack-infra15:40
clarkbI ran opendev-migrate out of 65313815:40
clarkbI have not run the thing that modifies repo contents15:41
*** zhangfei has quit IRC15:41
corvusright.  i wrote a change to opendev-migrate, which, since fungi was mostly working offline, i made as a followup and asked that it be squashed into the script15:41
clarkbgotcha15:41
corvusgimme a sec and i can run it15:42
clarkbcorvus: is it in the repos.yaml generation script?15:42
corvusclarkb: it's opendev-migrate15:42
corvusso we need to start gerrit again15:42
clarkbk15:42
corvusso i can run my version and get the zuul key moves15:42
clarkboh right the key moves15:42
clarkb(sorry zuul files kept parsing as zuul yaml files)15:42
corvusi will start gerrit15:43
clarkbI'm starting gerrit after double checking iptables15:43
clarkbk /me gets out of the way15:43
*** dims has joined #openstack-infra15:44
corvusnice15:44
*** Lucas_Gray has quit IRC15:44
corvusi think the output is not sorted15:44
corvusso my repos.yaml is completely different than yours15:45
clarkboh ya because python3.5 on review not 3.6:/15:45
corvusokay ~corvus/zuul-rename.sh15:45
mordredcorvus: your repos.yaml also looks good on general perusing15:45
corvusgerrit is stopped15:46
clarkbcorvus: there are 1638 zuul file moves and not 1640 (820 * 2 == 1640)15:46
clarkbis that expected?15:46
*** fmount has joined #openstack-infra15:46
corvusi have 819 repos in repos.yaml15:47
corvusso do you15:47
corvusfirst line isn't a move15:47
clarkboh right the repos: line15:47
clarkb++ things look good to me then15:47
corvus\o/15:47
mordredcorvus: also - I think we need to make sure we create target directories for new org15:47
corvusmordred: good point15:47
corvusmordred: i'll work on commands to do that15:48
mordreddo we have a set of new orgnames?15:48
corvusi don't think so.  i will soon though15:49
mordredkk15:49
corvus~corvus/zuul-dirs.sh15:51
mordredcorvus: lgtm15:51
clarkbI see nothing missing from the list lgtm15:52
corvusi think we're good to run the playbook now15:52
clarkbI agree. db and repo backups are done. gerrit doesn't seem to be running15:52
mordred++15:52
clarkbwe have our repos.yaml and zuul secrets mv data/scripts15:52
mordredcorvus: should we rsync a backup of the zuul keys as a belt/suspenders?15:54
corvussure i'll do that15:54
corvusdone15:55
mordredthat's all I can think of to be specifically paranoid about atm15:55
clarkbbefore running the playbook I think we may need to update the hostline for storyborad15:55
clarkbI'm double checking against inventory now15:55
clarkbstoryboard01.opendev.org is the hostname now15:56
clarkbother than that I think playbook is ready and good to go. (its interesting how the extra level of paranoia of being in the moment helps you catch stuff like that15:56
mordredclarkb: what do you mean update the hostline?15:57
clarkbmordred: - hosts: storyboard.openstack.org should be -hosts: storyboard01.opendev.org15:57
*** e0ne has quit IRC15:57
corvusit shouldn't be storyboard0115:58
corvusit should be a group with storyboard01 in it15:58
corvusi mean, that's fine for today15:58
clarkbgood point. storyboard group does exist15:58
corvusbut assuming we don't want our rename playbook to keep breaking everytime we change the host15:58
clarkb++15:58
mordred++15:58
corvuswhen we fix the real one, that's what we should do :)15:58
mordredand I concur about the line needing to be opendev.org15:58
clarkbalso its - hosts: not -hosts: I fail at yaml15:59
clarkbcorvus: ^ did you want to run that (you made the playbook edits and generated the final repos.yaml)15:59
corvusnot especially... i don't think i've ever run it16:00
corvusi just removed some things from it16:00
clarkbk16:00
corvusclarkb: want to use screen?16:00
clarkbya lets starts a root screen on bridge16:01
clarkbsomeone with a small terminal want to do it? otherwise you'll get my large termainl16:02
corvusi'm fine with a large terminal :)16:02
clarkbok I'll start it then16:02
mordredI'll get by with it ... :) - make it the size you need for driving16:02
clarkbstarted16:02
mordredon and watching16:03
clarkbcorvus: can you copy your playbook and repos.yaml onto bridge?16:03
corvusyep16:03
clarkbhttps://docs.openstack.org/infra/system-config/gerrit.html#renaming-a-project are the docs on running the playbook16:05
corvusplaybook is in place16:05
clarkband looks like you fixed the storyboard hosts line16:05
corvusya16:06
corvushow could you tell it was me? :)16:06
clarkbsomething about emacs16:06
mordredcorvus: you could have done that edit with sed and awk16:07
corvusmordred: i'll edit you with sed and awk16:07
clarkblet us know when repos.yaml is in place. I think we can make a copy of that file and reduce it to a single entry and run with that first. Then run with the other partition after that looks good16:07
mordredprobably a good idea. I need a good editing16:07
corvusclarkb: i sorted both of our repos.yaml files and the result is identical16:08
corvusi'll just copy my repos.yaml16:08
clarkbcorvus: oh good check16:08
corvusso that it's the same order as the zuul script16:08
corvusdone16:09
*** e0ne has joined #openstack-infra16:09
clarkbok I'll make two new files. One with a single entry and one with everything else so that we can do this in two passes (first confirmation it is happy, second everything else)16:10
corvusgood16:10
corvuslg16:11
mordred++16:12
corvusjust one thing i'd like to double or triple check16:13
clarkbok waiting16:13
corvusthe patching script runs on the new locations?16:13
clarkbcorvus: I think it can run on the old or new locations. It ls's the review_site dir and then operates within whatever repos are there16:13
mordredyeah16:13
clarkbcorvus: but you should independently confirm that16:14
mordredand does any replacements in the repos based on the input mapping, not based on what repo it's in16:14
corvusyep, that's what it looks like to me.  ok16:14
corvus47 # the gerrit git directory16:15
corvus48 top = sys.argv[1]16:15
corvus84 # find all second-level directories on which we will operate16:15
corvus85 repos = run(['find', top, '-maxdepth', '2', '-mindepth', '2', '-name', '*.git', '-type', 'd'])16:15
*** mattmceuen has joined #openstack-infra16:15
corvusall clear from me16:15
clarkbmordred: ready for me to run the pasted command?16:15
mordredclarkb: yes16:16
clarkbok proceeding16:16
clarkbok is that a werd ansible interaction with something?16:17
corvusmaybe that was on puppetmaster but not bridge?16:17
clarkboh ya16:17
corvus[ERROR] unknown variable 'defaults-file=/root/.gerrit_db.cfg'16:17
corvusthere is a /root/.gerrit_db.cnf on gerrit16:18
corvuscan probably copy that over16:18
clarkbcorvus: if you've already got ssh things set up for that copy want to do that?16:18
corvusyeah, lemme double check the creds match the gerrit config file16:18
mordredI used .gerrit_db.cfg for the db backup earlier16:19
mordredcnfg that is16:19
mordredcnf16:19
clarkbactually that should run on review16:19
corvusoh you're right16:19
corvusso we just need to fix the filename?16:19
mordredthen also update it to make the filename .gerrit_db.cnf instead of .cfg16:19
corvusi think the task does already run on reviwe16:20
clarkbya I think we just have to update the filename16:20
mordred++16:20
corvusclarkb: you drive16:20
clarkbk16:20
corvus(has the rename playbook ever been run?)16:20
clarkbthe name is /root/.gerrit_db.cnf ?16:21
corvusyes16:21
clarkbcorvus: ya we used it last time we renamed projects iirc16:21
corvusthis seems like a strange error to have in that case16:21
clarkbI agree16:21
corvusMay  2  2018 /root/.gerrit_db.cnf16:21
clarkbI'm double checking the storyboard defaults file16:22
mordredI used /etc/mysql/debian.cnf for the db backup on storyboard16:23
clarkbhrm I wonder if this changed at some point?16:23
clarkber chagned in puppet16:23
mordredthe storyboard one likely changed when we moved to local db16:24
clarkbah16:24
corvusi don't see any puppet or ansible to write the gerrit_db file out16:24
clarkbI thought the puppet mysql db backups module did that but maybe it doesn't16:25
clarkbthat could explain how we've diverged16:25
corvusoh, then maybe i'm not searching right16:25
mordredyes16:25
mordred$defaults_file = "/root/.${name}_db.cnf"16:25
corvusclarkb: yes it does16:25
corvusya16:26
clarkbbut ya I'm fairly certain we've run this playbook before because I remember editing repos yaml files before16:26
corvus27ecc02c (Clark Boylan 2013-09-05 18:22:21 -0700 30)   $defaults_file = "/root/.${name}_db.cnf"16:26
corvusso *that* isn't what changed :)16:26
clarkbheh thats been there a long time16:26
*** smarcet has joined #openstack-infra16:26
clarkbLet me know if you think we are ready to run it on this first project again16:26
corvusclarkb: if you've double checked storyboard then ++16:27
mordred++16:27
corvusi have started a list of things to clean up at the end of the etherpad16:27
clarkbcorvus: thank you for that16:27
clarkbI'll rerun now16:27
clarkbheh is the arg not --defaults-file?16:28
clarkbmordred: ^16:28
mordredshould be ... one sec16:28
corvusmysql reviewdb --defaults-file=/root/.gerrit_db.cfg16:29
corvusrunning that on review01 fails16:29
mordredclarkb: --defaults-file=#       Only read default options from the given file #.16:29
mordreddatabase comes after arguments16:29
mordredmysql --defaults-file=/root/.gerrit_db.cnf reviewdb16:30
clarkbok so change the order of the db and arguments16:30
corvusmysql --defaults-file=/root/.gerrit_db.cnf reviewdb16:30
corvusworks16:30
clarkbediting16:30
*** smarcet has quit IRC16:31
corvuslooks like the storyboard one is already correct16:31
clarkbyup16:31
mordredwhat the heck happend to that line?16:31
clarkbif you think that looks good I am ready to rerun16:31
mordred++16:31
corvusdoes this mean we don't have db backups on storyboard?16:32
mordredI did db backups on storyboard16:32
corvussorry i mean *regular* backups16:32
clarkbno there is a crontab entry that uses the debian defaults file16:32
clarkbso I think storyboard backups were working16:32
*** igordc has joined #openstack-infra16:32
clarkbcorvus: anything else we should check before trying again?16:33
corvusok, we use /etc/mysql/debian.cnf if running local16:33
corvusi'm good :)16:33
clarkbalright proceeding16:33
*** mgoddard has quit IRC16:34
clarkbok its the dest dir problem we anticipated for zuul keys on review_site now :)16:34
corvusagreed16:34
corvusi'll make a script16:34
clarkbI think we'll have that same issue on git0*16:34
clarkband the local review mirror16:34
corvusoh maybe we should just incorporate this into the playbook then16:34
clarkbprobably not a bad idea16:35
*** mgoddard has joined #openstack-infra16:35
corvusis there a jinja filter to get dirname?16:35
mordredmkdir $(dirname $(dirname /opt/lib/git/{new}))16:35
mordred?16:35
*** electrofelix has quit IRC16:36
mordredlooking for jinja16:36
corvuslooks like there's a |dirname16:36
corvusmaybe shell is easier16:36
corvusi'll drive16:36
mordred++16:36
*** e0ne has quit IRC16:36
clarkbcorvus: use -p so that it doesn't error when the dir exists16:37
clarkbalso do we need to chown to gerrit2?16:38
corvushrm i guess so16:38
mordredcorvus: wait - reove /opt/lib/git16:38
mnaser|dirname works in Ansible (but not jinja2 native fwiw)16:38
mordredthat's what's in item[0]16:38
mordred++16:38
corvusthis might be worth making a new task16:38
mordredyeah16:39
mordredcorvus: was nI wrong - do we need the double dirname?16:40
mordredcorvus: I think just one dirname16:40
clarkbmode is 755 on the other dirs16:40
*** lpetrut has quit IRC16:41
mordredcorvus: ++16:42
corvusmordred: i think you're right :)16:42
mordredcorvus: :)16:42
*** rpittau is now known as rpittau|afk16:42
mordred\o/16:43
mordredwe made a directory!16:43
mordredon review, /opt/lib/git/x is there16:44
corvusderp thanks16:44
*** mgoddard has quit IRC16:44
corvusthat play look good?16:44
mordredyes16:44
clarkbI thought the ls said it wasn't there?16:45
clarkb(sorry trying to follwo along and may have missed it when it was there)16:45
corvusclarkb: i was on the wrong host16:45
mordredclarkb: it's there on review.o.o16:45
clarkboh right16:45
corvusgit0* play look good?16:46
mordredyes. I think it's solid16:46
*** igordc has quit IRC16:46
clarkbyes I think so16:46
corvusi *think* that's covered for gitea...oh we need to pull in those tasks files16:46
corvusand... give it a root password don't we?16:47
corvusand it looks like that does not create the orgs16:47
clarkbI think the gitea apssword is in the ansible vars16:47
corvusoh, right, and we have access to that because we're on bridge16:48
*** mattw4 has joined #openstack-infra16:48
corvusand it's in the normal inventory hostvars stuff16:48
mordredyeah16:48
clarkbre creating the orgs that is another playbook right?16:48
corvusok, so we do need to add in an org creation16:48
corvusyeah16:48
corvuslet's come back to that16:48
*** gyee has quit IRC16:48
corvusah, well, that looks like the last thing actually16:48
corvusi don't see any more places where we'd need to mkdir16:48
clarkbagreed I think we are good mkdiring on git0* and review16:49
mordred++16:49
clarkbleaving us with the gitea org creation16:49
*** gyee has joined #openstack-infra16:49
corvusfor this, it may be easiest to write a one-time playbook to create the orgs16:49
mordredcorvus: yeah - we have the list of them you made earlier16:50
clarkbI'm good with that16:50
*** cmurphy is now known as cmurpheus16:50
corvuswe are missing one var -- gitea_url16:51
mordredI think it's in the playbook16:51
clarkbthat might be in the public data?16:51
corvusyep it is16:51
mordredright there16:51
mordredyeah16:51
corvusdoes that look right?16:53
clarkbcorvus: yes, though ansible loop syntax always confuses me. We can also simplify it by removing the orgs we already have16:53
clarkbopenstack opendev zuul come to mind16:54
corvusyeah, i think i just removed those 316:54
corvusokay, i think we're gtg on that, should we run it now?16:55
clarkbcorvus: ++16:55
mordred++16:56
clarkbheh 201 not 20016:56
mordredor, 200 not 20116:57
*** mriedem is now known as mriedem_lunch16:57
corvushrm, i don't understand the situation16:58
clarkbthe playbook expects a 201 but it got a 20016:59
corvusright, but the org was not created16:59
clarkboh16:59
corvusso that's a correct error16:59
corvusooooh17:01
mnaserI think inagust and Vexxhost are gitea orgs too17:01
mnaserinaugust*17:01
corvusthey're pre-existing; we're looking for airship to be created17:01
mordredcorvus: oh god - it's because it's redirecting us to opendev.org?17:02
corvusyeah i think it's the ssl redirect17:02
clarkbhow did that work when we created vexxhost/ and inaugaust?17:03
mordredyeah17:03
corvushrm17:03
corvushttps17:05
mordredyes!17:05
mordredand it worked17:05
corvusi've updated this playbook and the migration playbook17:05
corvusi should have run -f10 sorry17:05
mordredno worries - I'm just thrilled it's working17:06
clarkbso the issue was we needed https://localhost?17:06
corvusyeah17:06
clarkbbefore we rerun repos-first.yaml the mysql udpates we've already done should be safe to reapply right?17:07
corvusi think we're ready to run the migration with first again; you have the conn :)17:07
clarkbwe do an update where and that where won't match anymore so it should noop right?17:07
corvusi believe so because nothing will match the where clause17:07
clarkbmordred: ^17:07
mordredyes17:08
corvusi highlighted the relevant lines17:08
clarkbok I'm ready to rerun repos-first.yaml when you hand over the con again :)17:08
mordredthe where clause should not match17:08
corvusclarkb: it's yours17:08
clarkbmordred: ready?17:08
mordredyup17:08
clarkbok gitea failed17:10
clarkbbut everything else looked fine17:10
corvushow is repos not defined?17:10
corvusoh17:11
corvuswe need an include vars there17:11
clarkbah its a separate play17:11
corvusya17:11
clarkblike that?17:11
corvusi vote we fix it, then copy that play to its own playbook and run it17:11
corvusclarkb: lgtm17:12
mordred++17:12
corvusor maybe even that play and all the ones that follow?17:13
clarkbcorvus: ya let me update to do the following ones too17:13
clarkband actually we don't need the index backup until later so I'll remove that17:14
corvus++17:14
clarkbhow does that look now17:14
corvusgood17:14
mordred++17:15
clarkbrunning the new playbook now17:15
clarkbok xenapi-os-testing should be done17:15
corvushttps://opendev.org/x/xenapi-os-testing looks good17:15
mordredit does - but the redirect doesn't work17:15
mordredisn't that the thing you fixed with that upstream patch corvus ?17:17
corvuswow, it's not in a final release yet17:18
corvusit's in 1.8.0-rc117:18
mordredcrap17:19
clarkbhrm I thought we upgraded gitea to pick that stuff up. Maybe they needed to backport and we didn't realize?17:19
mordredwe could potentially cherry pick it out and apply it in our docker build - but that would obviously take some work with stuff back online17:19
clarkbmordred: we could trust an infra-root to push the image out of band17:19
clarkbthen correct when stuff is online again17:19
mordredthat is true17:19
corvusor we could manipulate the database17:19
mordredis it just a db fix?17:20
corvusi believe i understand what needs to be done17:20
mordredok17:20
corvuswe would insert records in the db based on our move mapping to cause the redirects to happen17:20
mordredI'm comfortable with that for today - it seems somehow like the least janky option17:20
corvusand yeah, the redirection is handled entirely by the db.17:20
mordredcool17:20
corvusso maybe we continue for now, and perform "add redirects to gitea db" after we're back online?17:21
clarkbcorvus: is that safe to add after the fact or do we need to record project ids or similar?17:21
clarkbI'm trying to verify storyboard and utterly failing because i don't understand its search17:21
corvusshould be fine to do after the fact17:22
clarkbxenapi-os-testing doesn't return a thing like it does for nodepool17:23
mordredclarkb: I don't get anything for https://storyboard.openstack.org/#!/project/openstack/xenapi-openstack-testing or https://storyboard.openstack.org/#!/project/x/xenapi-openstack-testing17:23
mordredclarkb: is it really a storyboard project?17:24
corvuswas it in storyboard in the first place?17:24
clarkboh good question17:24
mordredprobably not I'd guess17:24
clarkbno it was not17:24
mordredgood. well, it still isn't17:24
clarkbok if we are doing gitea org redirects later should we rerun our playbook with another test repo and then move on to the rest?17:25
corvussince it stops on failure, i'm okay running the rest now17:26
clarkbit won't continue the next item in the loop? it completely exits?17:26
mordredyeah - I'm also ok running the rest now17:26
clarkbok17:26
clarkbcorvus: is the https://localhost fix in the opendev_migration.yaml too?17:28
corvusyes17:28
*** igordc has joined #openstack-infra17:28
clarkbalright ready to go then?17:28
clarkbcommand is up17:28
corvus++17:29
clarkbmordred: ?17:29
mordred++17:29
clarkbalright here goes17:29
mordredfingers crossed17:29
mordredthis isn't going to be the FASTEST thing :)17:32
mnaserpurposely done so17:32
mnaserfor lunch (or breakfast) time17:32
mnaser:)17:32
mordred:)17:32
clarkbit is about halfway through the changes db update17:37
*** jamesmcarthur has quit IRC17:40
clarkbabout 100 repos to update changes db for17:40
clarkbso should be done in a minute or two I expect17:41
clarkbwell then it goes on to do the other things17:41
corvusmordred, clarkb: drat; there is a code change needed for the redirects17:42
corvusi think i should build a gitea image manually with the patch and push it up17:43
clarkbcorvus: ++17:43
corvusshould we stop the migration script so that we don't have to do the database entries manually, or should we plan on doing that and restarting gitea afterwords?17:44
clarkbstopping it seems potentially painful to figure out what needs what updates but that is doable17:44
corvuswe could take gitea down17:44
clarkbcorvus: oh that would do it17:44
corvusthat would probably stop it at exactly the right place :)17:44
clarkbindeed17:45
clarkbsounds good to me if you can do that relly quick17:45
corvuswill do17:45
corvusgitea is down17:46
corvusi will go build the image now17:46
clarkbok and we haven't gotten to that play yet17:46
corvusshould i just rebuild our image based on upstraem 1.8.0-rc3?17:48
*** eernst has joined #openstack-infra17:49
clarkbmaybe stick to 1.7.x for now?17:49
corvusok.  1.7.4 which we were running or 1.7.6?17:49
clarkbthe paranoid in me says 1.7.417:49
clarkb:)17:49
clarkbwe can do A/B testing of gitea updates when not in the middle of the migration and be sure that the other versions work17:49
corvusk17:50
clarkb(though I guess we can always set the image label back to the older version too)17:50
mordred++ to 1.7.417:51
corvuswe need to be running one of these patches for the redirects to work at all17:51
corvusso this is worth doing so that if anything goes wrong in later versions, we have a working version to fall back on17:51
mordred++17:52
clarkbthat is a good point17:52
corvushttps://github.com/jeblair/gitea/tree/opendev17:53
corvusand i promise you, the irony is not lost on me.  :)17:53
corvus(our docker file wants to clone from a web accessible location...)17:53
clarkbthat apepars to be two jeblair commits on top of 1.7.417:53
mordredyes. I concur, and think that's a good location17:54
mordredand also ironic17:54
*** jamesmcarthur has joined #openstack-infra17:55
mordredcorvus: maybe once gerrit is back up, we should also propose a system-config patch to update the dockerfile to point to that location until there isa  1.8.0 release we upgrade to17:55
corvus++17:55
mordredso we don't accidentally revert17:55
corvusi'll just push up what i'm doing right now17:55
*** jamesmcarthur has quit IRC17:55
mordredcool17:55
corvusbuilding now17:56
corvusi have manually inserted the redirect for xenapi-os-testing (which is how i discovered the missing piece)17:56
corvusso we should be able to confirm that's working when we bring gitea up with the new images17:57
corvuslooks like the process has stopped as expected17:57
clarkbI agree17:57
clarkbI am goign to take this as an opportunity for a short bio break17:58
clarkbback in a minute17:58
corvusshall we bring gitea back online now?  (with the old images)17:58
mordredcorvus: crappit17:58
*** eernst has quit IRC17:58
mordredcorvus: https://github.com/go-gitea/gitea/pull/5987 is also in 1.8.0 not in 1.7.x17:58
corvusheh17:58
corvusok i'll cherry pick that too17:58
corvusmordred: https://github.com/jeblair/gitea/commits/opendev lg?17:59
*** roman_g has joined #openstack-infra17:59
mordred++18:00
corvusrebuilding18:00
clarkbI think we've gotten too used to CD :P18:00
clarkbsurely if the code is merged it goes straight to production18:00
corvusshall i restart gitea now?  i stopped it by stopping docker, which i'll need to restarct anyway to pull the new images...18:00
corvusclarkb: yeah... :)18:00
clarkbcorvus: ya the playbook is not running so should be safe to do that18:01
corvusi mean, there have been at least 2 point releases since then which these didn't end up in... :|18:01
clarkbI am going to make a new playbook that removes everything before the gitea stuff18:01
corvusclarkb: ++18:01
* mordred was scanning through the gitea 1.8 changelog18:02
mordreddoesnm't look like anything scary18:02
smcginnisSo not just gerrit is offline? All services?18:03
clarkbsmcginnis: gerrit, gitea and zuul18:03
clarkbsmcginnis: everything else is up and running18:03
smcginniskk, thanks18:03
corvushttps://opendev.org/ is back up18:03
clarkband we should have gitea back and happy momentarily18:03
corvusand https://opendev.org/openstack/xenapi-os-testing is doing the infinite redirect which will be fixed by the new version18:04
mordredcorvus: neat!18:05
corvusmordred: are you still personally a member of opendevorg?18:05
corvusmordred: if so, can you add me?18:05
mordredlet's find out18:05
mordrednope18:05
corvusok, i'll dig out the passwords :)18:06
clarkbsmcginnis: rought state of things is once gitea is back with the redirect fix we will run the playbook to update gitea configs, then the next step after confirming it and storyboard are happy is to run fungi's inplace update of repos for the renaming. Then when we are happy with that we can start gerrit and the real fun begins :)18:06
corvusthe password we have for opendevzuul is not working18:08
clarkbcorvus: is ours the base64 version?18:08
clarkbI ran into that debugging the registry stuff once18:08
corvusi'm looking in the password file18:08
clarkb(we store base64 in zuul and that gets converted on the output)18:09
mnasercorvus: I think the stuff stored in .docker/config is a base64 of username:password18:09
clarkboh or maybe it wants it base64 as input18:09
smcginnisclarkb: Thanks for that status. ;)18:09
corvusno i'm just trying to log into the web ui with the password stored in our encrypted password store18:09
corvusthere should be no base64 involved18:09
corvusthe password for opendevzuul is the same as openstackzuul which seems suspicious to me18:10
corvuswe may need to decrypt the zuul secret :|18:10
mnaserdo we recall who created the opendevorg .. org?18:10
mordredyeah - that was me - but I have since divested myself of personal ownership18:11
mordredcorvus: can you log in as openstackzuul with the password that's there - and does openstackzuul have access to opendevorg ?18:12
mnaserah gotcha18:12
corvusmordred: no that's what i've been trying to type here18:12
corvusnot sure why this is confusing :)18:12
corvusmordred: oh openstackzuul for opendevorg18:13
corvusmordred: no18:13
mordredyeah18:13
mordredk18:13
mordredjust checking18:13
corvusmordred: login works, only access to zuul orgs18:13
mordredsad panda18:13
mnaserI guess someone is gonna have to work on decrypting https://opendev.org/openstack-infra/system-config/src/branch/master/.zuul.yaml#L25-L4018:13
corvusi'm working on decrypting the zuul secret18:13
clarkbcorvus: root history has some decryption stuff if your grep for base6418:13
clarkber on zuul0118:14
corvusi have a script18:14
corvushttps://review.openstack.org/63977118:14
*** mriedem_lunch is now known as mriedem18:15
*** cgoncalves has quit IRC18:15
corvuslogged in and password store updated18:17
mordred\o/18:17
corvusadded myself18:17
corvuspushing18:19
*** e0ne has joined #openstack-infra18:19
corvusi do not have a large upstream pipe.18:19
corvusclarkb: so the expanse was really good.18:20
clarkbcorvus: yup18:20
corvushave you read the books?  are they good?18:20
clarkbI've read the first 4 or 5 after that they kinda fizzled out for me18:21
clarkbbut the first set are worth a read18:21
corvusok, i'll give 'em a shot18:21
clarkbare you on a dsl pipe? I seem to recall your area of the world has a good independnet dsl provider18:22
corvusi know you said the show could seem slow due to worldbuilding, and i agree you should commit to at least a few eps.  but one of the things i liked about it it never felt like a wasted episode.  3 seasons and they hit the ball every time at bat.  even bsg had some episodes that were like "well what was the point of that?"18:23
clarkbya if you pay attention the early episodes do lead up to later episodes well. But with minimal context it can be hard to pick up on all of that18:23
fungiokay, i'm back at a keyboard, but no idea what the current state is or if i should be helping break something... should i catch up on scrollback or is there anything urgent to jump into right away?18:24
clarkbfungi: let me tldr for you18:24
fungimuch obliged!18:24
clarkbfungi: we have done everything in the migrate playbook up to the point where we do teh gitea renames. This is because we have discovered we need a newer version of gitea to include corvus and mordred's fixes to gitea for our redirecting stuff18:24
clarkbfungi: corvus has built that image and is uploading it to dockerhub now. We'll restart gitea on that image as soon as it is available18:25
clarkbfungi: the next step after that is to run the rest of the playbook, then run your in place git updates, then start gerrit assuming things look good18:25
fungiokay, cool... i saw nick highlights about needing to squash something into one of the scripts but i missed which one. something about zuul moves?18:26
clarkbfungi: problems we ran into include stopping gerrit before getting the repos.yaml (your comment said gitea not gerrit and I didn't double check so my bad). Also our migrate playbook had bugs around mysql config speicification and needing to create org dirs before moving repos18:26
*** dims has quit IRC18:26
clarkbfungi: the moves of zuul secret keys18:26
clarkbfungi: corvus had a change up that needed to be squashed into your script change. He took care of that manually18:26
fungioh! right, opendev-migrate does also hit the gerrit api for a list of actual repos, my bad :(18:27
clarkboverall things are looking good right now. Its just been a slow one item at a time slog18:27
fungiand what was the modification which needed squashing? i included the requested addition of zuul/main.yaml18:27
corvusclarkb: yeah, i'm thinking of re-watching it, actually... i think it'll hold up...18:27
corvusfungi: the generation of the zuul key file moves18:27
fungioh! i totally missed you asking about that. yes i can see where that would be needed, sorry!18:28
corvusclarkb: and yeah, i use sonic.net.  they are rolling out fiber, but haven't gotten to me, so i'm still on bonded adsl (~40mbit down)18:28
clarkbfungi: as for where you can help we have a root screen running on bridge if you want to be a second set of eyeballs for when we run the next playbook. And if you can stick around long enough maybe you want to be the one to run your edit git in place18:28
fungiwe probably should do zuul keyfile moves in the rename_repos playbook though, right? i assume that's going to come up any time we do a repository rename in the future?18:28
corvushttps://hub.docker.com/u/opendevorg is updated18:29
clarkbfungi: as a future improvement yes, but for now we are just going to run that script I think18:29
*** dims has joined #openstack-infra18:29
fungisure, that makes total sense. the scripts i pushed up are entirely utilitarian and (hopefully) one-shot18:29
corvusi'm ready to docker-compose pull and restart18:29
mordredcorvus: ++18:29
clarkbcorvus: ++18:29
mordredfungi: corvus started a list of improvements we need to make for the future on the bottom of the etherpad18:29
fungiawesome18:30
fungialso joined screen session on bridge18:30
corvusrunning docker-compose pull on all gitea servers18:30
corvussorry i should have done that in the screen18:30
corvus"docker-compose up -d --timeout 60" is what our playbooks do next; i think that will restart?18:32
mordredI think so18:32
corvusi'll do that now then18:32
clarkbya that should be fine18:33
mordredredirect worked!18:33
corvushttps://opendev.org/openstack/xenapi-os-testing  works18:33
*** edmondsw has quit IRC18:33
clarkbyay18:33
mordredok. that was exciting18:33
corvusi think we're ready to pick up18:33
mordredcorvus: ++18:33
clarkbI've pulled up the edited playbook for just gitea and after tasks in the screen18:34
clarkbdoes that look good to everyone?18:34
mordredclarkb: yes.18:34
corvus++18:34
clarkbalright drafting up the command now18:34
clarkbhow does that look? do we want to run it on a single repo first?18:35
clarkbor jsut go with it since it will fail fast?18:35
corvusi think go18:35
clarkbmordred: fungi ^18:35
clarkbfwiw I'm just go too considering it fails fast18:35
mordredI thnk just go18:36
* clarkb gives fungi a few more seconds to object before hitting enter18:36
clarkbalright hitting enter18:37
clarkbseems to be running18:37
mordredyeah. and picking out random ones the rename/redirect seem to be working18:38
fungiyep, sorry, still catching up18:38
mordredhttps://opendev.org/openstack/fuel-ccp-searchlight -> https://opendev.org/x/fuel-ccp-searchlight18:38
mordredfor instance18:38
mordredworks18:38
mordredhttps://opendev.org/airship/drydock is there - yay new orgs18:39
mordredI am comfortable that that is working properly18:39
clarkbany objections if I go make a kettle of tea real quick while we wait for this?18:39
* fungi is glad he wrote the opendev-patching script so that it will work regardless of whether it happens before or after the renames playbook18:39
mordredcorvus: how long does the crsf token last?18:39
mordredfungi: ++18:39
mordredclarkb: do it18:39
fungiclarkb: i suspect you have time to get through several cups of tea before this playbook is done18:40
fungilooks like we're getting on the order of 1-2 renames per second18:40
corvusmordred: i'm not sure18:40
mordredcorvus: here's hoping the time is "longer than we need it to"18:40
fungiit'll either be that, or the other thing18:41
corvushttps://github.com/go-macaron/csrf/blob/master/csrf.go18:42
corvusmaybe indefinite18:42
mordredyeah18:43
corvusi will start heating up lunch18:43
mordredfungi: so - it should be done in about 13 minutes18:43
mordred++18:43
* mordred stands up and walks around for no reason18:43
*** rf0lc0 has joined #openstack-infra18:43
clarkbI looked at my yard asthey just treated it with a larvacide18:44
*** eglute has quit IRC18:45
clarkbjapanese beetles are bad and state is killing them18:45
fungiwon't someone think of the larva?!?18:45
fungiahh, yeah18:45
fungii need to get out and address some shrubbery this weekend. semi-annual bulk pickup starts monday18:46
*** rfolco has quit IRC18:46
fungii have a *lot* of neglected pruning18:46
*** e0ne has quit IRC18:46
clarkbthis is the sort of thing wher ethey say "you can opt out but if you do you need a valid medical excuse from a doctor otherwise we'll get a court order overriding your opinion"18:47
*** dims has quit IRC18:48
*** eglute has joined #openstack-infra18:48
clarkbthinking out loud here about next steps. When we start gerrit do we want to keep the iptables rules preventing access in place? that way gerrit can replicate in a more controlled manner?18:48
corvusclarkb: i think that's a stellar idea18:49
fungiwhat amount of replication are we anticipating?18:49
clarkbfungi: all of it because gerrit replicates everything on start18:49
corvuswe could probably be running the zuul move scripts now (i don't expect that to take long though)18:49
fungii guess just the usual "i don't know what may have changed so i'll replicate everything to be safe" that gerrit does, right18:49
clarkbyup18:49
fungiyeah, file moves within the same filesystem will be near-instant18:50
clarkbI have ginger lemon tea now18:50
fungiat most a few seconds18:50
fungito complete the full set18:50
mordredhttps://opendev.org/jjb/jenkins-job-builder \o/ - happy to see that with it's own nice little home18:51
*** dims has joined #openstack-infra18:51
clarkbI think we are about 1/3 of the way through18:51
corvusmordred: it'll have a friend there too with python-jenkins18:51
mordredcorvus: it should have a friend18:51
corvusshall i run the zuul scripts now?18:51
clarkbcorvus: I'm good with that if you are18:52
clarkbdon't forget to mkdir first18:52
clarkbfungi: ^ this is probably the biggest lesson of the day18:52
clarkbnone of our renaming stuff assumed new orgs :)18:52
mordredfunny that :)18:52
mordredcorvus: ++18:52
corvusi've run the dir creation18:53
corvusnow i'll run "bash -xe zuul-rename.sh"18:53
corvusthat should fail fast if there's a prob18:53
clarkb++18:53
mordredand succeed fast if there's not18:53
corvusmv: cannot stat '/var/lib/zuul/keys/ssh/project/gerrit/openstack/deb-os-refresh-config': No such file or directory18:53
clarkbah we are renaming some repos that never zuulv3'd18:53
corvusmaybe i should just run without -e then18:54
corvusit moved a bunch of other stuff before that successfully18:54
clarkbya maybe write to a log file then we can grep all the cannot stats18:54
clarkband check if they look sane18:54
mordred++18:54
corvusbash -x zuul-rename2.sh >zuul-rename.log 2>&118:55
corvusthat look right?18:55
corvusdid i get the redirect order correct?18:56
clarkb2>&1 is correct18:56
clarkbI don't think the order of that vs >zuul-rename.log matters much?18:56
mordredno, it doesn't18:56
corvusk.  that's done18:57
mordredwoot18:57
*** Goneri has quit IRC18:57
corvushttp://paste.openstack.org/show/749545/18:57
clarkbthe deb-* and loci-* are fine aiui (loci transitioned to a single repo for all their images)18:58
clarkbnothing is really jumping out at me as a mistake there18:59
mordredme either18:59
clarkbwe are past the halfway mark on the gitea renames18:59
mordredwoot19:00
clarkbfungi: once this is done I think the next thing is your in place git repo edits19:00
fungi139 nsfod errors some of which are for the same project, seems like a relatively small subset at least19:00
clarkbfungi: nsfod?19:00
AJaegerno such file or directory?19:01
clarkboh no such file or directory ya19:01
* AJaeger never heard that abbreviation before, I might be wrong...19:01
fungii was being hip, channeling my inner millennial19:02
*** auristor has quit IRC19:02
AJaeger;)19:02
AJaegerclarkb: https://opendev.org/opendev/puppet-vinz is a RETIRED repo, should that really have gone to opendev? Something to double check aferwards?19:03
fungiwhere is the copy of repos.yaml file we're working from for the current playbook run?19:03
clarkbAJaeger: I think we moved all the puppetry19:03
AJaegerclarkb: ah19:03
clarkbAJaeger: I'm not too worried about it since over time we will grow retired repos anyway19:03
AJaeger;)19:03
corvusfungi: bridge:~root19:04
fungithanks19:04
clarkbso in the ansible output it says it is redirecting openstack/stx-manifest to starlingx/stx-manifest but https://opendev.org/openstack/stx-manifest redirects to https://opendev.org/starlingx/manifest properly19:04
fungiand yeah, things like puppet-vinz makes more sense as a retired opendev repo than a retired openstack repo19:05
clarkba bug in our log entries but not in the actual redirecting?19:05
fungiclarkb: is it maybe handling org transfers and renames separately?19:05
clarkbfungi: oh maybe19:05
corvusi think we moved vinz to x but forgot to move its puppet with it19:05
clarkbcorvus: ya I'm not going to lose any sleep over that19:05
corvusand yes, those are two separate operations in gitea19:05
clarkbthe vinz thing19:06
corvus"transfer repo ownership" is the org move and "update repo name" is the rename within the org19:06
clarkbgot it19:06
clarkbjust over 200 to go now19:07
fungiwas someone else planning to fire up the opendev-patching script or shall i get prepared to do so?19:07
clarkbfungi: I would be most comfortable if you did it :)19:07
*** auristor has joined #openstack-infra19:08
clarkbassuming that doesn't interfere with your holidaying today19:08
fungihappy to if folks want. i'm expecting it to require roughly half an hour but will start it in a screen session just in case my internet goes back to broken (it was offline again for several hours this morning but was back before i got home)19:09
fungii've just rejoined a root screen session on review.o.o dated from march 18... looks like maybe renidex stuff19:10
fungii'm going to close that one out and start a fresh one19:10
fungiand then su to gerrit2 within it19:10
fungialso going to copy the repos.yaml from bridge.o.o into ~gerrit219:11
clarkbfungi: ++19:12
clarkbabout 100 to go now19:13
mnaserseems like a rate of 100 per 5m19:13
fungiwhich would be ~1 every 3 seconds19:14
clarkbfungi: let us know when we should attach to the review screen19:14
fungiyou can attach at any time19:14
fungii've got the repos.yaml copied into place already and just confirming the checksum now19:14
fungilooks like it matches19:15
*** auristor has quit IRC19:16
*** ijw has joined #openstack-infra19:17
fungigerrit's offline so i can't be sure, did anyone make any additional comments or updates to the opendev-patching script after i last touched it?19:18
mordredI did not - I don't think any of us touched the patching script19:18
clarkbI did not19:18
clarkbstoryboard is updating now. gitea should be done19:19
fungiokay, i'll copy the last version of it i had onto review.o.o in that case19:20
clarkbthe last update I know for it was your fix for the acls in projects.yaml19:20
clarkbdoing the mkdir19:20
clarkbstoryboard is done, it is backing up the old gerrit index now19:20
fungiis the rename-repos playbook going to try to start gerrit?19:21
fungiand if so, is that a problem?19:21
corvusno it's done and gerrit is offline19:21
fungiokay, cool19:22
mordredwoot it is done!19:22
clarkbyup I'm just trying to confirm where the index backup is19:22
fungi~44 minutes runtime19:22
fungii'm ready with the opendev-patching script in gerrit2's homedir on review.o.o now whenever we're satisfied it's time to start that19:22
mordredrepos in storyboard look corret19:22
clarkbdrwxr-xr-x  6 gerrit2 gerrit2       4096 Apr 19 15:43 index.backup.155570163719:23
clarkbI think that was from our first pass through with the test repo19:23
fungithat looks like today19:23
clarkbbut I don't see one from the most recent run19:23
AJaegerfungi, just one comment on your script: We need to merge a couple of cleanups for project-config before we can merge anything there, I hope I pushed everything up for that. Our linters are not happy with your change as is (files are not sorted anymore).19:23
clarkbI think I'm ok with that given that file was from after gerrit was stopped19:23
fungiAJaeger: yep, that was expected19:23
AJaegerfungi: but let's go ahead with your script...19:23
corvusi'm "go"19:24
fungii wasn't sure what wuold need to be reordered, but it's just the one repo so should be a single patch19:24
*** kranthikirang has joined #openstack-infra19:24
mordred++19:24
fungiclarkb: ready?19:24
* AJaeger pushed several ones (one per file) - we can squeeze them together...19:24
clarkbI'm go with the note that we should have a second backup there and don't but it seems to be ok because we have the one from earlier today19:24
clarkbfungi: ^19:24
*** kaspars__ has joined #openstack-infra19:25
* AJaeger expects not to be around in time for helping with those, so, please take them and do what is needed...19:25
fungiyep, wfm. starting it now, eta ~20:00z19:25
fungistarted and hasn't crashed yet, so that's a plus19:25
clarkbAJaeger: thank you for that19:25
clarkbI wonder if the ansible warning about perms in /tmp is why we don't have a second19:26
clarkbin any case I think we have the backup we need so I won't worry too much19:26
fungitop says python3 and git are the most active processes and the got processes are churning pids so seems to be going19:26
corvusclarkb:  we should have only one, and that's the one.  it did work.  we never ran the backup play previously19:27
fungiit did cinder, and `git --git-dir=/home/gerrit2/review_site/git/openstack/cinder.git show master` has our commit19:27
clarkbcorvus: oh the timestamp seems off19:28
fungisame for `git --git-dir=/home/gerrit2/review_site/git/openstack/cinder.git show stable/pike`19:28
corvusclarkb: i think it's preserved from the original due to "cp -ax"19:28
clarkbah19:28
clarkbyay for more than one set of eyeballs :)19:28
corvusbetween all of us, we add up to a complete sysadmin :)19:28
clarkbdon't remind me of my ls/ln mixup. I'm still annoyed at myself over that one19:29
clarkbls -s does not do what ln -s does :)19:29
corvusi forgot ansible does things on remote hosts19:29
fungiheck, last night i was trying to do a dict.update() in a variable assignment19:30
clarkbnext step at ~2000zulu is start gerrit, check replication and online reindexing?19:31
fungii believe so19:31
fungii have a feeling the missing openstack repos on github will cause some replication failures19:31
clarkbshould I create the CNAMEs for git.airshipit.org git.starlingx.io and git.openstack.org to point at files.openstack.org now? or wait on that? zuul-ci is in gerrit so it will have to happen when gerrit is running19:32
fungiwe're not bouncing gitea again, right? so probably fine to start redirecting nowish?19:32
corvus++19:32
clarkbFrom where I stand gitea is happy and in its final state (other than needing replication to)19:33
*** kaspars__ has left #openstack-infra19:33
clarkbok I'll start working on those cname updates19:33
mordred++19:33
corvusand since we updated the cgit farm, i think we've started 404ing on some things, so now is a good time19:34
clarkband to double check files.o.o is my target right?19:34
clarkbI should say files.openstack.org19:34
corvusafaik :)19:34
fungiin theory the content on gitea is as intact as the content on the cgit farm19:35
fungi"replication" should be a (probably lengthy) no-op19:35
corvusagreed19:35
clarkbfungi: it will replicate all of your updates happening now19:35
clarkbother than that agreed19:35
fungiahh, right, those19:36
*** igordc has quit IRC19:36
mordredwhat did we decide the story is on the renames for the github repos?19:37
clarkbmordred: dmsimard wrote a thing that will transfer ownership of a repo from our org to another org if the target org adds our user as an owner temporarily19:39
clarkbmordred: this was already tested with ara so should be in good shape. Its just a matter of going through those motions19:39
clarkbI have updated dns19:39
mordredyeah - so that's good for things in openstack that are going somewhere else on github and where people care19:39
*** auristor has joined #openstack-infra19:39
fungifor things we're moving into the openstack org today we can probably just run it with our shared admin account19:40
mordredbut what about openstack repos that renamed within openstack orgs19:40
clarkbmordred: oh I see devstack etc19:40
mordrednod - so we just need, at some point, to make a filtered versio of repos.yaml and feed it to dmsimard's thing19:40
mordredclarkb: yeah19:40
clarkbmordred: ++ to that plan19:40
mordredclarkb: so I guess that would be anything in repos.yaml where to: starts with openstack/19:40
*** whoami-rajat has quit IRC19:40
fungishould be able to filer that down really easily19:40
corvusmordred: feel like doing that?  might be able to get it done before we bring gerrit up...19:40
mordredyeah. I'll go make the filtered version19:41
fungis/to/new/ but that, yes19:41
clarkbhttp://git.airshipit.org/openstack/airship-berth19:41
clarkbbe amazed ^19:41
clarkb(sorry I'm just really excited that worked)19:41
corvusa *lot* went into that :)19:41
*** kranthikirang has quit IRC19:41
* clarkb checks project-config19:42
*** kranthikirang has joined #openstack-infra19:42
clarkbproject-config redirects in my browser but git clone not working yet19:43
clarkbI don't think its cached dns so maybe something is not working?19:43
corvusclarkb: git.zuul-ci.org is a cname for git.openstack.org, so that's already in place19:43
* fungi is just amused that the top contributor in stackalytics for a very long time to come will be "OpenDev Sysadmins"19:43
mordredok. /root/repos-github.yaml19:43
clarkbcorvus: ah19:44
corvusclarkb: i agree, the cloning isn't working as expected19:44
clarkbfungi: ^ I know you tested this a bit any idea of why that may be?19:44
clarkbgit seems to send a git for the old path19:44
fungihuh, checking19:45
clarkbso is it not respecting the path part of the redirect and only doing the host?19:45
*** jamesmcarthur has joined #openstack-infra19:45
clarkbhttps://opendev.org/openstack-infra/project-config doesn't clone either19:45
clarkbso I don't think it is files fault19:46
fungicloning https://git.openstack.org/openstack-infra/zuul doesn't work for me but cloning https://git.openstack.org/zuul/zuul does19:46
fungileading me to think this may be a gitea issue19:46
mordredyeah. it doesn't work for me just pointing to opendev urls19:46
clarkbya I wonder if the redirects don't apply to cloning19:47
mordredthis is ... very unfortunate19:47
clarkbone workaround would be to do a large lookup table in apache redirects and point to the target19:47
fungiand yeah, i tested cloning insofar as i could, but only tested the apache to gitea redirects, not the inner-gitea redirects19:48
clarkbya19:48
*** slaweq has joined #openstack-infra19:48
clarkbbut basically have apache do a redirect from openstack-infra/zuul to zuul/zuul to address that?19:48
corvuswe don't have an apache in front of gitea19:49
clarkbno but we are updating opendev.org and paths at the same time where we do that so its less of a concern19:49
mordredhttps://github.com/niemeyer/gopkg/issues/50 <-- mention of latest git not following redirects by default19:50
clarkbis that git config somethign we can apply maybe?19:51
corvusi don't understand the relevance of that19:51
mordredI just tried - it doesn't help19:51
mordredso - potentially irrelevant19:51
fungiyeah, git *is* following redirects from apache on files.o.o to gitea on opendev.org19:51
mordredfungi: ah - yeah - good point19:52
clarkbya its gitea taht isn't redirecting the git client19:52
corvuspatches are done19:52
*** eernst has joined #openstack-infra19:53
fungii also keep getting "Corrupted Content Error: The site at https://opendev.org/openstack-infra/zuul/ has experienced a network protocol violation that cannot be repaired. The page you are trying to view cannot be shown because an error in the data transmission was detected. Please contact the website owners to inform them of this problem." with firefox19:53
clarkbfungi: I don't get that I go straight to https://opendev.org/zuul/zuul/19:54
fungithough that may be me... i also keep getting it for https://opendev.org/19:54
AJaegerfungi: works for me with firefox19:54
mordredfungi: I do not get that with that URL in chrome19:54
fungii'll restart firefox for good measure19:54
clarkbso with the git repo edits done do we need  a plan for the redirects not working with git or do we think that is something we can fix in a followup?19:54
clarkbI think that doing a lookup table in apache for the old domains will get us ~90% of what we need19:55
clarkbpeople using new domain will liekly have updated to new path too19:55
kranthikirangTeam, don't want to disturb you and work; Here is the test I have done from my setup; git clone https://git.openstack.org/openstack/airship-promenade/19:55
kranthikirangCloning into 'airship-promenade'...19:55
kranthikirangfatal: repository 'https://opendev.org/openstack/airship-promenade/' not found19:55
kranthikirangredirect works but the path is not correct?19:56
clarkbkranthikirang: that is the issue we are discussing now19:57
fungikranthikirang: yes, that's what we're working on solving now19:57
kranthikirangcool; thanks19:57
clarkbwe could do a quick hand edit on files.o.o for say project-config to prove that that redirect table will work19:57
fungii suppose we could reset the dns entry in the short term while we continue troubleshooting the gitea redirect19:57
corvusi'm attempting to find the problem with gitea19:57
clarkbfungi: I'm not sure that will help19:58
clarkbfungi: we've moved the repos on cgit servers19:58
fungiahh, right-o19:58
fungigreat point19:58
corvusdid someone get a trace of the http interaction?19:59
clarkbcorvus: GIT_TRACE_CURL=1 git clone https://git.openstack.org/openstack-infra/project-config19:59
clarkbthat will get you one20:00
corvusthx20:00
*** eernst has quit IRC20:00
fungifwiw, a firefox restart got me working again (at least solved the weird protocol error i was getting)20:01
fungiand thanks for the git envvar magic. i was trying git clone -v -v -v20:01
mordredwow. that's fascinating20:01
mordred20:01:21.153291 http.c:545              => Send header: GET /openstack/airship-berth/info/refs?service=git-upload-pack HTTP/1.120:01
mordredwhich gets a 40420:02
clarkbya gitea must be using different rules for git-upload-pack20:02
mordredjust doublechecked that redirects work for other subpath entries20:03
clarkbfungi: looking at the htaccess rules can we do a rewriterule for every rename before the ignore all args comment ? but rewrite to git.openstack.org and fallthrough for the other rules to apply?20:03
clarkbso git.openstack.org/openstack-infra/project-config -> gets rewritten to git.openstack.org/openstack/project-config then we apply any rules below for hashes or whatever20:04
clarkbthen that gets sent to opendev.org20:04
mordredin browser, https://opendev.org/airship/berth/info/refs works - but https://opendev.org/openstack/airship-berth/info/refs does not20:04
fungiclarkb: that's probably a viable workaround, if the bug in gitea turns out to be nontrivial to fix20:05
fungieasy enough to test by just editing the .htaccess file on disk. no apache restarts/reloads needed20:05
clarkbyup I'm drafting up a rule like that for project-config and will paste it here before I modify .htaccess20:06
*** arunkant has joined #openstack-infra20:06
*** basante has joined #openstack-infra20:07
clarkbfungi: RewriteRule RewriteRule "^(cgit/|)openstack-infra/project-config(.*)$" "$1openstack/project-config/$2"20:07
clarkber only one RewriteRule prefix20:07
*** ralonsoh has joined #openstack-infra20:08
clarkbneed to remove the / before $220:08
AJaegerclarkb: LGTM20:08
clarkbRewriteRule "^(cgit/|)openstack-infra/project-config(.*)$" "$1openstack/project-config$2"20:08
clarkbok I'm going to add that and test it20:09
fungii think so... may want to do something to better separate the .* at the end lest we end up with unwanted substring matches20:09
*** jcoufal has joined #openstack-infra20:10
funginot that there's going to be a openstack-infra/project-config-something-else but for other renames there might be (and might be matched by something which was rewritten in an earlier entry from the mapping, and might even end up causing a circular redirect under the right circumstances)20:11
mordred++20:11
clarkbRewriteRule "^(cgit/|)openstack-infra/project-config(/(.*)|)$" "$1openstack/project-config$2"20:11
clarkbfungi: ^ is that better?20:11
fungi(((.git/?)?|/).*|)$ maybe"?20:13
clarkbI think taht requires you to have a / if you .git but let me improve it20:14
*** jamesmcarthur has quit IRC20:14
clarkbRewriteRule "^(cgit/|)openstack-infra/project-config(.git|)(/(.*)|)$" "$1openstack/project-config$2$3"20:15
fungiwell, that's the reason i had the additional ? in it20:15
clarkboh I see20:16
fungibut what you have there would probably be roughly the same matches20:16
clarkbok giving that a go20:16
fungihopefully we'll either not need it or at least not need it for very long, because this doesn't solve future renames for folks who are already using opendev.org remotes20:17
fungiso it's a short-term stop-gap at best20:18
corvusi've identified a potential change; testing now.20:18
corvus(to gitea)20:18
fungialso the opendev-patching script seems to have completed, 27m19s20:18
*** basante has quit IRC20:18
mordredcorvus: nice!20:18
fungislightly faster than when i was testing in /opt, but that could also be due to having the server entirely idle20:19
clarkbok my fix doesn't work even though I redirect to the desired location20:19
clarkbthis is beacuse git does a listing of all the repos and branches at that location and the original url isn't one of them20:19
fungi`git --git-dir=/home/gerrit2/review_site/git/openstack/project-config.git show master` shows acl moves too, so i think we're good20:20
clarkbhttp.followRedirects may be what I need for my fix to work20:20
clarkbtesting20:20
corvusmy first fix almost worked: http://paste.openstack.org/show/749550/20:22
corvusit lost the query string in the redirect20:23
clarkbcorvus: thats a good sign20:23
corvusclarkb: i don't understand what you're saying about http.followRedirects20:23
mordredoh - so close20:23
fungii have serious doubts git's http.followRedirects is relevant at all here20:24
clarkbcorvus: with my htaccess update git is listing the branches properly on opendev for openstack/project-config but none of them are openstack-infra/project-config so it rejects the data there20:24
clarkbsupposedly you can tell git to follow those redirects ?20:25
corvuswell, any solution that requires us to ask people to set a git option is a non-starter20:25
clarkbyes I agree20:25
corvusthat's like, roll-back territory.20:25
clarkb(I'm just trying to understand what the options are here, mroe than happy for your proper fix to properly fix it :))20:26
*** ralonsoh has quit IRC20:26
corvuswell, i'm worried about whether mine will given that a simple apache redirect doesn't work?20:26
clarkboh wait I see anotheri ssue int he apache redirect20:27
clarkbGET /openstack/project-config/info/refs/project-config/info/refs?service=git-upload-pack HTTP/1.120:27
clarkbits redirecting to a bad path so maybe I misinterpreted the error. I will work on understanding that rewrite20:27
fungihttp.followRedirects:  Whether git should follow HTTP redirects. If set to `true`, git will transparently follow any redirect issued by a server it encounters. If set to `false`, git will treat all redirects as errors. If set to `initial`, git will follow redirects only for  the initial request to a remote, but not for subsequent follow-up HTTP requests. Since git uses the redirected URL as  the base20:28
fungifor the follow-up requests, this is generally sufficient. The default is `initial`.20:28
fungiso i suppose it's not an all-or-nothing option, it's a trinary20:28
fungilooks like that was added in git 2.11.120:29
fungiso has been in place more than a couple years20:29
clarkbfungi: I don't understand how I end up with that GET above since I shouldn't hit any of the cgit/ rules20:30
clarkbfungi: any idea what might be going on there?20:30
mordredfor contrast, I did the GIT_TRACE_CURL thing with github.com/openstack/ara - github does not return a redirect, it returns the actual content directly from the old path20:31
fungiclarkb: i'm missing what's wrong with the path you pasted20:31
fungiwhat should it have been/what did you expect there?20:32
clarkbGET /openstack-infra/project-config/info/refs?service=git-upload-pack is the initial request and gets rewritten to GET /openstack/project-config/info/refs/project-config/info/refs?service=git-upload-pack20:32
clarkbfungi: the rewrite has project-config twice20:32
mordredclarkb:  I agree - that rewritten url is definitely wrong20:33
fungiahh, /project-config/info/refs is repeated. so perhaps the positional vars aren't what we expected20:35
clarkbRewriteRule "^(cgit/|)openstack-infra/project-config(.git|)(/(.*)|)$" "$1openstack/project-config$2$3" is the rule20:36
corvus\o/  http://paste.openstack.org/show/749552/20:37
corvusthat appears to work for a simple in-org rename20:37
corvusi'll try an org tranfer and org tranfser + rename next20:37
*** slaweq has quit IRC20:37
mordredcorvus: woot!20:37
fungian encouragingly small patch20:38
mordredcorvus: since you posted the first one, I've been reading that code trying to see if I could spot the second thing ... I'm glad you did :)20:38
mordredso - we STILL might need to get clarkb's thing to work if recent git only follows the first redirect20:39
clarkbI'm still at a loss20:40
clarkbdo I need to root with / at the beginning of my regex?20:40
fungishouldn't20:40
fungithe earlier matches work and don't start with a /20:40
corvusall 3 cases check out: http://paste.openstack.org/show/749553/20:41
*** dwalt has joined #openstack-infra20:41
clarkbcorvus: nice20:41
mordredcorvus: excellent. I support restarting our giteas with that20:41
fungiawesome! we need gitea images built from a fork with that patch applied though, right?20:41
clarkbI'll keep banging my head on the rewrite rule in case that becomes useful20:41
clarkbfungi: yup corvus already has one of those handy20:41
corvusokay.  i'll start the process for that20:42
mordredclarkb: do you really need the (cgit/|) ?20:42
clarkbmordred: no I don't think so20:42
clarkbso why don't I start by simplifying that20:42
mordredmaybe remove that for ... yeah20:42
clarkbRewriteRule "^openstack-infra/project-config(.git|)(/(.*)|)$" "openstack/project-config$1$2" is the new rule20:42
mordredgive it a shot20:43
clarkbstill getting GET /openstack/project-config/info/refs/project-config/info/refs?service=git-upload-pack but one less thing to debug now20:43
fungioh, right, the cgit urls aren't an issue anyway, just the git+http protocol urls20:44
mordredit's so weird that project-config gets repeated and not openstack/20:44
clarkbmordred: right or openstack-infra20:44
mordredyeah20:45
corvusthis look good to everyone?  https://github.com/jeblair/gitea/commit/cae7c35bfc9c834cdd8ca14f5ec73bd120f5149320:45
clarkbcorvus: I think so20:46
corvusand we're up to 4 commits on that branch: https://github.com/jeblair/gitea/commits/opendev20:47
mordredcorvus: ++20:47
corvusi'm rebuilding the image now (using that, rather than the docker source directory) to make sure it's clean20:48
mordredawesome20:48
*** ykarel|away has quit IRC20:48
corvuspushing20:49
*** jcoufal has quit IRC20:50
fungii have hopes the additional rewrites on files.o.o will be unnecessary. my reading of the http.followRedirects=initial default is that it follows however many redirects it encounters to arrive at content for its initial request, but then expects subsequent requests to be served from the same place the initial request finally was20:50
mordredah - ok20:51
mordredgood20:51
mordredthat would be way more pleasing20:51
clarkbI think adding a [L] may fix my redirect20:51
clarkbso if it is necessary I'm close to a solution there I think20:52
mordredcool20:52
mordredI agree with fungi - I hope that we don't need that20:52
fungiclarkb: oh, yes you likely do need a [L] (the ones i added needed one as well)20:52
mordredand that reading seems to make more sense20:52
fungiyeah, only following the first in a chain of redirects would be an odd misfeature20:53
clarkbhttp://git.openstack.org/openstack-infra/project-config works now with the [L]20:53
mordredclarkb: awesome20:53
clarkbif corvus fix doesn't work for some reason we have an out with my redirect20:53
corvusimages pushed20:54
mordredfungi: we live in an age of constant odd misfeatures20:54
clarkbRewriteRule "^openstack-infra/project-config(.git|)(/(.*)|)$" "openstack/project-config$1$2" [L]20:54
clarkbI'm going to comment that out now20:54
clarkbso that we don't have it interfere with corvus' things20:54
corvusi will dig out my bridge screen and use it to restart gitea20:54
clarkbI've commented out my files.o.o htaccess change20:55
corvusbridge command look good?20:56
clarkbcorvus: yes20:57
*** kjackal has quit IRC20:58
fungiclarkb: puppet would likely eventually revert it anyway20:58
clarkbfungi: ya though for puppet to work it needs that redirect to work aiui20:58
corvusgit clone https://git.openstack.org/openstack-infra/project-config20:59
clarkbbecause project-config20:59
mordredclarkb, fungi: I've got repos-github.yaml - what's the dmsimard playbook I should feed it to?20:59
corvusclarkb: that's what you were trying ^?20:59
clarkbcorvus: yes20:59
corvusseems to work for me now20:59
clarkbcorvus: I agree you are a magician20:59
mordredwoot!20:59
mordredI cloned airship-berth and it worked20:59
fungi`git clone https://git.openstack.org/openstack-infra/zuul` is working for me now21:00
clarkbwoo I think we can call that fixed now21:00
clarkbkranthikirang: can you check too?21:00
clarkbkranthikirang: try the clone/fetch you were doing before that failed21:00
fungias is `git clone https://git.zuul-ci.org/zuul`21:00
kranthikirangyeah, git clone https://git.openstack.org/openstack/airship-promenade/21:00
kranthikirangits working21:00
* corvus quickly closes stackoverflow window with "what do they call null in go again?" before anyone notices21:00
kranthikirangcool, team21:00
clarkbkranthikirang: thank you for checking and sorry for the trouble21:00
smcginniscorvus: ;)21:00
kranthikirangclarkb: No, I am watching all your conversation21:00
mordredkranthikirang: you can now also git clone https://opendev.org/airship/promenade21:01
kranthikirangthank you; I was struck because of this :)21:01
clarkbok so where were we21:01
fungikranthikirang: thanks for helping out!21:01
clarkbgitea redirects work21:01
clarkbgerrit in place commits have been made21:01
mordredI think we were at fungi changes21:01
clarkbare we ready to start gerrit?21:01
mordredah - I think we are21:01
mordredunless we want to run the github renames21:01
clarkbor at least verify those changes then start gerrit?21:01
fungiwhich fungi changes? those finished like an hour ago21:01
mordredso that gerrit doesn't derp on replicating to thigns that have moved21:02
clarkbfungi: the in place git repo updates21:02
clarkbmordred: thats a good point21:02
clarkbmordred: are you able to drive that?21:02
corvusi dig doing the github stuff if it's ready, it will save weirdness later21:02
corvusi also dig mordred driving it :)21:02
mordredclarkb, corvus : happy to drive - what's the playbook?21:02
mordredI have the data file ready21:02
fungime too. the less i touch github, the less murderous i feel21:02
clarkbuh it was  dmsimard change of course with gerrit off its harder to find these things :)21:02
mordredI think we maybe didn't land it21:03
clarkbya21:03
corvusi'm on it.  :)21:03
mordredwell piddle21:03
mordredyay!21:03
clarkbmordred: its ok corvus has everything cached21:03
mordredcorvus is the magical pony of today21:03
fungigertty ftw21:03
* mordred dubs corvus Star Baker21:03
*** Emine has quit IRC21:04
corvusoh, i only score half a point on this one21:04
corvusmy gertty doesn't have the latest rev cached.  however, it's 644937 in system-config21:04
corvusso we can pull it out of gerrit's repos with that21:04
clarkblatest rev did have a bugfix too21:04
* mordred is certain if Paul Hollywood were here, he'd shake corvus' hand21:04
fungii have no idea what a paul hollywood is, but sounds glamorous anyway21:05
clarkbmordred: how many projects are there to move like that out of curiousity?21:05
clarkbbeacuse we can probably click buttons too21:05
corvusi'll grab the script from gerrit's repos21:05
clarkbcorvus: k21:05
mordredclarkb: 3121:05
fungifewer than i thought21:05
clarkbya 31 is within the realm of reasonable sanity if we have to do it by hand21:05
mordredyeah21:05
clarkbI'll go get my keychain in case that becomes necessary21:05
*** diablo_rojo has joined #openstack-infra21:06
mordredfungi: paul hollywood is one of the judges on the Great British Baking Show ... and if he's really impressed with your cake, he shakes your hand and it's a big deal when he does21:06
pabelangero/ I'm online for the next few hours, if there is anything I can help with. Otherwise, keep up the awesome work!21:06
corvuslooks like refs/changes/37/644937/6 is the one21:07
fungimordred: oh, i think i've seen that, but only notable because it was co-hosted by noel fielding (a.k.a. vince noir from the mighty boosh)21:08
corvusmordred: bridge:~root/github-org-transfer.py21:08
mordredfungi: yes. noel is a lovely co-host21:08
clarkbfungi: I think you mean it crowd21:08
mordredcorvus: aweome. looking at that now21:08
fungiclarkb: that too21:09
fungiclarkb: he was richmond on the it crowd, yes21:09
fungibut i liked him on boosh better21:09
kranthikirangI just ran update_software to see how the git clone works on repos and looks like everything is good; just FYI21:09
mordredkranthikirang: woot!21:09
mordredcorvus: so - looks like it would be maybe easiest to write a playbook that does the loop on the repos21:09
fungikranthikirang: thanks! that's an excellent real-world test, i expect21:09
mordredclarkb: becuase the script wants username and password set - and I'm guessing we can find those in hiera somewhere21:10
kranthikirangfungi: sure thing21:10
corvusmordred: ++21:10
fungimordred: i believe the password ends up being the otp code21:10
fungiso may need to get a new otp passcode each call, i don't exactly know how that works21:10
corvus# TODO: Add support for two factor authentication by passing the "x-github-otp"21:11
clarkbya so I think dmsimard got a token with the otp21:11
mordredoh good21:11
corvus# The password can be the account's password or a personal access token created21:11
corvus# at https://github.com/settings/tokens21:11
clarkbso you go into the web ui, get a token using otp then you don't ahve to otp when you run the script21:11
fungiaha, that's easier then21:12
mordred... neat ... so, I don't think I have yet used the otp thing - anybody got a pointer to the instructions on that?21:12
clarkbmordred: its in the secrets file21:13
fungithey're in the password list21:13
mordredcool21:13
fungieasy cut-n-paste commands21:13
clarkbI wonder if we even need ansibel for that?21:15
mordredI'm sorry - I'm feeling really dumb here - I have no idea how this works or how I'm supposed to use it.21:15
fungitry to log into the github webui with that username21:16
clarkbmordred: so you login with the password listed as per normal. Then github will send you to a secondary screen saying enter your otp code21:16
fungiit will prompt for an otp code21:16
mordredok21:16
clarkbmordred: then you run the command given in the secrets file to get the otp code and enter its output in that second login screen21:16
fungirun the command on bridge with the secret to generate an otp code and then paste that into github21:16
fungiafter that you should be able to go to account settings or something and find where to generate an api token21:17
mordredok. neat. that worked21:17
mordredis this a Personal Access Token perhaps?21:18
fungisounds reasonable21:18
clarkbmordred: that is what the comment above that corvus pasted says21:18
mordredcool21:19
*** cgoncalves has joined #openstack-infra21:19
mordredok. I think those are good. now we just need to run that script with the arguments21:20
mordreddoes that look good to folks?21:23
clarkbwhere do we supply the token?21:23
corvuslooking21:23
clarkbalso might want to run it on a single repo to start like we did with the other moves21:23
mordredclarkb: I put it in GITHUB_PASSWORD env var21:24
mordredclarkb: good point21:24
clarkbthe env var won't get passed through ansible will it?21:24
corvusmay as well put it in the script21:24
corvusopenstack/git-review doesn't look right21:25
clarkbhrm https://opendev.org/opendev/git-review is a 404 :/21:26
mordredthat does seem to be what we rewrote it to21:26
corvushowever, that's what's in repos.yaml21:26
corvusyes; i think that may be an error that goes back to the first script21:26
corvuswe did spot-check some infra things21:26
mordredyup21:26
mordredgit-restack is correctly in opendev21:26
dtroyercatching up a bit with some testing: should "git clone https://git.openstack.org/openstack/stx-manifest.git" work?  It does without the trailing .git21:26
clarkbthe ethercacl has it as opendev/git-review21:27
mordredthat work for folks?21:28
clarkbdtroyer: I can confirm that doesn't seem to work in the general case but dropping .git does21:28
clarkbmordred: if that question is re the edits to the moving script yes I think so21:28
clarkbdo we think we move git-review later?21:28
mordredcool21:28
clarkb(to opendev that is)21:28
corvusyeah, mordred dropped it from the github list21:29
mordredwell - I put it in the single-list to use as a test21:29
mordredbut I can pick up a different one21:29
mordredhow's that for a test run21:29
clarkbmordred: wfm21:30
corvuswfm21:30
mordredcool. going to try it21:30
mordredseems to have worked21:30
corvusagree21:30
fungiit's not clear to me what happened with git-review... some problem earlier when i was afk?21:30
clarkbyup I agree too21:30
corvusfungi: it ended up in openstack rather than opendev21:31
mordredk. I'm going to run on the remainder if everyone is ok with that21:31
*** Lucas_Gray has joined #openstack-infra21:31
clarkband seems to be due to original repos.yaml state21:31
corvusmordred: ++21:31
clarkbmordred: ++21:31
fungiweird, repos.yaml should have taken the value from the ethercalc21:31
clarkbmordred: hrm is the token one shot?21:31
mordreddo I need to generate a new token for each thing?21:31
corvusfungi: i see the problem; it's a typo in the ethercalc21:32
mordredoh - openstack-dev21:32
clarkboh wow ya I see it too21:32
mordredopenstackadmin may not have openstack-dev access21:32
corvusmordred: i'll see if my account can fix that21:32
clarkbI can fix it if you can't21:33
fungicorvus: oh, good, not a systemic issue with the script then21:33
*** yamamoto has joined #openstack-infra21:33
mordredyeah - it looks still owned by us indivdually21:33
clarkbopenstack/ openstack-infra/ openstack-dev/ are the three that that needs to be owner on right? are there any old entries from a different source?21:34
fungimordred: i think dmsimard noted that he had to do something to add permissions for the openstackadmin account in the openstack org too21:34
clarkbya that was the owner perms from team member I think21:34
* fungi checks the saved notifications from that21:34
mordredyeah - it's working on openstack and openstack-infra21:34
*** ijw has quit IRC21:34
corvusclarkb, mordred: i see openstackadmin as a maintainer in openstack-dev21:34
mordredcan you make it an owner?21:34
corvusi may not understand the acl situation21:35
*** diablo_rojo has quit IRC21:35
corvusdidn't they get rid of owners?21:35
funginotification from that said "granted admin access"21:35
fungiso needs to be set as an admin of the org21:35
clarkbcorvus: if you clikc the little gear next to it in people/ then select manage there is an otpion to make it owner21:35
mordredhttps://github.com/orgs/openstack-dev/people show 7 of us as owners, whatever that means21:35
clarkbI think that is what we need21:35
fungiseems like org members can modify and add/remove repositories but admin perms are needed to do transfers?21:36
corvusdone21:36
corvusmakes perfect sense <EYE ROLL>21:36
*** ijw has joined #openstack-infra21:36
clarkblooks much happier21:36
corvusso that's set on -dev and -infra21:36
fungiyeah, i can't make heads or tails of their new rbac21:36
corvusanything else for me to check?21:36
clarkbcorvus: I think that is all of them that are going into openstack/21:37
mordredok. the devstack redirect works21:37
ianw_ptoo/ ... i can't imagine i'm much help at this point but am aroundish21:37
corvusi guess we'll find out if i see red :)21:37
*** ianw_pto is now known as ianw21:37
mordredthey all seem happy now21:37
corvusshall we move git-review?21:37
clarkbcorvus: now is probably a reasonable time to do it21:37
clarkbeverything is off etc21:37
mordredyeah21:37
*** yamamoto has quit IRC21:38
corvusrun the one-off rename playbook with just that... we'll also have to manually fixup the zuul config for it21:38
clarkbyup21:38
clarkbI can drive that21:38
corvusclarkb: go for it21:38
mordredclarkb: con is yours21:38
mordredcorvus: also - move zuul keys21:38
mordredsince I don't think the one-off rename playbook has that yet21:38
corvusi'll move the zuul keys21:38
clarkbhow does that repo yaml file look?21:39
clarkbianw: we are in root screen on bridge if interested in watching21:39
mordredlooks great21:40
corvusclarkb: lgtm.  zuul keys moved.21:40
*** eernst has joined #openstack-infra21:40
mordredclarkb: I'm assuming repos in github that we're now going to be not replicating to and will become stale are something we'll chalk up for later, yeah?21:40
mordredsomething something archive flag something I think?21:40
mordred(not urgent we do before gerrit update of course)21:40
corvusmordred: (that's the assumption i'm working under)21:41
clarkbmordred: ya plan was to help people do org transfers like you just did when we can coordinate on both sides21:41
*** ijw has quit IRC21:41
clarkbhow does my command look in the screen? ready to run that?21:41
fungiwhich may also involve unarchiving then first21:41
corvusclarkb: ++21:41
clarkbok running that now21:41
mordrednod. I think while I'm in there and looking at it, maybe I should go ahead and archive git-review, since it's moving to 'not mirrored to github' land21:42
fungisince at some point in the near future whoever takes over curating the openstack org on gh will probably want to archive all the stuff which got moved out of there21:42
mordredfungi: ++21:42
clarkbok that looks happy should double check the gerrit index backup again maybe21:42
clarkband test that cloning works21:42
corvushttps://git.openstack.org/openstack-infra/git-review goes to https://opendev.org/opendev/git-review21:43
clarkbI can clone it too21:43
mordredawesome21:43
clarkbok before we continue a few things. dtroyer points out that the .git suffix redirects aren't working21:43
fried_riceIn case nobody has mentioned this yet today: https://www.youtube.com/watch?v=KSQyW_l8OgE&feature=youtu.be&t=4621:43
clarkbalso in the etherpad we have it saying we should update the gerrit config and apache before starting gerrit21:44
clarkbdo we actually want to do ^ before hand or later?21:44
clarkbfried_rice: ha21:44
corvusfried_rice: lol :)21:44
mordredso - I'm not going to archive git-review in github - it mentions it makes it read-only but it can still be cloned - we might want to push a 'this repo is no longer here, please see opendev' commit before archiving21:44
mordredso let's leave that til later21:44
corvusmordred: agree21:44
clarkbwfm21:44
clarkbI think we already expect people to update remotes so its not the end of the world to me that .git doesn't work (I don't knwo if gitea expects to support that? /me tests)21:45
corvusif not, we can have the redirect drop it21:45
clarkbya even a direct clone with .git  without any redirects fails21:46
*** eernst has quit IRC21:46
mordredkk. so we just need to have the redirects drop .git21:46
clarkbso this may be a slightly annoying corner case that we roll forward with21:46
mordredyeah21:46
mordredwe can fix it after the fact21:46
clarkb++21:46
clarkbdtroyer: ^ fyi we plan to fix it but not a blocker for now21:46
clarkbdtroyer: thank you for catching that and letting us know21:46
dtroyerclarkb: I think if the redirects can drop it we can live with it21:47
clarkbso now we have to decide if we update gerrit before we start it or if we start it as review.openstack.org one last time21:47
clarkbalso I need a quick bio break21:47
clarkbbrb21:47
corvushere are the redirects if anyone feels like hacking on that: https://opendev.org/opendev/system-config/src/branch/master/modules/openstack_project/files/git-redirect.htaccess21:48
fungii thought i tested with .git extensions in urls21:48
clarkbgit clone https://opendev.org/opendev/git-review.git does not work for me fwiw21:49
dtroyerfungi: this is specifically with git clone21:49
clarkbwith the browser it works21:49
dtroyeragreed ^^^21:49
smcginnisWould it be it is getting a "/" appended to the URL when it should not?21:50
corvusyeah, i think we did not know that we needed the apache redirects to drop .git when going to gitea because gitea does not support .git21:50
smcginnisHmm, that works in browser with "/" too.21:50
fungiyeah, looks like maybe we're redirecting .git suffixes (which i tested) but that perhaps gitea doesn't support them?21:50
corvusoh weird21:50
corvusgitea web ui does render with '.git'21:50
clarkbcorvus: yup21:50
* corvus starts to get worried we may want another gitea patch21:50
mordrednah - I think just dropping them in the redirects is still fine21:51
fungiit does seem less like a missing feature and more like an actual bug, if they support browsing with .git extensions21:51
mordredI don't think it's important to support cloning with .git extension from the opendev urls21:51
mordredbut yeah21:51
mordredwhat fungi said21:51
corvus(i'm really tired of searching for the word "git" in the gitea source)21:51
*** fried_rice is now known as efried21:51
mordredI think if we never get around to fixing that, the world will continue turning21:52
clarkbya I still don't think it is a blocker. If we note that as a gotch and drop .git in our redirect htaccess file I think we'll be good21:52
mordred++21:52
fungiwell, the rewrite commits very well may have updated clone urls in some jobs with .git extensions, granted jobs cloning from git rather than from on-disk copies is not recommended21:52
mordredclarkb: I'm torn on updating gerrit - I could go either way21:52
mordredfungi: yeah - if people are cloning from git.openstack.org in their jobs, they get to keep both parts21:53
fungii agree "fixing" it on files.o.o seems like a fine solution21:53
clarkbI'm kinda leaning towards turning it on as review.openstack.org so that we can merge the chagne "normally" (even if that means a force merge)21:53
mordredclarkb: yeah. I think me too21:53
*** mriedem has quit IRC21:53
mordredwe can always hup gerrit later to pick up the changes - it's not necessary to do while off21:53
fungiwhich change are we needing to merge?21:53
*** jamesmcarthur has joined #openstack-infra21:53
mordredthe change to turn review.openstack.org into review.opendev.org21:54
clarkbfungi: the one that updates apache and gerrit config to serve gerrit as review.opendev.org21:54
fungioh, hah. how very catch-2221:54
mordredalso - do we want to update zuul's main.yaml and restart it before we turn gerrit back on?21:54
mordredor are we ok with maybe missing events?21:54
*** kranthikirang has quit IRC21:54
corvusi think we should get gerrit up and running, replicate, then update zuul's config and start zuul21:55
mordredkk. cool21:55
clarkbcorvus: before we turn it into review.opendev.org (to be clear)?21:55
fungiwhat else do we need to update in main.yaml which the opendev-patching script didn't get?21:55
mordredfungi: nothing - it's just that we need to roll that file out to zuul.o.o21:55
fungiahh21:55
fungirighty-o21:56
mordredfungi: or, that is - nothing that we know of21:56
clarkbalso we can possibly leave the firewall rules in place so that we can merge what we want without anyone else pushing stuff21:56
clarkbthough that might get weird with openid login redirects21:57
mordredI'm going to revoke the personal access token I created for openstackadmin21:57
corvusi lean toward manually merging the review.opendev.org change, then turning it on21:57
clarkbmordred: ++21:57
clarkbcorvus: that also works for me21:57
corvusalso fwiw, i think i found the one line to change in gitea to make .git clones work...  i can start testing that in the background if we want21:57
clarkbcorvus: that might be a good task while we wait for gerrit to replicate once it is up?21:58
clarkbso what I'm hearing is merge review.opendev.org switchover change, apply it to review.opendev.org ?, wait for replication and start zuul ?21:58
*** jamesmcarthur has quit IRC21:58
mordredwe'll need to manually merge the change, then run ansible to apply the stuff21:58
mordredclarkb: that is what I'm hearing21:58
clarkbfwiw we could also just apply it to bridge.o.o21:59
clarkbthen merge it when gerrit is up21:59
mordredyeah21:59
*** jamesmcarthur has joined #openstack-infra22:00
clarkb653507 is that change22:00
mordredcorvus: do you have it in your gertty cache?22:00
corvusyes. patchset 8 is current22:00
mordredcool22:00
fungisounds good22:01
corvuswant me to push it onto /opt/system-config on bridge?22:01
mordredyes22:01
corvuswill do22:01
mordredand then we want to kick.sh review yeah?22:01
clarkbmordred: ya as long as we don'22:01
clarkber22:01
clarkbas long as we don't expect it to update /opt/system-config on bridge or reenable the cron22:02
mordredkick doesn't run bridge.yaml22:02
clarkbk22:02
mordredwhich is what does that22:02
clarkbsorry I'm really paranoid about all that because it did that in the past22:02
mordredTOTALLY22:02
mordredI'm only saying that confidently because I checked earlier due to your paranoia22:02
clarkbroger22:02
clarkbnote that that is going to do a git fetch against https://git.openstack.org/openstack-infra/project-config22:03
clarkb(just something to keep an eye out for)22:03
clarkbon review01 that is22:03
clarkboh hold on22:03
ianwFYI on the .git extension; mitm proxying it the request is for 127.0.0.1:43346: GET https://opendev.org/opendev/git-review.git/info/refs?service=git-upload-pack22:03
clarkbthat git fetch is not going to have the renamed repos in it22:04
mordredoh right22:04
clarkbdo we have to worry about manage-projects undoing all our work?22:04
clarkb(sigh)22:04
mordredyeah. I think we need to start gerrit and get stuff replicated22:04
mordredotherwise rolling that change out to gerrit is gonna potentially cause havoc22:05
corvusclarkb, mordred: i have cherry-picked 653507 onto /opt/system-config on bridge22:05
mordredcorvus: I think clarkb has noted a reason this is dangerous22:05
corvusi will read back then :)22:05
clarkbalso we need to update opendev/git-review in gerrit/projects.yaml for that22:05
mordredyeah22:06
corvuswhat are we expecting kick.sh to do?22:06
mordredrun manage-projects after cloning project-config22:06
clarkbcorvus: it may run manage-project (jeepyb) and create all the repos we just moved22:06
corvusoh that would be very bad22:06
mordredyeah22:06
corvusi thought it only did that as part of a special playbook22:07
clarkbbeacuse it fetches project-config from https://git.openstack.org/openstack-infra/project-config22:07
clarkbno it is in puppet22:07
corvus"neat"22:07
clarkbit may only run it if the file has updated22:07
clarkbin which case we can check the file on both sides and cross our fingers22:07
fungiyeah, and i guess that will successfully redirect to the current state in gitea which is still missing replication of the opendev-patching result, so agreed bad22:08
corvusi don't think there's anything we need to do to gerrit to bring it up to replicate22:08
mordredme either22:08
fungii concur22:08
clarkbthe one gotcha is git-review22:08
corvusso we can do that, maybe even manually merge the git-review fixup,22:08
mordredwe could manually merge the git-review fixup real quick before we start22:09
corvusthen after that it should be safe to merge 653507 then kick, then restart22:09
mordredyeah22:09
corvusmordred: that works too22:09
clarkbyup22:09
fungiyeah, should be able to bypass zuul and manually submit the change22:09
corvusso: 1) fix git-review in project-config; 2) start gerrit; 3) merge 653507 in gerrit; 4) wait for replication; 5) kick22:10
*** kaspars__ has joined #openstack-infra22:10
clarkbcorvus: yes that sounds right to me22:10
mordred6) restart gerrit22:10
*** ijw has joined #openstack-infra22:10
corvus++22:11
corvuswho wants to do #1? :)22:11
clarkbfungi: ^ you probably have the most familiarity with it22:11
corvushttp://paste.openstack.org/show/749554/  appears to cause "git clone foo.git" to work with gitea22:11
mordredcorvus: I'm so glad you understand the code there22:12
corvusmordred: i absolutely positively 100% understand it and all the implications.22:12
fungiclarkb: hrm, i suppose there could be incorrect git-review references in other repos now too, but hopefully not22:13
*** diablo_rojo has joined #openstack-infra22:13
corvusfungi: yeas, it seems unlikely, and we can fix them later i think.22:13
clarkbya though in theory they will just cause things to break not create new projects22:13
corvusmordred: (i understand that it looks a lot like the code 20 lines up)22:13
fungiso i guess we need to just update zuul/main.yaml, gerrit/projects.yaml, gerritbot/channels.yaml and maybe move an acl file22:13
*** ijw has quit IRC22:13
clarkbthinking out loud here we could also as a step 4.5 update the project-config on review.openstack.org and manually run manage-projects to confirm it works. Then we don't ahve to worry about puppet hiding an issue and by updating it ourselves puppet shouldn't run it too22:14
*** ijw has joined #openstack-infra22:14
corvusfungi: sounds about right22:14
mordredclarkb: ++22:14
corvusclarkb: i would not object to that22:14
*** rpioso is now known as rpioso|afk22:14
fungiyeah, wfm22:14
*** kaspars__ has left #openstack-infra22:15
fungii can push a fix for git-review directly into project-config on disk too, is that what we want?22:15
mordredfungi: yes22:15
clarkbyup then we can start gerrit and let it replicate22:15
*** rh-jelabarre has quit IRC22:15
fungiworking on it already22:17
fungishould have it done here in a few minutes22:17
fungi`git grep --files-with-match openstack/git-review` only identifies 4 files22:18
fungizuul.d/projects.yaml being the only one i didn't already consider22:18
corvusshould i rebuild the gitea images with this?  https://github.com/jeblair/gitea/commits/opendev22:24
clarkbcorvus: +1 if you are happy with it22:24
clarkbthe route addition makes sense to me22:24
corvusif you look up a bit in the file you'll see something similar for the web ui22:24
mordredcorvus: ++22:24
corvus21 lines up.  i guess wrong :)22:25
corvusk, i kicked that off, i'll let you know when it's pushed22:25
mordredcorvus: we should also get those patches sent in as a PR and see if they'd be willing to squeeze them in to 1.8 - which they might not, given it's on rc4 already - but maybe they're simple enough that they'd accept them for an rc522:26
corvusyeah, i'll push up 2 new branches and open prs22:26
fungidoes http://paste.openstack.org/show/749556/ look like the patch folks are expecting me to push into the canonical project-config repo?22:26
fungi(that is to say, /home/gerrit2/review_site/git/openstack/project-config.git on review.o.o)22:27
clarkbfungi: yes22:27
mordredfungi: yes22:27
mordredI'm looking forward to the followup fun of moving things from the openstack zuul tenant to the opendev zuul tenant22:28
mnaserhow neat, I was going through launchpad, clicked https://git.openstack.org/cgit/openstack/neutron/commit/?id=37d33b2fcd4a1dde356df3b4b4a2f739afb6876c and went straight to the right url, awesome work so far everyone :)22:29
fungi`git --git-dir=/home/gerrit2/review_site/git/openstack/project-config.git show master` shows it applied now22:29
mordredmnaser: \o/22:29
mordredfungi: awesome.22:29
clarkbok any last items to check before we start gerrit?22:29
clarkbmaybe someone can figure out how to list the queues with the firewall in place22:30
*** kaspars__ has joined #openstack-infra22:30
corvusclarkb: should be able to with agent forwarding22:31
ianwclarkb: ssh to 127.0.0.1 as gerrit2?22:31
corvusor that22:31
clarkbok should I start it then?22:31
clarkblets tail the error log in fungi's screen22:32
mordredclarkb: ready as I'll ever be22:32
clarkbI started a tail -f in that screen22:32
clarkbI can start it in another window22:32
clarkbjust give me the go ahead22:32
fungiwfm22:33
mordred++22:33
fungino need for another window22:33
fungithat one has nothing useful in it22:33
clarkbfungi: I mean the tail is useful :)22:33
clarkbcorvus: ^ ready?22:33
fungioh, right, yes another window besides the tail22:34
* fungi makes universal "thumbs-up" sign22:34
clarkbshould I keep waiting for corvus or go for it?22:35
corvusback22:37
clarkbcorvus: I'm ready to start gerrit if you are22:37
corvus1 sec and i'll catch up22:37
clarkband fungi's root screen has a tail -f of the gerrit error log22:37
clarkbk22:37
corvusftr: https://github.com/go-gitea/gitea/pull/668822:37
corvusi'm ready22:37
clarkbalright I am starting gerrit now. here goes22:38
*** slittle1 has quit IRC22:38
clarkbit says it is ready22:38
corvus  18800 tasks22:39
corvus  37871 tasks22:39
fungiburning down quickly22:39
corvus  37023 tasks22:39
fungioh, wait, climbing22:39
fungibut now falling22:39
corvusnow heading downhill yeah22:40
clarkbshould I start online reindexing? or wait on that for after the second restart?22:40
mordredhttps://opendev.org/airship/divingbell/commit/c45e4faa126e9a1cad7b5d917b71616b674f5ab422:40
mordredlookie there! it's a transition patch22:40
corvusi don't see errors in the replication log22:40
clarkbno errors in the error log either22:40
corvusclarkb: i vote index after second start22:40
clarkbcorvus: roger22:40
mordredinaugust.com even got one: https://opendev.org/inaugust/inaugust.com/commit/6b49bac1ae320565ca3704d95cb6cd8262ba921722:41
fungiwoo!22:41
mordredI find that unreasonably exciting :)22:41
*** slittle1 has joined #openstack-infra22:41
corvusmordred: of course, you somehow tricked fungi into maintaining your website22:41
mordredcorvus: yes I did22:41
mordredcorvus: I consider 2019 a success now22:41
fungii'm telling you, "opendev sysadmins" will be the stackalytics stats envy of everyone22:41
clarkbls-projects works and its output looks coorect on a short skim to me22:41
fungiwell, of everyone who thinks stackalytics stats matter22:42
dtroyerfungi: especially now that it has been all fixed up…  will anyone believe it?22:42
*** Goneri has joined #openstack-infra22:42
fungitune in next week to find out22:42
clarkbnow down to 36k events22:43
corvuswe maybe could have gone ahead and dropped the git farm from the config...22:43
clarkboh right22:43
corvusnot sure if it's slowing us down or not22:43
mordredI stopped caring about stackalytics when I got beat out for the top committer by AJaeger and dhellmann22:43
corvusprobably not; the system doesn't have anything else to do22:43
corvus[2019-04-19 22:44:16,319] [d77c9ae5] Cannot replicate to git@github.com:openstack/activity-board.git22:44
mordredcorvus: weird. that repo exists22:45
corvusoh, did it git 'github archived'?22:45
mordredit doesn't appear to have been22:45
fungii don't think we've archived anything22:45
corvusthen hrm.22:46
clarkbis it possible they thottled us on that one?22:46
mordredgerrit isn't in its team22:46
clarkbor maybe the repo perms are wrong22:46
mordredteams22:46
clarkbya thats the thing22:46
clarkbmordred: are you fixing that?22:46
fungialso possible that repo has had broken/incomplete gerrit permissions on gh since it was created22:46
fungiyeah, that22:46
mordredclarkb: I'm not - I logged out already22:46
clarkbok I can fix it22:46
corvusi thought that was at org level?22:46
clarkbits both22:46
mordredcorvus: yeah - manage-projects adds gerrit to a team in the repo22:46
fungimaddening gh rbac once again22:47
mordredor somethign22:47
corvuswell, we've established nothing about the github rbac makes sense to me anyway.  so ... i'll do something else.22:47
mordredthe team exists in the org22:47
mordredthe team is granted write permission on the repo22:47
mordredthe gerrit user is in the team22:47
fungii'm looking forward to being able to care much less about gh in the very near future22:47
mordredyup22:48
corvusthirty four thousand eight-hundred eighty three bottles of beer on the wall...thirty four thousand eight-hundred eighty three bottles of beer....22:48
clarkbok I added the infra-core team as admin and the gerrit team as writer22:48
mordredcorvus: remind me never to play that game with you22:48
clarkbI expect that gerrit will be happy with pushing to that repo in github on its next pass22:49
mordred"yay"22:49
corvusgitea images are pushed, but i think restarting them with gerrit replicating would be counter-productive22:49
mordredI agree22:49
mordredwe can restart it when we restart gerrit22:49
*** jamesmcarthur has quit IRC22:49
fungisounds great22:49
corvusso afaict, we're at "wait for 34464 tasks to complete"22:49
mordredoh - we can merge the review.opendev.org patch now22:49
mordredif anybody has the brain powder to do that with the firewall in place22:50
corvusmordred: brain powder sounds explosive22:50
* mordred is very low on powder22:50
clarkbit might be easiset to do it via ssh22:50
clarkbsince that doesn't need the openid login round trip[22:50
* fungi has jelly beans22:50
corvusyeah, though we'll need to add us to bootstrappers first22:51
corvusalso via ssh22:51
corvusi'm up for working that out unless someone else is eager to.22:51
clarkbgo for it22:51
mordredI do not feel smart enough to do that without breaking something22:51
mordredright now22:51
corvuson it then22:51
clarkbI think I need to get blood flowing a bit better than it currently is and am gonna walk around a bit22:51
*** diablo_rojo has quit IRC22:52
corvus$ ssh corvus@localhost -p29418 gerrit set-members --add corvus "'Project Bootstrappers'"22:53
corvusMembers added to group Project Bootstrappers: corvus@inaugust.com22:53
corvusone down22:53
fungithat's how i've done it in the past, yes22:53
corvusgerrit query doesn't work because of the out of date index i assume22:54
corvusmaybe i can still blind review22:54
corvusbut first, i have to remove mordred's wip22:54
mordredcorvus: piddle.22:55
corvus$ ssh corvus@localhost -p29418 gerrit set-reviewers -p opendev/system-config -r mordred 65350722:55
corvusfatal: passed project openstack-infra/system-config when creating ChangeNotes for 653507, but actual project is opendev/system-config22:55
corvuswe may need to do that reindex now22:56
mordredblerg22:56
mordredyeah. although actually...22:56
mordredcorvus: you already put the change in /opt/system-config22:56
*** jamesmcarthur has joined #openstack-infra22:56
corvusmordred: oh you just want me to force-push the commit?22:56
clarkbI think we can index the single change22:56
mordredwe don't actually have to land that patch before kicking - it's just project-config that needs to be replicated22:56
corvusmordred: well, gerrit isn't going to replicate it until it merges22:57
mordredwe don't need that patch replicated22:57
clarkbhttps://review.gerrithub.io/Documentation/cmd-index-changes.html22:57
mordredwe only need the fungi project-config patch replicated22:57
clarkbmordred: corvus ya thats a good point its the manage-projects metadata we need for puppet to do the right thing22:58
mordredso that kicking with the manually applied patch won't pull old project-config and run manage-projects on it22:58
clarkbif we've got the other change lined up to go we can run it from bridge as is22:58
corvusok.  i'll go circulate my blood then.  :)22:58
mordredhttps://opendev.org/opendev/project-config/commit/565357e66adc66867b6b4fbea2518622feea108422:58
mordredwrong project-config :)22:59
mordredopenstack/project-config not yet replicaed22:59
clarkbconfirmed I don't see it yet either22:59
corvusmind if i take a 15-20 minute break?22:59
corvuswe're at   32290 tasks22:59
clarkbcorvus: nope I think its gonna take at least that long to eat through the replication queue22:59
mordredgo for it22:59
fungicorvus: please take a break22:59
clarkbI'm going to keep walking in circles (it just started raining otherwise I'd lap the block)23:00
fungiit's a holiday for a lot of folks23:00
*** diablo_rojo has joined #openstack-infra23:03
clarkbat 30k ish now23:08
clarkbso this might take another 1.5 hours?23:08
mordredyeah.23:09
clarkbok since I've got nothing better to do apparently. After we do the steps listed above We should have an up and running gerrit at review.opendev.org. The step after that is to update zuul's config and restart it?23:10
clarkbI'm guessing once we have a zuul mostly working we might be in a decent spot to pause then check in on things in the morning23:10
mordredyeah. I thnik so23:11
*** jamesmcarthur has quit IRC23:11
mordredcorvus, clarkb: since it's going to be another 1.5 (or possibly 2 hours) for replication - maybe we _should_ start the reindex too23:11
mordredotherwise we're going to need to reindex post 2nd start - and zuul really can't land changes until the reindex is done23:12
*** mattw4 has quit IRC23:12
mordred(given the error we saw above when corvus tried to land a change in a project that had been renamed)23:12
clarkbthat may slow down the replication as they compete for io and cpu but the overall wall time might be less23:13
clarkbI'm not opposed to starting the reindexes now. Do we want to wait for corvus to get back before committing to that?23:15
clarkbone concern is if gerrit won't stop if it is reindexing23:15
clarkb(I don't know if that is the case)23:16
clarkbbashate and bugdaystats also failed against github. I am checking their permissions now23:16
corvusthe only reason i can think of to avoid doing the reindex now, is if we wanted to see if we happen to replicate the project-config repo soonish; then we could restart gerrit before completing the initial repliation run23:17
*** jamesmcarthur has joined #openstack-infra23:18
clarkbcorvus: oh that is an interesting idea since ya it will kick off replication again after23:18
mordredthat is an interesting idea23:18
clarkbzuul might not be super happy about that when it comes up23:18
clarkbbut that will correct itself in time23:18
mordredI think we can't start zuul until reindex is done23:18
corvusoh, hey, we can find out when project-config will be replicated; i'll look23:19
mordredwould it help anything to do an explicit "replicate openstack/projecr-config" ?23:19
fungiyeah, normally post-rename reindexing isn't time-sensitive because it only has incorrect indices cached for one or a handful of repos23:19
corvusmordred: i think it would go at the end of the queue23:19
corvusmordred: but maybe worth a try :)23:19
clarkbfungi: well and we doubled our target count23:19
corvusi'm pretty sure the ssh error just logged was me :)23:20
clarkbcorvus: mordred ya it goes to the end of the queue iirc23:20
mordredkk23:20
corvusitas 9540 tasks away from the present position23:20
clarkbI fixed bashate and bugday stats23:20
corvusactually, the first one is at 9540, the last is at 1006323:21
corvusso what's that?  something like an hour from now?23:22
clarkbya about an hour I think23:22
clarkbin the 17k absolute queue size range23:22
mordredclarkb: didnt' we rename bashate from openstack-dev ?23:24
corvuswe should also drop the k8s gitea replication target23:24
mordredcorvus: ++23:24
corvus(since we didn't do the renames there, we'll need to reset it)23:25
clarkbmordred: maybe? maybe we lose the member data on those moves?23:25
mordredclarkb: whatcha wanna bet that a repo org transfer .. yeah23:25
mordredclarkb: since teams are owned by orgs23:25
mordredyou can't move a team membership23:25
clarkbthinking out loud here I think we may want to update system-config to use https://opendev.org/openstack/project-config as project-config before we reenable ansible + puppet23:25
clarkbthat way we are always getting that straight from the source23:25
mordredso we should update dmsimard's script - or at least our implementation of it - to then do the "add gerrit team" thing23:25
clarkb++23:26
clarkber though in the general case we won't want that23:26
clarkbbecause it will be up to the new non us affiliated org to set it up how they want23:26
mordredeyah - actually - we donm't need to fix that23:26
mordredyeah23:26
mordredso it's actually 'correct' - just annoying for 31 of our repos23:26
corvuswe just need to go click a bunch of things now, huh?23:26
mordredyeah. I'm pretty sure we'll need to do this for everything in the repos-github.yaml file23:27
clarkblooking like it23:27
corvuswe could each take a few23:27
clarkbmordred: want to put them in an etherpad and we can claim some?23:27
mordredyeah - one sec23:27
corvussomeone will probably have to tell me what gear icons to click.  sorry.23:27
clarkbcorvus: et al you go to eg https://github.com/openstack/bugdaystats/settings/collaboration then click the add a team drop down then select infra core and gerrit23:28
clarkbmake infra core admin and gerrit write perms in the drop downs that appear in their rows23:28
mordredk. they're in there23:28
corvusclarkb: thank you23:28
mordredI need to go log in as openstackadmin again, right?23:28
*** jamesmcarthur has quit IRC23:28
clarkbmordred: if you've removed your account perms to that org ya23:29
*** diablo_rojo has quit IRC23:34
clarkbok I think the clicking is done23:35
mordredy'all's so much faster at clicking23:35
clarkb23.7k so about 6k from project-config23:36
corvusi have a dent in my finger from the trackpoint.23:36
mordredand we're at a rate of about 4 minute / k I think - so probably 20/25 minutes until project-config23:37
corvusi'll go take another 20m break23:37
mordredyeah. I'm going to go look for pants23:37
clarkbreminder of the current plan/todolist 1) fix git-review in project-config; 2) start gerrit; 3) no longer worried about merging this change 4) wait for replication; 4.5) manually update project-config on review.o.o and run jeepy manage-projects 5) kick 6) restart gerrit23:38
clarkbwe are at 4)23:38
mordredclarkb: when we kick - we probably also want to kick zuul23:38
mordredto get the updated main.yaml23:39
clarkbzuul isn't running23:39
fungiroadmap was helpful, thanks23:39
mordredkick the puppet23:39
clarkbbut ya we need to update the main.yaml and the configparser config23:39
mordredto roll ut the main.yaml23:39
mordredyeah23:39
clarkbso there is a different zuul change to apply that we don't have on /opt/system-config yet. (I think we should do them one at a time?)23:39
mordredah. kk. yeah23:39
clarkbmordred: its the stuff that says canonical name is opendev.org and connect to review.opendev.org23:40
mordredoh yeah.23:40
clarkbnow at 22.7k23:40
clarkbso about 4 minutes per 5k23:40
clarkbor an hour and a half so our estimates were pretty good I think. Though I think we are also saying we can stop worring about replication once projects.yaml replicates23:41
clarkbfor 5.5) we can edit the replication config before starting zuul again to remove the git0* and kubernetes gitea to speed that up23:41
fungithe surprised thread on openstack-discuss where people didn't realize gerrit was going to be offline? comedy gold23:43
* fungi can't count the number of times/places/ways we announced that, even on that very ml23:44
clarkbI was worried people were getting annoyed by it too23:44
*** nicolasbock has quit IRC23:45
clarkbalright I'm just counting beer bottles i mean repos that need replication again now23:46
clarkbI'm gonna do a few more laps of the living room23:46
*** yamamoto has joined #openstack-infra23:48
paladoxYour running around the living room?23:49
clarkbit is pouring rain outside and I need yo stretch muscles23:50
mordredclarkb: ++ 5.523:50
paladoxclarkb oh, didn't realise it was raining :)23:53
clarkbproject-config has replicated to some mirrors23:59
clarkbgitea07 git03 github and k8s gitea still queued23:59
*** jamesmcarthur has joined #openstack-infra23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!