Friday, 2018-08-10

*** mschuppert has joined #openstack-infra00:05
*** agopi has joined #openstack-infra00:26
*** dklyle has quit IRC00:32
*** dklyle has joined #openstack-infra00:32
*** markvoelker has quit IRC00:35
*** slagle has quit IRC00:36
*** mtreinish has quit IRC00:45
*** mtreinish has joined #openstack-infra00:46
*** mriedem has quit IRC00:52
*** jtomasek_ has quit IRC00:58
*** hongbin has joined #openstack-infra01:00
*** mtreinish has quit IRC01:06
*** pcrews has quit IRC01:06
*** mtreinish has joined #openstack-infra01:08
*** ijw has joined #openstack-infra01:10
*** jamesmcarthur has joined #openstack-infra01:10
*** slaweq has joined #openstack-infra01:11
*** jamesmcarthur has quit IRC01:12
*** jamesmcarthur has joined #openstack-infra01:12
openstackgerritIan Wienand proposed openstack-infra/zuul-jobs master: Add openafs-client role  https://review.openstack.org/58933401:15
openstackgerritIan Wienand proposed openstack-infra/zuul-jobs master: Add kerberos-client role  https://review.openstack.org/59059101:15
*** slaweq has quit IRC01:16
openstackgerritIan Wienand proposed openstack-infra/openstack-zuul-jobs master: Test OpenAFS client install  https://review.openstack.org/58933501:16
*** ijw has quit IRC01:17
*** zhurong has joined #openstack-infra01:22
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: fix job required-projects list  https://review.openstack.org/59059401:31
*** yamahata has quit IRC01:32
*** rosmaita has quit IRC01:33
*** jamesmcarthur has quit IRC01:33
*** mschuppert has quit IRC01:36
*** ijw has joined #openstack-infra01:38
*** studarus has quit IRC01:45
*** jamesmcarthur has joined #openstack-infra01:48
*** jamesmcarthur has quit IRC01:53
*** jamesmcarthur has joined #openstack-infra01:55
*** Bhujay has joined #openstack-infra01:57
*** jamesmcarthur has quit IRC02:00
*** jamesmcarthur has joined #openstack-infra02:01
*** ijw has quit IRC02:02
*** ijw has joined #openstack-infra02:03
*** ijw has quit IRC02:06
*** e0ne has joined #openstack-infra02:16
*** e0ne has quit IRC02:18
*** jamesmcarthur has quit IRC02:18
*** jamesmcarthur has joined #openstack-infra02:22
*** zhurong has quit IRC02:23
*** yamamoto has joined #openstack-infra02:31
*** jamesmcarthur has quit IRC02:43
openstackgerritMerged openstack-infra/zuul master: Fix wrong matched project template  https://review.openstack.org/58820102:47
*** jamesmcarthur has joined #openstack-infra02:47
*** psachin has joined #openstack-infra02:48
*** yamamoto has quit IRC02:54
*** jamesmcarthur has quit IRC03:04
*** armax has quit IRC03:07
*** jamesmcarthur has joined #openstack-infra03:09
*** ijw has joined #openstack-infra03:09
*** slaweq has joined #openstack-infra03:11
*** hoangcx has left #openstack-infra03:12
*** slaweq has quit IRC03:15
*** ijw has quit IRC03:16
openstackgerritIan Wienand proposed openstack-infra/zuul-jobs master: Add kerberos-client role  https://review.openstack.org/59059103:19
openstackgerritIan Wienand proposed openstack-infra/zuul-jobs master: Add openafs-client role  https://review.openstack.org/58933403:19
*** hongbin has quit IRC03:19
openstackgerritwu.chunyang proposed openstack-infra/puppet-apparmor master: fix tests_smoke link  https://review.openstack.org/59062103:21
*** jamesmcarthur has quit IRC03:26
*** rh-jelabarre has quit IRC03:28
*** jamesmcarthur has joined #openstack-infra03:30
openstackgerritIan Wienand proposed openstack-infra/project-config master: Remove legacy-install-afs-with-puppet role  https://review.openstack.org/59063603:43
*** udesale has joined #openstack-infra03:49
*** Bhujay has quit IRC03:51
*** ianychoi has joined #openstack-infra03:56
*** jamesmcarthur has quit IRC04:00
*** ykarel|away has joined #openstack-infra04:03
*** jamesmcarthur has joined #openstack-infra04:04
*** jamesmcarthur has quit IRC04:10
openstackgerritIan Wienand proposed openstack-infra/project-config master: Remove legacy-install-afs-with-puppet role  https://review.openstack.org/59063604:15
openstackgerritIan Wienand proposed openstack-infra/project-config master: Bump ansible for linters  https://review.openstack.org/59064104:15
*** jamesmcarthur has joined #openstack-infra04:17
*** jamesmcarthur has quit IRC04:22
*** jamesmcarthur has joined #openstack-infra04:25
*** janki has joined #openstack-infra04:25
openstackgerritIan Wienand proposed openstack-infra/project-config master: linters: Take a guess at the roles path  https://review.openstack.org/59064204:30
ianwtonyb/pabelanger/mordred: ^^ https://review.openstack.org/#/c/590636/ and it's chain of deps should remove the need for puppet installs on the wheel builders by installing kerberos and openafs via ansible.  should be useful for mirror servers under ansible too04:32
tonybianw: Thanks!  I'll look over them but I like where they're going ;P04:34
*** yamahata has joined #openstack-infra04:37
*** ykarel|away is now known as ykarel04:39
*** jamesmcarthur has quit IRC04:42
*** Bhujay has joined #openstack-infra04:43
*** yamamoto has joined #openstack-infra04:51
*** slaweq has joined #openstack-infra05:11
*** jamesmcarthur has joined #openstack-infra05:11
*** slaweq has quit IRC05:16
*** janki has quit IRC05:19
*** jamesmcarthur has quit IRC05:20
*** jamesmcarthur has joined #openstack-infra05:22
*** ykarel_ has joined #openstack-infra05:26
*** jamesmcarthur has quit IRC05:26
*** ykarel has quit IRC05:28
*** janki has joined #openstack-infra05:28
*** ykarel__ has joined #openstack-infra05:28
*** ykarel_ has quit IRC05:31
*** quiquell has joined #openstack-infra05:42
*** yamamoto has quit IRC05:42
*** yamamoto has joined #openstack-infra05:46
*** nicolasbock has joined #openstack-infra05:50
openstackgerritYumengBao proposed openstack-infra/project-config master: Switch to publish-openstack-docs-pti for cyborg  https://review.openstack.org/59065005:53
*** hwoarang has joined #openstack-infra05:56
*** mschuppert has joined #openstack-infra06:02
openstackgerritMerged openstack/diskimage-builder master: better handle existing keywords files/directories  https://review.openstack.org/57763306:07
*** Emine has quit IRC06:12
dmelladomorning! could anyone please check what's going on with  https://review.openstack.org/#/c/584377/06:15
dmellado?06:15
*** yamahata has quit IRC06:15
dmelladoit seems that zuul didn't pick it properly and got stuck when going into gate queue06:15
dmelladotonyb: ianw AJaeger anyone around? ;)06:16
tonybdmellado: I think it just needs a recheck06:16
dmelladooh, well I'll recheck it then I'll play the dictator and just +a+w it06:17
tonybthe chnage it 'Depends-On' was in the gate pipeline when it got it;s +W so at that time it wasn't valid to tranistion06:17
dmelladotonyb: ack, thanks!06:17
tonybdmellado: I could be wrong but that's what I see.06:17
tonybdmellado: Looks like you'll know in about an hour ... if it gies straint gtom check -> gate pipelines06:18
dmelladotonyb: yep06:18
* dmellado hitting recheck xD06:18
tonyb:)06:21
*** yamamoto has quit IRC06:23
*** ykarel_ has joined #openstack-infra06:23
*** yamamoto has joined #openstack-infra06:24
*** ykarel__ has quit IRC06:26
*** jtomasek has joined #openstack-infra06:32
*** yamamoto has quit IRC06:32
*** larainema has quit IRC06:38
*** janki has quit IRC06:41
*** pcaruana has joined #openstack-infra06:43
*** hwoarang has quit IRC06:45
*** hwoarang has joined #openstack-infra06:50
*** ccamacho has joined #openstack-infra06:50
*** apetrich has joined #openstack-infra06:55
AJaegerdmellado: indeed, those two do not share a queue - so you need to wait with +A until the first is merged. Adding another +A is all that was needed06:55
dmelladoAJaeger: yep, looks like it's on its way now, thanks!06:56
AJaegerdmellado: or a toggle of the +A (remove, add back)06:56
dmelladoAJaeger: heh, that's what I first tried06:56
*** ykarel__ has joined #openstack-infra06:56
AJaegerdmellado: too early ;)06:57
AJaegerdmellado: the other change was not merged when you did it06:57
*** ykarel_ has quit IRC06:59
*** quiquell has quit IRC07:00
*** ykarel__ is now known as ykarel07:01
*** quiquell has joined #openstack-infra07:01
*** egonzalez has joined #openstack-infra07:01
*** jpich has joined #openstack-infra07:02
*** amoralej|off is now known as amoralej07:02
egonzalezhi, ask.o.o is down07:03
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use new translation jobs templates  https://review.openstack.org/59066507:03
egonzaleznvm, it works now07:03
AJaegereumel8: ^07:03
eumel8got it07:04
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use new translation jobs templates  https://review.openstack.org/59066507:05
AJaegereumel8: more later, just wanted to get the ball rolling...07:05
*** slaweq has joined #openstack-infra07:05
*** slaweq has quit IRC07:06
*** evrardjp has joined #openstack-infra07:06
*** slaweq has joined #openstack-infra07:06
*** rcernin has quit IRC07:07
*** holser_ has joined #openstack-infra07:10
*** jaosorior has quit IRC07:15
eumel8yes,thx07:17
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add --check-config option to zuul scheduler  https://review.openstack.org/54216007:17
*** janki has joined #openstack-infra07:27
*** ijw has joined #openstack-infra07:31
*** ijw has quit IRC07:35
*** jamesmcarthur has joined #openstack-infra07:38
*** ijw has joined #openstack-infra07:41
*** ginopc has joined #openstack-infra07:41
*** jamesmcarthur has quit IRC07:42
*** ykarel is now known as ykarel|lunch07:43
*** ijw has quit IRC07:45
*** ijw has joined #openstack-infra07:46
*** udesale has quit IRC07:51
*** udesale has joined #openstack-infra07:51
*** jpena|off is now known as jpena07:55
*** e0ne has joined #openstack-infra07:59
*** ijw has quit IRC08:08
*** ijw has joined #openstack-infra08:09
*** psachin has quit IRC08:13
*** priteau has joined #openstack-infra08:14
*** Bhujay has quit IRC08:23
*** psachin has joined #openstack-infra08:27
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix stuck job caused by exception during repo update  https://review.openstack.org/59069708:27
*** ijw has quit IRC08:28
*** janki has quit IRC08:32
*** derekh has joined #openstack-infra08:33
*** janki has joined #openstack-infra08:43
*** ykarel|lunch is now known as ykarel08:45
*** e0ne has quit IRC08:49
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use new translation jobs templates  https://review.openstack.org/59066508:52
*** xarses_ has quit IRC08:52
*** ssbarnea has quit IRC08:52
openstackgerritMatthieu Huin proposed openstack-infra/nodepool master: Do not abort node launch if failed node cannot be deleted  https://review.openstack.org/58985408:59
witekhello, could someone please help me on https://review.openstack.org/590387 ?09:02
witekI tried to follow https://git.openstack.org/cgit/openstack/goal-tools/tree/README.rst09:02
witekbut Zuul was misconfigured for stable branches on monasca-api prior to that09:03
*** gfidente has joined #openstack-infra09:04
witekPython 3 support was added in Rocky and enabling openstack-python35-jobs template blocked stable branches09:05
openstackgerritMerged openstack-infra/irc-meetings master: Update the nova team meeting chair to melwitt  https://review.openstack.org/59042709:06
AJaegerwitek: best wait until dhellmann is around...09:09
witekok09:09
AJaegerwitek: he's US based09:09
*** e0ne has joined #openstack-infra09:14
*** pbourke has quit IRC09:16
*** Dobroslaw has joined #openstack-infra09:17
*** pbourke has joined #openstack-infra09:18
*** e0ne has quit IRC09:27
*** Bhujay has joined #openstack-infra09:31
*** ssbarnea has joined #openstack-infra09:31
*** e0ne has joined #openstack-infra09:37
*** rkukura_ has joined #openstack-infra09:46
*** rkukura has quit IRC09:46
*** rkukura_ is now known as rkukura09:46
*** jaosorior has joined #openstack-infra09:48
*** roman_g has quit IRC10:13
*** roman_g has joined #openstack-infra10:13
*** tosky has joined #openstack-infra10:19
*** e0ne has quit IRC10:21
*** ykarel_ has joined #openstack-infra10:28
*** ykarel__ has joined #openstack-infra10:30
*** ykarel has quit IRC10:30
*** ykarel_ has quit IRC10:33
*** panda|ruck|off is now known as panda|ruck10:33
*** tosky has quit IRC10:35
*** tosky has joined #openstack-infra10:36
*** udesale has quit IRC10:36
*** udesale has joined #openstack-infra10:47
*** dave-mccowan has joined #openstack-infra10:55
*** rpittau has quit IRC11:00
*** dave-mccowan has quit IRC11:00
*** dtantsur|afk is now known as dtantsur11:01
*** jpena is now known as jpena|lunch11:06
*** holser_ has quit IRC11:18
*** nicolasbock has quit IRC11:19
*** rh-jelabarre has joined #openstack-infra11:26
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Split base playbook into two plays  https://review.openstack.org/59047811:26
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Remove old inactive users  https://review.openstack.org/58855311:32
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Remove old inactive users  https://review.openstack.org/58855311:37
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Set mgmt_hieradata variable for bridge.openstack.org  https://review.openstack.org/58862711:37
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996411:37
mordredcmurphy: I think https://review.openstack.org/#/c/588326/ is solid now - it has been properly running the ansible (and it has been failing because of ansible issues)11:37
cmurphymordred: coolbeans11:40
*** udesale has quit IRC11:41
*** udesale has joined #openstack-infra11:42
*** ykarel_ has joined #openstack-infra11:50
*** ykarel__ has quit IRC11:53
mordredcmurphy: also, as you might can tell - having that in place is super helpful :)11:55
*** boden has joined #openstack-infra11:56
cmurphy:)11:57
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add system-config to roles path  https://review.openstack.org/59075211:58
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Move roles into roles dir  https://review.openstack.org/59075311:58
mordredcmurphy: I haz ? ... in setup_host, there is a "host.add_env_var" call - does that add that as an env var to all subsequent on host calls?12:01
*** jpena|lunch is now known as jpena12:02
*** jaosorior has quit IRC12:03
*** mriedem has joined #openstack-infra12:05
cmurphymordred: it adds the variable to .ssh/environment which i believe has that effect yes12:07
mordredcmurphy: cool12:07
openstackgerritMonty Taylor proposed openstack-infra/puppet-openstack_infra_spec_helper master: Add roles dir in system-config to roles path  https://review.openstack.org/59075512:09
mordredcmurphy: so that ^^ should work?12:09
*** gary_perkins has quit IRC12:10
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Move roles into roles dir  https://review.openstack.org/59075312:10
cmurphymordred: read the comment on line 24 - beaker keeps the ssh connection open which means changes in the environment won't take effect until you reinitialize the connection12:11
mordredoh!12:11
cmurphyi would probably suggest adding both vars within the setup_host function12:11
mordredyah. I agree12:12
mordredcmurphy: is host.ssh_permit_user_environment needed for the add_env_var thing to work?12:13
AJaegerconfig-core, could you review https://review.openstack.org/589372 - and https://review.openstack.org/590665 (will need recheck once the first one is in), please? The first check will make changes for translations at release time much easier for us...12:14
openstackgerritMonty Taylor proposed openstack-infra/puppet-openstack_infra_spec_helper master: Add roles dir in system-config to roles path  https://review.openstack.org/59075512:14
cmurphymordred: yes, it makes a change to /etc/ssh/sshd_config in order to allow it12:14
mordredcmurphy: so maybe like that then12:14
cmurphymordred: yeah that looks right12:16
*** mriedem has quit IRC12:17
*** kgiusti has joined #openstack-infra12:20
mordred\o/12:20
*** quiquell has quit IRC12:20
*** rpittau has joined #openstack-infra12:23
pabelangerdmsimard: mind a +3 on https://review.openstack.org/590577/ blocking the removal of fedora-27 images in nodepool12:25
*** ansmith has joined #openstack-infra12:26
*** ykarel_ is now known as ykarel12:27
*** amoralej is now known as amoralej|lunch12:28
*** udesale has quit IRC12:34
*** janki has quit IRC12:35
*** holser_ has joined #openstack-infra12:35
*** psachin has quit IRC12:39
*** holser_ has quit IRC12:41
*** trown|outtypewww is now known as trown12:41
*** holser_ has joined #openstack-infra12:41
*** tpsilva has joined #openstack-infra12:44
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix permanently broken git cache  https://review.openstack.org/59076112:45
*** jamesmcarthur has joined #openstack-infra12:47
*** jamesmcarthur has quit IRC12:51
*** witek has quit IRC12:52
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix permanently broken git cache  https://review.openstack.org/59076112:54
*** jcoufal has joined #openstack-infra12:55
*** jamesmcarthur has joined #openstack-infra12:56
*** egonzalez has quit IRC13:03
bodenhi, I'm having some complications publishing a release for the vmware-nsx unofficial projects using the publish-to-pypi template; it appears my tag is being renamed... For example I pushed a signed tag of 13.0.0.0 to vmware-nsx, but it results in 2018.0.0.0rc2.dev48 being published to pypi13:03
bodenthe job log http://logs.openstack.org/e3/e300f9e7ad2d334adc8afad38c943d8ee76ec4ca/release/release-openstack-python/8cddd6a/job-output.txt.gz for https://pypi.org/project/vmware-nsx/#history13:04
bodenany ideas what I'm doing wrong here?13:04
*** rosmaita has joined #openstack-infra13:05
fungiboden: for starters, 13.0.0.0 isn't valid semver, you have one .0 too many13:06
bodenfungi: if I use 13.0.0 the dist created has three 0s... also that format seems to match what neutron is doing https://pypi.org/project/neutron/#history13:07
fungiboden: but also, looks like pbr might be finding a 2018.0.0.0rc2 tag and considering that the newest13:07
bodenfungi: can I delete a signed tag?13:07
fungiboden: what neutron is doing where?13:08
bodenfungi https://pypi.org/project/neutron/#history  has 13.0.0.0rc1   that's three 0s13:08
fungitag deletion is unreliable since it only propagates over push and not over pull13:08
bodenfungi: hmm, ok so I'm now unsure how to resolve if I can't delete the tag13:09
fungi13.0.0.0rc1 is what comes before 13.0.0 per pep 440 normalizaton rules13:09
bodenfungi: ok I was mislead by what's on pypi... any suggestions on how to proceed?13:10
fungiyeah, the usual advice about testing locally and being sure before you push a tag isn't much help afterward13:11
bodenfungi I did test locally, but frankly the process wasn't clear to me.. I thought everything was in order13:11
fungiinfra-root: opinions on trying to delete the vmware-nsx 2018.0.0.0rc2 tag? do we anticipate that sticking around on zuul mergers?13:12
fungiboden: testing insofar as `python setup.py sdisd bdist_wheel` and then looking at the resulting filenames that creates in the dist/ subdir?13:13
bodenfungi yes13:13
fungis/sdisd/sdist/13:13
fungiand it didn't create them with 2018.0.0.0rc2 in the filenames? interesting13:13
*** jamesmcarthur has quit IRC13:14
*** eharney has joined #openstack-infra13:14
bodenfungi this is my first time though this process and was using mainly https://docs.openstack.org/infra/manual/creators.html#tagging-a-release   there isn't much info there on such details, but in any case I think I just need to figure out how to proceed13:14
fungii need to spend a few minutes taking a closer look at the repo and the job logs to see if there might be a simpler solution13:16
bodenfungi I have similar problems with the other vmware-nsx projects too.. or maybe I'm just confused13:16
fungimordred: you may also have a slightly better grasp of pbr behaviors in this situation ^13:17
fungiboden: was your intent for this upcoming release to be 2018.0.0 or 13.0.0? if you're following neutron as an example, it stopped using year-based versions in 201513:18
boden13.0.013:19
mordredfungi: reading13:20
fungiyeah, looking at earlier tags in vmware-nsx you had like 12.0.0.0rc1 followed by 12.0.0 which is what we usually expect13:20
fungii have a feeling pbr is merely ignoring the malformed 13.0.0.0 tag and that if we just tag 13.0.0 it'll work13:22
fungiwithout trying to delete any tags13:22
fungibut running tox on the vmware-nsx repo is taking a few minutes13:22
mordredok. just tag again with 13.0.013:23
*** amoralej|lunch is now known as amoralej13:23
mordredand it'll fix it13:23
bodenfungi I can try... just hoping to not munk things up more.... sorry for this, I just didn't see such details noted in the docs.13:23
fungiahh, so pbr does indeed ignore tags with an extra (non-semver) 0?13:23
mordredyes13:23
* mordred has verified the behavior locally13:23
fungiboden: well, the tagging a release document is generic for all sorts of projects, and you're specifically fighting pbr behaviors/expectations here13:24
bodenunderstood, I didn't realize the can of worm lurking here :(13:24
mordredfungi: we should maybe make tagging a relase more explicit13:24
fungiso the information which would have helped you in this case would have come from reading the pbr docs13:24
fungimordred: yeah, like a sentence or two mentioning and linking to things like pbr documentatin?13:25
mordredyeah13:25
mordred"there are specific requirements on tag format, etc ... please see"13:25
bodenIMHO if there was a little mroe info/links on https://docs.openstack.org/infra/manual/creators.html#tagging-a-release  in regards to versioning I think that would help... also it might be nice to note that users should test locally; for newbies like myself13:26
*** dmsimard has quit IRC13:26
fungiyep, though also how you test is going to be very language/ecosystem-specific too13:27
fungifor testing javascript artifacts build correctly you'd need completely different instructions than python13:27
fungii suppose we can simply say that, and leave figuring out how to test a local tag as an exercise for the reader, assuming they're competent in whatever language ecosystem they're programming13:28
bodenor WARNING: signed tags can't be deleted, make sure you know what the heck you're doing :)13:29
fungiboden: but yeah, i also confirmed that checking out your 13.0.0.0 tag and building an sdist and a wheel i get 2018.0.0.0rc2.dev48 but after tagging the same commit with 13.0.0 it works as expected13:30
mordredyah - I think we don't need to delete those tags13:30
*** dpawlik has quit IRC13:30
mordredthey cease doing anything once a 13.0.0 signed tag is in place13:30
mordredthey might look unclean - but such is life13:30
*** dmsimard has joined #openstack-infra13:31
*** dansmith is now known as SteelyDan13:31
*** jamesmcarthur has joined #openstack-infra13:32
fungiboden: oh, also, you were looking at the document on initial project creation, not the one for project maintainers pushing releases on existing projects. you probably wanted https://docs.openstack.org/infra/manual/drivers.html#tagging-a-release13:32
fungithe project creator's guide is merely intended as a walkthrough of the steps involved in starting a new project from scratch13:33
fungiwhich does include a note about pbr's semver+pep440 version formatting13:34
*** efried is now known as fried_rice13:35
fungithough it is still lacking a warning about our inability to delete unwanted tags effectively, or a recommendation to locally test release artifact generation13:35
*** holser_ has quit IRC13:35
fungier, i should say, the tagging section in the driver's guide does include a note about pbr's semver+pep440 version formatting13:36
fungi(what i linked to)13:36
*** holser_ has joined #openstack-infra13:36
fungiwhile what you said you were following was the creator's guide which is a walkthrough for starting new projects13:36
bodenfungi: ack, def my fault... I didn't see the latter link you sent until now13:39
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047813:39
*** ykarel is now known as ykarel|away13:41
bodenfungi: so I had thought the branch creation was done afterwards via gerrit https://review.openstack.org/#/admin/projects/openstack/vmware-nsx,branches   but appears from the doc you sent that's not the case... assuming I get the signed tag can I just create and push the branch after-the-fact?13:43
*** larainema has joined #openstack-infra13:43
*** jistr is now known as jistr|call13:46
bodenotherwise I guess I can just bump it up to version 14.0.0 + push again including the branch13:52
mordredboden: you can make the branch after the tag for sure13:54
mordredin fact, you can give the tag as the ref to create the branch from13:55
bodenmordred would just just do that via git CLI? git checkout stable/rocky && git push gerrit 13.0.013:55
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: Rework translation templates  https://review.openstack.org/58937213:56
AJaegerfrickler: thanks for review, I fixed the typo everywhere ^13:56
AJaegerany other config-cores for review, please? ^13:56
*** ykarel|away has quit IRC13:58
*** jistr|call is now known as jistr14:00
fungiboden: i think you want `git push gerrit 13.0.0:stable/rocky` to create a stable/rocky branch from your 13.0.0 tag, but someone else should double-check me on that syntax14:00
*** apetrich has quit IRC14:00
*** hongbin_ has joined #openstack-infra14:03
fricklerAJaeger: ah, I didn't notice that it was in the original templates already14:04
smcginnisAny idea why a releasenotes job would get a MODULE FAILURE on "Synchronize files to AFS"?14:04
smcginnishttp://logs.openstack.org/5b/5b98bd8a702a8502ce7cb832c74b6a3ee05a33ed/tag/publish-openstack-releasenotes/ef70a94/job-output.txt.gz#_2018-08-10_03_21_54_36389714:04
smcginnisI thought we've seen that MODULE FAILURE message before when there was a typo in the ansible bits.14:05
fricklersmcginnis: http://logs.openstack.org/5b/5b98bd8a702a8502ce7cb832c74b6a3ee05a33ed/tag/publish-openstack-releasenotes/ef70a94/ara-report/result/8ebe070d-650d-461c-bbdc-99bb002790a1/14:05
fricklernot sure about the root cause for that error, though14:06
smcginnisOh right, I forgot the ARA part would show more details. Thanks frickler.14:06
AJaegerfrickler: a pasto - but still good to fix ;)14:06
smcginnisThat looks like the issue we saw the other day with possible overlapping rsync operations. Wasn't that what we thought it was dhellmann?14:07
fricklerthat would at least sound plausible to me14:07
dhellmannsmcginnis : that's what that error has been in the past, but I thought the new zuul changes to only run one of those jobs at a time was supposed to eliminate that14:08
smcginnisThis would be two cases where we've seen that not to be the case.14:08
smcginnisSo there may be something else going on.14:08
fungiunless the same job is being run for multiple projects but publishing into a common root14:08
smcginnisI guess they all would go to /afs/.openstack.org/docs/releasenotes/14:09
smcginnisThen a project specific subdirectory under that root.14:10
*** e0ne has joined #openstack-infra14:11
fungi: rename "/afs/.openstack.org/docs/releasenotes/sahara/_static/.jquery.js.TqhjvC" -> "_static/jquery.js": No such file or directory (2)14:11
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047814:12
fungii don't think there should be two jobs fighting over files in /afs/.openstack.org/docs/releasenotes/sahara/_static/14:12
fungithat looks fairly project-specific14:12
smcginnisLooks like the only failure is publishing the release notes. Should we just re-enqueue that one?14:13
*** eharney has quit IRC14:13
fungihard to tell whether it's complaining because .jquery.js.TqhjvC is missing or _static/ is missing14:13
smcginnisSomething else is missing here, so we should keep an eye on these failures. But they do seem to be transient at least.14:13
smcginnisfungi: Right, I wasn't sure which it meant either.14:14
fungii don't think we should reenqueue that one since it's a tag ref and presumably already successfully uploaded to pypi14:14
fungiso will fail if we try to reenqueue14:14
smcginnisOh? The only thing it showed as part of the failed jobs was the run of publish-openstack-releasenotes. Isn't this the post-tagging job?14:15
bodenfungi any idea if I can just use gerrit web https://review.openstack.org/#/admin/projects/openstack/vmware-nsx,branches and just create branch name "stable/rocky" and use the 13.0.0 revision number for the "Initial REvision" of the branch?  I'm tempted to try, but don't want to munk anything up14:16
fungismcginnis: it was in "pipeline: tag" per http://logs.openstack.org/5b/5b98bd8a702a8502ce7cb832c74b6a3ee05a33ed/tag/publish-openstack-releasenotes/ef70a94/zuul-info/inventory.yaml (though you can also currently see the pipeline name as part of the log url path)14:17
fungiboden: i think the acl for create ref may not also cover the gerrit webui, but i honestly don't remember. if it lets you, that's perfectly safe14:18
smcginnisfungi: Ah, thanks.14:18
fungiboden: you can definitely put the tag in the revision field there, yes14:18
bodenfungi: the tag (e.g. "13.0.0") or the revision number for it ("8076937814554a5ad1df148e7ddf34a336990e86")14:19
boden?14:19
fungithe tag works fine there14:19
bodenok thanks.. fingers crossed14:19
fungidoesn't have to be a git object sha14:19
fungismcginnis: dhellmann: also as far as the recent changes which help avoid contention over publication jobs with the supercedent pipeline manager, that's for things running in the post pipeline, not the tag pipeline14:20
dhellmannoh, hrm14:21
dhellmannI wonder if we should set that pipeline up the same way14:21
dhellmannalthough I don't know why 2 things would be publishing release notes to the same project at the same time14:21
fungiwell, that wouldn't help if that's what this is14:21
smcginnisAt least that explains it.14:21
fungiit's not like you're pushing two tags for the same project at the same time14:22
dhellmannright14:22
dhellmannI mean, we might, but that's not likely to be what happened here14:22
dhellmannwe do sometimes approve 2 tags on different branches14:22
fungibut also the supercedent pipeline manager works by deduplicating multiple queue items14:23
fungiwhich i don't think you'd want for releases14:23
fungiaccording to the traceback, rsync was copying from /var/lib/zuul/builds/ef70a94325ff4891a1e325e3d566839b/work/artifacts/ on the executor to /afs/.openstack.org/docs/releasenotes/sahara/14:25
mordredyeah - we DEFINITELY don't want supercedent for release pipeline14:25
mordredsince the job/queue-item is "publish-openstack-releasenotes"14:25
fungiis it possible some other different job was also writing to /afs/.openstack.org/docs/releasenotes/sahara/ at the same time?14:26
corvusfungi: if we delete a tag, i expect it to remain on the mergers, so we would want to delete it from all 19 of them (and the git mirrors, etc)14:26
fungicorvus: yeah, i expected that since zuul v2 did the same14:26
mordredcorvus: ++ ... I believe we figured out we do not need to delete it14:26
fungithanks for confirming14:26
*** eharney has joined #openstack-infra14:26
corvusmordred: thanks... that was my next question.  :)  i thought i'd go ahead and answer anyway since it seemed important14:27
corvusinfra-root: i just +3d https://review.openstack.org/590755  but i want to bring it to your attention as a subtle point about how testing ansible will work.  it seems like it could be important information to have in the back of your mind when debugging in the future.14:35
openstackgerritJavier Peña proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937614:36
openstackgerritJavier Peña proposed openstack-infra/puppet-openstackci master: Add AFS mirror support for RHEL/CentOS  https://review.openstack.org/52873914:36
mordredcorvus: now if only I could get https://review.openstack.org/#/c/590478 to pass tests on centos ...14:36
*** e0ne has quit IRC14:39
fungiwhat's the upshot of adding the roles dir in system-config to the roles path? just that we can refer to those roles in the jobs?14:40
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047814:40
corvusfungi: i think it makes the integration test configuration match the production configuration on bridge14:40
mordredyup14:41
mordredalso14:41
fungineat, that sounds useful14:41
mordredit's a stepping stone to ... https://review.openstack.org/#/c/590753/ - and would allow us to put the afs/krb roles ianw has been working on into there and use them for our test jobs AND in production14:41
mordredso - yes, what you said14:41
*** rpioso|afk is now known as rpioso14:41
*** bobh has joined #openstack-infra14:43
*** ccamacho has quit IRC14:47
openstackgerritMerged openstack-infra/puppet-openstack_infra_spec_helper master: Run ansible base playbook for puppet tests  https://review.openstack.org/58832614:47
openstackgerritMerged openstack-infra/puppet-openstack_infra_spec_helper master: Add roles dir in system-config to roles path  https://review.openstack.org/59075514:47
openstackgerritMerged openstack-infra/zuul master: web: fix job required-projects list  https://review.openstack.org/59059414:47
*** bobh has quit IRC14:49
clarkbfungi: catcing up on tag deletion is plan to delete 2018* and 13* tags?14:51
mordredclarkb: nope14:51
mordredclarkb: no need to delete14:51
clarkbmordred: just superceding them with new tags or?14:52
mordredclarkb: adding the correct tag fixes the issue14:52
mordredyup14:52
clarkbneat14:52
fungiyeah, pushing a new correct tag was all they needed in the end14:52
dhellmannregarding that rsync error in the sahara release notes job, https://review.openstack.org/#/c/590619/ was approved a few hours ago and would also have triggered a release notes build, so that may have been the source of the second job that caused the race condition14:56
fungiaha, so yes it's possible we want to move release notes publication to release-post or something?14:57
fungirather that doing it from the tag pipeline14:57
dhellmannmaybe? it isn't always a release thing, but it might be worth doing that just to serialize them14:57
*** hamzy_ is now known as hamzy14:57
fungior even just to the regular post pipeline. somewhere with the supercedent manager14:58
clarkbI think we decided its mostly a non issue too right? maybe we can filter that as a failure condition?14:59
clarkbor scope the rsync to unique tmp dirs?14:59
*** Bhujay has quit IRC14:59
*** Bhujay has joined #openstack-infra15:00
dhellmannI'd be fine with moving the job into a pipeline that uses the supercedent manager. Does it matter which one? The job does run sometimes just when a regular patch merges.15:00
fungiyeah i don't think the job running when a regular patch merges would be impacted by that, since it's already happening from another pipeline but maybe having them be the same pipeline would help (so regular post?)15:01
dhellmannhmm15:02
fungimmm, though the ref-updated event in that case would be the one for the releases repo15:02
funginot for the individual projects15:02
dhellmannthe pipeline doesn't have anything to do with what triggers the job, right? it's just how it's queued up to run?15:02
fungibasically we have an idempotent publication task we want to take advantage of supercedent pipeline manager behavior, but triggered from a tag push event15:03
*** tosky has quit IRC15:03
*** e0ne has joined #openstack-infra15:03
fungithe tag, pre-release and release pipelines are triggered by a ref-updated event with a ref pattern match of ^refs/tags/something15:04
openstackgerritJavier Peña proposed openstack-infra/puppet-openstackci master: Add AFS mirror support  https://review.openstack.org/52937615:05
fungithe post pipeline is triggered by a ref-updated event matching ^refs/heads/something15:05
*** dpawlik has joined #openstack-infra15:05
dhellmannso it sounds like we need it in both pipelines15:06
fungiwell, i think we have it in post and tag pipelines currently15:06
dhellmannyes, we do15:06
fungipost covers when changes merge to change the release notes, tag covers when tags are pushed adjusting what versions exist15:06
dhellmannand we need it to run when something is tagged and we need it to run when changes to notes files are merged15:06
dhellmannright15:06
dhellmannhence my question about whether the pipeline was tied to the trigger15:07
dhellmannI couldn't remember if that was defined in the job or the pipeline15:07
openstackgerritJavier Peña proposed openstack-infra/puppet-openstackci master: Add AFS mirror support for RHEL/CentOS  https://review.openstack.org/52873915:07
fungiit's almost like we want a different pipeline entirely which uses the supercedent pipeline manager and triggers on all ref-updated events regardless of ref pattern15:07
fungicorvus: ^ you might find this an interesting puzzle15:08
dhellmannthe way we built the release notes was special. I think I got too clever.15:08
fungii don't think it's all that special15:08
dhellmannthe other thing that is special about it is that it always checks out master to run the build, regardless of the commit that actually triggered the job15:09
fungiwe also have projects which want to update their documentation both when changes merge (to update branch tip content which documents the next release) and on tags (so that version numbers can be corrected in published docs)15:09
*** dpawlik has quit IRC15:09
dhellmannah, true15:09
fungiwe've sort of punted i the past and told projects to do one or the other15:10
fungifor various logistical reasons15:10
dhellmannso if we create an "any-ref" pipeline as you describe we could put the release notes job into it but we could also put the doc jobs into it15:10
*** e0ne has quit IRC15:10
fungibut i think the use case is still a valid one15:10
fungipotentially. that's what i'm brainstorming at least15:11
dhellmannI like it.15:11
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047815:11
mordredcorvus, fungi, clarkb: ^^ the most recent change to that makes me want to consider making bindep files instead of dealing with package lists in ansible variables15:12
mordredI don't think it's urgent right now - but I think it might be easier to maintain long-term15:12
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add nodepool info to test-emit-job-header  https://review.openstack.org/55794715:15
clarkbmordred: fwiw I'm kind of amazed that puppet and ansible and friends don't all have a bindep like thing to solve this problem15:16
clarkbI guess most shops are single distro15:16
clarkband now with containers you just encode it into a dockerfile15:16
clarkbmordred: re https://review.openstack.org/#/c/590478/9/playbooks/roles/base-server/tasks/main.yaml what does the paths: 'vars' do there?15:18
clarkbis that a magical input to the first found lookup?15:20
corvusfungi: yeah, i think if you want something to run on post and tag and be assured not to run simultaneously, a supercedent any is what you need -- except, i think supercedent collapses items by project-branch, which could cause you to end up with different queues for something that entered via refs/heads and something that entered via refs/tags.  so we may need a variant of supercedent which15:22
corvuscollapses by project only.15:22
corvusdhellmann: ^15:22
*** hwoarang has quit IRC15:23
corvusclarkb: yes, "paths" is a parameter to the first_found lookup15:23
corvusclarkb: means "look in these paths"15:23
fungicorvus: great point. it's not even currently safe in post since the job publishes to the same paths regardless of the branch which triggered it15:25
fungiso i agree, a project-supercedent pipeline manager implementation in zuul would be required if we want that15:26
fungicould we achieve something similar with a mutex?15:27
* fungi can't remember if zuul has support for a project+job mutex or if it's only explicitly by job15:28
corvusfungi: yeah, but you'd have to make a mutex for each project (or otherwise share a global mutex)15:28
corvusfungi: well, mutexes are global singletons -- then you attach them to jobs.  you could do that at the job definition (so all such jobs and their descendents use that single mutex), or at the project-pipeline level (so only that project's run of the job uses it)15:29
aspiersare there any docs on use of publish-openstack-sphinx-docs? I'm probably looking in the wrong places15:29
corvusproject-collapsing supercedent still sounds like the winner :)15:30
*** mriedem has joined #openstack-infra15:30
aspiersI'd like to start publishing the likes of http://logs.openstack.org/06/590406/7/check/build-openstack-sphinx-docs/8b8ade4/html/ on docs.openstack.org, if that's appropriate15:31
fungiyeah, seems like it would be complicated to apply project-specific mutexes to all the projects since they're getting the job from a template15:31
corvusaspiers: https://docs.openstack.org/infra/openstack-zuul-jobs/project-templates.html#project_template-build-openstack-sphinx-docs15:31
AJaegeraspiers: if you have an official repo, just use it ;)15:32
aspierscorvus: thanks!15:32
aspiersAJaeger: I'm guessing self-healing-sig is official by virtue of being a SIG, but I'm not 100% sure15:33
AJaegeraspiers: it is - listed in governance repo under reference/sigs-repos.yaml15:33
fungiaspiers: make sure you list that repo in the sigs repos list (i think reference/sigs-repos.yaml in openstack/governance is the right place)15:34
AJaegerfungi: he did ^15:34
aspiersyes, I know it's there - just not sure what that means from a governance perspective15:34
fungijust a means of tracking15:35
AJaegeraspiers: it's a repo of an official project/SIG - and only official ones can use docs.o.o15:35
aspiersso I can just change the .zuul.yaml from build-openstack-sphinx-docs to publish-openstack-sphinx-docs?15:35
fungii still wonder whether that info should move to the sigs.yaml in openstack/governance-sigs at some point15:35
AJaegeraspiers: yes, just do it15:35
aspiersok thanks15:35
AJaegeraspiers: and afterwards sent a change to openstack-manuals/www/... to add to index file. That is covered in the docs contributor guide15:35
aspiersgot it!15:36
AJaegerI mean: after you published content - we only link to content thta exists ;)15:36
aspierssure :)15:36
corvusAJaeger: maybe we should link the project-template doc to the contributor guide?15:36
*** Bhujay has quit IRC15:36
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047815:36
*** Bhujay has joined #openstack-infra15:37
*** rajinir has joined #openstack-infra15:37
corvusmordred: that sounds like a great idea ^  :)15:37
AJaegercorvus: so, link to https://docs.openstack.org/doc-contrib-guide/doc-index.html ?15:37
corvusAJaeger: yeah?  that way someone who finds all this by way of the project-template can get there?15:38
mordredcorvus: bah. working tests are so legacy15:38
* AJaeger works on a quick change...15:38
AJaegerconfig-core, could you review https://review.openstack.org/589372 - and https://review.openstack.org/590665 (will need recheck once the first one is in), please? The first check will make changes for translations at release time much easier for us...15:38
mordredcorvus: in cloud native, everything just magically works even if it's broken15:38
mordredcorvus: at least as long as you don't touch files in any way15:39
corvusmordred: is npm cloud native?  because i've never been able to run "npm build" two days in a row and have it work without having to reinstall everything.15:41
mordredcorvus: it must be!15:41
clarkbcorvus: mordred: nodeenv was my solution for that15:42
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: enhance publish-openstack-sphinx-docs description  https://review.openstack.org/59080815:42
AJaegercorvus, aspiers ^15:42
clarkbthen I just make a new one15:42
openstackgerritJeremy Stanley proposed openstack-infra/infra-manual master: Clarify inability to delete tags  https://review.openstack.org/59080915:44
fungiboden: would that ^ have helped?15:44
mordredclarkb, corvus: I mean, actually I haven't had that problem because yarn has the yarn.lock file ... so I was mostly taking the corvus comment as snark. if that's an actual problem I'd love to learn more about it15:44
openstackgerritJeremy Stanley proposed openstack-infra/infra-manual master: Clarify inability to delete tags  https://review.openstack.org/59080915:45
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add nodepool info to test-emit-job-header  https://review.openstack.org/55794715:46
clarkbmordred: I've not tried things with lock files but that would likely help. The problems tend to be unpinned deps that are incompatible with either other libraries or older node15:46
*** yamahata has joined #openstack-infra15:46
clarkbmordred: so you build a new one which gets you newer node and newer other libs15:47
mordredoh - yeah - using yarn to install there isn't really unpinned deps anymore15:48
*** rpittau has quit IRC15:48
mordredbut that's easier for zuul-web where we control it - and harder for etherpad-lite15:48
mordredclarkb: oh wow. I just looked at the etherpad-lite repo15:49
mordredI will not make that mistake again15:49
*** sthussey has joined #openstack-infra15:49
aspiersAJaeger: is https://docs.openstack.org/infra/manual/creators.html#add-links-to-your-project-documentation a poor duplicate of https://docs.openstack.org/doc-contrib-guide/doc-index.html ?15:51
aspiersperhaps the former should just redirect to the latter?15:51
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add nodepool info to test-emit-job-header  https://review.openstack.org/55794715:51
AJaegeraspiers: it should link to the same page15:53
AJaegeraspiers: and it does, both link to the same page...15:53
*** ginopc has quit IRC15:56
aspiersAJaeger: yes but they contain different info15:56
aspiershttps://docs.openstack.org/doc-contrib-guide/doc-index.html has a lot more info15:56
AJaegeraspiers: both link to the same page for the template. But if you want to align them more, please send a change. Happy to review!15:57
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Add nodepool info to test-emit-job-header  https://review.openstack.org/55794715:57
aspiersit just generally feels wrong to have two sections in two manuals covering the same topic15:57
aspiersthat's a DRY violation just waiting for someone to modify one place but not the other15:58
aspiersit's not so much about the current disparity as the potential for endless divergence15:58
openstackgerritAkihiro Motoki proposed openstack-infra/project-config master: Update horizon grafana  https://review.openstack.org/59081316:03
* fungi is gonna go grab some lunch, back soon16:03
mordredclarkb: do we have any hosts, other than puppetmaster, that are still trusty?16:07
clarkbmordred: yes, quite a few actually :/ floating in the back of my head is the need to rebuild them but wanting to be slushy for release means now is not greatest time16:07
mordred++16:08
mordredkk. so fighting through my trusty gate issues is worthwhile16:08
clarkbmordred: likely16:08
*** fried_rice is now known as fried_rolls16:08
clarkbI'm thinking post PTG we can plan to work through those again16:08
clarkb(sorting out the config mgmt stuff first at ptg and otherwise seems useful as we may do conversions of config management too)16:09
clarkbmordred: we got through quite a few service last winter. Then ran up agains tthose that needed work. The upside to cmurphy's puppet 4 stuff is that we get testing on xenial so the config management issues at least are being worked out16:12
clarkbreview.o.o and review-dev.o.o are also done leaving us with things like lists and ask and similar as the likely "difficult" nodes16:13
clarkbhosts like nodepool.o.o can hopefully be deleted in favor of new zk cluster, etherpad and similar srevices just needed the puppet updates I think16:14
*** Bhujay has quit IRC16:15
aspiershrm http://zuul.openstack.org/stream.html?uuid=1a2c0b80c3e34b5bb0f62a7342038660&logfile=console.log16:16
aspiers"msg": "SSH Error: data could not be sent to remote host \"147.75.38.184\". Make sure this host can be reached over ssh"16:17
aspiersIIRC it's retrying now16:17
clarkbaspiers: if that happens in the pre-run playbook it should retry on a newly scheduled instance16:17
clarkbthat looks like a packethost IP which I thought John tracked back to a bad hypervisor which was being replaced16:18
aspiersclarkb: thanks. watching to see if the retry succeeds16:19
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047816:21
*** kei-ichi has quit IRC16:22
*** jpena is now known as jpena|off16:22
*** mriedem has quit IRC16:27
mordredclarkb: ++16:27
*** fabo has quit IRC16:31
aspiersclarkb: it finished ok, although I'm not sure where the resulting docs are published to16:34
aspiershttps://docs.openstack.org/self-healing-sig/ is still 40416:34
clarkbaspiers: have a link to the job logs?16:35
aspiershttp://logs.openstack.org/71/71871b9922c135fcd9c0ce68712c118fea044e4f/post/publish-openstack-sphinx-docs/3abb7df/ara-report/16:35
*** jpich has quit IRC16:35
*** armax has joined #openstack-infra16:35
clarkbwe publish to afs which is on a 5 minute publish cycle iirc16:35
clarkbwhich should've happened about a minute ago16:36
aspiersahah16:36
clarkbyup docs are there now16:36
aspiersyup!16:36
aspiersawesome :)16:36
clarkbmordred: speaking of fun upgrades ^ afs will be a dance. The good news is we can do that without downtime assuming no unforeseen circumstances16:37
corvusmumble mumble in place manual upgrade mumble16:38
mordredclarkb: also - ianw has the afs/krb modules - so we might not be far-off from getting the afs servers to just be pure-ansible16:38
mordreds/modules/roles/16:38
openstackgerritMerged openstack-infra/zuul master: Cache branches in connections/sources  https://review.openstack.org/58997516:39
*** diablo_rojo has joined #openstack-infra16:41
clarkbinfra-root the stack at https://review.openstack.org/#/c/590023/ updates puppetry for etherpad, if we get that stuff in I will work on an upgrade for etherpad-dev16:42
*** holser_ has quit IRC16:43
clarkb(may as well keep picking them off as we can)16:43
mordredclarkb: done16:44
*** panda|ruck is now known as panda|ruck|off16:48
*** rmcall has quit IRC16:50
pabelangerclarkb: did john say anything about stuck deleting nodes? Wonder if we need to have an admin set the state again to something besides deleting16:51
pabelangerfor packethost16:51
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Tolerate missing project  https://review.openstack.org/57987216:52
clarkbpabelanger: he was looking at why they were unhappy. That was the neutron file limit problem I think16:56
openstackgerritClark Boylan proposed openstack-infra/system-config master: Add digit support to etherpad servers  https://review.openstack.org/59101716:59
clarkbnow does that change conflict with anyone else's changes to show me someone else was already working on that and I should revie wtheir stuff instead16:59
*** derekh has quit IRC17:01
*** dtantsur is now known as dtantsur|afk17:01
clarkbwhile I wait for etherpad stuff to merge, it looks like ethercalc may be in an upgradeable spot already. It isn't a heavily used service, any objection to me trying to spin up a new 02 instance on xenial for it?17:03
*** jamesmcarthur has quit IRC17:03
*** jamesmcarthur has joined #openstack-infra17:04
clarkbmordred: ^ and I'm going to spin that up from puppetmaster right?17:05
clarkbmordred: or should I run launch node from bridge at this point?17:05
*** jcoufal has quit IRC17:06
mordredclarkb: that's a great question - I think from puppetmaster is a better choice - although hang on one sec17:07
mordredclarkb: ok. it should just work17:08
mordredthe one thing to keep an eye out for is make_swap, which now calls python3 explicitly17:08
clarkbmordred: it being using bridge for launch node for puppet nodes?17:09
mordredbut I think python3 is already installed on xenial, so it should still work- if not, we might need to make that smarter17:09
mordredclarkb: oh - sorry, run launch_node.py from puppetmaster17:09
*** trown is now known as trown|lunch17:09
mordredwe haven't tested running puppet on nodes from bridge yet (hopefully very soon, but we havne't done it yet)17:09
clarkboh hrm https://review.openstack.org/#/c/527144/ never merged and the noop tests don't cover the things it fixes17:10
clarkbI guess I need to work on reviews first17:10
*** e0ne has joined #openstack-infra17:11
*** jamesmcarthur has quit IRC17:11
mordredzomg17:12
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047817:12
mordredclarkb: you're going to enjoy the diff between PS11 and PS12 there ^^ :)17:13
clarkbmordred: ha17:17
bodenwe recently updated our tempest project to publish to https://pypi.org/project/vmware-nsx-tempest-plugin/ instead of https://pypi.org/project/vmware-nsx-tempest/ as this matches our project setup/pkgs.. is there someway to delete the old https://pypi.org/project/vmware-nsx-tempest/ PYPI project as its not used and adds confusion17:18
bodenthe person who created/owns https://pypi.org/project/vmware-nsx-tempest/ is no long reachable, but this proj has openstackci as a maintainer17:19
*** gyee has joined #openstack-infra17:21
clarkbboden: generally, I think its considered bad manners to fully delete things from pypi because then anyone depending on that would be sad17:22
*** gfidente has quit IRC17:22
clarkbboden: would it make sense to push a release that maybe points at the new location as a dependency and also updates the readme docs for the old one to point at new one?17:22
*** jamesmcarthur has joined #openstack-infra17:22
clarkbmordred: ^ how has sdk/shade/etc handled this sort of thing17:22
clarkbas a heads up I'm approving the ethercalc series of changes17:23
mordredlike that17:23
bodenclarkb as far as I know no one is depending on it, but its possible I suppose... I can push a release with new location if needed17:23
mordredclarkb: it's also how we did the quantum/neutron migration17:23
*** jcoufal has joined #openstack-infra17:24
mordredwe made a release of python-quantumclient that just had a dependency on python-neutronclient17:24
clarkbfrickler: ianw cmurphy I notice though that other people have been thinking about this far more than me. I will defer on booting a new instance if someone else intended on doing that, but will work to get the stack merged and check the existing instance is still happy after for today17:24
mordredclarkb: ++17:24
*** yamahata has quit IRC17:25
*** eharney_ has joined #openstack-infra17:30
*** eharney has quit IRC17:33
*** amoralej is now known as amoralej|off17:34
*** jamesmcarthur has quit IRC17:36
*** jcoufal has quit IRC17:39
*** jamesmcarthur has joined #openstack-infra17:42
AJaegercorvus, config-core, can we merge https://review.openstack.org/#/c/557946/1 now? Not sure why we did not merge it last time...17:43
AJaegerI see https://review.openstack.org/#/c/557947/7 on top of it just approved...17:43
pabelangerI'm ready for testing, it will allow us to first do https://review.openstack.org/557948/17:44
pabelangerbut also can wait unitl next week17:44
clarkbcmurphy: can you check the comment on https://review.openstack.org/#/c/585292/3 I wnat to make sure I didn't misparse that17:45
AJaegerconfig-core, could you review https://review.openstack.org/589372 - and https://review.openstack.org/590665 (will need recheck once the first one is in), please? The first check will make changes for translations at release time much easier for us...17:46
*** jamesmcarthur has quit IRC17:47
clarkbAJaeger: I'll take a look once through the ethercalc stack17:47
*** jamesmcarthur has joined #openstack-infra17:47
AJaegerclarkb: thanks17:47
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: enhance publish-openstack-sphinx-docs description  https://review.openstack.org/59080817:49
mordredinfra-root: I need to AFK for a little bit to go pick up some scuba tanks17:49
clarkbmordred: watch your toes17:49
clarkbcmurphy: also comment on https://review.openstack.org/#/c/590489/117:50
*** priteau has quit IRC17:52
*** xarses_ has joined #openstack-infra17:53
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: Remove double docs job  https://review.openstack.org/59102617:54
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Move openstack-zuul-jobs completely in-repo  https://review.openstack.org/59102717:55
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: Remove double docs job  https://review.openstack.org/59102617:55
AJaegerconfig-core, we run an extra docs jobs on openstack-zuul-jobs, the two changes above clean this up ^17:56
AJaegerclarkb: thanks for reviewing the translation changes17:57
clarkbAJaeger: no problem17:57
*** yamahata has joined #openstack-infra17:58
AJaegercorvus, pabelanger:I'll go ahead with https://review.openstack.org/#/c/557946 now17:58
openstackgerritMerged openstack-infra/project-config master: Update horizon grafana  https://review.openstack.org/59081317:58
*** yamahata has quit IRC18:02
*** xarses_ has quit IRC18:03
*** yamahata has joined #openstack-infra18:03
openstackgerritMerged openstack-infra/openstack-zuul-jobs master: Rework translation templates  https://review.openstack.org/58937218:08
*** ianychoi has quit IRC18:10
*** ianychoi has joined #openstack-infra18:11
* fungi returns to discover that he should have decided to take the afternoon for diving18:12
mordredfungi: that's always the right choice18:13
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Remove old inactive users  https://review.openstack.org/58855318:13
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Set mgmt_hieradata variable for bridge.openstack.org  https://review.openstack.org/58862718:13
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996418:14
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add system-config to roles path  https://review.openstack.org/59075218:14
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Move roles into roles dir  https://review.openstack.org/59075318:14
mordredinfra-root: ok that ^^ is finally green (or at least the first patch is)18:15
mordredthey should all be safe to land up until the lsat one which I marked WIP18:15
*** trown|lunch is now known as trown18:15
mordredI will NOW go AFK to pick up scuba tanks, whilst being careful of my toes :)18:15
fungiinstead i went to a beach bar and had a dolphin sandwich that was listed on the menu as mahi-mahi (rage rage)18:15
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use translations-jobs-master-stable  https://review.openstack.org/59103218:16
fungithe atlantic ocean has no such fish as mahi-mahi. we have dolphin18:16
openstackgerritMerged openstack-infra/zuul-jobs master: Add test-emit-job-header roles  https://review.openstack.org/55794618:16
* fungi swears at tourists some more18:16
openstackgerritMerged openstack-infra/zuul-jobs master: Add nodepool info to test-emit-job-header  https://review.openstack.org/55794718:16
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use translations-jobs-master-stable  https://review.openstack.org/59103218:18
AJaegerdhellmann: could you review https://review.openstack.org/590666 , please? The dependency is in now...18:23
openstackgerritMerged openstack-infra/project-config master: Use new translation jobs templates  https://review.openstack.org/59066518:24
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use translation-jobs-master-only  https://review.openstack.org/59103318:24
dhellmannAJaeger : thanks18:24
dhellmannapproved18:24
AJaegerthanks!18:24
dhellmannAJaeger : did you see my comment on that monasca patch?18:24
AJaegerdhellmann: I see that 588842 (the olso jobs) has a merge conflict. Do you mind if I push the translation job change in and then rebase the oslo job on top?18:25
dhellmannAJaeger : please go right ahead18:25
dhellmannAJaeger : I proposed an approach for https://review.openstack.org/#/c/590387/ to unblock them for now. Let me know what you think.18:26
AJaegerdhellmann: yes, I did; thanks. I was this morning in a hurry and couldn't dig into monasca, just thought they do something really odd...18:26
AJaegerchecking...18:26
dhellmannoh, that's the monasca patch, in case you didn't have the link handy18:26
AJaegerdhellmann: yep, read it.18:26
dhellmannis that approach ok with you?18:27
AJaegerdhellmann: yes, it is. commented18:28
*** apetrich has joined #openstack-infra18:29
dhellmanngreat, thanks for pulling me in on that one18:30
* AJaeger thanks dhellmann18:30
*** roman_g has quit IRC18:32
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use translation-jobs-master-only  https://review.openstack.org/59103318:34
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: remove job settings for Oslo repositories  https://review.openstack.org/58884218:34
AJaegerdhellmann: wnat to WIP this ^ yourself again - or shall I?18:35
dhellmannon it18:35
AJaegerthanks18:35
AJaegerconfig-core, could you review https://review.openstack.org/#/c/591032 and https://review.openstack.org/#/c/591033, please? I like to get these quickly in to avoid conflicts and rebases18:37
pabelangerinfra-root: maybe sometime next week we could either consider deleting the /var/lib/zuul/executor-git directories on zuul-executors, so they are recloned with non 0777 permissions directories, or doing a mass chmod on them. In an effort to fix ansible warning in tox linter jobs:18:38
pabelanger[WARNING] Ansible is in a world writable directory (/home/zuul/src/git.openstack.org/openstack/ansible-role-nodepool), ignoring it as an ansible.cfg source.18:38
pabelangerhttp://logs.openstack.org/14/584614/17/check/tox-linters/c584cbe/job-output.txt.gz#_2018-07-28_02_15_24_873989 for more info18:39
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Use translation-jobs-master-only  https://review.openstack.org/59103318:39
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: remove job settings for Oslo repositories  https://review.openstack.org/58884218:39
fungipabelanger: sounds good. i could just mass-chmod them now if that's safe, but maybe friday during release candidate week is poor timing18:39
AJaegerdhellmann: sorry, found a problem and needed a rebase18:39
dhellmannAJaeger : got it18:40
* dhellmann goes afk for a bit18:40
pabelangerfungi: agree, after release week and non-friday :)18:40
pabelangererr, RC week18:40
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: enhance publish-openstack-sphinx-docs description  https://review.openstack.org/59080818:44
AJaegeraspiers, dhellmann, updated the descriptions for docs templates ^18:44
*** apetrich has quit IRC18:46
*** fried_rolls is now known as fried_rice18:47
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Setup missing translation jobs for neutron-lbaas-dashboard  https://review.openstack.org/59036418:48
*** diablo_rojo has quit IRC18:50
*** eharney_ is now known as eharney18:52
*** diablo_rojo has joined #openstack-infra18:54
dhellmannAJaeger : I wonder if we want to make that job fail if it can't find the repo name in the list in the governance repo19:02
dhellmannmaybe that's too pedantic19:03
dhellmannlet's wait and see if it's a problem19:03
AJaegerconfig-core, could you review https://review.openstack.org/#/c/591032 , https://review.openstack.org/#/c/591033 and https://review.openstack.org/590364, please? I like to get these quickly in to avoid conflicts and rebases19:03
AJaegerdhellmann: let's wait...19:04
dhellmannyeah19:04
clarkbinfra-root can we get reviews on https://review.openstack.org/#/c/590478/12 to fix our config management tests? All the puppe tthings I tried approving have failed on the fixes there19:08
clarkbAJaeger: I'm looking at your list of changes now19:08
AJaegerthanks, clarkb - and have a great weekend. I'm off now...19:09
fungienjoy your weekend, AJaeger!19:09
*** jamesmcarthur has quit IRC19:18
*** pcaruana has quit IRC19:19
*** dpawlik has joined #openstack-infra19:20
*** kaiokmo has quit IRC19:22
*** dpawlik has quit IRC19:24
*** kaiokmo has joined #openstack-infra19:24
*** kaiokmo has quit IRC19:25
openstackgerritTim Burke proposed openstack-infra/project-config master: Drop legacy-swift*-dsvm-functional-identity-v3-only jobs  https://review.openstack.org/59106419:27
*** diablo_rojo has quit IRC19:28
openstackgerritMerged openstack-infra/system-config master: Make integration tests works  https://review.openstack.org/59047819:30
*** jamesmcarthur has joined #openstack-infra19:33
*** jamesmcarthur has quit IRC19:35
*** sthussey has quit IRC19:39
*** jamesmcarthur has joined #openstack-infra19:40
*** eharney has quit IRC19:45
*** priteau has joined #openstack-infra19:47
*** e0ne has quit IRC19:51
*** xe1gyq has quit IRC19:55
*** eharney has joined #openstack-infra19:57
*** jamesmcarthur has quit IRC19:58
mordredclarkb, corvus, fungi, pabelanger: can I interest you in a nice shiny https://review.openstack.org/#/c/588553 ?19:58
clarkbI thought I had +2'd that when you asked about the comment the other day guess I didn't19:59
*** boden has quit IRC19:59
*** jamesmcarthur has joined #openstack-infra20:00
pabelanger+220:06
corvusmordred: wfm, thx20:06
mordredclarkb: oh - I had a thought about the puppet 4 parser thing and the new groups inventory on bridge ..20:06
mordredcorvus: \o/20:06
*** ansmith has quit IRC20:06
cmurphyclarkb: i'm gonna double check https://review.openstack.org/585292 tomorrow before beer but i'm pretty sure you're wrong20:08
mordredI'm not sure how to feel about that. neither cmurphy or clarkb are ever wrong20:09
clarkbcmurphy: damn20:09
cmurphymordred: i know it's confusing20:09
mordredcmurphy: I'm completely questioning reality now20:09
cmurphyi've had a couple beers though so clarkb has an edge20:09
openstackgerritColleen Murphy proposed openstack-infra/puppet-ethercalc master: Use versioncmp function  https://review.openstack.org/59048920:10
clarkbcmurphy: fwiw I always do get confused about what item is which when symlinks are involved20:10
clarkbI read `man ln` every time I use it20:10
cmurphyclarkb: same here20:10
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996420:10
mordredcorvus: if you have a sec ^^ I just updated that slightly20:10
cmurphyyou would kind of think a two letter command would be easier to use20:10
mordrednope20:11
clarkbcmurphy: but my specific concern here is that on existing server we have a dir with content already but we are replacing it with a symlink to the location that newer npm will install it to20:11
mordredtotally hard20:11
clarkbcmurphy: which doesn't exist yet20:11
clarkbbecause existing server uses old npm20:11
openstackgerritMerged openstack-infra/puppet-ethercalc master: Update ethercalc to work with Ubuntu Xenial  https://review.openstack.org/52714420:11
cmurphyhmmm yeah this is why nodejs is scary20:11
*** priteau has quit IRC20:12
*** diablo_rojo has joined #openstack-infra20:13
cmurphyclarkb: it's doing ln -s /opt/ethercalc/node_modules/ethercalc/node_modules/socialcalc /opt/ethercalc/node_modules/socialcalc <- the second one doesn't exist according to your example so it should be safe to create that link20:15
fungifar from being the only reason nodejs is scary20:15
openstackgerritMerged openstack-infra/puppet-ethercalc master: Add basic rspec test  https://review.openstack.org/52782220:16
openstackgerritMerged openstack-infra/puppet-ethercalc master: Turn off binary symlink in nodejs module  https://review.openstack.org/58529120:16
clarkbcmurphy: if that is the case then puppet has reversed the name and target values according to man ln20:16
clarkbtarget = /opt/ethercalc/node_modules/socialcalc name = /opt/ethercalc/node_modules/ethercalc/node_modules/socialcalc according to the puppet I think20:16
clarkbwhich works if you have a new npm install but not if you have an old I think20:17
cmurphyclarkb: yeah looking at https://puppet.com/docs/puppet/5.5/types/file.html#file-attribute-target i think they did20:17
*** sthussey has joined #openstack-infra20:20
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Map file comment line numbers (alternate)  https://review.openstack.org/59044220:22
clarkbcmurphy: I think we may want `ln -s /opt/ethercalc/node_modules/ethercalc/node_modules/socialcalc /opt/ethercalc/node_modules/socialcalc` for old npm and `ln -s /opt/ethercalc/node_modules/socialcalc ules/ethercalc/node_modules/socialcalc` for new npm beacuse the dir npm installs to changes :/20:23
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Map file comment line numbers  https://review.openstack.org/59044220:23
clarkbcmurphy: we might be able to switch on the nodejs version to decide which we want to do20:23
cmurphyclarkb: what version is currently running?20:25
clarkbnpm --version is 2.15.1120:26
clarkbnode --version is v4.8.720:26
cmurphyhmm okay i guess xenial is 6.x so i guess that makes sense20:27
mordredyah. the upstream docker image is built using node:4.8 base image - so I'm guessing the upstream isn't doing much with 6.x yet20:31
mordredand thus the confusion with the paths20:31
clarkbmordred: https://review.openstack.org/#/c/527144/18 indicates 4.x doesn't work on newer ubuntu20:32
corvusi'd like to restart the zuul scheduler with the fix to the job api20:32
corvusthough...20:32
corvusmaybe we ought to wait a few more mins and see if the line mapping change is ready to go in too20:33
mordred++20:34
mordredcorvus: it'll make it easier to iterate on that patch20:34
mordredwhich - btw - I ahve realized I need to completely rewrite20:34
mordredpabelanger: hey - you know things about centos, right?20:37
clarkbpabelanger: quick run away20:37
mordredpabelanger: http://logs.openstack.org/64/589964/6/check/openstackci-beaker-centos-7/c9adc6a/job-output.txt.gz#_2018-08-10_20_23_29_60826020:37
mordredpabelanger: "No package matching 'exim' found available, installed or updated"20:37
mordredif I do a yum search for exim on git01.openstack.org it totally finds one20:37
clarkbmordred: is the package in epel? we disable epel by default on our test nodes iirc20:38
mordredah - yes, it is20:38
mordredso I need to make sure that the code to enable epel is running20:38
corvusclarkb: you know things about centos!20:38
mordredaha! we enable epel in install_puppet.sh - but not in any of our puppet20:39
mordredso I didn't translate it in to ansibles20:39
clarkbcorvus: I'll never admit to it20:39
mordredI has question20:40
mordredin install_puppet.sh, there is this note:20:40
mordred    # NOTE(pabelanger): In openstack-infra, we already have epel on20:40
mordred    # our nodes, properly configured for mirrors and gpg keys; thus20:40
mordred    # check to see if the package is installed first.20:40
mordredI assume that is talking about on build nodes20:41
corvusdo we have it installed but disabled?20:41
clarkbcorvus: yes that20:41
mordredhow do we have it installed?20:41
mordredsorry - first question - that is referring to build nodes and not infra control plane nodes, right?20:42
clarkbmordred: its a config file in /etc/yum.d/ iirc with the flag that says disabled set20:42
clarkbmordred: ya20:42
clarkbmordred: you can yum install --enable-repo epel with our config I think20:42
mordredcool. so for control plane nodes we _don't_ have it installed already, but then we run instlal_puppet.sh so we do have it installed20:42
mordredclarkb: well, not if I didn't run install_puppet.sh I can't20:42
corvus(the 'epel' element is in the nodepool config)20:43
clarkbright its gonna be different on the test nodes and our actual control plane nodes20:43
mordredawesome. I can work with that20:44
mordredwow. we have some important logic in that install_puppet.sh script :)20:44
corvusin case this needs clarification: if epel is installed (but disabled), "yum install --enable-repo epel" will install a package from epel (the --enable-repo means to temporarily enable a disabled repo just for that command)20:44
*** eharney has quit IRC20:46
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Map file comment line numbers  https://review.openstack.org/59044220:48
openstackgerritWitold Bedyk proposed openstack-infra/project-config master: Revert "Make monasca-api py35 job voting"  https://review.openstack.org/59108620:54
*** jamesmcarthur has quit IRC20:55
*** trown is now known as trown|outtypewww21:01
*** diablo_rojo has quit IRC21:02
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996421:03
mordredcorvus, clarkb: ^^ that adds the epel logic from install_puppet.sh - and the systemd restart logic - to base-repos role21:04
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996421:08
mordredsorry - realized we should put a trap on there so that we only restart systemd if we updated it21:08
clarkbcorvus: left a comment on the line mappings change (actually two but one is sort of hand wavy). Unfortunately unable to do a comprehensive review so far but figured you might address the testing -1's and catch my comment in the process21:09
*** jamesmcarthur has joined #openstack-infra21:09
pabelangermordred: clarkb: corvus: everything you said is correct about epel :)21:11
mordredpabelanger: yay!21:11
mordredpabelanger: wanna look at https://review.openstack.org/589964 and see if that looks right?21:11
pabelangersure21:12
corvusclarkb: responded21:15
corvusand yeah, i'm fixing up the test errors now21:15
openstackgerritMerged openstack-infra/system-config master: Remove old inactive users  https://review.openstack.org/58855321:16
openstackgerritMerged openstack-infra/system-config master: Set mgmt_hieradata variable for bridge.openstack.org  https://review.openstack.org/58862721:16
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Fix web content copying in multi dashboard job  https://review.openstack.org/59108921:17
clarkbcorvus: ah I just noticed that FETCH_HEAD is passed as ref where that function is called then we don't use ref at all and hard code FETCH_HEAD in the funcion21:17
pabelangermordred: +2, left comment / suggestion21:17
mordredpabelanger: yay! thanks21:18
corvusclarkb: oh, ha, i misunderstood.  will fix :)21:18
mordredpabelanger: do you know why you had the external repo thing in the install_puppet.sh then?21:18
pabelangermordred: I don't maybe from a time of centos6?21:19
mordredwow. fun21:19
mordredwell - that'll certainly make the file easier to deal with :)21:19
pabelangermordred: ianw might also know21:19
mordredpabelanger: ianw knows everything21:19
mordredpabelanger: I can confirm - yum install epel-release works without anything else in a centos docker21:20
pabelangeryah, pretty sure legacy for centos-6, looking at git blame21:21
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Map file comment line numbers  https://review.openstack.org/59044221:21
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996421:22
mordredpabelanger: ^^ there we go then21:22
pabelangermordred: original commit: http://git.openstack.org/cgit/openstack-infra/system-config/commit/?id=d45bddc133ddd07733e9d0db4ebc1891c1fd055821:23
pabelanger:)21:23
pabelanger+221:23
mordredpabelanger: that was so many years ago21:23
pabelangerindeed21:23
*** jamesmcarthur has quit IRC21:24
*** AhmadMahmoudi has joined #openstack-infra21:24
*** dave-mccowan has joined #openstack-infra21:26
openstackgerritFatema Khalid Sherif proposed openstack-infra/storyboard master: Exposing search for comments by substring  https://review.openstack.org/59109221:31
*** anticw has joined #openstack-infra21:41
anticwhi there, quick gerrit question ... is there some sort of 'bot' we can get to close/abanadon old patchsets over a certain date or with some other trigger?21:41
anticwi can do it manually but a bot doing it is less 'personal' so it often causes less offense21:41
fungianticw: closing people's proposed changes sounds pretty personal already21:46
clarkbanticw: we had one a while back but then gerrit grew the ability for us to delegate that to our users (all change owners and core reviewers should be able to do it)21:46
clarkbanticw: so we killed the bot in favor of individuals doing it when appropriate21:46
fungialso, gerrit has great features which allow you to just ignore old, stale reviews if that's your concern21:47
fungii have open reviews i've been waiting for projects to merge since 201521:47
fungi(no joke)21:48
fungii'm sure others in here have some even older than that21:48
anticwfungi: some are a year old, people have moved on ... the issues are likely stale21:48
anticwfungi: what's the syntax / query you use to ignore older stuff?21:49
fungiand close any bugs you've had open for a year. who knows if they're still valid, right? ;)21:49
fungianticw: after:YYYY-MM-DD21:49
fungior you can express it as age:Xy21:49
fungithe gerrit search documentation has a lot of detail21:50
anticwthanks, i looked at the docs a while ago trying to see if i could detect what's in merge conflict21:50
fungiit has that too, just a sec and i can find it21:50
fungihttps://review.openstack.org/Documentation/user-search.html#search-operators21:51
fungiis:mergeable21:51
anticwyeah, trying that now21:51
anticwthanks21:51
fungiwhich you can also invert21:51
anticwthat's what i did21:53
anticwdoesn't look like you can alter the sort order at present though21:54
fungiyeah, except maybe on the consumer end of the api21:55
fungifor example, gertty has several sorting toggles (by number, by last update, reverse...)21:56
fungibut it's basically providing those at the presentation layer21:57
fungii thought gerrit had sorting options in its webui, but i'm not finding them. maybe they dropped those before 2.1321:59
anticwi see others asking for it, perhaps a later Web UI might suck more into the dom and allow client-side-sorting as it quite common now22:01
*** yamamoto has joined #openstack-infra22:02
openstackgerritMonty Taylor proposed openstack-infra/system-config master: Add exim role to base playbook  https://review.openstack.org/58996422:13
*** dhill_ has quit IRC22:13
*** dave-mccowan has quit IRC22:19
fungi"later webui" is the polyglot-based total rewrite "polygerrit" interface i, 2.14 (or is it 2.15?) which we're not running yet22:25
fungianticw: ^22:25
fungifind it in action at https://gerrit-review.googlesource.com/22:27
*** jamesmcarthur has joined #openstack-infra22:37
openstackgerritFatema Khalid Sherif proposed openstack-infra/storyboard-webclient master: Expose ordering criteria in search UI  https://review.openstack.org/57787022:41
openstackgerritFatema Khalid Sherif proposed openstack-infra/storyboard-webclient master: Exposing task creator name in  search results  https://review.openstack.org/58308522:41
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Map file comment line numbers  https://review.openstack.org/59044222:42
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Fix race in test_crd_check_unknown  https://review.openstack.org/59110622:42
corvusi think the line mapping change is ready, but it hit a racy test (fix ^).  i think i'll just restart the scheduler with the job api fix for now.22:43
*** rpioso is now known as rpioso|afk22:44
corvusand, well, lots of other changes :)22:45
*** jamesmcarthur has quit IRC22:59
*** rosmaita has quit IRC22:59
*** hongbin_ has quit IRC23:00
corvusdhellmann, AJaeger, tristanC, mordred: progress!  http://zuul.openstack.org/api/job/devstack23:04
*** yamamoto has quit IRC23:05
*** elod has quit IRC23:15
*** elod has joined #openstack-infra23:22
*** yamamoto has joined #openstack-infra23:38
*** jamesmcarthur has joined #openstack-infra23:39
*** jamesmcarthur has quit IRC23:44
*** sthussey has quit IRC23:49
pabelangerclarkb: ianw: tonyb: corvus: do you mind adding https://review.openstack.org/590785/ and https://review.openstack.org/590769/ to your review pipeline, they are devstack changes to stable/queens for fedora-28. needed for barbican23:52
pabelangerthen we can remove fedora-27 from nodepool23:52
pabelangeralso Sigyn didn't like that ping23:53
pabelangerjust got a warning23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!