Friday, 2018-04-27

*** salv-orlando has joined #openstack-infra00:00
*** slaweq has joined #openstack-infra00:01
*** jamesmcarthur has quit IRC00:01
*** florianf has joined #openstack-infra00:01
*** rkukura has quit IRC00:04
*** mriedem has quit IRC00:05
*** slaweq has quit IRC00:06
*** salv-orlando has quit IRC00:06
*** s-shiono has joined #openstack-infra00:08
*** florianf has quit IRC00:08
*** rlandy has quit IRC00:08
*** s-shiono_ has joined #openstack-infra00:09
*** bobh has joined #openstack-infra00:11
*** s-shiono has quit IRC00:12
*** yamamoto has joined #openstack-infra00:12
*** sree has joined #openstack-infra00:15
*** yamamoto has quit IRC00:18
*** sree has quit IRC00:19
*** masuberu has joined #openstack-infra00:20
*** masber has quit IRC00:23
*** dhill_ has quit IRC00:29
*** sree has joined #openstack-infra00:33
*** eernst has joined #openstack-infra00:34
*** dhill_ has joined #openstack-infra00:36
*** sree has quit IRC00:38
*** jamesmcarthur has joined #openstack-infra00:43
*** masber has joined #openstack-infra00:46
*** masuberu has quit IRC00:49
*** hongbin_ has joined #openstack-infra00:49
*** eernst has quit IRC00:57
*** eernst has joined #openstack-infra00:57
*** VW has joined #openstack-infra00:58
*** psachin has joined #openstack-infra01:01
*** salv-orlando has joined #openstack-infra01:02
*** wolverineav has joined #openstack-infra01:02
*** sree has joined #openstack-infra01:04
*** bobh has quit IRC01:05
*** salv-orlando has quit IRC01:06
*** sree has quit IRC01:09
*** wolverineav has quit IRC01:10
*** zhangfei has joined #openstack-infra01:11
*** VW has quit IRC01:14
*** yamamoto has joined #openstack-infra01:14
*** VW has joined #openstack-infra01:15
*** dpawlik has joined #openstack-infra01:15
*** agopi|zzz has joined #openstack-infra01:19
*** VW has quit IRC01:19
*** yamamoto has quit IRC01:20
*** dpawlik has quit IRC01:20
*** bobh has joined #openstack-infra01:21
*** harlowja has quit IRC01:23
*** masuberu has joined #openstack-infra01:27
*** masber has quit IRC01:31
*** bobh has quit IRC01:34
*** jamesmcarthur has quit IRC01:36
*** sree has joined #openstack-infra01:41
*** felipemonteiro__ has joined #openstack-infra01:43
*** sree has quit IRC01:46
*** rosmaita has quit IRC01:46
*** caphrim007 has joined #openstack-infra01:47
*** felipemonteiro__ has quit IRC01:49
*** gmann_ is now known as gmann01:49
*** caphrim007 has quit IRC01:51
*** jcoufal has quit IRC01:51
*** masber has joined #openstack-infra01:54
*** bobh has joined #openstack-infra01:55
*** masuberu has quit IRC01:56
*** hamzy has joined #openstack-infra02:00
*** slaweq has joined #openstack-infra02:02
*** salv-orlando has joined #openstack-infra02:02
*** eernst has quit IRC02:06
openstackgerritGhanshyam Mann proposed openstack-dev/hacking master: Release notes for 1.1.0  https://review.openstack.org/56112902:06
*** slaweq has quit IRC02:06
*** salv-orlando has quit IRC02:07
*** yamamoto has joined #openstack-infra02:16
*** yamamoto has quit IRC02:18
*** aeng has joined #openstack-infra02:18
*** yamamoto has joined #openstack-infra02:18
*** dhajare has joined #openstack-infra02:19
anteayathree first nations art shows in bc whilst summit is happening for those interested: https://www.theglobeandmail.com/arts/art-and-architecture/article-three-history-making-exhibitions-of-indigenous-art-and-culture-open-in/02:21
*** dhajare has quit IRC02:25
openstackgerritGhanshyam Mann proposed openstack-dev/hacking master: Release notes for 1.1.0  https://review.openstack.org/56112902:26
*** hamzy has quit IRC02:29
*** jamesmcarthur has joined #openstack-infra02:32
*** dhajare has joined #openstack-infra02:32
*** eernst has joined #openstack-infra02:36
*** hamzy has joined #openstack-infra02:36
*** aeng_ has joined #openstack-infra02:40
*** aeng has quit IRC02:41
*** gongysh has joined #openstack-infra02:48
*** eernst has quit IRC02:51
*** bobh has quit IRC03:02
*** salv-orlando has joined #openstack-infra03:03
*** salv-orlando has quit IRC03:08
*** dhill_ has quit IRC03:13
*** dpawlik has joined #openstack-infra03:16
*** dpawlik has quit IRC03:20
*** VW has joined #openstack-infra03:21
*** rajinir has quit IRC03:21
*** VW has quit IRC03:29
*** VW has joined #openstack-infra03:29
*** nicolasbock has quit IRC03:32
*** dhill_ has joined #openstack-infra03:33
*** VW has quit IRC03:33
*** ykarel|away has joined #openstack-infra03:38
*** ramishra has joined #openstack-infra03:42
*** jamesmcarthur has quit IRC03:42
*** lpetrut has joined #openstack-infra03:45
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul master: Sometimes GitHub doesn't return repo permissions  https://review.openstack.org/56466603:54
*** sree has joined #openstack-infra03:57
*** ykarel|away has quit IRC03:57
*** shu-mutow has joined #openstack-infra03:57
*** sree has quit IRC04:01
*** slaweq has joined #openstack-infra04:03
*** eernst has joined #openstack-infra04:03
*** salv-orlando has joined #openstack-infra04:04
*** eernst has quit IRC04:06
*** jamesmcarthur has joined #openstack-infra04:06
*** dhill_ has quit IRC04:06
*** slaweq has quit IRC04:08
*** sree has joined #openstack-infra04:08
*** salv-orlando has quit IRC04:09
*** jamesmcarthur has quit IRC04:11
*** vivsoni has joined #openstack-infra04:11
*** hongbin_ has quit IRC04:13
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: mqtt: add basic reporter  https://review.openstack.org/53554304:13
*** dhill_ has joined #openstack-infra04:20
openstackgerritSangho Shin proposed openstack-infra/project-config master: Allows networking-onos-core group to create a new branch  https://review.openstack.org/56466904:24
*** lpetrut has quit IRC04:24
*** mpjetta has quit IRC04:29
*** gongysh has quit IRC04:33
*** auristor has quit IRC04:33
*** auristor has joined #openstack-infra04:35
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: mqtt: add basic reporter  https://review.openstack.org/53554304:40
*** janki has joined #openstack-infra04:43
*** janki has quit IRC04:44
*** janki has joined #openstack-infra04:45
*** dayou has quit IRC04:45
*** janki has quit IRC04:45
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul-jobs master: Make revoke-sudo work on base cloud-init images  https://review.openstack.org/56467404:45
*** janki has joined #openstack-infra04:46
*** ykarel|away has joined #openstack-infra04:47
*** ykarel|away is now known as ykarel04:48
*** Hunner has quit IRC04:51
*** dhill_ has quit IRC04:51
*** bmjen has quit IRC04:51
*** bmjen has joined #openstack-infra04:57
*** Hunner has joined #openstack-infra04:58
*** Hunner has quit IRC04:58
*** Hunner has joined #openstack-infra04:58
*** links has joined #openstack-infra05:04
*** VW has joined #openstack-infra05:04
*** armaan has joined #openstack-infra05:04
*** salv-orlando has joined #openstack-infra05:05
*** eernst has joined #openstack-infra05:06
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: mqtt: add basic reporter  https://review.openstack.org/53554305:06
*** dayou has joined #openstack-infra05:06
*** dhill_ has joined #openstack-infra05:07
*** salv-orlando has quit IRC05:07
*** salv-orlando has joined #openstack-infra05:07
*** links has quit IRC05:08
*** mpjetta has joined #openstack-infra05:10
*** jchhatbar has joined #openstack-infra05:11
*** janki has quit IRC05:13
*** links has joined #openstack-infra05:13
*** links has quit IRC05:13
*** lpetrut has joined #openstack-infra05:14
*** dpawlik has joined #openstack-infra05:17
*** eernst has quit IRC05:19
*** masuberu has joined #openstack-infra05:20
*** VW has quit IRC05:20
*** VW has joined #openstack-infra05:21
*** dpawlik has quit IRC05:22
*** masber has quit IRC05:24
*** mikal_ has joined #openstack-infra05:24
*** auristor has quit IRC05:25
*** pgadiya has joined #openstack-infra05:26
*** pgadiya has quit IRC05:26
*** VW has quit IRC05:26
*** mikal has quit IRC05:27
*** lpetrut has quit IRC05:31
*** quiquell|off is now known as quiquell|rover05:31
*** onovy has quit IRC05:32
*** auristor has joined #openstack-infra05:33
*** e0ne has joined #openstack-infra05:34
*** dhill_ has quit IRC05:37
*** aeng_ has quit IRC05:41
*** eumel8 has joined #openstack-infra05:42
*** armaan has quit IRC05:42
*** dhill_ has joined #openstack-infra05:43
*** agopi|zzz has quit IRC05:44
*** udesale_ has joined #openstack-infra05:44
*** udesale_ has quit IRC05:44
*** germs has quit IRC05:46
*** germs has joined #openstack-infra05:47
*** germs has quit IRC05:47
*** germs has joined #openstack-infra05:47
*** claudiub has joined #openstack-infra05:47
*** masber has joined #openstack-infra05:47
*** masuberu has quit IRC05:50
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation  https://review.openstack.org/53554105:52
*** scas has quit IRC05:55
*** scas has joined #openstack-infra05:55
*** Douhet has quit IRC05:57
*** armaan has joined #openstack-infra05:58
*** armaan has quit IRC05:58
*** Douhet has joined #openstack-infra05:58
*** armaan has joined #openstack-infra05:59
*** armaan has quit IRC06:04
*** armaan has joined #openstack-infra06:04
*** iranzo has joined #openstack-infra06:09
*** lpetrut has joined #openstack-infra06:14
openstackgerritSangho Shin proposed openstack-infra/project-config master: Allows networking-onos-core group to create a new branch  https://review.openstack.org/56468206:14
*** onovy has joined #openstack-infra06:14
*** andreas_s has joined #openstack-infra06:20
*** armaan has quit IRC06:21
*** armaan has joined #openstack-infra06:21
*** gongysh has joined #openstack-infra06:24
*** Douhet has quit IRC06:29
*** Douhet has joined #openstack-infra06:30
*** pcaruana has joined #openstack-infra06:33
*** nmathew has joined #openstack-infra06:42
*** nmathew has quit IRC06:43
*** quiquell|rover is now known as quique|rover|afk06:49
*** pcaruana has quit IRC06:50
*** alex_xu has quit IRC06:51
*** alex_xu has joined #openstack-infra06:52
*** slaweq has joined #openstack-infra06:52
openstackgerritMerged openstack-infra/project-config master: Change label for neutron-tempest-ovsfw to "voting"  https://review.openstack.org/56193006:58
*** yolanda__ is now known as yolanda06:59
*** pcaruana has joined #openstack-infra07:06
*** diablo_rojo has joined #openstack-infra07:08
*** hemna_ has quit IRC07:09
*** alexchadin has joined #openstack-infra07:11
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: builder: support setting diskimage env-vars in secure configuration  https://review.openstack.org/56468707:13
*** xinliang has quit IRC07:14
*** xinliang has joined #openstack-infra07:15
*** jtomasek has joined #openstack-infra07:15
*** ccamacho has quit IRC07:17
*** rcernin has quit IRC07:17
*** dpawlik has joined #openstack-infra07:18
*** ccamacho has joined #openstack-infra07:18
*** dpawlik has quit IRC07:21
*** jaosorior has joined #openstack-infra07:21
openstackgerritSangho Shin proposed openstack-infra/project-config master: Allows networking-onos-core group to create a new branch  https://review.openstack.org/56468207:22
*** dpawlik has joined #openstack-infra07:22
*** tesseract has joined #openstack-infra07:27
*** pcichy has joined #openstack-infra07:27
*** armaan has quit IRC07:35
*** armaan has joined #openstack-infra07:35
*** edmondsw has joined #openstack-infra07:36
*** kjackal has quit IRC07:40
*** pcichy has quit IRC07:40
*** quique|rover|afk is now known as quiquell|rover07:40
*** edmondsw has quit IRC07:41
*** ssbarnea_ has joined #openstack-infra07:45
amotokiAJaeger: could you confirm this is the right approach for stable/queens tox_install.sh failure? https://review.openstack.org/#/c/564534/07:46
*** ykarel is now known as ykarel|away07:47
*** hashar has joined #openstack-infra07:47
openstackgerritJens Harbott (frickler) proposed openstack-infra/openstack-zuul-jobs master: Fix nova hacking integration job  https://review.openstack.org/56469107:49
*** kjackal has joined #openstack-infra07:50
*** jpena|off is now known as jpena07:52
*** aojea has joined #openstack-infra07:52
*** armaan has quit IRC07:52
*** amoralej|off is now known as amoralej07:52
*** armaan has joined #openstack-infra07:53
*** tesseract has quit IRC07:53
AJaegeramotoki: that's one workaround for pip10 - yes07:54
amotokiAJaeger: thanks for checking it. This is the gate fix so I am merging it fast.07:55
*** tesseract has joined #openstack-infra07:56
*** lucas-afk is now known as lucasagomes07:58
*** jamesmcarthur has joined #openstack-infra08:07
*** tosky has joined #openstack-infra08:10
*** jamesmcarthur has quit IRC08:12
*** alexchadin has quit IRC08:14
*** jogo has quit IRC08:14
*** alexchadin has joined #openstack-infra08:15
*** s-shiono_ has quit IRC08:19
openstackgerritMatthieu Huin proposed openstack-infra/nodepool master: Add separate modules for management commands  https://review.openstack.org/53630308:28
*** cuongnv has joined #openstack-infra08:35
*** cuongnv is now known as Guest8921108:36
openstackgerritMatthieu Huin proposed openstack-infra/nodepool master: Add separate modules for management commands  https://review.openstack.org/53630308:37
*** Guest89211 has quit IRC08:38
*** cuongnv_ has joined #openstack-infra08:38
*** mandre is now known as mandre_afk08:39
*** derekh has joined #openstack-infra08:40
*** shardy has joined #openstack-infra08:41
*** alexchadin has quit IRC08:42
*** shardy has quit IRC08:42
*** shardy has joined #openstack-infra08:42
*** zhangfei has quit IRC08:53
*** dtantsur|afk is now known as dtantsur08:55
*** pcaruana has quit IRC08:56
*** florianf has joined #openstack-infra08:57
*** zhangfei has joined #openstack-infra09:05
*** shardy has quit IRC09:07
*** pcaruana has joined #openstack-infra09:07
*** viks has quit IRC09:11
*** jogo has joined #openstack-infra09:11
*** cuongnv_ has quit IRC09:18
openstackgerritAndreas Jaeger proposed openstack-dev/hacking master: Import integration test  https://review.openstack.org/54776509:19
*** florianf has quit IRC09:21
*** stakeda has quit IRC09:21
*** panda|ruck|off is now known as panda|ruck09:21
openstackgerritShu Muto proposed openstack-infra/project-config master: Add horizon into required-projects for nodejs jobs for magnum-ui  https://review.openstack.org/56471109:23
*** zoli is now known as zoli|lunch09:29
openstackgerritMerged openstack-infra/project-config master: ignore the series_status.yaml when processing release requests  https://review.openstack.org/56434209:41
*** gfidente has joined #openstack-infra09:42
*** gfidente has joined #openstack-infra09:42
*** annp has quit IRC09:44
*** xinliang3 has quit IRC09:47
*** xinliang3 has joined #openstack-infra09:48
*** ansiwen[q] has quit IRC09:48
*** diablo_rojo has quit IRC09:51
*** pcichy has joined #openstack-infra09:59
*** shu-mutow has quit IRC10:03
*** alexchadin has joined #openstack-infra10:04
*** shardy has joined #openstack-infra10:06
*** shardy has quit IRC10:06
*** e0ne has quit IRC10:07
*** shardy has joined #openstack-infra10:08
*** rpittau has quit IRC10:08
*** dtantsur is now known as dtantsur|brb10:13
*** alexchadin has quit IRC10:14
*** l4yerffej has quit IRC10:15
*** l4yerffej has joined #openstack-infra10:17
*** alexchadin has joined #openstack-infra10:19
*** apetrich has quit IRC10:19
*** kjackal has quit IRC10:19
*** sree has quit IRC10:19
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900410:23
*** rpittau has joined #openstack-infra10:23
*** CrayZee has joined #openstack-infra10:27
*** kjackal has joined #openstack-infra10:29
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900410:30
*** nicolasbock has joined #openstack-infra10:30
*** salv-orlando has quit IRC10:33
*** salv-orlando has joined #openstack-infra10:34
*** boden has joined #openstack-infra10:35
*** alexchadin has quit IRC10:36
*** salv-orlando has quit IRC10:38
*** salv-orlando has joined #openstack-infra10:40
openstackgerritPaul Belanger proposed openstack-infra/system-config master: Remove fedora-26 from AFS mirror  https://review.openstack.org/56472510:45
openstackgerritPaul Belanger proposed openstack-infra/system-config master: Add fedora-28 to AFS mirrors  https://review.openstack.org/56472610:45
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900410:45
*** yamahata has quit IRC10:45
mordredinfra-root: heads up - we cut a new openstacksdk release (which shade depends on now) - should be zero impact, but just fyi10:46
pabelangerack10:48
*** mandre_afk is now known as mandre10:48
*** caphrim007 has joined #openstack-infra10:49
pabelangerinfra-root: I'd like to start preparing for fedora-28, if I could get a review on adding it to our AFS mirrors: https://review.openstack.org/#/q/topic:fedora-2810:51
*** zoli|lunch is now known as zoli10:52
*** pcichy has quit IRC10:53
*** caphrim007 has quit IRC10:53
*** dhajare has quit IRC10:56
*** alexchadin has joined #openstack-infra11:00
*** dhajare has joined #openstack-infra11:01
mordredpabelanger: it's almost likel there is always a new release of something ...11:04
dtantsur|brbfolks, how to debug such failures? http://logs.openstack.org/60/564560/3/check/ironic-tempest-dsvm-functional-python3/59ae183/job-output.txt.gz#_2018-04-27_08_52_19_91938811:04
mordreddtantsur|brb: those are unfortunate - usually either job-output.json or the ara report will have info11:06
dtantsur|brbok, lemme try11:06
*** dtantsur|brb is now known as dtantsur11:06
mordreddtantsur: http://logs.openstack.org/60/564560/3/check/ironic-tempest-dsvm-functional-python3/59ae183/ara-report/result/4195a9cb-0f8d-41ba-ba66-68d8458cf730/11:07
dtantsuraha, I suspected something like that11:07
dtantsurthanks mordred11:08
dtantsurnow I really wonder what in https://review.openstack.org/#/c/564560/2..3/playbooks/legacy/tempest-dsvm-ironic-functional-python3/run.yaml would cause it....11:09
pabelangermordred: indeed11:14
fricklerdtantsur: I'm guessing zuul chokes on the "'" in the comment11:15
dtantsurfrickler: this is my wild guess too, removing it11:15
mordred++11:15
dtantsurbut this is crazy :)11:15
mordreddtantsur: it's actually an ansible jinja parsing thing11:16
dtantsurTIL!11:16
*** dhajare has quit IRC11:16
mordredthat said - we need to get y'all migrated to some non-legacy jobs so you don't have to be editing fragile files like that11:17
dtantsurthat's fair. this patch is just a bit urgent, so I'm cargo-culting old jobs11:18
dtantsurmaybe I could make it a non-legacy job, I will try after it passes11:18
pabelanger#status log jessie removed from mirror.debian (AFS mirror) and reprepro configuration on mirror-update.o.o11:19
openstackstatuspabelanger: finished logging11:19
*** zhangfei has quit IRC11:19
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900411:19
*** andreas_s has quit IRC11:20
*** andreas_s has joined #openstack-infra11:20
*** ykarel|away is now known as ykarel11:22
*** andreas_s has quit IRC11:25
pabelangerfrickler: mind a review on https://review.openstack.org/564726/ too11:27
fricklerpabelanger: ack11:29
*** jcoufal has joined #openstack-infra11:32
*** ldnunes has joined #openstack-infra11:34
*** lucasagomes is now known as lucas-hungry11:38
*** andreas_s has joined #openstack-infra11:39
*** quiquell|rover is now known as quique|rover|lch11:40
openstackgerritMerged openstack-infra/system-config master: Remove fedora-26 from AFS mirror  https://review.openstack.org/56472511:42
*** caphrim007 has joined #openstack-infra11:47
*** caphrim007 has quit IRC11:52
openstackgerritPaul Belanger proposed openstack-infra/system-config master: Fix 'releases' is deprecated warning  https://review.openstack.org/56474011:54
*** jpena is now known as jpena|lunch11:56
*** ramishra has quit IRC11:58
*** efried is now known as fried_rice11:59
*** jtomasek has quit IRC12:01
*** lpetrut has quit IRC12:02
*** jtomasek has joined #openstack-infra12:02
*** lpetrut has joined #openstack-infra12:04
*** ssbarnea_ has quit IRC12:06
*** jamesmcarthur has joined #openstack-infra12:06
*** rosmaita has joined #openstack-infra12:07
*** ssbarnea_ has joined #openstack-infra12:07
*** katkapilatova has joined #openstack-infra12:07
*** panda|ruck is now known as panda|ruck|lunch12:08
*** ssbarnea_ has quit IRC12:09
*** tpsilva has joined #openstack-infra12:09
*** alex_xu has quit IRC12:10
*** alex_xu has joined #openstack-infra12:10
*** jamesmcarthur has quit IRC12:11
*** hwoarang has quit IRC12:13
*** ssbarnea_ has joined #openstack-infra12:13
*** jpich has joined #openstack-infra12:14
*** katkapilatova has left #openstack-infra12:14
pabelanger#status log fedora-26 removed from mirror.fedora (AFS mirror) and rsync configuration on mirror-update.o.o12:15
openstackstatuspabelanger: finished logging12:15
*** ssbarnea_ has quit IRC12:19
*** sree_ has joined #openstack-infra12:20
*** sree_ is now known as Guest709012:21
*** ssbarnea_ has joined #openstack-infra12:21
*** quique|rover|lch is now known as quiquell|rover12:22
*** trown|outtypewww is now known as trown12:23
*** Guest7090 has quit IRC12:24
*** camunoz has joined #openstack-infra12:28
*** alexchadin has quit IRC12:30
*** iranzo has quit IRC12:32
bodenhi, I have a hopefully painless question.. with the current requirements system should we still expect a proposal bot bump for requirements updates, or do we just update requirements ourselves within the scope of the upper constraints?? I’m sure there’s a note on this and I missed it; sorry for that12:32
*** yamamoto has quit IRC12:33
*** VW has joined #openstack-infra12:37
*** lucas-hungry is now known as lucasagomes12:38
*** gongysh has quit IRC12:38
*** rlandy has joined #openstack-infra12:39
*** kgiusti has joined #openstack-infra12:40
*** psachin has quit IRC12:41
openstackgerritMonty Taylor proposed openstack-infra/nodepool master: Clarify in doc introduction that OpenStack is not required  https://review.openstack.org/56474612:44
*** alexchadin has joined #openstack-infra12:45
*** VW has quit IRC12:46
*** jpena|lunch is now known as jpena12:54
openstackgerritMerged openstack-infra/zuul master: Fix zuul home directory in zuul from scratch document  https://review.openstack.org/56438612:57
openstackgerritMerged openstack-infra/nodepool master: Clarify in doc introduction that OpenStack is not required  https://review.openstack.org/56474612:57
*** wolverineav has joined #openstack-infra13:00
*** quiquell|rover is now known as quiquell|roger13:02
*** quiquell|roger is now known as quiquell|rover13:02
*** panda|ruck|lunch is now known as panda|ruck13:03
*** ethfci has quit IRC13:03
*** alexchadin has quit IRC13:05
openstackgerritMerged openstack-infra/system-config master: Add fedora-28 to AFS mirrors  https://review.openstack.org/56472613:05
pabelangerclarkb: comment on https://review.openstack.org/563788/ about log-inventory location13:09
*** mriedem has joined #openstack-infra13:13
*** yamamoto has joined #openstack-infra13:14
*** yamamoto has quit IRC13:14
*** yamamoto has joined #openstack-infra13:18
*** VW has joined #openstack-infra13:19
fungiboden: you may be better off asking in #openstack-requirements (i know some aspects about requirements tracking are changing, and i believe the full synchronization model is being dropped as part of that)13:20
bodenfungi ack… didn’t even realize there was a requirements chat room :)13:20
AJaegerboden: quick answer: The bot is not doing proposal updates anymore13:21
fungiboden: yeah, there's an entire official project team devoted to requirements management in openstack, with a ptl and everything13:21
bodenAJaeger I thought that was the case; thanks for confirmation13:21
pabelangerfungi: mind a +3 to fix deprecated warning in puppet: https://review.openstack.org/564740/13:21
*** stephenfin is now known as finucannot13:23
*** eernst has joined #openstack-infra13:24
*** r-daneel has joined #openstack-infra13:24
*** trown is now known as trown|brb13:26
*** pbourke has quit IRC13:27
*** pbourke has joined #openstack-infra13:28
*** pbourke has quit IRC13:29
*** Goneri has joined #openstack-infra13:29
*** pcichy has joined #openstack-infra13:31
*** dansmith is now known as superdan13:34
*** bnemec has quit IRC13:35
*** esberglu has joined #openstack-infra13:38
openstackgerritMerged openstack-infra/system-config master: Fix 'releases' is deprecated warning  https://review.openstack.org/56474013:40
fungiif another config-core reviewer is up for checking https://review.openstack.org/564608 (a small patch to hopefully finish fixing the legacy job for openstackid tarballs so our deployment automation will work again) it would be much appreciated. once it merges i'm happy to reenqueue the openstackid master branch tip13:42
*** bnemec has joined #openstack-infra13:42
mnaserfungi: lgtm13:43
fungithanks mnaser13:44
mnasernp :>13:44
*** kjackal has quit IRC13:44
*** edmondsw has joined #openstack-infra13:51
*** jchhatbar has quit IRC13:52
dhellmannI need some help with my git repo import patch. AJaeger wants a "groups" entry because I'm having it use storyboard. I don't know what that is or what to make it. This is 1 repo, not owned by a team. Should I just use the repo name? There seem to be a lot of other standalone repos without "groups"13:52
dhellmannhttps://review.openstack.org/#/c/564622/3/gerrit/projects.yaml13:52
openstackgerritMerged openstack-infra/openstack-zuul-jobs master: More fix laravel branch and master publish jobs  https://review.openstack.org/56460813:52
dhellmannmaybe not "a lot" but "some"13:53
*** kjackal has joined #openstack-infra13:54
AJaegerdhellmann: repos that use storyboard have groups - can you confirm, fungi?13:55
dhellmannAJaeger : ok, but I DON'T KNOW WHAT THAT IS so I need more information13:55
*** dave-mccowan has joined #openstack-infra13:55
dhellmannthe documentation says to use that if there are multiple related repos, which is not the case here13:55
*** trown|brb is now known as trown13:56
*** eharney has quit IRC13:57
mordredyah - groups is really only to group multiple things ... like, for openstacksdk we have an openstacksdk group that contains openstack/openstacksdk and openstack-infra/shade13:58
mordredbut it is not a required field for all projects - only ones that want to be part of a grouping13:58
mordredAJaeger, fungi: I think we need to clarify the process - groups should not be reuqired for all storyboard projects - it might just have mostly been the case due to the projects we've migrated so far13:59
*** dave-mccowan has quit IRC13:59
dhellmannthe docs I was following do not imply that is a required field: https://docs.openstack.org/infra/manual/creators.html#add-the-project-to-the-master-projects-list14:00
*** apetrich has joined #openstack-infra14:00
*** johnthetubaguy_ is now known as johnthetubaguy14:00
dmsimardinfra-root: FYI fresh installs of ARA are currently failing with this kind of trace: http://paste.openstack.org/raw/720015/. This should hopefully not propagate to the executors but keep an eye out and let me know while I'm troubleshooting it ?14:00
mordreddmsimard: ack14:01
*** dave-mccowan has joined #openstack-infra14:01
*** yamahata has joined #openstack-infra14:01
*** aojea has quit IRC14:01
*** gongysh has joined #openstack-infra14:03
*** gongysh has quit IRC14:03
openstackgerritPaul Belanger proposed openstack-infra/system-config master: Updates for fedora-28 rsync  https://review.openstack.org/56477114:04
AJaegermordred: that's what I understand as guideline by fungi - let's wait for him to chime in14:04
openstackgerritMerged openstack-infra/nodepool master: Refactor NodeLauncher to be generic  https://review.openstack.org/53555514:05
pabelangerfungi: mordred: dmsimard: mind a review: ^ new files to exclude for fedora-28 rsync14:05
dmsimardinfra-root: It looks like flask broke the 0.12.3 python wheel and they released flask 1.0: https://github.com/pallets/flask/issues/272814:06
dmsimardWhich is why ARA installations are breaking.14:06
*** dtantsur is now known as dtantsur|brb14:07
pabelangerhopefully they don't just delete the wheel and rebuild14:08
pabelangerand do a version bump14:08
fungimordred: AJaeger: dhellmann: i haven't considered groups necessary for storyboard projects, it's merely that we've been creating groups for official openstack project teams to assist in organizing their sets of deliverables14:08
fungiso, say, when importing bugs for all sahara's projects we create a sahara project group and add those to it14:08
dhellmannI could set the group to "doug" or something. :-)14:09
*** alex_xu has quit IRC14:09
openstackgerritPaul Belanger proposed openstack-infra/nodepool master: Add fedora-28 to nodepool dsvm  https://review.openstack.org/55921114:09
mordreddhellmann: I consider you a group ;)14:09
dhellmannsometimes I feel like it14:10
pabelangerianw: ^fedora-28 for nodepool dsvm, works out of the box it seems14:10
fungiyes, if there is some (even small) set of people who will likely be interested in tasks for some specific set of repos, then it may make sense to create a grouping around that14:10
fungifor example, the interop and refstack project groups have some overlap in what projects are in them14:10
dhellmannin this case I don't even have a team in mind to help maintain this repo, although I'd be happy to add it as an infra thing or oslo thing if someone wanted to14:10
dhellmannis it easy to add the group later?14:10
fungiyep14:11
fungijust a matter of adding the info to projects.yaml when the time comes14:11
dhellmannso maybe let's do that, if it comes to it14:11
*** alex_xu has joined #openstack-infra14:11
*** salv-orlando has quit IRC14:11
*** salv-orlando has joined #openstack-infra14:12
*** hemna_ has joined #openstack-infra14:13
openstackgerritPaul Belanger proposed openstack-infra/project-config master: Build fedora-28 DIBs with nodepool-builder  https://review.openstack.org/56477514:13
*** bobh has joined #openstack-infra14:13
pabelangerclarkb: fungi: mordred: dmsimard: ^and enables fedora-28 (beta) DIBs for diskimage-builder, release should be next week14:13
*** salv-orlando has quit IRC14:16
dmsimardinfra-root: Follow up regarding flask/ara breakage, flask maintainer was quick to respond and will release a fixed flask 0.12.4 package so I won't implement a workaround.14:16
*** quiquell|rover is now known as quiquell|off14:19
*** ihar has joined #openstack-infra14:20
*** jogo has quit IRC14:22
smcginnisdmsimard: Is that the tracebacks I've been seeing in logs? ^14:22
dmsimardsmcginnis: where ?14:23
*** agopi|zzz has joined #openstack-infra14:23
smcginnisdmsimard: Let me find an example...14:23
*** agopi|zzz is now known as agopi14:23
openstackgerritMerged openstack-dev/hacking master: Import integration test  https://review.openstack.org/54776514:24
smcginnisOf course I saw a few last night and now can't find any...14:25
smcginnisdmsimard: Found it!14:26
smcginnishttp://logs.openstack.org/68/564068/6/gate/legacy-grenade-dsvm-cinder-mn-sub-volbak/acfeb79/job-output.txt.gz#_2018-04-26_23_10_20_68940214:26
openstackgerritAndreas Jaeger proposed openstack-infra/project-config master: Remove legacy-hacking-integration-nova  https://review.openstack.org/56478614:26
dmsimardsmcginnis: yes, that's the trace14:28
smcginnisdmsimard: OK, great. Then I don't have to remember to ask about it anymore. ;)14:28
openstackgerritAndreas Jaeger proposed openstack-infra/openstack-zuul-jobs master: Remove legacy-hacking-integration-nova  https://review.openstack.org/56478714:29
dmsimardsmcginnis: thankfully it doesn't appear fatal but that job is generating HTML reports ? We're not supposed to do that anymore14:29
AJaegerfungi, so the change by dhellman is fine as is? Then I'll +2A...14:29
smcginnisdmsimard: Not sure.14:29
dmsimard"legacy-grenade-dsvm-cinder-mn-sub-volbak" feels oddly specific, I'll have a look14:30
mordreddmsimard: bah. legacy-grenade-dsvm-cinder-mn-sub-volbak is perfectly generic ;)14:30
dmsimardprobably need to throw the python version, the distro and the name of the openstack release in there14:31
*** yamamoto has quit IRC14:31
*** krenczew1 has quit IRC14:33
*** andreas_s has quit IRC14:34
*** dave-mccowan has quit IRC14:42
*** dave-mccowan has joined #openstack-infra14:43
fungiAJaeger: probably? i haven't looked at the change in question but i'll review it now14:46
fungisnice i seem to have context14:46
*** dave-mcc_ has joined #openstack-infra14:46
fungier, since14:46
*** yamamoto has joined #openstack-infra14:46
*** melwitt is now known as jgwentworth14:47
mordredpabelanger: btw - I put up a patch to get a shade release cut: https://review.openstack.org/#/c/564752/ - so as soon as that lands we should be able to make forward progress on the cinder volume thing14:48
*** dave-mccowan has quit IRC14:48
*** pcichy has quit IRC14:48
pabelangermordred: great14:49
openstackgerritMerged openstack-infra/project-config master: import the git-nit repository  https://review.openstack.org/56462214:49
*** hongbin_ has joined #openstack-infra14:50
smcginnismordred: Is that time sensitive enough to warrant a Friday release? We usually avoid releasing on Friday's unless it's something blocking other time sensitive work.14:52
*** rpittau has quit IRC14:52
mordredpabelanger: ^^ ?14:54
pabelangermordred: smcginnis: no, think it can wait until normal release procedures. vexxhost is disabled currently14:56
pabelangerand allows me to go see Avengers at lunch :D14:56
*** dtantsur|brb is now known as dtantsur14:56
smcginnisOK, sounds good. We can get it processed right away Monday. Or Sunday night if I get to it.14:56
smcginnis:)14:56
smcginnisGood plan!14:56
fungiyeah, at worst it just means we're down a chunk of job capacity over the weekend, when we likely won't be needing it anyway14:56
smcginnisWhat is the vexxhost issue with cinder?14:57
pabelangerit is leaking volumes for some reasons14:57
pabelangerwhen we use boot-from-volume with nova14:57
pabelangerso, shade will allow us to implement quota management in nodepool14:58
*** yamamoto has quit IRC14:58
dmsimardinfra-root: There's 2718 hits on the Flask ARA issue ("AttributeError: 'Blueprint' object has no attribute 'json_encoder'") in the past 24hrs according to logstash. Probably worthy of an email to openstack-dev or a notice ?15:04
mordredsmcginnis: yah - they *why* is a whole other question that we need to dig in to15:05
mordredsmcginnis: but in the mean time - working around it15:05
*** VW_ has joined #openstack-infra15:05
pabelangerdmsimard: these are jobs not using the new database wsgi app?15:05
*** VW_ has quit IRC15:05
*** rajinir has joined #openstack-infra15:06
*** VW_ has joined #openstack-infra15:06
dmsimardpabelanger: There's a lot of different jobs, some non-legacy, I'm trying to get a clear idea15:06
pabelangercould I get a review on https://review.openstack.org/564771/ to fix fedora rsync mirror15:06
smcginnismordred, pabelanger: Ack, thanks15:07
dmsimardpabelanger: for example http://logs.openstack.org/29/564729/2/check/neutron-grenade/2dcf4e6/job-output.txt#_2018-04-27_14_43_20_04898515:07
dmsimardthat seems to be... devstack-gate ?15:07
pabelangerdmsimard: ack, maybe we should use the outage as a method to update those jobs to ara-report database logic15:07
*** yamamoto has joined #openstack-infra15:07
mordredpabelanger: oh. blerg. the leaked volumes in vexxhost have been cleaned up now haven't they15:08
* mordred should have poked yesterday15:08
dmsimardpabelanger: yeah it's probably devstack-gate: https://github.com/openstack-infra/devstack-gate/blob/649d1ae775867568f0aba582361c3489250b9aad/devstack-vm-gate-wrap.sh#L53915:08
pabelangermordred: I am not sure, maybe mnaser did it15:08
mordredit's all good15:08
mnaserhi15:08
*** felipemonteiro__ has joined #openstack-infra15:08
*** VW has quit IRC15:08
mordredpabelanger, mnaser: next time we discover leaked volumes - if we can capture the volume record of a few of them that would be great - the main question is 'do the leaked volumes still show an attachment in the attachments list pointing to a now-non-existent server or not15:09
openstackgerritJeremy Stanley proposed openstack-infra/openstack-zuul-jobs master: Yet more fix laravel branch/master publish jobs  https://review.openstack.org/56479915:09
fungipabelanger: mnaser: ^ one more bit we missed15:09
mordredif they do - then making a leaked volume cleaner is doable15:09
fungishould have been using work_root instead of log_root15:09
mordredsince we can look for volumes that list attachments to non-existent volumes15:09
mordredsince we can look for volumes that list attachments to non-existent servers15:10
pabelangersure15:10
*** jamesmcarthur has joined #openstack-infra15:10
mordredbut if that part of the volume record gets cleaned up yet the volume sticks around - I think deleting it would be very dangerous15:10
mnasermordred: actually, it might be worse, because you cant delete a volume that is attached to a non existent server, nor can you remove the attachment15:10
mordredmnaser: that's excellent15:10
mnasermordred: i think the problem stems from nova ignoring volume delete failures15:10
mordredmnaser: did you clean up the volumes in the openstackjenkins project? or did they just eventually clean themselves up15:11
*** pcaruana has quit IRC15:11
pabelangerall the volume I cleaned up, were detached and able to just use openstack volume delete uuid15:11
mnasermordred: i think i deleted them because it was related to some internal cinder-volume thing15:11
mnaseri guess then maybe the issue might be resolved15:11
mordredoh - wait - there's more in here - I suck at python15:11
*** yamamoto has quit IRC15:12
*** salv-orlando has joined #openstack-infra15:12
mnaserhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2370-L241515:13
mnaserhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2441-L245015:13
pabelangerinfra-root: I'm going to take an extended lunch today, will be back later in the afternoon. I'd love a few reviews on https://review.openstack.org/#/q/topic:fedora-28 to continue work on fedora-28 when I return.  May 1st looks to be the release day now15:13
mnaserfungi: +A15:14
fungithanks pabelanger, mnaser... i'll reenqueue the openstackid branch tip yet again once that fix lands15:15
*** shardy has quit IRC15:17
*** yamamoto has joined #openstack-infra15:17
*** salv-orlando has quit IRC15:17
*** dpawlik has quit IRC15:17
openstackgerritColleen Murphy proposed openstack-infra/puppet-openstackci master: Fix scope of vhost template variable  https://review.openstack.org/56460015:17
mordredpabelanger, mnaser: from what I can see, there are 11 leaked volumes in the vexxhost account. most of them have attachments listed to non-existent servers15:19
*** jogo has joined #openstack-infra15:19
*** jogo has joined #openstack-infra15:19
*** VW_ has quit IRC15:20
mordredbut mnaser says a volume with a non-existent server attachment can't be deleted15:20
mordredso I'm honestly not sure there is a leak cleaner we can write that I'd be comfortable landing15:21
mnaserwhich means we can to reset the attachment state15:21
mnasers/can/have/15:21
mordredmnaser: also - those code links15:21
mordredmnaser: yah - which you have to do on your side I think15:21
mnaseri can reset it but at the scale and churn of openstack infra it wouldn't be a sustainable solution15:21
mordredmnaser: I love that a failure during volume deletion just logs a warning15:21
mordredmnaser: agree15:22
mnaseryeah because of that i try to push customers to create a volume then attach it15:22
openstackgerritColleen Murphy proposed openstack-infra/puppet-zuul master: Fix defined type namespacing  https://review.openstack.org/56480915:22
mordredmnaser: does that work with boot-from-volme?15:22
mnasermordred: i think this won't be an issue, if you do boot from volume, it's on you to delete the volume when you're done15:22
pabelangermordred: mnaser: so, openstack volume delete doesn't work?15:23
pabelangerif so, something changed recently, as I was able to manually clean them up15:23
openstackgerritColleen Murphy proposed openstack-infra/puppet-ethercalc master: Fix defined type namespacing  https://review.openstack.org/56453515:23
mnaserbut then again if it fails to detach then and just logs an error for that..15:23
*** rkukura has joined #openstack-infra15:23
mnaseryou wont be able to delete it either15:23
pabelangerokay, have to run, will catch up in backscroll15:23
mnaseri really don't think nova should just log a message and then make you end up in some inconsistent state where admin intervention is required15:23
mordredmnaser: well - yeah, what's what we're doing now - we're doing boot-on-volume but doing it from an image source - so the boot-from-volume process is creating the volume for us and then booting from it15:24
openstackgerritColleen Murphy proposed openstack-infra/puppet-gerrit master: [DNM] Test puppet-4 puppet-apply jobs  https://review.openstack.org/55751515:24
mordredmnaser: I suppose we could change the code to create a volume from the image, then boot the server on it without delete-on-termination15:24
mordredmnaser: and on server deletion invert the process15:24
mordredoh - but I guess that still has the attachment problem like you said15:25
mordrednodepool - finding intractable bugs since 201215:25
mnaserbut then you'll have one more resource to carry *and* yeah if it fails to detach the vm will disappear and poof15:25
*** jamesmcarthur has quit IRC15:25
*** claudiub has quit IRC15:26
mnasermordred: this has unfortunately been a common frustration which has resulted in us creating custom flavors for customers with a certain amount of disk15:27
mnaserand i *hate* doing that because i feel like we should fix that issue fundamentally15:27
mordredagree15:28
mnaseri much rather have an ERROR state VM that failed to delete with a volume stuck rather than a disappearing VM with an 'attached' volume15:28
mordredwell - that or I do wish it was a generally possible thing for users to create custom flavors15:28
mordredmnaser: ++15:28
mnaserit also allows the user to just ... try deleting again15:28
mnaserand it might just work15:28
mordredsmcginnis: ^^ more context on what's going on with the volume thing15:28
smcginnisThanks, will have to catch up after meeting.15:29
clarkbI too agree that properly recording errors is better than failing to succeed and disappearing data15:29
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900415:29
mordredsmcginnis: tl;dr boot-from-volume-from-image can leave volumes in an undeletable state if anything goes wrong when nova tries to delete the volume15:30
*** VW has joined #openstack-infra15:30
smcginnisAh, yeah. I've seen that issue crop up here and there. Not much we can do on the Cinder side unfortunately.15:30
clarkbyou could delete the volume properly?15:31
clarkbI'm assuming nova doesn't have issues in that case15:31
mnaserclarkb: well i think you cant blame cinder for having some intermittant issues here and there15:32
mnasercinder just has no way to allow nova to recover/retry15:32
*** myoung is now known as myoung|email-unl15:32
*** myoung|email-unl is now known as myoung|emailplz15:32
mordredclarkb: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2441-L2450 is the fun part15:33
smcginnisclarkb: Well, we can delete the volume properly if told to, but if Nova doesn't tell us to then we can't randomly guess.15:33
clarkbsmcginnis: reading ^ nova is telling cinder? its that cinder fails then nova doesn't handle that gracefully?15:33
*** Guest44397 has quit IRC15:33
clarkbboth sides can and should do better15:33
mordredthe problem is that if there is an issue, like say a communication error, nova logs a warning then continues to delete the server - so the volume is left in an inappropriate state15:33
fungior if nova tries to tell cinder to delete but the message ends up in a black hole somewhere15:33
fungiyeah, that15:34
*** agopi is now known as agopi|brb15:34
mordredbecause from cinder's pov it's still attached15:34
smcginnisThe errors I've seen were Nova getting some type of error and never telling Cinder to delete the volume.15:34
mordredyah. could be a 500 from an internal load balancer, for instance15:34
mnasermordred: oh interesting15:34
clarkbmordred: do we have tracebacks from that warning?15:34
mnaserthat function would raise an exception15:34
mnaserhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2502-L250315:34
clarkband ya its reraising there15:35
smcginnisIt's the problem with having Nova manage the process rather than going directly to each service to perform their own operations.15:35
mordredah - ok15:35
*** jaosorior has quit IRC15:35
*** yamamoto has quit IRC15:35
mnaseri think dropping 'raise_exc=False' from that line would fix it15:35
mnaserbut i guess there's a reason behind it15:35
mnasergit blame time15:35
mordredmnaser: :)15:36
openstackgerritMerged openstack-infra/openstack-zuul-jobs master: Yet more fix laravel branch/master publish jobs  https://review.openstack.org/56479915:36
clarkbsmcginnis: sort of, nova should be just as capable of doing it as nodepool15:36
mnasergit blame on nova/manager/compute.py crashes on github, nice15:36
*** gyee has joined #openstack-infra15:36
mordredyah- because the volume thing here is an impl detail15:36
mordredas a user, what we want here is a root filesystem of a certain size on a server we are booting to be ephemeral15:36
mordredthe only way we can do that is by creating a volume15:37
mordredI mena - we can still try skipping the bdm layer and doing it ourselves15:37
*** agopi|brb is now known as agopi15:38
*** lpetrut has quit IRC15:38
mnaseroh15:40
mnaserhttps://review.openstack.org/#/c/545087/15:40
*** jamesmcarthur has joined #openstack-infra15:40
mnaserok sorry thats the stable/ocata backport15:40
mnaserhttps://review.openstack.org/#/q/I8b1c05317734e14ea73dc868941351bb31210bf015:40
mnasermoral of the story upgrade your clouds i guess15:41
mnaseri guess this is only partly a fix for one failure path15:42
openstackgerritMerged openstack-infra/zuul master: Don't store references to secret objects from jobs  https://review.openstack.org/55359615:50
*** caphrim007 has joined #openstack-infra15:51
*** VW_ has joined #openstack-infra15:51
*** VW has quit IRC15:54
openstackgerritMerged openstack-infra/project-config master: add test jobs for openstack/git-nit repository  https://review.openstack.org/56462515:55
*** VW_ has quit IRC15:55
*** pcichy has joined #openstack-infra15:55
*** VW has joined #openstack-infra15:55
*** hashar is now known as hasharAway15:56
*** dpawlik has joined #openstack-infra15:57
*** felipemonteiro_ has joined #openstack-infra15:57
*** lucasagomes is now known as lucas-afk15:58
*** eharney has joined #openstack-infra16:01
*** felipemonteiro__ has quit IRC16:01
*** dpawlik has quit IRC16:02
*** bnemec is now known as beekneemech16:02
openstackgerritDavid Peacock proposed openstack-infra/project-config master: Adding tripleo-role-keystone  https://review.openstack.org/56481916:03
*** hasharAway is now known as hashar16:03
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Allow extra time for some ansible tests  https://review.openstack.org/56457216:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Fix race in test_bubblewrap_leak  https://review.openstack.org/56464016:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Perform late validation of secrets  https://review.openstack.org/55304116:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Perform late validation of nodesets  https://review.openstack.org/55308816:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Late bind projects  https://review.openstack.org/55361816:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make config objects freezable  https://review.openstack.org/56281616:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove layout from ParseContext  https://review.openstack.org/56369516:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove 'base' from UnparsedAbideConfig  https://review.openstack.org/56375716:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Change TestMaxTimeout to not run ansible  https://review.openstack.org/56456216:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Store source context on all config objects  https://review.openstack.org/56456316:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Cache configuration objects in addition to YAML dicts  https://review.openstack.org/56406116:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Stop deep-copying job variables  https://review.openstack.org/56456416:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove source_context argument to Pipeline  https://review.openstack.org/56464216:05
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Simplify UnparsedConfig.copy  https://review.openstack.org/56464716:05
*** zerick_ is now known as zerick16:08
dhellmanncould I get someone to add me to the git-nit-core group in gerrit please? https://review.openstack.org/#/admin/groups/1900,members16:09
clarkbdhellmann: one sec16:09
clarkbdone16:09
dhellmannclarkb : thanks!16:09
openstackgerritDavid Peacock proposed openstack-infra/project-config master: Add system-required template for tripleo-role-keystone  https://review.openstack.org/56482316:10
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add regex support to project stanzas  https://review.openstack.org/53571316:12
*** salv-orlando has joined #openstack-infra16:13
openstackgerritJeremy Stanley proposed openstack-infra/openstack-zuul-jobs master: Further fix laravel branch/master publish jobs  https://review.openstack.org/56482816:14
fungipabelanger: mnaser: ^ i think this is the last fix we need for openstackid tarball publication (it's publishing successfully now, but to a subdirectory we don't want)16:14
fungii'll clean up the http://tarballs.openstack.org/openstackid/tarballs/ directory and reenqueue (hopefully one final time) once that's in place16:15
*** dtantsur is now known as dtantsur|afk16:15
openstackgerritDavid Peacock proposed openstack-infra/project-config master: Adding tripleo-role-keystone  https://review.openstack.org/56481916:18
*** salv-orlando has quit IRC16:18
*** VW has quit IRC16:19
openstackgerritDavid Peacock proposed openstack-infra/project-config master: Adding tripleo-role-keystone  https://review.openstack.org/56481916:20
*** VW has joined #openstack-infra16:23
*** jpich has quit IRC16:24
*** fried_rice is now known as fried_rolls16:27
*** VW has quit IRC16:27
clarkbcorvus: since you are talking about restarting zuul I've just checked that zuul is being installed properly and pbr seems to report the current HEAD sha116:27
*** r-daneel_ has joined #openstack-infra16:29
*** r-daneel has quit IRC16:29
*** r-daneel_ is now known as r-daneel16:29
clarkbfungi: openstackid fix approved16:30
*** felipemonteiro_ has quit IRC16:31
*** felipemonteiro__ has joined #openstack-infra16:31
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add allowed-triggers and allowed-reporters tenant settings  https://review.openstack.org/55408216:31
*** lpetrut has joined #openstack-infra16:32
corvusclarkb: yay!  we're probably a few hours out from patches landing; a bit of a backlog (who works on fridays ?!)16:33
*** e0ne has joined #openstack-infra16:34
*** derekh has quit IRC16:35
*** ccamacho has quit IRC16:35
*** zoli is now known as zoli|gone16:36
*** yamamoto has joined #openstack-infra16:36
*** jamesmcarthur has quit IRC16:36
*** trown is now known as trown|lunch16:40
*** e0ne has quit IRC16:41
*** eharney has quit IRC16:41
*** yamamoto has quit IRC16:42
openstackgerritMerged openstack-infra/zuul master: Allow extra time for some ansible tests  https://review.openstack.org/56457216:44
openstackgerritMerged openstack-infra/openstack-zuul-jobs master: Further fix laravel branch/master publish jobs  https://review.openstack.org/56482816:44
openstackgerritMerged openstack-infra/zuul master: Fix race in test_bubblewrap_leak  https://review.openstack.org/56464016:45
openstackgerritMerged openstack-infra/zuul master: Perform late validation of secrets  https://review.openstack.org/55304116:58
openstackgerritMerged openstack-infra/zuul master: Perform late validation of nodesets  https://review.openstack.org/55308816:58
openstackgerritMerged openstack-infra/zuul master: Late bind projects  https://review.openstack.org/55361816:58
AJaegerinfra-root, FYI, I'll be travelling to KubeCon next week - don't expect to see much from me...17:02
openstackgerritColleen Murphy proposed openstack-infra/puppet-zuul master: Fix scope of vhost template variable  https://review.openstack.org/56484417:02
clarkbAJaeger: have fun17:02
fungiAJaeger: enjoy it!17:02
openstackgerritColleen Murphy proposed openstack-infra/puppet-gerrit master: [DNM] Test puppet-4 puppet-apply jobs  https://review.openstack.org/55751517:03
AJaegerthanks, clarkb and fungi17:03
*** VW has joined #openstack-infra17:06
*** pbourke has joined #openstack-infra17:07
*** eernst has quit IRC17:07
*** jpena is now known as jpena|off17:07
*** eernst has joined #openstack-infra17:08
*** tbh has joined #openstack-infra17:08
*** salv-orlando has joined #openstack-infra17:09
*** tesseract has quit IRC17:09
*** yamahata has quit IRC17:09
*** pbourke has quit IRC17:10
tbhHi, I got access rights for openstack/meteos project. I want to start work on this project. There is no much work psuhed to this repo. I am not sure whom to inform to not to remove this repo because there is no activity for a while17:10
*** pbourke has joined #openstack-infra17:10
clarkbtbh: if it hasn't been retired already (doesn't apepar to have been) and there is activity on it we'll leave it be17:11
*** pbourke has quit IRC17:12
*** pbourke has joined #openstack-infra17:13
fungiwe don't automatically retire repositories anyway17:13
tbhclarkb, there is no activity on this repositories for many months... so am informing17:14
tbhclarkb, fungi, am going to push code next week17:15
*** VW_ has joined #openstack-infra17:15
*** VW_ has quit IRC17:17
openstackgerritColleen Murphy proposed openstack-infra/puppet-openstackci master: Fix scope of vhost template variables  https://review.openstack.org/56460017:17
*** VW_ has joined #openstack-infra17:17
openstackgerritColleen Murphy proposed openstack-infra/puppet-zuul master: Fix scope of vhost template variables  https://review.openstack.org/56484417:18
*** VW has quit IRC17:18
rosmaitagood afternoon ... if someone has a few spare minutes, i'm seeing this weird failure in the glance functional-py35 tests ... http://logs.openstack.org/49/564649/1/check/openstack-tox-functional-py35/b6f5675/testr_results.html.gz -- the subunit parser thing ... anyone know what causes that?17:20
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Report git sha in status page version  https://review.openstack.org/56462817:21
*** mriedem is now known as mriedem_afk17:21
*** VW_ has quit IRC17:22
*** kmalloc has joined #openstack-infra17:22
*** germs has quit IRC17:22
*** germs has joined #openstack-infra17:23
*** germs has quit IRC17:23
*** germs has joined #openstack-infra17:23
clarkbrosmaita: I'll look once my tea is made17:25
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add release note about re2  https://review.openstack.org/56484717:27
rosmaitaclarkb: appreciate it17:29
corvusclarkb, cmurphy, pabelanger, mordred, fungi: thinking more about the re2 thing -- maybe we should be running bindep in puppet-zuul (and other modules for projects which now have bindep files)?17:30
clarkbcorvus: ya its probably not a bad idea, basically puppet exec `bash -c 'apt-get install -y $(bindep -b /opt/zuul/bindep.txt)'`17:31
cmurphycorvus: that sounds good to me17:33
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900417:34
clarkbrosmaita: my reading of it is that the subunit data stream (which is basically the output of the test runs for tracking success and failure as well as logging and stdout failed to parse due to checksum errors17:37
clarkbrosmaita: I think due to incomplete data sending17:37
clarkbrosmaita: I grabbed the subunit file and converted it to version 1 (whcih is more human readable) to see the checksum errors17:38
*** yamamoto has joined #openstack-infra17:38
clarkbrosmaita: if I had to guess why that happened the tests or testsuite crashed the output somehow17:39
clarkb(closing the file descriptor possibly)17:39
clarkbrosmaita: there are a lot of novaclient exceptions which probably aren't related but unsure if you know about those17:41
*** amoralej is now known as amoralej|off17:41
fungicorvus: clarkb: cmurphy: i missed whatever "the re2 thing" is, but sounds like it might be worth a try. i worry still that we could end up installing python modules from distro packages that way and then end up attempting to pip upgrade them when continuously deploying python-based services from source, but we can cross that bridge if and when we come to it17:41
clarkbfungi: basically zuul added a new system dep which was properly reflected inbindep but puppetry broke17:42
clarkbdep in this case is libre2-dev iirc17:42
*** yamamoto has quit IRC17:43
rosmaitaclarkb: thanks ... that sounds like a kind of random thing (the subunit problems), not a problem with the tests themselves?17:44
*** dhill_ has quit IRC17:44
fungiclarkb: yeah, seems like a reasonable approach then17:44
clarkbrosmaita: possibly, though seems more likely the tests are breaking subunit somehow. (like closing the socket fd)17:45
fungiclarkb: the software declares its distro package dependencies, so puppet can certainly take advantage of that and allow us to stop double-accounting all the package names17:45
clarkbrosmaita: unfortuntely there is a bit of chicken and egg here with this being how we get the logs so not having logs its hard to see what was going on17:45
*** yamahata has joined #openstack-infra17:45
*** felipemonteiro_ has joined #openstack-infra17:45
clarkbrosmaita: I'd probably start by checking if it happens consistently on the change, then work to clean up these novaclient exceptions so the logs are readable (assuming we don't want those exceptions to be happening at all)17:46
corvusfungi: you're suggesting that maybe a bindep-specified package might pull in an unexpected python-foo distro package?17:46
*** armaan has quit IRC17:46
fungicorvus: probably not for our python-based services, but maybe if we're deploying multiple things onto one server17:46
fungithen again, we probably only have to worry about our (python-based) projects making use of bindep anyway17:46
fungiand those wouldn't put their python deps in bindep.txt17:47
rosmaitaclarkb: thanks!17:47
fungicorvus: so i think i've talked myself out of any real concern, at least until bindep becomes much more popular for non-python projects17:47
clarkbrosmaita: then hopefully we write enough data before things get kille to see what is going on (since it won't be full of exception data due to novaclient)17:47
fungicorvus: the only downside i can see is that it's not very puppety, but maybe someone with better puppet-fu than me can work out how to turn bindep output into a resource iterator17:49
*** ykarel is now known as ykarel|away17:49
*** felipemonteiro__ has quit IRC17:49
*** trown|lunch is now known as trown17:50
*** dhill_ has joined #openstack-infra17:50
openstackgerritColleen Murphy proposed openstack-infra/puppet-kibana master: Fix scope of vhost template variables  https://review.openstack.org/56485317:51
*** gfidente has quit IRC17:52
*** rkukura has quit IRC17:53
*** ykarel|away has quit IRC17:54
*** armaan has joined #openstack-infra17:55
*** salv-orlando has quit IRC17:55
*** salv-orlando has joined #openstack-infra17:56
cmurphygot a successful puppet apply test with puppet 4 :D https://review.openstack.org/#/c/557515/17:57
clarkbtime to start reviewing the depends on list I guess17:58
*** dpawlik has joined #openstack-infra17:58
*** caphrim007_ has joined #openstack-infra17:59
*** rkukura has joined #openstack-infra18:00
*** salv-orlando has quit IRC18:01
*** dpawlik has quit IRC18:02
*** caphrim007 has quit IRC18:03
*** panda|ruck is now known as panda|ruck|off18:07
*** salv-orlando has joined #openstack-infra18:08
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add debug info to test_slow_start  https://review.openstack.org/56485718:11
clarkbcmurphy: https://review.openstack.org/#/c/564577/1 that one has a failing test and the log isn't really clear on what is broken18:11
clarkbcmurphy: have you happened to look into that yet?18:12
clarkboh I scrolled too far past the erorr18:12
clarkbhttp://logs.openstack.org/77/564577/1/check/legacy-puppet-beaker-rspec-infra/902e108/job-output.txt.gz#_2018-04-26_18_53_59_544750 I'm guessing that is the libre2-dev problem I will recheck18:12
*** kjackal has quit IRC18:13
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add regex support to project stanzas  https://review.openstack.org/53571318:14
cmurphyclarkb: oh yeah that was where i found that, forgot to recheck it18:14
clarkbcmurphy: comment on https://review.openstack.org/#/c/564601/118:14
openstackgerritColleen Murphy proposed openstack-infra/puppet-storyboard master: Use versioncmp function  https://review.openstack.org/56460118:16
cmurphyclarkb: fixed18:16
openstackgerritColleen Murphy proposed openstack-infra/puppet-mailman master: Fix scope of vhost template variables  https://review.openstack.org/56485918:18
clarkbcmurphy: looking at https://review.openstack.org/#/c/564609/2/templates/dual-elasticsearch.vhost.erb won't @elasticsearch_prefix and @elasticsearch_url need to convert to lookups like you did in the logs vhost for openstackci?18:18
clarkbI'm guessing that will be the next wave of fixes?18:18
*** pcichy has quit IRC18:19
cmurphyclarkb: yeah already working on that https://review.openstack.org/#/c/564853/1/templates/dual-elasticsearch.vhost.erb18:19
cmurphyclarkb: it's a little scary because the apply test doesn't always catch those18:19
clarkbya since its a noop it doesn't actually write to disk18:20
clarkbcmurphy: in those cases does it substitute empty string too rather than erroring?18:20
cmurphyclarkb: yeah :(18:20
clarkbgg18:21
cmurphyer no it substitutes nil18:21
clarkboh even better18:21
cmurphywhich i didn't expect because otherwise puppet 4 seems stricter about types18:21
*** ykarel|away has joined #openstack-infra18:23
*** markmcclain has quit IRC18:25
*** hwoarang has joined #openstack-infra18:27
openstackgerritColleen Murphy proposed openstack-infra/puppet-openstack_health master: Fix scope of vhost template variables  https://review.openstack.org/56486018:30
*** electrofelix has quit IRC18:31
*** markmcclain has joined #openstack-infra18:32
*** r-daneel_ has joined #openstack-infra18:33
*** r-daneel has quit IRC18:34
*** r-daneel_ is now known as r-daneel18:34
*** armaan has quit IRC18:35
mordredcorvus: I think we should be running bindep - but I also think we need to poke at our bindep file a little bit18:38
*** yamamoto has joined #openstack-infra18:40
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Fix description for DependentPipelineManager  https://review.openstack.org/56486218:40
mordredcorvus: for instance, it declares that we need zookeeperd - which is not true on all of the zuul nodes18:40
clarkbmordred: that is for the test jobs right? so the test profile would be appropriate18:41
*** rkukura has quit IRC18:41
mordredclarkb: yah - there's also a setof things that are important if you're installing deps from source without wheels available, but which if you do have wheels are not needed (although they obviously don't hurt)18:43
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Fix some code description  https://review.openstack.org/56486218:44
clarkbmordred: in that case I think we err on the side of caution because nothing requires an upstream to continue producing wheels18:44
mordredya18:45
*** yamamoto has quit IRC18:45
clarkbthis remeinds me I should look at fixing the bindep tests in my use distro change18:49
corvusmordred: oh yeah, we should resolve that before we do that in puppet.  or we'll have a bunch of zookeeperds :)18:49
openstackgerritColleen Murphy proposed openstack-infra/puppet-refstack master: Fix scope of vhost template variables  https://review.openstack.org/56486318:50
*** salv-orlando has quit IRC18:50
openstackgerritMerged openstack-infra/zuul master: Make config objects freezable  https://review.openstack.org/56281618:51
openstackgerritMerged openstack-infra/zuul master: Remove layout from ParseContext  https://review.openstack.org/56369518:51
*** fried_rolls is now known as fried_rice18:56
fungiright, we could consider making more judicious use of profiles in zuul's (and nodepool's) bindep.txt. like a scheduler profile, an executor profile, a merger profile, a launcher profile, a builder profile and so on18:57
openstackgerritMerged openstack-infra/zuul master: Remove 'base' from UnparsedAbideConfig  https://review.openstack.org/56375718:58
openstackgerritMerged openstack-infra/zuul master: Change TestMaxTimeout to not run ansible  https://review.openstack.org/56456218:58
openstackgerritMerged openstack-infra/zuul master: Store source context on all config objects  https://review.openstack.org/56456318:58
openstackgerritMerged openstack-infra/zuul master: Cache configuration objects in addition to YAML dicts  https://review.openstack.org/56406118:58
openstackgerritMerged openstack-infra/zuul master: Stop deep-copying job variables  https://review.openstack.org/56456418:58
openstackgerritMerged openstack-infra/zuul master: Remove source_context argument to Pipeline  https://review.openstack.org/56464218:58
openstackgerritMerged openstack-infra/zuul master: Simplify UnparsedConfig.copy  https://review.openstack.org/56464718:58
*** salv-orlando has joined #openstack-infra18:59
corvusinfra-root: i'd like to eat lunch.  then i'd like to restart zuul and see if it blows up.19:00
mordredcorvus: are you sure that's the right order?19:00
corvusmordred: i could not be more certain!19:01
fungimight want to wait for 564628 to merge too, i just now (re)approved it19:01
corvusi'm pretty sure not eating lunch is how we ended up with memory problems in the first place19:01
mordredgood19:01
corvusfungi: oh that'll be nice yeah.19:01
*** spsurya has quit IRC19:01
corvusmordred: not sure if you saw 564628 -- you might want to retro-review it19:02
mordredfungi: I've also been playing with the idea of a 'build' profile 'these are the things you need if you want ot build wheels for zuul and all of its depends'19:02
mordredcorvus: lgtm19:03
*** e0ne has joined #openstack-infra19:03
fungicorvus: i got to playing around with package_resources last night because i wanted one of my personal projects to have a show environment command where it would report not only its own version and git commit info, but also those of all its declared install_requires as well as transitively installed dependencies (for improved upstream error reporting in the future). as a result i can probably reuse19:03
fungisome of that to do the pbrless version module for zuul when i remember to poke at it19:03
fungier, pkg_resources19:04
*** caphrim007_ has quit IRC19:05
*** caphrim007 has joined #openstack-infra19:05
*** e0ne has quit IRC19:06
corvusfungi: nice!  that could be useful19:07
pabelangerand back19:08
pabelangercould I get a few reviews on https://review.openstack.org/564771/ and https://review.openstack.org/564775/ thanks19:10
openstackgerritColleen Murphy proposed openstack-infra/puppet-askbot master: Fix scope of vhost template variables  https://review.openstack.org/56486619:12
*** imacdonn has quit IRC19:14
*** imacdonn has joined #openstack-infra19:15
openstackgerritMerged openstack-infra/zuul master: Report git sha in status page version  https://review.openstack.org/56462819:15
*** dpawlik has joined #openstack-infra19:17
*** myoung|emailplz is now known as myoung19:18
*** evrardjp has quit IRC19:18
*** evrardjp has joined #openstack-infra19:21
*** dpawlik has quit IRC19:22
openstackgerritColleen Murphy proposed openstack-infra/puppet-storyboard master: Fix scope of vhost template variables  https://review.openstack.org/56486819:25
smcginnisI just noticed I have some of the patches from around the queens release still out there.19:33
smcginnisIf someone could take a look, that would be appreciated.19:34
smcginnishttps://review.openstack.org/#/q/project:openstack-infra/devstack-gate+owner:%22Sean+McGinnis+%253Csean.mcginnis%2540gmail.com%253E%22+status:open19:34
fungiany other config-core willing to approve https://review.openstack.org/564047 so i can initiate the barbican migration from launchpad to storyboard?19:35
*** slaweq has quit IRC19:35
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add regex support to project stanzas  https://review.openstack.org/53571319:35
clarkbfungi: looking19:37
clarkbfungi: and done19:37
fungiprobably fine to waive the only-osf-staff-reviewers approving an osf-staff-authored change in this particular case19:37
fungias i can't imagine that one being even remotely controversial19:38
fungithanks!19:38
clarkbya its tiny19:38
*** yamamoto has joined #openstack-infra19:42
*** lpetrut has quit IRC19:44
*** lpetrut has joined #openstack-infra19:44
pabelangerclarkb: any objection to start building fedora-28 images, https://review.openstack.org/564775/ currently working with DIB19:45
openstackgerritMerged openstack-infra/project-config master: Add Barbican to StoryBoard  https://review.openstack.org/56404719:46
*** yamamoto has quit IRC19:47
openstackgerritFatih Degirmenci proposed openstack-infra/nodepool master: Add nodepool service file for CentOS7  https://review.openstack.org/56487219:49
*** kjackal has joined #openstack-infra19:49
mordredfungi: I didn't even realize that was a thing19:51
*** r-daneel_ has joined #openstack-infra19:52
*** r-daneel has quit IRC19:53
*** r-daneel_ is now known as r-daneel19:53
*** Douhet has quit IRC19:55
*** Douhet has joined #openstack-infra19:55
*** claudiub has joined #openstack-infra19:59
corvusinfra-root: i'd like to restart zuul now.20:02
clarkbcorvus: ok20:02
mordredcorvus: I believe in you20:05
*** CrayZee has quit IRC20:06
corvusrelease has been notified and their queues are quiet (also, friday)20:06
fungithanks corvus!20:07
corvus(i'm restarting everything for good measure, even though the main focus is the scheduler)20:07
fungimordred: more an informal thing where those of us who are employed by osf are doing our best to not squander the community's good will20:08
corvusyou have 5 good will points remaining20:08
corvus(i really hope everyone read that in the voice of korben dallas's cab)20:09
clarkbwhile corvus is doing that I've been nerd sniped by bindep, anyone have access to /etc/os-release on a redhat enterprise workstation install?20:09
clarkbif I could have the contents of that file it would be helpful20:09
corvusthe scheduler is back up, after only about 30s of downtime20:10
fungiwow, quick, right?20:11
fungiif only my pizza would finish baking in that amount of time20:11
*** caphrim007_ has joined #openstack-infra20:11
corvusfungi: well, it hasn't started doing anything yet, this is just the new idea of restart the scheduler before the executors have finished stopping, so that we don't miss gerrit events20:11
corvusit's waiting for mergers/executors to come online20:11
corvuslooks like i can start the mergers now, so i'll do that.  still waiting on executors to stop20:12
corvus4/6 stopped20:13
openstackgerritBen Nemec proposed openstack-dev/pbr master: Read description file as utf-8  https://review.openstack.org/56487420:13
corvus9/1020:14
openstackgerritClark Boylan proposed openstack-infra/bindep master: Use the distro package to determine distro  https://review.openstack.org/56465020:14
corvusstarting executors20:15
clarkbfungi: pabelanger notmyname ^ it mostly works now according to the tests. Just need os-release data for a few more distros and to remove what I think is a test we no longer need.20:15
*** caphrim007 has quit IRC20:15
notmynameclarkb: nice!20:15
clarkbnotmyname: to complicate matters most rpm based distros appear to use a different name in lsb_release and os-release you know just to be confusing20:16
clarkbnotmyname: I've done my best to add the other when one is detected20:16
corvusinfra-root: apparently we have a hole in our tests: http://paste.openstack.org/show/720047/20:17
corvusthat is certainly going to cause problems for us20:17
fungioh, ick20:17
corvusi can manually revert the scheduler and restart it20:17
corvusthat might be the best thing to do, then i'll triage the bug and figure out if we should roll forward with a fix, or revert on master20:18
corvussound like a plan?20:18
*** lpetrut has quit IRC20:18
clarkbyup20:18
fungisounds as good as we can make it for now20:18
corvusi'll just revert to 3.0.2 :)20:18
fungionce that's done, i'm curious to discover what's not serializable about that object20:19
clarkbfungi: I expect NOSE_HTML_OUT_FILE wants a string not a python value20:19
corvusit may be that mappingproxies don't implement a needed interface20:20
corvuson the plus side: Zuul version: 3.0.3.dev21 95c89f420:20
corvusrestarting scheduler now20:21
corvusi saved queues again; i'll restore both copies.  so there shouldn't be much impact.20:21
*** bobh has quit IRC20:22
clarkbfungi: corvus rereading the error message its not the OUT_FILE that is a string, its mappingproxy itself20:24
clarkbwhich is unfortunate20:24
clarkbI'm going to test that now20:25
clarkbya that appears to be it20:27
corvusso: you just can't json serialize a mappingproxy?20:28
*** bobh has joined #openstack-infra20:28
clarkbat least not without coercing the type first? This feels liek a half baked implmentation of that type20:28
mordredclarkb, corvus everything about how json serialization works is bong20:29
corvusyeah, it's not *quite* all i hoped it would be20:29
mordredwhatever you do, don't go look at the actual code in the stdlib20:29
corvusmordred: i'm pretty sure mappingproxy is bong too, so.... double bong or something.20:29
mordredbecause it sure does do 'if isinstance(dict)' rather than looking to see if a given thing implements the right interface20:29
clarkbits literally just a pointer to a dict20:30
clarkbit should be serializable20:30
clarkbbut it isn't20:30
mordredso if your thing does not actually subclass dict, jsonencoder gets confused20:30
mordredthat said - we can write a custom json encoder20:30
*** auristor has quit IRC20:33
corvusokay, the hole in our tests is that we don't seem to have any deep dictionaries under vars20:36
*** r-daneel_ has joined #openstack-infra20:36
corvusso the first level of the vars dict gets converted to a dict, but not deeper ones20:36
corvusi want to say that part of the Job.deepUpdate method actually has to convert all these back to dicts anyway, so let me poke at that first before we head down the road of serializing mappingproxies20:37
*** r-daneel has quit IRC20:37
*** r-daneel_ is now known as r-daneel20:37
mordredcorvus: that should be an easy enough testing hole to fix too20:39
corvusyep, i've reproduced locally20:40
*** ssbarnea_ has quit IRC20:43
*** wolverineav has quit IRC20:43
*** yamamoto has joined #openstack-infra20:43
*** wolverineav has joined #openstack-infra20:44
openstackgerritColleen Murphy proposed openstack-infra/puppet-drupal master: Fix scope of vhost template variables  https://review.openstack.org/56488020:44
corvusokay, the deepUpdate method only needs to turn mappingproxies into dicts if an item appears in both things (eg, a variable in a parent is being overriden in a child job)20:45
corvusit's easy enough to make it do that all the time, if we just want to fix it that way20:46
corvusor we could keep those as mappingproxies and then try to figure out how to serialize them20:46
corvusi'm not too worried about performance here; this is inside of job freezing, so there's a bunch of copying going on anyway, and this only happens when we're really going to run a job.20:47
corvusso i'm sort of inclined to just fix it in deepUpdate20:47
corvus(ie, always turn it back into a dict)20:47
corvusalso -- there's a second bug here, we sure do call isinstance(foo, dict)  :)20:48
clarkbcorvus: you're basically saying let the scheduler config side by forzen but when it goes to the executor we copy it and unfreeze it and then serialize that?20:48
clarkbs/side by frozen/side stay frozen/20:48
*** wolverineav has quit IRC20:48
clarkbthat seems reasonable. The internal representation doesn't need to be directly serializable20:48
corvusclarkb: this is actually still inside the scheduler, even before we send it to the executor client.  this is the part where we collect all the variants, and then construct a new synthetic job by combining all of them.20:49
clarkbah20:49
corvusthat's why i say there's a bunch of copying happening anyway20:49
clarkband variant application implies modification so frozeness isn't required20:49
*** yamamoto has quit IRC20:49
corvusyep20:50
openstackgerritColleen Murphy proposed openstack-infra/puppet-ethercalc master: Fix scope of vhost template variables  https://review.openstack.org/56488220:50
clarkbI'd be fine with that approach, kind of makes it explicit if we do the wrong thing too20:51
clarkbas it did here20:51
corvushow should i duck type these... getattr(foo, 'items') or getattr('__getitem__')?20:51
corvusor should i just "if isinstance(dict) or isinstance(mappingproxy)"?20:51
clarkbisinstance is nice and explicit20:52
fungithough may result in an ever-growing list of dict-like types down the road, or do we really only expect it to be one of those two?20:53
mordredclarkb: you can do isinstance with a list20:53
mordredcorvus: I mean20:53
openstackgerritColleen Murphy proposed openstack-infra/puppet-etherpad_lite master: Fix scope of vhost template variables  https://review.openstack.org/56488420:54
mordredif isinstance(foo, (dict, mappingproxy)):20:54
corvusmordred: did i just learn something new about python 1.5.2?20:54
fungineat and kindof sqlish20:54
mordredin fact, you can make a variable somewhere: DICT_TYPES = (dict, mappingproxy) and then do if isinstance(foo, DICT_TYPES) ... which is how six does its STRING_TYPES thing20:55
mordredcorvus: :)20:55
mordredcorvus: there's always something new to learn!20:55
mordredcorvus: you know ... if we really wanted to be l33t, instead of adopting python 3.5, we could have adopted 1.520:55
corvusmordred: actually, i think it's python2.  the 1.5.2 docs don't mention tuples20:56
mordredcorvus: I'm pretty sure I could not actually write a python 1.5 program any more20:56
mordreddarn. 2.1.3 is as far back as pyenv will let me install20:57
fungipyenv isn't l33t enough for python 1.x20:58
dmsimardI haven't seen a notice about a restart or needing to recheck changes but I'm catching up with the backlog. It seems some of the changes I've +W'd aren't anywhere in the queue ?21:01
*** trown is now known as trown|outtypewww21:01
dmsimardok so there was a restart, maybe my things were lost somewhere in there21:02
fungidmsimard: there were a couple of very short (30-60s?) scheduler restarts21:02
*** jtomasek has quit IRC21:02
mordreddmsimard got lucky21:03
dmsimard"lucky" :P21:03
fungihe is a lucky guy21:03
dmsimardI've +W around 16:20ish, anyway, I've re +Wd21:03
dmsimardWe'll finally have a new release of ARA next week, cutting a pre-release today. Then we can merge the performance improvements for logs.o.o with https://review.openstack.org/#/c/558688/21:04
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Coerce MappingProxyTypes in job vars to dicts  https://review.openstack.org/56488621:05
corvusclarkb, mordred, fungi: ^21:06
corvusi also scanned for other instances of isinstance(.*dict), and i don't think there are any more which could be problematic21:06
*** jcoufal has quit IRC21:06
*** harlowja has joined #openstack-infra21:07
*** felipemonteiro__ has joined #openstack-infra21:10
*** felipemonteiro_ has quit IRC21:10
*** rfolco is now known as rfolco|off21:11
mordredcorvus: cool21:11
clarkbcorvus: should I go ahead and approve it?21:13
corvusclarkb: yeah, maybe we can swing one more restart attempt.  also, master's broken anyway :)21:13
clarkbapproved21:13
*** ldnunes has quit IRC21:13
clarkbI'm gonna find lunch while we wait on that21:13
corvusclarkb: it passes pep8 and tests locally21:14
*** ykarel|away has quit IRC21:15
corvusdo we have bionic testing for system-config?21:16
clarkbcorvus: I think we do21:17
*** felipemonteiro_ has joined #openstack-infra21:17
clarkbchecking really quiickly21:17
clarkbnope i'm wrong21:17
corvusokay, i guess i'll do that21:18
corvuspabelanger: unless you have bionic system-config patches?21:18
*** dpawlik has joined #openstack-infra21:18
*** felipemonteiro__ has quit IRC21:20
openstackgerritJames E. Blair proposed openstack-infra/openstack-zuul-jobs master: Add infra apply-puppet-bionic job  https://review.openstack.org/56489121:22
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Test eavesdrop on bionic  https://review.openstack.org/56489221:23
pabelangercorvus: no, haven't added them yet21:23
corvuspabelanger: how's that look ^ ?21:23
*** dteselkin_ has quit IRC21:23
*** igormarnat has quit IRC21:23
*** dpawlik has quit IRC21:23
*** e0ne has joined #openstack-infra21:24
pabelangercorvus: hmm, bionic seems to be puppet5 by default now, https://packages.ubuntu.com/bionic/puppet wonder how puppetlabs repo will handle that21:24
*** rakhmerov has quit IRC21:25
corvusdon't we use the puppetlabs repo explicitly so we don't have to care what's in the distros?21:25
clarkbsort of, we did it on older distros to get newer puppet but as puppet moved well ahead and stopped publishing older puppet for newer distros we used distro puppet21:26
pabelangeryah, I don't think puppetlabs is building puppet3 any more21:27
corvusi'm on the fence, but this may be the thing that convinces me that we should switch to ansible21:27
*** igormarnat has joined #openstack-infra21:27
clarkbcorvus: the difference being we can easily install ansible from source?21:27
corvusclarkb: no, that we don't have to install ansible on the remote system21:28
pabelangerI don't see bionic packages yet: https://apt.puppetlabs.com/pool/21:28
clarkbfwiw the switch from /etc/puppet to /etc/puppetlabs to line up with the company name. Then changing the company name to Puppet is what I'm hung up on21:28
*** dteselkin has joined #openstack-infra21:28
dmsimardclarkb: wow21:28
clarkbapparently red hat patches it to still be /etc/puppet21:29
clarkbto make things even worse21:29
pabelanger -- Matthias Klose <doko@ubuntu.com>  Thu, 29 Mar 2018 14:21:28 +080021:29
pabelangeris when puppet 5 was added to bionic21:29
pabelangerwhen I last checked, before that date, it was still puppet 421:29
corvussurprise!21:29
pabelangerindeed21:30
corvusokay, well, i guess if i want to make progress on the irc stuff, i just have to install limnoria in a venv21:30
pabelangerthat makes it much harder to switch control plane to bionic21:30
*** rakhmerov has joined #openstack-infra21:30
dmsimarda venv or a docker container ? /me ducks21:30
corvusdmsimard: go for it21:30
corvusdmsimard: your assistance on this project is very welcome.21:31
mordreddmsimard: I actually owe a spec on starting to use containers for things21:31
*** armaan has joined #openstack-infra21:31
corvusdmsimard: perhaps you could push up a change to implement that?21:31
mordreddmsimard: maybe I'll get that written by the next meeting21:31
cmurphythe package name from the puppetlabs repo is puppet-agent not puppet so it won't conflict with the distro package named puppet21:32
clarkbpabelanger: odd that bionic shows up in dists but not pool21:33
clarkbpabelanger: just not populated with content yet I guess21:33
pabelangerclarkb: yah, same thought21:34
corvuspabelanger, clarkb, cmurphy: so the only puppet option is puppet5 in the distro, right?21:34
clarkbcorvus: as of right now from what I can tell correct21:34
dmsimardcorvus: I was half friday trolling but really though, between running xenial-based container images on bionic systems and switching from puppet to ansible...21:35
clarkbdmsimard: I think you've got that backwards, it would be bionic container on xenial21:35
corvuspabelanger, clarkb, cmurphy: is there any chance that might work, like, is it worth trying that out in a job real quick21:35
pabelangermaybe setup PPA a rebuild puppet (4.10.4-2ubuntu3) bionic; urgency=medium, that was previous version21:35
pabelangerthen figure out puppet 5 issue21:35
clarkbcorvus: cmurphy has a set of puppet4 chagnes up, most of them are largely mechnical21:35
dmsimardclarkb: yeah21:35
clarkbcorvus: I'm told the delta between puppet 4 and 5 is much smaller than the delta between 3 and 521:36
clarkbcorvus: so we mgiht add a puppet5 job to go along cmurphy's port work?21:36
*** felipemonteiro_ has quit IRC21:36
pabelangerdmsimard: if voting, I'd ansible before containers for me21:36
corvusdmsimard: yeah, i'm just really tired of having this conversation in a trolling way.  we've talked about it enough and we're willing to evaluate something like that on the merits.  i'd really rather not see any more about it until there's a spec up to talk about.21:36
*** kjackal has quit IRC21:36
pabelangerI'll rebase ansible spec this evening21:37
mordredand I will actually write the other one - probably this weekend21:37
*** salv-orlando has quit IRC21:37
clarkbcorvus: https://review.openstack.org/#/q/topic:puppet-4+status:open that set of changes give syou an idea of what needs updating21:37
*** salv-orlando has joined #openstack-infra21:38
corvusmostly our old friend scope.lookupvar :)21:38
clarkbcorvus: ya it is largely mechnical at this point with the ansible role update21:38
clarkbcorvus: assuming the ansible role will actually work with puppet4 fully21:38
clarkband then assuming puppet5 didn't create similar problems (I'm told it didn't but yet to be tested)21:38
cmurphyi haven't even been thinking about puppet 5 yet21:39
dmsimardcorvus: I've discussed ansibilization in a serious setting more than once with pabelanger and the software factory folks, we already have a lot of Ansible roles for openstack-infra things but it might not be generic enough. Between https://github.com/softwarefactory-project/sf-config/tree/master/ansible/roles, windmill, https://github.com/Logan2211/ci-stack and others, I genuinely wonder how much21:39
dmsimardwork it would be.21:39
corvusdmsimard: probably the most constructive thing would be to help make pabelanger's ansible spec and mordred's container spec as thorough as possible so we can make a good choice21:40
clarkbcorvus: ++21:40
corvusclarkb, cmurphy, pabelanger: what does the puppet_version: 4 job variable do?21:41
clarkbcorvus: it tells install_puppet.sh in system config to install puppet 4 instead of puppet 321:41
*** e0ne has quit IRC21:41
clarkbcorvus: you'll need to start there for using puppet 5 I bet (largely a noop on bionic though since its the distro package)21:41
dmsimardcorvus: sure, I haven't been part of the discussions that would lead to mordred's spec so I'm curious to see how that will pan out but pabelanger's https://review.openstack.org/#/c/469983/ is bookmarked21:42
openstackgerritMonty Taylor proposed openstack-infra/project-config master: Add new project pbrx  https://review.openstack.org/56489621:42
openstackgerritMonty Taylor proposed openstack-infra/project-config master: Add pbrx to zuul  https://review.openstack.org/56489721:42
*** salv-orlando has quit IRC21:42
clarkbdmsimard: one thing to keep in mind is that nodepool and zuul are the easy things. Its the everything else long tail that makes things difficult21:42
mordreddmsimard: I'll ping you as soon asI've got a draft21:42
corvusthinking about patterns makes that tractable21:42
*** salv-orlando has joined #openstack-infra21:42
corvuslike "a server that runs a python service fronted by apache"21:43
dmsimardclarkb: yeah that's why I mentioned the software factory roles. We have logserver (with os_loganalyze), mqtt, ELK, grafana, etc21:43
mordredI actually started being the 'let's use us some containers' because of gerrit :)21:43
fungietherpad (nodejs), gerrit (java), mediawiki (php) and so on21:43
*** boden has quit IRC21:43
pabelangereven if we agreed on ansible, i don't think we'd want to just write thing as fast a possible. we'd likely want to go system by system and establish a method to how our roles work. Oh and testing for sure...21:44
fungimordred: gerrit's already in a container21:44
fungiwell, a java virtual machine anyway21:44
mordredfungi: not enough of one21:44
fungiyeah, the jvm fails to contain some bits of gerrit21:45
mordredfungi: it's the fact that java itself is tied to distro release that eventually made me grok containers as a replacement for rpm/dpkg in these contexts21:45
pabelangerdmsimard: how open is SF in porting them to ubuntu or even multi distro support might be a good question to find out21:45
pabelangerthat's been a tricky thing for our puppet modules today21:45
*** yamamoto has joined #openstack-infra21:46
mordredpabelanger: this is the other reason I became a fan of the idea of using containers as packaging format :)21:46
fungithis way we get to port everything to alpine21:47
clarkbfungi: good thing I've got a patch up to bindep to make that possible :)21:47
dmsimardpabelanger: I could be wrong but I don't suppose SF would object to supporting more than CentOS as a deployment target if someone shows up -- but a lot of the SF works is about packaging, too. So yum install zuul, etc.21:47
pabelangermordred: yah, until we bikeshed on the container version :) But agree21:48
openstackgerritAnita Kuno proposed openstack-infra/system-config master: This patch impliments the survey spec: I3c389596373b94459a32a4e540d514a2941acbb1  https://review.openstack.org/55797921:48
dmsimardjust like OSA didn't support CentOS until a cycle or two ago21:48
mordredpabelanger: my bikeshed color is "use the python:slim based container image"21:49
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Support puppet 5 on ubuntu  https://review.openstack.org/56489821:49
pabelangerdmsimard: right, supporting both git / package, dnf / apt, all things to discuss21:49
pabelangereither way, let me rebase spec tonight and we can discuss more21:49
dmsimardpabelanger: ++21:50
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Support puppet 5 on ubuntu  https://review.openstack.org/56489821:52
*** yamamoto has quit IRC21:52
corvusclarkb, cmurphy, pabelanger: ^ does that look like it stands a chance? :)21:52
pabelangerthink so21:53
clarkbcorvus: and maybe depeonds on https://review.openstack.org/#/c/557515/ to get that set of fixes too21:54
clarkbbut otherwise ya21:54
openstackgerritJames E. Blair proposed openstack-infra/openstack-zuul-jobs master: Add infra apply-puppet-bionic job  https://review.openstack.org/56489121:55
openstackgerritJames E. Blair proposed openstack-infra/system-config master: Support puppet 5 on ubuntu  https://review.openstack.org/56489821:56
cmurphycorvus: seems reasonable21:56
openstackgerritJames E. Blair proposed openstack-infra/openstack-zuul-jobs master: Add infra apply-puppet-bionic job  https://review.openstack.org/56489121:57
openstackgerritAnita Kuno proposed openstack-infra/system-config master: This patch impliments the survey spec: I3c389596373b94459a32a4e540d514a2941acbb1  https://review.openstack.org/55797921:59
openstackgerritMonty Taylor proposed openstack-infra/project-config master: Add new project pbrx  https://review.openstack.org/56489622:02
*** rlandy has quit IRC22:04
openstackgerritMerged openstack-infra/zuul master: Coerce MappingProxyTypes in job vars to dicts  https://review.openstack.org/56488622:04
dmsimardmordred: for https://review.openstack.org/#/c/564896/, do you want gerritbot ?22:04
*** edmondsw has quit IRC22:06
mordreddmsimard: dunno- I'm not sure where, if anywhere, that should go yet - so I left it off for now22:06
dmsimardk22:06
mordreddmsimard: (it's still a young enough thing I'm not sure how useful it'll become to people and don't want to make assumptions)22:06
*** dave-mcc_ has quit IRC22:07
*** bobh has quit IRC22:13
openstackgerritAnita Kuno proposed openstack-infra/system-config master: This patch impliments the survey spec: I3c389596373b94459a32a4e540d514a2941acbb1  https://review.openstack.org/55797922:18
openstackgerritPaul Belanger proposed openstack-infra/nodepool master: Fix nodepool-launcher systemd file  https://review.openstack.org/56490122:18
*** agopi is now known as agopi|out22:20
openstackgerritMerged openstack-infra/project-config master: Add new project pbrx  https://review.openstack.org/56489622:22
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Fix zuul systemd files  https://review.openstack.org/56490322:28
openstackgerritColleen Murphy proposed openstack-infra/puppet-meetbot master: Convert httpd::vhost to apache::vhost::custom  https://review.openstack.org/56490422:28
*** camunoz has quit IRC22:29
*** Goneri has quit IRC22:35
*** jroll has quit IRC22:41
*** salv-orlando has quit IRC22:41
*** salv-orlando has joined #openstack-infra22:42
corvusinfra-root: hows about i restart zuul again?22:43
clarkbcorvus: I am finishing up late lunch can assist if it helps22:43
corvusclarkb: slash early dinner :)22:43
*** agopi|out has quit IRC22:44
fungisounds good, i'm still fairly around though beginning to wind down22:44
corvusi'll get started now22:44
corvusi'll just restart the scheduler again22:44
*** caphrim007_ has quit IRC22:45
clarkbcorvus: I actually decided it was snack time so I can make ramen in another hour or so for proper early dinner :)22:45
*** caphrim007 has joined #openstack-infra22:45
corvusmaybe i'll reward myself with a snack if zuul actually works this time22:46
*** salv-orlando has quit IRC22:46
clarkbsun noodle makes fresh ramen noodle packs that I tend to make a quick kombu broth for then add in some veggies. quite good22:46
corvusclarkb: what's 'make a quick kombu broth' entail?22:47
clarkbcorvus: seaweed in water for a soak then boil it for a short time. I thne use the flavor pack from the packaging with that instead of plain hot water22:47
*** yamamoto has joined #openstack-infra22:47
clarkbmakes it taste a bit like the ocean22:48
corvusneat22:48
*** eernst has quit IRC22:48
corvusscheduler is up22:48
clarkbI should pick a weekend where I make a proper broth from scratch but enotime22:49
fungiyeah, presumably the same method you'd use to make a kombu dashi22:49
clarkbfungi: ya thats basically it22:50
fungiif you can get your hands on dried shiitake, soak those in cold water until they soften and add the water you drain off into the broth22:50
corvusZuul version: 3.0.3.dev22 e82db1222:50
fungithat looks promising22:50
clarkbsha1 checks out22:50
*** dhill_ has quit IRC22:51
fungiyeah, matches what's checked out on zuul0122:51
corvusno unexpected tracebacks since the restart (only one for reporting to a closed change in gerrit)22:51
clarkbhttp://zuul.openstack.org/stream.html?uuid=d0110bf8562a43f6a1ed574b9920f14b&logfile=console.log that job is running22:51
*** lbragstad has quit IRC22:51
fungiclarkb: i have a great book on dashi methods if you want a recommendation for your shelf. i've found it excellent22:52
clarkbhttp://cacti.openstack.org/cacti/graph.php?action=view&local_graph_id=64792&rra_id=all is the graph to watch22:52
clarkbfungi: yes, please22:53
*** yamamoto has quit IRC22:53
*** caphrim007_ has joined #openstack-infra22:53
corvusre-enqueue is finished22:53
clarkbcorvus: I kinda want to push up a big stack of config changes now :)22:54
corvuswe're at 437880 rss22:54
corvusclarkb: i have 13 old ones sitting around, i was thinking of rechecking those22:54
clarkbya its doing well. I want to say when I did previous restarts it quickly climbed to 2gb and beyond22:54
*** Nil_ has quit IRC22:54
clarkbcorvus: ++22:55
fungiclarkb: "dashi and umami: the heart of japanese cuisine" (eat-japan/cross media ltd)22:55
fungiclarkb: it covers a lot about flavor theory as well22:55
fungiand has excellent photography22:55
clarkbfungi: amazon tells me I'm not getting it for cheap anytime soon22:55
clarkbI'll have to look for it in used book stores22:55
fungioh, too bad22:55
clarkb$348 is cheapest amazon option22:56
*** hongbin_ has quit IRC22:56
openstackgerritColleen Murphy proposed openstack-infra/puppet-etherpad_lite master: Fix scope of vhost template variables  https://review.openstack.org/56488422:56
clarkbfungi: it must be good :)22:56
fungicover price on the edition i got was ¥5500 or £2522:56
fungihardcover22:56
*** caphrim007 has quit IRC22:57
fungiso, like, 10% of what it seems to be going for these days22:57
fungithat's nuts22:57
fungiit _is_ a great reference though22:58
corvusokay i rechecked those 13 changes; no significant change in memory usage so far22:58
corvusthough they aren't a stack, so it's a bit hard to tell if they all made it in or got bounced out for merge conflicts22:58
corvusmaybe i'll make some synthetic ones real quick22:58
clarkbcorvus: there was a slight bump in total system usage according to free -m22:58
clarkbbut from 880MB to 905MB22:58
clarkbres currently at 460xyz22:59
*** caphrim007_ has quit IRC22:59
*** caphrim007 has joined #openstack-infra22:59
corvusshall i try for 20 changes?22:59
clarkbI'm game23:00
fungiyeah, utilization's a trifle of what we see it get up to normally anyway23:00
fungiseems safe23:00
corvushttps://review.openstack.org/#/q/topic:zuul-test23:01
clarkbit appeas to be spinning the cpu to process them23:02
clarkbbut memory hasn't skyrocketed yet23:02
clarkb(slightly up)23:02
corvuscreating the layouts is taking about 4 seconds each23:02
clarkbcorvus: is that good or bad relative to the old system?23:03
corvusi'll have to look up the old times, but it's not worrying at least :)23:03
*** caphrim007 has quit IRC23:03
*** r-daneel has quit IRC23:04
corvusclarkb: i think they're all loaded now23:04
clarkbcorvus: there was a jump up to 525MB or so res23:05
clarkbwhich is still quite reasonable compared to before I think23:05
clarkbdefinitely seems less hungry than in the past23:05
corvuslooks like building a layout was about 22 seconds before23:06
*** fried_rice is now known as efried23:06
clarkbwow23:06
fungiyikes23:06
corvusso that's a nice improvement; should mean for less "dead" time23:06
clarkbya I guess even if the memory wins are massive the load time wins are good23:07
fungiwhat was the main line of work which led to that improvement, do you think?23:07
corvusthere's much less yaml parsing and schema validtion now23:07
*** eernst has joined #openstack-infra23:07
pabelangercorvus: nice work!23:07
clarkbya that happens upfront and as long as the yaml parsed data structures aren't invalidated in cache they continue to be used23:07
corvus(i mean, there's less *repeated* parsing and validation :)23:07
clarkband then the actual config layer over the top is what mutates23:07
fungireducing redundant parsing and validation sounds great to me23:07
pabelangernow I'm really curious how small of a scheduler we could use :D23:08
pabelangerguess time will tell23:09
corvuspabelanger: yeah, i'd like to shrink it once we get a feeling for how this behavios23:09
pabelangerexciting23:09
clarkblooking at cacti it appears we typically need up to a week to reach steady state memory consumption23:09
corvusand there's no telling if this introduced a leak or something too, so that's something to watch out for23:10
corvusshould i push up another 20 changes?23:10
clarkbsure? it handled the first set just fine. Do we want to do an even bigger set?23:10
corvus(also, i mean while the first 20 are still there23:11
clarkbah23:11
clarkbsure23:11
fungiyeah, let's see if it holds up23:11
corvuspushed23:11
corvusthe jobs on the first change haven't even started yet, so they're all still in the queue23:12
corvusthis status page is not going to be nice to our browsers though23:13
clarkbfirefox has been handling it pretty well in recent releases23:13
clarkbI can scroll on it and only takes half a second to render the current location23:14
clarkbcorvus: while I'm thinking about it https://review.openstack.org/#/c/535713/ is ready for review and touches similar code if you want to reviwe it while its fresh23:15
clarkbcorvus: and for puppet 5 looks like install_modules.sh also has a puppet version checker we need to flip for supporting puppet 523:18
clarkbotherwise your job seems to be doing the right thing up to that point23:18
clarkbfungi: wow tallboy23:18
openstackgerritAnita Kuno proposed openstack-infra/system-config master: This patch impliments the survey spec: I3c389596373b94459a32a4e540d514a2941acbb1  https://review.openstack.org/55797923:19
*** dpawlik has joined #openstack-infra23:19
*** hashar has quit IRC23:19
corvusclarkb, fungi: it looks like it may be creating more layouts than i'm expecting23:20
corvusi see it creating repeated layouts for the same changes23:20
fungihrm23:23
fungias in, it's logging that it's doing so?23:23
corvusyep23:23
openstackgerritFatih Degirmenci proposed openstack-infra/zuul master: Add CentOS 7 environment setup instructions  https://review.openstack.org/56494823:24
*** dpawlik has quit IRC23:24
clarkbI see it creating layouts but haven't quite figured out how to tie that back to changes in the logs yet23:24
clarkbzuul.Pipeline.openstack.check: Freezing job graph for maybe?23:24
corvus2018-04-27 23:23:07,085 DEBUG zuul.Pipeline.openstack.check: Preparing dynamic layout for: <Change 0x7f8b33c38be0 564906,1>23:25
corvusit's looking like it's factorial.  906.  906, 907.  906, 907, 908.23:25
*** nicolasbock has quit IRC23:25
openstackgerritFatih Degirmenci proposed openstack-infra/zuul master: Add CentOS 7 environment setup instructions  https://review.openstack.org/56494823:26
clarkboh is this like the merge problem?23:26
clarkbwhen we have a stack of changes it does the whole stack each time23:26
clarkbfor each step throug the list of changes23:26
corvusyeah, but it's not supposed to do that for layouts; it *is* supposed to do the factorial merge, but then the results from that should feed into one layout per change23:27
*** adrianreza has quit IRC23:28
fungihave you been able to tell whether it's just dependent changes/pipelines or independent as well?23:28
corvusthis is a stack of dependent changes in check23:29
fungiokay, so it's redoing the intermediate layouts sounds like23:30
corvusyeah23:30
*** eernst has quit IRC23:32
clarkbreading the code its definitely going to call getLayout on each item. So I guess its up to the caching mechanism to make sure we don't do it N! times23:32
corvusclarkb: right but that should only happen once per item23:33
clarkbya23:33
corvusoooooh23:34
corvusare we making dynamic layouts for non-live items23:34
clarkbcorvus: ya I think that is it23:34
clarkbfor if you have 1<-2<-3 when its processing 3 its loading 1 and 2 which are not live too23:34
fungithat would make sense23:35
corvusokay, so this probably isn't a regression23:35
corvuswe've just probably never pushed 40 dependent dynamic layout changes to notice this before :)23:35
fungiso opportunity for more performance enhancement i suppose23:35
clarkbprocessonitme23:35
clarkb*-processOneItem() is the source of this I think23:36
corvusso... are we going to have 820 layouts in memory?23:36
fungicould explain the sudden memory jumps we've been unable to track down up to now?23:37
corvusfungi: well, usually we don't have very many .zuul.yaml changes depending on each other.23:37
corvusand probably the cpu use before would have made it appear completely dead.23:38
fungiahh23:38
corvusit looks like it's up to change 34 out of 46; so... we're about half done :)23:39
corvus(er, change number 934 and 946)23:39
*** eernst has joined #openstack-infra23:39
corvuswe could let this continue, and then we will have the results from one heck of a stress test, or i could restart it and drop this part of the queue23:40
*** edmondsw has joined #openstack-infra23:40
*** jroll has joined #openstack-infra23:40
clarkbthe fact it hasn't broken yet is impressive. Also memory usage has dropped23:40
clarkbI'm still trying to figure out where we recurse into the non active items for certain23:41
openstackgerritFatih Degirmenci proposed openstack-infra/nodepool master: Add systemd drop-in file for CentOS 7  https://review.openstack.org/56487223:41
clarkbaha its for item in queue.queue[:]:23:41
clarkbin processQueue because each change with its parents its own queue in check iirc23:41
corvus'live' not 'active' i think23:42
clarkbah right active means you are running jobs right now23:42
clarkband looking at gate it seems to skip those properly23:42
*** salv-orlando has joined #openstack-infra23:42
corvusyeah, active is the window23:42
clarkbso ya processQueue in the pipeline manager is doing it with the above for loop. I bet we address this by reusing a layout if its been produced23:43
clarkbwe check if not item.layout in prepareJobs() so we must use distinct items across different queues. Maybe we keep a layout cache in the pipeline manager though and check that too23:44
clarkbif not item.layout and not layouts.get(item): type deal23:44
corvusi'm not sure that's the solution... i think it's simpler actually, i don't think the non-live items need a layout23:44
clarkboh right since git will already "layer" things in for us23:44
corvusso if we can just convince them to skip layout generation and only do it on the live one, that should work.  the live one will, by virtue of having performed the merge of all the changes ahead... exactly :)23:44
*** edmondsw has quit IRC23:45
clarkbif not item.layout and item.live: getLayout()23:45
clarkbroughly at prepareJobs() in pipeline manager23:45
corvusyeah, we may need a return True in there if not item.live, to allow it to proceed past that23:46
corvusbut i *think* that's about it23:46
*** salv-orlando has quit IRC23:46
corvus8 changes to go23:47
openstackgerritFatih Degirmenci proposed openstack-infra/zuul master: Add steps to use systemd drop-in for Nodepool on CentOS 7  https://review.openstack.org/56495023:47
*** tosky has quit IRC23:47
*** eernst has quit IRC23:48
*** eernst has joined #openstack-infra23:48
*** yamamoto has joined #openstack-infra23:49
corvusi think we can probably let it just burn itself out; i think the risk is that if a config change lands before these finish, it'll do the whole thing again23:50
clarkbok did you want to throw that fix up today?23:50
corvusi'm inclined to leave it for later since it's not a regression23:51
corvuswork on a proper test, etc23:51
corvusi can restart zuul now and drop the 40 changes from the queue, or we can leave it and i can check back in a few hours and if they're still there, do it then23:52
clarkbok23:52
clarkbya lets wait and see23:52
fungiagreed23:52
clarkbsince the data it produces is useful23:52
*** jroll has quit IRC23:53
corvuswe are at ~630 layouts in memory, with 1.6G used23:54
*** yamamoto has quit IRC23:54
*** esberglu has quit IRC23:56
*** jroll has joined #openstack-infra23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!