Monday, 2023-10-23

opendevreviewAkihiro Motoki proposed openstack/horizon master: Specify transform=repr explicitly in assertQuerysetEqual()  https://review.opendev.org/c/openstack/horizon/+/89731005:22
opendevreviewAkihiro Motoki proposed openstack/horizon master: Specify transform=repr in assertQuerysetEqual()  https://review.opendev.org/c/openstack/horizon/+/89731005:25
opendevreviewAkihiro Motoki proposed openstack/horizon master: Django 4.2: Adjust instance detail template  https://review.opendev.org/c/openstack/horizon/+/89902106:43
amotokivishalmanchanda: django42 job is green now after patches from zigo and me are applied :-)07:22
zigoamotoki: Ah, GREAT ! :)07:22
vishalmanchandaawesome:)07:22
amotokihopefully this kind of things are handled by generative AI ;p07:23
zigoThis looks like a lot nicer than what I wrote, thanks for it.07:23
opendevreviewMerged openstack/horizon master: Specify transform=repr in assertQuerysetEqual()  https://review.opendev.org/c/openstack/horizon/+/89731008:26
opendevreviewVishal Manchanda proposed openstack/horizon master: [DNM] Add pytest-based jobs in the CI job  https://review.opendev.org/c/openstack/horizon/+/89902910:06
opendevreviewMerged openstack/horizon master: pytest-based selenium tests add compute, volume update defaults tests  https://review.opendev.org/c/openstack/horizon/+/89832710:18
opendevreviewMerged openstack/horizon master: Pytest based selenium test : Add volumes snapshot pagination tests  https://review.opendev.org/c/openstack/horizon/+/89879811:13
amotokivishalmanchanda: hi, is there any document to understand pytest-based selenium tests?12:47
janjasek__Hello amotoki, here is a brief explanation what are the main changes compared to current tests: https://etherpad.opendev.org/p/horizon-pytest12:50
amotokijanjasek__: thanks. more specifically, I would like to understand how arguments passed to each test function and how fixtures works. Is it better to read pytest doc first?12:51
amotokihorizon uses pytest but it is not common in OpenStack, so perhaps I need to learn it first before reviewing them...12:55
janjasek__Yes. I would recommend to you go through at least base pages what fixtures are, how to use them and how to use arguments. It is nicely described in pytest documentation: https://docs.pytest.org/en/stable/explanation/fixtures.html12:58
janjasek__amotoki, I am planning to describe it very briefly also tomorrow in our PTG meeting. How we use fixtures combined with openstack SDK, etc.13:00
amotokijanjasek__: thanks. it would be helpful :-)13:00
opendevreviewMerged openstack/horizon master: pytest-based selenium tests add floatingips tests + add instance params  https://review.opendev.org/c/openstack/horizon/+/89883514:32
opendevreviewJan Jasek proposed openstack/horizon master: pytest-based selenium tests add group create, delete, edit tests  https://review.opendev.org/c/openstack/horizon/+/89907515:25
opendevreviewJan Jasek proposed openstack/horizon master: pytest-based selenium tests add volumetypes/qos create, delete tests  https://review.opendev.org/c/openstack/horizon/+/89909823:59

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!