| vishalmanchanda | zigo: hello. | 03:54 |
|---|---|---|
| vishalmanchanda | zigo: yes. I am working for NEC, Technical Lead. | 03:55 |
| opendevreview | Tobias Urdin proposed openstack/horizon master: Fix allowed address pair row unique ID https://review.opendev.org/c/openstack/horizon/+/893650 | 05:58 |
| zigo | vishalmanchanda: Thanks! | 06:13 |
| *** kopecmartin|off is now known as kopecmartin | 07:04 | |
| opendevreview | Thomas Goirand proposed openstack/horizon master: Use repr to compare with objects https://review.opendev.org/c/openstack/horizon/+/897209 | 10:20 |
| opendevreview | Thomas Goirand proposed openstack/horizon master: WIP: Use repr to compare with objects https://review.opendev.org/c/openstack/horizon/+/897209 | 10:21 |
| zigo | vishalmanchanda: amotoki: Your thoughs on this patch, before I finalise it (ie: fix all the pep8 thingy...)? | 10:22 |
| zigo | I also have another class of unit test failures like this one: https://paste.opendev.org/show/bw2T7UqOprvtqutx2cCr/ | 10:24 |
| zigo | More than 100 failures of this type, and I have no idea what's going on. Any clue? | 10:24 |
| vishalmanchanda | zigo: hello, Could you please if your issue fixed by patch https://review.opendev.org/c/openstack/horizon/+/894390 ? | 10:48 |
| zigo | Ah, that's what I thought ... it's Django 4 related. Thanks for the hint! | 11:46 |
| zigo | vishalmanchanda: Trying the patch right away. | 11:47 |
| zigo | vishalmanchanda: It's much nicer, I have only 10 failures remaining now ! :) | 12:04 |
| zigo | Some being selenium related (and I don't do Selenium tests in my package, so I need to blacklist them correctly ...). | 12:05 |
| zigo | I have only one single unit test failure now, after adding the patch from vish above, plus my own for the repr() calls. Here's the failure: | 14:07 |
| zigo | https://paste.opendev.org/show/bC5TQnWmnd05DV9QiXut/ | 14:07 |
| zigo | Note: this is on Django 4... | 14:08 |
| opendevreview | Merged openstack/horizon master: pytest-based selenium tests add flavor create, delete tests https://review.opendev.org/c/openstack/horizon/+/897010 | 23:30 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!