| opendevreview | Vishal Manchanda proposed openstack/xstatic-angular-fileupload master: Update .gitreview file https://review.opendev.org/c/openstack/xstatic-angular-fileupload/+/889673 | 05:10 |
|---|---|---|
| opendevreview | Vishal Manchanda proposed openstack/xstatic-angular-fileupload master: Update .gitreview file https://review.opendev.org/c/openstack/xstatic-angular-fileupload/+/889673 | 05:13 |
| opendevreview | Vishal Manchanda proposed openstack/xstatic-angular-fileupload master: Update .gitreview file https://review.opendev.org/c/openstack/xstatic-angular-fileupload/+/889673 | 08:29 |
| opendevreview | Merged openstack/xstatic-angular-fileupload master: Update .gitreview file https://review.opendev.org/c/openstack/xstatic-angular-fileupload/+/889673 | 14:23 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jul 26 15:00:17 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:00 |
| tmazur | o/ | 15:00 |
| vishalmanchanda | hello everyone | 15:01 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:01 |
| vishalmanchanda | let's start the meeting | 15:01 |
| vishalmanchanda | #topic Notices | 15:01 |
| vishalmanchanda | A casual reminder about the release, this week is R-10 week. | 15:02 |
| vishalmanchanda | We have one month left for the feature freeze. | 15:02 |
| vishalmanchanda | For more info. about schedule please refer https://releases.openstack.org/bobcat/schedule.html | 15:03 |
| vishalmanchanda | moving to the next announcement | 15:04 |
| vishalmanchanda | release team purposed a patch to cut a new release of horizon for the stable/yoga branch. | 15:04 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/889457 | 15:04 |
| vishalmanchanda | So please check if we can merge the open patches in stable/yoga branch to include in above release. | 15:05 |
| vishalmanchanda | https://review.opendev.org/q/project:openstack/horizon+branch:stable/yoga+status:open | 15:05 |
| vishalmanchanda | I have no other announcement for this week. | 15:06 |
| vishalmanchanda | moving to next topic | 15:06 |
| vishalmanchanda | #topic Release priorities | 15:06 |
| vishalmanchanda | Updating xstatic-jQuery version | 15:07 |
| vishalmanchanda | As you already know, now horizon is using XStatic-jQuery===3.3.1.1 version | 15:07 |
| vishalmanchanda | also, horizon-integration job is also voting and passing. | 15:07 |
| vishalmanchanda | So IMO that thing is completed now. | 15:08 |
| vishalmanchanda | We can also update upper-constraints to use XStatic-jQuery =3.5.1.1 | 15:08 |
| vishalmanchanda | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L80 | 15:08 |
| vishalmanchanda | We can also remove capping in ``gloabl-requirements.txt`` file for xstatic-jQuery | 15:09 |
| vishalmanchanda | https://github.com/openstack/requirements/blob/master/global-requirements.txt#L385 | 15:09 |
| vishalmanchanda | rdopiera: tmazur what you think, should we bump the version to 3.5.1.1? | 15:10 |
| rdopiera | vishalmanchanda: yes, there were some CVEs | 15:10 |
| vishalmanchanda | rdopiera: ok, I will purpose a patch for updating the version. | 15:11 |
| rdopiera | thank you | 15:11 |
| vishalmanchanda | yw | 15:11 |
| vishalmanchanda | after that we can close the bug https://bugs.launchpad.net/horizon/+bug/1955556 | 15:12 |
| tmazur | yes | 15:12 |
| vishalmanchanda | because all the libraries are updated in horizon now mentioned in that bug | 15:13 |
| vishalmanchanda | great | 15:13 |
| vishalmanchanda | thanks everyone for helping in that migration. | 15:13 |
| vishalmanchanda | One question here rdopiera do you want to add horizon-integration job which runs with chrome browser as non-voting? | 15:14 |
| rdopiera | vishalmanchanda: I was thinking about it, but it would further slow down our tests | 15:15 |
| rdopiera | that vm is already super slow | 15:15 |
| vishalmanchanda | hmm. | 15:15 |
| vishalmanchanda | moving to next topic | 15:16 |
| rdopiera | I have some proposals to discuss to speed up our tests, maybe we can add chromium once they are faster | 15:16 |
| vishalmanchanda | nice | 15:16 |
| vishalmanchanda | rdopiera: anything you want to discuss about that now, please go ahead. | 15:18 |
| rdopiera | thank you | 15:19 |
| rdopiera | I wrote a summary of the possbile changes here: https://etherpad.opendev.org/p/horizon-pytest | 15:20 |
| rdopiera | we would like to start writing the new tests in a new directory in openstack_dashboard/tests, so that we can use conftest.py to provide local pytest config | 15:20 |
| vishalmanchanda | nice | 15:21 |
| rdopiera | I'm thinking of using openstack_dashboard/tests/integration and openstack_dashboard/selenium (the latter for the gui tests that use mocks) | 15:21 |
| rdopiera | we wouldn't run them on the gate until the are done | 15:21 |
| rdopiera | once they are done, they would replace the current jobs | 15:22 |
| vishalmanchanda | ok | 15:22 |
| vishalmanchanda | I will go through the etherpad summary. | 15:24 |
| vishalmanchanda | I am looking at release-priorities etherpad at Line 13 and just want to know the status if anyone is working on it. | 15:26 |
| vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities#L13 | 15:26 |
| vishalmanchanda | First item is almost completed now XStatic and JS dependencies | 15:27 |
| vishalmanchanda | Second one Consistent and Secure Default RBAC is not a priority thing for us now. | 15:27 |
| rdopiera | maybe we should remove it? | 15:27 |
| vishalmanchanda | rdopiera: yeah, I will do that | 15:28 |
| vishalmanchanda | Third Improve integartion test and add more integartion test for angular view I guess your new pytest thing covering it https://etherpad.opendev.org/p/horizon-pytest | 15:29 |
| rdopiera | yes | 15:30 |
| vishalmanchanda | Next thing, I don't know if anyone is working on updating memcached and SCSS libraries. | 15:31 |
| rdopiera | memcached is just a question of adding the new library to requirements, changing the default settings, and coordinating with packagers to include it | 15:31 |
| vishalmanchanda | ok | 15:33 |
| rdopiera | it's django.core.cache.backends.memcached.PyLibMCCache | 15:34 |
| vishalmanchanda | actually, I am unable to recall what exactly we have to do for memcahed. | 15:34 |
| rdopiera | right now we are using django.core.cache.backends.memcached.PyMemcacheCache which had some problems (unmaintained? didn't work with newer python? can't remember) | 15:36 |
| rdopiera | but all other openstack projects are using pylibmc | 15:36 |
| rdopiera | ah, now I remember | 15:36 |
| rdopiera | PyMemcacheCache doesn't support ssl connections | 15:37 |
| vishalmanchanda | ok so we want to switch to pylibmc from memcached? | 15:37 |
| rdopiera | yes, we want pylibmc to be consistent with other projects and to be able to use an encrypted connection | 15:37 |
| rdopiera | and I think there was also an ipv6 support problem | 15:38 |
| rdopiera | in any case, everyone else is using pylibmc, so we will remove one more dependency from openstack this way | 15:38 |
| vishalmanchanda | https://github.com/openstack/horizon/blob/0f58e59e92039fe107d3959200f5d92699fcf15f/test-requirements.txt#L15 | 15:38 |
| vishalmanchanda | got it. | 15:39 |
| vishalmanchanda | rdopiera: Could you please add all these details at Line 22 https://etherpad.opendev.org/p/horizon-release-priorities#L21 | 15:39 |
| rdopiera | sure | 15:39 |
| vishalmanchanda | anything else also if you remember, if any test patch you have pushed so far. | 15:40 |
| vishalmanchanda | rdopiera: thanks | 15:40 |
| rdopiera | the scss stuff needs more work | 15:41 |
| vishalmanchanda | yeah I remember your patch doesn't works with material theme | 15:42 |
| rdopiera | it has several problems, it was a quick hack | 15:42 |
| vishalmanchanda | I will rebase that patch on master in this week. | 15:42 |
| vishalmanchanda | what more issues? | 15:42 |
| vishalmanchanda | if you remember? | 15:43 |
| rdopiera | it's just hacky code, with a lot of quick workarounds | 15:44 |
| vishalmanchanda | lol | 15:44 |
| rdopiera | by the way, we have another option we could consider: use a command line scss compiler | 15:44 |
| rdopiera | the django-compress plugin supports that | 15:44 |
| rdopiera | we don't have to rely on python libraries then | 15:45 |
| vishalmanchanda | ok | 15:46 |
| rdopiera | I haven't tested it, though | 15:46 |
| rdopiera | I will try it | 15:46 |
| vishalmanchanda | I will also explore those option and will let you know. | 15:46 |
| vishalmanchanda | we basically wants to switch from pyScss? | 15:47 |
| rdopiera | yeah | 15:48 |
| vishalmanchanda | as it is unmaintained now? | 15:48 |
| vishalmanchanda | also don't work with django 3.x | 15:48 |
| rdopiera | switching to the official scss compiler would be best | 15:48 |
| vishalmanchanda | ok | 15:48 |
| vishalmanchanda | Next thing is horizon doesn't support setuptools 67.3.1 | 15:48 |
| vishalmanchanda | rdopiera: Do you know if that bug is fixed now after we release new version of xtstaic? | 15:49 |
| rdopiera | no idea | 15:49 |
| rdopiera | I couldn't reproduce it | 15:49 |
| rdopiera | the fix was based on some comments from python devs | 15:50 |
| vishalmanchanda | ok | 15:50 |
| vishalmanchanda | maybe we can ask here to kolla team https://review.opendev.org/c/openstack/kolla/+/876460 | 15:50 |
| vishalmanchanda | Any updates on "Integrate OpenStackSDK to prepare to python-*client deprecation" | 15:51 |
| rdopiera | well, we got openstack sdk working in our example tests | 15:52 |
| rdopiera | so we know how to use it now | 15:52 |
| vishalmanchanda | cool | 15:52 |
| rdopiera | but we still don't know how to integrate it with opestack_auth properly | 15:52 |
| rdopiera | and microversions are going to be fun | 15:53 |
| vishalmanchanda | you mean, you tested it locally in your downstream prod.? | 15:53 |
| rdopiera | we tested it by using it inside our example tests in that horizon-pytest patch | 15:53 |
| vishalmanchanda | ok got it. | 15:54 |
| rdopiera | but in actual horizon use we will need to create the connection object differently, from an existing session | 15:54 |
| rdopiera | it's supported, but we didn't try it yet | 15:54 |
| vishalmanchanda | you guys are working on cool stuff:) | 15:55 |
| rdopiera | and I'm not sure how well microversions are supported in openstack sdk, the docs are vague on that topic | 15:55 |
| vishalmanchanda | ok | 15:56 |
| vishalmanchanda | we are almost out of time | 15:57 |
| vishalmanchanda | moving to next topic | 15:57 |
| vishalmanchanda | #topic open-discussion | 15:57 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:57 |
| vishalmanchanda | I just want to raise some attention for a feature review https://review.opendev.org/c/openstack/horizon/+/885570 | 15:58 |
| vishalmanchanda | Add TOTP support | 15:59 |
| vishalmanchanda | The feature looks nice to me from user/operator point of view, if we can add it in horizon | 16:00 |
| vishalmanchanda | I am still exploring how to test it. | 16:00 |
| vishalmanchanda | Also, author is a new contributor in horizon. | 16:00 |
| tmazur | Does it require any special deploy to test? | 16:00 |
| vishalmanchanda | tmazur: yes. | 16:00 |
| vishalmanchanda | I found a nice video on you tube if you can take a look https://www.youtube.com/watch?v=JEniPHp1l74 | 16:01 |
| tmazur | thank you | 16:01 |
| vishalmanchanda | my env. is not setup yet, but let's see. | 16:02 |
| vishalmanchanda | thanks, everyone for joining. | 16:02 |
| vishalmanchanda | see you next week. | 16:02 |
| tmazur | o/ | 16:03 |
| vishalmanchanda | #endmeeting | 16:03 |
| opendevmeet | Meeting ended Wed Jul 26 16:03:36 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:03 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-26-15.00.html | 16:03 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-26-15.00.txt | 16:03 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-26-15.00.log.html | 16:03 |
| opendevreview | Merged openstack/horizon master: Fix deprecated use of 'jQuery.fn.select()' shorthand event https://review.opendev.org/c/openstack/horizon/+/883385 | 16:29 |
| opendevreview | Merged openstack/horizon master: Fix ports tab at Launch Instance dialog https://review.opendev.org/c/openstack/horizon/+/884640 | 16:53 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade at 21:00 utc, approximately an hour from now | 20:02 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a minor upgrade, but should return shortly | 21:01 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!