| zigo | vishalmanchanda: Could you review https://review.opendev.org/c/openstack/horizon/+/885570 ? | 06:55 |
|---|---|---|
| vishalmanchanda | zigo: Is this a feature of keystone added in horizon by your patch? | 07:04 |
| zigo | vishalmanchanda: Yeah. If a user has TOTP activated in Keystone, this patch makes it "just work" in Horizon. | 07:05 |
| zigo | Note: this is the patch of my colleague, I just helped him a little bit. | 07:05 |
| vishalmanchanda | zigo: ok, I will check the keystone doc for this feature. | 07:05 |
| zigo | Thanks. | 07:05 |
| zigo | My colleague is an intern, it'd be a cool achievement for him to show to his univercity report if it was merged... | 07:06 |
| zigo | (he probably will join Infomaniak after his internship...) | 07:06 |
| vishalmanchanda | nice. | 07:06 |
| vishalmanchanda | zigo: if you link of some doc. about this feature in keystone, how to enable this feature in keystone, please add those link in commit-msg, api-ref. | 07:09 |
| vishalmanchanda | it will help reviewers in reviews. | 07:09 |
| zigo | vishalmanchanda: The patch includes a small doc change, on how to configure Horizon itself, but probably a link to Keystone's doc (in the horizon doc) would be nice indeed. | 07:10 |
| vishalmanchanda | yes | 07:11 |
| zigo | If you don't mind, best would be to add this as a comment (I'm not supposed to work, I'm supposed to be on holidays, today is an exception) | 07:11 |
| vishalmanchanda | zigo: ok sure. | 07:11 |
| zigo | Thanks. | 07:12 |
| opendevreview | Jan Jasek proposed openstack/horizon master: [WIP] Rewrite integration tests using pytest format https://review.opendev.org/c/openstack/horizon/+/885070 | 11:29 |
| opendevreview | Jan Jasek proposed openstack/horizon master: [WIP] Rewrite integration tests using pytest format https://review.opendev.org/c/openstack/horizon/+/885070 | 19:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!