| opendevreview | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/886565 | 03:53 |
|---|---|---|
| opendevreview | Michel Nederlof proposed openstack/horizon master: Fix object-store container toggle for turning public access on/off https://review.opendev.org/c/openstack/horizon/+/884596 | 08:09 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 12:22 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 12:23 |
| zigo | rdopiera: Hi there! Is the CI still broken?!? I can't get any patch to verify. | 12:28 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 12:54 |
| rdopiera | zigo: yes | 12:55 |
| rdopiera | zigo: I hope that we can try running the integration tests with chromium, then we at least will get the javascript console logs, and that may shed some light on what the problem is exactly | 12:56 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 14:44 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 14:46 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jun 21 15:00:17 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:01 |
| vishalmanchanda | Hello everyone | 15:02 |
| vishalmanchanda | only two of us. | 15:04 |
| vishalmanchanda | let's start the meeting | 15:04 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:05 |
| vishalmanchanda | I have no announcements for this week. | 15:06 |
| vishalmanchanda | so moving to release priorities topic | 15:06 |
| rdopiera | o/ | 15:06 |
| vishalmanchanda | #topic Release priorities | 15:06 |
| vishalmanchanda | there is no update from my side on jQuery update. | 15:07 |
| vishalmanchanda | I am investigating the horizon integration job failure issue. | 15:07 |
| vishalmanchanda | I am unable to reproduce the issue in local env. | 15:08 |
| vishalmanchanda | Now I am trying to create a new devstack env. using debian-bullseye distribution which our gate CI is using. | 15:09 |
| vishalmanchanda | I tried to revert few of my jQuery changes but still random integration tests fails https://review.opendev.org/c/openstack/horizon/+/886244 | 15:10 |
| rdopiera | I'm thinking we could perhaps get more insight into the issue, if we got the javascript console logs. That is not possible with firefox, but I was thinking maybe we could add a non-voting job with chromium to our gate? | 15:10 |
| vishalmanchanda | rdopiera: ok, sounds good. | 15:11 |
| rdopiera | I proposed a patch that fixes some issues with chromium in our tests, but I have no idea where to even start with the new job | 15:11 |
| vishalmanchanda | rdopiera: what you want to run a integration job(non-voting) with chromium browser? | 15:12 |
| rdopiera | yes | 15:12 |
| rdopiera | on the tests side, we just need to set the SELENIUM_CHROME environment variable, but on the setup side we have to make sure chromium is installed | 15:13 |
| vishalmanchanda | what if we change default browser to chromium in ``karma.conf.js`` file. | 15:14 |
| rdopiera | where is that file? | 15:14 |
| vishalmanchanda | This is the patch where we switch to firefox browser. | 15:15 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/765865 | 15:15 |
| rdopiera | that's for angular unit tests | 15:16 |
| rdopiera | not for selenium | 15:16 |
| tmazur | Isn't it just for npm tests? | 15:17 |
| tmazur | Yeah | 15:17 |
| rdopiera | for integration tests, we just need SELENIUM_CHROME=1 in the environment variables | 15:18 |
| vishalmanchanda | oh, sorry my bad. | 15:18 |
| rdopiera | but chromium or chrome has to be installed on the vm | 15:18 |
| rdopiera | I don't know if it's currently installed by default | 15:18 |
| rdopiera | another thing we could try to at least get the patches merging again is to change the test that is failing to go to the settings page by entering an url in the location bar, instead of clicking on the menu | 15:22 |
| rdopiera | because right now it's the clicking on the menu that is failing | 15:22 |
| rdopiera | however, I think that will just expose further problems | 15:22 |
| rdopiera | if we are getting a javascript error and the menus stop working, then the tests will just fail in a different spot | 15:23 |
| vishalmanchanda | yeah we can merge atleast https://review.opendev.org/c/openstack/horizon/+/883953 | 15:26 |
| vishalmanchanda | for cirros image issue | 15:27 |
| rdopiera | if everything else fails, we could set the integration tests to non-voting | 15:28 |
| rdopiera | but I wouldn't want to do that | 15:29 |
| vishalmanchanda | yeah me too. | 15:31 |
| vishalmanchanda | Does this patch https://review.opendev.org/c/openstack/horizon/+/886260/6/horizon/test/webdriver.py change default browser to chrome? | 15:31 |
| rdopiera | no, it doesn't change the browser, it only fixes the download directory when using chrome | 15:32 |
| rdopiera | you still have to explicitly define SELENIUM_CHROME to use chrome | 15:32 |
| rdopiera | I can add a tox environemnt that does it? | 15:33 |
| vishalmanchanda | there is abandon patch which try to run integartion test with chrome | 15:33 |
| vishalmanchanda | please see if it helps you https://review.opendev.org/c/openstack/horizon/+/583093 | 15:33 |
| rdopiera | ooh, fancy, it has a --headless option, that means we wouldn't even need the xvfbwrapper | 15:34 |
| rdopiera | but I wouldn't want to just switch, preferably I would prefer to have a separate job | 15:35 |
| tmazur | Maybe we could have a non-voting job first? | 15:35 |
| tmazur | And then if it works we could switch? | 15:35 |
| rdopiera | just a non-voting job would give us the browser log file | 15:37 |
| rdopiera | so that would be a win | 15:37 |
| rdopiera | vishalmanchanda: I will add an environment to tox, and then we can add a job that runs it | 15:38 |
| vishalmanchanda | rdopiera: yes. | 15:38 |
| vishalmanchanda | I will help to add a new job that will use chrome browser. | 15:39 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Fix test_credentials for Chrome browser in integration tests https://review.opendev.org/c/openstack/horizon/+/886260 | 15:40 |
| rdopiera | now we have tox -e integration-chrome | 15:41 |
| rdopiera | it still uses the xvfbwrapper mechanism like with firefox | 15:42 |
| rdopiera | we can later improve it | 15:42 |
| vishalmanchanda | ok I will check how to add a new job which only use chrome browser for horizon integration job | 15:48 |
| vishalmanchanda | I have nothing more to discuss here. | 15:56 |
| vishalmanchanda | #topic open-discussion | 15:56 |
| vishalmanchanda | Does anyone have any topic to discuss? | 15:56 |
| rdopiera | thanks everyone | 15:59 |
| vishalmanchanda | thanks everyone for joining. | 16:00 |
| *** gthiemon1e is now known as gthiemonge | 16:00 | |
| vishalmanchanda | #endmeeting | 16:00 |
| opendevmeet | Meeting ended Wed Jun 21 16:00:23 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-21-15.00.html | 16:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-21-15.00.txt | 16:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-21-15.00.log.html | 16:00 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test horizon integartion with chrome browser https://review.opendev.org/c/openstack/horizon/+/886649 | 16:06 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test horizon integartion with chrome browser https://review.opendev.org/c/openstack/horizon/+/886649 | 16:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!