| opendevreview | Jan Jasek proposed openstack/horizon master: [WIP] Rewrite integration tests from scratch https://review.opendev.org/c/openstack/horizon/+/886089 | 12:08 |
|---|---|---|
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jun 14 15:00:15 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:01 |
| rdopiera | o/ | 15:01 |
| vishalmanchanda | Hello everyone | 15:01 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L32 | 15:02 |
| vishalmanchanda | let's start the meeting | 15:02 |
| vishalmanchanda | #topic Notices | 15:02 |
| amotoki | hi | 15:02 |
| vishalmanchanda | This week is OpenInfra Summit + PTG going on but no-one of us going there. | 15:03 |
| vishalmanchanda | I hope maybe next time we may travel for the PTG. | 15:04 |
| vishalmanchanda | moving to next announcement | 15:04 |
| vishalmanchanda | I have purposed a patch to move horizon stable/stein branch to EOL and send a mail on open-discuss and no objection is raised so far. | 15:05 |
| vishalmanchanda | https://review.opendev.org/c/openstack/releases/+/885109 | 15:05 |
| vishalmanchanda | we are good to move forward with moving horizon stable/stein branch to EOL. | 15:06 |
| vishalmanchanda | moving to next announcement | 15:06 |
| vishalmanchanda | I pushed a patch to Pin XStatic-Font-Awesome to <4.8.0.0 in openstack/requirements and it's also got merged. | 15:07 |
| vishalmanchanda | https://review.opendev.org/c/openstack/requirements/+/885159 | 15:07 |
| vishalmanchanda | Now I guess next thing is to identify and pin more Xstatic packages which are not horizon deliverables https://governance.openstack.org/tc/reference/projects/horizon.html to avoid any failures. | 15:09 |
| vishalmanchanda | that's all announcements from my side for this week. | 15:11 |
| vishalmanchanda | moving to next topic | 15:11 |
| amotoki | I am not sure pinning more xstatic packages makes sense or not | 15:11 |
| rdopiera | I think it does make sense for the data-only ones | 15:12 |
| amotoki | rdopiera: +1 | 15:12 |
| amotoki | is there no issue from rhosp perspective? perhaps rhosp and other rh deliverables do not include moinmoin who is the other major user of xstatic, so it would not be a problem | 15:13 |
| amotoki | I don't know the situation around ubuntu and debian | 15:14 |
| vishalmanchanda | I think we can watch if automatic update of any Xstatic package break horizon and then decide if we need those update or not. | 15:16 |
| rdopiera | yeah, we don't care about the moin moin wiki | 15:17 |
| amotoki | oen question: what is the actual problem around xstatic-font-awesome and is it documented somewhere? (launchpad bug or anywhere is okay) | 15:18 |
| rdopiera | I didn't think about the situation of distros that need it | 15:18 |
| rdopiera | the problem is that when it was upgraded, the names/paths were changed for no apparent reason | 15:18 |
| amotoki | I see. it sounds a good reason to block the new version, but perhaps we need to make it searchable/findable anywhere. | 15:20 |
| amotoki | how about filing a horizon bug and add a comment on it to g-r? | 15:21 |
| vishalmanchanda | https://zuul.opendev.org/t/openstack/build/e5dd3c8fced64cf2b95ecc2d50bc0827/log/job-output.txt#20091 | 15:21 |
| rdopiera | the files used to be named fontawesome.css and now are named font-awesome.css | 15:22 |
| vishalmanchanda | amotoki: ok, I will open a open bug for that in horizon launchpad for future reference. | 15:22 |
| vishalmanchanda | There is not much update on jQuery migrate this week. | 15:24 |
| vishalmanchanda | Only one patch is not merged yet https://review.opendev.org/q/topic:update-jquery+status:open | 15:25 |
| vishalmanchanda | I was waiting for https://review.opendev.org/c/openstack/horizon/+/883953 to get merged to fix the CI. | 15:25 |
| vishalmanchanda | but horizon-integration jobs fails too much. | 15:26 |
| rdopiera | we looked into those failures a bit | 15:26 |
| rdopiera | it seems it's failing when it clicks on the user menu to go to the settings page | 15:26 |
| rdopiera | somehow the menu never opens | 15:26 |
| vishalmanchanda | here you can find summary of failed tests https://etherpad.opendev.org/p/random-failed-horizon-integration-tests | 15:27 |
| rdopiera | I suspect a javascript error, but firefox doesn't let us retreve the javascript error logs, so we don't know | 15:27 |
| tmazur | for different tests it's the same problem apparently: that user menu dropdown doesn't open | 15:28 |
| rdopiera | we looked at several different failures, they all fail trying to click that menu | 15:28 |
| rdopiera | of course we can't reproduce it locally | 15:31 |
| vishalmanchanda | hmm, what we should do now? | 15:31 |
| rdopiera | I'm looking for a workarund to get js errors somehow, by using an error callback | 15:32 |
| rdopiera | we could also switch to chromium... | 15:33 |
| vishalmanchanda | ok, we can try that. | 15:33 |
| vishalmanchanda | I am just wondering if these issue happening due to my jQuery update patches. | 15:34 |
| vishalmanchanda | https://review.opendev.org/q/topic:update-jquery | 15:34 |
| rdopiera | it is possible, but it's hard to tell without seeing the error | 15:34 |
| rdopiera | you can try and see if you can reproduce it locally | 15:35 |
| vishalmanchanda | unfortunately I am unable to run integration job locally on my env. but I will try again today. | 15:36 |
| rdopiera | manual reproducer would work too, anything that lets you see the error | 15:37 |
| tmazur | I am going to try on my other env too | 15:37 |
| rdopiera | it's random, so there must be some kind of a race condition perhaps | 15:37 |
| vishalmanchanda | ok, yeah. | 15:37 |
| vishalmanchanda | If we look at this data https://etherpad.opendev.org/p/random-failed-horizon-integration-tests | 15:38 |
| vishalmanchanda | "test_instances_pagination" integration test fails too much | 15:39 |
| tmazur | We've checked test_logout failure, and it's the same issue with that menu | 15:39 |
| vishalmanchanda | tmazur: yes | 15:40 |
| tmazur | But yeah, it seems pagination triggers it way more often | 15:40 |
| vishalmanchanda | should we avoid recheck now on https://review.opendev.org/c/openstack/horizon/+/883953 | 15:41 |
| vishalmanchanda | until we found the fix or some workaround? | 15:42 |
| rdopiera | looking at the commits, the jquery changes are the last patches that merged | 15:43 |
| vishalmanchanda | I can revert last 2-3 patches or maybe more of jquery update in a single patch and see. | 15:46 |
| vishalmanchanda | I think I got dropped | 15:52 |
| amotoki | vishalmanchanda: nobody commented since you wrote | 15:53 |
| vishalmanchanda | let's try our best to fix the horizon integration job asap. | 15:54 |
| tmazur | yeah | 15:55 |
| vishalmanchanda | moving to next topic | 15:56 |
| vishalmanchanda | #topic open-discussion | 15:56 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:56 |
| vishalmanchanda | Thanks everyone for joining. | 16:01 |
| vishalmanchanda | let's fix the CI asap. | 16:01 |
| vishalmanchanda | see you next week. | 16:01 |
| vishalmanchanda | #endmeeting | 16:01 |
| opendevmeet | Meeting ended Wed Jun 14 16:01:27 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-14-15.00.html | 16:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-14-15.00.txt | 16:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-06-14-15.00.log.html | 16:01 |
| tmazur | o/ | 16:01 |
| amotoki | o/ | 16:02 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Revert Update jQuery Changes https://review.opendev.org/c/openstack/horizon/+/886113 | 17:19 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Update cirros image to cirros-0.6.1-x86_64 to fix integration job https://review.opendev.org/c/openstack/horizon/+/883953 | 17:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!