| opendevreview | Vishal Manchanda proposed openstack/horizon master: Update cirros image to cirros-0.6.1-x86_64 https://review.opendev.org/c/openstack/horizon/+/883953 | 04:10 |
|---|---|---|
| zigo | Hi. On our patch here: https://review.opendev.org/c/openstack/horizon/+/884184 | 07:07 |
| zigo | there's test_floatingip_associate_disassociate that fails, though it seems unrelated, is there an ongoing issue with this test? | 07:07 |
| vishalmanchanda | zigo: yes, it is failing after devstack updated cirros image to 0.6.1 | 07:08 |
| vishalmanchanda | I am trying to fix that issue here https://review.opendev.org/c/openstack/horizon/+/883953 | 07:08 |
| zigo | vishalmanchanda: Thanks ! | 07:08 |
| * zigo is happy that it's not his fault | 07:08 | |
| vishalmanchanda | Please don't recheck until above patch don't get merged. | 07:09 |
| zigo | Wont do, of course. | 07:09 |
| vishalmanchanda | thanks | 07:09 |
| zigo | vishalmanchanda: Quick question: how far are we from having horizon.conf instead of local_setting.py in production ? :) | 07:38 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed May 31 15:00:13 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:01 |
| vishalmanchanda | Hello everyone | 15:01 |
| rdopiera | o/ | 15:01 |
| amotoki | hi | 15:02 |
| vishalmanchanda | let's start the meeting | 15:02 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:02 |
| vishalmanchanda | #topic Notices | 15:03 |
| vishalmanchanda | Just a casual reminder about the schedule, This week is R-18 week. | 15:04 |
| vishalmanchanda | more info. about the schedule here https://releases.openstack.org/bobcat/schedule.html | 15:04 |
| vishalmanchanda | moving to next announcement | 15:05 |
| vishalmanchanda | horizon integration job is broken | 15:05 |
| vishalmanchanda | more specifically, you may have noticed "test_floatingip_associate_disassociate" test fail for your patch, this is due to now devstack is using cirros 0.6.1 image https://review.opendev.org/c/openstack/devstack/+/881437 | 15:06 |
| vishalmanchanda | So we have to merge https://review.opendev.org/c/openstack/horizon/+/883953 to fix the CI. | 15:06 |
| vishalmanchanda | but Unfortunately many integration tests still fails randomly for this patch but please approve this patch asap to unblock the CI. | 15:07 |
| vishalmanchanda | I was also thinking if we should ask infra team to force merge the above patch an then check random failures for other tests. | 15:09 |
| vishalmanchanda | You can find about random failing tests here https://etherpad.opendev.org/p/random-failed-horizon-integration-tests | 15:09 |
| vishalmanchanda | Does anyone have any suggestion, what we should do force-merge https://review.opendev.org/c/openstack/horizon/+/883953 or anything else? | 15:10 |
| amotoki | vishalmanchanda: one question on cirros image. what happens if the cirros version does not match the version specified by devstack? | 15:13 |
| amotoki | does it mean our job fails with 100%? | 15:13 |
| vishalmanchanda | no if cirros vesrion doesn't match then ' test_floatingip_associate_disassociate' test fails and then job stops after that. | 15:14 |
| amotoki | okay. I am fully sure how cirros version affects the fip test failure though | 15:15 |
| vishalmanchanda | if cirros version match then 'test_instances_pagination_and_filtration ', ' test_instances_pagination ' and test_router_delete_interface_by_row | 15:15 |
| vishalmanchanda | fails randomly. | 15:16 |
| amotoki | could you add the context you mentioned here to the commit msg in change 883953? | 15:16 |
| vishalmanchanda | For Fip tests it try to launch a VM first and then associate and disassociate floating ip but instance not creating now due to different cirros image and fails | 15:17 |
| amotoki | because such image does not exist? | 15:18 |
| vishalmanchanda | amotoki: ok, I will upadte commit-msg for patch 883953 | 15:18 |
| vishalmanchanda | amotoki: yes. | 15:18 |
| amotoki | got it. | 15:19 |
| amotoki | for further step, we can explore a way to pick up the cirros version registered by devstack automatically by default | 15:19 |
| vishalmanchanda | ok please +2ed and w +1 on patch 883953. | 15:20 |
| vishalmanchanda | amotoki: yeah, sounds good. | 15:20 |
| vishalmanchanda | moving to next announcement. | 15:20 |
| amotoki | vishalmanchanda: will +2 once you update the commit msg | 15:20 |
| vishalmanchanda | amotoki: thanks. | 15:21 |
| vishalmanchanda | I will update it after the meeting | 15:21 |
| vishalmanchanda | You may have noticed I have self-approve few patches in the stable branches | 15:22 |
| vishalmanchanda | https://review.opendev.org/q/I9c75b084705dfdc6df52aca1659f89444c8a1728 | 15:22 |
| vishalmanchanda | It was done to fix zuul config errors https://zuul.opendev.org/t/openstack/config-errors | 15:23 |
| vishalmanchanda | the stable branch patches waiting for review from long time and infra team suggested me to merge them immediately to avoid more conflict. | 15:24 |
| vishalmanchanda | I hope no-one have any issue with that. | 15:24 |
| amotoki | I see no problem on such kind of patches | 15:24 |
| vishalmanchanda | ok cool | 15:24 |
| amotoki | they failed when proposed. was there any change since then? | 15:25 |
| vishalmanchanda | but stable/stein branch is still broken see https://review.opendev.org/c/openstack/horizon/+/878846 | 15:25 |
| amotoki | is it the oldest EM branch in horizon? | 15:26 |
| vishalmanchanda | no they failed because of merge conflict after some changes i.e. Remove usage of openstack/xstatic-font-awesome | 15:26 |
| vishalmanchanda | So I squashed two patches in a single patch to fix the CI. | 15:26 |
| vishalmanchanda | stable/stein is in extended maintenance phase | 15:29 |
| vishalmanchanda | yeah we already move stable/rocky to eol. | 15:30 |
| vishalmanchanda | So now my question here is anyone here is interested in maintaining stable/stein branch, otherwise we can move it to EOL? | 15:30 |
| amotoki | I can say nothing on detail, perhaps we need to check other projects for requirements-check job at least. | 15:30 |
| vishalmanchanda | infra-team suggested me to make failed job non-voting for stable/stein branch. | 15:31 |
| amotoki | rdopiera: tmazur: I think stein can be EOL'ed from RH perspective, right? | 15:32 |
| rdopiera | we don't use stein anymore, I'm fine with EOL | 15:32 |
| tmazur | +1 | 15:32 |
| amotoki | all here are okay to make stein EOL :-) | 15:33 |
| vishalmanchanda | ok, I will check with infra team if they can force merge open patches in stable/stein branch https://review.opendev.org/q/project:openstack%252Fhorizon+branch:stable%252Fstein+status:open and then we can move it to EOL. | 15:33 |
| rdopiera | off with its head | 15:33 |
| vishalmanchanda | or no need to merge open patches? | 15:34 |
| amotoki | vishalmanchanda: could you send a mail to propose stein EOL to the mailing list for clarification? | 15:34 |
| rdopiera | I don't mind either way | 15:34 |
| tmazur | No need for zuul one for sure | 15:35 |
| vishalmanchanda | amotoki: mail I will send for sure. | 15:35 |
| amotoki | yeah, we don't need to fix the gate if we EOL a branch :) | 15:35 |
| vishalmanchanda | ok thanks, I will send a mail on open-discuss ML. | 15:35 |
| tmazur | Two others seems to be nice to have still, but again EOL, so I'm ok with either option | 15:36 |
| vishalmanchanda | noted | 15:37 |
| vishalmanchanda | moving to next thing. | 15:37 |
| vishalmanchanda | It come to my attention that horizon is failing with the latest font-awesome release https://zuul.opendev.org/t/openstack/build/e5dd3c8fced64cf2b95ecc2d50bc0827 | 15:38 |
| rdopiera | that's why we have it pinned | 15:39 |
| vishalmanchanda | I remember we decided to pin xstatic pypi version | 15:39 |
| vishalmanchanda | so I think we should do it now asap. | 15:39 |
| vishalmanchanda | we need to pin the version in openstack/requirements as well. | 15:41 |
| vishalmanchanda | ok I will check we should pin the version in openstack/requirements for the pypi which we are not maintaining anymore atleast. | 15:43 |
| amotoki | pinning is okay as a temporary solution. what do we need to do to unpin them? | 15:43 |
| vishalmanchanda | moving to next announcement | 15:43 |
| vishalmanchanda | we should atleast open a new bug for that issue and keep checking on it I think. | 15:45 |
| rdopiera | do we really need to use the latest release of a font? | 15:47 |
| rdopiera | iirc Dreimark just randomly changed some paths | 15:47 |
| vishalmanchanda | TBH, I have no idea about that. | 15:47 |
| amotoki | I don't think we always need to the latest version of the font, but if we continue to use a specific version it leads to a situation we use very old version..... | 15:48 |
| rdopiera | it's an icon font, we don't use any new icons they added | 15:48 |
| amotoki | this is my only concern | 15:48 |
| rdopiera | there is not going to be a CVE for a font | 15:48 |
| amotoki | yeah | 15:49 |
| amotoki | it is very static one | 15:49 |
| rdopiera | eXtra Static | 15:49 |
| amotoki | hehe | 15:50 |
| vishalmanchanda | ok then we can pin the same version in openstack/requirement and mentioned these comments for future reference. | 15:50 |
| vishalmanchanda | for awosome-font pypi | 15:50 |
| rdopiera | I recently had a message from our security team, telling us that customers are complaining about old library versions in horizon, because they use some outomated script for checking it, and it claims it's insecure | 15:51 |
| rdopiera | And I really don't know where to start explaining | 15:51 |
| amotoki | rdopiera: like jquery or angularjs? | 15:51 |
| rdopiera | among others, yes | 15:52 |
| vishalmanchanda | what more library versions they are complaining about, if you have any list? | 15:53 |
| vishalmanchanda | we can target them next to update. | 15:54 |
| rdopiera | I don't, they were very sparse in detail, I also asked them about any particular cve or exploit they are concerned about, and they weren't able to answer either | 15:54 |
| vishalmanchanda | hmm | 15:55 |
| rdopiera | people shouldn't be allowed to use tools they don't understand | 15:55 |
| vishalmanchanda | lol | 15:55 |
| rdopiera | (we are patching jquery and angularjs downstream to fix any cves that pop up) | 15:56 |
| vishalmanchanda | good. | 15:56 |
| vishalmanchanda | next announcement is, I am on full week vacation next week. I have no access to my mails. So I was thinking if we can skip next weekly meeting until someone wants to chair the next horizon weekly meeting. | 15:58 |
| vishalmanchanda | no internet. | 15:58 |
| rdopiera | 'm fine with skipping, enjoy your vacation | 15:58 |
| vishalmanchanda | thanks. | 15:59 |
| amotoki | vishalmanchanda: I am fine to skip it. enjoy your vacation! | 15:59 |
| tmazur | yeah, let's skip | 15:59 |
| vishalmanchanda | ok cool then I will send a mail on open-discuss ML about this. | 15:59 |
| tmazur | Enjoy your vacation Vishal! | 15:59 |
| vishalmanchanda | next to next week, we have Vancouver summit. | 16:01 |
| vishalmanchanda | tmazur: are you travelling? | 16:01 |
| tmazur | No | 16:01 |
| vishalmanchanda | next to next week we have Vancouver summit. | 16:02 |
| vishalmanchanda | tmazur: are you travelling? | 16:02 |
| vishalmanchanda | or anyone else | 16:02 |
| vishalmanchanda | ok then we can have our weekly meeting in summit week as no-one of us travelling. | 16:02 |
| tmazur | Yeah | 16:03 |
| amotoki | no. I am not travelling either | 16:03 |
| vishalmanchanda | we already out of time. | 16:03 |
| vishalmanchanda | I have no updates on release-priorities topic because spend most of my time in fixing CI for master and stable branches last week. | 16:04 |
| vishalmanchanda | #topic open-discussion | 16:04 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 16:04 |
| tmazur | I fixed those ports at launch Instance dialog | 16:05 |
| vishalmanchanda | tmazur: thanks for the quick fix | 16:05 |
| tmazur | And that's it from me for today :) | 16:05 |
| vishalmanchanda | waiting for CI to fix then I will review it. | 16:05 |
| amotoki | vishalmanchanda: feel free to ping me if we can land fixes this week :-) | 16:06 |
| vishalmanchanda | Does anyone look at setuptool bug | 16:06 |
| vishalmanchanda | amotoki: thanks. | 16:06 |
| vishalmanchanda | If no other topic to discuss, let's end this meeting | 16:08 |
| vishalmanchanda | thanks everyone for joining. | 16:08 |
| vishalmanchanda | Take care. | 16:08 |
| vishalmanchanda | #endmeeting | 16:08 |
| opendevmeet | Meeting ended Wed May 31 16:08:59 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:08 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-31-15.00.html | 16:08 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-31-15.00.txt | 16:08 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-05-31-15.00.log.html | 16:08 |
| amotoki | o/ | 16:11 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Update cirros image to cirros-0.6.1-x86_64 to fix integration job https://review.opendev.org/c/openstack/horizon/+/883953 | 16:20 |
| vishalmanchanda | amotoki: commit msg updated, please take a look and approve. | 16:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!