| *** Guest9750 is now known as atmark | 14:32 | |
| vishalmanchanda | #startmeeting horizon | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Apr 19 15:00:36 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:02 |
| tmazur | o/ | 15:02 |
| vishalmanchanda | Hello everyone | 15:02 |
| vishalmanchanda | let's start the meeting | 15:03 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L32 | 15:03 |
| vishalmanchanda | I have no announcements for this week, so moving to Release priorities topic | 15:04 |
| vishalmanchanda | #topic Release priorities | 15:04 |
| vishalmanchanda | thanks rdopiera for reviewing Jquery migration patches. | 15:05 |
| vishalmanchanda | https://review.opendev.org/q/topic:update-jquery | 15:05 |
| vishalmanchanda | tmazur: Could you also review them. | 15:05 |
| tmazur | Sure, will do today | 15:06 |
| vishalmanchanda | let me know in case if you have any doubt in those patches. | 15:06 |
| vishalmanchanda | tmazur: thanks. | 15:06 |
| vishalmanchanda | I will try to fix more deprecated method and once it done, I will update the XStatic-JQuery-Migrate version to 3.3.2.1 and then later JQuery version | 15:10 |
| vishalmanchanda | moving to next item | 15:10 |
| vishalmanchanda | I look into setuptool bug https://bugs.launchpad.net/horizon/+bug/2007574 but I still not able to reproduce this issue. | 15:11 |
| rdopiera | it depends on what order things are being installed | 15:12 |
| vishalmanchanda | one time I hit the same issue mentioned in the bug, but now it is working in my local env. | 15:12 |
| vishalmanchanda | rdopiera: ohh. I see. | 15:12 |
| rdopiera | we just need to add an import to the base xstatic setup.py | 15:13 |
| rdopiera | I keep forgetting to make a PR | 15:13 |
| vishalmanchanda | rdopiera: could you please do it atleast for one pypi i.e. XStatic-term.js | 15:14 |
| vishalmanchanda | If similar changes required in other pypi as well, I can help. | 15:15 |
| rdopiera | we just need it for the xstatic itself | 15:15 |
| rdopiera | just 'import pkg_resources' in the setup.py for xstatic package | 15:16 |
| rdopiera | I will do it | 15:16 |
| vishalmanchanda | rdopiera: that will be awesome. | 15:17 |
| vishalmanchanda | thanks. | 15:17 |
| vishalmanchanda | I have nothing more to discuss on release priority topic. | 15:18 |
| vishalmanchanda | moving to next topic | 15:19 |
| vishalmanchanda | #topic open-discussion | 15:19 |
| rdopiera | we have a new blueprint | 15:20 |
| rdopiera | https://blueprints.launchpad.net/openstack/?searchtext=action-to-export-credentials-in-users-menu | 15:21 |
| vishalmanchanda | yeah a patch is also up for this bp https://review.opendev.org/c/openstack/horizon/+/879163 | 15:22 |
| vishalmanchanda | It's on my review list. | 15:23 |
| vishalmanchanda | rdopiera: you want to discuss something about this bp? | 15:24 |
| rdopiera | not particularly, I just find it curious, might be a candidate for a contributor | 15:25 |
| vishalmanchanda | ack. | 15:27 |
| vishalmanchanda | rdopiera: you remember 2 weeks back while removing the external contributors from pypi packages you removed everyone except openstacci for font-awosome pypi, even moinwiki contributors and then you added him back. | 15:28 |
| vishalmanchanda | So gmann and fungi want to know if this is possible, if someone removes themself, can also add themselves back as a maintainer for a pypi? | 15:30 |
| rdopiera | no, I asked the pypi admin to add me back | 15:31 |
| rdopiera | and it involved some verification | 15:31 |
| vishalmanchanda | rdopiera: ok thanks for confirming. | 15:31 |
| fungi | asked via an issue on github i guess? | 15:32 |
| rdopiera | via e-mail to admin@pypi.org | 15:32 |
| fungi | aha, thanks | 15:32 |
| vishalmanchanda | I have one query on your patch using double quotes for HTML attribute https://review.opendev.org/c/openstack/horizon/+/879490 | 15:34 |
| vishalmanchanda | Please reply on it, so we can merge it. | 15:34 |
| vishalmanchanda | that's all from my side for this week. | 15:36 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:37 |
| vishalmanchanda | If no other topic to discuss, we can end this meeting. | 15:41 |
| vishalmanchanda | thanks, everyone for joining. See you next week. | 15:42 |
| vishalmanchanda | #endmeeting | 15:43 |
| opendevmeet | Meeting ended Wed Apr 19 15:43:07 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:43 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-19-15.00.html | 15:43 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-19-15.00.txt | 15:43 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-19-15.00.log.html | 15:43 |
| amotoki | vishalmanchanda: I dropped a couple of questions to your jquery-update patches. I might be wrong, but I believe it is worth checking in detail. | 16:17 |
| vishalmanchanda | amotoki: thanks, checking them. will update the patches soon. | 16:20 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix "jQuery.fn.mousedown() event shorthand is deprecated" warning https://review.opendev.org/c/openstack/horizon/+/879990 | 16:27 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecated use of 'jQuery.fn.change()' shorthand event https://review.opendev.org/c/openstack/horizon/+/880071 | 16:36 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Fix deprecation warning for .removeAttr() https://review.opendev.org/c/openstack/horizon/+/880541 | 20:23 |
| -opendevstatus- NOTICE: The Etherpad service on etherpad.opendev.org will be offline for the next 90 minutes for a server replacement and operating system upgrade | 21:58 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!