| opendevreview | Radomir Dopieralski proposed openstack/horizon master: Clean up the syntax of html attributes to always use double quotes https://review.opendev.org/c/openstack/horizon/+/879490 | 09:00 |
|---|---|---|
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Apr 5 15:00:16 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:01 |
| vishalmanchanda | hello everyone | 15:01 |
| tmazur | o/ | 15:02 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L29 | 15:03 |
| vishalmanchanda | let's start the meeting | 15:03 |
| vishalmanchanda | #topic Notices | 15:03 |
| vishalmanchanda | I have few updates for this week. | 15:03 |
| vishalmanchanda | First of all, Welcome to First meeting of bobcat cycle. | 15:04 |
| tmazur | \o/ | 15:04 |
| vishalmanchanda | Thanks for joining the vPTG, if you didn't join and looking for the notes what we discuss, you can find here https://etherpad.opendev.org/p/horizon-bobcat-ptg | 15:04 |
| vishalmanchanda | For bobcat cycle schedule please refer https://releases.openstack.org/bobcat/schedule.html | 15:05 |
| vishalmanchanda | One update on pypi maintainers cleanup from my side, I have sent the mail to all external maintainers last week, now rdopiera you can remove yourself and other maintainers and make openstackci as owner. | 15:06 |
| vishalmanchanda | As expected, I didn't get any response from any maintainers as of today. | 15:07 |
| rdopiera | \o/ | 15:07 |
| vishalmanchanda | rdopiera: If you are looking for list of pypi where you are maintainer please see https://paste.openstack.org/show/819503/ | 15:07 |
| rdopiera | thanks | 15:08 |
| vishalmanchanda | I have also updated their status in cleanup etherpad https://etherpad.opendev.org/p/openstack-pypi-maintainers-cleanup#L113 | 15:09 |
| vishalmanchanda | moving to next announcement | 15:09 |
| vishalmanchanda | rdopiera: Could you take a look at https://review.opendev.org/c/openstack/horizon/+/862901 | 15:10 |
| vishalmanchanda | Once it get merge, will cut a final release of stable/xena branch for horizon before moving to extended maintenance phase. | 15:10 |
| vishalmanchanda | About https://review.opendev.org/c/openstack/horizon/+/870902, same 5 integration test are failing. So it's worth to look into failed test rather than just rechecking on gate. | 15:11 |
| vishalmanchanda | https://paste.openstack.org/show/819505/ these integration test are failing for 870902. | 15:12 |
| vishalmanchanda | I guess some issue with deleting the instances/volumes in integration test. | 15:13 |
| vishalmanchanda | moving to next item. | 15:14 |
| vishalmanchanda | You may have noticed zuul job doesn't trigger for stable/train and stable/stein branch. | 15:14 |
| vishalmanchanda | https://review.opendev.org/q/project:openstack/horizon+branch:stable/train+status:open | 15:14 |
| vishalmanchanda | To fix this issue, we have to merge https://review.opendev.org/c/openstack/horizon/+/878845 and https://review.opendev.org/c/openstack/horizon/+/878846 | 15:15 |
| vishalmanchanda | Feel free to work on these patches, if it is urgent for you. | 15:16 |
| vishalmanchanda | moving to next announcement | 15:16 |
| vishalmanchanda | rdopiera: Did you get time to write a mail to other openstack project(nova, cinder, neutron, glance) to know feature gap for horizon. | 15:17 |
| vishalmanchanda | we discuss this topic in vPTG https://etherpad.opendev.org/p/horizon-bobcat-ptg#L101 | 15:18 |
| vishalmanchanda | just an reminder. | 15:18 |
| vishalmanchanda | I have no other announcements to make, if anyone have any announcement to make. please go ahead | 15:19 |
| rdopiera | vishalmanchanda: not yet | 15:19 |
| vishalmanchanda | rdopiera: ok. | 15:19 |
| vishalmanchanda | moving to next topic | 15:21 |
| vishalmanchanda | #topic Release priorities | 15:21 |
| vishalmanchanda | I have updated the list of priorities items for Bobcat cycle which we will track in bobcat cycle. | 15:23 |
| vishalmanchanda | Feel free to add any bug/feature which you think we should prioritize in the bobcat cycle. | 15:23 |
| vishalmanchanda | We will start tracking these features from next week. | 15:25 |
| vishalmanchanda | that's all from my side for this week. | 15:25 |
| vishalmanchanda | #topic open-discussion | 15:25 |
| vishalmanchanda | I am facing some issues while running integration job in local env. | 15:26 |
| vishalmanchanda | timeout errors. | 15:27 |
| vishalmanchanda | here are some error logs https://paste.openstack.org/show/bPI5p7CtvPLJ3L7nMsyD/ | 15:28 |
| vishalmanchanda | anyone also facing same issues and know how to fix these? | 15:28 |
| tmazur | I doubt I've seen anything like this :/ | 15:29 |
| rdopiera | looks like it can't connect to selenium | 15:30 |
| rdopiera | does the browser window open? | 15:31 |
| vishalmanchanda | no, it's not opening when I run integration test. | 15:31 |
| vishalmanchanda | I am using Firefox browser. | 15:31 |
| rdopiera | if you comment out the "headless" env variable, it will open, so you might be able to see better what's happening | 15:32 |
| rdopiera | it might be failing to start for a variety of reasons | 15:32 |
| rdopiera | geckodriver not available or too old | 15:33 |
| rdopiera | or crashing for some reason | 15:33 |
| vishalmanchanda | geckodriver version is same as we are using in horizon CI | 15:33 |
| rdopiera | but your browser is newer | 15:34 |
| vishalmanchanda | yes | 15:34 |
| rdopiera | you can also try starting geckodriver manually and see if it says anything | 15:35 |
| vishalmanchanda | ok, I will try that. | 15:35 |
| vishalmanchanda | thanks for the workarounds. | 15:35 |
| rdopiera | I have one thing to note | 15:35 |
| rdopiera | We have a very weird issue with the django compressor on upgrading horizon, where the compressor fails to run | 15:36 |
| rdopiera | it's similar to https://lists.openstack.org/pipermail/openstack-discuss/2020-December/019312.html however in our case restarting memcached doesn't help | 15:37 |
| rdopiera | I tried to debug it, but it looks like escaping of single quotes changed somehow between versions | 15:37 |
| rdopiera | as I'm unable to figure out what is happening exactly and how to fix it, I decicded to work around it, and in the meantime also clean up out html templates a bit | 15:38 |
| rdopiera | and I replaced all single quotes in html with double quotes | 15:38 |
| rdopiera | I know it seems like unneeded change, but I think we are better with consistent quoting like this, and it will help sidestep that particular problem | 15:39 |
| vishalmanchanda | ok, I have one query how you are upgrading horizon from which branch to latest? | 15:40 |
| rdopiera | vishalmanchanda: they are installing a newer verson of a container that contains horizon | 15:41 |
| vishalmanchanda | rdopiera: ok. | 15:41 |
| rdopiera | the problem is with two versions of Train | 15:41 |
| rdopiera | so it's pretty old for us | 15:41 |
| rdopiera | I will backport that patch to our downstream repository | 15:42 |
| vishalmanchanda | I am fine with using html attributes to always use double quotes. | 15:42 |
| vishalmanchanda | will review it asap. | 15:42 |
| rdopiera | thanks | 15:43 |
| vishalmanchanda | I have one more request for patch review https://review.opendev.org/c/openstack/xstatic-jquery-migrate/+/878923 | 15:43 |
| vishalmanchanda | It add warning about Xstatic packages may contain security vulnerabilities. | 15:44 |
| vishalmanchanda | Please review it once you have time. | 15:44 |
| rdopiera | I removed everyone from pypi now | 15:45 |
| vishalmanchanda | rdopiera: thanks. | 15:45 |
| opendevreview | Merged openstack/xstatic-jquery-migrate master: Add Javascript fork warning boilerplate to README https://review.opendev.org/c/openstack/xstatic-jquery-migrate/+/878923 | 15:46 |
| vishalmanchanda | We can add the same warning message for other xstatic packages which are old and may have CVE. | 15:47 |
| rdopiera | yes, very good idea | 15:47 |
| rdopiera | I'm also thinking about adding this to the pep8 test: https://www.djlint.com/docs/languages/django/ | 15:47 |
| rdopiera | or a similar tool | 15:48 |
| vishalmanchanda | I will look for those Xstatic packages and purpose a patch to update README file. | 15:48 |
| vishalmanchanda | rdopiera: great. | 15:49 |
| vishalmanchanda | Does anyone have any other topic to discuss? | 15:50 |
| tmazur | I have a question | 15:51 |
| vishalmanchanda | please ask. | 15:51 |
| tmazur | Do we want to work on SDK in bobcat? Should we add it to our priorities? | 15:51 |
| vishalmanchanda | tmazur: yeah, I am also thinking about it. | 15:52 |
| tmazur | Seems it's inevitable anyway | 15:52 |
| vishalmanchanda | tmazur: we should prioritize these work for sure. | 15:52 |
| vishalmanchanda | As most of openstack project planing to move to SDK. | 15:54 |
| vishalmanchanda | big +1 from my side for SDK work. | 15:54 |
| tmazur | Thanks | 15:55 |
| vishalmanchanda | I am also planning to work on these thing for few cinder or neutron features. | 15:55 |
| vishalmanchanda | in bobcat cycle. | 15:55 |
| vishalmanchanda | If no more topic to discuss, let's end this meeting. | 15:57 |
| vishalmanchanda | Thanks everyone for your contributions. | 15:58 |
| vishalmanchanda | See you next week. | 15:58 |
| vishalmanchanda | #endmeeting | 15:58 |
| opendevmeet | Meeting ended Wed Apr 5 15:58:27 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:58 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-05-15.00.html | 15:58 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-05-15.00.txt | 15:58 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-04-05-15.00.log.html | 15:58 |
| rdopiera | vishalmanchanda: it seems I removed maintainers from font-awesome by mistake | 16:03 |
| rdopiera | vishalmanchanda: do you know if there is a way to log in through the openstackci account and add them back? | 16:03 |
| vishalmanchanda | rdopiera: You mean you want to add Reimar Bauer? | 16:05 |
| rdopiera | either myself, Reimar or Thomas | 16:12 |
| rdopiera | then we can add the missing people | 16:12 |
| rdopiera | I wrote to pypi admin to ask to put them back now, we will see what they say | 16:12 |
| vishalmanchanda | ok, I am also checking with one of TC how can we do that. | 16:13 |
| gmann | rdopiera: vishalmanchanda: hi, as XStatic-Font-Awesome is not openstack deliverables any more, we can remove openstackci from maintainer list https://pypi.org/project/XStatic-Font-Awesome/ | 17:34 |
| gmann | rdopiera: if pypi admin does not response or taking time then openstackci can add them back and remove themself. I think pypi reply might take long time as I heard in PTG | 17:34 |
| gmann | fungi: ^^ can you please check this. XStatic-Font-Awesome is not openstack deliverables now and we need to give maintainers from openstackci to rdopiera and he can add non openstack maintainers as per applicability | 17:36 |
| vishalmanchanda | gmann: fungi :thanks, that will works for us. | 17:36 |
| gmann | let's wait for fungi response and if that is possible to do | 17:37 |
| vishalmanchanda | ok | 17:37 |
| fungi | rdopiera: vishalmanchanda: gmann: it looks like the only person who can fix that now is "Reimar Bauer" according to https://pypi.org/project/XStatic-Font-Awesome/ | 17:41 |
| fungi | it would be a pretty big security hole in pypi if someone whose account got removed could log back in and readd themselves | 17:42 |
| vishalmanchanda | fungi: yeah, I think Jay from Tc also raise this point in vPTG but got ignored. | 17:43 |
| vishalmanchanda | oops Jay raised some different concern like current pypi maintainers can also remove everyone even openstackci or also delete pypi not this issue like a person can readd themselves as pypi maintainer. | 17:49 |
| rdopiera | fungi, vishalmanchanda: all is fixed now | 17:57 |
| rdopiera | sorry for the fuss | 17:57 |
| rdopiera | gmann: I will remove openstackci then | 17:58 |
| fungi | rdopiera: thanks, how did you end up fixing? | 18:00 |
| fungi | in case someone else accidentally does the same thing on another project later | 18:01 |
| vishalmanchanda | fungi: I will check with how he done that. | 18:16 |
| vishalmanchanda | I will check with him how he added himself again. | 18:16 |
| gmann | rdopiera thanks. | 18:51 |
| gmann | yeah, knowing the process/workaround will be good to know | 18:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!