| vishalmanchanda | #startmeeting horizon | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Aug 10 15:00:18 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| rdopiera | o/ | 15:00 |
| vishalmanchanda | Hello everyone | 15:00 |
| tmazur | o/ | 15:00 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:01 |
| vishalmanchanda | ok let's start the meeting | 15:02 |
| vishalmanchanda | #topic Notices | 15:02 |
| amotoki | hi | 15:02 |
| vishalmanchanda | One announcement from my side about PTG | 15:02 |
| vishalmanchanda | I hope all of know that the next PTG is going to be virtual now. | 15:03 |
| vishalmanchanda | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029879.html | 15:03 |
| amotoki | is it announced already? | 15:03 |
| vishalmanchanda | amotoki: yes | 15:03 |
| amotoki | I missed that | 15:03 |
| rdopiera | in the cloud | 15:04 |
| vishalmanchanda | I have already signup for horizon team, will book the slot once schedule is up. | 15:05 |
| vishalmanchanda | I will also create the etherpad to collect the topics for PTG discussion. | 15:06 |
| vishalmanchanda | meanwhile, Please signup for PTG if not done yet, to get all PTG related updates. | 15:06 |
| vishalmanchanda | it is free. | 15:06 |
| vishalmanchanda | https://www.eventbrite.com/e/project-teams-gathering-october-2022-tickets-374118026087 | 15:06 |
| vishalmanchanda | that is only update from my side for this week. | 15:07 |
| vishalmanchanda | If anyone have any announcement to make, please go ahead. | 15:08 |
| vishalmanchanda | moving to next topic | 15:09 |
| vishalmanchanda | #topic Release priorities | 15:09 |
| vishalmanchanda | Small update on Xstatic-angular migration to 1.8.2.2 from my side. | 15:11 |
| vishalmanchanda | Patches for 3 plugins merged this week | 15:11 |
| vishalmanchanda | https://review.opendev.org/q/topic:angular_updates | 15:12 |
| vishalmanchanda | Now gate for 3 plugins still failing octavia-dashboard,magnum-ui,ironic-ui | 15:13 |
| johnsom | We have made progress on the octavia-dashboard issues. We are down to the "Possibly unhandled rejection: undefined thrown" issue | 15:14 |
| vishalmanchanda | johnsom: JFYI similar issue in magnum-ui... | 15:15 |
| johnsom | This one is crazy tricky to track down it seems | 15:15 |
| johnsom | https://www.irccloud.com/pastebin/ObD9B42W/ | 15:15 |
| johnsom | We could disable that error | 15:15 |
| vishalmanchanda | johnsom: for magnum-ui, I skipped 2 test in local env.:) | 15:16 |
| johnsom | But I think it would disable it for all of horizon. It seems the authors on the octavia-dashboard left a lot of paths without error path coverage. | 15:16 |
| johnsom | The other three we have resolved | 15:17 |
| vishalmanchanda | johnsom: If we ignore those tests, Does anything else broken in ocatvia-dashboard. functionality for those tests? | 15:19 |
| johnsom | I haven't circled back and run the dashboard by hand, but initial testing appeared to only be unit test bugs | 15:20 |
| vishalmanchanda | johnsom: Could you please check if related code works fine in GUI side? | 15:21 |
| vishalmanchanda | becuase I haven't the env. to verify that. | 15:21 |
| johnsom | Yeah, we will do that. | 15:22 |
| vishalmanchanda | tmazur: what's you think about disbaling it for all of horizon? | 15:22 |
| tmazur | vishalmanchanda: I don't think it's a good idea. Rejection conception has been changed with new Angular, so it's not good to just hide an error | 15:24 |
| amotoki | can we disable it when initializing UT per plugin? generally spekaing I don't think it is a good idea. | 15:24 |
| tmazur | I've fixed a bunch in horizon itself, and I can help with plugins, but I don't have env with them to test | 15:25 |
| vishalmanchanda | tmazur: ok, I help you with env. | 15:25 |
| vishalmanchanda | tmazur: It is very simple, you just have to clone the repo. | 15:26 |
| johnsom | We would appreciate any help you can give on octavia-dashboard. We don't have anyone familiar with angular right now. We are also happy to help test, etc. | 15:26 |
| tmazur | Cool. I hope it won't be a big problem, usually catching the rejection is enough | 15:26 |
| tmazur | Ok, let's try to fix it properly then. I'll take a look into the patch and give some ideas to try. | 15:27 |
| vishalmanchanda | tmazur: after that I usually add https://paste.openstack.org/show/bjFPjBkMxwKTyk6YBbTK/ in plugins tox.ini because I face too many error, if I run tests with Karma command | 15:28 |
| vishalmanchanda | tmazur: thanks. | 15:28 |
| johnsom | We are down to just that error after our work overnight. | 15:28 |
| johnsom | Also, question, why are we using "Firefox" instead of "FirefoxHeadless" in the karma config? | 15:29 |
| vishalmanchanda | tmazur: I tried to catch those error in case of mangnum-ui but not succeded:( | 15:29 |
| vishalmanchanda | tmazur: FYI 2 tests fails in case of magnum-ui | 15:30 |
| vishalmanchanda | https://github.com/openstack/magnum-ui/blob/master/magnum_ui/static/dashboard/container-infra/clusters/resize/resize.service.spec.js#L96 | 15:30 |
| vishalmanchanda | https://github.com/openstack/magnum-ui/blob/master/magnum_ui/static/dashboard/container-infra/clusters/rolling-upgrade/upgrade.service.spec.js#L119 | 15:30 |
| tmazur | vishalmanchanda: sometimes the test itself is based on checking the rejection. These kind of tests we have to remove, since all the rejections are handled now | 15:31 |
| vishalmanchanda | tmazur: ok, I see. | 15:32 |
| tmazur | I'll take a look | 15:32 |
| vishalmanchanda | Also, I have one question about Jquery! | 15:32 |
| vishalmanchanda | Yesterday I am checking there is no Gerrit repo exist for openstack/Xstatic-jQuery | 15:34 |
| amotoki | vishalmanchanda: it is not maintained under openstack governance. | 15:35 |
| vishalmanchanda | amotoki: Do we have to release it like done here for jquery-migrate https://review.opendev.org/c/openstack/xstatic-jquery-migrate/+/717128 ? | 15:35 |
| amotoki | vishalmanchanda: why do we need a release in openstack? | 15:36 |
| amotoki | looking at xstatic-jquery pypi https://pypi.org/project/XStatic-jQuery/, I am not sure who usually cut a relase. | 15:38 |
| vishalmanchanda | amotoki: yeah | 15:38 |
| rdopiera | amotoki: I think it was Thomas Waldmann | 15:39 |
| amotoki | rdopiera: do you know anything? I wonder "sheep" in the maintainer list is you | 15:39 |
| rdopiera | yes, it's me | 15:39 |
| rdopiera | and openstackci is the script | 15:39 |
| rdopiera | so it will be released automatically, just like the other xstatic packages | 15:40 |
| vishalmanchanda | ok, pypi already have XStatic-jQuery v3.5.1.1, so need of new release atleast for now. | 15:41 |
| vishalmanchanda | Yesterday I was checking if it picks the lastest version https://review.opendev.org/c/openstack/requirements/+/852652 | 15:42 |
| amotoki | hmm.... but xstatic-jquery has never been relased thru the openstack/releases repo. | 15:42 |
| rdopiera | the openstackci user has the rights, so it should work | 15:43 |
| amotoki | it should work as PyPI side. | 15:44 |
| vishalmanchanda | I will check that. | 15:44 |
| amotoki | another point is that openstack/releases repo is for official deliverables. we have no corresponding repo for xstatic-jquery under the openstack governance. | 15:45 |
| amotoki | so if we would like to use openstack/releases repo to cut a release we need a governance change to add a corresponding repo. | 15:45 |
| rdopiera | I can release it manually if needed | 15:45 |
| amotoki | I am okay with either. | 15:46 |
| amotoki | do we want a repo for xstatic jquery under horizon governance? | 15:46 |
| rdopiera | we don't have it under openstack, because it was first created for moinmoin, and it was maintained as part of moinmoin | 15:46 |
| rdopiera | horizon is not the only user of xstatic | 15:47 |
| amotoki | rdopiera: makes sense | 15:47 |
| amotoki | where is xstatic-jquery maintained? | 15:47 |
| rdopiera | there should be a link on pypi let me look | 15:48 |
| vishalmanchanda | https://github.com/jquery/jquery | 15:49 |
| amotoki | vishalmanchanda: it is the repo forr jquery itself. | 15:49 |
| vishalmanchanda | my bad. | 15:50 |
| amotoki | homepage on pypi usually give us the infomration but I can find jquery upstream only | 15:50 |
| vishalmanchanda | Is it https://anaconda.org/conda-forge/xstatic-jquery ? | 15:50 |
| vishalmanchanda | https://github.com/xstatic-py/xstatic-jquery | 15:51 |
| rdopiera | https://github.com/xstatic-py/xstatic-jquery | 15:51 |
| amotoki | rdopiera: you pushed a PR for 3.4.1 :-) | 15:53 |
| rdopiera | yeah, back when I was trying to upgrade horizon | 15:53 |
| amotoki | so it looks like it is clear enough on how we can prepare xstatic-jquery for 3.6.0. | 15:54 |
| rdopiera | the problem is that our ci is failing with the new jquery-migrate, without any error message | 15:55 |
| rdopiera | it works when I run the tests locally | 15:56 |
| vishalmanchanda | rdopiera: yeah some integration tests fails, I will look into those. | 15:57 |
| vishalmanchanda | ok moving to next topic | 15:57 |
| vishalmanchanda | #topic Open reviews | 15:58 |
| alistarl1 | Hi, regarding https://review.opendev.org/c/openstack/horizon/+/851914 I have fixed the tests | 15:58 |
| vishalmanchanda | Could you review this patch https://review.opendev.org/c/openstack/horizon/+/840220 | 15:58 |
| vishalmanchanda | tmazur: rdopiera :^^ | 15:58 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/845158 | 15:59 |
| vishalmanchanda | I have been waiting for a second review on the above patches for a long time. | 16:00 |
| amotoki | alistarl1: I am trying to test it with multiple regions. it takes time... I also have questions like why permissions need to be checked explicitly in allowed() and so on. I will drop them as comments | 16:00 |
| alistarl1 | oh great, I also struggle with integration tests which are failing, and I cannot achieve to re-run on a kolla or devstack env | 16:01 |
| alistarl1 | even with a working openstack behind, I get a selenium exception: selenium.common.exceptions.ElementNotInteractableException: Message: Element <a href="/settings/"> could not be scrolled into view | 16:01 |
| vishalmanchanda | alistarl1: JFYI, these integration tests fails randomly, the failure maybe not be related to your patch. | 16:02 |
| vishalmanchanda | alistarl1: We are working on fixing these random failures. | 16:02 |
| alistarl1 | I check permissions because I copied the trunk panel code: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/trunks/panel.py#L36, but if you think it is not required I can remove it | 16:03 |
| alistarl1 | vishalmanchanda: Oh ok I will recheck then | 16:03 |
| amotoki | while it is optional, hopefully can we land https://review.opendev.org/c/openstack/horizon/+/851261 (django 4.0 preparation) | 16:05 |
| amotoki | when reviewing a bunch of django3.2 deprecation warnings, i was tried to run them locally.... | 16:05 |
| amotoki | s/tried/tired/ | 16:05 |
| vishalmanchanda | amotoki: +1 | 16:06 |
| vishalmanchanda | Do we have any other topics to discuss? | 16:07 |
| vishalmanchanda | If nothing more to discuss, let's end this meeting. | 16:08 |
| vishalmanchanda | Thanks, everyone for your contributions and joining. | 16:08 |
| vishalmanchanda | See you next week. | 16:09 |
| vishalmanchanda | #endmeeting | 16:09 |
| opendevmeet | Meeting ended Wed Aug 10 16:09:35 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:09 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-10-15.00.html | 16:09 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-10-15.00.txt | 16:09 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-10-15.00.log.html | 16:09 |
| amotoki | o/ | 16:10 |
| johnsom | A followup to the earlier discussion, I have manually tested the Octavia plugin under Angular 1.8.2 and it appears to be working fine. It's really just down to that last unit test issue. | 19:38 |
| vishalmanchanda | johnsom: ack. | 19:39 |
| johnsom | Another followup, I think I have corrected all of the issues in the octavia-dashboard plugin. https://review.opendev.org/c/openstack/octavia-dashboard/+/846176 | 23:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!