| opendevreview | Sam Morrison proposed openstack/horizon master: Fix instance filtering by certain attributes. https://review.opendev.org/c/openstack/horizon/+/835169 | 03:12 |
|---|---|---|
| opendevreview | Merged openstack/horizon stable/xena: Change to a proper policy for Resume operation https://review.opendev.org/c/openstack/horizon/+/831855 | 04:26 |
| opendevreview | Keigo Noha proposed openstack/horizon stable/wallaby: Change to a proper policy for Resume operation https://review.opendev.org/c/openstack/horizon/+/835132 | 05:03 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Do not assume keystone admin endpoint https://review.opendev.org/c/openstack/horizon/+/835172 | 05:29 |
| amotoki | vishalmanchanda: ^ | 05:29 |
| vishalmanchanda | amotoki: ack. | 05:42 |
| vishalmanchanda | amotoki: Don't we need to cleanup for code and remove entry where we use admin endpoint | 05:43 |
| vishalmanchanda | amotoki: For e.g. https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/base.py#L302 | 05:44 |
| vishalmanchanda | amotoki: and many other places. | 05:44 |
| amotoki | vishalmanchanda: what you pointed is a different thing. | 05:44 |
| amotoki | vishalmanchanda: this kind of aliases are still required to handle OPENSTACK_ENDPOINT_TYPE setting properly. | 05:45 |
| amotoki | vishalmanchanda: the point is that horizon should not assume 'admin' endpoint is always configured. | 05:45 |
| vishalmanchanda | amotoki: ok, I was preparing a patch where I remove references of admin endpoint in code and then fixing unit tests. | 05:46 |
| amotoki | vishalmanchanda: in keystone v3 API, there is no functional difference depending on which endpoint is used. | 05:46 |
| amotoki | vishalmanchanda: so as you can see in the keystone installation guide, all endpoints (public, admin, internal) are configured as same. | 05:47 |
| vishalmanchanda | amotoki: maybe keystone team not updated their documentation. | 05:47 |
| vishalmanchanda | amotoki: I have seen few patches in other openstack projects where they replace admin endpoint with public endpoint, so I thought we should do the same thing here. | 05:49 |
| amotoki | the min requirement is to configure one endpoint for keystone and projects should not have more assumptions. | 05:50 |
| vishalmanchanda | ok. | 05:50 |
| amotoki | keeping 'admin' endpoint may lead to confusion so devstack dropped it. | 05:50 |
| amotoki | horizon started to fail after this. this is an example. | 05:51 |
| vishalmanchanda | amotoki: So we don't need cleanup of admin endpoint reference in horizon code, just confirming with you? | 05:51 |
| amotoki | vishalmanchanda: deployers can still configure 'admin' endpoints although it is not required. I think dropping 'admin' endpoint completely is a different topic. | 05:53 |
| vishalmanchanda | amotoki: ok. thanks for quick patch. | 05:53 |
| vishalmanchanda | amotoki: let me test your patch. | 05:53 |
| vishalmanchanda | amotoki: one more question I have in my mind. | 05:55 |
| vishalmanchanda | amotoki: sorry for asking too many question:( | 05:55 |
| amotoki | vishalmanchanda: np | 05:55 |
| amotoki | vishalmanchanda: let's clarify them one by one | 05:56 |
| vishalmanchanda | Do you think we should backport your patch in stable/yoga and then a cut a new release for stable/yoga branch. | 05:56 |
| vishalmanchanda | Or let's backport it to stable/yoga for now and cut a release after 1-2 weeks. | 05:57 |
| amotoki | vishalmanchanda: we have two pending topics. the one is SYSTEM_SCOPE_SERVICES patch and the other is what we are talking about. | 05:58 |
| vishalmanchanda | yes | 05:58 |
| amotoki | vishalmanchanda: The first is not included in the latest release, so I think we need to cut a release anyway. | 05:58 |
| vishalmanchanda | amotoki: ok. | 05:58 |
| amotoki | vishalmanchanda: the second one is also really nice to have. we have a chance for another release soon so it is nice to include it too. | 05:59 |
| amotoki | vishalmanchanda: regarding my patch, I am preparing a relnote too. | 05:59 |
| vishalmanchanda | amotoki: regarding first patch, Do you want to incorporate this comment https://review.opendev.org/c/openstack/horizon/+/818763/6/openstack_dashboard/dashboards/admin/aggregates/panel.py ? | 06:02 |
| amotoki | vishalmanchanda: no. it is a kind of refactoring, so it is optional. | 06:03 |
| vishalmanchanda | amotoki: ok. | 06:03 |
| amotoki | If refactored, these logics can be moved to horizon/base.py. | 06:03 |
| vishalmanchanda | ok. | 06:05 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Do not assume keystone admin endpoint https://review.opendev.org/c/openstack/horizon/+/835172 | 11:07 |
| vishalmanchanda | rdopiera: Could you please take a look at https://review.opendev.org/c/openstack/horizon/+/835172 asap. | 11:13 |
| opendevreview | Merged openstack/horizon master: Replace remaining usage of ugettext_lazy https://review.opendev.org/c/openstack/horizon/+/834864 | 11:48 |
| opendevreview | Vishal Manchanda proposed openstack/horizon stable/yoga: Do not assume keystone admin endpoint https://review.opendev.org/c/openstack/horizon/+/835143 | 15:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!