| rdopiera | vishalmanchanda: do you remember where the release procedure for horizon is documented? | 08:59 |
|---|---|---|
| vishalmanchanda | rdopiera: I am not sure we have specific topic added in horizon documentation about the release process. | 09:09 |
| vishalmanchanda | rdopiera: we discussed few points like we should take care at the time of release like update policy rules for backend services and check open patches and merge them asap while cutting a new release of stable branches | 09:11 |
| vishalmanchanda | rdopiera: but we never document it horizon docs. | 09:11 |
| vishalmanchanda | but we can document it under https://docs.openstack.org/horizon/latest/contributor/contributing.html. | 09:13 |
| vishalmanchanda | rdopiera: what exactly you want to check, maybe I can help you? | 09:13 |
| rdopiera | vishalmanchanda: I was asked by the RBAC/policy people, when I told them that policies are updated as a part of the release process | 09:16 |
| rdopiera | and I thought I saw it written down somewhere | 09:16 |
| vishalmanchanda | rdopiera: ok, let me push a patch to add it in our documentation. | 09:18 |
| rdopiera | vishalmanchanda: awesome, thank you! | 09:18 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [doc] Add documentation about the things to do before releasing https://review.opendev.org/c/openstack/horizon/+/834641 | 10:01 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [doc] Add documentation about the things to do before releasing https://review.opendev.org/c/openstack/horizon/+/834641 | 10:21 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [doc] Add documentation about the things to do before releasing https://review.opendev.org/c/openstack/horizon/+/834641 | 11:31 |
| *** prometheanfire is now known as Guest0 | 11:48 | |
| *** ChanServ changes topic to "OpenStack Horizon | Current release priorities: https://etherpad.openstack.org/p/horizon-release-priorities | Docs: https://docs.openstack.org/horizon/latest/" | 11:52 | |
| amotoki | vishalmanchanda: rdopiera: I am testing https://review.opendev.org/c/openstack/horizon/+/818763, but I am hitting "Invalid service catalog: identity" when opening the panels under "Identity" dashboard (except app credential one). | 14:09 |
| amotoki | vishalmanchanda: rdopiera: I do not configure any setting. Afer stack.sh I pulled the patch and did the usual horizon restart process (collectstatic, compress and then restart apache). | 14:10 |
| amotoki | vishalmanchanda: rdopiera: before digging into it, I would like to ask you two first. | 14:11 |
| vishalmanchanda | amotoki: let me test it again in my env. | 14:29 |
| vishalmanchanda | amotoki: I am not hitting that issue you mentioned above. | 14:47 |
| vishalmanchanda | amotoki: tested with both apache and development runserver. | 14:48 |
| vishalmanchanda | amotoki: maybe some issue with your env. otherwise unit tests also fails. | 14:55 |
| amotoki | vishalmanchanda: okay. I will check my env. Regarding the review, I believe someone who confirms the behavior should approve it. It should not me. | 14:58 |
| vishalmanchanda | amotoki: ack. | 14:59 |
| amotoki | vishalmanchanda: I would like to avoid blind +2/W from me | 14:59 |
| vishalmanchanda | amotoki: fair enough! | 14:59 |
| amotoki | vishalmanchanda: one question. Does your env have 'admin' endpoint for 'identity'? you can check it by "openstack catalog show identity'. | 15:38 |
| vishalmanchanda | amotoki: yes. | 15:41 |
| amotoki | vishalmanchanda: hmm... the current devstack does not configure admin endpoiint for keysotne now | 15:43 |
| amotoki | vishalmanchanda: https://opendev.org/openstack/devstack/commit/65a5db8e3376fbeb6871629cbfe5d77fe848e039 dropped it. | 15:44 |
| amotoki | vishalmanchanda: does horizon still require the admin endpoint? | 15:44 |
| amotoki | vishalmanchanda: I know you added the workaround for horizon CI, but if required it sounds a big issue. | 15:45 |
| amotoki | vishalmanchanda: at least, we must document it as a know issue in the release note. | 15:46 |
| vishalmanchanda | amotoki: ok, I see. | 15:47 |
| vishalmanchanda | amotoki: my devstack env. is old | 15:47 |
| amotoki | so it means horizon does not work the devstack with default configurations | 15:48 |
| vishalmanchanda | amotoki: maybe that's why I am not hitting "Invalid service catalog: identity" issue under identity panel | 15:48 |
| amotoki | vishalmanchanda: i confirmed it is not specific to rdopiera's system-scope patch. it always happens | 15:48 |
| vishalmanchanda | amotoki: 😞( | 15:49 |
| vishalmanchanda | amotoki: This patch https://review.opendev.org/c/openstack/devstack/+/789094 is merged long time back why we hit this issue now. | 15:51 |
| amotoki | vishalmanchanda: https://bugs.launchpad.net/horizon/+bug/1950659 | 15:52 |
| vishalmanchanda | amotoki: I am also preparing a new devstack env. to investigate this issue. | 15:52 |
| amotoki | vishalmanchanda: you added an extra configuration in horizon CI https://opendev.org/openstack/horizon/commit/f9bab3fe195eb13635aa70cb910d94df98d66cf3 | 15:52 |
| vishalmanchanda | amotoki: but all panel works for me under Identity dashboard. | 15:53 |
| amotoki | vishalmanchanda: does it work without 'admin' endpoint? | 15:53 |
| vishalmanchanda | amotoki: you mean i should delete admin endpoint and then check? | 15:54 |
| vishalmanchanda | amotoki: in my current devstack env. | 15:55 |
| amotoki | vishalmanchanda: what I can say at least is that other projects do not assume 'admin' endpoint for identity is configured. | 15:55 |
| amotoki | vishalmanchanda: ah, you are talking about your env. | 15:55 |
| amotoki | vishalmanchanda: yes, i think you can reproduce it by deleting admin endpoint for identity. | 15:56 |
| vishalmanchanda | vishalmanchanda: ok | 15:57 |
| vishalmanchanda | amotoki: neutron also done similar workaround https://review.opendev.org/c/openstack/neutron/+/816792 | 15:57 |
| amotoki | vishalmanchanda: IIUC it is a requiredment from not neutron but rally | 15:58 |
| vishalmanchanda | amotoki: ok. | 15:58 |
| -amotoki- will be afk soon | 16:00 | |
| vishalmanchanda | amotoki: I also hit above issue after deleting identity admin endpoint. | 16:06 |
| *** Guest0 is now known as prometheanfire | 16:33 | |
| *** tosky is now known as Guest38 | 17:04 | |
| *** tosky_ is now known as tosky | 17:04 | |
| ganso | vishalmanchanda: hi! the xena backport merged, maybe you could please +2W the wallaby one? https://review.opendev.org/c/openstack/horizon/+/829663 | 17:06 |
| vishalmanchanda | ganso: ack, I will review it soon but I can't give +2/W as I am not a stable core. | 17:08 |
| ganso | vishalmanchanda: oh I see, well rdopiera has +2'ed, Amotoki is the uploaded, a +2 from one more stable core is needed then | 17:09 |
| vishalmanchanda | ganso: In that case we have a policy in horizon that if a stable core purposed a patch in stable branches, it can be approved with single +2 by another stable core. | 17:21 |
| vishalmanchanda | rdopiera: Could you approve it once you have time. | 17:21 |
| ganso | vishalmanchanda: great! thank you! | 17:22 |
| rdopiera | vishalmanchanda: I already +2d it | 17:22 |
| rdopiera | ah, ok, misunderstood | 17:23 |
| rdopiera | approved | 17:23 |
| vishalmanchanda | rdopiera: thanks:) | 17:23 |
| ganso | rdopiera: thank you! | 17:23 |
| opendevreview | Merged openstack/horizon stable/wallaby: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829663 | 18:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!